[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #9 from Alex Buckley  ---
Created attachment 68154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68154=edit
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

The administrator also has the ability to skip the feature release tool on the
update
process and it will be displayed to the next superlibrarian user that
logs in. Because librarian staff are likely to be more familiar with the
system preference settings that a library would want to set than an IT
support administrator

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.120033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the
'Update database structure' page you are prompted to login and the main
page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1 and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. Notice there is also a skip button. Click the skip button and notice
you are redirected to the staff intranet login page.

8. Login with the Koha db administrator credentials and notice that the
Koha main page is displayed

9. Logout and enter superlibrarian user credentials and submit the login
form

10. Notice you are redirected to the Koha web installer login page

11. Login with the Koha db administrator credentials

12. Notice the feature release change tool is displayed

13. Alter the NumSavedReports and the
TalkingTechItivaPhoneNotification values and select the 'Save all
preferences' button

14. Query the values of these two sysprefs in the systempreferences
database table and notice they have been changed to what you submitted

15. Click the 'Log into Koha staff intranet' button

16. Notice the intranet login page appears

17. Login and the main page will be displayed

18. Repeat steps 1,2 and click the 'Continue to feature release tool'
button

19. Notice the feature release tool is displayed and repeat steps 13 and
14

20. Click the 'Log into Koha staff intranet' button, login as either
Koha db administrator or as a superlibrarian (it doesn't matter which
you log in as) and the Koha staff intranet mainpage will be displayed

21. Log out and then log back in again and notice the staff intranet is
still displayed. Note you are not redirected to the Koha web installer
login page to go through the feature release change tool because you
have already gone through it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68153|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68152|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68151|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #8 from Alex Buckley  ---
Created attachment 68153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68153=edit
Bug 19247 - Added ability to skip feature release tool

The administrator can now skip the feature release tool on the update
process and it will be displayed to the next superlibrarian user that
logs in. Because librarian staff are likely to be more familiar with the
system preference settings that a library would want to set than an IT
support administrator

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.120033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the
'Update database structure' page you are prompted to login and the main
page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1 and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. Notice there is also a skip button. Click the skip button and notice
you are redirected to the staff intranet login page.

8. Login with the Koha db administrator credentials and notice that the
Koha main page is displayed

9. Logout and enter superlibrarian user credentials and submit the login
form

10. Notice you are redirected to the Koha web installer login page

11. Login with the Koha db administrator credentials

12. Notice the feature release change tool is displayed

13. Alter the NumSavedReports and the
TalkingTechItivaPhoneNotification values and select the 'Save all
preferences' button

14. Query the values of these two sysprefs in the systempreferences
database table and notice they have been changed to what you submitted

15. Click the 'Log into Koha staff intranet' button

16. Notice the intranet login page appears

17. Login and the main page will be displayed

18. Repeat steps 1,2 and click the 'Continue to feature release tool'
button

19. Notice the feature release tool is displayed and repeat steps 13 and
14

20. Click the 'Log into Koha staff intranet' button, login as either
Koha db administrator or as a superlibrarian (it doesn't matter which
you log in as) and the Koha staff intranet mainpage will be displayed

21. Log out and then log back in again and notice the staff intranet is
still displayed. Note you are not redirected to the Koha web installer
login page to go through the feature release change tool because you
have already gone through it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #71 from Katrin Fischer  ---
With the patch applied the message "Not checked out." appears twice when
returning an item that has not been checked out.

QA tools also highlight some issues:

 FAIL   C4/Circulation.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope 

 FAIL   C4/Items.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK spelling
   OK valid

 FAIL   C4/Reserves.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope 

 OK C4/UsageStats.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   OK valid

 FAIL   circ/returns.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope 

 OK installer/data/mysql/sysprefs.sql
   OK git manipulation
   OK semicolon
   OK sysprefs_order

 OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/authorised_values.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   t/db_dependent/Circulation/Returns.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope 

 FAIL   t/db_dependent/Circulation/issue.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope 

 FAIL   t/db_dependent/UsageStats.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"my" variable $item masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #7 from Alex Buckley  ---
Created attachment 68152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68152=edit
Bug 19247 - Followup: QA test tool fixes

Test plan:
1. Run QA test tools and notice that all files pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #6 from Alex Buckley  ---
Created attachment 68151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68151=edit
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

Link to the release notes for the most recent installed release are also
provided by this tool.

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.1200033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the 'Update
database structure" page you are prompted to login and the main page appears if
you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1, and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. The feature release tool will be displayed. Click on the 'New Syspref
information' tab and notice that the system preferences (names,
explanations and (editable) default values) installed in the
update process are displayed

8. Change the value of TranslateNotices syspref and click the 'Save all
preferences' button

9. Refresh the page manually and click on the 'New syspref information'
tab and notice the value of the TranslateNotices syspref has been
altered

10. Click on the 'Release notes' tab and open the release note link
which is 17.05 release notes

11. Leave the feature release change tool by clicking the 'Next and
submit' button

12. You are prompted to login, after entering the correct credentials
the intranet main page is displayed

Sponsored-by: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=19247

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67889|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 68149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68149=edit
Bug 15494 - Add syspref

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #5 from Alex Buckley  ---
Created attachment 68150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68150=edit
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

Link to the release notes for the most recent installed release are also
provided by this tool.

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.1200033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the 'Update
database structure" page you are prompted to login and the main page appears if
you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1, and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. The feature release tool will be displayed. Click on the 'New Syspref
information' tab and notice that the system preferences (names,
explanations and (editable) default values) installed in the
update process are displayed

8. Change the value of TranslateNotices syspref and click the 'Save all
preferences' button

9. Refresh the page manually and click on the 'New syspref information'
tab and notice the value of the TranslateNotices syspref has been
altered

10. Click on the 'Release notes' tab and open the release note link
which is 17.05 release notes

11. Leave the feature release change tool by clicking the 'Next and
submit' button

12. You are prompted to login, after entering the correct credentials
the intranet main page is displayed

Sponsored-by: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=19247

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67887|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 68147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68147=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67888|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 68148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68148=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67886|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 68146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68146=edit
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Katrin Fischer  ---
This seems to work quite well! Also tested renew through checkout, renewal tab
and OPAC.

When renewing the item from the list of checkouts and using the renewal limit
override functionality, the message displayed is:

Renew failed: item_denied_renewal

This could be improved, maybe with a small follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Katrin Fischer  ---
When trying to suspend a hold from the holds list in staff, there is an
internal server error that translates to:

Can't call method "ymd" on an undefined value at
/home/vagrant/kohaclone/Koha/Hold.pm line 65.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

--- Comment #26 from Katrin Fischer  ---
Can you take another look at my last comment and meaning of 0 please?

I retested and after installing the patch the daily column is empty. Later it's
not possible to safe it empty, as empty jumps to 0. It doesn't feel quite
right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Katrin Fischer  ---
The patch appears to break the list of checkouts in the patron account:

Error: Syntax error, unrecognized expression: ##issues-table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

Summary|ability to download items   |Ability to download items
   |lost report |lost report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19467] New: Display location and itemtype description on lost items report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19467

Bug ID: 19467
   Summary: Display location and itemtype description on lost
items report
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The lost items report displays the location and itemtype codes instead of the
descriptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19467
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19467] Display location and itemtype description on lost items report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19467

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9573

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18805] Add ability to use up account credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
This is at the bottom of a rather long dependency tree where most of the items
are not yet pushed to master:

18805: Add ability to use up account credits 

depends on:

2696: Fine Payments Should Show What Was Paid For 
18790: Add ability to void payments 
18786: Add ability to create custom payment types 
14826: Resurrect account offsets table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Katrin Fischer  ---
Tested on master:

1) Create a suggestion in OPAC
2) Accept the suggestion in staff
3) Add order from this suggestion
4) Go to cataloguing search and search for the record and another
5) Merge the suggestion record with the catalog record - catalog record wins
(should be the more common case when a patron suggests something that already
exists)
6) Verify that after merging, the new title displays in the acquisition record
7) Verify that the suggestion info no longer displays in basket
8) Verify that the new title doesn't display in suggestions. The old title will
still show as suggested (not updated)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67042|0   |1
is obsolete||

--- Comment #53 from Katrin Fischer  ---
Created attachment 68141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68141=edit
Bug 17492: Followup - adapt the code to current master

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67867|0   |1
is obsolete||

--- Comment #56 from Katrin Fischer  ---
Created attachment 68144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68144=edit
Bug 17492: (followup) Added missing tests

This patch only adds a missing condition to test defined age in
is_category_valid method. The other task of this patch is to add missing
automated db-dependent tests.

Test plan:
1) Apply patch
2) Create a patron and assign him a category having age limits set
3) Change patron's age to be older/younger than category's limits
4) At "Check out" and "Details" tabs you should see a warning with a
button allowing to change the category, eg.:
 - http://prntscr.com/cz7ch3
 - http://prntscr.com/cz7em4
 - http://prntscr.com/cz7dj1
5) Set a valid category according to patron's age
6) Warning should disappear
7) Perform similar test again, but instead of changing the age change
the limits of a category
8) During tests verify "Change category" button everytime opens "Modify
patron" page:
  http://prntscr.com/cz7g5q
9) Ensure that left-side panel is always on its expected place
10) Remove patron's date of birth and test that all categories are
allowed now
11) Run automated tests: prove t/db_dependent/Koha/Patron.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67851|0   |1
is obsolete||

--- Comment #55 from Katrin Fischer  ---
Created attachment 68143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68143=edit
Bug 17492: (followup) Logic moved to Koha namespace

Test plan:
1) Apply patch
2) Create a patron and assign him a category having age limits set
3) Change patron's age to be older/younger than category's limits
4) At "Check out" and "Details" tabs you should see a warning with a
button allowing to change the category, eg.:
 - http://prntscr.com/cz7ch3
 - http://prntscr.com/cz7em4
 - http://prntscr.com/cz7dj1
5) Set a valid category according to patron's age
6) Warning should disappear
7) Perform similar test again, but instead of changing the age change
the limits of a category
8) During tests verify "Change category" button everytime opens "Modify
patron" page:
  http://prntscr.com/cz7g5q
9) Ensure that left-side panel is always on its expected place

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67868|0   |1
is obsolete||

--- Comment #57 from Katrin Fischer  ---
Created attachment 68145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68145=edit
Bug 17509: Removed invalid patterns

This patch only removes invalid gender-specific patterns from messages
in automated tests.

https://bugs.koha-community.org/show_bug.cgi?id=17492

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67850|0   |1
is obsolete||

--- Comment #54 from Katrin Fischer  ---
Created attachment 68142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68142=edit
Bug 17492: (followup) Fixed broken layout of the patron detail page

Test plan:
1) apply this patch
2) open eg. /cgi-bin/koha/members/moremember.pl?borrowernumber=3
3) tabbed menu (checkout, details, fines, etc.) should be displayed on
the left side of the page not at the bottom

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67041|0   |1
is obsolete||

--- Comment #52 from Katrin Fischer  ---
Created attachment 68140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68140=edit
Bug 17492: Followup - use bootstrap 3 button classes

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67040|0   |1
is obsolete||

--- Comment #51 from Katrin Fischer  ---
Created attachment 68139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68139=edit
Bug 17492: Add a warning about age being of-limits and a button to update it

This patch adds a warning if a patron's age is out of limits if an assigned
category.
It also adds a button allowing to change the category.

Test plan:
1) Apply patch
2) Create a patron and assign him a category having age limits set
3) Change patron's age to be older/younger than category's limits
4) At "Check out" and "Details" tabs you should see a warning with a
button allowing to change the category, eg.:
 - http://prntscr.com/cz7ch3
 - http://prntscr.com/cz7em4
 - http://prntscr.com/cz7dj1
5) Set a valid category according to patron's age
6) Warning should disappear
7) Perform similar test again, but instead of changing the age change
the limits of a category
8) During tests verify "Change category" button everytime opens "Modify
patron" page:
  http://prntscr.com/cz7g5q

Tested all 4 patches together, works as expected
Signed-off-by: Marc Véron 

Bug 17492: Removed a line setting 'flagged' template parameter by mistake

Signed-off-by: Marc Véron 

Bug 17492: Fixed URL generation of "Change category" button

Signed-off-by: Marc Véron 

Bug 17492: Fixed forbidden patterns

Signed-off-by: Marc Véron 

Bug 17492: Removed extra IFs

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #22 from Katrin Fischer  ---
Hi Aleisha,

I am sorry, but I am still having the same troubles:

- No feedback on pushing the button
- Errors in the logs for patron card creator:

Can't use string ("-2") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/svc/creator_batches line 65.
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed
[for Statement "INSERT INTO creator_batches (batch_id, description,
item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
/home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind
variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm
line 73.

and label creator, when trying to add an item to a batch:

WARNING: An error was encountered and item(s) not added to batch 1. Please have
your system administrator check the error log for details. 

Using kohadevbox, freshly reset database on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #28 from Katrin Fischer  ---
Made a tiny follow-up - 'pending' seems more common in Koha and is what we show
the patron in the OPAC.

Josef filed bug 19456 for the problem with the title tag.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67808|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 68133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68133=edit
Bug 14919: Add test for Koha::Patron->old_holds subroutine

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #27 from Katrin Fischer  ---
Created attachment 68138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68138=edit
Bug 14919 (follow-up)  Changed status from 'in queue' to 'pending'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67988|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 68137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68137=edit
Bug 14919: (followup) Show accurate status in holds history

This patch fixes the status showed in holds history table.

The determination of status is following:

1. "hold.found is 'F'" - Fullfilled - the hold was fullfilled by checking the
item to patron. If hold reaches this state, it can't changed status
anymore, or be cancelled, that's why this goes first

2. "hold.cancellationdate is filled" - When the hold is cancelled, its
eventually waiting or in transit status remains the same, only
cancellation dat is filled, so this has to go second

3. "hold.found is 'W'" - Hold is waiting

4. "hold.found is 'T'" - Hold is in transit to target library

Test plan:
0) Apply the patch
2) Read the status determination note in this commit message and confirm
it makes sense
1) Have patron/patrons with at least one hold in every status
2) Go to holds history page and confirm it show the right status
3) Try to break the status determination ;)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67818|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 68136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68136=edit
Bug 14919: (follow-up) Fixing some typos and adding to pref description

- Adds 'holds' to pref description of intranetreadinghistory
- Fixes typo in link to holds history from patron account
- Changes reserve date to hold date in table heading

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67810|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 68135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68135=edit
Bug 14919: Add holds history for patron

Test plan:
0) Have a patron with some current and old reserves
1) Go to patron circulation page
2) Notice, there is new item called "Holds history" in the left
circulation menu
3) Go to this page and confirm the data on this page are OK, and that
ui does behave as expected
4) Go to adminitration, columns setting, try to change the setting for
holdshistory table and confirm it is taken into account on holds history
page

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67809|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 68134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68134=edit
Bug 14919: Add Koha::Patron->old_holds subroutine

Test plan:
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #23 from Katrin Fischer  ---
Hi David, thx for the updated test plan. I reset my system since and I could
see the bug and confirm the fix now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67102|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 68132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68132=edit
Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #36 from Katrin Fischer  ---
Sequence of attached patches is wrong, but works when you apply them in order
:)

I have started testing by regression testing the bibliographic frameworks
export and import and for the default framework some things seem not quite
right:

- When exporting the default framework to Excel format the file ending changed
from xml to ods for bibliographic frameworks
- Reimporting the exported file for Default always results in unspecific error
message.
- QA might ask for tests for the changes to ImportExportFramework.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from Katrin Fischer  ---
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11976 - Show publication date instead of received date
Applying: Bug 11976 - Display either or both publication date and receival date
error: sha1 information is lacking or useless
(installer/data/mysql/sysprefs.sql).
error: could not build fake ancestor
Patch failed at 0001 Bug 11976 - Display either or both publication date and
receival date
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-11976---Display-either-or-both-publication-dat-6GeGs3.patch

Some things in the second patch don't look quite right - it seems to contain
some changes that don't belong to the patch (drop lines for tables, delete for
the pref).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #20 from Katrin Fischer  ---
Comment on attachment 67165
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67165
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

Review of attachment 67165:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11300=67165)
-

Hi Bouzid,

noted some thing in the splinter review. Additionally:

- atomicupdate for adding the system preference is missing
- You will have to add tests for the new module to pass QA
- QA tools show some fails:

 OK C4/Biblio.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   OK valid

 FAIL   C4/Linker/Z3950Server.pm
   FAIL   critic
Found use of Switch. This module is deprecated by the Perl 5
Porters at line 223, column 5. Find an alternative module.
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for flip_heading
POD is missing for getZ3950Authority
POD is missing for get_link
POD is missing for update_cache
   OK spelling
   OK valid

 OK cataloguing/automatic_linker.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

 FAIL   installer/data/mysql/sysprefs.sql
   OK git manipulation
   OK semicolon
   FAIL   sysprefs_order
Not blocker: Sysprefs AdditionalFieldsInZ3950ResultSearch is
bad placed (see bug 10610)

- I've tried to configure and test the feature, but see an alert with an
internal server error. Plack error logs show:

CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_cataloguing_automatic_linker_2epl
line 65, this can lead to vulnerabilities. See the warning in "Fetching the
value or values of a single named parameter" at /usr/share/perl5/CGI.pm line
436.
Personal-name,do-not-truncate,ext="K�rger, Walter Christian"
ZOOM error 114 "Unsupported Use attribute" (addinfo: "Personal-name") from
diag-set 'Bib-1' at /home/vagrant/kohaclone/C4/Linker/Z3950Server.pm line 260.
Can't locate object method "get_link" via package "C4::Linker::Default"
(perhaps you forgot to load "C4::Linker::Default"?) at
/home/vagrant/kohaclone/C4/Biblio.pm line 533.

::: C4/Linker/Z3950Server.pm
@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

Please use Modern::Perl instead!

::: installer/data/mysql/sysprefs.sql
@@ +8,5 @@
>  ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create 
> a duplicate invoice','YesNo'),
>  ('AddressFormat','us','us|de|fr','Choose format to display postal 
> addresses', 'Choice'),
> +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC 
> field/subfields are displayed in -Additional field- column in the result of a 
> search Z3950', 'Free'),
> +('AddPatronLists','categorycode','categorycode|category_type','Allow user to 
> choose what list to pick up from when adding patrons','Choice'),
> +('AddressFormat','us','','Choose format to display postal addresses', 
> 'Choice'),

I think there is a merge error here - the new pref (LinkerZ3950Server) is
missing and others are doubled up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] [16.11.x] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

--- Comment #9 from Katrin Fischer  ---
Assuming that this is for 16.11.x only?

This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #48 from Katrin Fischer  ---
Follow-up has been pushed to 16.11.x and will be in 16.11.13.

Thx Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19450] OverDrive integration failing on missing method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
This is critical as without the patch you can't tell what has been ordered.
Can we please get the tests requested?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #6 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #4)
> Created attachment 68084 [details] [review]
> Bug 19422: Make sure it will never happen again

This breaks packaging. From the nightly build log at
https://apt.abunchofthings.net/koha-nightly/unstable-log.txt

read_file
'/usr/share/koha/intranet/cgi-bin/installer/data/mysql/kohastructure.sql' -
sysopen: No such file or directory at t/check_kohastructure.t line 22.
# Looks like your test exited with 2 before it could output anything.
t/check_kohastructure.t . 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/1 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19437] Rearrange CancelExpiredReserves tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19437
Bug 19437 depends on bug 19260, which changed state.

Bug 19260 Summary: Reservations / holds marked as problems being seen as 
expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19437] Rearrange CancelExpiredReserves tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19437

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED

--- Comment #8 from Katrin Fischer  ---
Depends on 19260 which depends on another bug not in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #35 from Katrin Fischer  ---
Depends on bug 12063 that is not in 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #33 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
Doesn't apply cleanly to 16.11.x - please provide rebased patches if you want
this to be included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19257] Warn when reopening a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17834] Change library news text for single-branch libraries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834

--- Comment #12 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
Dependency on bug 17708 which is not in 16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19343] Private lists displayed in search results list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343

--- Comment #19 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

--- Comment #45 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/