[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

--- Comment #25 from Marcel de Rooy  ---
Created attachment 68654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68654=edit
Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t

SuggestionEngine_ExplodedTerms.t uses paths like /../.. or /.. in order
to find a template in opac-tmpl.
Sub badtemplatecheck does not like these paths.
Using Cwd::abs_path to resolve the situation (rel2abs does not).

Test plan:
Run again t/db_dependent/SuggestionEngine_ExplodedTerms.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #10 from Aleisha Amohia  ---
Created attachment 68653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68653=edit
Bug 19532: Circulation rules

Adding 3 new rules and columns to issuingrules
- recall_due_date_interval
- recall_overdue_fine
- recall_shelf_time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #12 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #7)
> No idea if the QAer will request an addition test in SIP/Patron.t or
> Message.t ;)

Either that or he might write them :-)

Excellent idea, very useful for patrons using external services.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #10 from Nick Clemens  ---
Created attachment 68651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68651=edit
Bug 18625: (QA follow-up) Simply update_lastseen

No need to check the pref.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

--- Comment #11 from Nick Clemens  ---
Created attachment 68652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68652=edit
Bug 18625: QA followup - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67953|0   |1
is obsolete||
  Attachment #67954|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 68650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68650=edit
Bug 18625: Update lastseen in patron info request

Many services use SIP patron req info to validate a patron against
the koha database. If recording lastseen sites will
also want to record that the user has accessed these
library facilities although they have not logged into koha

Signed-off-by: Marcel de Rooy 
Verified that Patron Info request (63) updates lastseen when the pref has
been enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #17 from Liz Rea  ---
Created attachment 68649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68649=edit
Bug 16782 - missing , fixed now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68639|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Created attachment 68648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68648=edit
Bug 16782 - disclose JSON URL for reports on the saved report page

It has always annoyed me that you had to look at the help to divine the url for
a report.
This patch works it out and displays it for you in a new column on the saved
reports table.

Requirements:
- OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be
complete. It's ok if they are not, but it's better if they are.
- You must have a saved report that is public to your OPAC, and one that is not
public.

To test:
- create a public saved report and a private staff report. They can be
anything.
- view the saved reports page, note that under a new heading of JSON URL the
link to the json feed for that report shows.
- copying and pasting that link into the address bar, or clicking it, should
take you to the results of the selected report.

sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68600|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Created attachment 68647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68647=edit
Bug 18816 - Make CataloguingLog work in production by preventing circulation
from spamming the log

The system preference CataloguingLog is not recommended for use in
production. This is do to the fact that every checkin and checkout
generates one or more log entires. This seems to be not only bad
behavior, but unnecessary and outside the needs of CataloguingLog as we
have CirculationLog.

Test Plan:
1) Log into staff client
2) Home -> Koha administration -> Global system preferences -> Logs
3) Set only CataloguingLog to 'Log', everything else to "Don't log"
4) Click 'Save all Logging preferences'
5) In MySQL, use your instance DB, and then type 'delete from action_logs;'
6) Have a person checkout and checkin anything.
7) In MySQL, 'select * from action_logs;'
   -- there will be data. This is the floodiness that will be removed.
8) Apply this patch
9) Repeat steps 5-7
   -- there should be no data.
10) Edit any biblio or item.
11) In MySQL, 'select * from action_logs;'
-- there should be data reflecting the changes made.
12) run koha qa test tools

NOTE: Improved clarity of test plan -- Mark Tompsett

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #62439|0   |1
is obsolete||

--- Comment #120 from Srdjan Jankovic  ---
Created attachment 68646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68646=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #9 from Aleisha Amohia  ---
Created attachment 68645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68645=edit
Bug 19532: Some module fixes

Removing files related to OldRecall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68643|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 68644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68644=edit
Bug 19532: Some DB fixes

Removing the old_recalls table, as suggested in Comment 5
Renaming 'found' column to 'status'
Adding 'old' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68643|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68642|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68642|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68643|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68642|0   |1
is obsolete||

--- Comment #7 from Aleisha Amohia  ---
Created attachment 68643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68643=edit
Bug 19532: Some DB fixes

Removing the old_recalls table, as suggested in Comment 5
Renaming 'found' column to 'status'
Adding 'old' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #6 from Aleisha Amohia  ---
Created attachment 68642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68642=edit
Bug 19532: Some DB fixes

Removing the old_recalls table, as suggested in Comment 5
Renaming 'found' column to 'status'
Adding 'old' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Liz Rea  changed:

   What|Removed |Added

Summary|Display public report URL   |Display report URL in staff
   |in staff client report  |client report interface
   |interface   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold placement needs override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||andreas.hedstrom.mace@sub.s
   ||u.se

--- Comment #2 from Andreas Hedström Mace  ---
Even after applying the patch, the itemtype dropdown remains empty when a staff
override is required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #2 from Jonathan Druart  
---
Created attachment 68641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68641=edit
Bug 19289: Use the ACQ framework to display bibliographic details

The ACQ MARC framework is only used for the ‘Item’ block.
This patch add the ability to define biblio fields (!= 995 or 952) to
customize the display of the bibliographic details when ordering.

This new feature is controlled by a new pref:
UseACQFrameworkForBiblioRecords

Test plan:
- Create a new installation to populate the ACQ framework correctly
- Set the pref UseACQFrameworkForBiblioRecords to "Use"
- Create a new order
=> You will see the lib from the ACQ framework
- Add/remove/update biblio subfields in the ACQ framework
- Create a new order
=> You should see the new subfields displayed

Note for QA: I though I would be able to refactor existing code to make
it more flexible, but it is a bit messy and lost a lot of time. I
finally decided to copy/paste the existing code. I simplified it as, I
think, we do not want the plugin, etc. like in the full biblio editor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #1 from Jonathan Druart  
---
Created attachment 68640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68640=edit
Bug 19289: Add existing fields to the ACQ framework

When ordering, the bibliographic details contain the title, author,
publisher code, publication year, isbn and series info.
To avoid regression to provide the same behaviour, we will add these
fields to the ACQ framework

NOTE: This patch makes the change only for
  - en
  - fr / unimarc complet

Other frameworks will be updated before to be pushed, to avoid
unecessary rebases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Jonathan Druart  changed:

   What|Removed |Added

Summary|Allow configuration of the  |Allow configuration of the
   |fields on the ‘Catalog  |fields on the 'Catalog
   |details’ form in the|details' form in the
   |acquisition baskets |acquisition baskets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Liz Rea  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Liz Rea  changed:

   What|Removed |Added

  Attachment #68619|0   |1
is obsolete||
  Attachment #68620|0   |1
is obsolete||
  Attachment #68621|0   |1
is obsolete||

--- Comment #15 from Liz Rea  ---
Created attachment 68639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68639=edit
Bug 16782 - disclose JSON URL for reports on the saved report page

It has always annoyed me that you had to look at the help to divine the url for
a report.
This patch works it out and displays it for you in a new column on the saved
reports table.

Requirements:
- OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be
complete. It's ok if they are not, but it's better if they are.
- You must have a saved report that is public to your OPAC, and one that is not
public.

To test:
- create a public saved report and a private staff report. They can be
anything.
- view the saved reports page, note that under a new heading of JSON URL the
link to the json feed for that report shows.
- copying and pasting that link into the address bar, or clicking it, should
take you to the results of the selected report.

sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68637|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 68638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68638=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #14 from Liz Rea  ---
Regarding showing the non-public, that's fine. I'll do a catchall followup that
does it how I want it to be done.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19535] Notice (Available) for suggestion is not send at the right time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19535

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Patrick, I am not sure how easy this would be to do, as the workflows of the
libraries are quite different here. Not every library uses a processing status
or similar. How could we trigger the change in a way that works for every
library?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #13 from Liz Rea  ---
Ha, I originally had it as a link, but decided not to in the end because it was
awkward when OPACBaseURL wasn't set. Plus you never click on it, you only ever
use it in code, so not much reason to be clickable.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19535] New: Notice (Available) for suggestion is not send at the right time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19535

Bug ID: 19535
   Summary: Notice (Available) for suggestion is not send at the
right time
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: patrick.robitai...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Koha has a notice template for notifications to be sent out to the patron once
a suggestion gets available (AVAILABLE). But the notification is send to the
patron who has made the suggestion directly when the suggestion has been
receive. This notification should be send when the status of the record item is
available.  

1) Create suggestion in OPAC;
2) Accept suggestion in Staff;
3) Order suggestion in acquisitions;
4) Close basket;
5) Receive order;
>The mail is generate for the patron who make the suggestion but the item is 
>not ready to circulate. 

It would be nice to have an email for the reception and an email to indicate
that the item is really ready to circulate, considering the status of the
document.

Regard, Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68636|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 68637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68637=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68635|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 68636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68636=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3843] Items Added in Acq Should Default to 'Ordered'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3843

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|3841|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841
[Bug 3841] Should have Default ACQ Framework
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||3841


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841
[Bug 3841] Should have Default ACQ Framework
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|3843|19289


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3843
[Bug 3843] Items Added in Acq Should Default to 'Ordered'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289
[Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in
the acquisition baskets
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

--- Comment #3 from Jonathan Druart  
---
Created attachment 68635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68635=edit
Bug 3841: Add the ACQ framework for new installations

This patch adds the acquisition frameworks (frameworkcode=ACQ) for new
installations.
It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default
framework (frameworkcode='')

Test plan:
Create a new installation and make sure the ACQ framework exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3841] Should have Default ACQ Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

--- Comment #37 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #36)
> Created attachment 68634 [details] [review]
> Bug 17829: (follow-up) Move GetMember to Koha::Patron
> 
> Do not call method on $patron if there is no other reserves

Patch pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #24 from Katrin Fischer  ---
Hi all, trying to understand this bug a bit better. Could you explain the use
case for your library a bit? What is the additional not-for-loan used for? Why
is it needed in addition to the lost setting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65002|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 68634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68634=edit
Bug 17829: (follow-up) Move GetMember to Koha::Patron

Do not call method on $patron if there is no other reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19486] When cancelling a waiting hold via circulation the patron is charged the ExpireReservesMaxPickUpDelayCharge

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19486

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
On the checkin screen, if ExpireReservesMaxPickUpDelayCharge is set, there is
an option "Forgive fees for manually expired holds".
If ticked, the patron will not be charged.

Isn't it the expected behaviour?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19534] New: Adding collection code attribute to cover image div

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19534

Bug ID: 19534
   Summary: Adding collection code attribute to cover image div
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: mich...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To further facilitate add images associated with items, add collection code
attribute ID to cover image div.

Requested by archive that wanted to have images associated with specific
collections appear next to items in search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

--- Comment #31 from Katrin Fischer  ---
Which others do you mean? Meet me on IRC :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17334] members-update.pl should show timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #18 from Kelly McElligott  ---
Could this be used when a Patron makes a purchase suggestion also?  A library
has mentioned that they would love to see the time in addition to the date on
purchase suggestions made through the OPAC?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

--- Comment #30 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #25)
> Hi Tomas,
> 
> what I meant is that the table displays dail limit = 0 for all circulation
> conditions existing pre-update. 
> If 0 means unlimited it should display as such. 
> If 0 means 0 we should fix the existing rules on update so they still work.

I'm looking at this, and it still bugs me that this is already the behaviour
for other 4 fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1971] Suggestion : Should have only one entry by title + a counter of waiting persons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1971

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to M. Tompsett from comment #10)
> (In reply to Tomás Cohen Arazi from comment #6)
> > (In reply to M. Tompsett from comment #5)
> > > For example, try a "-c=2" instead of a "-c 2". Ugliness ensues.
> > 
> > Are we supposed to support -c=2?
> 
> Not expressly. But sometimes, some scripts are that format, and sometimes
> they are not. I'm not sure which is the officially preferred way for scripts
> in general, but I thought I would mention it as a valid weakness, since for
> some strange reason I typed that instead of what was expected and documented.

I don't think we should take care of non-documented ways of passing parameters.
Either the manpage or the --help switch propose that syntax.

I don't even think we should support multiple ways of passing the parameters,
as it tends to this: confussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #23 from Jonathan Druart  
---
Suggestion 1:
Bug 11629 adds UpdateNotForLoanStatusOnCheckin and bug 14576 adds
UpdateitemLocationOnCheckin.
Both have the same behaviour: it will update the NotForLoan or Location value
of the checked in item following the rules defined in the sysprefs.
For instance: 
   NEW: FIC
   FIC: GEN
will modified the value of location to FIC if was NEW, and to GEN if was FIC.

I am not sure it makes sense for us here, but we could imagine a new pref
UpdateItemWhenLost which could be filled with:
  itemlost: 1
  notforloan: 2
which will work for any fields of the items table.

Suggestion 2:
We already have a DefaultLongOverdueLostValue, would it make sense to use it
here too?

Suggestion 3:
We add 2 other sysprefs: UpdateNotForLoanStatusWhenLost and
UpdateItemLostWhenLost (weird name)

Suggestion 4:
We display the different LOST authorised values on the "Holds awaiting pickup"
page, like it is on the "Items details" page for Lost, Damaged and Withdrawn.

Vote by text message, send 1, 2, 3 or 4 to 0424242

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #12 from Katrin Fischer  ---
Should we show the URL for non-public too? They are automatically available
under the staff url, when set to not public.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10260] Enter a note when writing off all or pay selected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260

Barton Chittenden  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi

--- Comment #3 from Barton Chittenden  ---
*** Bug 17077 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17077] Write off all does not let you write a description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17077

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Barton Chittenden  ---


*** This bug has been marked as a duplicate of bug 10260 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

--- Comment #10 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #6)
> (In reply to M. Tompsett from comment #5)
> > For example, try a "-c=2" instead of a "-c 2". Ugliness ensues.
> 
> Are we supposed to support -c=2?

Not expressly. But sometimes, some scripts are that format, and sometimes they
are not. I'm not sure which is the officially preferred way for scripts in
general, but I thought I would mention it as a valid weakness, since for some
strange reason I typed that instead of what was expected and documented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #8 from Jonathan Druart  
---
Created attachment 68633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68633=edit
Bug 19444: Do not auto renew if patron is expired and
BlockExpiredPatronOpacActions is set

If the patron's account has expired and BlockExpiredPatronOpacActions is set,
we expect auto renewal to be rejected.

Test plan:
Use the automatic_renewals.pl cronjob script to auto renew a checkout

Before this patch, if the patron's account has expired the auto renew was done.
With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions
is not set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #23 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #20)
> Created attachment 68303 [details] [review]
> Bug 16486: [FOLLOW-UP] Putting time in date column
> 
> In reply to Comment 6, I have moved the time into a column separate from
> the description. Unfortunately the timestamp has the date and the time,
> so I figured it was easier to just have them in the same column and
> replace the original date column.

I think the date column has different info than the timestamp and shouldn't be
replaced for all instances - for things like lost fees or account fees date is
when it was created - if a partial payment is applied that updates timestamp
but not date

We should probably have both columns available, or show both info:

Original date:
2017-07-07
Updated:
2017-10-21 12:12:38

or

2017-10-21 12:12:38 (2017-07-07)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68630|0   |1
is obsolete||

--- Comment #18 from M. Tompsett  ---
Created attachment 68632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68632=edit
Bug 11976: Counter patch using Column Settings

As per Nick Clemen's suggestion from comment #6,
system preferences may not be the best way.

Using Home->Administration->Column Settings->OPAC->subscriptionst
the fields visibility can be toggled.

TEST PLAN
-
1) Have a subscription where you have received at least once.
2) Look for it in OPAC and note the date is the received date, not the
publication date
3) Apply patch
4) Log in to staff client
5) Home->Administration->Column Settings->OPAC->subscriptionst
6) Set visibility as desired.
7) Refresh OPAC page
   -- everything should be as expected.
8) run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be to the patron 's detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be to the patron 's detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68568|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 68631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68631=edit
Bug 19531: When saving patron record do not redirect to circ if not authorised

If the logged in patron does not have the necessary permission we should
not redirect to circulation.pl but moremember.pl instead

Test plan:
With the borrowers permission, you should be able to edit a patron and
be redirect to the moremember page

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

--- Comment #10 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #8)
> sub build_patron_attributes_string
> 
> Could you please add a small test in t/db_dependent/SIP for this new
> subroutine? Thanks.

Good idea. I've added them to the initial patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #17 from M. Tompsett  ---
Created attachment 68630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68630=edit
Bug 11976: Failing counter patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #22 from Nick Clemens  ---
Created attachment 68624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68624=edit
Bug 17467: (followup) Make koha-zebra handle legacy script names

This patch adds the new koha-zebra script the ability to handle being
called by other script names, for backwards compatibility with the legacy
koha-*-zebra scripts.

It is intended to be used in conjunction with a patch that replaces the old
koha-*-zebra scripts for symbolic links, pointing to the new koha-zebra script.

To test:
- Apply this patch
- Create symbolic links to the new script:
  vagrant@kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra
koha-start-zebra
  vagrant@kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra
koha-stop-zebra
  vagrant@kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra
koha-restart-zebra
- Run:
  $ sudo ./koha-start-zebra kohadev
=> SUCCESS: Same behaviour than the koha-start-zebra script
- Run:
  sudo ./koha-stop-zebra kohadev
=> SUCCESS: Same behaviour than the koha-stop-zebra script
- Run:
  sudo ./koha-restart-zebra kohadev
=> SUCCESS: Same behaviour than the koha-restart-zebra script

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #27 from Nick Clemens  ---
Created attachment 68629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68629=edit
Bug 17467: Restart failing, missing instance parameter

This follow up should make it work. Perhaps there is a more
elegant way, but wanted to generate something that works.

Before this patch, the --restart stops Zebra, but does not
restart it. After, it does restart.

Before this patch, the --status gives nasty long help.
After this patch, reasonable output.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #25 from Nick Clemens  ---
Created attachment 68627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68627=edit
Bug 17467: Add tab-completion for koha-zebra

This patch adds tab-completion for bash, for the koha-zebra script.

To test:
- Run (on the vagrant user):
  $ source kohaclone/debian/koha-common.bash-completion
- Run:
  $ sudo koha-zebra -
  ( means press the tab key)
=> SUCCESS: Tab completion works as expected for the koha-zebra command.
- Sign off :-D

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #24 from Nick Clemens  ---
Created attachment 68626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68626=edit
Bug 17467: (followup) Make the install script install koha-zebra

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66420|0   |1
is obsolete||
  Attachment #66421|0   |1
is obsolete||
  Attachment #66422|0   |1
is obsolete||
  Attachment #66423|0   |1
is obsolete||
  Attachment #66424|0   |1
is obsolete||
  Attachment #66425|0   |1
is obsolete||
  Attachment #66426|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 68623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68623=edit
Bug 17467: Add koha-zebra script to handle Zebra daemons

This script is intended to replace the following currently used scripts
on packages setups:
- koha-start-zebra
- koha-stop-zebra
- koha-restart-zebra

It also introduces a --status option switch, for asking for daemon statuses

To test

- Apply the patch
- Run:
  $ sudo debian/scripts/koha-zebra --start kohadev
=> SUCCESS: same behaviour than koha-start-zebra kohadev
- Run:
  $ sudo debian/scripts/koha-zebra --stop kohadev
=> SUCCESS: same behaviour as koha-stop-zebra kohadev
- Run:
  $ sudo debian/scripts/koha-zebra --restart kohadev
=> SUCCESS: same behaviour than koha-restart-zebra kohadev
- Run:
  $ sudo debian/scripts/koha-zebra --status kohadev
=> SUCCESS: It correctly shows the status for the running (or not) process

Play with different combinations of this commands

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #26 from Nick Clemens  ---
Created attachment 68628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68628=edit
Bug 17467: Add missing --status switch handling

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #23 from Nick Clemens  ---
Created attachment 68625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68625=edit
Bug 17467: Add koha-zebra documentation

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60063|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 68622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68622=edit
Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2
fields

Some libraries need to be able to send additional patron data from the
extended patron attributes in made up SIP2 fields for the patron
information and patron status responses.

Test Plan:
1) Apply this patch
2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3.
   Make a least one repeatable.
3) Create a patron, add those attibutes for the patron, make sure there
   are at least two instances of the repeatable code
4) Edit your SIP2 config file, add the following within the login stanza:
   
   
   
5) Using the sip cli emulator, run patron_information and
   patron_status_request messages for the patron
6) Note the values you set for the patron attributes are sent in the
   corrosponding fields!

Signed-off-by: Kyle M Hall 
Signed-off-by: Daniel Mauchley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #11 from Nick Clemens  ---
Display was a bit long, took the liberty of using a link instead of the URL,
hope that's okay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #9 from Nick Clemens  ---
Created attachment 68620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68620=edit
Bug 16782: Fix spelling of 'Available'

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68446|0   |1
is obsolete||
  Attachment #68447|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 68619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68619=edit
Bug 16782 - disclose URL for public reports on the saved report page

It has always annoyed me that you had to look at the help to divine the url for
a public report.
This patch works it out and displays it for you.

Requirements:
- OPACBaseURL must be set for the url to be complete. It's ok if it's not, but
it's better if it is.
- You must have a saved report that is public to your OPAC.

To test:
- create a public saved report. It can be anything.
- view the saved reports page, note that under Public it says: Avaliable at
(opacbaseurl)/cgi-bin/koha/svc/report?id=1
- copying and pasting that into the address bar should take you to the public
results of your report.

sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display public report URL in staff client report interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #10 from Nick Clemens  ---
Created attachment 68621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68621=edit
Bug 16782: QA Followup - use a link instead of showing full URL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68118|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 68617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68617=edit
Bug 19462: Add a koha-elasticsearch command

This patch adds a new command to be used for Elasticsearch-related
tasks.

The current implementation only offers the --rebuild action switch,
that allows reindexing Elasticsearch on a per-instance basis as we are
used to with the rest of the koha-* commands.

Other options could be added in a future: --status (ES server status
report, etc).

To test:
- Apply the whole patchset
- Have a suitable Koha+Elasticsearch setup [1]
- Run:
  $ reset_all
- Run:
  $ man koha-elasticsearch
=> SUCCESS: A pretty man page is displayed covering all options
- Run:
  $ sudo koha-elasticsearch blah
=> SUCCESS: The script fails because blah is not a valid instance name
- Run:
  $ sudo koha-elasticsearch -v kohadev
=> SUCCESS: Reindex happens!
- Try the -a, -b and -c option switches
- Sign off happily :-D

Sponsored-by: ByWater Solutions

[1] This is straightforward if you are using KohaDevBox and created the
box using: $ KOHA_ELASTICSEARCH=1 vagrant up

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

--- Comment #9 from Nick Clemens  ---
More options can be added in the future, but this will ease testing and is a
great start

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68119|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 68618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68618=edit
Bug 19462: Add koha-elasticsearch documentation

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #16 from M. Tompsett  ---
I'm torn whether to sign this off or not. I think Nick may have a reasonable
suggestion for a counter-patch: CSS related.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #24 from Nick Clemens  ---
This looks good overall, everything seems to work fine, one test breakage:

vagrant@kohadevbox:kohaclone(BUGFUN)$ prove -v
t/db_dependent/SuggestionEngine_ExplodedTerms.t
t/db_dependent/SuggestionEngine_ExplodedTerms.t .. 
ok 1 - use Koha::SuggestionEngine;
ok 2 - Created suggestion engine
bad template path# Tests were run but no plan was declared and done_testing()
was not seen.
# Looks like your test exited with 255 just after 2.
Dubious, test returned 255 (wstat 65280, 0xff00)
All 2 subtests passed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #13 from Victor Grousset/tuxayo  ---
Created attachment 68616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68616=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #68538|0   |1
is obsolete||

--- Comment #12 from Victor Grousset/tuxayo  ---
Created attachment 68615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68615=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #11 from Victor Grousset/tuxayo  ---
Created attachment 68614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68614=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #68526|0   |1
is obsolete||
  Attachment #68537|0   |1
is obsolete||

--- Comment #9 from Victor Grousset/tuxayo  ---
Created attachment 68612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68612=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #68527|0   |1
is obsolete||

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 68613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68613=edit
Bug 19522: Coding style: Fix alignement after previous patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #15 from M. Tompsett  ---
Created attachment 68611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68611=edit
Bug 11976: Rename things for clarity

"Receival Date" is not what is used on the full history
picture attached to this bug.

Additionally, OPACSerialDisplayDate is better than
OPACSerialDisplayPublicationDate.  As the former clarifies
that it could be more or less than Publication Date that
is displayed.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/