[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #13 from M. Tompsett  ---
Please do not do whitespace changes in patches unless necessary for individual
changed lines. White space patches should be separated. Otherwise, it makes
eyeballing the bug more difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68857|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 68876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68876=edit
Bug 19551 - Fix wrong order of operations in cash register report

To test:
1 - Find or create a fine for a patron
2 - Write it off
3 - Home -> Reports -> Cash register
4 - Fill in current date and transaction type 'Write off'
5 - Click Submit
-- see your write off
6 - Fill in previous dates and transaction type 'Write off'
7 - Click Submit
-- see your write off (bad)
8 - Apply patch
9 - Rerun steps 3-7
-- write only visible for current date.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68865|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 68875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68875=edit
Bug 19554: The inventory table should jump to detail instead of MARCdetail

This patch just replaces the link to detail.
Detail provides item information needed in case of inventory problems.

Test plan:
Go to Tools/Inventory.
Create an inventory list without barcode file.
Check if the link goes to detail now.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19558] New: Link 130 uniform title authority record to 240 tag

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19558

Bug ID: 19558
   Summary: Link 130 uniform title authority record to 240 tag
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jb...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Uniform titles will link only to 130, 630, 730, and 830 tags. 240 tags are
uniform title tags and should also be linked.

In addition, the auto create function should but does not create a 130 uniform
title authority from a 240 bibliographic entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19557] Saved Filters from Advanced Search in OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19557

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19557] Saved Filters from Advanced Search in OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19557

Jessie Zairo  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19557] New: Saved Filters from Advanced Search in OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19557

Bug ID: 19557
   Summary: Saved Filters from Advanced Search in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If a patron performs an advanced search on the OPAC, the filters (that they
selected on the advanced search page) will not save if the patron searches then
edits the search box on the results page. 

Steps 

1) Click on the advanced search link 
2) Search for keyword or title in your collection 
3) Your brief results page populates
4) This will give you a breadcrumb trail of your advanced search (RESULTS OF
SEARCH FOR 'KW,WRDL: FLORIDA NOT KW,WRDL: TRAVEL'
5) select a facet on the left to filter your results
6) now search in the search box on cgi-bin/koha/opac-search.pl

While Koha treats this as a new search, it would be great to have an option for
the patron to modify that original advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #167 from Magnus Enger  ---
As far as I can see, these are the remaining problems pointed to by the qa
script, that can actually be fixed:

 FAIL   Koha/Exceptions/Ill.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK spelling
   OK valid

I think Tomas introduced this in a followup. He can probably add a little bit
of POD to it. 

 FAIL   Koha/Illrequestattributes.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for 'object_class'
   OK spelling
   OK valid

 FAIL   Koha/Illrequests.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for 'object_class'
   OK spelling
   OK valid

These two files do have some subs that are missing POD. I can look at that
again tomorrow. 

 FAIL   installer/data/mysql/atomicupdate/ill_tables.sql
   FAIL   git manipulation
The file has been added and deleted in the same patchset

Not sure how we can fix this without redoing completely the patches from Alex? 

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   FAIL   tt_valid
lines 665
   FAIL   valid_template
: not found

The codes mixes TT directives and HTML rather intimately: 

665   

Not sure how we can do it differently, though?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #166 from Tomás Cohen Arazi  ---
Created attachment 68874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68874=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an
exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warning.

TODO: Should add a noticeable warning on the UI, or a tooltip on the button.
TODO: add a couple tests for the exception

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

3/ I know it doesn't look right, but am not sure how to display. This is the
usual empty
datatable display we have everywhere in Koha.

2/ We could fix it with a proper IDE, I use Komodo and refactoring code is
pretty straigh-forward.
Worth a separate bug report.

1/ That TODO is misleading. It refers to their own migration from a different
design. I checked this
code and cannot find occurences of ->status with that annotation. I think this
relates to backends code.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19496] Patron notes about item does not get emailed as indicated

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] 5 digit, "Borrower Number" from details page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68868|0   |1
is obsolete||

--- Comment #375 from Tomás Cohen Arazi  ---
Created attachment 68872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68872=edit
Bug 7143: Make about.pl knows about the new epoch column

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68869|0   |1
is obsolete||

--- Comment #376 from Tomás Cohen Arazi  ---
Created attachment 68873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68873=edit
Bug 7143: Update 'Koha development team' list

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68867|0   |1
is obsolete||

--- Comment #374 from Tomás Cohen Arazi  ---
Created attachment 68871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68871=edit
Bug 7143: Add missing entries

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68866|0   |1
is obsolete||

--- Comment #373 from Tomás Cohen Arazi  ---
Created attachment 68870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68870=edit
Bug 7143: Add a new "Epoch" column to the history.txt

To allow sort easily. It also fix a few typo and remove 1 duplicated line

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19545] Make possible to turn off (and on) sending payment receipts by email

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19545

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #28 from Marjorie Barry-Vila  ---
Still valid in 16.11.

Anyone works on this?

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19555] Some changes to records are not reflected in OAI-PMH

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
(In reply to Magnus Enger from comment #0)
> The solution that comes to my mind first is to:
> - add a timestamp to the biblio_metadata table, and
> - consider both biblioitems.timestamp and biblio_metadata.timestamp when
> OAI-PMH decides what records to return
> 
> Opinions?

We need to make sure any change on the record (even to non-mapped fields, which
is my bet here) updates the timestamp.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #5 from M. Tompsett  ---
This problem does exist if you manually install yourself. You will have to do
the move, because the problem does not exist on the kohadevbox, and I don't
know why a fresh git install manually done following the wiki instructions
using mariadb-server and mariadb-client does not have a debian.cnf file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #371 from Jonathan Druart  
---
Created attachment 68868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68868=edit
Bug 7143: Make about.pl knows about the new epoch column

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #372 from Jonathan Druart  
---
Created attachment 68869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68869=edit
Bug 7143: Update 'Koha development team' list

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #369 from Jonathan Druart  
---
Created attachment 68866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68866=edit
Bug 7143: Add a new "Epoch" column to the history.txt

To allow sort easily. It also fix a few typo and remove 1 duplicated line

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #370 from Jonathan Druart  
---
Created attachment 68867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68867=edit
Bug 7143: Add missing entries

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19556] New: Added Content ISBN Does Not Match MARC 020

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556

Bug ID: 19556
   Summary: Added Content ISBN Does Not Match MARC 020
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jyo...@esilibrary.com
QA Contact: testo...@bugs.koha-community.org

This came to my attention with Novelist Select, but it does not appear to only
relate to that.

Here's what I'm seeing:

Issue 1:
A MARC record shows the 020 $a as "9780345813602 (hardcover) :" (minus quotes).
The Novelist Select section of detail shows as blank.

Novelist support reports seeing that they're getting a 9-digit ISBN 034581360.

When I inspect the Novelist Select section, Koha appears to be passing
034581360X.



https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15772 mentions that
Novelist can't interpret 10-digit ISBNs ending in X and this seems to be
consistent with that.


Issue 2 (less problematic from a patron perspective):
A MARC record shows the 020 $a as "9781408810552" (minus quotes). The Novelist
Select section shows the expected results.

Novelist support reports getting ISBN 1408810557 This is a valid ISBN for the
title, but not the one on the record.

When I inspect the Novelist Select section of the details page, Koha appears to
be passing 1408810557.




In both cases above, ISBNs used for Novelist Select are the same as used for 
gbs-thumbnail-preview, however the cover image is returned in both cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19555] New: Some changes to records are not reflected in OAI-PMH

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Bug ID: 19555
   Summary: Some changes to records are not reflected in OAI-PMH
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

The OAI-PMH server can take "from" and "until" dates, in which case it should
return records that were added or changed in the given date range:

/koha/oai.pl?verb=ListRecords=marcxchange=2017-10-26=2017-10-28

In current master, Koha uses biblioitems.timestamp to figure out which records
should be returned for a given timeframe: 
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/OAI/Server/ListBase.pm;h=0c7c56a13d7fcc977e5de5ff471059c9e32d7cfb;hb=HEAD#l63

This worked fine when the marcxml column was still in the biblioitems table.
Any change to the record would update the timestamp and it would be reflected
in OAI-PMH. 

But then we yanked marcxml out of the biblioitems table, and moved it to
biblio_metadata.metadata. This means that biblioitems.timestamp only gets
updated when one of the MARC-fields that has its own column in biblioitems gets
updated. And this means that some changes are not reflected in OAI-PMH. 

To verify: 
- Open a record for editing in Koha
- Look at the row in biblioitems that corresponds to the record
- Change e.g. one of the subjects -> the timestamp is not updated
- Change e.g. the ISBN -> the timestamp IS updated

The solution that comes to my mind first is to:
- add a timestamp to the biblio_metadata table, and
- consider both biblioitems.timestamp and biblio_metadata.timestamp when
OAI-PMH decides what records to return

Opinions?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Jason Palmer  changed:

   What|Removed |Added

 CC||jpal...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

--- Comment #1 from Marcel de Rooy  ---
Created attachment 68865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68865=edit
Bug 19554: The inventory table should jump to detail instead of MARCdetail

This patch just replaces the link to detail.
Detail provides item information needed in case of inventory problems.

Test plan:
Go to Tools/Inventory.
Create an inventory list without barcode file.
Check if the link goes to detail now.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #4 from M. Tompsett  ---
TEST PLAN
---
1) Fresh KohaDevBox to be thrown away later.
2) login vagrant/vagrant or vagrant ssh
3) sudo -i
4) cd /etc/mysql
5) mv debian.cnf broken_debian.cnf
   -- this makes sure the link is broken
  (as is the case in long hard old school koha installs with MariaDB)
6) exit
7) cd ~/kohaclone
8) git checkout master
9) git pull
10) git checkout -b bug_19547 origin/master
11) git checkout master
12) perl ~/misc4dev/cp_debian_files.pl
13) sudo koha-create --create-db testmaster1
-- nasty error
14) sudo koha-create --request-db testmaster2
-- nasty error
14) git checkout bug_19547
15) perl ~/misc4dev/cp_debian_files.pl
16) sudo koha-create --create-db testfix1
-- should work
17) sudo koha-create --request-db testfix2
-- should work

-- Sadly, testmaster1 and testmaster2 may require manual steps to remove. That
is why I wrote "to be thrown away later."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19554] New: The inventory table should jump to detail instead of MARCdetail

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Bug ID: 19554
   Summary: The inventory table should jump to detail instead of
MARCdetail
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

The regular detail page gives me information about items and MARCdetail does
not. In most cases inventory problems are about items and not about MARC fields
in the biblio record. So I propose to just replace the link. A trivial edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 68864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68864=edit
Screenshot: ES stopped

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 68863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68863=edit
Screenshot: running ES

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 68861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68861=edit
Bug 19542: Add a check for ES configuration health

This patch adds a new statuc function to Koha::SearchEngine::ElasticSearch
which is instended to replace most of get_elasticsearch_params. This function
reads the configuration from C4::Context->config('elasticsearch') and raises
relevant exceptions when mandatory entries are missing.

Its behaviour is covered by tests.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 68862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68862=edit
Bug 19542: Add Elasticsearch information in the 'About' page

This patch adds Elasticsearch related information to the 'About' page.

The information is gathered and displayed only when the 'SearchEngine' syspref
is set to 'Elasticsearch'. It displays configured nodes, and the status:
- Running
- Not running

In case it is running, it displays the defined indices and the document count
on each.
If there are configuration problems, exceptions are catch and a convenient
warning
message is displayed.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Have ES configured in your koha-conf.xml file (by default in kohadevbox)
- Set the 'SearchEngine' syspref to 'Elasticsearch'
- Comment out pieces of the elasticsearch-specific entries (server, index_name,
  the whole elasticsearch block). Reload on each change.
=> SUCCESS: Warning messages are displayed and make sense in the context of
your changes.
> the rest of the tests require having ES running on the dev env. This can
be easily
  achieved by creating the kohadevbox using:
$ KOHA_ELASTICSEARCH=1 vagrant up
- Stop the 'elasticsearch' service:
  $ sudo service elasticsearch stop
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, and the status is 'not running'
- Start the 'elasticsearch' service:
  $ sudo service elasticsearch start
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, the status is 'running' and
created indices info is displayed, along with the document count
on each index.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19553] New: Patron page: HTML span tag visible in page title when patron has a title

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19553

Bug ID: 19553
   Summary: Patron page: HTML span tag visible in page title when
patron has a title
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 68860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68860=edit
Screenshot of the web browser

The HTML is

Koha  Patrons 

Patron details for Monsieur Abdelhak 
Aguetant(9051941236)



See also attached screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #165 from Magnus Enger  ---
Created attachment 68858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68858=edit
Bug 7317: QA followup

This fixes some of the issues reported by the QA script, but not all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm breaks opac and staff

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|critical|minor

--- Comment #5 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #4)
> (In reply to Tomás Cohen Arazi from comment #3)
> > I never managed to reproduce it. Are you sure your setup is pointing to the
> > right PERL5LIB?
> 
> Ha. If it wasn't, I really should have had so much more problems..
> And what about uncommenting a line in a library that is not used?

Just for the record:
Paths like PERL5LIB and KOHA_HOME are not the problem (verified).
It is something deeper in the install. Combination of libraries etc?

Since nobody doing a fresh install can confirm the problem, I will lower the
severity of this bug first before closing it ;)
Picking minor for my dev box..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551
[Bug 19551] Cash register report has bad erroneous results from wrong order of
operations
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Nick Clemens  changed:

   What|Removed |Added

 Depends on||6934
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934
[Bug 6934] New report Cash Register Statistics
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

--- Comment #1 from Nick Clemens  ---
Created attachment 68857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68857=edit
Bug 19551 - Fix wrong order of operations iun cash register report

To test:
1 - Find or create a fine for a patron
2 - Write it off
3 - Run the cash register report for current date, see your write off
4 - Run the cash register report for previous dates, still see your
write off
5 - Apply patch
6 - Run cash register for current date, writee off shows (good)
7 - Run cash register report for previous dates, write off does not show
(good)
8 - Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19551] New: Cash register report has bad erroneous results from wrong order of operations

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Bug ID: 19551
   Summary: Cash register report has bad erroneous results from
wrong order of operations
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

in reports/cash_register_stats.pl
$whereTType = q{ AND accounttype = 'FOR' OR accounttype = 'W' };
needs parens to combine the OR, better yet:
$whereTType = q{ AND accounttype IN ('FOR','W') };

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14399] Fix inventory.pl part two (following 12913)

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399

--- Comment #41 from Marcel de Rooy  ---
Mason: Any reason why you did not pick this one ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19065] Transaction library filter on Cash register report doesn' t work

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19065

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||n...@bywatersolutions.com
 Resolution|--- |DUPLICATE

--- Comment #3 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 18919 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18919] "Transaction Branch" select field broken in Cash register statistics

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18919

Nick Clemens  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Nick Clemens  ---
*** Bug 19065 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19550] Add links to related authorities for UNIMARC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550

--- Comment #1 from Julian Maurice  ---
Created attachment 68856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68856=edit
Bug 19550: Add links to related authorities for UNIMARC

Links exist in search results for MARC21 but not for UNIMARC.
This patch fixes that.

Test plan:
1. Create an authority with a field 550 that links to another authority
   e.g. 550 $a Foo $9 42
2. Reindex this authority
3. Search for this authority
4. See that you now have a link "Foo" to authorities/detail.pl?authid=42
   in the summary

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19550] Add links to related authorities for UNIMARC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19550] New: Add links to related authorities for UNIMARC

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550

Bug ID: 19550
   Summary: Add links to related authorities for UNIMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Links exist in search results for MARC21 but not for UNIMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

--- Comment #1 from Kyle M Hall  ---
Created attachment 68855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68855=edit
Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds
on a biblio

In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve:
1982 my $hold = Koha::Holds->search({biblionumber => $biblionumber,
borrowernumber => $borrowernumber })->next;

If a patron has multiple holds there is no way to know if we have the correct
one.

This function should be updated to take an itemnumber as well and all calls
updated.

Test Plan:
1) Apply this patch
2) Capture some holds, ensure the correct hold was caught and printed in the
notice
3) prove t/db_dependent/Reserves.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #15 from Victor Grousset/tuxayo  ---
@Caroline Cyr La Rose
I got results consistent with yours.
Thanks for raising the OPAC vs intranet issue, I didn't think of this when
first trying the test plan. And it seems that the test plan was written for the
OPAC as more details are needed for doing it in the intranet. (related the
overriding the circ rule (disabling it or ignoring it))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #63227|0   |1
is obsolete||

--- Comment #14 from Victor Grousset/tuxayo  ---
Created attachment 68854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68854=edit
Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold
policy

If in the circ rules matrix you set "On shelf holds allowed" to "If all
unavailable",
default hold policy "From home library" is ignored.

Test plan:

- Have a test user from one branch (eg Centerville)

- Set "On shelf holds allowed" to "If all unavailable" for your patron and item
  category (or everyone and everything)
- For "Default checkout, hold and return policy", set hold policy to "From home
library"
  -> make sure there is no "Default holds policy by item type" to override the
setting

- Have two items for a record.
  1. An item with home branch same as test user (eg Centerville)
  -> check this item out to somebody else
  2. an item with a different home branch (eg Fairfield)
  -> available, not checked out
- Try to place a hold for your test user. Does not work.

- Apply the patch
- Try to place a hold. Should work now.

Followed test plan, worked as intended
Signed-off-by: Alex Buckley 

Followed test plan in the intranet and OPAC, worked as intended.
With few assumptions made:
- when the hold works, should be on the item 1 (Centerville)
  item 2 is only there to trigger the bug
- the circ rules were identically setup on each branch and in "Standard rules
for all libraries"
Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19549] New: Reserve Slip prints first found hold when patron has multiple holds on a biblio

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Bug ID: 19549
   Summary: Reserve Slip prints first found hold when patron has
multiple holds on a biblio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve:
1982 my $hold = Koha::Holds->search({biblionumber => $biblionumber,
borrowernumber => $borrowernumber })->next;

If a patron has multiple holds there is no way to know if we have the correct
one.

This function should be updated to take an itemnumber as well and all calls
updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68664|0   |1
is obsolete||

--- Comment #51 from Alex Arnaud  ---
Created attachment 68853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68853=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68663|0   |1
is obsolete||

--- Comment #50 from Alex Arnaud  ---
Created attachment 68852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68852=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19548] New: Search Result Second page not available

2017-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

Bug ID: 19548
   Summary: Search Result Second page not available
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: Linux
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rainer.stowas...@zamg.ac.at
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

With the SRU/Z39.50 search 
using a quotation mark
has the interesting effect that the first page of a result is displayed
but a second page is not available.

Looking at the pl source 
it seems that quotation marks are used and escaped for the first page
but not for a second recall.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/