[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #69298|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 69299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69299=edit
Bug 19466 - Check if cardnumber mandatory

Followed test plan and patch applies and functions as expected.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #57 from Mike  ---
Can anobody move this bug ... its on very good way


Thanks


Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 CC||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13881] Add desk management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

David Bourgault  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

--- Comment #1 from David Bourgault  ---
Created attachment 69298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69298=edit
Bug 19466 - Check if cardnumber mandatory

Turns out this isn't a bug, since it is caused by 'cardnumber' being in the
'BorrowerMandatoryField' syspref.

It is however confusing for the user that it suggested to leave the field blank
when the field is required. To alleviate this I added a condition to the code;
it will not suggest leaving the field blank if 'BorrowerMandatoryField'
contains 'cardnumber'.

To test:

Before:
0) Enable autoMemberNum
1) Add 'cardnumber' to BorrowerMandatoryField
2) Go to create a user: a message will appear suggesting you leave the
cardnumber field blank for autocalc, but when submitting the form it will show
as required.
Apply patch
2) Go to create a user: if 'cardnumber' is in BorrowerMandatoryField, the
suggestion will not be shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #63 from David Bourgault  ---
Created attachment 69297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69297=edit
Bug 12747 - Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

  Attachment #69295|0   |1
is obsolete||

--- Comment #28 from David Bourgault  ---
Created attachment 69296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69296=edit
Bug 14784 - Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

  Attachment #68132|0   |1
is obsolete||

--- Comment #27 from David Bourgault  ---
Created attachment 69295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69295=edit
Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927

Ian Bays  changed:

   What|Removed |Added

 CC||ian.b...@ptfs-europe.com

--- Comment #15 from Ian Bays  ---
After recent upgrade to 17.05.04.000 bulkmarcimport started to fail on all
items attempted to be added.

ERROR: Adding items to bib 1 failed: Undefined subroutine
::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line
382,  line 1

So I manually added the prefix and the next error came up:

ERROR: Adding items to bib 74925 failed: Undefined subroutine
::Items::GetMarcStructure called at /usr/share/koha/lib/C4/Items.pm line
2307,  line 14.

Manually adding the prefix to that line seems to have worked, but it does not
feel like the right solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault  changed:

   What|Removed |Added

  Attachment #69293|0   |1
is obsolete||

--- Comment #3 from David Bourgault  ---
Created attachment 69294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69294=edit
Bug 19681 - Correct result count formatting

Small correction, previous patch accidentally changed the file mode to 644.

--

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Owen Leonard  changed:

   What|Removed |Added

  Attachment #69289|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 69293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69293=edit
Bug 19681 - Correct result count formatting

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

--- Comment #1 from Owen Leonard  ---
Created attachment 69292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69292=edit
Bug 19682: Move JS to the footer: Two patron-related tools

This patch modifies two patron-related tools templates in the staff
client so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Import patrons
  - Upload patron images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19683] Export.pl does not populate the Authority Types dropdown correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

--- Comment #1 from David Bourgault  ---
Created attachment 69291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69291=edit
Bug 19683 - Unbless authority_types search results

Fixes the bug by unblessing the authority types search results, and correcting
the variable names in the template.

To test:
0) Tools > Export > Export authority records
1) Authority Types dropdown is not empty

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19683] Export.pl does not populate the Authority Types dropdown correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

David Bourgault  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19683] New: Export.pl does not populate the Authority Types dropdown correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Bug ID: 19683
   Summary: Export.pl does not populate the Authority Types
dropdown correctly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: david.bourga...@inlibro.com
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: philippe.blo...@inlibro.com

When exporting Authorities, the authority_type dropdown that enables filtering
displays a list of blank values.

To reproduce:
0) Tools > Export > Export authority records
1) Authority Types dropdown is empty (except for "-- All --")

I've experienced the bug on 16.05 and master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19641] Move patron templates to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19682] New: Move JS to the footer: Two patron-related tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Bug ID: 19682
   Summary: Move JS to the footer: Two patron-related tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: dominic.piche...@inlibro.com,
testo...@bugs.koha-community.org
Depends on: 19641, 19647
Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for two patron-related tools which also incorporate
elements from the Patrons module, requiring a dependency on Bug 19641: Import
patrons and Upload patron images.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
[Bug 19682] Move JS to the footer: Two patron-related tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19680] Move JS to the footer: Patron and circulation tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19680] Move JS to the footer: Patron and circulation tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

--- Comment #1 from Owen Leonard  ---
Created attachment 69290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69290=edit
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

--- Comment #1 from David Bourgault  ---
Created attachment 69289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69289=edit
Bug 19681 - Correct result count formatting

This simply passes the missing information to the template.

Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

David Bourgault  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19681] New: label-item-search.pl result count formatting error when there is only one page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Bug ID: 19681
   Summary: label-item-search.pl result count formatting error
when there is only one page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: david.bourga...@inlibro.com
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When doing an item search through label-item-search.pl, if there is a only one
page of results the formatting of the result count is weird.

To reproduce:
0) Go to Tools > Label creator > New > Label batch
1) Add items
2) Do a search that will return few items
3) The result count will read "Results through of X" instead of "Results 1
through X of X"

The error is also present on 16.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680
[Bug 19680] Move JS to the footer: Patron and circulation tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680
[Bug 19680] Move JS to the footer: Patron and circulation tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19680] New: Move JS to the footer: Patron and circulation tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Bug ID: 19680
   Summary: Move JS to the footer: Patron and circulation tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 19647
Blocks: 17858

In order to conform to best practices for performance, staff client template
JavaScript should be in the footer instead of the header.

This patch will do so for some patron and circulation-related tools.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19679] Move templates JavaScript to the footer: More tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19679] Move templates JavaScript to the footer: More tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

--- Comment #1 from Owen Leonard  ---
Created attachment 69288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69288=edit
Bug 19679: Move templates JavaScript to the footer: More tools templates

This patch modifies more staff client tools templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  Export data
  Inventory
  Notices & slips
  Upload local cover image

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19679] Move tools templates JavaScript to the footer: More tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard  changed:

   What|Removed |Added

Summary|Move tools templates|Move tools templates
   |JavaScript to the footer:   |JavaScript to the footer:
   |More MARC tools |More tools templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19679] Move templates JavaScript to the footer: More tools templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Owen Leonard  changed:

   What|Removed |Added

Summary|Move tools templates|Move templates JavaScript
   |JavaScript to the footer:   |to the footer: More tools
   |More tools templates|templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679
[Bug 19679] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679
[Bug 19679] Move tools templates JavaScript to the footer: More MARC tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19679] New: Move tools templates JavaScript to the footer: More MARC tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Bug ID: 19679
   Summary: Move tools templates JavaScript to the footer: More
MARC tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 19647
Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for more Tools features.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69261|0   |1
is obsolete||

--- Comment #25 from Lari Taskula  ---
Created attachment 69286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69286=edit
Bug 19410: Move search_for_api into a Mojo helper

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Julian Maurice 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69276|0   |1
is obsolete||

--- Comment #4 from Claire Gravely  ---
Created attachment 69285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69285=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JS file, acquisitions-menu.js, which will be added
to each template which has the Acquisitions sidebar menu (in this case,
suggestions). Highlighting of the current page in the sidebar menu will
be broken for pages which have not been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69259|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 69283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69283=edit
Bug 19410: Unit tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Julian Maurice 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69262|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 69287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69287=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
  t/db_dependent/Koha/Objects.t \
  t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Julian Maurice 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69260|0   |1
is obsolete||

--- Comment #24 from Lari Taskula  ---
Created attachment 69284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69284=edit
Bug 19410: (follow-up) Fix typo in POD

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Julian Maurice 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69258|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 69282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69282=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
$vendors = Koha::Acquisition::Booksellers->api_list_search($c);
return $c->render(status => 200, openapi => $vendors);
  } catch {
...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Julian Maurice 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Owen Leonard  changed:

   What|Removed |Added

  Attachment #69280|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 69281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69281=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69278|0   |1
is obsolete||

--- Comment #3 from Claire Gravely  ---
Created attachment 69280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69280=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11285] Vocabulary disambiguation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10035] move or copy hard due date to be by patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10035

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #27 from Koha Team Lyon 3  ---
Created attachment 69279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69279=edit
monthly irregularities test example

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #26 from Koha Team Lyon 3  ---
Hello Alex,
For the three types of periodicity, the "permanent" irregularities on top of
table are kept over the renewal. This is working. But the detail of excluded
issues is not automatically set in relation with these ones (cf joined
image).We have to manually uncheck and recheck the "permanent" irregularities
to have the corresponding issues checked in the "Not published column".

That's a progress in the sense that there's a trace of the previous
configuration but the idea was to get all this automatically. would it be
possible ?

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69277|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69278=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

--- Comment #1 from Claire Gravely  ---
Created attachment 69277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69277=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19016] Add a script to fix corrupted data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016

Oliver Bock  changed:

   What|Removed |Added

 CC||oliver.b...@aei.mpg.de

--- Comment #16 from Oliver Bock  ---
FWIW, I just tried the script with all the patches (up to now) and ran into a
FK constraint violation:


% ./cleanup_database.pl --fix-corrupted-data

 * Tables biblio/deletedbiblio: 1455
Updating biblio.biblionumber=1455 with new id 1516
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_koha`.`items`, CONSTRAINT `items_ibfk_5` FOREIGN KEY
(`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
UPDATE CASCADE) [for Statement "UPDATE biblio SET biblionumber = ? WHERE
biblionumber = ?" with ParamValues: 0=1516, 1=1455] at ./cleanup_database.pl
line 510,  line 755.
Something went wrong, rolling back!

 * Tables biblioitems/deletedbiblioitems: 1455
Updating biblioitems.biblioitemnumber=1455 with new id 1516

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard  changed:

   What|Removed |Added

  Attachment #69240|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 69276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69276=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JS file, acquisitions-menu.js, which will be added
to each template which has the Acquisitions sidebar menu (in this case,
suggestions). Highlighting of the current page in the sidebar menu will
be broken for pages which have not been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |claire_grav...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to course reserves shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Claire Gravely  changed:

   What|Removed |Added

Summary|Clicking Cancel when adding |Clicking Cancel when adding
   |New Course shows message|New Course to course
   |Invalid Course! |reserves shows message
   ||Invalid Course!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19678] New: Clicking Cancel when adding New Course shows message Invalid Course!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Bug ID: 19678
   Summary: Clicking Cancel when adding New Course shows message
Invalid Course!
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: claire_grav...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it redirected
back to the main Course Reserves page.

To reproduce: 
Go to Course Reserves
Click '+ New Course'
Cancel the process
You are shown 'Invalid Course!'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Component|Architecture, internals,|REST api
   |and plumbing|
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
Summary|Koha::Objects needs a   |Add a helper function for
   |->search_for_api method |generating object searches
   ||for the API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15996] Bibliographic records diffing tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15996

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #3 from Magnus Enger  ---
Should this be "Needs signoff"? Could you add a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #6 from Magnus Enger  ---
Created attachment 69275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69275=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #5 from Magnus Enger  ---
Created attachment 69274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69274=edit
Update Schema - DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

  Attachment #69234|0   |1
is obsolete||
  Attachment #69272|0   |1
is obsolete||

--- Comment #4 from Magnus Enger  ---
Created attachment 69273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69273=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #3 from Magnus Enger  ---
Created attachment 69272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69272=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Claire Gravely  ---
Getting JS ReferenceError: $ is not defined
suggestion.pl:554:5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12497] Make OPAC search history feature accessible when it should

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |victor.grous...@biblibre.co
   ||m
 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12497] Make OPAC search history feature accessible when it should

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

--- Comment #3 from Gaetan Boisson  ---
On additional issue is that if you have activated search history on the opac,
and have an opac set to private via opacpublic, then patrons can only access
their search history if they have the permission to manage borrowers.

To reproduce :
- set your opac to private via opacpublic
- activate EnableOpacSearchHistory
- log in your private opac with a user that has no permissions for the staff
interface
- search for something in the catalog
- the link for search history is now visible, but if you click on it, you will
get an access denied message

- log in to your private opac with a user that has the "borrowers" permission
- repeat above steps : you can now access your search history.

Since this issue and the fact that the url still responds when the syspref is
turned off, when it should  display an access denied page, can be fixed in the
same block of code, we will offer a patch for both issues at once.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12497] Make OPAC search history feature accessible when it should

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Gaetan Boisson  changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com
Summary|OPAC search history page|Make OPAC search history
   |should only be accessible   |feature accessible when it
   |when feature is activated   |should

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19657] Move lists templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19657] Move lists templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69238|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69271=edit
Bug 19657: Move lists templates JS to the footer

This patch modifies the staff client's lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
lists page: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3185] Mobile Library/Bookmobile Mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3185

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #2 from Jon Knight  ---
Is this still required?  In the current version of Koha I can go into "Home ›
Administration › Circulation and fine rules", select a particular library and
then set "Return policy" in the "Default checkout, hold and return policy for
" to be "Item returns to issuing library".  If the particular library
in question is a mobile library van, would this not mean that books it issued
returned back to it?  I think this matches up with the original request from
seven years ago?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19628] Move course reserves templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19628] Move course reserves templates JS to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69164|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69270=edit
Bug 19628: Move course reserves templates JS to the footer

This patch modifies the staff client course reserves templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables, autocomplete, etc.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #12 from Jon Knight  ---
I'm just trawling through old REOPENed cases and I see that the current (17.05)
borrower schema still has the inconsistencies in the addresses.  As this was
reopened because it was proving to be an issue for some addresses longer than
100 characters, is it worth just attacking just those fields to make them all
match the address versions?

In other words make these field changes in the borrowers table schema:

B_address mediumtext NOT NULL,
B_address2 text,
B_city mediumtext NOT NULL,

and

altcontactaddress1 mediumtext NOT NULL,
altcontactaddress2 text,
altcontactaddress3 mediumtext NOT NULL,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19674] Broken indicators of changed fields in manage staged MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69251|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69269=edit
Bug 19674: Broken indicators of changed fields in manage staged MARC records
template

This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.

To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.

Changing any of the  fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19674] Broken indicators of changed fields in manage staged MARC records template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19664] Reports sidebar menu should match list of reports on reports home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69245|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69268=edit
Bug 19664: Reports sidebar menu should match list of reports on reports home
page

This patch makes the reports sidebar menu a little more consistent with
the reports home page menu by adding missing links to reports.

To test, observer the reports sidebar menu before and after the patch
and confirm that missing reports are linked in the update.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19664] Reports sidebar menu should match list of reports on reports home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #2 from Claire Gravely  ---
Hullo,

I find that my itemtypes drop down list just shows blanks instead of the item
types with patch applied. When I run the report I get a column for Books in the
results but then a Blank column next to it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19652] REST API: Log request and response content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69265|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 69267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69267=edit
Bug 19652: REST API: Log request and response content

This patch adds request and response logger to REST API. It is useful for
viewing
parameters that came within the request, and the content that is about to be
rendered back.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

Example configuration:
log4perl.logger.rest = DEBUG, REST
log4perl.appender.REST=Log::Log4perl::Appender::File
log4perl.appender.REST.filename=/home/koha/koha-dev/var/log/rest.log
log4perl.appender.REST.create_at_logtime=true
log4perl.appender.REST.syswrite=true
log4perl.appender.REST.recreate=true
log4perl.appender.REST.mode=append
log4perl.appender.REST.layout=PatternLayout
log4perl.appender.REST.layout.ConversionPattern=[%d] [%p] %m %l %n
log4perl.appender.REST.utf8=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19672] Move tools templates JavaScript to the footer: More MARC tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69252|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69266=edit
Bug 19672: Move tools templates JavaScript to the footer: More MARC tools

This patch modifies some staff client templates from the "Tools"
section so that JavaScript is included in the footer instead of the
header.

- Automatic item modifications by age
- MARC modification templates
- Stage MARC records for import
- Staged MARC record management

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19672] Move tools templates JavaScript to the footer: More MARC tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19652] REST API: Log request and response content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula  changed:

   What|Removed |Added

Summary|Debug-level logging for |REST API: Log request and
   |response JSON   |response content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19652] Debug-level logging for response JSON

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Lari Taskula  changed:

   What|Removed |Added

  Attachment #69233|0   |1
is obsolete||

--- Comment #4 from Lari Taskula  ---
Created attachment 69265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69265=edit
Bug 19652: REST API: Log request and response content

This patch adds request and response logger to REST API. It is useful for
viewing
parameters that came within the request, and the content that is about to be
rendered back.

To test:
1. prove t/db_dependent/api/v1.t
2. Configure log4perl configuration file for REST API and set log level to
DEBUG
3. Make any request to existing REST API endpoint
4. Observe response JSON in your log file

Example configuration:
log4perl.logger.rest = DEBUG, REST
log4perl.appender.REST=Log::Log4perl::Appender::File
log4perl.appender.REST.filename=/home/koha/koha-dev/var/log/rest.log
log4perl.appender.REST.create_at_logtime=true
log4perl.appender.REST.syswrite=true
log4perl.appender.REST.recreate=true
log4perl.appender.REST.mode=append
log4perl.appender.REST.layout=PatternLayout
log4perl.appender.REST.layout.ConversionPattern=[%d] [%p] %m %l %n
log4perl.appender.REST.utf8=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/