[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #54 from Katrin Fischer  ---
Hi Aleisha, want to retest and try to push this through QA, can you please
rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

--- Comment #9 from Katrin Fischer  ---
(In reply to J Schmidt from comment #7)
> -Used Sandbox1 (ByWater)
> -Koha Admin > MARC Bibliographic framework > Default framework > Actions >
> MARC Structure.
> -780 > Actions > Subfields. 
> -Found subfield i > clicked on Edit.
> -Expanded advanced constraints > checkmarked the Editor box > clicked Save
> changes. Noticed in the area that the 780$a is hidden. Hmmm. Left it
> alone.
> -Go to 785 and repeat this same step with Save changes
> Go to Koha Admin > MARC bibliographic framework test. Click that. System
> says test is OK.
> -Koha > Search the catalog > Didn't find any records.
> -Went to Koha > cataloging > New from z39.50 search for vogue and ISSN:
> 0042-8000. Import the record with the LCCN of 08036997. Save MARC record
> into Koha.
> add in 942-
> -Prompted me to add a new item record so I did that. Saved.
> -Went back to Edit bib record > Simple editor. Record number 439. 
> -Went to the 780 field and was able to add in and save a subfield i
> information. 
> -Saved the bib and was able to click SHOW MARC to see the subfield i
> information.
> -Went to Edit bib to repeat and fill in subfield i of the 785. Saved the bib
> again and was able to click SHOW MARC to see the subfield i information.
> 
> I would save this passes and can be signed off off.

Thx for testing! The MARC view will always work as it's generated from the
visibility settings you make for your frameworks. For this patch, you need to
take a look at the intranet detail page (normal view). 

I will try and find some examples for $i use in our union catalog.

Note: we should try and keep the existing patches, but add some to fix the OPAC
detail page as well!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #12 from Katrin Fischer  ---
(In reply to Marjorie Barry-Vila from comment #10)
> Hi,
> 
> I repeat this problem on 16.11
> 
> Test plan:
> 
> - in notice HOLD (/tools/letter.pl), write text in Print tab, save
> - check in table message_transports that line for HOLD are present (select *
> from message_transports)
> - in notice HOLD, supress text in Print tab, save
> - check in table message_transport that lines for HOLD are missing and in
> Patron messaging Preferences, there is a "-" where check box should appear
> 
> Regards
> Marjorie

Hi Marjorie,

I have tried to replicate the problem following your test plan, but it didn't
work for me on master. After emptying out the print section of the HOLD
template, the checkboxes still appear normally for me.
Maybe this is specific to 16.11, but can't test there right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19831] New: Turn on EnhancedMessagingPreferences by default for new installations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831

Bug ID: 19831
   Summary: Turn on EnhancedMessagingPreferences by default for
new installations
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I think we should not hide the different messaging options for new
installations and turn on EnhancedMessagingPreferences by default on
installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

--- Comment #3 from Katrin Fischer  ---
Thank you, Bonnie!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #4 from Katrin Fischer  ---
Thank you, Jessica!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69869|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 69894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69894=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Thx Priya!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69870|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 69893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69893=edit
Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile

To test:
1/ Grep to find OpacShowLibrariesPullDownMobile
2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm:
3/ Apply patch
4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2
files

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69871|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 69892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69892=edit
Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a
few European countries"

To test
1/ run installer and notice the inaccurate text "UNIMARC is used in Europe"
2/ run the patch attached
3/ run the installer and notice that the updated text "UNIMARC is used in a few
European countries"is now present

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Bug 10344 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per 
kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 CC||alei...@catalyst.net.nz
 Status|RESOLVED|REOPENED

--- Comment #78 from Aleisha Amohia  ---
This commit 01fbe2be9925f8586b9a2cb4dc908fc856b672a8 (Bug 10306: Core module
changes for multiple mappings) is breaking a bunch of things for me. A few
examples:

/cgi-bin/koha/opac-user.pl - when trying to see OPAC user summary, I get
internal server error: Not an ARRAY reference at
/home/vagrant/kohaclone/C4/Biblio.pm line 1124
/cgi-bin/koha/acqui/neworderbiblio.pl - when trying to add an order to a basket
from an existing record, I get
internal server error: Not an ARRAY reference at
/home/vagrant/kohaclone/C4/Biblio.pm line 2667

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Bug 19096 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per 
kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19594] Move admin templates JavaScript to the footer: MARC-related

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
Bug 19594 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per 
kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69849|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 69891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69891=edit
[SIGNED-OFF] Bug 19826: Add K::Acq::Budget(s) and K::Acq::Budget::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #64 from Aleisha Amohia  ---
Sorry for the gazillions of emails! This should now apply cleanly on master.
I should've added in the original test plan to update the database and the
schema after applying patches, so make sure you do that first! Here's the test
plan again.

TEST PLAN:

0. Update database and schema
1. Enable the UseRecalls syspref
2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields
(recall due date interval, recall overdue fine amount, recall pickup period)
3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default
number of days used if the recall pickup period isn't set in Step 2
4. Check out an item to a patron
5. Go to that item's detail page in the OPAC. Notice the holdings table says
'Checked out'
6. Log in to the OPAC with another patron and go back to that detail page. The
holdings table should now have a Recall link next to the 'Checked out' text
7. Click the Recall button and confirm the Recall
8. Go to the user's opac summary and confirm there is now a Recalls tab, with
the correct number of recalls (should be 1).
9. Test cancelling the recall by clicking Cancel. Confirm the recall has been
cancelled. Repeat steps 6 and 7.
10. In the left navigation, there will also be a 'recalls history' tab. Click
it. There should be a log, similar to reading history, with the cancelled
recall and the new recall in it. Confirm all information is correct
11. Again, test cancelling the recall. Repeat steps 6 and 7.
12. In the staff interface, go to the logged in user's checkouts. Confirm you
can see a new Recalls tab, with the active (not cancelled) recall in the table.
Should be the same for the details tab also.
13. Test cancelling works for both of these again, and making new recalls
again.
14. Check in the recalled item. You should see a pop up, asking to confirm the
recall as waiting. Click confirm.
15. Go to the Circulation main page. You should see 3 new reports: recalls
queue, overdue recalls and recalls awaiting pickup
16. Go to the recalls queue, confirm you can see an entire history of recalls
at your library. Confirm cancel works when selecting checkboxes and clicking
the multiple button. If you do this, you'll need to place the recall again and
check the item in again
17. Go to recalls awaiting pickup. You should see the recall under the recalls
waiting tab
18. in Mysql, set the waitingdate for your recall to be more than 'recall
pickup period' days before today's date
19. Refresh the recalls awaiting pickup page. You should see the recall under
the recalls waiting tab, and the recalls waiting more than X days tab.
20. expire the recall. confirm this is expired by checking the recalls queue
21. place another recall, but do not check it in
22. in mysql, set the date_due of the checkout (issues table) to be at least
'recall due date interval' number of days before today's date
23. run the overdue_notices.pl cronjob
24. go to the overdue recalls circ report and confirm your recall shows there
25. try cancelling the recall here also
26. in mysql, check the message_queue and confirm there have been the
appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices
sent with the correct to and from addresses and other content
27. test t/db_dependent/Koha/Recalls.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69405|0   |1
is obsolete||

--- Comment #60 from Aleisha Amohia  ---
Created attachment 69887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69887=edit
Bug 19532: Flagging recall as 'old' when expired or cancelled

Set 'old' flag to 1 if cancelling or expiring a recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69872|0   |1
is obsolete||

--- Comment #63 from Aleisha Amohia  ---
Created attachment 69890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69890=edit
Bug 19532: Nice message if no recalls for opac recalls history

https://bugs.koha-community.org/show_bug.cgi?id=19523

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69409|0   |1
is obsolete||

--- Comment #61 from Aleisha Amohia  ---
Created attachment 69888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69888=edit
Bug 19532: Cronjob to check for overdue recalls

This patch adds a check to the overdue_notices cronjob, so if any of the
overdue issues are also recalls, the status will be set to O (overdue)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69410|0   |1
is obsolete||

--- Comment #62 from Aleisha Amohia  ---
Created attachment 69889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69889=edit
Bug 19532: Tests for Koha/Recalls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69354|0   |1
is obsolete||

--- Comment #59 from Aleisha Amohia  ---
Created attachment 69886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69886=edit
Bug 19532: Send notice to user to pickup recalled returned item

Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall
when the item is checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69223|0   |1
is obsolete||

--- Comment #56 from Aleisha Amohia  ---
Created attachment 69883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69883=edit
Bug 19532: UseRecalls syspref

This patch adds a syspref to control the usability of the recalls
feature

Test the following:

Staff side
/includes/circ-menu.inc
/includes/circ-nav.inc
/includes/members-menu.inc
/admin/preferences/circulation.pref
/circ/circulation-home.tt
/circ/circulation.tt
/circ/recalls_overdue.tt
/circ/recalls_queue.tt
/circ/recalls_waiting.tt
/members/moremember.tt
/members/recallshistory.tt

OPAC
/includes/usermenu.inc
/opac-recall.tt
/opac-recalls.tt
/opac-user.tt
/members/recallshistory.pl
/opac/opac-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69353|0   |1
is obsolete||

--- Comment #58 from Aleisha Amohia  ---
Created attachment 69885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69885=edit
Bug 19532: Send notice to user to return a recalled item

When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is
sent to the user who has the item checked out, with the updated due
date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69222|0   |1
is obsolete||

--- Comment #55 from Aleisha Amohia  ---
Created attachment 69882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69882=edit
Bug 19532: Only recall items checked out by other users

... shouldn't be able to recall items that are currently checked out by
yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69221|0   |1
is obsolete||

--- Comment #54 from Aleisha Amohia  ---
Created attachment 69881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69881=edit
Bug 19532: Recalls awaiting pickup report

this patch adds reports for all recalls awaiting pickup, and recalls
that have been waiting more than X days. a syspref,
RecallsMaxPickUpDelay, is added to give a general max shelf time for
recalls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69322|0   |1
is obsolete||

--- Comment #57 from Aleisha Amohia  ---
Created attachment 69884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69884=edit
Bug 19532: Recall pop up when checking in an item

When checking in an item on the staff side, the staff member will see a
pop up if there is a recall attached to that item. From here, they can
confirm the recall, setting the status to 'Waiting' and updating the
waitingdate. The item will still be checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69149|0   |1
is obsolete||

--- Comment #51 from Aleisha Amohia  ---
Created attachment 69878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69878=edit
Bug 19532: recalls history

this patch
- adds recalls history (similar to holds history) to OPAC and intranet
- edits the tables in opac-user.pl (OPAC), moremember.pl and
circulation.pl (staff) so that it only shows active recalls (recalls
that have been requested or are waiting)
- some extra datatables fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69170|0   |1
is obsolete||

--- Comment #52 from Aleisha Amohia  ---
Created attachment 69879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69879=edit
Bug 19532: Recalls queue

This patch adds a recalls queue page to the circulation reports

You can see all recalls made in the system, who requested them, their
status and other relevant info. you can cancel individual or multiple
recalls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69147|0   |1
is obsolete||

--- Comment #49 from Aleisha Amohia  ---
Created attachment 69876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69876=edit
Bug 19532: Show recalls on intranet side

This patch
- adds Recall tab to the Check out section of member account, and to the
Details section of member account
- Functionality to cancel recalls on staff side
- Fixing cancel on OPAC side (before I was deleting the whole recall
instead of cancelling)
- Fixing validation when checking whether a recall can be placed on an
item that has been recalled by this borrower before. If the old recall
is expired or cancelled then they can make a recall again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69172|0   |1
is obsolete||

--- Comment #53 from Aleisha Amohia  ---
Created attachment 69880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69880=edit
Bug 19532: Overdue recalls report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69100|0   |1
is obsolete||

--- Comment #47 from Aleisha Amohia  ---
Created attachment 69874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69874=edit
Bug 19532: Recall an item in OPAC

This patch:
  - adds the 'Recall' button to the item on it's detail page
  - adds ability to place a recall
  - the recall is stored in the recalls table
  - the due date for the checkout is updated to whatever has been set in
  the issuing rule under recall_due_date_interval
  - error messages for if the user isn't logged in, the user tries to
  place a recall on an item they have already recalled, or if storing
  the recall in the db fails for any reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69148|0   |1
is obsolete||

--- Comment #50 from Aleisha Amohia  ---
Created attachment 69877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69877=edit
Bug 19532: Fixing broken OPAC recalls table

Forgot to add 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69102|0   |1
is obsolete||

--- Comment #48 from Aleisha Amohia  ---
Created attachment 69875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69875=edit
Bug 19532: Cancel recall and see recalls in OPAC

This patch adds ability for user to cancel a recall
They can also see their recalls in the user summary

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68653|0   |1
is obsolete||

--- Comment #46 from Aleisha Amohia  ---
Created attachment 69873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69873=edit
Bug 19532: Circulation rules

Adding 3 new rules and columns to issuingrules
- recall_due_date_interval
- recall_overdue_fine
- recall_shelf_time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69841|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #69411|0   |1
is obsolete||

--- Comment #45 from Aleisha Amohia  ---
Created attachment 69872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69872=edit
Bug 19532: Nice message if no recalls for opac recalls history

https://bugs.koha-community.org/show_bug.cgi?id=19523

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #11 from Chris Cormack  ---
(In reply to Jonathan Druart from comment #10)
> This change broke 3 tests:
> https://jenkins.koha-community.org/job/Koha_16.11_D8/lastCompletedBuild/
> testReport/

Yup, the tests are wrong so they should break. I'll fix them this afternoon ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19829] OPAC Search Limit by Branch bringing up records where the home library only has a missing copy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19829

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

--- Comment #1 from Bonnie Crawford  ---
Created attachment 69871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69871=edit
Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a
few European countries"

To test
1/ run installer and notice the inaccurate text "UNIMARC is used in Europe"
2/ run the patch attached
3/ run the installer and notice that the updated text "UNIMARC is used in a few
European countries"is now present

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Bonnie Crawford  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||bonniecrawf...@catalyst.net
   ||.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

priya.pa...@catalyst.net.nz changed:

   What|Removed |Added

 CC||priya.pa...@catalyst.net.nz
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

--- Comment #1 from priya.pa...@catalyst.net.nz ---
Created attachment 69870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69870=edit
Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile

To test:
1/ Grep to find OpacShowLibrariesPullDownMobile
2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm:
3/ Apply patch
4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2
files

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jessica  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jessica  changed:

   What|Removed |Added

 CC||jessicafree...@catalyst.net
   ||.nz
  Attachment #69868|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #2 from Jessica  ---
Created attachment 69869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69869=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #1 from Jessica  ---
Created attachment 69868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69868=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for
memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and
t/db_dependent/UsageStats.t 3/grep again, notice they have been removed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19510] edi_manage permission has no description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

--- Comment #3 from Katrin Fischer  ---
Thx Chris! 


I really need to sleep now... :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19510] edi_manage permission has no description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19510] edi_manage permission has no description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69866|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 69867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69867=edit
Bug 19510: Add description for edi_manage in acquistion permissions

Test Plan:
1/ Login
2/ Select patrons
3/ Search for a patron by name or card number that exists in the system
4/ Click More -> Set permissions
5/ Expand 'acquistions' and notice that 'edi_manage' has no description
6/ Apply patch
7/ Refresh the permissions page or repeat steps 2 to 5.
8/ Notice that 'edi_manage' now has a description of 'Manage EDIFACT
transmissions'

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=19519

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
I agree that the availability filter is problematic, but I am not sure someone
is willing to invest time in this, you might want to consider funding a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #24 from Katrin Fischer  ---
Comment on attachment 69204
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69204
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

Review of attachment 69204:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11300=69204)
-

Hi Bouzid, did you attach the most recent patch? This one is not using
Modern::Perl as you said in your last comment?

I have taken another look at the code, some are questions:

::: C4/Linker/Z3950Server.pm
@@ +1,1 @@
> +package C4::Linker::Z3950Server;

I am not sure about adding a new module to the C4 namespace at this point in
time, as we have been busy moving things into the new Koha namespace. This
might be something to check with the Release Manager. It might be ok because of
the relationship with C4::Linker.

@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

You should always use Modern::Perl instead of use strict; use warnings;

@@ +121,5 @@
> +  ($authid, $record, $status) = $self->getZ3950Authority($heading);
> +
> +  Do a Z39.50 search for the heading using the $conn ZOOM::Connection object 
> and the $heading Heading.
> +  The column origincode is used to check for duplicates.
> +  FIXME: Use thesaurus in search? As of Koha 3.8, the community stopped 
> using them.

What's this comment referring to?

@@ +167,5 @@
> +}
> +my $query;
> +if ($heading->{'auth_type'} eq 'PERSO_NAME' ){
> + $query 
> =qq(Personal-name,do-not-truncate,ext="$heading->{'search_form'}");
> +}elsif ($heading->{'auth_type'}  eq 'UNIF_TITLE' ) {

I am not sure if these are universal or only specific to MARC21. :(

@@ +214,5 @@
> +my $authtypecode = C4::AuthoritiesMarc::GuessAuthTypeCode($record);
> +my $authId;
> +
> +# Use the control number to prevent the creation of duplicate 
> authorities.
> +my $controlNumber = $record->field('970')->subfield('0');

What is 970? I checked authority frameworks and bibliograpic frameworks but
it's defined in neither?

@@ +225,5 @@
> +# Corrections and verifications before insertion
> +my $format;
> +my $leader=' nz  a22 o  4500';# Leader for incomplete MARC21 
> record
> +
> +if (uc(C4::Context->preference('marcflavour')) eq 'UNIMARC') {

No need for uc() here I think.

@@ +238,5 @@
> +$record->leader($leader);
> +}
> +if (!$record->field('003')) {
> +$record->insert_fields_ordered(
> +
> MARC::Field->new('003',C4::Context->preference('MARCOrgCode'))

I think this needs to be adjusted - as of 17.11 the MARCOrgCode can also be set
on library level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19510] edi_manage permission has no description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

--- Comment #1 from Chris Weeks  ---
Created attachment 69866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69866=edit
Bug 19510: Add description for edi_manage in acquistion permissions

Test Plan:
1/ Login
2/ Select patrons
3/ Search for a patron by name or card number that exists in the system
4/ Click More -> Set permissions
5/ Expand 'acquistions' and notice that 'edi_manage' has no description
6/ Apply patch
7/ Refresh the permissions page or repeat steps 2 to 5.
8/ Notice that 'edi_manage' now has a description of 'Manage EDIFACT
transmissions'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19510] edi_manage permission has no description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Chris Weeks  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

--- Comment #4 from Katrin Fischer  ---
Hi Isabel, thx for your first patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69864|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 69865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69865=edit
Bug 18313: remove delicious link on social networks

To test:
1/ enable social networkds systems preference
2/ look at any record on the OPAC, notice it has a link to delicious
3/ apply patch
4/ refersh page on OPAC, noitce delicious link has gone

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

isabel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||isabel.gr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

--- Comment #2 from isabel  ---
Created attachment 69864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69864=edit
Bug 18313: remove delicious link on social networks

To test:
1/ enable social networkds systems preference
2/ look at any record on the OPAC, notice it has a link to delicious
3/ apply patch
4/ refersh page on OPAC, noitce delicious link has gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #11 from Katrin Fischer  ---
Thx for your first patch Sherryn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69862|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 69863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69863=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack  changed:

   What|Removed |Added

  Attachment #36164|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

sherryn  changed:

   What|Removed |Added

 CC||sher...@catalyst.net.nz
 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #9 from sherryn  ---
Created attachment 69862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69862=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16821] Facets: home libraries, locations, item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

--- Comment #7 from Katrin Fischer  ---
I guess you could always display, say, all item types, but we couldn't display
the number of records behind it then and also it would show item types that are
not part of the search result.

Would be interesting to get some idea how well this works with Elastic at the
moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
This change broke 3 tests:
https://jenkins.koha-community.org/job/Koha_16.11_D8/lastCompletedBuild/testReport/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for float

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #8 from Jonathan Druart  
---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for float

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #7 from Jonathan Druart  
---
Created attachment 69861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69861=edit
Bug 19759: Fix failing test in Chargelostitem.t

t/db_dependent/Circulation/Chargelostitem.t .. 1/6
 #   Failed test 'The accountline amount should be precessfee value '
 #   at t/db_dependent/Circulation/Chargelostitem.t line 71.
 #  got: '4.5968041848873e+20'
 # expected: '459680418488730451968.00'

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #8 from Jonathan Druart  
---
I have moved the code creating Koha::Patron->old_checkouts to its own bug
report (bug 19830).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19599


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599
[Bug 19599] anonymise_issue_history can be very slow on large systems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830
[Bug 19830] Add the Koha::Patron->old_checkout method
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69778|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 69860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69860=edit
Bug 19599: Speed anonymise_issue_history up

The query generated by anonymise_issue_history is unecessary complex and
can be very slow on large DB.
With this patch we will execute one query per patron instead.

See patch "Bug 19599: Simplify the query" on the bug report for an
alternative.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

--- Comment #1 from Jonathan Druart  
---
Created attachment 69859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69859=edit
Bug 19830: Add the Koha::Patron->old_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19830] New: Add the Koha::Patron->old_checkout method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Bug ID: 19830
   Summary: Add the Koha::Patron->old_checkout method
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17584] Add the Koha::Patron->checkouts method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19830

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19829] New: OPAC Search Limit by Branch bringing up records where the home library only has a missing copy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19829

Bug ID: 19829
   Summary: OPAC Search Limit by Branch bringing up records where
the home library only has a missing copy
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisettesla...@gmail.com
QA Contact: testo...@bugs.koha-community.org

When doing a search and limiting by branch using the 'Home Library' section on
the left had side of the search results page, some records that belong to that
home library but are marked as lost or damaged or are staff use copies (all of
which are invisible to patrons in the opac) will still come up in the search
results even when limiting to currently available items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15839

--- Comment #18 from Jonathan Druart  
---
Koha::Reviews is used since bug 15839 (in 16.11.x), but the patron's info are
still retrieved from GetMember.
Since bug 17829 (17.11) they are using Koha::Patrons (which means we cannot
call a method on an undefined object)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839
[Bug 15839] Move the reviews related code to Koha::Reviews
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808
[Bug 19808] Reviews from deleted patrons make few scripts to explode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808
[Bug 19808] Reviews from deleted patrons make few scripts to explode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #17 from Victor Grousset/tuxayo  ---
BTW any idea why it doesn't seem to affect 16.11?
A least for the explosion part. It still shows "Your comment" + the edit button
when the patron is deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #18 from Jon Knight  ---
I have applied the database changes on my kohadevbox and I get this from `prove
-v t/db_dependent/Budgets.t` (first 128 tests of the 145 are OK, so looks like
test 129 is blowing up, so I won't include all the output for brevity here):

ok 127 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_2)
ok 128 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_21)
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=17307944232523900.00, 1='1', 2='Manual Debit'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) at
/home/vagrant/kohaclone/Koha/Object.pm line 122
# Looks like your test exited with 255 just after 128.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 17/145 subtests 

Test Summary Report
---
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 128 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 128.
Files=1, Tests=128,  5 wallclock secs ( 0.04 usr  0.02 sys +  3.98 cusr  0.44
csys =  4.48 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||tomasco...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 69858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69858=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations. The rest of the DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 69857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69857=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

Summary|Reviews from deleted|Reviews from deleted
   |patrons make opac-detail|patrons make few scripts to
   |explode |explode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #16 from M. Tompsett  ---
Comment on attachment 69856
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Review of attachment 69856:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19808=69856)
-

::: reviews/reviewswaiting.pl
@@ +67,4 @@
>  }
>  )->unblessed;
>  
> +for my $review ( @$reviews ) {

Love the explicit $review instead of $_ code.

@@ +72,1 @@
>  # setting some borrower info into this hash

Think the comment is misplaced.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #15 from Jonathan Druart  
---
Created attachment 69856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856=edit
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home › Tools › Comments › Comments awaiting moderation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #14 from Jonathan Druart  
---
Created attachment 69855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69855=edit
Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #13 from Jonathan Druart  
---
Created attachment 69854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69854=edit
Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

Make the tests easier to read

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69828|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 69853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69853=edit
Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||lari.task...@jns.fi,
   ||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19828] New: Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Bug ID: 19828
   Summary: Koha::Object->store should catch DBIC exceptions and
raise Koha::Exceptions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

DBIC exceptions are not suitable for reporting end users and API consumers the
problems we find. They need to be parsed to find out the root cause of the
problems. This could be done in Koha::Object-based classes (see bug 16330 for a
discussion on this), but it should be handled more generically, in
Koha::Object->store.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/