date:20180109

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69077|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70294|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #12 from Katrin Fischer  ---
Created attachment 70399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70399=edit
Bug 18856: (follow-up) Catch missed instance of is_cancelable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #11 from Katrin Fischer  ---
Created attachment 70398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70398=edit
Bug 18856: Don't show cancel option for waiting holds in OPAC

If a hold is 'waiting' for the patron to collect then the patron should be
prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure' alert
and when you click Yes the page just refreshes and the hold remains.
Staff can cancel the hold from the staff interface but they can then action the
waiting hold.
I think therefore that it is correct behaviour that a patron cannot cancel a
hold when it reaches waiting state via the opac but it would be useful to
either have a warning to prevent the cancellation or a useful message when they
attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a hold,
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds

Signed-off-by: Kyle M Hall 
Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from Katrin Fischer  ---
Fixed the patch subjects according to guidelines (: (follow-up) state what
was fixed)

Should is_cancelable be removed after this change? It seems the only remaining
occurrences are in tests:

Koha/Hold.pm:=head3 is_cancelable
Koha/Hold.pm:sub is_cancelable {
t/db_dependent/Hold.t:# Test method is_cancelable
t/db_dependent/Hold.t:ok( $hold->is_cancelable(), "Unfound hold is cancelable"
);
t/db_dependent/Hold.t:ok( $hold->is_cancelable, "Waiting hold is cancelable" );
t/db_dependent/Hold.t:ok( !$hold->is_cancelable, "In transit hold is not
cancelable" );


Sorry Marcel, forgot to check the QA contact first!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Lee Jamison  changed:

   What|Removed |Added

  Attachment #70383|0   |1
is obsolete||

--- Comment #6 from Lee Jamison  ---
Created attachment 70397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70397=edit
Bug 19938: Refactor checkoverdues

TEST PLAN
-
0) back up plack error log if you care.

1) Run these on your kohadevbox:
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
However, the log file will have noise.

2) Run these on your kohadevbox:
git bz apply 19938
restart_all
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
This time the log file will have no noise.

3) run koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Lee Jamison  changed:

   What|Removed |Added

  Attachment #70382|0   |1
is obsolete||

--- Comment #5 from Lee Jamison  ---
Created attachment 70396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70396=edit
Bug 19938: Split C4/Members.pm to avoid conflict issues

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19715] Add the amount of contract's in the vendor' s détails page.

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14568

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19319] Reflected XSS Vulnerability in opac-MARCdetail.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19319

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19568] Wrong html filter used in opac-opensearch.tt url

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19569] X-Frame-Options=SAMEORIGIN is not set from opac-showmarc.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19569

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com
   |ity.org |
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
 QA Contact||testo...@bugs.koha-communit
   ||y.org
 Status|Passed QA   |Pushed to Master
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
 Status|Passed QA   |Pushed to Master
  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha
 QA Contact||testo...@bugs.koha-communit
   ||y.org

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha
 Status|Passed QA   |Pushed to Master
 QA Contact||testo...@bugs.koha-communit
   ||y.org

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19568] Wrong html filter used in opac-opensearch.tt url

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568

Jonathan Druart  changed:

   What|Removed |Added

  Component|Koha|Architecture, internals,
   ||and plumbing
  Group|Koha security   |
 Status|Passed QA   |Pushed to Master
Product|Koha security   |Koha

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19319] Reflected XSS Vulnerability in opac-MARCdetail.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19319

Jonathan Druart  changed:

   What|Removed |Added

  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha
 Status|Passed QA   |Pushed to Master
  Group|Koha security   |

--- Comment #27 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19569] X-Frame-Options=SAMEORIGIN is not set from opac-showmarc.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19569

Jonathan Druart  changed:

   What|Removed |Added

Product|Koha security   |Koha
 Status|Passed QA   |Pushed to Master
  Component|Koha|Architecture, internals,
   ||and plumbing
 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Group|Koha security   |

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
Product|Koha security   |Koha
  Component|Koha|Architecture, internals,
   ||and plumbing
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML.

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #24 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #23 from Liz Rea  ---
You could have asked me to fix those things, I'd have been happy to.

Thank you for the extra patches all the same.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16782] Display report URL in staff client report interface

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782

--- Comment #22 from Jonathan Druart  
---
Created attachment 70395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70395=edit
Bug 16782: Use uri filter instead of html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Manual
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #13 from Jonathan Druart  
---
Can we have a patch for the manual please? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #12 from Jonathan Druart  
---
Created attachment 70394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70394=edit
Bug 11046: Improve the readability of the regex using named capture

The tests tell me I am good

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

--- Comment #1 from Owen Leonard  ---
Created attachment 70393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70393=edit
Bug 19939 - Move cataloging Z39.50 results actions into menu

This patch modifies the template which displays cataloging Z39.50
search results so that the "MARC," "Card," and "Import" links are moved
out of separate table cells and into one menu.

The old menu which would appear when any table cell is clicked has been
removed, and code added to display the same Bootstrap menu if a table
cell is clicked.

To test, apply the patch and go to Cataloging -> New from Z39.50/SRU.

- Perform a Z39.50 search which will return more than one result.
- Confirm that clicking the "Actions" button triggers a drop-down menu.
  - Confirm that the links in the menu trigger actions for the correct
bibliographic record.
- Confirm that clicking any other table cell in the table of results
  will trigger the display of the same menu.
  - Confirm that this menu works correctly for the correct record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #21 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #15)
> QA Comment
> Interesting feature! Limited testing did not reveal problems.
> 
> Functionality issue:
> In Administration, smart-rules, the section "Default checkout limit by
> patron category" contains the item "Maximum total holds allowed (count)".

I've submitted a patch to improve the section name.

> Not sure if the label should contain total and count btw.

Removed

> But the section should be renamed. This does not pertain any longer to
> checkout limits only.

Agreed.

> Furthermore I would expect to have max_holds also under Default checkout,
> hold and return policy. It seems consistent to add it also without a patron
> category restriction.

That behavior is controlled by the maxreserves system preference. We should
move that out of a syspref and into the circ rules. I'd be happy to do that on
another bug but it's definitely out of the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #20 from Kyle M Hall  ---
Created attachment 70392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70392=edit
Bug 15524 [QA Followup] - Change language used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #19 from Kyle M Hall  ---
Created attachment 70391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70391=edit
Bug 15524: (follow-up) Rename database update

This ensures that this update is applied in the correct order relative
to its dependent bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #18 from Kyle M Hall  ---
Created attachment 70390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70390=edit
Bug 15524 - Update Schema

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67180|0   |1
is obsolete||
  Attachment #67181|0   |1
is obsolete||
  Attachment #67531|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 70389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70389=edit
Bug 15524 - Set limit on maximum possible holds per patron by category

It's possible to set a limit on the maximum number of holds for a particular
branch/category/itemtype, but not on the total number of holds for a given
patron (by branch/category).
This new rule works in conjunction with the existing branch/borrower/item rules
in that Koha will use the lower of the two limits. This new rule counts all
holds of all types, which prevents bib-level holds from not being counted for
the purpose of these limits. This makes the most sense and was also requested
by the sponsor.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Go to the circ rules editor, note the new max holds rules
   by patron category in the "Checkout limit by patron category".
   ( Should we rename this section? )
4) Create find a patron that is allowed to place a hold, count the
   number of holds that patron has. Lets make that number 'X'.
5) Set the new max holds rule to X for "All libraries"
6) Note the patron can no longer place another hold
7) Set the new max holds rule to X + 1 for the patron's home library
8) Note the patron can again place another hold
9) Set the new max holds rule to X for the patron's home library
10) Note the patron can no longer place another hold

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #23 from Jonathan Druart  
---
Created attachment 70388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70388=edit
Bug 18071: Improve parameters handling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #16 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #15)
> QA Comment
> Interesting feature! Limited testing did not reveal problems.
> 
> Functionality issue:
> In Administration, smart-rules, the section "Default checkout limit by
> patron category" contains the item "Maximum total holds allowed (count)".

I've submitted a patch to improve the section name.

> Not sure if the label should contain total and count btw.

Removed

> But the section should be renamed. This does not pertain any longer to
> checkout limits only.

Agreed.

> Furthermore I would expect to have max_holds also under Default checkout,
> hold and return policy. It seems consistent to add it also without a patron
> category restriction.

That behavior is controlled by the maxreserves system preference. We should
move that out of a syspref and into the circ rules. I'd be happy to do that on
another bug but it's definitely out of the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #22 from Jonathan Druart  
---
Can we rename commit with confirm? We use commit 3x in misc instead of 8x for
confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #77 from Jonathan Druart  
---
Also, when I see:
@@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { 
 }

 return $any_available ? 0 : 1; 
+} else { # on_shelf_holds == 0 "If any unavailable" (the description is
rather cryptic and could still be improved)
+return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} ); 
 }
-
-if ($item->{onloan}) { 
-return 1;  
-}  
-
-if ( Koha::Holds->search({itemnumber => $item->{itemnumber},   
-  found => ['W', 'T']})->count ) { 
-return 1;  
-}   

Then:
+sub hasItemswaitingOrInTransit {
+my ( $self ) = @_;
+
+if ( Koha::Holds->search({ biblionumber => $self->id,
+   found => ['W', 'T'] })->count ) {
+return 1;
+}

I am pretty sure something is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #76 from Jonathan Druart  
---
Additionally, do you think adding camelCase method's name in a module
containing only snake_case is a good idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #75 from Jonathan Druart  
---
Comment on attachment 69815
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815
Bug 4319: [OPAC] Allow holds on waiting/transit items

Review of attachment 69815:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=4319=69815)
-

::: Koha/Biblio.pm
@@ +319,5 @@
>  }
>  
> +=head3 hasItemswaitingOrInTransit
> +
> +=cut

Why are you cheating the QA script?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18472] Add system preferences to manage online help system

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19817

--- Comment #27 from Jonathan Druart  
---
I am waiting for answers, feedbacks and suggestions on bug 19817.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18472

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #7 from Jonathan Druart  
---
(In reply to George Williams (NEKLS) from comment #6)
> Signed off based on video that Jesse put together for me.

Well, none of the dependencies apply cleanly, where are the patches ? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I have fixed an easy conflict with commit
971591d4ee8576d6782d32610bbae7cfe4674231
Bug 19029: Add JavaScript security question for cloning circ rules

-
+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67177|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 70387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70387=edit
Bug 15520: Add permission to restrict circ rules editing to own library

Test plan:

1) Ensure that you have four users:
 a) A superlibrarian
 b) A user with all `parameters` permissions (the toplevel `parameters`
box is checked).
 c) A user with the `manage_circ_rules` permission (and, of course,
`catalogue`).
 d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted`
and `catalogue` permissions.
2) As all four users, load the "Circulation and fine rules"
   administration page (admin/smart-rules.pl).
3) The page should be unchanged for the first three users. It should be
   possible to view and edit the circ rules for all libraries.
4) The last (restricted) user should only be able to view and edit the
   circ rules for their own library.

Followed test plan, patch worked as described
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

--- Comment #1 from Jonathan Druart  
---
Created attachment 70384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70384=edit
Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued

Just a preliminary step to clean the code a bit in CanBookBeIssued.
The effective item type is already set from GetItem and we do not need
to deal with that again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

--- Comment #2 from Jonathan Druart  
---
Created attachment 70385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70385=edit
Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences

The biblioitem's info can be retrieved with Koha::Biblio->biblioitem

Test plan:
1. Use the age restriction to restrict checkouts for a given patron
2. Check some items of a biblio out, go to "Items" tab, then "View
item's checkout history" link. Compare views with and without patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

--- Comment #3 from Jonathan Druart  
---
Created attachment 70386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70386=edit
Bug 19943: Remove C4::Biblio::GetBiblioItemData

It is no longer used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19943

--- Comment #8 from Jonathan Druart  
---

Bug 19943 - Koha::Biblio - Remove GetBiblioItemData


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943
[Bug 19943] Koha::Biblio - Remove GetBiblioItemData
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19943] New: Koha::Biblio - Remove GetBiblioItemData

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

Bug ID: 19943
   Summary: Koha::Biblio - Remove GetBiblioItemData
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19929


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929
[Bug 19929] Add Koha Objects for class_source and class_sort_rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19915


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
[Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15937] Batch checkout buggy behavior

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937

Owen Leonard  changed:

   What|Removed |Added

 CC|gmcha...@gmail.com, |
   |oleon...@myacpl.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70375|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 70383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70383=edit
Bug 19938: Refactor checkoverdues

TEST PLAN
-
0) back up plack error log if you care.

1) Run these on your kohadevbox:
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
However, the log file will have noise.

2) Run these on your kohadevbox:
git bz apply 19938
restart_all
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
This time the log file will have no noise.

3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #3 from M. Tompsett  ---
Created attachment 70382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70382=edit
Bug 19938: Split C4/Members.pm to avoid conflict issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19942] New: Children's search interface

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942

Bug ID: 19942
   Summary: Children's search interface
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Would like to see an alternative OPAC search for patrons geared towards
children.  Something like this:

http://www2.hampton.lib.nh.us:8080/kids?config=default#/categories

It would be easy enough to customize searches, but it would be great to be able
to customize a background, and add big buttons to the search topics.  You will
notice that the general search bar at the top limits to children's materials,
and the layout of the results is EXTREMELY kid friendly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #2 from M. Tompsett  ---
This may conflict with 19933 which removes C4::Members::patronflags if 19933 is
pushed first. In which case, I believe removing C4/Member's from this patch
should be sufficient. I'll split.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15683] Inconsistent population of lastreneweddate between AddRenewal and AddIssue

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15683

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org
 Status|Needs Signoff   |Signed Off

--- Comment #6 from George Williams (NEKLS)  ---
Signed off based on video that Jesse put together for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19908] Password should not be mandatory

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908

Bob Ewart  changed:

   What|Removed |Added

 CC||bob-ew...@bobsown.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

--- Comment #5 from M. Tompsett  ---
Comment on attachment 70348
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70348
Bug 19933: Remove patronflags - In CanBookBeIssued

Review of attachment 70348:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19933=70348)
-

Nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |victor.grous...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13165] Active Hold Limit

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13239] MySQL Character encoding utf8

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

--- Comment #1 from Victor Grousset/tuxayo  ---
Everything come from here:
http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv;hb=94cd27677d8febd2979f9f618f1e8cd1bd2d68d7

3 templates with commas hardcoded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15019] Plack testing - Umbrella

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|geor...@latahlibrary.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13551] Add the ability to sort results on cataloguing (addbooks.pl)

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13551

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17031

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14373] Disallow payment of accruing fines

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

--- Comment #3 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #2)
> I am not sure I understand the changes, how can we know it will not
> introduce side-effects?
> Tests are missing.

The facets links are composed of an index and a value separated by ":", for
example su:History.
But real CCL syntax is index=value so ":" must be replaced by "=".
But actual code replaces all ":" even in value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] New: Acquisitions' CSV exports should honor syspref "delimiter "

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Bug ID: 19928
   Summary: Acquisitions' CSV exports should honor syspref
"delimiter"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victor.grous...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

1. Set syspref "delimiter" to "tabs"

2. Create a vendor with minimal info
3. Create a basket with minimal info
4. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=X
5. "Export as CSV"
6. You should see that the file contains commas "," This is the bug.

7. Create a basket group with minimal info
8. Close this basket group
9. Go to the "Closed" tab to see your basket group
10. "Export as CSV"
11. You should see that the file contains commas "," This is the bug.

12. Create a basket with minimal info
13. Add a item to the basket
14. Close the basket
15. Go to /cgi-bin/koha/acqui/lateorders.pl
16. "Export as CSV"
17. You should see that the file contains commas "," This is the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15038] Move BatchCheckoutsValidCategories into the categories table

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17031] Use delimeter system preference for Overdues report download

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19928

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940

--- Comment #1 from Jonathan Druart  
---
Created attachment 70381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70381=edit
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call

Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15521] Make circulation rules backend more granular

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC|gwilli...@nekls.org |geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14546] Make staff client templates responsive

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19932


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932
[Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging
Z39.50 search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2018-01-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #69820|0   |1
is obsolete||

--- Comment #39 from Alex Arnaud  ---
Created attachment 70335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
- From: 2017-10-09, To: 2017-10-15,
- Frequency: 1/day,
- 7 issues,
- test prediction pattern
- check Wednesday and Thursday as irregularity,
- save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
with corresponding serials

  - Do the same for a monthly and weekly subscription

Rebased - 2017-12-15 - Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 286 matches

Mail list logo