[Koha-bugs] [Bug 19951] New: ; Literary form: not translated on search results with de-DE installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951

Bug ID: 19951
   Summary: ; Literary form: not translated on search results with
de-DE installed
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: elias.deh...@thulb.uni-jena.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Created attachment 70420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70420=edit
Shows the bug

"; Literary form:" isn't translated on the search results when the german is
selected.

steps to reproduce:

1. install the german translation de-DE

2. switch to german on the opac

3. make a search for something (as long as it has a literary form)

4. on the results everything is translated except ; Literary form:

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Ed Veal  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Candice Hope  changed:

   What|Removed |Added

 CC||candi...@payson.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||dependency

--- Comment #7 from Katrin Fischer  ---
Should we set this to In discussion or failed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

--- Comment #7 from Christopher Brannon  ---
This is in desperate need of attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19948] Rest API documentation is out of date in Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
https://koha-community.org/manual/17.11/en/html/17_miscellaneous.html?highlight=rest#rest-services
 

is not about our current implementation but about a patch/scripts Biblibre
provided in the past to implement a REST API for Koha.

I suggest removing that paragraph as Koha's REST API is still being developed
and it will be hard to keep up with changes. Fast changing technical
documentation seems better suited for the wiki atm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Katrin Fischer  changed:

   What|Removed |Added

  Comment #8 is|1   |0
private||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #17 from Katrin Fischer  ---
is_found is also a bit confusing, because this also includes transit items.
found = F in the reserves table is for waiting. So you might not think about
the transit items as well immediately. It confused me on testing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #16 from Jonathan Druart  
---
Yes Barton you are right, that's why I added a comment to the POD of the method
to tell it only applies for the OPAC.
Maybe rename the method to something more verbose (is_cancelable_from_opac) to
remove the ambiguity?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70398|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10821] label pdf adding in strange breaking

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #15 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #14)
> Kyle, Katrin and Marcel, could you take a look at this l
> ast patch?
> It sounds better to me to keep the method and fix its behaviour instead of
> testing is_found that can be confusing. Feel free to obsolete it if you
> disagree and I will pushed Kyle's patches with a follow-up to remove the
> method and the tests.

The problem with 'is_cancelable' is that staff and opac have different views of
whether the item is cancelable or not, whereas is_found is un-ambiguous.

is_cancelable *sounds* like it's clearer because it signals its intent, but
under the circumstances, I think 'is_found' is better.

Just my humble opinion; I'm also probably missing context because I haven't
taken the time to read the code, so take my words with a large grain of salt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19644] When editing items Tag editor [ellipses (...)] by date accessioned is non functional

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19644

J Schmidt  changed:

   What|Removed |Added

 CC||jpal...@switchinc.org,
   ||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

--- Comment #7 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #5)
> 3. I guess it is just my undestanding of CAS that is bad but why do we call
> get_session then delete it? 
> Is cas_ticket == sessionID?

And of course it's not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Passed QA

--- Comment #4 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #26 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #14 from Jonathan Druart  
---
Kyle, Katrin and Marcel, could you take a look at this l
ast patch?
It sounds better to me to keep the method and fix its behaviour instead of
testing is_found that can be confusing. Feel free to obsolete it if you
disagree and I will pushed Kyle's patches with a follow-up to remove the method
and the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70398|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 70419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70419=edit
[ALTERNATIVE-PATCH] Bug 18856: Don't show cancel option for waiting holds in
OPAC

This is the alternative patch of Kyle's
"""
If a hold is 'waiting' for the patron to collect then the patron should
be prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure'
alert and when you click Yes the page just refreshes and the hold
remains.
Staff can cancel the hold from the staff interface but they can then
action the waiting hold.
I think therefore that it is correct behaviour that a patron cannot
cancel a hold when it reaches waiting state via the opac but it would be
useful to either have a warning to prevent the cancellation or a useful
message when they attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a
hold,
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds
"""

It sounds better to keep the ->is_cancelable method, for readability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

--- Comment #6 from Chris Cormack  ---
(In reply to Jonathan Druart from comment #5)

> 
> Another one: from the pod of CGI::Session->find :
> "Experimental feature.
> Note: find() is meant to be convenient, not necessarily efficient. It's best
> suited in cron scripts."

Yes, but it is still a lot faster than opening every session and checking them
all by hand.
It's only called when a user logs out of another application other than Koha,
and only by the CAS server, never by the user. So it is essentially a
background process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
I am not going to test this patch, but I would like to make sure the changes
make sense.

1. I do not understand the code in opac-user.pl, why is it here? It sounds like
it will be better at its place in C4::Auth.

2. You should move out get_session the code you copy/pasted from there

3. I guess it is just my undestanding of CAS that is bad but why do we call
get_session then delete it? 
Is cas_ticket == sessionID?

Side note: it will not work if SessionStorage=memcached (but we should remove
that), CGI::Session::Driver::memcached->traverse does nothing.

Another one: from the pod of CGI::Session->find :
"Experimental feature.
Note: find() is meant to be convenient, not necessarily efficient. It's best
suited in cron scripts."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950

--- Comment #1 from Owen Leonard  ---
Created attachment 70418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70418=edit
Bug 19950: Update popup window templates to use Bootstrap grid: Serials

This patch updates the two serials templates to use the Bootstrap grid
instead of the YUI grid.

Apply the patch and go to Serials and locate an existing
subscription.

- Click the "Edit routing list" in the sidebar.
- Save the routing list, and click "Save and preview routing slip."
- The routing slip preview should look correct and buttons should work
  correctly.

- When viewing the details of a subscription, click the "Renew" button
  in the toolbar. The popup window should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19950] New: Update popup window templates to use Bootstrap grid: Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950

Bug ID: 19950
   Summary: Update popup window templates to use Bootstrap grid:
Serials
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19931

This bug falls under the omnibus Bug 19931, "Update popup window templates to
use Bootstrap grid." Updated in this patch will be routing-preview-slip.tt
(Routing slip preview) and subscription-renew.tt (Subscription renew).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931
[Bug 19931] Update popup window templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19950


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950
[Bug 19950] Update popup window templates to use Bootstrap grid: Serials
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

--- Comment #1 from Owen Leonard  ---
Created attachment 70417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70417=edit
Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging
authority search

This patch updates the cataloging authority search templates to use the
Bootstrap grid instead of the YUI grid.

To test you must have a MARC subfield configured with "Thesaurus"
linked to an authority type.

Apply the patch and go to Cataloging -> New record. Click the plugin
link for the field which is linked to authorities. In the popup window,
the search form and search results should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #22 from Nick Clemens  ---
Created attachment 70416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70416=edit
Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #21 from Nick Clemens  ---
Created attachment 70415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70415=edit
Bug 19166: DO NOT PUSH - Schema updates

Included to ease testing :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #20 from Nick Clemens  ---
Created attachment 70414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70414=edit
Bug 19166 - Add the ability to add adjustments to an invoice

This patchset adds the ability to add adjustments to an invoice, one can
provide a reason, an adjustment amount, select a budget, and choose
whether to encumber the funds before the invoice is closed or not

To test:

1 - Create a new invoice with or without a shipping cost
2 - Note there are no existing adjustments
3 - Add an adjustment
4 - Submit the form withno changes, nothing happens
5 - Update the adjustment you created, ensure changes are saved but no
extra adjustment created
6 - Add another invoice prodiving only reason or amount (you can have 0
value adjustments)
7 - Verify the adjustment total at bottom is correct
8 - Recieve some orders
9 - Verify totals are correct

Conflicts:
C4/Budgets.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67599|0   |1
is obsolete||
  Attachment #67600|0   |1
is obsolete||
  Attachment #67602|0   |1
is obsolete||
  Attachment #67890|0   |1
is obsolete||

--- Comment #19 from Nick Clemens  ---
Created attachment 70413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70413=edit
Bug 19166 - Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

--- Comment #6 from rkui...@roundrocktexas.gov ---
The bug is problematic for our staff and patrons.  Need to limit to items that
are actually available for loan excluding checked out, damaged, or not for
loan.  There is a related bug 9810 that has some work being done on it.  It is
currently in 'FailedQA' status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949
[Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging
authority search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949
[Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging
authority search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19949] New: Update popup window templates to use Bootstrap grid: Cataloging authority search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Bug ID: 19949
   Summary: Update popup window templates to use Bootstrap grid:
Cataloging authority search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 19786
Blocks: 19931

This bug falls under the omnibus Bug 19931, "Update popup window templates to
use Bootstrap grid." Updated in this patch will be auth_finder.tt and
searchresult-auth.tt, the templates for cataloging authority searches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786
[Bug 19786] Move template JavaScript to the footer: Authorities, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931
[Bug 19931] Update popup window templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Christopher Davis  changed:

   What|Removed |Added

 CC||cgda...@uintah.utah.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19948] Rest API documentation is out of date in Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19948] New: Rest API documentation is out of date in Koha manual

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948

Bug ID: 19948
   Summary: Rest API documentation is out of date in Koha manual
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The 'REST services' documentation does not fit the current implementation of
the koha rest API.

For instance, the documentation shows a 'user' endpoint:

GET user/byid/:borrowernumber/holds
GET user/:user_name/holds
GET user/byid/:borrowernumber/issues
GET user/:user_name/issues
GET user/:user_name/issues_history
GET user/byid/:borrowernumber/issues_history
GET user/today
GET user/all
POST user

But the endpoint implemented in api/v1 is "patrons", e.g.

https://intranet.bywatersolutions.com/api/v1/patrons/221

The best current documentation that I'm aware of is

https://wiki.koha-community.org/wiki/REST_api_RFCs

It would be nice to build this documentation via api/v1/spec

see also bug 17694

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947

--- Comment #1 from Owen Leonard  ---
Created attachment 70412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70412=edit
Bug 19947: Update popup window templates to use Bootstrap grid: Acquisitions
transfer order

This patch updates the acquisitions transfer order template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Corrected footer include for popup window.

To test, apply the patch and go to Acquisitions -> Vendor -> Open order
-> Transfer.

In the popup window search for a vendor, select, and choose a basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19947] New: Update popup window templates to use Bootstrap grid: Acquisitions transfer order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947

Bug ID: 19947
   Summary: Update popup window templates to use Bootstrap grid:
Acquisitions transfer order
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 19755
Blocks: 19931

This bug falls under the omnibus Bug 19931, "Update popup window templates to
use Bootstrap grid." Updated in this patch will be transferorder.tt, the
template for transferring an order from one vendor to another in acquisitions.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755
[Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931
[Bug 19931] Update popup window templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19947


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947
[Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions
transfer order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19947


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947
[Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions
transfer order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Christopher Brannon  changed:

   What|Removed |Added

   Severity|enhancement |major
 CC||cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19917] Holds for self registered patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19917

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19942] Children's search interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

--- Comment #1 from Owen Leonard  ---
Created attachment 70411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70411=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search

This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Some capitalization corrections, better 
handling. This patch does not fix Bug 17119.

To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937

Lee Jamison  changed:

   What|Removed |Added

  Attachment #70364|0   |1
is obsolete||

--- Comment #2 from Lee Jamison  ---
Created attachment 70410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70410=edit
Bug 19937: Silence warnings t/db_dependent/www/batch.t

TEST PLAN
-
1) Run the following on a kohadevbox:
git checkout -b bug_19937 origin/master
sudo koha-shell -c bash kohadev
prove t/db_dependent/www/batch.t
cat /var/log/koha/kohadev/plack-error.log

The following errors are triggered at the end of the log file:
Use of uninitialized value in array element at
/home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50.
Use of uninitialized value $results_per_page in numeric eq (==) at
/home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53.
Use of uninitialized value in uc at
/home/vagrant/kohaclone/C4/ImportBatch.pm line 1120.

2) Run the following on a kohadevbox:
exit
git bz apply 19937
restart_all
sudo koha-shell -c bash kohadev
prove t/db_dependent/www/batch.t
cat /var/log/koha/kohadev/plack-error.log

The log file will end with the restarting of plack, not the
errors.

3) run koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19946] New: Update popup window templates to use Bootstrap grid: Authority Z39.50 search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Bug ID: 19946
   Summary: Update popup window templates to use Bootstrap grid:
Authority Z39.50 search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 19931

This bug falls under the omnibus Bug 19931, "Update popup window templates to
use Bootstrap grid." Updated in this patch will be z3950_auth_search.tt, the
template for Z39.50 searches from the authorities interface.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931
[Bug 19931] Update popup window templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946
[Bug 19946] Update popup window templates to use Bootstrap grid: Authority
Z39.50 search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Alex Arnaud  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

--- Comment #1 from Alex Arnaud  ---
Created attachment 70409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70409=edit
Bug 19945 - ILSDI - Return the reason a reserve is impossible

Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=1_id=1_id=1)
 - you should get the reason instead of NotHoldable,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #66306|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 70408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70408=edit
Bug 19160 CAS Single logout

CAS supports single logout, where if you logout of one application it
logs you out of all of them.

This bug implements this

You will need a CAS server (with single logout configure),
and at least 2 applications (one being Koha)

1/ In Koha login via CAS
2/ Login to the other application via CAS
3/ Logout of the other application
4/ Notice you are still logged into Koha
5/ Log out of Koha
6/ Apply patch
7/ Login to Koha via CAS, login to other app via CAS
8/ Log out of other app
9/ Notice you are logged out of Koha

If you dont have CAS, this patch should be a no op, you could test that
1/ Login and logout normally
2/ Apply patch
3/ Login and logout still work fine

Signed-off-by: Katrin Fischer 
Patch works as described, local login still works correctly.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud  changed:

   What|Removed |Added

  Attachment #69783|0   |1
is obsolete||

--- Comment #6 from Hugo Agud  ---
Created attachment 70404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70404=edit
Bug 19804: Add new DB column issuingrules.suspension_chargeperiod

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud  changed:

   What|Removed |Added

  Attachment #69784|0   |1
is obsolete||

--- Comment #7 from Hugo Agud  ---
Created attachment 70405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70405=edit
Bug 19804: DBIC Schema changes

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud  changed:

   What|Removed |Added

  Attachment #69786|0   |1
is obsolete||

--- Comment #9 from Hugo Agud  ---
Created attachment 70407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70407=edit
Bug 19804: Add the new column to the circ rules interface

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud  changed:

   What|Removed |Added

  Attachment #69785|0   |1
is obsolete||

--- Comment #8 from Hugo Agud  ---
Created attachment 70406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70406=edit
Bug 19804: Add a 'Fine charging interval' for suspension days

We already have a chargeperiod (Fine charging interval) value which is
taken into account for fine ($) for not for the suspension period.

This patch adds a new column suspension_chargeperiod (Fine day charging
interval) to add the same behaviour when a suspension is calculated.

Test plan:
Add overdue item and play with the circulation rules (and the calendar).
The suspension period must be correctly calculated.
Please provide the different tests you made.

Signed-off-by: Hugo Agud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

--- Comment #11 from sandbo...@biblibre.com  ---
Created attachment 70402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70402=edit
Bug 19801 - Display messages on user details page as well as on Check Out page

To test:

Look up a borrower, add a message (internal or opac)
Click the Details tab for that borrower
Messages should be displayed above the user information [is this the right
place? it could go below]
adding messages on this page should make them immediately available
deleting messages on this page should delete them immediately and bring you
back to the detail page.

Basically, make sure messages work from both the Check out and detail pages and
that there are no typos.

Messages should work the same as they always have from the Check Out page.

sponsored-by: Catalyst IT
Signed-off-by: Simon Pouchol 

Signed-off-by: Marjorie Vila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

--- Comment #12 from sandbo...@biblibre.com  ---
Created attachment 70403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70403=edit
Bug 19801 - Fixes for QA

- Fixes indentation
- changes messages to patron_messages (even though it's not like that on the
circulation page.)

Signed-off-by: Marjorie Vila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70239|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #69798|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Marjorie Vila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #9 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #8)
> "Bug 19938: Split C4/Members.pm to avoid conflict issues"
> 
>  => What does it mean?

because 19933 might trigger a conflict in C4/Members with the removal of
patronflags, so put the possible conflict area elsewhere. I split it from a
single commit, so as to avoid the conflict as needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19801] Internal note added to the detail's user page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] Add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

--- Comment #7 from Kyle M Hall  ---
4) Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] Add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

--- Comment #6 from Jonathan Druart  
---
So... once and for all: new subroutines cannot be added to the C4 namespace and
you have to provide test coverage.
We are moving the code from C4 to Koha, so I will not accept more subroutines
to C4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] Add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Kyle M Hall  ---
Needed to pass qa:
1) Implement use of Account Offsets. Any change to a fee or payment needs to
add to the account offsets table from now on. The point of it is to create a
full accounting of all changes to accountlines

2) Add a user permission for this functionality

3) Implement using Koha::Account::Line(s)/Offset(s) instead of using direct SQL
queries. These new subs should live in Koha::Account::Line since they are
operating on individual accountlines. We need to reduce the number of subs in
the C4 namespace instead of adding to them ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
The price formatting must be done template side, search for '$Price' or '[% USE
Price %]' in **/*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

--- Comment #3 from Jonathan Druart  
---
Why did not you choose to use patron-title.inc?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] Add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.bourga...@inlibro.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Price diplay on a   |Price display on a
   |basketgroup |basketgroup

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
This is too specific, we should provide a generic way to do that.
The prefix code should be a parameter of the script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
Note: You will need the python3 version of vdebug if you are running python3:
https://github.com/markkimsal/vdebug/tree/python3
(which does not work really well)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964

Jonathan Druart  changed:

   What|Removed |Added

Summary|koha-plack should have a|Add a --debugger flag to
   |--debugger switch   |koha-plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #5 from Hugo Agud  ---
Good morning

I have insall the patch into kohadev, I have checked out and checked in several
items with different configuration and it works.. 

I have created a rule of 1 suspension day for every 2 delay

Case 1
Cumulative on
Calendar without holidays--> works as espected
Calendar with holiday -->  work as expected


Cumulative off
Calendar without holidays --> works as expected
Calendar with holidays -->  works as expected

I missed something to check, if not I will sign it asap

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65318|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 70401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70401=edit
Bug 18964: Add --debugger option to koha-plack

CAVEAT: This patch is only about allowing koha-plack to start a debugging
session on a remote target. Configuring all the needed pieces to make it
work is out of the scope of the bug. Testing should be focused (mainly) on
making sure this introduces NO REGRESSIONS on regular use (i.e. not debugging).

This patch adds the following option switches to koha-plack:

--debugger
--
Toggle debugging

--debugger-key
--
Some IDEs require a key, this needs to match because they are picky about it

--debugger-location
---
This option switch is used to specify the host:port your IDE is listening at.
Inside kohadevbox (using Vdebug with Vim) this would be localhost:9000. Outside
kohadevbox it would be 192.168.50.1:9000

--debugger-path
---
This is the path in which you installed the Komodo Remote Debugger library [1].
In kohadevbox
you could put the contents of the downloaded .tar.gz in
/home/vagrant/dbgp/perllib. That
perllib seems to be required for things to work [2].

You can test with a simple CLI script things work:

PERL5LIB=/home/vagrant/dbgp/perllib:$PERL5LIB \
PERLDB="BEGIN { require q(/home/vagrant/dbgp/perllib/perl5db.pl) }" \
PERLDB_OPTS="RemotePort=192.168.50.1:9000" perl -d t/Prices.t

If you see action on your IDE, you are on the right track on the IDE side.

To test:
- Apply this patch
- Enable remote debugging on your IDE, on port 9000 (or adjust the command
  below to match your IDE's listening port).
- Download the Komodo Remote Debugger package, and place the package's contents
  in /home/vagrant/dbgp/perllib (you should see perl5db.pl in there).
- Run:
  $ sudo koha-plack --stop kohadev
  $ sudo kohaclone/debian/koha-plack --start \
 --debugger \
 --debugger-path /home/vagrant/dbgp/perllib
\
 --debugger-location 192.168.50.1:9000 \
 kohadev
=> SUCCESS: You IDE/tool gets a connection from the Plack process.
- Sign off :-D

The explanation on how to use it assumes you are running kohadevbox.

WARNING: The main difficulty I found was setting the right dir/file mappings.

[1] http://code.activestate.com/komodo/remotedebugging/
[2] https://github.com/Komodo/KomodoEdit/issues/644#issuecomment-236268012

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

--- Comment #3 from Katrin Fischer  ---
We have since used these patches successfully in production for several months,
at first as a backport to 3.22, now in 16.11. No issues so far.
The CAS logout will only happen if the CAS server is set up to sent a logout
request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #25 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #22)
> Can we rename commit with confirm? We use commit 3x in misc instead of 8x
> for confirm.

Yes we can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #24 from Marcel de Rooy  ---
Created attachment 70400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70400=edit
Bug 18071: (QA follow-up) Rename commit to confirm parameter

Trivial edit.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #60 from Katrin Fischer  ---
I think for this bug an option to switch between Any and Anywhere would be
good. Then for existing installations keep the current behaviour and for new
installations (default setting) use the 'smaller' index. The custom one is
definitely for a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213

Josef Moravec  changed:

   What|Removed |Added

 QA Contact||josef.mora...@gmail.com
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #15 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #13)
> Can we have a patch for the manual please? :)

Does the Manual keyword trigger someone of the Documentation team to do so?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #78 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #77)
> Also, when I see:
> @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { 
> 
>  }
> 
>  return $any_available ? 0 : 1; 
> 
> +} else { # on_shelf_holds == 0 "If any unavailable" (the description is
> rather cryptic and could still be improved)
> +return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber}
> );  
> 
>  }
> -
> -if ($item->{onloan}) { 
> 
> -return 1;  
> 
> -}  
> 
> -
> -if ( Koha::Holds->search({itemnumber => $item->{itemnumber},   
> 
> -  found => ['W', 'T']})->count ) { 
> 
> -return 1;  
> 
> -}   
> 
> Then:
> +sub hasItemswaitingOrInTransit {
> +my ( $self ) = @_;
> +
> +if ( Koha::Holds->search({ biblionumber => $self->id,
> +   found => ['W', 'T'] })->count ) {
> +return 1;
> +}
> 
> I am pretty sure something is wrong.

It might be helpful to explain what you think is wrong. You are comparing
pieces of code here that have different goals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #8 from Jonathan Druart  
---
"Bug 19938: Split C4/Members.pm to avoid conflict issues"

 => What does it mean?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #0)
> While retesting a bug, I ran a prove -r -v t, which generated a lot of log
> noise. One such entry was:
> [Tue Jan  9 03:54:58 2018] starman: Use of uninitialized value
> $overdues_count in numeric gt (>) at
> /home/vagrant/kohaclone/opac/opac-main.pl line 76.

Prove generated a log entry from opac-main.pl? How?

https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/console

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Josef Moravec  ---
Please, squash the patches and ask for new sign-off, it's completely different
code now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18757] Problem when importing only items in MARC records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #6 from Fridolin SOMERS  ---
I set back to NSO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/