[Koha-bugs] [Bug 20048] koha-zebra missing --status

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048

--- Comment #1 from M. Tompsett  ---
Created attachment 70757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70757=edit
Bug 20048: --status shell command line check missing

TEST PLAN
1) Run the following commands
git checkout -b bug_20048 origin/master
sudo perl ~/misc4dev/cp_debian_files.pl
sudo koha-zebra --status kohadev
   -- Will get error message
2) Run the following commands
git bz apply 20048
sudo perl ~/misc4dev/cp_debian_files.pl
sudo koha-zebra --status kohadev
   -- Will not get error message, but actual status
3) NOTE: Koha QA Test tools do not check bash scripts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047

--- Comment #1 from Nick Clemens  ---
Created attachment 70756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70756=edit
Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count

To test:
1 - prove t/db_dependent/Koha/Z3950Servers.t
2 - Load cataloging and authority home pages
3 - Verify you can add form z395 on each page
4 - Delete all z3950 servers
5 - Verify option to add from Z3950 is removed on both pages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19965] 008 tag editor not showing completely

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965

--- Comment #3 from Hussain A  ---
Created attachment 70755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70755=edit
java problem for 008 tag editor

Dear Katrin Fischer, 
Thank you for your response
As you indicated, the problem is seems to be from the Java, or whatever it is,
do you have any suggestions to resolve this issue?
Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20048] New: koha-zebra missing --status

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048

Bug ID: 20048
   Summary: koha-zebra missing --status
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com

Running a koha-zebra --status kohadev told me --status was an invalid option.
Turns out the option was forgotten to be added around line 225.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Nick Clemens  changed:

   What|Removed |Added

 Blocks||20047


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047
[Bug 20047] Add Z3950Server Object and use it for getting server count
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19987
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987
[Bug 19987] If no z39.50/SRU servers, the z39.50/SRU buttons should not show
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20047] New: Add Z3950Server Object and use it for getting server count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047

Bug ID: 20047
   Summary: Add Z3950Server Object and use it for getting server
count
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20046] New: Change configuration of the authorities z39.50 search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20046

Bug ID: 20046
   Summary: Change configuration of the authorities z39.50 search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: patrick.robitai...@collecto.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi,

It would be nice if the search form for the z39.50 authorities search would be
revised. The principle of this form could be reversed completely. at the
moment, the informations must be entered in the field corresponding to the type
of authority we are looking for. It could be only a form with two fields.The
first one would be for enter the information and the other one for choose the
type of authority. 

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70744|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 70754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70754=edit
Bug 19987: If no z39.50/SRU servers the button should not show

Test plan:
[1.] Load the patch and make sure you have some Z39.50/SRU servers
 (Administration => Z39.50/SRU servers administration)
[2.] Then go to authorities and notice that the 'New from
 Z39.50/SRU' button is there
[3.] Next go to cataloging and notice that the 'New from Z39.50/SRU'
 button is there too
[4.] Now make sure you have no Z39.50/SRU servers (remove the
 servers)
 (Administration => Z39.50/SRU servers administration)
[5.] Go to authorities and notice that the 'New from Z39.50/SRU'
 button is not there
[6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU'
 button is not there too

:)

Signed-off-by: Owen Leonard 

I added a missing [% END %] during signoff. Hope no one minds!

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15770] Number::Format issues with large numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #38 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #37)
> (In reply to Séverine Queune from comment #35)
> > Did I miss a dependency ? The patch doesn’t seem to apply.
> 
> It applied correctly here, could you test again with this rebased version?

New patch applies correctly.

- with "Allow and notify" option, I get this sotware error :
Undefined subroutine ::Members::GetNoticeEmailAddress called at
/home/koha/src/circ/pendingreserves.pl line 95.

- "Mark as lost" works well : hold is cancelled, the fields set in the syspref
are correctly updated (and when I choose itemlost is changed, itemlost_on is
"timestamped" (can I say it ?)).

Cancellation is blocked with this 2 options if hold is placed on biblio.

- with the syspref set to "Do not allow", I only see the usual option "Cancel
hold".



(In reply to Katrin Fischer from comment #31)
> Why the holds awaiting pickup list? That would mean, you got the book for
> the patron, you checked it in, you sent the email notice to the patron and
> THEN you notice it's actually not there... ? Wouldn't it make more sense to
> this from the holds queue or holds to pull pages that you use when looking
> for the item?

That was definetly a good idea to use the "Holds to pull" list, thank you
Katrin !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20045] New: Switch single-column templates to Bootstrap grid: Various

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045

Bug ID: 20045
   Summary: Switch single-column templates to Bootstrap grid:
Various
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: dc...@prosentient.com.au, josef.mora...@gmail.com,
misi...@fit.edu, neng...@gmail.com,
testo...@bugs.koha-community.org
Blocks: 19980

This patch will convert several unrelated templates to use the Bootstrap grid:

- about.tt
- auth.tt
- serials/subscription-add.tt
- admin/admin-home.tt
- reports/reports-home.tt
- suggestion/suggestion.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15770] Number::Format issues with large numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

M. Tompsett  changed:

   What|Removed |Added

  Attachment #69982|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 70753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70753=edit
Bug 15770: Do not format numbers if too big

At several places we got the following error if we use numbers too big
for Number::Format
Template process failed: undef error - round() overflow. Try smaller
precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44

It make the app explodes.
The goal here is to handle these errors gracefully and easily.

Test plan:
- Add a manual fine to a patron of 100
- Create a patron category with an enrolment fee of 123456789012345

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20045


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045
[Bug 20045] Switch single-column templates to Bootstrap grid: Various
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70741|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 70752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70752=edit
Bug 20042: 00-load.t fails when Elasticsearch is not installed

00-load.t fails when Elasticsearch is not installed. Blocks packaging.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

--- Comment #1 from Owen Leonard  ---
Created attachment 70751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70751=edit
Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging

This patch updates several cataloging module templates to use the
Bootstrap grid.

- cataloguing/addbooks.tt - Cataloging - The main page and the
  cataloging search results page should look correct.

- cataloguing/addbiblio.tt - Cataloging -> New record - The record edit
  page should look correct.

- cataloguing/merge.tt - Cataloging -> Search -> Select two records to
  merge. The merge reference selection page should look correct, as well
  as the source/destination selection page.

- cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit ->
  Attach item. The barcode submit form and confirmation screens should
  look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED
 QA Contact|n...@bywatersolutions.com   |testo...@bugs.koha-communit
   ||y.org

--- Comment #27 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #25)
> This works as advertised, however see bug 19910
> 
> If we are going to honor the delimiter pref, I think we need to use it in
> displaying what format will be downloaded.
> 
> Want another QA opinion here

Agreed, please see the changes made on bug 19910 and add the info here too.
You can then switch back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70698|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 70750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70750=edit
Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter"

Bonus fixes:
- Basketgroup: there was an unnecessary space.
  " RRP tax excluded" replaced by "RRP tax excluded"
- Late orders:
  - leading spaces before every line
  - surrounding spaces for [% orders.size %]

Other changes:
- quoted "Total orders in late" to no worry about additional spaces
- Late orders: additional spaces which shouldn't be a problem because
  all the fields are enclosed by quotes.

Test plan:
1. Set syspref "delimiter" to "#'s"
2. Change the language e.g. FR-fr

3. Create a vendor with minimal info
4. Create a basket with two items
5. Go to the basket. URL should be
   /cgi-bin/koha/acqui/basket.pl?basketno=X
6. Close this basket
7. "Export as CSV"
8. You should see that the file contains commas "," This is the bug.
   Leave the file open for future comparison to ensure that there are
   no regressions.

9. Create a basket group with two baskets
   (tick the close this basket group check box)
10. Go to the "Closed" tab to see your basket group
11. "Export as CSV"
12. You should see that the file contains commas "," This is the bug.
Leave the file open for future comparison to ensure that there are
no regressions.

13. Go to /cgi-bin/koha/acqui/lateorders.pl
14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick
orders of different vendors.
15. "Export as CSV"
16. You should see that the file contains commas "," This is the bug.
Leave the file open for future comparison to ensure that there are
no regressions.

17. Apply this patch
18. Translation stuff
1. cd misc/translator
2. perl translate update YOUR_LANG
3. manually edit the po file, remove the fuzzy tags.
   And translate the string. You can just copy the original and
   replace some parts by gibberish.
4. perl translate install YOUR_LANG

19. Re-export the same CSVs and compare with the original version to check that
- delimiter syspref is honored
- the headers are translatable
- there is no whitespace regression (additional newlines or spaces)

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20044


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
[Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] New: Switch single-column templates to Bootstrap grid: Cataloging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

Bug ID: 20044
   Summary: Switch single-column templates to Bootstrap grid:
Cataloging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

There are several single-column cataloging templates which can be updated to
use the Bootstrap grid.

- cataloguing\addbiblio.tt
- cataloguing\addbooks.tt
- cataloguing\merge.tt
- cataloguing\moveitem.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70703|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 70749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70749=edit
Bug 19977: Open only .pref files in Local Use tab (sysprefs)

Test plan:
1. Open .../prog/en/modules/admin/preferences/circulation.pref
with vim (check that it creates a .circulation.pref.swp in the same
directory)
2. Go to the "Local Use" tab in admin/systempreferences.pl
3. Confirm that the page works normally

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |In Discussion

--- Comment #25 from Nick Clemens  ---
This works as advertised, however see bug 19910

If we are going to honor the delimiter pref, I think we need to use it in
displaying what format will be downloaded.

Want another QA opinion here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038

--- Comment #1 from Owen Leonard  ---
Created attachment 70748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70748=edit
Bug 20038: Switch single-column templates to Bootstrap grid: Acquisitions

This patch updates several acquisitions module templates to use the
Bootstrap grid.

- acqui/z3950_search.tt - Acquisitions -> Vendor -> View basket -> Add
  to basket -> From an external source. The Z39.50 search form should
  look correct.
  - Search for a title. The search results page should look correct.

- acqui/addorder.tt - Acquisitions -> Vendor -> View basket -> Add to
  basket. Add an order to the basket which costs more than is available
  in the fund you select. The error/confirmation screen should look
  correct.

- acqui\modordernotes.tt - Acquisitions -> Vendor -> View basket -> Add
  internal or vendor note. The note add form should look correct.

- acqui/cancelorder.tt - Acquisitions -> Vendor -> View basket -> Cancel
  order (from an open basket which has existing orders). The
  confirmation screen should look correct.

- acqui\basketheader.tt - Acquisitions -> Vendor -> New basket. The new
  basket edit form should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755

Owen Leonard  changed:

   What|Removed |Added

 Blocks||20038


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038
[Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755
[Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #19 from Séverine Queune  ---
Hi Jonathan, 

Nicolas applied this morning the patch in our local instance, and everything
seems to work as expected, except that we don't have any more warnings if
required fields are empty, and the order is saved.

I just tried once again in Biblibre's sandbox#2 and behaviour is the same.
I'm really sorry I didn't notice it during my tests, it's not logical for me to
try to save a form without the required fields so I didn't think about testing
it.

Do you need a new bug report ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Would be better to fix, but I didn't see the problem in a quick look. This
prevents the error for user so PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #98 from M. Tompsett  ---
Comment on attachment 69050
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050
Bug 11879: Follow-up - Streamline markup and make label corrections

Review of attachment 69050:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69050)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +293,5 @@
> +Secondary email
> +[% CASE 'fax' %]
> +Fax
> +[% END %]
> +

This is nicer and friendlier on the po files, I'm sure. I believe it was done
the other way because of a misunderstanding of HTML 1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates). The
SWITCH isn't allowed inside HTML tags, that is  is really
bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70528|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 70746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70746=edit
Bug 16603: When processing uploaded offline circulation file, "apply directly"
option fails

This patch is a temporary mitigation of whatever the real problem is.
The patch hides the "Apply directly" button so that the option isn't
available.

To test, apply the patch and generate a .koc file with some
transactions. Upload the file via Circulation -> Offline
circulation file upload. After the file is uploaded, you should see only
a "Add to offline circulation queue" button, which should work
correctly.

Signed-off-by: Grace Smyth 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

--- Comment #4 from Nick Clemens  ---
Created attachment 70747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70747=edit
Bug 16603: (QA Follow-up) Add a FIXME

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

--- Comment #14 from Katrin Fischer  ---
Some first feedback: We successfully tested the patches on our 16.11.x branch,
but want to run some more tests. So far it's looking good!

We will try to sign off before end of January.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #97 from M. Tompsett  ---
Comment on attachment 69029
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029
Bug 11879: Changes to Koha's schemas

Review of attachment 69029:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69029)
-

None of these have lastseen, as mentioned in the other patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #96 from M. Tompsett  ---
Comment on attachment 69028
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028
Bug 11879: Add the "Main contact method" field in borrower informations.

Review of attachment 69028:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69028)
-

::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql
@@ +1,2 @@
> +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL 
> DEFAULT NULL AFTER `lastseen`;
> +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` 
> VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`;

deletedborrowers and borrowers should maintain the same field order.

::: installer/data/mysql/kohastructure.sql
@@ +1682,4 @@
>`lang` varchar(25) NOT NULL default 'default', -- lang to use to send 
> notices to this patron
>`login_attempts` int(4) default 0, -- number of failed login attemps
>`overdrive_auth_token` text default NULL, -- persist OverDrive auth token
> +  `lastseen` datetime default NULL, -- last time a patron has been seed 
> (connected at the OPAC or staff interface)

This adds lastseen, but the borrowers_primary_contact_method did not add it at
all.

::: installer/data/mysql/updatedatabase.pl
@@ +14968,4 @@
>  }
>  }
>  
> +

Totally not necessary to touch this.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +538,5 @@
>  
>  [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && 
> nofax %]
>
> +Contact
> +

Keep whitespace changes separate.

@@ +602,4 @@
> [% IF ( mandatoryemailpro ) %] class="required">Required[% END %]
>  
>  [% END %]
> +[% UNLESS nofax %]

Keep whitespace changes separate.

@@ +664,5 @@
> +[% END %]
> + [% END %]
> +   
> +
> +

This is the only place where you can really get away with these minor
whitespace changes on the END and /ol.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +275,5 @@
> +[% ELSE %]
> +[% guarantor.firstname | html %] [% guarantor.surname | html 
> %]
> +[% END %]
> +
> +[% END %]

Where did this ELSIF clause come from?! This has nothing to do with
primary_contact_method.

::: opac/opac-memberentry.pl
@@ +93,5 @@
>  libraries => \@libraries,
>  OPACPatronDetails => C4::Context->preference('OPACPatronDetails'),
>  );
> +my 
> $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField");
> +my @field_check=split(/\|/,$check_BorrowerMandatoryField);

Something is strange about this indentation. I would expect the same
indentation level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70695|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 70745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70745=edit
Bug 19771: Fix crashing in pending offline circulation actions list

When the barcode is empty or invalid, an "Internal Server Error"
is triggered on the kohadev box.

TEST PLAN
-
0) back up your database if you care about it.
1) Run the following commands:
git checkout master
git pull
git checkout -b bug_19771 origin/master
git bz apply 19771
   -- This should be quite uneventful. Standard promptings.
2) Continue to run the following commands:
git checkout master
reset_all
sudo koha-shell -c bash kohadev
./misc/cronjobs/create_te_koc_db.pl --sqlite3
   -- This will create a borrowers.db in your current directory.
3) On the host where you intend on running the koct install it.
   -- https://sourceforge.net/projects/koha-oc/files/
  download and install.
4) get the borrowers.db file to your host where you installed koct
5) point koct at the file you downloaded
   Database -> Select Borrowers DB File
6) Create a .koc file with the following transactions.
check in, check out, check in (bad barcode),
pay fines (any non-zero amount).
7) Run the following commands:
restart_all
   -- we want to make sure caching for plack isn't in the way.
8) In the staff client: Home -> Circulation
-> Upload offline circulation file (.koc)
9) Choose the file created and click 'Upload file'.
10) Add to offline circulation queue.
11) View pending offline circulation actions
-- This should die. Reading /var/log/koha/kohadev/plack-error.log
   should be the same error as comment #0.
   However, this was only the bad biblio error.
12) Run the following commands:
git checkout bug_19771
restart_all
13) Refresh staff client page.
-- it should all come up.
14) Select the bad biblio line, and delete it.
15) Run the following commands:
git checkout master
restart_all
16) Refresh the staff client page.
-- it should die. Same error as comment #0.
   This confirms the fine payment issue.
17) Run the following commands
git checkout bug_19771
restart_all
18) Refresh the staff client page.
-- it should all come up.
19) run the koha qa test tools
20) if you backed up your database, restore it. :)

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20043] New: Error in fr-FR translation?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20043

Bug ID: 20043
   Summary: Error in fr-FR translation?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

Just putting it here to not forget, there is something wrong in the
MARC21slim2intranetDetail.xsl for fr-FR
I bet on a translation issue.

==> /var/log/koha/kohadev/plack-error.log <==
Error while loading stylesheet xml:
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/MARC21slim2intranetDetail.xsl:923:
parser error : EntityRef: expecting ';'

 Note d'action:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||11559
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
[Bug 11559] Professional cataloger's interface
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||18417


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417
[Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C)
(P)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

--- Comment #5 from Owen Leonard  ---
A good follow-up would be to address the pages in Acquisitions which let you
add to a basket from Z39.50 ("From an external source"). The link is in
acquisitions-add-to-basket.inc which is included in acqui/basket.tt,
acqui/booksellers.tt, and acqui/neworderbiblio.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70709|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 70744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70744=edit
Bug 19987: If no z39.50/SRU servers the button should not show

Test plan:
[1.] Load the patch and make sure you have some Z39.50/SRU servers
 (Administration => Z39.50/SRU servers administration)
[2.] Then go to authorities and notice that the 'New from
 Z39.50/SRU' button is there
[3.] Next go to cataloging and notice that the 'New from Z39.50/SRU'
 button is there too
[4.] Now make sure you have no Z39.50/SRU servers (remove the
 servers)
 (Administration => Z39.50/SRU servers administration)
[5.] Go to authorities and notice that the 'New from Z39.50/SRU'
 button is not there
[6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU'
 button is not there too

:)

Signed-off-by: Owen Leonard 

I added a missing [% END %] during signoff. Hope no one minds!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19788] Case sensitivity is not preserved when creating local system preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

--- Comment #10 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

--- Comment #6 from Mirko Tietgen  ---
This is needed in 17.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19788] Case sensitivity is not preserved when creating local system preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20003


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003
[Bug 20003] Result summary of remaining checkouts items not displaying.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003

Jonathan Druart  changed:

   What|Removed |Added

Version|17.11   |master
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17829

--- Comment #3 from Jonathan Druart  
---
Caused by 
  commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6
Bug 17829: Move GetMember to Koha::Patron

Due to a bad merge conflict during a rebase (that is exactly why we should not
wait for moths to focus on these patches...)

So I guess it impacts master as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19702] Basket not displaying correctly on home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18696] Change debian/source/format to quilt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696

Mirko Tietgen  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
   Severity|trivial |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18696] Change debian/source/format to quilt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696

--- Comment #1 from Mirko Tietgen  ---
Created attachment 70743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70743=edit
Bug 18696: Change debian/source/format to quilt

debian/source/format uses 'native'. As Koha is not native Debian software,
and to allow Debian revision numbers like -2 in 16.05.13-2, it should be
changed to 'quilt'.

This is only relevant to packaging and does not affect Koha itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

--- Comment #8 from Owen Leonard  ---
Thanks for the follow-up! I squashed the two patches during sign-off for
simplicity's sake.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18696] Change debian/source/format to quilt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696

Mirko Tietgen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70666|0   |1
is obsolete||
  Attachment #70708|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 70742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70742=edit
Bug 16427: Direct link to authority records missing staff detail view

I added a magnigying glass icon in the staff detail view that links to
the authority records.

Test Plan:
1) On the Koha staff page, create a new authority. The type of authority
   will be: Topical Term.
2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter
   the topical term or geographic name entry element and then save the
   new authority e.g. science.
3) In circulation, search the catalog for a random book. Click the title
   of the book and you will be taken to the book details.
4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED
   ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title).
5) Edit the Topical term or geographic name entry element by clicking
   the button on the right of the bar.
6) In the Search main heading ($a only) enter your topical term e.g.
   science.
7) Press search, and then in the table that pops up, click 'choose'.
8) Save your edits and the new topical term will be in the 'Subject(s)'
   list of the book details.
9) Notice that there is no magnifying glass icon.
10) Apply this patch
11) Notice that there is now a magnifying glass icon next to the topical
term.
12) Click on the magnifying glass and it will take you directly to the
authorities records

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

Mirko Tietgen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

--- Comment #1 from Mirko Tietgen  ---
Created attachment 70741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70741=edit
Bug 20042: 00-load.t fails when Elasticsearch is not installed

00-load.t fails when Elasticsearch is not installed. Blocks packaging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

--- Comment #5 from Mirko Tietgen  ---
Created attachment 70740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70740=edit
Bug 19783: Move check_kohastructure.t to db_dependent

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #69636|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen  changed:

   What|Removed |Added

Summary|make check_kohastructure.t  |Move check_kohastructure.t
   |compatible to package build |to db_dependent
   |process |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

Mirko Tietgen  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20042] New: 00-load.t fails when Elasticsearch is not installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042

Bug ID: 20042
   Summary: 00-load.t fails when Elasticsearch is not installed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org

00-load.t fails when Elasticsearch is not installed. Blocks packaging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70666|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19840] Patron note is not displayed on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin SOMERS  ---
Bug 18276 is not in 17.05.x but is this bug needed for it anyway ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #4 from Mirko Tietgen  ---
Moving it to db_dependent is the cleaner solution, I'll add a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19621] Routing lists tab not present when viewing 'Holds history' tab for a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Nick Clemens  ---
Small change, SO and QA in one step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Nick Clemens  changed:

   What|Removed |Added

  Attachment #70546|0   |1
is obsolete||
  Attachment #70568|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 70738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70738=edit
Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn

1)apply patch
2) go into administration --> search for OPACSearchForTitleIn
3) *click to edit*
4) look at the link and read the google scholar one.
5) check that the start link is https://scholar.google.com.
6) http://www.scholar.google is incorrect

Signed-off-by: Claire Gravely 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

--- Comment #8 from Nick Clemens  ---
Created attachment 70739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70739=edit
Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn

Amended the sql statement so it only affects the http://www.scholar.google.com
url

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #16 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #21 from Jonathan Druart  
---
https://screenshots.firefox.com/PlajuumMOPG7dPMe/catalogue.kohadev.org

And FreeForm as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #20 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #15)
> The button's functionality is restored with the patch. But the problem of
> the non-functional exploding Dummy and FreeForm (which should work
> universally) remains. Actually using the button still leads to:
> 
> Template process failed: file error - : not found at
> /home/vagrant/kohaclone/C4/Templates.pm line 122.

Dummy works for me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I have just quickly tested the feature on 17.05.x and everything works fine.
Please read the description on the bug report and try again :)

Changing the password unlock the account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

Summary|Allow correct handling of   |Internationalization:
   |plural translation  |plural forms, context, and
   ||more

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #15 from Marcel de Rooy  ---
Well, it is kind of hard to separate. Maybe apart from this:

+sub _bib_indicator2 {
+my ( $code ) = @_;
+my %thes_mapping = ( a => 0, b => 1, c => 2, d => 3, k => 5, n => 4, r =>
7, s => 7, v => 6, z => 7, '|' => 4 );
+return $thes_mapping{ $code } // $code // '4';
+}
+
+sub _bib_subfield2 {
+my ( $indicator2, $subject_headings, $conventions ) = @_;
+return if $indicator2 ne '7';
+return 'aat' if $subject_headings eq 'r';
+return 'sears' if $subject_headings eq 's';
+return $conventions if $subject_headings eq 'z';
+}

I noted that some fields still contain more exceptions. Like:
653, 654 ind2, 655 ind1, 656 and 657 only 7 in ind2, 658, 662, 69X

I still feel more for an approach I originally had in mind by adding a conf
file containing essentially a hash that tells you what to do like:
600, ind1 => authind1 | authind2 | bibind1 | bibind2 | [fixed_value] |
thesaurus
where thesaurus could trigger a call to bib_indicator2.
The uniform title stuff would move to that config file.
It would give people more flexibility to make changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

--- Comment #4 from Julian Maurice  ---
(In reply to M. Tompsett from comment #2)
> One would hope this case never happens. And if it does, stop editing the
> files on a live system. That being said, this is a straight-forward regexp
> tightening.

Of course this should never happen in production, but it can be annoying during
development.
Thanks for the sign-off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025

--- Comment #4 from Mike  ---
I agree, but Koha use CROn for automatic backup, logs make documented records
about it. Direct export from db via CL tool or GUI tools should be logged
manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025

--- Comment #3 from Katrin Fischer  ---
If someone has the information to run koha-dump, wouldn't they also be able to
get the dump using a tool like mysqldump?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025

--- Comment #2 from Mike  ---
Hi Katrin,
especially koha-dump. Because we need to know when Koha made backup and who run
it. It contains personal data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19200] Warns when exporting a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Fridolin SOMERS  ---
Depends on Bug 8612 that is not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||19200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200
[Bug 19200] Warns when exporting a basket
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19200] Warns when exporting a basket

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||8612
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
[Bug 8612] CSV export profile to have custom fields in export csv basket
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #17 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19756] Encoding issues when update DB is run from the interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin SOMERS  ---
Pushed to 17.05.x for v17.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/