[Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield is mandatory and linked to authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 --- Comment #4 from Katrin Fischer--- Hi Hugh, thx for your comment - I was starting to think it was only me (note the dates on the comments!) :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield is mandatory and linked to authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Hugh Rundlechanged: What|Removed |Added CC||hu...@brimbank.vic.gov.au --- Comment #3 from Hugh Rundle --- This is a gigantic pain and as Katrin mentions, difficult to identify after the fact. Just to clarify how I would expect this to work, Katrin's combined descriptions are correct: * If there is a default value: dropdown should be preselected to the default * If no default value: dropdown should be preselected to blank * If field is compulsory and no default value: Koha should show an error complaining that there is no value assigned to the field in question. Currently making something mandatory preselects the first value in the dropdown and doesn't give an error or warning. This is very rarely what users would want and never what administrators would expect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20255] deletedbiblio_metadata id should not increment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20255 Rocio Dresslerchanged: What|Removed |Added CC||jb...@bywatersolutions.com, ||ro...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20255] New: deletedbiblio_metadata id should not increment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20255 Bug ID: 20255 Summary: deletedbiblio_metadata id should not increment Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: ro...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When restoring bib data from the deletedbiblio_metadata table, you will get a duplicate ID error message. This is because the id field in deletedbiblio_metadata increments rather than keeps the id from the original entry in biblio_metadata. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #7 from Jonathan Druart--- Yes I thought about that, but it may be problematic as we do not necessarily create the object for the notices only. So if we do it that way (when creating it) we may need to fetch it twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Chris Cormackchanged: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Testing this with a library at the moment, will sign off if it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #6 from Tomás Cohen Arazi--- (In reply to Jonathan Druart from comment #5) > Kyle and Tomas, What about this last patch? I think (in terms of the problem you highlight) that the read_only flag should be passed when creating the object, and immutable. Like this: my $patrons = Koha::Patrons->search( $criteria, $attributes, $read_only ); And then, it should be inherited by each of the generated objects: while (my $patron = $patrons->next ) { print "Patron " . $patron->id . " readonly!" if $patron->read_only; } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Jonathan Druartchanged: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- Looks invalid, please reopen if it is not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #4 from Jonathan Druart--- Created attachment 72013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72013=edit [FOR DISCUSSION] Bug 19966: Add Koha::Object->read_only If ->read_only is called, only accessor methods will be allowed on this object. use Koha::Patrons; my $p = Koha::Patrons->find(1); say $p->borrowernumber; $p->surname('another surname')->store; say $p->surname; => Will work $p = Koha::Patrons->find(1); $p->read_only; $p->surname('another surname again')->store; => Will explode Problem: use Koha::Patrons; my $p = Koha::Patrons->find(1); say $p->borrowernumber; $p->read_only; $p->{_read_only} = 0; $p->surname('another surname again')->store; => Will not explode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #5 from Jonathan Druart--- Kyle and Tomas, What about this last patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #29 from Josef Moravec--- Marcel, try it now, it applies cleanly on current master for me now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravecchanged: What|Removed |Added Attachment #71929|0 |1 is obsolete|| Attachment #71930|0 |1 is obsolete|| Attachment #71931|0 |1 is obsolete|| --- Comment #26 from Josef Moravec --- Created attachment 72010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72010=edit Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #28 from Josef Moravec--- Created attachment 72012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72012=edit Bug 9701: (follow-up) Adjust tests Test plan: prove t/db_dependent/Biblio.t should be green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravecchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #27 from Josef Moravec--- Created attachment 72011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72011=edit Bug 9701: (QA follow-up) Fix indentation and some strings - Fixes tabs pointed out by the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #25 from Josef Moravec--- Probably my bad, I will try to rebase and re-upload patches, but probably not today, and tomorow I am out, so please be patient... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #13 from Jonathan Druart--- I use `stress -c 4` to recreate the failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #12 from Jonathan Druart--- This is my try with Time::Fake, what's wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #11 from Jonathan Druart--- Created attachment 72009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72009=edit Bug 20191: Try and fix random failure from Server.t - v3... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9302] Add ability to merge patron records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #22 from Tomás Cohen Arazi --- Sorry, please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |In Discussion --- Comment #3 from Tomás Cohen Arazi --- Kyle: do you think some other methods could be blacklisted? (_resultset, etc). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Nick Weingardtchanged: What|Removed |Added CC||nick.weingardt@valorchristi ||an.com --- Comment #100 from Nick Weingardt --- *** Bug 19577 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19577] Secondary email is unable to receive notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19577 Nick Weingardtchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nick Weingardt --- *** This bug has been marked as a duplicate of bug 12802 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #403 from Jonathan Druart--- Created attachment 72008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72008=edit Bug 7143: Update about page for new dev - Pongtawat Chippimolchai -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Jonathan Druartchanged: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #10 from Jonathan Druart --- I tried with Time::Fake but failed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonardchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard --- This applies cleanly for me (after some auto-merging). Can you try again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #13 from Jonathan Druart--- Created attachment 72007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72007=edit Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #12 from Jonathan Druart--- Created attachment 72006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72006=edit Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druartchanged: What|Removed |Added Attachment #71803|0 |1 is obsolete|| Attachment #71804|0 |1 is obsolete|| Attachment #71805|0 |1 is obsolete|| Attachment #71806|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 72004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72004=edit Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #11 from Jonathan Druart--- Created attachment 72005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72005=edit Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #62 from Jonathan Druart--- Splitting correctly into different patches is more helpful for the author than testers :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #61 from Charles Farmer --- If it'll make everyone's life easier, I'll split this development appropriately in the coming days. Marking 'failed QA', so nobody touches it in the meantime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #59 from Jonathan Druart--- See bug 19303 and bug 19304 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #60 from Jonathan Druart--- (In reply to Charles Farmer from comment #59) > Freshly rebased. > > To facilitate future git apply, Z3950Server.pm was regenerated. Field > `attributes` now sits under `sru_fields` and `add_xslt` with longtext, > instead of the previous mediumtext that conflicted with the master's version > of the Schema. That is why it is suggested to add 1 patch for atomic update/kohastructure and 1 patch for the DBIC schema changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes marked as problematic with no_barcode?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562 Marcel de Rooychanged: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes marked as problematic with no_barcode?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562 Marcel de Rooychanged: What|Removed |Added Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #4 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > The solution marked before as 'custom' might on second thought be > generalized enough to be selected for inclusion. > So my proposal submitted. > Feedback welcome. No feedback. Closing this one. I agree that the solution is arguable.. Still curious if other libraries use convolutes in Koha though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9701] Configure default indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooychanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Marcel de Rooy --- My git does not like that second patch.. Applying: Bug 9701: (QA follow-up) Fix indentation and some strings *** Error in `git': malloc(): memory corruption: 0x02837340 *** fatal: sha1 information is lacking or useless (C4/Biblio.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Owen Leonardchanged: What|Removed |Added Attachment #71605|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 72003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72003=edit Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins This patch modifies the templates for MARC21 editor plugins so that JavaScript is included in the footer. To test, you must link the plugins to their corresponding tag + subfield (if they aren't already): In a bibliographic framework: 000 -> marc21_leader.pl 006 -> marc21_field_006.pl 007 -> marc21_field_007.pl 008 -> marc21_field_008.pl 773$t -> marc21_linking_section.tt In an authorities framework: 000 -> marc21_leader_authorities.tt 008 -> marc21_field_008_authorities.tt -> marc21_field_008_classifications.tt For each field, trigger the plugin by clicking the plugin link. Test JavaScript-driven functionality in each plugin window and confirm that your selections are correctly saved to the editor. Signed-off-by: Claire Gravely Edit: Fix for QA, add KOHA_VERSION variables to js includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Owen Leonardchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17672] Items table should have a damaged_on column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672 Jonathan Druartchanged: What|Removed |Added Keywords|additional_work_needed | --- Comment #21 from Jonathan Druart --- New commit added to misc4dev. commit 05f342d6a850e2a89b2d49a9ce1bcb35c411d787 Fix items.sql since bug 17672 damaged_on has been added and so we must list the columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17672] Items table should have a damaged_on column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672 --- Comment #20 from Jonathan Druart--- (In reply to Tomás Cohen Arazi from comment #19) > I think Jonathan is asking you to provide a fix for misc4dev he. Nope, I would have asked explicitly in that case :) I let a note here to let you know and added a keyword to not forget. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 --- Comment #5 from Owen Leonard--- Created attachment 72002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72002=edit Bug 19786: (follow-up) Correct js include path, popup window size This follow-up adds the required KOHA_VERSION variable to two templates where it was missing. This patch also adds a 'window_size' parameter to a popup window function so that self-closing windows like blinddetail-biblio-search.pl can appear small and others at a reasonable size. To test, apply the patch and clear your browser cache if necessary. - Confirm that the QA tools do not complain about missing KOHA_VERSION in auth_finder.tt and searchresultlist_auth.tt. - Open a bibliographic record for editing in the basic editor using a framework in which a field is linked to authorities. - Trigger the authority selection window for that field. - Click the "Clear field" button at the top of the authority search pop-up window. Another smaller popup window should briefly appear, and then both windows should close. - Trigger the authority selection window again. - Click the "Create new authority" button. A new window should appear with the MARC authority editor. The window should be a usable size. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 Owen Leonardchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druartchanged: What|Removed |Added Keywords|additional_work_needed | --- Comment #116 from Jonathan Druart --- Ok, make sense! Thanks for the answers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Fiona Borthwickchanged: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20254] New: Forbid the download of duplicate EDI messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 Bug ID: 20254 Summary: Forbid the download of duplicate EDI messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org In theory EDI messages should be downloaded only once, as we rename it according to Edifact conventions as soon as downloaded. However the case has occured when after an issue with a vendor's server duplicates of the days files have been uploaded to the download directory. As a result duplicate quotes are downloaded, creating new orders on the system, as Koha cannot now rename the file (it would entail overwriting a file on the vendor's system) this can continue infinitely. So do not allow duplicate filenames to be downloaded, add a unique constraint to edifact_messages to support this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #9 from Jonathan Druart--- and again: https://jenkins.koha-community.org/job/Koha_Master_D8/381/console -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Jessie Zairochanged: What|Removed |Added CC||jza...@bywatersolutions.com --- Comment #3 from Jessie Zairo --- This is definitely something libraries would like to be able to edit from the Notices and Slips interface in tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20253] New: Optionally use buyer's purchase order number from Edifact quote in basketname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 Bug ID: 20253 Summary: Optionally use buyer's purchase order number from Edifact quote in basketname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Current default behaviour is to use the filename of the QUOTE in the basketname. This would instead use the buyer's purchase order number (segment RFF with a qualifier ON) instead so that this would be searchable. This should be optional as even when supplied many (most) sites do not have meaningful or distinctive data in the field (e.g. 'Books for branch X'). Logical is to add it as a vendor option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravecchanged: What|Removed |Added QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #84 from Josef Moravec --- Patch doesn't apply, please, rebase. Also, we will need pod and test for GetOpenURLResolverURL in C4::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #115 from Kyle M Hall--- AFAIK, the reason the former is better then the latter is fairly simple. With the latter ( that is, /my/file.js?version=[% KOHA_VERSION %] ), the file will *never* be cached. It will always be fetched on each page load. Since we would be passing a GET parameter, a modern web browser would assume the contents of the URL may vary based on the parameter, and will assume it shouldn't cache the file. Kyle (In reply to Marcel de Rooy from comment #114) > (In reply to Jonathan Druart from comment #113) > > Could anyone explain (again) why we choose to append the version to the > > filename and not in parameter? > > > > So basically why: > > /my/file_[% KOHA_VERSION %].js > > and not: > > /my/file.js?version=[% KOHA_VERSION %] > > > > Kyle and Martin talked about the two approaches earlier in comments (from > > comment 4) but I do not understand. Please clarify. > > > > It could avoid the rewrite rules. > > From one of the linked sources: > === > But which is better: mylogo.1.2.gif or mylogo.gif?v=1.2? To gain the benefit > of caching by popular proxies, avoid revving with a querystring and instead > rev the filename itself. > === > I am not sure if passing a version as parameter in a script URL would be > good practice. It seems quite uncommon, but I may be wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 --- Comment #19 from Marcel de Rooy--- Created attachment 72000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72000=edit Bug 19452: [17.11.x] Remove the truncate option The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. Note that the subsequent call of SetMessagingPreferencesFromDefaults will already delete the records. This makes it possible to remove the truncate option altogether. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 --- Comment #20 from Marcel de Rooy--- Created attachment 72001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72001=edit Bug 19452: [17.05.x] Remove the truncate option The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. Note that the subsequent call of SetMessagingPreferencesFromDefaults will already delete the records. This makes it possible to remove the truncate option altogether. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Tomás Cohen Arazichanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20252] New: If an EDI orderline is cancelled send a cancellation message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20252 Bug ID: 20252 Summary: If an EDI orderline is cancelled send a cancellation message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org On cancelling a order if the order has been submitted as an edifact order an ORDCHG message should be generated and transmitted. ORDCHG will contain the order reference and the ean for the item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonardchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonardchanged: What|Removed |Added Attachment #71602|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 71999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71999=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20235] Telegram notifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20235 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- (In reply to Lari Taskula from comment #1) > Currently just a thought but I'm curious if our community has interest in > supporting instant messaging apps for notifications. Sounds like an interesting feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #114 from Marcel de Rooy--- (In reply to Jonathan Druart from comment #113) > Could anyone explain (again) why we choose to append the version to the > filename and not in parameter? > > So basically why: > /my/file_[% KOHA_VERSION %].js > and not: > /my/file.js?version=[% KOHA_VERSION %] > > Kyle and Martin talked about the two approaches earlier in comments (from > comment 4) but I do not understand. Please clarify. > > It could avoid the rewrite rules. >From one of the linked sources: === But which is better: mylogo.1.2.gif or mylogo.gif?v=1.2? To gain the benefit of caching by popular proxies, avoid revving with a querystring and instead rev the filename itself. === I am not sure if passing a version as parameter in a script URL would be good practice. It seems quite uncommon, but I may be wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Failed QA --- Comment #21 from Josef Moravec --- Why should be accounttype hidden for credits? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Josef Moravecchanged: What|Removed |Added Attachment #70470|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 71998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71998=edit Bug 19966 - Add ability to pass objects directly to slips and notices Koha spends an incredible amount of time on parsing and processing parameters passed in to slips and notices. It would be immensely more efficient to be able to pass objects directly to GetPreparedLetter so it doesn't need to do any fetching / processing on them. Test plan: 1) Apply this patch 2) prove t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 --- Comment #4 from Hugo Agud--- fixed.. thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 --- Comment #3 from Mirko Tietgen--- Hi Hugo, please set your credentials in your development system. Your patch says > Signed-off-by: Your Full Name You can find some information here: https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Getting_Started_with_Git -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 Hugo Agudchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17672] Items table should have a damaged_on column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672 --- Comment #19 from Tomás Cohen Arazi--- (In reply to Nick Clemens from comment #18) > (In reply to Jonathan Druart from comment #17) > > It broke the misc4dev tools: > > C4::Installer::load_sql returned the following errors while attempting to > > load /home/vagrant/misc4dev/data/sql/marc21/1611/after_17196/items.sql: > > DBD::mysql::st execute failed: Column count doesn't match value count at row > > 1 at /usr/share/perl5/DBIx/RunSQL.pm line 273. > > Doesn't this mean misc4dev needs an update? Not sure what is needed here I think Jonathan is asking you to provide a fix for misc4dev he. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 Hugo Agudchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 Hugo Agudchanged: What|Removed |Added Attachment #71884|0 |1 is obsolete|| --- Comment #2 from Hugo Agud --- Created attachment 71997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71997=edit Bug 19610: Make koha-common.logroate use copytruncate This patch makes logrotate use the **copytruncate** directive, removing the need to stop the Zebra and Plack servers on log rotation. To test: - Run: $ misc4dev/cp_debian_files.pl - Edit the new /etc/logrotate.d/koha-common file changing 'weekly' for 'hourly'. This is to ease testing. - Run: $ sudo ls -l /var/log/koha/kohadev - Open a second terminal on your kohadevbox. On it... - Run: $ sudo logrotate /etc/logrotate.d/koha-common - Run: $ sudo ls -l /var/log/koha/kohadev => SUCCESS: Files got rotated! (i.e. files ending in .1 are created, the sizes make sense (.1 have contents, the ones without numbering probably zeroed <- it will depend on what's happening with your devbox in between). - Play with your Koha, do some searches too: => SUCCESS: You have access to your Koha, searches work. i.e.: - Apache handled the log rotation operation - Plack handled the log rotation operation - Zebra handled the log rotation operation - Sign off :-D! Sponsored-by: Orex Digital Signed-off-by: Hugo Agud ha...@orex.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17672] Items table should have a damaged_on column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672 --- Comment #18 from Nick Clemens--- (In reply to Jonathan Druart from comment #17) > It broke the misc4dev tools: > C4::Installer::load_sql returned the following errors while attempting to > load /home/vagrant/misc4dev/data/sql/marc21/1611/after_17196/items.sql: > DBD::mysql::st execute failed: Column count doesn't match value count at row > 1 at /usr/share/perl5/DBIx/RunSQL.pm line 273. Doesn't this mean misc4dev needs an update? Not sure what is needed here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mason Jameschanged: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Mason Jameschanged: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 Hugo Agudchanged: What|Removed |Added Attachment #71881|0 |1 is obsolete|| --- Comment #3 from Hugo Agud --- Created attachment 71995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71995=edit Bug 20234: Make maintenance scripts use koha-zebra instead of koha-*-zebra This patch makes all maintenance scripts use **koha-zebra** instead of the old **koha-*-zebra** scripts. To test: - Run: $ perl misc4dev/cp_debian_files.pl $ sudo service koha-common stop => SUCCESS: No errors and the Zebra-related sevices are stopped $ sudo service koha-common start => SUCCESS: No errors and the Zebra-related services are started $ sudo service koha-common restart => SUCCESS: No erros and Zebra-related services are running $ sudo koha-create --create-db test => SUCCESS: Instance created and zebra running for it $ sudo koha-disable test => SUCCESS: No errors and Zebra is stopped for instance test $ sudo koha-zebra --start test $ sudo koha-remove test => SUCCESS: No errors, instance removed, no Zebra running for test - Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud ha...@orex.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 Hugo Agudchanged: What|Removed |Added Attachment #71882|0 |1 is obsolete|| --- Comment #4 from Hugo Agud --- Created attachment 71996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71996=edit Bug 20234: Update ervice description in koha-common.init The service description is very old and outdated. This patch fixes this. Sponsored-by: Orex Digital Signed-off-by: Your Full Name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20251] New: SIP checkout broken in master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Bug ID: 20251 Summary: SIP checkout broken in master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Attempts to checkout via sip cause the sipserver to crash. The interface to CanBookBeIssued was altered so it now requires a Koha::Patron object. When passed an oldstyle Patron hash it aborts on the call to unblessed. Can be mitigated by retrieving a Patron object with Koha::Patrons->find( { cardnumber => $borrower->{cardnumber}} ); in _can_we_issue sub of Checkout.pm but it may be time to look at rationalizing the patron handling in the SIP routines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #30 from Fridolin SOMERS--- It also corrects a small bug, when restriction is infinite, the date "31/12/" was displayed in return page. This is because new code always checks for this infinite date and returns message "ForeverDebarred" instead of "PrevDebarred". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #29 from Fridolin SOMERS--- (In reply to David Bourgault from comment #28) > Signed-off-by: Katrin Fischer Is this patch signed off ? Or does it need a second signing ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Fridolin SOMERSchanged: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Fridolin SOMERSchanged: What|Removed |Added Patch complexity|--- |Small patch CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/