[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #3 from Josef Moravec  ---
I just added a screenshot for easy review ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #2 from Josef Moravec  ---
Created attachment 72466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72466=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #123 from Josef Moravec  ---
Created attachment 72458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72458=edit
Bug 11317: Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #130 from Josef Moravec  ---
Created attachment 72465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72465=edit
Bug 11317: (QA follow-up) Fix datatable

Fixes the link to datatables.css
Fixes the footer javascript

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #127 from Josef Moravec  ---
Created attachment 72462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72462=edit
Bug 11317: (Follow-up) Fixing merge error and cosmetic changes

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #128 from Josef Moravec  ---
Created attachment 72463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72463=edit
Bug 11317: (Follow-up) File with same name in different directories now has
distinct hash

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec  changed:

   What|Removed |Added

  Attachment #66094|0   |1
is obsolete||
  Attachment #66095|0   |1
is obsolete||
  Attachment #66096|0   |1
is obsolete||
  Attachment #66097|0   |1
is obsolete||
  Attachment #66098|0   |1
is obsolete||
  Attachment #66099|0   |1
is obsolete||
  Attachment #66100|0   |1
is obsolete||
  Attachment #72309|0   |1
is obsolete||

--- Comment #121 from Josef Moravec  ---
Created attachment 72456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72456=edit
Bug 11317: Adds a page to access log files on the server from the intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Sponsored by : CCSR

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #122 from Josef Moravec  ---
Created attachment 72457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72457=edit
Bug 11317: Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #129 from Josef Moravec  ---
Created attachment 72464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72464=edit
Bug 11317: (Follow-up) Fix tab chars and move javascript to the footer

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #124 from Josef Moravec  ---
Created attachment 72459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72459=edit
Bug 11317: Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #125 from Josef Moravec  ---
Created attachment 72460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72460=edit
Bug 11317: Move file access under Tools and add specific permission

- Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.
- Remove datatables-strings.inc from .tt
- Allow sorting on date column in file access tool.  For some reason, the table
was blocking sorting based on timestamp,
  even though most users would probably want that since the feature is used
primarily to access generated (daily) reports i
  and finding the last ones is very important.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #126 from Josef Moravec  ---
Created attachment 72461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72461=edit
Bug 11317: Update the link under reports

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085

--- Comment #5 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > (In reply to Fridolin SOMERS from comment #1)
> > > Also adds  on "Unlimited" and "None defined" so that there are more
> > > visible
> > > and that there translation is more simple.
> > 
> > Why do you want to make them more visible? I do not think it should be done
> > in this patch.
> 
> Its because there are a special case, like All for Patron category or Item
> type.
> 
> Otherwise we can use a simple span.

Ok corrected, one step at the time indeed ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #70877|0   |1
is obsolete||

--- Comment #4 from Fridolin SOMERS  ---
Created attachment 72455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72455=edit
Bug 20085: Better translatability of smart-rules.tt

Template smart-rules.tt in administration contains some if/elsif/else with
translatable strings.
For example :
[% IF rule.onshelfholds == 1 %]
Yes
[% ELSIF rule.onshelfholds == 2 %]
If all unavailable
[% ELSE %]
If any unavailable
[% END %]

Adding span to translatable strings will allow to have the same translation
than :


Yes
If any unavailable
If all unavailable


This is important to allow editing an existing circulation and fine rule.

Actually for example in french some strings are translated differently :
msgid "%s Yes %s If all unavailable %s If any unavailable %s"
msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s"

msgid "If any unavailable"
msgstr "Si au moins un exemplaire est indisponible"

Test plan :
1) Look at PO files, for example fr-FR and see there is :
msgid "%s Yes %s If all unavailable %s If any unavailable %s"
msgid "If any unavailable"
2) Apply patch
3) update PO files
4) Look at PO files, for example fr-FR and see there is now only :
msgid "If any unavailable"
5) Install translation
6) Go to Administration > Circulation and fine rule
7) Check that when editing an existing rule, edition comboboxes are set on the
correct value
8) Create a default holds policy by item type and check that correct values are
displayed in table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #162 from M. Tompsett  ---
Today was massive rebase, and confirm changes. Still to do: test and confirm
that comment #112 is the exhaustive test plan. Sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70259|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70256|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72453|0   |1
is obsolete||

--- Comment #161 from M. Tompsett  ---
Created attachment 72454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72454=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72452|0   |1
is obsolete||

--- Comment #160 from M. Tompsett  ---
Created attachment 72453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72453=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72451|0   |1
is obsolete||

--- Comment #159 from M. Tompsett  ---
Created attachment 72452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72452=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72450|0   |1
is obsolete||

--- Comment #158 from M. Tompsett  ---
Created attachment 72451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72451=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72449|0   |1
is obsolete||

--- Comment #157 from M. Tompsett  ---
Created attachment 72450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72450=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72448|0   |1
is obsolete||

--- Comment #156 from M. Tompsett  ---
Created attachment 72449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72449=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20337] New: Add modification templates to Batch item modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20337

Bug ID: 20337
   Summary: Add modification templates to Batch item modification
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: verolenci...@yahoo.com.ar
QA Contact: testo...@bugs.koha-community.org

Batch item modification allows adding o deleting data, but not modification of
existing data, for example change dashes to spaces in signatures.
It should be possible to use also MARC Modification Template on items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC|rkui...@roundrocktexas.gov  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=10454|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #155 from M. Tompsett  ---
Created attachment 72448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72448=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|0   |1
is obsolete||

--- Comment #154 from M. Tompsett  ---
Created attachment 72447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72447=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #152 from M. Tompsett  ---
Created attachment 72445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72445=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|0   |1
is obsolete||

--- Comment #153 from M. Tompsett  ---
Created attachment 72446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72446=edit
Bug 14385 Followup: C4::Borrowers not found

GetMember is in C4::Members, not C4::Borrowers

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #151 from M. Tompsett  ---
Comment on attachment 70259
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259
Bug 14385: A lot of patches

Review of attachment 70259:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14385=70259)
-

::: opac/opac-tags.pl
@@ +310,5 @@
> +if (grep { $_->{term} eq $my_tag->{term} } @$results) {
> +if (! $my_tag->{visible} ) {
> +my $check_biblio = GetMarcBiblio({
> +biblionumber => $my_tag->{biblionumber},
> +embed_itesm  => 1,

Always good idea to re-check over and over. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

--- Comment #36 from Owen Leonard  ---
Created attachment 72444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72444=edit
Bug 19474 (follow-up) Catch up with changes to CSS from Bug 19981

This patch brings staff-global.scss up to date with changes made in Bug
19981.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #72305|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 72442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442=edit
Bug 19469: Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall 

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley 
Signed-off-by: Andreas Hedström Mace 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 72443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72443=edit
Bug 19469: (followup) Use patron-title.inc as proposed by bug 18403

This patch makes the new template include file use the patron-title.inc
include to render the patron name.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #72304|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 72441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72441=edit
Bug 19469: Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall 

Passed QA test tool
Signed-off-by: Alex Buckley 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20336] New: Add a generic way for Koha::Object(s) to call logaction as required

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20336

Bug ID: 20336
   Summary: Add a generic way for Koha::Object(s) to call
logaction as required
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959

Owen Leonard  changed:

   What|Removed |Added

  Attachment #71482|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 72440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72440=edit
Bug 19959: Update popup window templates to use Bootstrap grid: Label creator

This patch updates two label creator templates to use the Bootstrap grid
instead of the YUI grid.

To test, apply the patch and go to Label creator -> Manage -> Label
batches.

- Create a new or open an existing label batch.
- Click "Add items."
  - The resulting pop-up window should look correct.
  - Perform a search
- The search results screen should look correct.

Signed-off-by: Charlotte Cordwell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320

--- Comment #3 from Katrin Fischer  ---
Ah yep, a URL would definitely work better than a setting in the Apache config
:) A text input could be done later, I just wanted to put it out there :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

  Attachment #71557|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 72439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72439=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Edit: Fixed footer include error causing blank popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #70381|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 72438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72438=edit
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf

This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call

Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20322] Circulation page layout and design update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320

--- Comment #2 from Nick Clemens  ---
The idea was a way to replace OPAC_CSS_OVERRIDE, I would be happy with maybe
both?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 72437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72437=edit
Bug 20167: Make changing a hold pass the itemnumber to ModReserve

If you have an item-level hold, changing an attribute (like priority,
pickup location or suspended until date) makes the hold a biblio-level
hold, because ModReserve is not passed the current itemnumber.

This patch uses the hold's itemnumber and passes it to the ModReserve
call.

To test:
- Run the regression tests from the previous patch:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail
- Apply this patch
- Run the tests:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 72436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72436=edit
Bug 20167: Regression test

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #3 from Josef Moravec  ---
David, is this ready for testing? If so, please change status to "Needs
signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #150 from M. Tompsett  ---
Currently does not apply, reworking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20164] Suspend Waiting Hold in OPAC loophole

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20164

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #40 from Fridolin SOMERS  ---
(In reply to Mirko Tietgen from comment #39)
> Fridolin: This is a "standing" bug, it will get new patches whenever a
> dependency is pushed. So after push I set it back to assigned.

Ok thanks for the explanation ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085

--- Comment #3 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #2)
> (In reply to Fridolin SOMERS from comment #1)
> > Also adds  on "Unlimited" and "None defined" so that there are more
> > visible
> > and that there translation is more simple.
> 
> Why do you want to make them more visible? I do not think it should be done
> in this patch.

Its because there are a special case, like All for Patron category or Item
type.

Otherwise we can use a simple span.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20333] Show certain links just for registered users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333

--- Comment #3 from Katrin Fischer  ---
Another thought: woudn't it be better to show the link and ask for login before
access? That way users can discover the existence of the resources, otherwise
they might not even notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20333] Show certain links just for registered users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #1)
> Hi Hugo,
> 
> I think just controlling the visibility is not a good way of protecting
> restricted resources. Links can be shared or keep working, if your account
> has been blocked or deleted. What you need to implement, I think, is a
> protection of the resource itself, that Koha can't provide unless it's
> stored within Koha itself.

We could add that functionality to Koha uploads.

Some sites work with the referer as a way to validate the request, so hiding
the links could help. But that'd be certainly a separate featurre: optionally
removing 856 fields based on some regexp and config.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

--- Comment #1 from Tomás Cohen Arazi  ---
(In reply to Stefan Berndtsson from comment #0)
> If a patron has an item level hold with pickup location set to library A and
> staff then (via the Holds tab in the patron view) changes pickup location to
> library B, itemnumber is lost from the hold. This is a definite problem when
> the items within a bibliographic record are different things (separate
> volumes for example).
> 
> This can be fixed by adding some code in Koha/REST/V1/Hold.pm
> 
> This bit before the ModReserve call:
> 
> if($hold->itemnumber()) {
> $params->{itemnumber} = $hold->itemnumber();
> }
> 
> 
> However, given the FIXME comment in C4/Reserves.pm for ModReserve, I'm
> wondering if this is the desired fix:
> "Note that the forgoing can have the effect of causing
> item-level hold requests to turn into title-level requests.  This
> will be fixed once reserves has separate columns for requested
> itemnumber and supplying itemnumber."
> 
> 
> A different method of solving this issue could be to provide itemnumber as
> part of the pickup-location-change call instead and keep the rest of the
> REST-API and ModReserve the way it works now. I'm somewhat unfamiliar with
> the how the Mojolicious system works, so I haven't looked into that method
> yet.

I think your proposed solution is the right onw.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|19940   |
 Depends on||19940


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940
[Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19941
 Depends on|19941   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941
[Bug 19941] 'alt' and 'title' attributes of the item type image are not set
when a hold is placed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #70380|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
Jonathan, it seems to me that you submitted the patch for bug 19440 here, and
forgot about this specific bug you were trying to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17657] Item type's images could not be displayed correctly on the item types admin page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657
Bug 17657 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525
Bug 18525 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449
Bug 16449 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671
Bug 16671 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16114] Regression: Bug 14828 broke display of localized item type descriptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114
Bug 16114 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730
Bug 15730 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306
Bug 15306 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
Bug 15449 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19646] value_builder marc21_linking_section template is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646
Bug 19646 depends on bug 14828, which changed state.

Bug 14828 Summary: Move the item types related code to Koha::ItemTypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20335] New: Stage MARC records for import does not work under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20335

Bug ID: 20335
   Summary: Stage MARC records for import does not work under
Plack
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: arouss1...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In a vanilla 17.11.03 installation with Plack enabled, attempting to
stage a MARC record for import fails with a pop-up message that
reads: "Failed to submit form: error".

In intranet-error.log the following information appears:
stage-marc-import.pl:
/usr/share/koha/intranet/cgi-bin/tools/stage-marc-import.pl: cannot open input
file /tmp/koha_hax_upload/3f11cee01b610984d5dbd6430106d173_koha.mrc: No such
file or directory

The permissions of the directory and file above are as follows:
drwxr-xr-x 2 hax-koha hax-koha 4096 Mar  5 16:18 /tmp/koha_hax_upload
-rw-r--r-- 1 hax-koha hax-koha 1058 Mar  5 16:18
/tmp/koha_hax_upload/3f11cee01b610984d5dbd6430106d173_koha.mrc

To reproduce, simply enable Plack in a vanilla 17.11.03 installation,
then go to Home -> Tools -> Stage MARC records for import, browse for
a file, hit the "Upload file" button, and then click the "Stage for
import" button.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20333] Show certain links just for registered users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #8 from Francesco Rivetti  ---
(In reply to Katrin Fischer from comment #7)
> I think we should try and provide at least a script to automate merging the
> two tables. You cannot assume that most admins know Koha well enough to fix
> the issues themselves. A problem might be the possible existence of
> duplicated rows. We could check that and then suggest a fix before
> continuing.

My idea is to move all the rows properly.

if any rows clash (for some unforeseen reason, i found a "orphaned" item
referring to a non-existent biblio here, but can be anything!) then they won't
be moved.

at the end, if the table is empty, it gets removed, otherwise it stays there.

does it sounds good?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20333] Show certain links just for registered users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Hugo,

I think just controlling the visibility is not a good way of protecting
restricted resources. Links can be shared or keep working, if your account has
been blocked or deleted. What you need to implement, I think, is a protection
of the resource itself, that Koha can't provide unless it's stored within Koha
itself.

> These conditions are the same than ILL request.

Can you explain?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #7 from Katrin Fischer  ---
I think we should try and provide at least a script to automate merging the two
tables. You cannot assume that most admins know Koha well enough to fix the
issues themselves. A problem might be the possible existence of duplicated
rows. We could check that and then suggest a fix before continuing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

David Gustafsson  changed:

   What|Removed |Added

  Attachment #72434|0   |1
is obsolete||

--- Comment #2 from David Gustafsson  ---
Created attachment 72435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72435=edit
Bug 20334 - Option for escaping slashes in search queries

Add "QueryRegexEscapeOption" system preference to provide option to escape
Elasticsearch regexp delimiters (/) within queries, or alternativly to
unescape escaped slashes (\/) while escaping unescaped slashes, in
effect making "\/" the new regexp delimiter.

How to test:
1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
2) All tests should succeed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #18 from Victor Grousset/tuxayo  ---
So no need to change anything functionally?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

--- Comment #1 from David Gustafsson  ---
Created attachment 72434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72434=edit
Bug 20334 - Option for escaping slashes in search queries

Add "QueryRegexEscapeOption" system preference to provide option to escape
Elasticsearch regexp delimiters (/) within queries, or alternativly to
unescape escaped slashes (\/) while escaping unescaped slashes, in
effect making "\/" the new regexp delimiter.

How to test:
1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
2) All tests should succeed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] New: Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Bug ID: 20334
   Summary: Option for escaping slashes in search queries
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com

There are a number of reserved characters in the Elasticsearch query syntax (+
- = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /). Slash (/), which is used for
regexps, is quite often used in searches with the intent as it should be
interpreted as a literal sting. This causes the search to crash since
Elasticsearch treats this as an unclosed regular expression (or a regexp if two
slashes are used which can be even more confusing). To address this particular
case here is a patch with an option to escape slashes (or require them to be
escaped to count as a regular expression delimiter).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20333] New: Show certain links just for registered users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333

Bug ID: 20333
   Summary: Show certain links just for registered users
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org

It should be great If Koha should be able to show certain llinks (856) if a
certain logged users belong to one or more category codes

Some libraries are requesting us the functionality of allow Koha to catalogue
in the 856 link to restricted documents, that only will be showed if

1. the user is logged 
2. if the category code match certain values

These conditions are the same than ILL request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #35 from Josef Moravec  ---
I can't even add an item without collection code after last patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72385|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 72433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72433=edit
Bug 20321 - Remove get_biblionumber_from_isbn

To test:
1 - grep get_biblionumber_from_isbn
2 - verify all occurences are not actual calls (except for test)
3 - Apply patch
4 - grep get_biblionumber_from_isbn
5 - Verify it is removed

Signed-off-by: Roch D'Amour 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/