date:20180327

[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |l...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #8 from Katrin Fischer  ---
The holding library pull down is empty in the batch add form, please fix!
Thx Owen for noticing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19916] Can't search keyword or standard ID from Acquisitions external source / z3950

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73368|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73369=edit
Bug 19916: Add keyword and standard ID fields to acq external search

To test:
1 - Add an order from external source
2 - Note you don't have keyword or standard ID fields
3 - Add a catalog record from Z3950, note those fields are there
4 - Apply patch
5 - Check acq and note you do have those fields
6 - Do some searches to verify they work as expected

Signed-off-by: Maksim Sen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19916] Can't search keyword or standard ID from Acquisitions external source / z3950

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73062|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 73368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73368=edit
Bug 19916 - Add keyword and standard ID fields to acq external search

To test:
1 - Add an order from external source
2 - Note you don't have keyword or standard ID fields
3 - Add a catalog record from Z3950, note those fields are there
4 - Apply patch
5 - Check acq and note you do have those fields
6 - Do some searches to verify they work as expected

Signed-off-by: Maksim Sen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19916] Can't search keyword or standard ID from Acquisitions external source / z3950

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19673] Patron batch modification tool cannot use authorised value "0"

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73223|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73367=edit
Bug 19673: Allow to set patron attributes to 0 with batch patron modification

This patch will have to be tested deeply to make sure it will not
introduce regression!

The idea is to display an empty option in the patron attributes select
and ignore it. That way we can deal with false values 0 and "" which
were skipped before.

Test plan:
Add several patron attributes
Use the batch patron modification tool to add/update/remove them
Play with empty "" and 0 values, as well as other values
Modify several attributes in a row

Signed-off-by: Charles Farmer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19673] Patron batch modification tool cannot use authorised value "0"

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #14 from Mason James  ---
a temporary workaround for this issue is to increase the apache TimeOut
variable to something large.. like 900 (or more)

 https://httpd.apache.org/docs/current/mod/core.html#timeout

900 seconds = 15 minutes, apache's default is 60

you can add the 'Timeout 900' line to your apache.conf (global)
..but you probably just want to add the line inside your Koha intranet vhost(s)


we've been running this fix on prod without any problems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618

--- Comment #13 from Alex Buckley  ---
*** Bug 18646 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18646] Recommendation system for OPAC which integrates with the Mana database

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18646

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Alex Buckley  ---
This is a duplicate of 18618 so I am setting it to Resolved Duplicate

*** This bug has been marked as a duplicate of bug 18618 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Alex Buckley  ---
I have recorded some screencast videos showing the behaviour of the bug before
applying the patch and following the test plan after applying the patch and
running steps 4 and 5. If you are testing this and are confused about the test
plan I will happily email these videos to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #4 from Alex Buckley  ---
Created attachment 73365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73365=edit
Patch applies cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #5 from Alex Buckley  ---
Created attachment 73366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73366=edit
Circled barcode in the pay fines table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20469] Add item status to staff article requests form

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469

--- Comment #3 from M. Tompsett  ---
Comment on attachment 73282
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73282
Bug 20469: Add item status to staff article request form

Review of attachment 73282:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20469=73282)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
@@ +42,5 @@
>  [% END %]
> +[% BLOCK item_status %][%# pass Koha::Item into myitem %]
> +[% IF myitem.onloan %]Checked out
> +[% ELSIF myitem.is_waiting_or_transit %]On hold
> +[% ELSE %]Available

Just curious about the lack of 's. Does this translate?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20477] Silence warnings Fast Cataloguing

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20477

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364

--- Comment #3 from M. Tompsett  ---
Created attachment 73364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73364=edit
Bug 20364: Follow up to correct koha qa test tool failure

Plus, improve the perlcritic level beyond minimal.

TEST PLAN
-
1) apply first patch
2) run the script in a koha shell output to before.xml
3) run koha qa test tools
   -- script will fail.
4) perlcritic -3 on script is noisy.
5) apply this patch
6) run the script in a koha shell output to after.xml
7) a diff of these two output files should be identical
8) run koha qa test tools
   -- script will now pass
9) perlcritic -3 on script is OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72559|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 73363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73363=edit
Bug 20364: Show languages from MARC21 field 041 in intranet

Show the language names coded in field 041, in intranet search
results and in detail view.

Test plan:
1) Apply patch
2) Do a search, and check the results look correct
3) Check some biblio detail pages that they look correct
4) Add some 041 subfields (a, b, d, h, j) in any combinations
5) Repeat 2 and 3

Signed-off-by: Pasi Kallinen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #3 from Alex Buckley  ---
Created attachment 73362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362=edit
Bug 18889 - Storing and display of barcode with fines in intranet

Test plan:
1. Create a manual invoice fine making sure you enter in a barcode value

2. Go to the 'Pay fines' tab and notice that the barcode value is not
displayed

3. Apply patch

4. Update your database by running the updatedatabase.pl script in
koha-shell

This will run the atomicupdate file
bug_18889_added_barcode_field_to_accountlines.sql which contains the
database changes

5. Update your DBIx by running the command (in the Koha root directory):
misc/devel/update_dbix_class_files.pl --db_name= --db_user=
--db_pass=

6. Repeat step 1 and 2 and notice that there is a new front end column
in the 'Pay fines' page which displays the item barcode

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

  Attachment #69352|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20484] New: Can access /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl without the elasticsearch preference on

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484

Bug ID: 20484
   Summary: Can access
/cgi-bin/koha/admin/searchengine/elasticsearch/mapping
s.pl without the elasticsearch preference on
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Not a big deal, but one can access
/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl without the
Elasticsearch Search engine preference enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

--- Comment #1 from M. Tompsett  ---
Created attachment 73361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73361=edit
Bug 20482: Correct Terminology codes to Bibliographic ones

"RELATIONSHIP TO ISO 639-2
ISO 639-2 (Codes for the representation of names of
languages-- Part 2: alpha-3 code) was based on the MARC
Code List for Languages and published in 1998. In the 22
cases where the ISO 639-2 list has two alternative codes,
the bibliographic code is the same as the MARC code."
(http://www.loc.gov/marc/languages/introduction.pdf)

This leads me to believe that eus, mri, and sqi are
incorrect. The slk code was corrected on an earlier bug.

TEST PLAN
--
Apply patch
Do a database upgrade
-- Are eus, mri, and sqi fixed?
reset_all
-- Are eus, mri, and sqi never there in the first place?
koha qa test tools only check perl code.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20245

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20245] Wrong language code for Slovak

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20482

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20483] New: Allow users to delete specific borrower history entries, independent of of anonymising data

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20483

Bug ID: 20483
   Summary: Allow users to delete specific borrower history
entries, independent of of anonymising data
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Borrowers should be able to granularly delete or anonymise their own issuing
histories. Possibly we should only remove what the item was, not the entire
record of the checkout.

For example, if someone had issued 10 books in the past, but didn't want "the
three little pigs" to turn up in their history anymore, they should be able to
delete this. This borrower could either show a statistic of "10 issues" with
titles for 9, or we could remove the record of the issue altogether.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20482] New: language_rfc4646_to_iso639: Terminology codes instead of Bibliographic code

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20482

Bug ID: 20482
   Summary: language_rfc4646_to_iso639: Terminology codes instead
of Bibliographic code
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

While testing Bug 20245, other issues were also discovered.
See the following comment:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245#c4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20245] Wrong language code for Slovak

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72542|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 73360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73360=edit
Bug 20245: Wrong language code for Slovak

This patch updates iso639_2_code value for Slovak language

Test plan:
1) Obtain a biblio record having 'slo' value in its language
   code (marc field 041a)
2) Try to find it through Advanced search + more options
   with language set to Slovak
3) Nothing is found
4) Apply this patch
5) Repeat steps 1 and 2
6) Record is found now

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20245] Wrong language code for Slovak

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20245] Wrong language code for Slovak

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245

--- Comment #7 from M. Tompsett  ---
Based on reading from links given, I found this particular excerpt useful:
"RELATIONSHIP TO ISO 639-2
ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3
code) was based on the MARC Code List for Languages and published in 1998. In
the 22 cases where the ISO 639-2 list has two alternative codes, the
bibliographic code is the same as the MARC code."
(http://www.loc.gov/marc/languages/introduction.pdf)

As such, I'm leaning towards they should all be Bibliographic. So, I'm going to
sign this off. However, we should fix the others too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

--- Comment #4 from Alex Buckley  ---
When testing this I can email the videos of the test plan before and after
applying the patches because they are too large to attach to this bug report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #126 from Hugh Rundle  ---
This sounds like a great feature!

Just wondering about 'recall due date interval'. Will there be an option to not
change the due date at all? i.e. we just want to recall the item to cataloguing
maintenance when it's returned (and cut the queue if there are holds on the
title/item), but we're not in a huge hurry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

--- Comment #3 from Alex Buckley  ---
Created attachment 73359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73359=edit
Bug 19780 - Updating the invoice costs after updating the actual cost of an
order following the receival of the order

This patch builds on the previous patch attached to the bug report 19780.

The purpose of this patch is to fix the current bug in Koha which is if
you have accidently written in the incorrect value into an order
receival form then try to correct the value by clicking on the order
line link and writing in a new value into the actual value input field
of the order and then save the form and go and view the invoice you
notice that the invoice amount has not been updated to match the newly
entered actual value of the order.

This bug was reported by Horowhenua District Library

Now with this patch after clicking on the order line link and writing in
a new actual value for a received order the database is correctly
updated with the new actual value and if you now view the appropriate
invoice for that order you will notice that the invoice amount has been
updated.

To make the testing of this patch easier I have made a before and after
screencast video to compliment the test plan.

Updated test plan:
1. Create an order with the vendor price: 10.00 and actual price of
12.00

2. Close the order and receive the shipment. Change the actual price in
the receival page to 14.00

3. Open a new tab and view the invoice for the newly received order and notice
that 14.00 is the value displayed

4. In your first tab now click on the order line link to modify the order.
Change the actual price to 15.00

5. View the invoice now and notice that 14.00 is still the value being
displayed

6. Apply patch

7. Repeat steps 1,2,3,4 and 5 and notice that 15.00 is the value
displayed in the invoice

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - "Cannot process file as an image"

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898

--- Comment #12 from Craig  ---
(In reply to Craig from comment #11)
> (In reply to Jef Bucas from comment #10)
> > I got this problem on Debian Stretch with version 17.11.03-1.
> > 
> > Solution was to disable Systemd's Apache2's PrivateTmp flag.
> > 
> > /lib/systemd/system/apache2.service
> > --
> > [Unit]
> > Description=The Apache HTTP Server
> > After=network.target remote-fs.target nss-lookup.target
> > 
> > [Service]
> > Type=forking
> > Environment=APACHE_STARTED_BY_SYSTEMD=true
> > ExecStart=/usr/sbin/apachectl start
> > ExecStop=/usr/sbin/apachectl stop
> > ExecReload=/usr/sbin/apachectl graceful
> > PrivateTmp=false
> > Restart=on-abort
> > 
> > [Install]
> > WantedBy=multi-user.target
> > ---
> > 
> > systemctl daemon-reload
> > systemctl restart apache2
> 
> Hi Jef,
> 
> Thanks for this. I will try and disable later tonight and report back. To
> the community, just out of curiosity, would this problem in any way be
> related to setting a template cache directory, as specified here:
> https://wiki.koha-community.org/wiki/Performance?
> 
> Many thanks!

Hi everyone,

Can confirm Jef's fix above. I am now able to successfully upload a local cover
image. Jef, thanks again!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - "Cannot process file as an image"

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20455] Can't sort patron search on date expired

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73296|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73358=edit
Bug 20455: Fix sort patrons by date expired

We may need to apply this change for all other occurrences in our
codebase.

Test plan:
- Make sure sample patron data is loaded and you have a patron without a
date expired defined
- Make an empty search for all patrons or another search that gives you
a good amount of results
- Try to sort on the date expired column

=> Without this patch you get
Odd number of elements in anonymous hash
at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189.
output_pref is called with 'dateonly' (ref SCALAR), not a DateTime
object

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20455] Can't sort patron search on date expired

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
>8) Without patch you see "For loan" in items.notforloan for value 0
>9) With patch you see "Available" in items.notforloan for value 0

Still 'For loan' for me. Please fix test plan or patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20330] Allow translating more of quote upload

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20330

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73286|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 73357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73357=edit
Bug 20330: Allow translating more of quote upload

Translate the error messages, and the table headers.

Test plan:

1) Go to Home -> Tools -> Quote editor -> Import quotes
2) Upload quotes from a file. Try to trigger the error messages
3) On successful import, check the table header texts
4) Apply patch, update & install a language
5) The error messages and the table header texts should
   show up in the xx-YY-staff-prog.po
6) Repeat 1,2,3

Signed-off-by: Pasi Kallinen 

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20330] Allow translating more of quote upload

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20330

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #26 from Jonathan Druart  
---
And I messed up with the bug number when pushing the last patch...
  Bug 19583: Remove use of C4::AuthoritiesMarc
should have been
  Bug 19582: Remove use of C4::AuthoritiesMarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20386] Improve warning and error messages for Search Engine Configuration

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20386

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19739] Add default ES configuration to koha-conf.xml

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #24 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

--- Comment #23 from Jonathan Druart  
---
Created attachment 73356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73356=edit
Bug 19233: Restore styling of the button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #19 from Jonathan Druart  
---
It does not look correct to me:
https://screenshots.firefox.com/EeG5M4P78NVOdnr5/pro.kohadev.org

- Nothing is displayed on the screen
- The warning should not be displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #24 from Jonathan Druart  
---
Nick, please care about spaces and alignment:
In your patch it looks like:
-$query->param('value_any') || undef,
-$query->param('value_match')   || undef
+$query->param('value_match') || undef,
+$query->param('value_any')   || undef

With correct alignement:
+$query->param('value_match')   || undef,
 $query->param('value_any') || undef,
-$query->param('value_match')   || undef

Much easier to read, right?
Will be done on pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #23 from Jonathan Druart  
---
Please take care of commit messages and author:
  Author: Koha User 
  Bug 19582 - remove use of C4::AuthoritiesMarc

  Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #33 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #32)
> Should we remove the draft status from here?
> https://wiki.koha-community.org/wiki/Database_updates#DBIx::Class_.28DRAFT.29

Done

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |ere.maij...@helsinki.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #32 from Katrin Fischer  ---
Should we remove the draft status from here?
https://wiki.koha-community.org/wiki/Database_updates#DBIx::Class_.28DRAFT.29

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Charles Farmer  changed:

   What|Removed |Added

  Attachment #67882|0   |1
is obsolete||

--- Comment #21 from Charles Farmer  ---
Created attachment 73355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73355=edit
Bug 17983 - Tests for minutes loan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Charles Farmer  changed:

   What|Removed |Added

  Attachment #67881|0   |1
is obsolete||

--- Comment #20 from Charles Farmer  ---
Created attachment 73354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73354=edit
Bug 17983 - Enabled the use of minutes loan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Charles Farmer  changed:

   What|Removed |Added

  Attachment #67880|0   |1
is obsolete||

--- Comment #19 from Charles Farmer  ---
Created attachment 73353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73353=edit
Bug 17983 - Add Minutes math to DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

--- Comment #3 from M. Tompsett  ---
Created attachment 73352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73352=edit
Bug 19945: Follow up optimization and test correction

The double call to CanItemBeReserved was pointless in
the C4/Reserves.pm HoldItem, as CanBookBeReserved calls
CanItemBeReserved and even returns that code.

Additionally, the tests failed, because there were 5
tests not 4.

TEST PLAN
--
prove t/db_dependent/ILSDI_Services.t
run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70409|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 73351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73351=edit
Bug 19945 - ILSDI - Return the reason a reserve is impossible

Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=1_id=1_id=1)
 - you should get the reason instead of NotHoldable,

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets.

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Help plugin authors output headers correctly

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Problem with plugins and|Help plugin authors output
   |encodings   |headers correctly
  Text to go in the||The current plugin writing
  release notes||practice is to craft the
   ||response header in the
   ||controller methods. This
   ||patchset adds new helper
   ||methods for plugin authors
   ||to use when dealing with
   ||output on their plugins.
   ||This way the end-user
   ||experience is better, and
   ||the plugin author's tasks
   ||easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets.

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

--- Comment #3 from Kyle M Hall  ---
Created attachment 73350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73350=edit
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets

purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.

It uses a simple SQL query to determine which rows in accountlines need to be
removed:

463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467   AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }

The function comes with the following warning:

451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.

This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.

Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets.

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||cont...@alvet.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 73349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73349=edit
Bug 19223: Add methods to correctly handle plugin-generated output

This patch introduces two methods to be used by plugin authors:

->output
->output_html

They are basically wrappers for the helper methods from C4::Output
(output_html_with_http_headers and output_with_http_headers).

Plugin authors can use them, or keep the current flexibility of handling
the headers themselves in their code.

The KitchenSink plugin should be updated to highlight this.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: The methods are not implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass, and they are meaningful
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 73348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73348=edit
Bug 19223: Unit tests for output and output_html methods

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #9 from Tomás Cohen Arazi  ---
Common practice is to have the plugins print their output, but it is not
obvious that headers need to be generated correctly, etc. I will provide a
patch that adds helper methods, and this needs to be highlighted in the
KitchenSink plugin somehow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #18 from Jonathan Druart  
---
Jon,

  Total: [% selectedbasket.total | $Price %] ([% selectedbasket.currency %])
Will display: 42 (EUR) or 42 (USD)

With bug 4078 you can use the with_symbol flag to display the symbol.
  Total: [% selectedbasket.total | $Price with_symbol => 1
Will display: €42 or $42

I think it is what we want here.

Actually what we really want is: "42 €" and "$42", but it's not configurable
(yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #16 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #15)
> (In reply to Jonathan Druart from comment #13)
> > 1. It sounds like we should also modify circulation_batch_checkouts.tt
> 
> Follow-up submitted!

Thanks

> > 2. Are you sure we want this to apply to SIP and self-checkout?
> 
> Yes, the logic behind this is: if the patron is holding the book, they can
> check it out.

Should not we make it explicit in the syspref's description in that case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73346|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 73347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73347=edit
Bug 19233: (follow-up) Use a button to submit form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73345|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 73346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73346=edit
Bug 19233: (follow-up) Use a button to submit form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - "Cannot process file as an image"

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898

--- Comment #11 from Craig  ---
(In reply to Jef Bucas from comment #10)
> I got this problem on Debian Stretch with version 17.11.03-1.
> 
> Solution was to disable Systemd's Apache2's PrivateTmp flag.
> 
> /lib/systemd/system/apache2.service
> --
> [Unit]
> Description=The Apache HTTP Server
> After=network.target remote-fs.target nss-lookup.target
> 
> [Service]
> Type=forking
> Environment=APACHE_STARTED_BY_SYSTEMD=true
> ExecStart=/usr/sbin/apachectl start
> ExecStop=/usr/sbin/apachectl stop
> ExecReload=/usr/sbin/apachectl graceful
> PrivateTmp=false
> Restart=on-abort
> 
> [Install]
> WantedBy=multi-user.target
> ---
> 
> systemctl daemon-reload
> systemctl restart apache2

Hi Jef,

Thanks for this. I will try and disable later tonight and report back. To the
community, just out of curiosity, would this problem in any way be related to
setting a template cache directory, as specified here:
https://wiki.koha-community.org/wiki/Performance?

Many thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73344|0   |1
is obsolete||

--- Comment #20 from Nick Clemens  ---
Created attachment 73345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73345=edit
Bug 19233: (follow-up) Use a button to submit form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20374] New french intranet and opac unimarc xslt

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20374

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |stephane.del...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Jonathan Druart  changed:

   What|Removed |Added

 Comment #42 is|1   |0
private||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

--- Comment #43 from Jonathan Druart  
---
14:27 < tcohen> and I don't like code 'dying' instead of raising exceptions
14:29 < tcohen> I think rollback+exception should take place in the lib,
because the controller should consider the API call an atomic action, that can
fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #42 from Jonathan Druart  
---
14:27 < tcohen> I agree with you  on 20446
14:27 < tcohen> and I don't like code 'dying' instead of raising exceptions
14:29 < tcohen> I think rollback+exception should take place in the lib,
because the controller should consider the API call an atomic action, that can
fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

--- Comment #19 from Nick Clemens  ---
Created attachment 73344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73344=edit
Bug 19233: (follow-up) Don't use JS trickery to set form action

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|blocker |major

--- Comment #8 from Jonathan Druart  
---
Lowering severity as it looks more like a configuration issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |In Discussion

--- Comment #41 from Jonathan Druart  
---
(In reply to Alex Arnaud from comment #33)
> (In reply to Jonathan Druart from comment #31)
> > I do not understand why you put the transaction in the pl and not in the
> > method, are there any good reasons?
> 
> My opinion is that commit or rollback should not take place in the API. As
> Katrin asked, we could use merge_with to add this feature on the GUI. In
> this case, what is point to have the transaction in there ? Will we offer
> the ability to "test" before confirm on the GUI ?

Tomas, Can I get your opinion on this please? I am expecting the whole move to
be done in a transaction (handled by the method) and an exception raised if
something failed.

The dry-run mode could be done using nested transactions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #8 from Tomás Cohen Arazi  ---
Steps to reproduce:

- Install some translation:
  $ kshell
 k$ cd misc/translator
 k$ perl translate install es-ES
 k$ exit
  $ restart_all
- Enable es-ES in the sysprefs (languages)
- Choose 'Español'
- Upload a plugin
(https://github.com/bywatersolutions/koha-plugin-csv2marc/releases)
- Choose to configure the plugin
=> FAIL: Double-encoded chars on the header, everywhere actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #11 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #10)
> If I understand it correctly MarkLostItemsAsReturned should determine if the
> item is checked in on return or not, independent now of where you set the
> item lost status, correct? (bug 12363)
> 
> What's the difference this patch introduces? (sorry, ran out of time to
> check)

When an item is marked as lost when cataloguing (additem.pl), LostItem will be
called and the item checked in if MarkLostItemsAsReturned is set.
This is the expected behavior (I think): what the code wanted to do (but
failed) and it is what is done in other areas.

My concern is that we are going to fix a long standing bug and may break
librarian's workflows (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

--- Comment #9 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #8)
> Hi Owen, the toolbar on 'edit title' behaves better now, but a long title
> won't wrap (as it did before). Could you please take another look?

I can't reproduce this problem. Could you try again? Share a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #53 from M. Tompsett  ---
The question is does the in_ipset return the correct value for bad ranges?
Because currently, it assumes open when a bad range is provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382

--- Comment #20 from Jonathan Druart  
---
Created attachment 73343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73343=edit
Bug 18382: Add a test

This is what I am expecting but I may be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #19 from Jonathan Druart  
---
Kyle, I was not expecting your follow-up patch to work, I was expecting that
->suspend_hold would not update suspend_until

What is supposed to do:
  $hold->suspend_hold( $dt );
  $hold->suspend_hold;
?

I would expect suspend_until to be set to undef

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73318|0   |1
is obsolete||

--- Comment #52 from M. Tompsett  ---
Created attachment 73342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73342=edit
Bug 14407: Follow up to add test case and clean noise

Comment #28 has a /36 which is invalid CIDR.
This triggers a crash and noise.
This cleans up the crash and noise, and adds
test cases to check for them.

prove t/Auth.t
-- before missing null case, and /36 case.
-- after null case, and /36 with/without warnings.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73316|0   |1
is obsolete||

--- Comment #51 from M. Tompsett  ---
Created attachment 73341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73341=edit
Bug 14407: Follow up add missing atomic update

The patch only added the system preference for fresh installs.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70476|0   |1
is obsolete||

--- Comment #50 from M. Tompsett  ---
Created attachment 73340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73340=edit
Bug 14407: Unit tests for in_ipset

TEST PLAN
-
1) apply all pathches
2) sudo koha-shell -c bash kohadev
   prove t/Auth.t
   -- should run.
3) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70475|0   |1
is obsolete||

--- Comment #49 from M. Tompsett  ---
Created attachment 73339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73339=edit
Bug 14407: Allow restricting SCO to IP or IP range

Converted this to actual applicable patches.
I think the test plan is comment #28. -- Mark Tompsett

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #48 from M. Tompsett  ---
(In reply to Marc Véron from comment #28)
> - Set SelfCheckAllowByIPRanges to 192.168.1.1 192.168.1.0/36
>   as described for syspref SelfCheckAllowByIPRanges
>   Internal Server Error
>   Plack error log says;
>   36, as in '192.168.1.30/36', does not make sense at
> /home/marc/koha/C4/Auth.pm line 2058.
> 
> Is it a bug or a wrong description for SelfCheckAllowByIPRanges?

36 is not valid. 8+8+8+8 = 32. Why would you have a number bigger than 32 on an
IPv4 address?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #47 from M. Tompsett  ---
kohadevbox is triggered from 192.168.50.1, so testing 192.168.0.0/16 worked
nicely. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19870] Loaned items show as available unless logged in

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|oleon...@myacpl.org |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

--- Comment #5 from Owen Leonard  ---
Created attachment 73338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73338=edit
Bug 19892 (follow-up) Replace one more instance

This patch replaces one more instance of [% IF ( numbersphr ) %].

To test, apply the patch and view the source of the OPAC home page.

With the OPACNumbersPreferPhrase system preference set to 'use,' you
should find this in the HTML source:

Call number

With the preference set to 'don't use,' you should find this:

Call number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #5 from Jonathan Druart  
---
I cannot push this patch as it, we need to prove libhttp-oai-perl v3.27
To do that it needs to be tested on debian 9 to make sure dependencies are not
broken if another is installed.

Marked as Blocked until someone tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20480] Fix styling issues on bad SCI/SCO module logins

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20480] Fix styling issues on bad SCI/SCO module logins

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various

2018-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 204 matches

Mail list logo