[Koha-bugs] [Bug 9701] Configure default indicators

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This report adds default|This adds default
  release notes|indicators to biblio|indicators to bibliographic
   |frameworks. Table   |frameworks. The table
   |marc_tag_structure is   |marc_tag_structure is
   |adjusted. In order to make  |adjusted. In order to make
   |effective use of this   |effective use of this
   |enhancement, you may want   |enhancement, you may want
   |to add values in MARC   |to add values in your MARC
   |frameworks administration.  |frameworks administration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #37 from Katrin Fischer  ---
(In reply to M. Tompsett from comment #34)
> (In reply to Katrin Fischer from comment #33)
> > Maybe something like this?
> > https://thenounproject.com/search/?q=application=1490070
> > https://thenounproject.com/search/?q=windows=1088956
> > https://thenounproject.com/search/?q=windows=375632
> 
> All these download at 700x700, when we need 16x16. And something about a
> black icon makes it an ugly contrast to the colorful firefox icon.

Hi Marc, those are available as SVG vector graphics that can be resized to any
size and colored any way you want. You can even download different colores. I
also checked all are licensed under CC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #16 from Katrin Fischer  ---
(In reply to Bouzid Fergani from comment #15)
> Hi,
> 
> I not obtain the same result as zebra with applying this patch.
> I try the simple search : test using operator contain
>  in zebra i have : 4 results
>  In ES, I have : 2 results
> without this patch, I obtain :
>   In zebra i have : 4 results
>   In ES, I have : 1 result
> Thanks.
> Bouzid.

Hi Bouzid, it's hard to tell, if that's right or wrong from your description..
We can't always expect the same results. What was your search? On which kind of
data? Which results where missing you had expected to be included?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18202] Define profiles for Z39.50 server targets

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11297

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #69 from David Cook  ---
I was just thinking about
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 and how it
really relates to this...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add important constraint to |Add important constraint to
   |marc tags and subfields |MARC tags and subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #36 from Liz Rea  ---
I feel like, as and when we have a desktop application that is actually
compiled and readily available for other platforms, it doesn't make sense to
change it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #35 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #32)
> I'd prefer another icon for the "get desktop application" link.
> The KOC app is written in Qt and could be compiled for different OS.
> 
> I think we should choose an icon representing a generic desktop app.

How about we push this, because the rest is a significant improvement, and then
discuss this one icon issue on a separate bug? Because I'd hate to see these
get stuck in discussion forever, because of one annoying icon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #34 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #33)
> Maybe something like this?
> https://thenounproject.com/search/?q=application=1490070
> https://thenounproject.com/search/?q=windows=1088956
> https://thenounproject.com/search/?q=windows=375632

All these download at 700x700, when we need 16x16. And something about a black
icon makes it an ugly contrast to the colorful firefox icon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #15 from Katrin Fischer  ---
Took the chance to fix a tiny capitalization error pointed out by the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74154|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 74194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74194=edit
Bug 20515: (follow-up) Add missing CAN_user_ill

This follow up patch adds two missing CAN_user_ill tests in templates

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

--- Comment #14 from Katrin Fischer  ---
Created attachment 74195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74195=edit
Bug 20515: (QA follow-up) Fix capitalization on 'Ill Requests'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #33 from Katrin Fischer  ---
Maybe something like this?
https://thenounproject.com/search/?q=application=1490070
https://thenounproject.com/search/?q=windows=1088956
https://thenounproject.com/search/?q=windows=375632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer  ---
Hi Kyle, 

it works now!

Can you please fix the remaining issues in a follow-up?

- Fix capitalization on notice templates: Account Writeoff, Account Payment
- Add notices to other installers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19974

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8484

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #50 from Katrin Fischer  ---
Hi Aleisha, 

I have added a follow-up, to adapt your patches to the recent changes from bug
20538. Then I've started testing, but I can't add a note from the OPAC:

No property noteseen for Koha::Checkout

I've run the database update and updated the Schema, but keep getting this
error.

Can you please fix?

The last follow-up I would have counted for a QA follow-up as the changes are
clearly what I asked for. If this is a small fix, consider changing back to
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #49 from Katrin Fischer  ---
Created attachment 74193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74193=edit
Bug 17698: (QA follow-up) Changes to use Asset TT plugin (bug 20538)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|In Discussion   |Patch doesn't apply

--- Comment #15 from Katrin Fischer  ---
Do we need to decide here if we want to support ATOM or RSS as a standard? 

We have had reports about the RSS feed not working and I'd like to help get
things moving here again. Patches currently don't apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer  changed:

   What|Removed |Added

Summary|opac-detail.pl -- Series|Correctly URI-encode URLs
   |link fails when series  |in XSLT result lists and
   |title ends with semicolon   |detail pages
   |preceded by space   |
 Status|Needs Signoff   |Failed QA

--- Comment #36 from Katrin Fischer  ---
Hi Ere, 

you tend to create quite big patch sets - often it's better to split things up
a bit to ease testing. That will make it easier for sign-offers.
For example you could have one patch for MARC21 and one for UNIMARC here.
NORMARC might not be necessary, as of bug 18984.

>From testing (MARC21):

1) URLs to external sources are broken at least in intranet result an detail
page:
Example:
http://localhost:8081/cgi-bin/koha/catalogue/http%3A%2F%2Fwww.loc.gov%2Fcatdir%2Fdescription%2Frandom048%2F90032101.html

2) Shoudl the comma behind publisher not be encoded?
http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Provider:%22Vintage%20Books%2C%22
Record is from the sample data: Opus posthumous / by Wallace Stevens. 

Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #68 from Katrin Fischer  ---
Comment on attachment 73583
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73583
Bug 14570 - Make it possible to add multiple guarantors to a record

Review of attachment 73583:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14570=73583)
-

Hi Kyle,

this is a huge patch with several consequences. Lots to test. Not nearly done
yet.

1) Release notes
Should state consequences to:
- patron import (no change, but can only import with one guarantor?)
- LDAP and SIP (lines where changed, but only in POD?)
- patron REST API (guarantor information can't be changed or asked for)
- Reports using borrowers.guarantorid have to be changed/rewritten
...

2) QA script
 FAIL   opac/opac-user.pl
   FAIL   valid
"my" variable $patron masks earlier declaration in same scope

 FAIL   Koha/Patron/Relationships.pm
   FAIL   pod 
Spurious =cut command
*** ERROR: 
 in file Koha/Patron/Relationships.pm
   FAIL   pod coverage
POD is missing for 'object_class'

 FAIL   Koha/Patron.pm
   FAIL   pod coverage
POD is missing for 'has_permission'

3) New unit tests pass.

4) Tests in GUI

Testing this, something doesn't seem to be quite right. 

a) I tried adding a guarantor from a Teacher (Professional) and from a Kid
(Child) account. Both don't offer the form to me.

b) Using the 'add child' from an existing patron (Adult), a new form opens for
an adult patron category, the guarantor information is empty.


5) Code review (splinter):

::: Koha/Patron.pm
@@ +119,5 @@
>  
>  return scalar Koha::Patron::Images->find( $self->borrowernumber );
>  }
>  
> +=head3 library

Please add a description here too, not just an empty entry. QA tools will be
happy with this, but the missing POD never fixed.

@@ +135,5 @@
>  
> +Returns the set of relationships for the patrons that are guarantors for 
> this patron.
> +
> +This is returned instead of a Koha::Patron object because the guarantor
> +may not exist as a patron in Koha. If this is true, the guarantors name

This is quite a change - is it really implemented in this patch set? What's the
use case? Just a name is not a lot to locate the person if needed.

::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
@@ -17,5 @@
>  [% IF CAN_user_borrowers_edit_borrowers %]
>  [% IF patron.is_adult AND Koha.Preference("borrowerRelationship") %]
>   href="/cgi-bin/koha/members/memberentry.pl?op=addguarantorid=[% 
> patron.borrowernumber %]"> Add child
>  [% END %]
> -[% IF CAN_user_borrowers_edit_borrowers %]

This change doesn't look like it was intentional/related. Please check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|indr...@l2c2.co.in  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Katrin Fischer  ---
Appears to works well, marking signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74114|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 74192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74192=edit
Bug 13655: Allow creation of organisations without entering userid

See comment 1 of the bug report for defails of the issue.

Test plan:
Good luck (you will need to test all combinations (category type eq and
ne 'I'), then quick edition and partial edit)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20585] New: Label surname as name for organisation type patrons

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Bug ID: 20585
   Summary: Label surname as name for organisation type patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

I would be nice to consistently label 'surname' as 'name' for patrons of an
organisation type category.

- when adding/editing a patron of this type
- on details tab
- ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer  changed:

   What|Removed |Added

Summary|Truncation disables |Using QueryAutoTruncate
   |relevance ranking   |breaks relevance ranking

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer  changed:

   What|Removed |Added

Summary|Truncation disables |Truncation disables
   |relevance ranking when not  |relevance ranking
   |using QueryParser   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |critical
 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
I am upping severity here since a lot of people use QueryAutoTruncate unaware
of it breaking Relevance and falsely assuming Koha can't do better. If we can't
fix it, we should add a warning to the system preference description of
QueryAutoTruncate.

Old patch doesn't apply any longer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #124 from Katrin Fischer  ---
Checked the patches, QA tools still pass, no differences found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #136 from Katrin Fischer  ---
I am very sorry, this doesn't apply for me. I tried to fix it, but I got stuck
with the last 3 patches:

Applying: Bug 11317: (Follow-up) Fix tab chars and move javascript to the
footer
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 11317: (Follow-up) Fix tab chars and move javascript
to the footer
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am -i --continue".
If you prefer to skip this patch, run "git am -i --skip" instead.
To restore the original branch and stop patching, run "git am -i --abort".

Please also note that bug 20538 will require some changes, but they should be
fast!

For the path, I am no expert. Maybe lean on the sample paths for uploaded files
or plugins?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74168|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 74191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74191=edit
Bug 18007: Interface updates to notices and notice previews

This patch makes changes to the form for adding and editing notices, and
to the template for viewing a rendered preview of notices.

- Preview now shows side-by-side comparisons
- JavaScript has been movied out of template into separate file
- Validation of the add/edit form improved through use of validation
  plugin

To test, apply the patch on top of those for Bug 17981

- Add a new notice.
  - Confirm that the form can't be submitted without data in the "code"
and "name" fields.
  - Confirm that the form can't be submitted without filling in at least
one message template (subject and body).
  - Confirm that you cannot submit the form while using an
existing notice code.
  - Follow Bug 17981's test plan for testing the preview function.
Confirm that the preview loads correctly and looks correct.
- Test both with old syntax messages which require conversion and
  messages in template-toolkit syntax.

Signed-off-by: Katrin Fischer 
Fixed conflicts caused by bug 20538.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20577] Script to go through catalogue removing the 998 MARC tag data

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20577

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20577] Script to go through catalogue removing the 998 MARC tag data

2018-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20577

--- Comment #3 from Alex Buckley  ---
Hi Katrin

Yes I think you're right this patch is not upstreamable as it is too specific. 

The use case that prompted me to write this script is that one of our clients
had migrated data across to Koha, and in this migrated data the marcxml
contained barcodes in the 998$a MARC subfield. 

As the 998 MARC field is not updated when moving an item from one biblio to
another the old biblio (as well as the new biblio) continued to be displayed in
search results for the moved items barcode.

Therefore running this script to remove the 998 field stopped this indexing bug
from happening. This script could be useful if it was made more generic so a
MARC subfield in migrated data could be specified to be removed where it is not
necessary or it is causing indexing errors. However I will park this at the
moment.

A patch that would be useful to get your feedback on is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 which is fixing
the broken patron filtering on the patron page in the intranet as that is quite
a major bug. 

Cheers,
Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/