[Koha-bugs] [Bug 20594] Revert Perl version to 5.10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20594 --- Comment #3 from M. Tompsett--- Okay, then can I squash them both and call the refactor an enhancement? Clearly, touching the version number is up for discussion on koha-devel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20603] Remove unused subs from C4::Accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsettchanged: What|Removed |Added Attachment #74425|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 74512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74512=edit Bug 20603: Remove ModNote, getcredits and getrefunds from C4::Accounts Test plan: 0) Do not apply the patch 1) Run these 3 commands git grep ModNote git grep getcredits git grep getrefunds all should return occurances only in C4/Accounts.pm - the sub definition and in t/db_dependent/Accounts.t 2) Apply the patch 3) Run commands from 1) again, now there should be no occurence 4) prove t/db_dependent/Accounts.t should return green Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20603] Remove unused subs from C4::Accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 M. Tompsettchanged: What|Removed |Added Blocks||20603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 [Bug 20603] Remove unused subs from C4::Accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20225] Remove unused script reports/stats.print.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 M. Tompsettchanged: What|Removed |Added Blocks||20603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 [Bug 20603] Remove unused subs from C4::Accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20603] Remove unused subs from C4::Accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20603 M. Tompsettchanged: What|Removed |Added Depends on||18643, 20225 CC||mtomp...@hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Remote DB installation fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 --- Comment #14 from M. Tompsett--- Created attachment 74511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74511=edit Bug 16690: Make DB_HOST environment variable override. Actually use __WEBSERVER_HOST__ in rewrite-config.PL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 jdem...@roseville.ca.uschanged: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Remote DB installation fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 --- Comment #13 from M. Tompsett--- Created attachment 74510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74510=edit Bug 16690: Simplify and correct the SHOW GRANTS MySQL / MariaDB allow the current connected user to check their own grants with CURRENT_USER. There is no need for the installer to know the IP address of the webserver. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Remote DB installation fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 --- Comment #12 from M. Tompsett--- Oo... CURRENT_USER is ANSI 1999. Anyone object to simpler code? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #14 from Katrin Fischer--- Was this intentional? +use Data::Printer colored => 1; warn p $subscription; If possible I think the success message for batch renewal would be better without the pop-up and just on the page above the table with the usual markup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20610] Add BULAC to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Adds a library |Add BULAC to about page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer --- I am sorry, but this doesn't work for me. The GUI works nicely, select/unselect all and link logic. But: When I click on the link, I get a pop up with a sucess message that the subscriptions have been renewed. But when I repeat my search, the expiration date hasn't changed. When I try to renew the subscription nanually using the 'renew button' the pop-up asks about the duration for the renewal and the expiration date is correctly updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Remote DB installation fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #11 from M. Tompsett --- I'm having difficulty retesting my own patch, so I've changed the status back to ASSIGNED, while I looking into this. I blame plack. ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Katrin Fischerchanged: What|Removed |Added Attachment #74500|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 74509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74509=edit Bug 20614: Use GET instead of POST for subscription renewing It will prevent Firefox (and certainly other browsers) to block the form resubmit: "To display this page, Firefox must send information that will repeat any action (such as a search or order confirmation) that was performed earlier." Test plan: Renew a subscription and save => You should not longer see the browser warning Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #57 from Katrin Fischer--- Oh, and please also fix git commit messages! https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischerchanged: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #56 from Katrin Fischer --- The patch no longer applies, can you please check? Maybe you did the last change without Owen's follow-up? Please also take a comment at c#55! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17614] Introduce multiple fine charging intervals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17614 --- Comment #5 from Katrin Fischer--- (In reply to Fiona Borthwick from comment #4) > Katrin - your comment above does go some way to achieving this but I have > another scenario that has just come in today. > > Our customer have imposed new fining structures which do not increment at > the same value on a weekly basis. > > Overdue items - 1 week £0.25 per item > Overdue items - 2 weeks£0.50 per item > Overdue items - 3 weeks £0.80 per item > Overdue items - 4 weeks£1.00 per item > Overdue items - 5 weeks£1.30 per item > Overdue items - 6 weeks£1.50 per item > Overdue items - 7 weeks£1.80 per item > Overdue items - 8 weeks £2.05 per item > Overdue items - 9 weeks£2.30 per item > Overdue items - 10 weeks£2.60 per item > Overdue items - 11 weeks£2.80 per item > > As you can see from this, week 1 and 2 would be catered for using the start > of interval and 7 day interval but week 3 does not go up to £0.75 - it goes > up to £0.80. > > Some development in this area to allow customers to create a graduated > fining structure would be very welcome. Hi Fiona, that matches what a lot of libraries in Germany do actually. I've a 'hack' in fines.pl that does a bit of this, but I've failed at imagining how we could implement this properly, especially the GUI. Probably a separate page? Pop-up from the issuingrules table? Maybe as it's a bit of a different problem (not about fine charging interval but about the actual fine) we should continue discussion on a different bug? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer --- Hi Aleisha, QA script passes with the exception of the commit message descriptions. Could you please fix with the next iteraton? (https://wiki.koha-community.org/wiki/Commit_messages) 1) borraccount.tt + Original date + Updated Maybe make this "Created" or "Creation date" and "Updated". Not sure original date will be understood, thinking of translation too. Why the change from Writeoff to Written off? The last table row (total due) is not correctly formatted with the patch (empty last cell). 2) printfeercpt.tt Table layout is broken by the patch here too. Same for terminology as above. 3) cash_register_stats.tt Table layout is broken here too (last total row). Stopping here. Please consider if changing the description would make sense and recheck the other changed templates for layout problems too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Status|Passed QA |Failed QA --- Comment #39 from Katrin Fischer --- Puh, ok, I found a problem: When we push this as is, we will immediately start sending out payment and writeoff notices after update. Libraries might not expect that to happen and it smells trouble, especially since you'd want to translate/adapt the notice. I think the easisest solution would be to not add them with a database update. We could put the sample notices on a wiki page instead, so people can easily add them. Or into the manual. Or: We could add a system preference to determine when to send them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Attachment #74424|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 74508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74508=edit Bug 19191: Add non-english notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Attachment #74423|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 74507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74507=edit Bug 19191: Fix capitalization of notice titles Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Attachment #74095|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 74505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74505=edit Bug 19191: Remove need for bug 19966 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Attachment #74105|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 74506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74506=edit Bug 19191: Add correct unit tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Katrin Fischerchanged: What|Removed |Added Attachment #74094|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 74504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74504=edit Bug 19191: Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Text to go in the|Adds the ability to handle |Adds the ability to handle release notes|patron-level API keys to be |patron-level API keys to be |used for authenticating the |used for authenticating the |REST api. |REST API. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druartchanged: What|Removed |Added Attachment #74426|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #114 from Jonathan Druart--- 2. Why not a foreign key on aqorders.created_by (with on delete set null)? 3. orderreceive.tt and showorder.tt must use patron-title.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Failed QA --- Comment #113 from Jonathan Druart --- Bug 12395: Save order line's creator reverts bug 20303 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Failed QA --- Comment #19 from Jonathan Druart --- 1. >From Koha::SearchFields->weighted_fields +while ( my $field = $fields->next ) { +push @$w_fields, $field->name; +push @$weight, $field->weight; +} + +return ($w_fields, $weight); >From search.pl: ($w_fields, $weight) = Koha::SearchFields->weighted_fields(); then we call build_query_compat with { w_fields => @$w_fields, weight => @$weight } which will finally do: +if ( defined $weights[0] ) { +for (my $i = 0 ; $i < (scalar @weights) ; $i++ ){ +push @fields, "$w_fields[$i]^$weights[$i]"; +} +} so basically you want to fetch the weighted fields from build_query_compat, with something like: push @fields, sprintf("%s^%s", $_->name, $_->weight) for Koha::SearchFields->weighted_fields; That seems much more easier, what did I miss? 2. Sounds like you could replaced the loop in is_mapped_biblios, with $self->search_marc_maps->search({ index_name => 'biblios' })->count ? 1 : 0; 3. search_marc_maps reads wrong too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druartchanged: What|Removed |Added Keywords||release-notes-needed, ||rel_18_05_candidate --- Comment #54 from Jonathan Druart --- We should also update https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druartchanged: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Working_with_staf ||f_client_SCSS --- Comment #53 from Jonathan Druart --- Owen, could you add, on the wiki page, a list of the files bug 19474 and bug 20427 are going to add to our codebase? And tell what is the purpose in front each one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org URL||https://wiki.koha-community ||.org/wiki/Working_with_staf ||f_client_SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #52 from Jonathan Druart--- Could we imagine to have a staff-global.css and staff-global.min.css It would depend on the dev_install config flag, devs will use .css whereas production installations will use .min.css The .min.css would be generated only on releasing (and will avoid to pollute the git log). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9302] Add ability to merge patron records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #54 from Jonathan Druart--- Thanks for the follow-ups. (In reply to Jonathan Druart from comment #38) > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING? > How are we going to keep it up-to-date? Answer still needed. (In reply to Jonathan Druart from comment #39) > 4. on /members/merge-patrons.pl?id=19=5=45=21 the [+][-] links in > the header do nothing > (https://screenshots.firefox.com/kq2LyGsluEr0ir7F/pro.kohadev.org) > > 5. After this confirmation screen: > https://screenshots.firefox.com/h9NQITzesVqeVQm6/pro.kohadev.org > I see these 3 holds: > https://screenshots.firefox.com/ZfjbD6PZWOBYv3Je/pro.kohadev.org > > It's not clear to me what happened. Answering to myself: So it's not the holds that have been transferred in the sense we use it usually, that was I was confused. Errors handling should be polished a bit. For instance I am seeing these screens when id or keeper does not match valid borrowernumbers: https://screenshots.firefox.com/nIgsc8xOpLHvuqXC/pro.kohadev.org https://screenshots.firefox.com/VTKYZNqBS3L8B5cq/pro.kohadev.org https://screenshots.firefox.com/gEGiMi16yknuyrZU/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20610] Adds a library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 Séverine Queunechanged: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #3 from Séverine Queune --- (In reply to claire.hernan...@biblibre.com from comment #1) > Created attachment 74435 [details] [review] > Bug 20610: Adds a library > > Test plan: > 1) Apply bug patch > 2) Go to staff interface > About page > Koha Team > 3) See a new entry "BULAC" Nice one Claire :) Thanks ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20610] Adds a library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 Séverine Queunechanged: What|Removed |Added Attachment #74435|0 |1 is obsolete|| --- Comment #2 from Séverine Queune --- Created attachment 74503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74503=edit Bug 20610: Adds a library Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20610] Adds a library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 Séverine Queunechanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Text to go in the||Adds the ability to handle release notes||patron-level API keys to be ||used for authenticating the ||REST api. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druartchanged: What|Removed |Added Summary|Batch renewal of serials|Batch renewal of serials |and order creation | --- Comment #12 from Jonathan Druart --- Updating the bug report title, the "order creation" bit is not part of these patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com --- Comment #29 from Tomás Cohen Arazi --- (In reply to Dilan Johnpullé from comment #28) > Created attachment 74402 [details] [review] > Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt > > Patch applies and functions as described. > Signed-off-by: Dilan Johnpullé Dilan, it seems you only uploaded the last signed patch. You need to do the same with all the patches. You can try $ cd kohaclone $ git fetch $ git checkout origin/master -b qa_20400 $ git bz apply -s 20400 # then $ git bz attach 20400 HEAD~5.. Ask on IRC if you have trouble doing it. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20615] New: add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Bug ID: 20615 Summary: add the link of number of times the authority are used in edit mode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: patrick.robitai...@collecto.ca QA Contact: testo...@bugs.koha-community.org Hi, in the authorities module, when we consult a record there is a line at the top of the page indicating the number of records for which this authority is being usaed in. But this line disappears when you go into edit mode of the record. It would be convenient to keep this information on edit mode too. Thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16808 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20614 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Jonathan Druartchanged: What|Removed |Added Blocks||7910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 [Bug 7910] Batch renewal of serials and order creation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druartchanged: What|Removed |Added Depends on||20614 QA Contact|koha.sek...@gmail.com | --- Comment #11 from Jonathan Druart --- The original patch did not work at all, I had to rewrite from scratch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 [Bug 20614] Firefox prevents parent page reload when renewing subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #10 from Jonathan Druart--- Created attachment 74502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74502=edit Bug 7910: Give feedack when the subscriptions have been renewed - useless? This patch adds a message to the user to let them know the subscription have been renewed successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druartchanged: What|Removed |Added Attachment #10737|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 74501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74501=edit Bug 7910: Add the ability to renew several subscriptions at once This patch adds a "Renew all selected subscriptions" action link on top of the table of the "Check expiration" page. It will allow to auto-renew several subscriptions. Test plan: Make sure this new link renew the selected subscriptions as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 --- Comment #1 from Jonathan Druart--- Created attachment 74500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74500=edit Bug 20614: Use GET instead of POST for subscription renewing It will prevent Firefox (and certainly other browsers) to block the form resubmit: "To display this page, Firefox must send information that will repeat any action (such as a search or order confirmation) that was performed earlier." Test plan: Renew a subscription and save => You should not longer see the browser warning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20614] New: Firefox prevents parent page reload when renewing subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20614 Bug ID: 20614 Summary: Firefox prevents parent page reload when renewing subscriptions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com On "Home › Serials › Check expiration", the "Renew" buttons open a popup which will reload the parent page when closed. But Firefox prevents the page to reload (form resubmit): "To display this page, Firefox must send information that will repeat any action (such as a search or order confirmation) that was performed earlier." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #23 from Séverine Queune--- (In reply to Jonathan Druart from comment #22) > (In reply to Séverine Queune from comment #20) > > > Some values are not displayed in the table : > > - item type > > - additional subscription fields > > I have added item type in the last version of the patch. > I consider the additional subscription fields out of my scope. > Ok for me for item type ! Let' open a new ticket for additionnal subscription fields :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Julian Mauricechanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Julian Mauricechanged: What|Removed |Added Attachment #74483|0 |1 is obsolete|| --- Comment #7 from Julian Maurice --- Created attachment 74497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74497=edit Bug 20612: Unit tests This patch makes the oauth.t tests leverage on the new Koha::ApiKey(s) classes. It adds tests for expired tokens too. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests should fail without the rest of the patches. Sponsored-by: ByWater Solutions Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Julian Mauricechanged: What|Removed |Added Attachment #74484|0 |1 is obsolete|| --- Comment #8 from Julian Maurice --- Created attachment 74498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74498=edit Bug 20612: Make OAuth2 use patron's client_id/secret pairs This patch wires the OAuth related code so it leverages on the new Koha::ApiKey(s) classes and tools introduced by bug 20568 instead of the hardcoded entries in koha-conf.xml originally proposed by bug 20402. To test revisit the test plan for bug 20402, and verify that it works. But create API key pairs instead of writing them down in koha-conf.xml. Also: - Run: $ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Julian Mauricechanged: What|Removed |Added Attachment #74485|0 |1 is obsolete|| --- Comment #9 from Julian Maurice --- Created attachment 74499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74499=edit Bug 20612: koha-conf.xml cleanup Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20613] Alert staff about missing email address when accepting or rejecting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20613 Katrin Fischerchanged: What|Removed |Added Summary|Alert staff about missing |Alert staff about missing |email when accept or reject |email address when |a suggestion|accepting or rejecting a ||suggestion CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74454|0 |1 is obsolete|| --- Comment #45 from Julian Maurice --- Created attachment 74492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74492=edit Bug 20568: (follow-up) Atomic update fix Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74477|0 |1 is obsolete|| --- Comment #47 from Julian Maurice --- Created attachment 74494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74494=edit Bug 20568: (QA follow-up) Make sure client_id and secret are not overwritten on store Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74480|0 |1 is obsolete|| --- Comment #48 from Julian Maurice --- Created attachment 74495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74495=edit Bug 20568: (QA follow-up) Get rid of the id column Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74482|0 |1 is obsolete|| --- Comment #49 from Julian Maurice --- Created attachment 74496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74496=edit Bug 20568: CSRF protection Edit: fix warning introduced by this patch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74476|0 |1 is obsolete|| --- Comment #46 from Julian Maurice --- Created attachment 74493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74493=edit Bug 20568: (QA follow-up) Test client_id and secret are not overwritten Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74389|0 |1 is obsolete|| --- Comment #44 from Julian Maurice --- Created attachment 74491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74491=edit Bug 20568: Move value => client_id + secret This patch addresses the request from Julian that api keys are expected to be client id/secret pairs. It does so by - Adding 'client_id' and 'secret' columns - Removing 'value' Tests got adjusted and so controller scripts and templates. Both libs and tests changes have been squashed. This ones remain in order to keep Owen's attribution on the template changes and avoid rebase conflicts. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74346|0 |1 is obsolete|| --- Comment #42 from Julian Maurice --- Created attachment 74489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74489=edit Bug 20568: API key management for OPAC users This patch makes the OPAC interface for API keys management work with the new lib. Verify all actions work for a logged user. Users without login should be redirected to an error page. The AllowPatronsManageAPIKeysInOPAC syspref is added to control if the OPAC feature is enabled or not. To test: - Verify the syspref works - Verify users can manage their API keys Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74388|0 |1 is obsolete|| --- Comment #43 from Julian Maurice --- Created attachment 74490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74490=edit Bug 20568: (follow-up) Interface and markup changes This patch makes some interface changes to bring things better in line with existing interface patterns. This patch also re-indents the modified templates with 4 spaces instead of 2 and makes s self-closing. Also changed: Corrected system preference check in opac-apikeys.pl. To test, apply the patch and: In the staff client: - Open a patron record and choose More -> Manage API keys. - There should be a standard message dialog containing a link to "Generate a new key." - Clicking the link should show the form for adding a new key. - Test that clicking the "Cancel" link hides the form. - Test that creating the new key works correctly. - You should now see a table showing existing keys and a "Generate a new key" button above it. - Test that the "Delete" button asks for confirmation, and that confirming and denying both work correctly. - Test that "Revoke" and "Activate" actions still work correctly. In the OPAC: - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Allow." - Log in to the OPAC and click the "your API keys" link in the sidebar. - Clicking the "Generate new key" button should display the form for adding a new key. - Clicking the "cancel" link should hide the form. - Submitting the form should add a new key. - You should now see a table showing existing keys. - Test that the "Delete" link asks for confirmation, and that confirming and denying both work correctly. - Test that "Revoke" and "Activate" actions still work correctly. - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Don't allow." - Log in to the OPAC and confirm that the "your API keys" link in the sidebar is no longer visible. - Confirm that navigating directly to /cgi-bin/koha/opac-apikeys.pl results in a 404 error. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74345|0 |1 is obsolete|| --- Comment #41 from Julian Maurice --- Created attachment 74488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74488=edit Bug 20568: Unit tests This patch adds unit tests for the introduced classes: Koha::ApiKey(s). To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/ApiKeys.t => FAIL: Tests fail because the feature is not implemented. Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74343|0 |1 is obsolete|| --- Comment #39 from Julian Maurice --- Created attachment 74486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74486=edit Bug 20568: API keys management in interface This introduces the concept of API keys for use in the new REST API. A key is a string of 32 alphanumerical characters (32 is purely arbitrary, it can be changed easily). A user can have multiple keys (unlimited at the moment) Keys can be generated automatically, and then we have the possibility to delete or revoke each one individually. Test plan: 1/ Go to staff interface 2/ Go to a borrower page 3/ In toolbar, click on More -> Manage API keys 4/ Click on "Generate new key" multiple times, check that they are correctly displayed under the button, and they are active by default 5/ Revoke some keys, check that they are not active anymore 6/ Delete some keys, check that they disappear from table 7/ Go to opac interface, log in 8/ In your user account pages, you now have a new tab to the left "your API keys". Click on it. 9/ Repeat steps 4-6 Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Attachment #74344|0 |1 is obsolete|| --- Comment #40 from Julian Maurice --- Created attachment 74487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74487=edit Bug 20568: Add mandatory description field for api keys This patch changes the table structure adding fields usually found on this kind of api management pages. Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74474|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 74484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74484=edit Bug 20612: Make OAuth2 use patron's client_id/secret pairs This patch wires the OAuth related code so it leverages on the new Koha::ApiKey(s) classes and tools introduced by bug 20568 instead of the hardcoded entries in koha-conf.xml originally proposed by bug 20402. To test revisit the test plan for bug 20402, and verify that it works. But create API key pairs instead of writing them down in koha-conf.xml. Also: - Run: $ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74475|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 74485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74485=edit Bug 20612: koha-conf.xml cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74473|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 74483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74483=edit Bug 20612: Unit tests This patch makes the oauth.t tests leverage on the new Koha::ApiKey(s) classes. It adds tests for expired tokens too. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests should fail without the rest of the patches. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20613] Alert staff about missing email when accept or reject a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20613 Patrick Robitaillechanged: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74481|0 |1 is obsolete|| --- Comment #38 from Tomás Cohen Arazi --- Created attachment 74482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74482=edit Bug 20568: CSRF protection Edit: fix warning introduced by this patch Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added CC||oleon...@myacpl.org --- Comment #37 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #30) > QA comments: > > 1) The UUID generation happens in the store method. This means that every > time I revoke/activate a key, client_id and secret are changed. I think that > is not the desired behaviour. Done. I provided both regression tests for this situation and the fix. > 2) A CSRF attack can remove and revoke keys. This can be prevented by using > Koha::Token. Done. Good catch :-D > 3) UUID::generate($uuid); UUID::unparse( $uuid, $uuidstring ); can be > replaced by $uuidstring = uuid(); I've had issues with Jessie's version of UUID (0.05). I get: Error: "uuid" is not exported buy the UUID module > 4) In intranet, if I have no key and click twice on "Generate a new client > id/secret pair" link, the form appear then disappear. Not really a problem, > but it's an odd behaviour. I suggest to just show the button even if I have > no keys, like in OPAC. Right, I will think about it. Maybe Owen can answer about this. > 5) I feel that api_keys.id is not useful as client_id can be used as a > primary key You are right! Removed! > 6) Since we're using UUID, why not store the binary representation instead > of the string representation ? I don't know how that would affect > performance but that will save storage space. If we stick with the string > representation I suggest that we change the data type of client_id and > secret to a fixed-width string type (CHAR(36) ?) I don't think this is necessary. For this client_id/secret pairs as are not expected be be many. Also, VARCHAR only takes as much space as the size of the content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20613] New: Alert staff about missing email when accept or reject a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20613 Bug ID: 20613 Summary: Alert staff about missing email when accept or reject a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@collecto.ca QA Contact: testo...@bugs.koha-community.org Hi, When we accept or reject a purchase suggestion, if the user does not have an email address in his account, there is no alert to inform us that the email could not be sent. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #36 from Tomás Cohen Arazi--- Created attachment 74481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74481=edit Bug 20568: CSRF protection Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74479|0 |1 is obsolete|| --- Comment #35 from Tomás Cohen Arazi --- Created attachment 74480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74480=edit Bug 20568: (QA follow-up) Get rid of the id column Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74478|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 74479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74479=edit Bug 20568: (QA follow-up) Get rid of the id column Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #33 from Tomás Cohen Arazi--- Created attachment 74478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74478=edit Bug 29568: (QA follow-up) Get rid of the id column Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #31 from Tomás Cohen Arazi--- Created attachment 74476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74476=edit Bug 20568: (QA follow-up) Test client_id and secret are not overwritten Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 --- Comment #32 from Tomás Cohen Arazi--- Created attachment 74477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74477=edit Bug 20568: (QA follow-up) Make sure client_id and secret are not overwritten on store Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druartchanged: What|Removed |Added Assignee|kohapa...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added CC||benjamin.rokseth@deichman.n ||o, ||julian.maur...@biblibre.com ||, ||martin.renvoize@ptfs-europe ||.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 --- Comment #3 from Tomás Cohen Arazi--- Created attachment 74475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74475=edit Bug 20612: koha-conf.xml cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 --- Comment #1 from Tomás Cohen Arazi--- Created attachment 74473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74473=edit Bug 20612: Unit tests This patch makes the oauth.t tests leverage on the new Koha::ApiKey(s) classes. It adds tests for expired tokens too. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests should fail without the rest of the patches. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 --- Comment #2 from Tomás Cohen Arazi--- Created attachment 74474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74474=edit Bug 20612: Make OAuth2 use patron's client_id/secret pairs This patch wires the OAuth related code so it leverages on the new Koha::ApiKey(s) classes and tools introduced by bug 20568 instead of the hardcoded entries in koha-conf.xml originally proposed by bug 20402. To test revisit the test plan for bug 20402, and verify that it works. But create API key pairs instead of writing them down in koha-conf.xml. Also: - Run: $ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added Depends on||20402, 20568 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 [Bug 20402] Implement OAuth2 authentication for REST API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Tomás Cohen Arazichanged: What|Removed |Added Blocks||20612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 [Bug 20612] Make OAuth2 use patron's client_id/secret pairs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20612] Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Tomás Cohen Arazichanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Tomás Cohen Arazichanged: What|Removed |Added Blocks||20612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 [Bug 20612] Make OAuth2 use patron's client_id/secret pairs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #55 from Owen Leonard--- (In reply to Roch D'Amour from comment #50) > - Try to delete some serials that has items available, the confirmation > dialog does not ask There is a typo which is preventing this from working correctly: [% IF $countitems > 0 %] should be [% IF countitems > 0 %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonardchanged: What|Removed |Added Attachment #74318|0 |1 is obsolete|| --- Comment #54 from Owen Leonard --- Created attachment 74472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74472=edit Bug 17674 (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the
[Koha-bugs] [Bug 20612] New: Make OAuth2 use patron's client_id/secret pairs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20612 Bug ID: 20612 Summary: Make OAuth2 use patron's client_id/secret pairs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Bug 20568 implements a way to define client_id/secret API keys for patrons. We should use those instead of the hardcoded ones in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20568] Add API key management interface for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Julian Mauricechanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #30 from Julian Maurice --- QA comments: 1) The UUID generation happens in the store method. This means that every time I revoke/activate a key, client_id and secret are changed. I think that is not the desired behaviour. 2) A CSRF attack can remove and revoke keys. This can be prevented by using Koha::Token. 3) UUID::generate($uuid); UUID::unparse( $uuid, $uuidstring ); can be replaced by $uuidstring = uuid(); 4) In intranet, if I have no key and click twice on "Generate a new client id/secret pair" link, the form appear then disappear. Not really a problem, but it's an odd behaviour. I suggest to just show the button even if I have no keys, like in OPAC. 5) I feel that api_keys.id is not useful as client_id can be used as a primary key 6) Since we're using UUID, why not store the binary representation instead of the string representation ? I don't know how that would affect performance but that will save storage space. If we stick with the string representation I suggest that we change the data type of client_id and secret to a fixed-width string type (CHAR(36) ?) Failing QA for 1 and 2. 3 and 4 are not required but they should be easy to do. 5 and 6 are just thoughts. Please comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/