[Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Mason Jameschanged: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegelchanged: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Hi Katrin, Bug 27010 adds a few new subfields. Translated files have been updated accordingly. Maybe you could consider updating the patch (23+24+25+26) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bernardo Gonzalez Kriegelchanged: What|Removed |Added Attachment #75097|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 75098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75098=edit Bug 20710: Update MARC21 frameworks to Update 26 (April 2018) This bug add update 26 changes. Update 26 http://www.loc.gov/marc/bibliographic/bdapndxg.html New subfields 377$3, 380$3, 381$3, 383$3, 730$4 Codes Map 007/04 'x' new Map 007/06 'c' renamed No auth changes To test: 1) Apply Bug 19835 2) Apply this patch 3) Reload marc21 bibliografic frameworks, check loads ok 4) Clean your browser cache 5) Edit a new bib record, fire 007 plugin, for Map, 04 position, check new 'x' for Map, 06 position, check renamed 'c' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bernardo Gonzalez Kriegelchanged: What|Removed |Added Depends on||19835 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Bernardo Gonzalez Kriegelchanged: What|Removed |Added Blocks||20710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 --- Comment #1 from Bernardo Gonzalez Kriegel--- Created attachment 75097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75097=edit Bug 20710: Update MARC21 frameworks to Update 26 (April 2018) This bug add update 26 changes. Update 26 http://www.loc.gov/marc/bibliographic/bdapndxg.html New subfields 377$3, 380$3, 381$3, 383$3, 730$4 Codes Map 007/04 'x' new Map 007/06 'c' renamed No auth changes To test: 1) Apply Bug 19835 2) Apply this patch 3) Reload marc21 bibliografic frameworks, check loads ok 4) Clean your browser cache 5) Edit a new bib record, fire 007 plugin, for Map, 04 position, check new 'x' for Map, 06 position, check renamed 'c' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #134 from Chris Cormack--- Yes, because of the months of stuff before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #133 from Jonathan Druart--- It was too later for 18.05 anyway. We are in feature freeze for a week already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #131 from Alain Dussert--- Hi All, I agree that an RFC would be ideal. It would be great for this feature to be put in production in Koha 18.11 Thanks, Alain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #132 from Chris Cormack--- I actually find this incredibly disappointing. We could have had a working feature in 18.05 except for people consistently trying to scope creep it. Now we won't until at least 18.11 and it will probably be over specced, over ambitious and fragile. This has to stop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #93 from David Bourgault--- I've resquashed the patch to keep it clean. New changes: * Support repeatable tags Repeated tags will repeat the field name, e.g.: " 035$a: some value 035$a: another value " * Delimiter switched to comma from whitespace (whitespace is ignored). I did this to make it uniform with the sysprefs 'z3950NormalizeAuthor' and 'z3950AuthorAuthFields'. * Reworded syspref description slightly, added '001' to example " Display the MARC field/subfields <> in the 'Additional fields' column in the result of a search Z3950 (use comma as delimiter e.g.: "001, 082$ab, 090$ab") " * No longer shows tags missing the target subfield * Added a test for repeatable tags and syspref splitting to t/db_dependent/Breeding.t Adding multiple additional tags will result in the result table being very big (lots of whitespace). I tried using a to make it more compact, but it became too hard to read (cluttered). I left it with for now. QA Tool green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 David Bourgaultchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 David Bourgaultchanged: What|Removed |Added Attachment #74783|0 |1 is obsolete|| Attachment #74784|0 |1 is obsolete|| Attachment #74785|0 |1 is obsolete|| Attachment #74786|0 |1 is obsolete|| Attachment #74787|0 |1 is obsolete|| --- Comment #92 from David Bourgault --- Created attachment 75096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75096=edit Bug 12747: Add extra column in Z3950 search This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields prove t/db_dependent/Breeding.t Sponsored-by: CCSR (https://ccsr.qc.ca) Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Tomás Cohen Arazichanged: What|Removed |Added Attachment #73876|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 75095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75095=edit Bug 20305: Remove warnings from tools scripts Signed-off-by: Julian Maurice Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 Tomás Cohen Arazichanged: What|Removed |Added Attachment #75042|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 75094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75094=edit Bug 20700: MARC21 add/update leader/007/008 codes This add/updates some codes from updates 22 (Apr/16) and 23 (Nov/16) Update 22 https://www.loc.gov/marc/up22bibliographic/bdapndxg.html Sound Recording 007/03 n (new) Sound Recording 007/10 n (new) Sound Recording 007/01 r (new) Sound Recording 007/01 s (new) Update 23 https://www.loc.gov/marc/up23bibliographic/bdapndxg.html Leader/18 n (new) Music 008/20 p (new), b (renamed) To test: 1) Apply the patch 2) Clean your browser cache 3) Go to cataloguing -> new record 4) Leader plugin: check leader/18, new option 'n' 5) 007 Plugin: a) Sound recording check 007/01 new 'r' check 007/03 new 'n' check 007/10 new 'n' b) Electronic resource check 007/01 new 's' 6) 008 Plugin: Music, check 008/20 renamed 'b', new 'p' Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20712] New: ILL belongs to the circulation section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20712 Bug ID: 20712 Summary: ILL belongs to the circulation section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I belive the ILL handling UI belongs more to the Circulation section than the main staff page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #58 from Kyle M Hall--- (In reply to Jonathan Druart from comment #56) > 1. There is 'Account Writeoff' vs 'Account writeoff' > > 2. In Koha::Account->pay, why require C4::Letters; instead of use? > > 3. Koha/Account.pm:273 > lang=> Koha::Patrons->find( $self->{patron_id} )->lang, > No need to refetch the patron object, you did it already at the beginning of > the method. > > 4. Koha/Account.pm:280 > offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map { > $_->id } @account_offsets ] } } ), > > I do not understand this line, we are refetching what we already have? Follow addresses everything but 2. I used require instead of use because use is hoisted and it would import it even if the feature is not being used. Basically it's a small efficiency improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #57 from Kyle M Hall--- Created attachment 75093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75093=edit Bug 19191 [QA Followup] - Remove double fetches from database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hallchanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20586] Infinite loop creation of issues when using multi receive or generate next serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20586 Jonathan Druartchanged: What|Removed |Added Version|17.11 |unspecified Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- We do not support mod_perl, so I am going to mark it as won't fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20711] New: Previous fields are not cleared when selecting an authority in notice editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20711 Bug ID: 20711 Summary: Previous fields are not cleared when selecting an authority in notice editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david.bourga...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When choosing an authority for a zone in the bibliographic notice editor, existing fields are not cleared. So if I have a information in the subfields $a $v $9 and I import a authority notice with subfields $a $9 $x, the previous $v value is not cleared. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #15 from Jonathan Druart--- Julian, I am more or less stealing this bug report for bug 19185. I am willing to move/rewrite these 2 patches somewhere else if you think I lost too much your initial idea. The goal here is more to have a first working thing pushed, and then see later how we can re-use/modify it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Jonathan Druartchanged: What|Removed |Added Blocks||19185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 [Bug 19185] Web installer and onboarding tool selenium test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #14 from Jonathan Druart--- Created attachment 75092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75092=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druartchanged: What|Removed |Added Depends on||19821 --- Comment #10 from Jonathan Druart --- Maybe not ready yet for integration but need feedbacks. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 [Bug 19821] Run tests on a separate database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #13 from Jonathan Druart--- Created attachment 75091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75091=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #8 from Jonathan Druart--- Created attachment 75089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75089=edit Bug 19185: Ease elements selection - The marcflavour select needs an id to be selected easily - "Continue to the next step" should be a button (like others) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #9 from Jonathan Druart--- Created attachment 75090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75090=edit Bug 19185: Add selenium tests for installation and onboarding process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druartchanged: What|Removed |Added Attachment #66508|0 |1 is obsolete|| Attachment #68830|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 75088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75088=edit Bug 19185: Use submit button if only one exists on the page During the installation process we do not have fieldset.action, in order to not complicate changes we are just going to use the submit button if only one exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Mauricechanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Julian Maurice --- Patches rebased on master + new patch (attachment 75086) Reset bug status to Needs signoff since the last patch brings a lot of changes. To test, use test plan from comment 21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #24 from Julian Maurice--- Created attachment 75086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75086=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Mauricechanged: What|Removed |Added Attachment #72079|0 |1 is obsolete|| --- Comment #22 from Julian Maurice --- Created attachment 75084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75084=edit Bug 15774: (QA followup) Make sure that tablename is correctly saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Mauricechanged: What|Removed |Added Attachment #72086|0 |1 is obsolete|| --- Comment #23 from Julian Maurice --- Created attachment 75085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75085=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Mauricechanged: What|Removed |Added Attachment #72078|0 |1 is obsolete|| --- Comment #21 from Julian Maurice --- Created attachment 75083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75083=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazichanged: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #16 from Tomás Cohen Arazi--- Created attachment 75082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75082=edit Bug 20284: Fix minor compilation errors Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74599|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 75079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75079=edit Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74652|0 |1 is obsolete|| --- Comment #14 from Tomás Cohen Arazi --- Created attachment 75080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75080=edit Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #15 from Tomás Cohen Arazi--- Created attachment 75081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75081=edit Bug 20284: (QA follow-up) superlibrarian has ill permissions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Katrin Fischerchanged: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #4 from Katrin Fischer --- Because we don't do atomic updates in this case, we don't want to mess with what people have set up for their use. Note: these files have been auto-generated so I am just copying them into the right spot. If that changes a blank line, I am still ok with it :) If you take a closer look you can see that the ACQ framework has been moved into another file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druartchanged: What|Removed |Added Status|BLOCKED |ASSIGNED Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- I am working on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20648] Attribute option "Display in check-out" should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648 Séverine Queunechanged: What|Removed |Added Depends on||12159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 [Bug 12159] Duplicate borrower_add_additional_fields function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queunechanged: What|Removed |Added Blocks||20648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648 [Bug 20648] Attribute option "Display in check-out" should be renamed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707 Nick Clemenschanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20637] Holds to pull: filter shows two itypes on the same line if a biblio has two items of a different type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20637 Nick Clemenschanged: What|Removed |Added CC||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707 --- Comment #3 from Nick Clemens--- Note: Workaround is to disable CircAutoCompl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707 --- Comment #2 from Nick Clemens--- Created attachment 75078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75078=edit Bug 20707: Replace circ/search.pl circulate permission requirement with catalogue To test: 1 - Setup a staff patron with permissions: catalogue reserveforothers course_reserves 2 - Log in to staff client as that patron 3 - Find a record and click to place a hold 4 - Type more than three letters into the search bar but don't submit 5 - Note that you will not receive autocomplete results 6 - Either submit, or try to visit any page in staff client 7 - Your session has been expired, you must log in again 8 - Log in, go to course reserves 9 - As before, trigger the autocomplete search in the instrcutor field 10 - Again your session has been terminated 11 - Apply patch 12 - Repeat above actions, this time you will not be kicked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707 Nick Clemenschanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Tomás Cohen Arazichanged: What|Removed |Added Attachment #74963|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 75077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75077=edit Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Tomás Cohen Arazichanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707 Nick Clemenschanged: What|Removed |Added Summary|Permissions issue in|Permissions for |placing holds - users are |circ/ysearch.pl override |logged out |specific page level ||permissions and delete ||sessions improperly --- Comment #1 from Nick Clemens --- With Kyle's help we tracked this down: when placing a hold if you trigger the autocomplete i.e. ysearch.pl you are logged out as not having permissions circ/ysearch requires circulate => '*' whereas request.pl requires reserveforothers => 'place_holds' this is also true for course reserves - searching for an instructor will log the user out unless they have circulate permissions. tags-review uses it as well I think the most straightforward route is to remove the circulate permission check from ysearch and require simply catalogue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bernardo Gonzalez Kriegelchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20710] New: Update MARC21 frameworks to Update 26 (April 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bug ID: 20710 Summary: Update MARC21 frameworks to Update 26 (April 2018) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org New update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Failed QA --- Comment #56 from Jonathan Druart --- 1. There is 'Account Writeoff' vs 'Account writeoff' 2. In Koha::Account->pay, why require C4::Letters; instead of use? 3. Koha/Account.pm:273 lang=> Koha::Patrons->find( $self->{patron_id} )->lang, No need to refetch the patron object, you did it already at the beginning of the method. 4. Koha/Account.pm:280 offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map { $_->id } @account_offsets ] } } ), I do not understand this line, we are refetching what we already have? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 M. Tompsettchanged: What|Removed |Added Status|Needs Signoff |In Discussion CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- Also, why no atomic update to correct current systems doing an upgrade? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #2 from M. Tompsett--- Comment on attachment 75044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75044 Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Review of attachment 75044: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20709=75044) - ::: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql @@ +86,4 @@ > UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND > tagsubfield = 'r' AND frameworkcode = 'FA'; > UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND > tagsubfield = 's' AND frameworkcode = 'FA'; > UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND > tagsubfield = 'x' AND frameworkcode = 'FA'; > + If a blank line is the only difference, perhaps it should not be part of the patch? ::: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql @@ -520,5 @@ > -INSERT INTO marc_subfield_structure(tagfield, tagsubfield, liblibrarian, > libopac, repeatable, mandatory, kohafield, tab, authorised_value, > authtypecode, value_builder, isurl, hidden, frameworkcode, seealso, link, > defaultvalue, maxlength) > -SELECT tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, > kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, > 'ACQ', seealso, link, defaultvalue, maxlength > -FROM marc_subfield_structure > -WHERE frameworkcode="" > -AND kohafield IN ("biblio.title", "biblio.author", > "biblioitems.publishercode", "biblioitems.editionstatement", > "biblio.copyrightdate", "biblioitems.isbn", "biblio.seriestitle" ); Why remove this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Accept different monetary formats as input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Koha Team Lyon 3changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #77 from Koha Team Lyon 3 --- Hello, I have followed the test plan (really enthousastic one ;) )and tried different inputs (with dot, comma, symbol, names) in fines patrons tab : maninvoice.pl, mancredit.pl, paycollect.pl) I test it with different setups in DecimalSeparators and the results were consistent. I found only one issue, perhaps related to bug19521. With DecimalSeparators=',.', when you are on paycollect.pl and choose to writeoff a fine, if you enter "1,50", the writeoff amount saved is only 1. The problem occurs only with the writeoff I think that we should change the name of this ticket as it handles only the members payments. Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20685] Modify letter template does not render incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druartchanged: What|Removed |Added Summary|Modify notice page for HOLD |Modify letter template does |SLIP rendering incorrectly |not render incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaudchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaudchanged: What|Removed |Added Attachment #74751|0 |1 is obsolete|| --- Comment #31 from Alex Arnaud --- Created attachment 75073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75073=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20620] Warning in moredetail.pl need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20620 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20477] Silence warnings Fast Cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20477 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaudchanged: What|Removed |Added Attachment #74752|0 |1 is obsolete|| --- Comment #32 from Alex Arnaud --- Created attachment 75074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75074=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaudchanged: What|Removed |Added Attachment #74754|0 |1 is obsolete|| --- Comment #34 from Alex Arnaud --- Created attachment 75076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75076=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20685] Modify notice page for HOLD SLIP rendering incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaudchanged: What|Removed |Added Attachment #74753|0 |1 is obsolete|| --- Comment #33 from Alex Arnaud --- Created attachment 75075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75075=edit Bug 18316: String changes Signed-off-by: Nick Clemens Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- Dead since commit 68ce64a793b023164ac19a56602747945a1bdca1 Date: Mon Oct 29 13:19:58 2007 -0500 Bugfixing the template, and removing link to compound reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20198] `›`missing in breadcrumb of translated pages of aqbudgets.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20198 Bernardo Gonzalez Kriegelchanged: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Hi, what do you see after the translation? On current master that line ... Budgets [% IF.. is translated as ...Presupuestos [% IF.. using es-ES for example. Translation script prefers strings inside tags, ... in this case; if '' remains alone, then it's also removed from translation files. But that does not affect the translated result file, on first look. Do you find a problem with the translated file? Regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemenschanged: What|Removed |Added Status|Signed Off |In Discussion --- Comment #130 from Nick Clemens --- We talked about this one a lot at hackfest and have been working on recall functionality for one of our partners. While I agree on the strategy of starting small and avoiding scope creep I do think that we need a path forward and would really like to see an RFC that provides a roadmap to the final feature ensuring that this base allows for work towards that end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20505] Selenium tests fail if server not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com Status|Passed QA |In Discussion --- Comment #5 from Jonathan Druart --- I do not know if this is valid, I would prefer to explode if the server is not running and to know there is something wrong in the setup. The error is explicit: "Selenium server did not return proper status" This change could hide problems in jenkins configuration. Tomas, opinion? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #55 from Kyle M Hall--- Created attachment 75072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75072=edit Bug 19191: Add syspref to control use of email receipts, defaulting to disabled Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #53 from Kyle M Hall--- Created attachment 75070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75070=edit Bug 19191: Fix capitalization of notice titles Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druartchanged: What|Removed |Added Keywords|release-notes-needed, | |rel_18_05_candidate | --- Comment #60 from Jonathan Druart --- This will not be part of 18.05 unfortunately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #54 from Kyle M Hall--- Created attachment 75071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75071=edit Bug 19191: Add non-english notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #52 from Kyle M Hall--- Created attachment 75069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75069=edit Bug 19191: Add correct unit tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #51 from Kyle M Hall--- Created attachment 75068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75068=edit Bug 19191: Remove need for bug 19966 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hallchanged: What|Removed |Added Attachment #75066|0 |1 is obsolete|| --- Comment #50 from Kyle M Hall --- Created attachment 75067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75067=edit Bug 19191: Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hallchanged: What|Removed |Added Attachment #74626|0 |1 is obsolete|| Attachment #74627|0 |1 is obsolete|| Attachment #74628|0 |1 is obsolete|| Attachment #74629|0 |1 is obsolete|| Attachment #74630|0 |1 is obsolete|| Attachment #74686|0 |1 is obsolete|| --- Comment #49 from Kyle M Hall --- Created attachment 75066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75066=edit Bug 19191: Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hallchanged: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 --- Comment #15 from Kyle M Hall--- Created attachment 75061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75061=edit Bug 20624: Unit tests This patch adds tests to verify that disabling the RESTOAuth2ClientCredentials syspref makes any request on the /api/v1/oauth/token using the 'client_credentials' grant fail with 'grant not implemented'. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests fail because the change is not implemented! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 --- Comment #16 from Kyle M Hall--- Created attachment 75062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75062=edit Bug 20624: Make /api/v1/oauth/token respect RESTOAuth2ClientCredentials This patch makes the /api/v1/oauth/token enpoint respect the RESTOAuth2ClientCredentials syspref. It will return 400 (with 'Unimplemented grant type' error message) on the event of the syspref being disabled and the grant_type => 'client_credentials' value passed. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: It fails because the off-switch is not implemented - Apply this patch - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 --- Comment #17 from Kyle M Hall--- Created attachment 75063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75063=edit Bug 20624: Make staff client respect RESTOAuth2ClientCredentials This patch makes the staff client UI respect the RESTOAuth2ClientCredentials syspref. To test: - Make sure RESTOAuth2ClientCredentials is "Don't enable" - Go to a patron's detail page => SUCCESS: The 'More' dropdown doesn't show the API keys management link. - Enable RESTOAuth2ClientCredentials - Reload => SUCCESS: The 'More' dropdown shows the API keys management link - Click on the API keys management link => SUCCESS: You can edit the api keys - Disable the syspref - Reload => SUCCESS: You are presented an error 400 page. - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 Kyle M Hallchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 --- Comment #18 from Kyle M Hall--- Created attachment 75064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75064=edit Bug 20624: (QA follow-up) Unit tests for missing deps situation This patch tests the situation in which Net::OAuth2::AuthorizationServer is missing. It mocks Module::Load::Conditional::can_load and expects the /token endpoint answers 'Unimplemented grant type' to all requests, and the 'authenticate_api_request' in 'under' exit with unauthorized (403) to requests in which the Authorization header is passed containing a Bearer token, but OAuth2 is not really available. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests fail because our REST endpoints don't support this behaviour. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 Kyle M Hallchanged: What|Removed |Added Attachment #74986|0 |1 is obsolete|| Attachment #74987|0 |1 is obsolete|| Attachment #74988|0 |1 is obsolete|| Attachment #74989|0 |1 is obsolete|| Attachment #75020|0 |1 is obsolete|| Attachment #75021|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 75060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75060=edit Bug 20624: Add RESTOAuth2ClientCredentials syspref Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 --- Comment #19 from Kyle M Hall--- Created attachment 75065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75065=edit Bug 20624: (QA follow-up) Handle missing deps gracefuly This patch makes the /token endpoint and the authenticate_api_request method behave correctly in the event of missing deps for OAuth2. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: The behaviour is not implemented - Apply this patch - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooychanged: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy --- Looks good to me. (We could still improve on holds :) Note that imo we do not need the multi_hold param in opac-reserve. If you have one title, 'none of these titles' is still true. And on the other hand, if you have two titles, we actually do not need the top level none_available message at all. We still see multiple lines with There are no items that can be placed on hold. No big deal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooychanged: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooychanged: What|Removed |Added Attachment #74802|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 75059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75059=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. Signed-off-by: Owen Leonard Fixed stray during signoff. Signed-off-by: Marcel de Rooy For consistency with staff, I renamed multi_holds to multi_hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20620] Warning in moredetail.pl need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20620 Marcel de Rooychanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20477] Silence warnings Fast Cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20477 Marcel de Rooychanged: What|Removed |Added Attachment #74178|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 75058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75058=edit Bug 20477: Silence floody noise on fast cataloging TEST PLAN - See comment #0 to reproduce. apply this patch restart_all echo | sudo tee /var/log/koha/kohadev/place-error.log restart_all cat /var/log/koha/kohadev/plack-error.log -- just restart information log into staff client again, home -> circulation -> fast cataloging cat /var/log/koha/kohadev/plack-error.log -- just restart information run qa test tools Signed-off-by: Roch D'Amour Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20477] Silence warnings Fast Cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20477 Marcel de Rooychanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20477] Silence warnings Fast Cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20477 Marcel de Rooychanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/