[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

--- Comment #10 from Katrin Fischer  ---
We have branchcodes that are a mix of capitals and numbers, so I don't think
it's an odd case.

The problem with deprecating something just in the source code is that people
will still use it - how would they know? The code comments have been there
forever, maybe we need to fix it or remove it, but don't leave it like that?
Least we could do is add a note to the GUI about it being problematic or
deprecated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

--- Comment #9 from M. Tompsett  ---
Comment on attachment 75509
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509
Bug 19113: Barcode value builder not working with numeric branchcode

Review of attachment 75509:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19113=75509)
-

::: C4/Barcodes/ValueBuilder.pm
@@ +49,4 @@
>  my $month = $args->{mon};
>  my $query = "SELECT MAX(CAST(SUBSTRING(barcode,-4) AS signed)) AS number 
> FROM items WHERE barcode REGEXP ?";
>  my $sth = C4::Context->dbh->prepare($query);
> +$sth->execute("^[-a-zA-Z0-9]{1,}$year$month");

If this regexp is wrong, there are several other places it is wrong too. See
C4/Barcodes/hbyymmincr.pm db_max for example.

See also line 142:
This format is deprecated and SHOULD NOT BE USED.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #8 from M. Tompsett  ---
(In reply to Blou from comment #6)
> Test
> - It's a bit complicated.  You need
>- all your branchcodes to be numerics (01,02,71...)

Who sets their branch codes to purely numerical values?!


>- all barcodes to already be a bunch of numbers
> - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one.

Support for the hbyymm barcode methodology has been deprecated, as far as I
know. Why even fix it for this bizarre case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

--- Comment #5 from Nick Clemens  ---
Created attachment 75516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75516=edit
Bug 19490: (follow-up) Add tooltip to each row

To test:
1 - Run batch modification on some items
2 - Hover over the holds column
3 - Note the tool tip
4 - PLace some holds to verify combinations of item/record level holds
show appropriately

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #1 from Owen Leonard  ---
Created attachment 75515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75515=edit
Screenshot of the modal window

I'm not crazy about the duplication of the heading. Maybe it's better to have a
blank (or nonexistent?) modal header.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from M. Tompsett  ---
The 'q' portion of the sed logic is faulty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20809] New: Link patron image to patron image add/edit form

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Bug ID: 20809
   Summary: Link patron image to patron image add/edit form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 75514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75514=edit
Screen capture of the edit button interaction

The structure of moremember.tt makes it possible to use AJAX to pull just the
patron image add/edit form and display it in a modal. I'd like to add a link to
the patron image so that the image can be edited from anywhere it displays.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75512|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 75513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75513=edit
Bug 20807: Lost items report: Improve the display of CSV profile errors

This patch modifies the template for the lost items report to change the
way it handles a missing CSV profile. Now, if there is a missing CSV
profile, a message is displayed with details about the profile
requirements. If the logged-in user has the right permission there is a
link to the CSV profiles page.

Since item selection is used only in conjunction with exporting results,
item selection controls are all hidden when there is no valid CSV
profile.

To test, apply the patch go to Reports -> Lost items.

 - Run the report with parameters which will return results.
 - If your system has no CSV profile for exporting lost items:
   - If you are logged in as a user with manage_csv_profiles permission:
 - You should see a message dialog instructing you to create a CSV
   profile with a link to the CSV profiles page.
   - If you are not logged in as a user with manage_csv_profiles
 permission:
 - You should see a similar message but without a link to the CSV
   profiles page.
   - In both cases, with no CSV profile defined there should be no
 checkboxes in the table of results and no "select all/clear all"
 controls.
 - If your system has a valid CSV profile for exporting lost items:
   - Checking the checkbox for one or more items in the table should
 trigger the display of an "Export selected items" link.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

--- Comment #1 from Owen Leonard  ---
Created attachment 75512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75512=edit
Bug 20807: Lost items report: Improve the display of CSV profile errors

This patch modifies the template for the lost items report to change the
way it handles a missing CSV profile. Now, if there is a missing CSV
profile, a message is displayed with details about the profile
requirements. If the logged-in user has the right permission there is a
link to the CSV profiles page.

Since item selection is used only in conjunction with exporting results,
item selection controls are all hidden when there is no valid CSV
profile.

To test, apply the patch go to Reports -> Lost items.

 - Run the report with parameters which will return results.
 - If your system has no CSV profile for exporting lost items:
   - If you are logged in as a user with manage_csv_profiles permission:
 - You should see a message dialog instructing you to create a CSV
   profile with a link to the CSV profiles page.
   - If you are not logged in as a user with manage_csv_profiles
 permission:
 - You should see a similar message but without a link to the CSV
   profiles page.
   - In both cases, with no CSV profile defined there should be no
 checkboxes in the table of results and no "select all/clear all"
 controls.
 - If your system has a valid CSV profile for exporting lost items:
   - Checking the checkbox for one or more items in the table should
 trigger the display of an "Export selected items" link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20808] New: I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808

Bug ID: 20808
   Summary: I cant install Koha on Ubuntu 18.04 LTS (Bionic
Beaver) - Unmet dependences
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paul.mess...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Hello,

I am installing Koha on Ubuntu 18.04 LTS Bionic Beaver (Fresh Installation).
However, I have experienced the following error when I run "sudo apt-get
install koha-common"

The following packages have unmet dependencies:
 koha-common : Depends: libmarc-charset-perl but it is not installable
   Depends: libmarc-xml-perl but it is not installable
E: Unable to correct problems, you have held broken packages.

Workaround:

sudo apt-get install libmarc-record-perl
sudo apt-get install libxml-sax-perl
wget
http://ftp.br.debian.org/debian/pool/main/libm/libmarc-charset-perl/libmarc-charset-perl_1.35-2_amd64.deb
wget
http://ftp.br.debian.org/debian/pool/main/libm/libmarc-xml-perl/libmarc-xml-perl_1.0.3-1_all.deb
sudo dpkg -i libmarc-charset-perl_1.35-2_amd64.deb
libmarc-xml-perl_1.0.3-1_all.deb
sudo apt-get install koha-common

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75510|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 75511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75511=edit
Bug 20692: Return and display and error if koha-plack failed

If koha-plack did not comment/uncomment the line it should fails and
display an error instead of success.

Useful for old apache config files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75040|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 75510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75510=edit
Bug 20692: Return and display and error if koha-plack failed

If koha-plack did not comment/uncomment the line it should fails and
display an error instead of success.

Useful for old apache config files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774
[Bug 20774] Trivial HTML error in itemslost.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Owen Leonard  changed:

   What|Removed |Added

 Blocks||20807


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807
[Bug 20807] Lost items report: Improve the display of CSV profile errors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

Blou  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Blou  ---
Still don't understand why the patch had been replaced by Bug 15685.  So
setting back to need sign off.  Not signed off yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20807] New: Lost items report: Improve the display of CSV profile errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Bug ID: 20807
   Summary: Lost items report: Improve the display of CSV profile
errors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Currently, if you don't have a "Export lost items in report" CSV profile, the
lost items report results will show what looks like a disabled link to
exporting selected items. Information about the missing CSV profile is hidden
in a title attribute on that link.

I propose that we instead display a message about the missing CSV profile and
hide all selection tools and checkboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20807

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

Blou  changed:

   What|Removed |Added

  Attachment #66019|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

--- Comment #6 from Blou  ---
Created attachment 75509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509=edit
Bug 19113: Barcode value builder not working with numeric branchcode

The regexp for the value builder 'hbyymmincr' doesn't allow for numerics in the
branchcode, so the nextnum found is always 0 and multiple Add always generate
the same barcode.

This simply allow for numerics within the regex.

Test
- It's a bit complicated.  You need
   - all your branchcodes to be numerics (01,02,71...)
   - all barcodes to already be a bunch of numbers
- Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one.
- Find an item in the pro-search,
- New -> New Item
- Click on the 'p' to have the value builder create the next barcode.
   - Without the patch, the query won't have found anything, so it'll suggest
xx0001
- Click Add.  It reprensent the form to enter another one.
   - Click on the 'p' edit box, it'll offer you again xx0001
With the patch, it'll offer valid ones everytime.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
Summary|koha-plack doesn't check|koha-plack doesn't check
   |for Include *-plack.conf|for Include *-plack.conf
   |line in |line in
   |/etc/apache2/sites-availabl |/etc/apache2/sites-availabl
   |e/$ISNTANCE.conf|e/$INSTANCE.conf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

--- Comment #9 from Martha Fuerst  ---
(In reply to Kyle M Hall from comment #7)
> (In reply to Martha Fuerst from comment #6)
> > Is there something in sysprefs that might be fouling it up? 
> 
> That looks pretty good, are you sure you are triggering the rule by
> utilizing the branch chosen from RetundLostOnReturnControl?
> 
> Basically, if the other refund lost item fee rule options work, then you can
> switch those rules to "only if unpaid" and it should work. If they do not
> work it is an issue with your test data.

Gotcha.

Tested again after you took a look at my settings (thanks Kyle!) -

Test Plan:
1) Apply this patch
2) Set your lost item refund on return policies to 'Only if unpaid'
3) Mark an item lost, charging the lost fee
4) Return the item, a full refund should ocurr
5) Mark another item lost, charging the lost fee
6) Make a partial payment on this lost fee
7) Return the item
8) The remaining balance of that fee should be 0, but the patron should
   not recieve a credit for the already paid balance
8) Mark another item lost, charging the lost fee
9) Fully pay the lost fee
10) Return the item. The paid lost fee should be unaffected.

Everything worked as it should - signing off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75392|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 75508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75508=edit
Bug 20774: Trivial HTML error in itemslost.tt

This patch makes a minor correction to the markup of the lost items
report template.

To test, apply the patch and run the lost items report with parameters
which will return results. The report results should look correct, and
the page should validate with no relevant errors.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

--- Comment #5 from M. Tompsett  ---
(In reply to Owen Leonard from comment #4)
> (In reply to M. Tompsett from comment #3)
> > There's a stray /a in this section. Could you fix this too? I'll leave the
> > text/javascripts for another bug. :)
> 
> This seems to be a symptom of a larger problem with the export feature which
> I'll try to address in a separate bug.

Having just retested with a CSV profile defined from Tools, and rechecking the
page, I see what you are talking about. Another bug it is, no sense scope
creeping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

--- Comment #4 from Owen Leonard  ---
(In reply to M. Tompsett from comment #3)
> There's a stray /a in this section. Could you fix this too? I'll leave the
> text/javascripts for another bug. :)

This seems to be a symptom of a larger problem with the export feature which
I'll try to address in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
↩
| 
Select all |↩
 Clear
all↩
↩
  | Actions:↩
  ↩
   Export selected items↩
  ↩
↩
↩

There's a stray /a in this section. Could you fix this too? I'll leave the
text/javascripts for another bug. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

--- Comment #2 from M. Tompsett  ---
Comment on attachment 75392
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75392
Bug 20774: Trivial HTML error in itemslost.tt

Review of attachment 75392:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20774=75392)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -87,4 @@
>  
>  [% item.biblio.author %]
>  [% AuthorisedValues.GetDescriptionByKohaField( 
> kohafield => 'items.itemlost', authorised_value => item.itemlost ) %]
> -[% 
> item.itemlost_on | $KohaDates %]

Oh my! Good catch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #9 from Séverine Queune  ---
All behaviours are correct (the bonus one too !).

I just wondered about this setting : any acquisition permission except
suggestions_manage : "Suggestions" link on acqui-home side menu is hidden,
shouldn't it be the same for the "Manage suggestions" link on the "Pending
suggestions" frame ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #50 from Ere Maijala  ---
I'll review as soon as possible.

Regarding the format of the full record, there are some other options that
might be worth considering:

- Store as JSON making it possible to do advanced MARC queries
- Don't store the full record but get it from the database. There are obvious
downsides but also upsides to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20778] Unable to delete a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #4 from Séverine Queune  ---
I never noticed that point before :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20778] Unable to delete a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 75505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75505=edit
Bug 20778: Fix subscription deletion. Also remove the first confirmation pop
because we have another one.

Test plan:
  - go to a subscription detail page,
  - click on edit -> delete subscription,
  - confirm deletion,
  - check that the subscription is no longer here

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20778] Unable to delete a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #75429|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20778] Unable to delete a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20779] Style refresh for patron detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20779] Style refresh for patron detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75436|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 75504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75504=edit
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #46 from Katrin Fischer  ---
(In reply to Alex Arnaud from comment #42)
> (In reply to Katrin Fischer from comment #39)
> 
> > Input number for decimals can be problematic for translations in my
> > experience. Please test for example with de-DE if the value is correctly
> > stored (it will force a decimal comma instead of . on input, which is
> > inconsistent with our other input fields right now)
> 
> I just tried on a Koha translated into German. Sounds that there no problem
> with the values stored. Any test plan to reproduice issue you talked about?

The problem we had was that it forced you to enter decimal values with comma
but Koha didn't undertand them and then truncated the value. 1,1 = 1. This
happened in fines in an older version, some more info here:

Bug 17098 - Validation problems with form field type "number" (decimal
separator)

We are still using the patch described there. It might depend on the browser
and version you use and will only appear if the template language is one that
uses decimal commas.

But what remains, I think, is a problem of consistency. Having some inputs ask
for comma and others for . is confusing to libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75470|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 75503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75503=edit
Bug 20262: Add ability to refund lost item fees without creating credits

Some libraries handle refunding of paid lost fees at a financial office and not
within Koha. To facilitate this, it would be good for Koha to have the option
to not generate lost returned credits by skipping fully paid lost items, and
only refunding the outstanding balance on partially paid lost fees.

Test Plan:
1) Apply this patch
2) Set your lost item refund on return policies to 'Only if unpaid'
3) Mark an item lost, charging the lost fee
4) Return the item, a full refund should ocurr
5) Mark another item lost, charging the lost fee
6) Make a partial payment on this lost fee
7) Return the item
8) The remaining balance of that fee should be 0, but the patron should
   not recieve a credit for the already paid balance
8) Mark another item lost, charging the lost fee
9) Fully pay the lost fee
10) Return the item. The paid lost fee should be unaffected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #49 from David Gustafsson  ---
Missed a word, should be: "The performance difference was also _not_ as big"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #48 from David Gustafsson  ---
Ok! MARCXML is still the default format, so previous behaviour is maintained if
preference is left as is. The performance difference was also as big as hoped
on the whole, so the largest benefit might be smaller index. I could remove it
though quite confident it does not introduces any new bugs. Also I accidentally
removed you sign off, but since have changed some things since then perhaps
best to sign off again in that case. What I should have done is add the new
changes as new commits, but wanted a clean diff to make it easier to review as
a single unit, but in this case new commits would probably have been better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

--- Comment #6 from Owen Leonard  ---
(In reply to M. Tompsett from comment #4)
> Was there any real benefit to changing HTML comments to Template Toolkit
> comments?

The comments are for people editing the template, so there's not any reason to
add to the file size of the generated HTML by outputting them there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75488|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 75500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75500=edit
Bug 20520: Re-indent moremember.tt

This patch reindents the template for the patron detail page,
moremember.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the patron detail page. There should be no visible
difference before and after the applying the patch.

HTML validation before and after the patch should return the same
results.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #5 from Séverine Queune  ---
Seems good to me on all pages.
Thanks Owen !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

--- Comment #4 from M. Tompsett  ---
Was there any real benefit to changing HTML comments to Template Toolkit
comments?

Nasty /div mismatches in some cases, as far as I could read. Also, layering
issues with things not nested properly. Indentation really cleaned this up
nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Séverine Queune  changed:

   What|Removed |Added

  Attachment #75313|0   |1
is obsolete||

--- Comment #4 from Séverine Queune  ---
Created attachment 75499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75499=edit
Bug 20756: Compiled CSS

This patch contains the compiled CSS file

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20640] Allow migrating a request between backends

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Séverine Queune  changed:

   What|Removed |Added

  Attachment #75312|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 75498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75498=edit
Bug 20756: OPAC "Share list" button should be styled with an icon

This patch adds a new "share" icon to the sprite image used to style
controls in the OPAC. The "share list" links now have a "sharelist"
class which is used to style the links with the new icon.

Also changed: Fixed the page structure markup of opac-shareshelf.tt.

To test you must have the OpacAllowSharingPrivateLists system preference
enabled.

 - Log in to the OPAC and go to Lists -> Your lists.
 - Create one or more private lists if necessary.
 - In the table of your lists there should be a "Share" link with the
   new icon.
 - View one of these lists and confirm that the "Share" link at the top
   of the table of list items.
 - Click through to the share list page and confirm that the page looks
   correct.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #7 from Andrew Isherwood  ---
Created attachment 75497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75497=edit
Bug 20772: Display and edit of price_paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #6 from Andrew Isherwood  ---
Created attachment 75496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75496=edit
Bug 20772: Return cost & price_paid in API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #5 from Andrew Isherwood  ---
Created attachment 75495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75495=edit
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #3 from Andrew Isherwood  ---
Created attachment 75493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75493=edit
Bug 20772: DO NOT PUSH - Schema update

Schema update for illrequestattributes.readonly
Schema update for illrequests.price_paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #4 from Andrew Isherwood  ---
Created attachment 75494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75494=edit
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #1 from Andrew Isherwood  ---
Created attachment 75491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75491=edit
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772

--- Comment #2 from Andrew Isherwood  ---
Created attachment 75492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75492=edit
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #45 from David Gustafsson  ---
(In reply to Nick Clemens from comment #41)
> Generally you make your code changes, commit the patches, then run:
> misc/devel/update_dbix_class_files.pl
> And commit those as their own patch - that way the changes are included for
> testers but can be regenerated when pushing to master

Thanks for clarifying this, now I understand how to go about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #4 from Séverine Queune  ---
That's interesting !
Works fine for me.
A detail about css hiding : I had to use #tools_batchMod-edit .holds_count {
display: none; }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #44 from David Gustafsson  ---
(In reply to Katrin Fischer from comment #39)
> (In reply to Alex Arnaud from comment #38)
> > (In reply to David Gustafsson from comment #37)
> > > Created attachment 75458 [details] [review] [review] [review]
> > > Change search field weight field to decimal and add column declaration to
> > > DBIx results source
> > 
> > Hello David,
> > 
> > You provide changes on Koha/Schema/Result/SearchField.pm. This should be
> > done in a dedicated patch. RM will ignore it.
> > 
> > Also, you replaced the input type number with a input text. This cause
> > errors when typing non-numeric characters in. You can use a input number
> > with step=0.1 to increment decimal numbers.
> > 
> > Need to fail QA
> 
> Input number for decimals can be problematic for translations in my
> experience. Please test for example with de-DE if the value is correctly
> stored (it will force a decimal comma instead of . on input, which is
> inconsistent with our other input fields right now)

Now updated the patch with requested changes. Also tried with German
translation and worked for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

Séverine Queune  changed:

   What|Removed |Added

  Attachment #75321|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 75489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75489=edit
Bug 19490: Add a 'Holds' column to the items batchmodification tool

To test:
1 - Add some items to bathc modification
2 - Note there is no indication fo holds
3 - Apply patch
4 - Reload and note you can see how many holds (or none)
5 - Note you can hide this column with css:
#batchMod-edit .holds_count { display: none; }
6 - Note the column has a tooltip to indicate item vs. record holds

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #43 from David Gustafsson  ---
Created attachment 75490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75490=edit
Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #42 from Alex Arnaud  ---
(In reply to Katrin Fischer from comment #39)

> Input number for decimals can be problematic for translations in my
> experience. Please test for example with de-DE if the value is correctly
> stored (it will force a decimal comma instead of . on input, which is
> inconsistent with our other input fields right now)

I just tried on a Koha translated into German. Sounds that there no problem
with the values stored. Any test plan to reproduice issue you talked about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20806] New: Column settings issues for holdshistory-table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Bug ID: 20806
   Summary: Column settings issues for holdshistory-table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There is 2 display issues with the table "Holds history" tab :
   - no change when modifying "Column settings > Patrons >
(id=holdshistory-table)". I don't know if it is linked, but the  on
the tab is "table_holdshistory".
  - column "Item type" is always empty

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584

--- Comment #5 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #4)
> I prefer not to push to this one and Bug 19176 on 17.05.x

Why that? It only affects tests and will prevent random failures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584

Jonathan Druart  changed:

   What|Removed |Added

Summary|Koha/Patron/Categories.t is |Koha/Patron/Categories.t is
   |on slow servers |failing on slow servers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #15 from Andrew Isherwood  ---
Hi Magnus - Thanks for looking at this. Currently, all this code does is log
status changes. I can see how you might have thought that other stuff was being
logged as, in addition to logging during ->status calls, we also have potential
logging during a ->store call. This was to catch the case where a status was
being set directly in a ->store call, e.g.

->store({ status => 'REQ' })

Which obviously wouldn't have been caught by the logger in the status method.

So, there is potential to log other "things" during the ->store call, but
currently we don't. It is easily added by adding a new element to the
Koha::ILLRequest::Logger $loggers class property:


$self->{loggers} = {
status => sub {
$self->log_status_change(@_);
}
};

[...]

sub log_maybe {
my ($self, $req, $attrs) = @_;

if (defined $req && defined $attrs) {
foreach my $key (keys %{ $attrs }) {
if (defined($self->{loggers}->{$key})) {
$self->{loggers}->{$key}($req, $attrs->{$key});
}
}
}
}

[...]

sub log_status_change {
my ( $self, $req, $new_status ) = @_;

$self->set_data({
actionname   => 'STATUS_CHANGE',
objectnumber => $req->id,
infos=> to_json({
log_origin=> 'core',
status_before => $req->{previous_status},
status_after  => $new_status
})
});

$self->log_something();
}

As you can see, currently it says "if we get a call to $request->store and the
thing we're storing contains a 'status' property, log the value of it"

We also provide display templates for when it comes to displaying that stored
"thing" back to the user.

I *have* added a call to the logger in the BLDSS backend whenever an API
request is sent to the BLDSS status check endpoint. It's a very simple addition
and can be seen here:

https://github.com/PTFS-Europe/BLDSS-backend/commit/40a4ccdce6e04293970258797d7a0c4fcb33ff32

I hope this helps :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20520] Re-indent moremember.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Owen Leonard  changed:

   What|Removed |Added

  Attachment #75432|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 75488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75488=edit
Bug 20520: Re-indent moremember.tt

This patch reindents the template for the patron detail page,
moremember.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the patron detail page. There should be no visible
difference before and after the applying the patch.

HTML validation before and after the patch should return the same
results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805

--- Comment #2 from Owen Leonard  ---
Created attachment 75487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75487=edit
Bug 20805: Update child to adult patron process broken on several
patron-related pages

This patch fixes a problem with several patron-related pages, where the
"Update child to adult patron" menu item doesn't work. With some pages,
the right category information wasn't being passed from the script to
the template. With some, the right JavaScript variable weren't being
passed from the template to the included JavaScript file.

To test, apply the patch locate some patrons with "child" type patron
categories. With each patron, go to one of the following pages and test
the "update child" process in the toolbar's "More" menu.

 - Circulation ->
   - Batch check out
   - Notices
   - Statistics
   - Files
   - Housebound
   - Delete (test from the deletion confirmation screen).

All test should be performed on a system with multiple adult patron
categories configured AND on a system with only a single adult patron
category.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #41 from Nick Clemens  ---
(In reply to David Gustafsson from comment #40)
> (In reply to Alex Arnaud from comment #38)
> > (In reply to David Gustafsson from comment #37)
> > > Created attachment 75458 [details] [review] [review] [review]
> > > Change search field weight field to decimal and add column declaration to
> > > DBIx results source
> > 
> > Hello David,
> > 
> > You provide changes on Koha/Schema/Result/SearchField.pm. This should be
> > done in a dedicated patch. RM will ignore it.
> > 
> > Also, you replaced the input type number with a input text. This cause
> > errors when typing non-numeric characters in. You can use a input number
> > with step=0.1 to increment decimal numbers.
> > 
> > Need to fail QA
> 
> Ok, I can fix this, though precision should be 0.01 in that case. There is
> server side validation, so everything that is not a number will be ignored
> regardless of input type.
> 
> I was not aware that Koha/Schema/Result/* files should not be changed. How
> does that work for signing off, since without the change Koha will throw an
> error when trying to save weights in admin UI?

Generally you make your code changes, commit the patches, then run:
misc/devel/update_dbix_class_files.pl
And commit those as their own patch - that way the changes are included for
testers but can be regenerated when pushing to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #40 from David Gustafsson  ---
(In reply to Alex Arnaud from comment #38)
> (In reply to David Gustafsson from comment #37)
> > Created attachment 75458 [details] [review] [review]
> > Change search field weight field to decimal and add column declaration to
> > DBIx results source
> 
> Hello David,
> 
> You provide changes on Koha/Schema/Result/SearchField.pm. This should be
> done in a dedicated patch. RM will ignore it.
> 
> Also, you replaced the input type number with a input text. This cause
> errors when typing non-numeric characters in. You can use a input number
> with step=0.1 to increment decimal numbers.
> 
> Need to fail QA

Ok, I can fix this, though precision should be 0.01 in that case. There is
server side validation, so everything that is not a number will be ignored
regardless of input type.

I was not aware that Koha/Schema/Result/* files should not be changed. How does
that work for signing off, since without the change Koha will throw an error
when trying to save weights in admin UI?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

--- Comment #14 from Katrin Fischer  ---
it's NOT a problem we should solve here... (sorry, typo)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805

--- Comment #1 from Owen Leonard  ---
The latter issue is also present with the patron deletion confirmation page
(deletemem.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Magnus Enger  changed:

   What|Removed |Added

  Attachment #75485|0   |1
is obsolete||

--- Comment #6 from Magnus Enger  ---
Created attachment 75486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75486=edit
Bug 20797 - Add link to biblio detail view from ILL detail view

Signed-off-by: Magnus Enger 
Tested thusly:
- Make sure there are a couple of ILL requests with biblionumber
- Apply the patch
- Go to "List requests" page
- Biblionumber is now a link, clicking on it leads to the detail
  view of the biblio
- Go to "Manage request"
- Biblionumber is a link here too, clicking on it leads to detail
  view

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20805] New: Update child to adult patron process broken on several patron-related pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805

Bug ID: 20805
   Summary: Update child to adult patron process broken on several
patron-related pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Because of code missing from templates and Perl scripts, the "Update child to
adult patron" process is not working correctly on several pages:

Broken altogether:

 - Batch check out

If multiple adult patron categories are configured, the "update child" process
should trigger a pop-up where the user can choose a category. On these pages
the pop-up isn't being triggered, and the process results in an error.

 - Notices
 - Statistics
 - Files
 - Housebound

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #75454|0   |1
is obsolete||

--- Comment #4 from Andrew Isherwood  ---
Created attachment 75485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75485=edit
Bug 20797 - Add link to biblio detail view from ILL detail view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com
 Status|Failed QA   |Needs Signoff

--- Comment #5 from Andrew Isherwood  ---
Hi Magus - Latest attachment addresses this. Thanks for the feedback :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #3 from Martin Renvoize  ---
Totally.. not sure how I missed it.. tunnel vision.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #39 from Katrin Fischer  ---
(In reply to Alex Arnaud from comment #38)
> (In reply to David Gustafsson from comment #37)
> > Created attachment 75458 [details] [review] [review]
> > Change search field weight field to decimal and add column declaration to
> > DBIx results source
> 
> Hello David,
> 
> You provide changes on Koha/Schema/Result/SearchField.pm. This should be
> done in a dedicated patch. RM will ignore it.
> 
> Also, you replaced the input type number with a input text. This cause
> errors when typing non-numeric characters in. You can use a input number
> with step=0.1 to increment decimal numbers.
> 
> Need to fail QA

Input number for decimals can be problematic for translations in my experience.
Please test for example with de-DE if the value is correctly stored (it will
force a decimal comma instead of . on input, which is inconsistent with our
other input fields right now)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #38 from Alex Arnaud  ---
(In reply to David Gustafsson from comment #37)
> Created attachment 75458 [details] [review]
> Change search field weight field to decimal and add column declaration to
> DBIx results source

Hello David,

You provide changes on Koha/Schema/Result/SearchField.pm. This should be done
in a dedicated patch. RM will ignore it.

Also, you replaced the input type number with a input text. This cause errors
when typing non-numeric characters in. You can use a input number with step=0.1
to increment decimal numbers.

Need to fail QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/