[Koha-bugs] [Bug 20514] Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514

dani...@brimbank.vic.gov.au changed:

   What|Removed |Added

 CC||dani...@brimbank.vic.gov.au

--- Comment #1 from dani...@brimbank.vic.gov.au ---
Is there any chance of this being patched in 18.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

--- Comment #2 from Alex Buckley  ---
Created attachment 75551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75551=edit
Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions
conditional block

Moving the conditional block [% IF
(CAN_user_circulate_circulate_remaining_permissions ) %] block up the
checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes
this bug.

Test plan:
1. Go to the circ home page and confirm the following
keyboard shortcuts work:

Alt+q = goes to search catalog
Alt+w = goes to renew

2. Go to returns.pl and confirm the following  keyboard shortcuts work:

Alt+q = goes to renew
Alt+w = goes to search catalog

3. Apply patch

4. Restart apache2, memchached and plack

5. Confirm on the returns.pl the following keyboard shortcuts work:
Alt+q = goes to search catalog
Alt+w = goes to renew

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Development FY18 New System Preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Kyle, can you explain what FY18 means?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12004] Regional preference on holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004

Lisette  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20747

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747

Lisette  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12004

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747

Lisette  changed:

   What|Removed |Added

 Depends on||11126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126
[Bug 11126] Make the holds system optionally give precedence to local holds
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Lisette  changed:

   What|Removed |Added

 Blocks||20747
 CC||lisettesla...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747
[Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system
rather than individual library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20817] Acquisitions development - Ordering existing items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Kyle, can you explain this one a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Thx for the super fast fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

--- Comment #2 from Jonathan Druart  
---
Nick, Martin: This should be your first one ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

--- Comment #1 from Jonathan Druart  
---
Created attachment 75550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75550=edit
Bug 20818: Add missing QA Manager entry in 18.05.00 release notes

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20818] New: Missing QA manager entry in 18.05 release notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Bug ID: 20818
   Summary: Missing QA manager entry in 18.05 release notes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: About
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

Sorry Katrin! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

--- Comment #2 from Owen Leonard  ---
Created attachment 75549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75549=edit
Bug 20814: Display issue with 'Saved reports' tabs when memcached is off

This patch changes the configuration of the saved reports table so that
columns which were previously excluded from the table altogether are now
hidden. This prevents a JavaScript error when DataTables tries to
reference a missing column.

To test, apply the patch and go to Reports -> Use saved. You should have
at least one report category configured and assigned to reports in order
for the tabs display to be visible.

Test the table of saved reports under a variety of these circumstances:

 - memcached disabled or enabled
 - reports exist or don't exist which require update from the old
   marcxml syntax
 - cache_expiry and/or update columns are configured in Administration
   -> Columns settings to be shown or hidden

The report category tabs and the table should render correctly under all
circumstances.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #53 from Jonathan Druart  
---
(In reply to Narcis Garcia from comment #52)
> PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver
> site profile. Doesn't Perl have some similar to not make necessary to check
> filesystem paths and permissions?
> 
> I have a Koha 17.11 running in Debian 9 (Stretch) without problem about
> uploads. How does Koha 17.11 deal with this?

Did you see comment 4?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

Narcis Garcia  changed:

   What|Removed |Added

 CC||informat...@actiu.net

--- Comment #52 from Narcis Garcia  ---
PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver site
profile. Doesn't Perl have some similar to not make necessary to check
filesystem paths and permissions?

I have a Koha 17.11 running in Debian 9 (Stretch) without problem about
uploads. How does Koha 17.11 deal with this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

M. Tompsett  changed:

   What|Removed |Added

  Attachment #61337|0   |1
is obsolete||

--- Comment #22 from M. Tompsett  ---
Created attachment 75548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75548=edit
Bug 12759: Use a list (shelf) for batch record modification and deletion

To test:
1) Create a list, add a record to it by its barcode that you don't mind
deleting
2) Go to Tools -> Batch record modification
3) Select the record type 'Authorities'. Confirm the dropdown to select
a list disappears. Confirm selecting 'Biblios' makes the dropdown show
again.
4) Select the list from the dropdown, select a modification template,
Continue
5) Confirm all of the records in that list show on the page. Click
Modify selected records. Confirm this is successful.
6) Go to Batch record deletion
7) Select the record type 'Authorities'. Confirm the dropdown to select
a list disappears. Confirm selecting 'Biblios' makes the dropdown
show again.
8) Select the list from the dropdown and click Continue
9) Confirm all of the records in that list show on the page. Click
Delete selected records. Confirm this is successful.
10) Go back to your lists. The list should still exist but it will now be
empty.

Sponsored-by: Catalyst IT

NOTE: Rebased to work -- Mark Tompsett

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned during circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20350] Add column configuration to table of saved reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350

--- Comment #11 from Jonathan Druart  
---
(In reply to Lucie Gay from comment #4)
> Tested on sandbox Biblibre n°9
> 
> Go to Reports -> Use saved : 
> there is no button "Column visibility" in the table's pagination toolbar,
> report groups are displayed like a list and not in tabs
> 
> Go to Administration -> Columns settings :
> The selection is not applied

It was a real bug :)
See bug 20814.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20350


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350
[Bug 20350] Add column configuration to table of saved reports
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20350] Add column configuration to table of saved reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350

Owen Leonard  changed:

   What|Removed |Added

 Blocks||20814


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814
[Bug 20814] Display issue with 'Saved reports' tabs when memcached is off
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20817] New: Acquisitions development - Ordering existing items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Bug ID: 20817
   Summary: Acquisitions development - Ordering existing items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Acquisitions: attaching orders to existing records while retaining 9xx
information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20816] New: add user expiration date to SIP2 message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816

Bug ID: 20816
   Summary: add user expiration date to SIP2 message
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

add a user's expiration date to the SIP2 message in its own field, at least
Patron Information Response (64), and probably the Patron Status Response (24)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] New: Development FY18 New System Preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Bug ID: 20815
   Summary: Development FY18 New System Preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: k...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

1 - Add a enw system preference "Don'tForgiveLostAfter" which would allow
specification of a range of time
2 - modify the check in routine to check the value of the itemlost_on field and
only refund if before this time
3 - Add feedback for circulation staff to alert that item was lost but fee is
not refunded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
Summary|Merge deletedbiblio* and|Merge deleted* tables with
   |deleteitems tables with |their "alive" cousins
   |their "alive" cousins   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #2 from Owen Leonard  ---
The item search table is rendered server-side, so all sorting happens
server-side. This eliminates some of our standard sorting methods, like
embedding a sortable string in a title tag.

Renaming the column "cn_sort" has the right effect for the purposes of sorting:
The column name "cn_sort" is passed to the query and the rows are sorted
correctly by call number.

Unfortunately this breaks the column filter: "cn_sort" is an ambiguous column
name for the purposes of the query because of biblioitems.cn_sort. I'm not sure
if there is a good way to handle this besides adding some conditional code
specific to these columns.

Suggestions welcome!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

--- Comment #1 from Owen Leonard  ---
The error happens when memcached is disabled. This eliminates the "Cache
expiry" column and messes up the column count for DataTAbles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #3 from Jonathan Druart  
---
Pushed to master for 18.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #74 from Jonathan Druart  
---
Last patch pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Séverine Queune  changed:

   What|Removed |Added

Summary|Display issue with 'Saved   |Display issue with 'Saved
   |reports' tabs   |reports' tabs when
   ||memcached is off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75319|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 75547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75547=edit
Bug 20767: Display a stack trace when a method is not covered by tests

When a method is not allowed yet (not covered by tests), developers get
an error the is not really useful: "The method XXX is not covered by
tests!"
It would be more useful to have a stack trace in order to know where
this error come from.

Test plan:
Modify some code to display this stack trace and confirm it makes sense
to have it, i.e. it will make debug easier

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20814] New: Display issue with 'Saved reports' tabs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814

Bug ID: 20814
   Summary: Display issue with 'Saved reports' tabs
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

Created attachment 75546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75546=edit
Saved report - bullet list instead of tabs

Saved report tabs become a bullet list when using the search form on
/cgi-bin/koha/reports/reports-home.pl
Problem may doesn't appear on some instances, test with sandbox to reproduce
(screenshot from Biblibre's sandbox #11).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11375] Improve patrons permissions display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

--- Comment #8 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #7)
> Hi Owen, are you still working on this?

Whoops, I missed this question when you first asked. I still have an up-to-date
branch with this. I'm thinking about trying to get it in with Bug 20813 (unless
that bug proves to be controversial?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #37 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #36)
> 1. when adding/editing a patron category, "Display in quick add: " is a bit
> meaningless, I would add a quick description, like we have for "Default
> privacy:", "Block expired patrons:", etc.
OK

> 
> 2. There is a condition ([% IF Koha.Preference('PatronQuickAddFields') ||
> Koha.Preference('BorrowerMandatoryField') %]) template-side to display the
> "Quick add new patron" button, should we do the same on the patron's
> category form?
Indeed

> 
> 
> And a question: what is the use case here? It seems that it would have been
> done in css or javascript easily... :)
It is a request from Aix-Marseille University which has 10 patron categories.
I think its more efficient for them to have only the most-used categories in
quick-add.
The actually have a JS customisation but it would be better to have it for
everybody in code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #5 from Kyle M Hall  ---
Original pre-rebase code ( known to be working ):
https://github.com/bywatersolutions/bywater-koha-devel/tree/user_permissions_revamp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall  changed:

   What|Removed |Added

URL||https://github.com/bywaters
   ||olutions/bywater-koha-devel
   ||/tree/bug_20813

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584

--- Comment #6 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Fridolin SOMERS from comment #4)
> > I prefer not to push to this one and Bug 19176 on 17.05.x
> 
> Why that? It only affects tests and will prevent random failures.

Bug 19176 is complex, I want to stabilize 17.05.x and focus on 17.11.x soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #4 from Kyle M Hall  ---
Created attachment 75545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75545=edit
Bug 20813 [Do Not Push]: Update Schema Files

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #3 from Kyle M Hall  ---
Created attachment 75544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75544=edit
Bug 20813: Remove deleted table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #1 from Kyle M Hall  ---
Created attachment 75542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75542=edit
Bug 20813: Update db schema

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #2 from Kyle M Hall  ---
Created attachment 75543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75543=edit
Bug 20813: Revamp user permissions system

Koha's current user permissions system is a bit convoluted and limited
due to it's legacy where the permissions system was a simple set of
flags. A second layer of sub-permissions were later added complication
and obfuscation to the system.

We should revamp the permissions system to be a more modern system and
open the path to having unlimited nesting of sub-permissions instead of
shoe-horning sub-permissions into the limited system we have.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Restart all the things!
4) Koha should still enforce user permissions as before

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20813] New: Revamp user permissions system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Bug ID: 20813
   Summary: Revamp user permissions system
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha's current user permissions system is a bit convoluted and limited due to
it's legacy where the permissions system was a simple set of flags. A second
layer of sub-permissions were later added complication and obfuscation to the
system.

We should revamp the permissions system to be a more modern system and open the
path to having unlimited nesting of sub-permissions instead of shoe-horning
sub-permissions into the limited system we have.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75531|0   |1
is obsolete||

--- Comment #69 from David Gustafsson  ---
Created attachment 75541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75541=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75527|0   |1
is obsolete||

--- Comment #65 from David Gustafsson  ---
Created attachment 75537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75537=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75529|0   |1
is obsolete||

--- Comment #67 from David Gustafsson  ---
Created attachment 75539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75539=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #70 from David Gustafsson  ---
Now patches should apply to latest master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75528|0   |1
is obsolete||

--- Comment #66 from David Gustafsson  ---
Created attachment 75538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75538=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75530|0   |1
is obsolete||

--- Comment #68 from David Gustafsson  ---
Created attachment 75540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75540=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75526|0   |1
is obsolete||

--- Comment #64 from David Gustafsson  ---
Created attachment 75536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75536=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20812] Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812

Diana Romero  changed:

   What|Removed |Added

Version|unspecified |16.11
 OS|All |Linux
   Deadline||2018-05-24

--- Comment #1 from Diana Romero  ---
El error se produce el 24/05/2018 hora 8:14 am

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20812] New: Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812

Bug ID: 20812
   Summary: Tag "" is not a valid tag. at
/usr/share/koha/lib/C4/Biblio.pm line 2615.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bibliot...@colprecentro.edu.co
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615.
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #63 from David Gustafsson  ---
I think root cause of this is that the "Bug 18316: Ability to weight search
fields" commit was created from a commit with the line:
"type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno')
..." in /data/mysql/kohastructure.sql
when in current Koha master the line is:
`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum')

This is the reason why:
https://github.com/Koha-Community/Koha/commit/cff62796ea9fc227c24fec8f8f3f153a715796ef

I can rebase the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #73 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #72)
> Created attachment 75535 [details] [review]
> Bug 19287: (follow-up) Use the notice defined for the library of the patron

Fix the bug caught by Séverine on bug 20767 comment 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #72 from Jonathan Druart  
---
Created attachment 75535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75535=edit
Bug 19287: (follow-up) Use the notice defined for the library of the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #4 from Séverine Queune  ---
I have a (good ?) example on my test instance : when I try to use the new
syspref to mark an item lost and notify patron from holds to pull list, I get
this software error :
The method homebranch is not covered by tests!"

Applying this patch, I get this one :

The method Koha::Patron->homebranch is not covered by tests!

Trace begun at /var/repositories/koha/Koha/Object.pm line 398
Koha::Object::AUTOLOAD('Koha::Patron=HASH(0x8d10e08)') called at
/var/repositories/koha/
circ/pendingreserves.pl line 71

Is it the behaviour you were looking for ?
As I don't know what you expect I prefer not signing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #62 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18316:
Something went wrong !Applying: Bug 18316: Ability to weight search
fields
Using index info to reconstruct a base tree...
M   installer/data/mysql/kohastructure.sql
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18316: Ability to weight search fields
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 18316 - Add weighting/relevancy options to ElasticSearch

75526 - Bug 18316: Ability to weight search fields
75527 - Bug 18316: Add weighting/relevancy options to ES query on simple search
75528 - Bug 18316: String changes
75529 - Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return
a result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set
75530 - Bug 18316: Change search field weight field to decimal
75531 - Bug 18316: Update Koha/Schema/Result/SearchField.pm

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-18316-Ability-to-weight-search-fields-MFIcJl.patch .


Same result on my test instance :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #241 from Séverine Queune  ---
I tried to test bug 20810 but this dependency doesn't apply :

Bug 11708 - Display all basketgroups on one page, and new column
aqbasketgroups.closeddate

75003 - Bug 11708: Change aqbasketgroups.closed to closeddate
75004 - Bug 11708: New page for basket groups

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11708: Change aqbasketgroups.closed to closeddate
Applying: Bug 11708: New page for basket groups
Using index info to reconstruct a base tree...
M   acqui/basketgroup.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Falling back to patching base and 3-way merge...
error: The following untracked working tree files would be overwritten by
merge:
Koha/Acquisition/Basketgroup.pm
Koha/Acquisition/Basketgroups.pm
acqui/basketgroups.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt
Please move or remove them before you can merge.
Aborting

Also failed on Biblibre's sandbox #11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

--- Comment #8 from Séverine Queune  ---
Just tested once more with follow-up, tooltip on each row is clear for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

Séverine Queune  changed:

   What|Removed |Added

  Attachment #75489|0   |1
is obsolete||

--- Comment #6 from Séverine Queune  ---
Created attachment 75533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75533=edit
Bug 19490: Add a 'Holds' column to the items batchmodification tool

To test:
1 - Add some items to bathc modification
2 - Note there is no indication fo holds
3 - Apply patch
4 - Reload and note you can see how many holds (or none)
5 - Note you can hide this column with css:
#batchMod-edit .holds_count { display: none; }
6 - Note the column has a tooltip to indicate item vs. record holds

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

Séverine Queune  changed:

   What|Removed |Added

  Attachment #75516|0   |1
is obsolete||

--- Comment #7 from Séverine Queune  ---
Created attachment 75534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75534=edit
Bug 19490: (follow-up) Add tooltip to each row

To test:
1 - Run batch modification on some items
2 - Hover over the holds column
3 - Note the tool tip
4 - PLace some holds to verify combinations of item/record level holds
show appropriately

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19706] Item search: Unsupported format html

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18047

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19706

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75503|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 75532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75532=edit
Bug 20262: Add ability to refund lost item fees without creating credits

Some libraries handle refunding of paid lost fees at a financial office and not
within Koha. To facilitate this, it would be good for Koha to have the option
to not generate lost returned credits by skipping fully paid lost items, and
only refunding the outstanding balance on partially paid lost fees.

Test Plan:
1) Apply this patch
2) Set your lost item refund on return policies to 'Only if unpaid'
3) Mark an item lost, charging the lost fee
4) Return the item, a full refund should ocurr
5) Mark another item lost, charging the lost fee
6) Make a partial payment on this lost fee
7) Return the item
8) The remaining balance of that fee should be 0, but the patron should
   not recieve a credit for the already paid balance
8) Mark another item lost, charging the lost fee
9) Fully pay the lost fee
10) Return the item. The paid lost fee should be unaffected.

Signed-off-by: Kyle M Hall 

Signed-off-by: Martha Fuerst 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #17 from Magnus Enger  ---
Hm, the previous version of the patch was working as expected, but with the
most recent version, when I go to "Manage request" i get an "Internal Server
Error". The Plack error log says: 

Template process failed: undef error - The method logs is not covered by tests!
at /home/vagrant/kohaclone/C4/Templates.pm line 122

The code around line 122 looks like this:

120 my $data;
121 binmode( STDOUT, ":utf8" );
122 $template->process( $self->filename, $vars, \$data )
123   || die "Template process failed: ", $template->error();
124 return $data;

Not quite sure if there is a problem with the patch or if i screwed up my
testing environment?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #16 from Magnus Enger  ---
(In reply to Andrew Isherwood from comment #15)
> Hi Magnus - Thanks for looking at this. Currently, all this code does is log
> status changes. 

Ah, gotcha! I'll sign off, then. 

If you do find the time to add logging of any changes to the metadata I'll be
happy to test and sign off on it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20811] New: Fix wrong usage of ModBiblio in bulkmarcimport.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811

Bug ID: 20811
   Summary: Fix wrong usage of ModBiblio in bulkmarcimport.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

In misc/migration_tools/bulkmarcimport.pl, line  454, ModBiblio is called like
so:

  eval { ( $biblionumber, $biblioitemnumber ) = ModBiblio( $record,
$biblionumber, GetFrameworkCode($biblionumber) ) };

But the POD for ModBiblio says:

  "Returns 1 on success 0 on failure"

So $biblionumber gets 1 or 0, and $biblioitemnumber never gets anything. This
leads to problems when ModBiblioMarc is called on line 487:

  ModBiblioMarc( $clone_record, $biblionumber, $framework );

If the ModBiblio was successfull, this will try to updated the record with
biblionumber = 1, which is most likely not what we want.

(I probably won't have the time to fix this soon, so please beat me to it!)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #61 from David Gustafsson  ---
Not used to working with multiple patches in git bz, so had removed the schema
changes locally, but used git bz incorrectly so it did not get included. Later
managed to screw things up even more, but now managed to restore the patches
(which I accidentally obsoleted) and fix the two last ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75522|0   |1
is obsolete||

--- Comment #57 from David Gustafsson  ---
Created attachment 75528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75528=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75525|0   |1
is obsolete||

--- Comment #60 from David Gustafsson  ---
Created attachment 75531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75531=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75524|0   |1
is obsolete||

--- Comment #59 from David Gustafsson  ---
Created attachment 75530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75530=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75523|0   |1
is obsolete||

--- Comment #58 from David Gustafsson  ---
Created attachment 75529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75529=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75521|0   |1
is obsolete||

--- Comment #56 from David Gustafsson  ---
Created attachment 75527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75527=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #55 from David Gustafsson  ---
Created attachment 75526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75526=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #54 from David Gustafsson  ---
Created attachment 75525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75525=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #53 from David Gustafsson  ---
Created attachment 75524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75524=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #52 from David Gustafsson  ---
Created attachment 75523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75523=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #51 from David Gustafsson  ---
Created attachment 75522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75522=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75520|0   |1
is obsolete||

--- Comment #50 from David Gustafsson  ---
Created attachment 75521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75521=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75073|0   |1
is obsolete||
  Attachment #75074|0   |1
is obsolete||
  Attachment #75075|0   |1
is obsolete||
  Attachment #75076|0   |1
is obsolete||
  Attachment #75458|0   |1
is obsolete||
  Attachment #75490|0   |1
is obsolete||
  Attachment #75519|0   |1
is obsolete||

--- Comment #49 from David Gustafsson  ---
Created attachment 75520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75520=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #48 from David Gustafsson  ---
Created attachment 75519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75519=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #47 from Alex Arnaud  ---
(In reply to David Gustafsson from comment #43)
> Created attachment 75490 [details] [review]
> Update Koha/Schema/Result/SearchField.pm

Hello David,

Your dedicated patch is ok. But, please, remove the changes on the schema file
from the previous one: attachment 75458. And add the bug number at the start of
your commit messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20810] Add filters and links in basketgroups page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20810] Add filters and links in basketgroups page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810

--- Comment #1 from Julian Maurice  ---
Created attachment 75518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75518=edit
Bug 20810: Add filters and links in basketgroups page

- Open/Closed filtering
- Per-column filtering
- Add links to basketgroups and booksellers
- Display basketgroup id next to basketgroup name

Test plan:
1. Go to basketgroups page (/acqui/basketgroups.pl)
2. Verify that the "Open/Closed/All" buttons work correctly by showing
   respectively only open basketgroups, only closed basketgroups, and
   all basketgroups. The "date closed" column should be hidden when only
   open basketgroups are shown.
   A hidden "Closed" column containing only "1" or "0" was added for
   these buttons to work correctly. Verify that you do not see it.
3. Verify that the column filters are displayed under the column headers
   and that they filter using only the data in their respective column.
   Verify that there is no filter for "Action" column.
4. Verify that the bookseller names are now links to the bookseller
   pages
5. Verify that basketgroup names are now links to the basketgroup pages
6. Verify that basketgroup id is displayed in the 'Name' column, next to
   the basketgroup name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Blocks||20810


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810
[Bug 20810] Add filters and links in basketgroups page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20810] New: Add filters and links in basketgroups page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810

Bug ID: 20810
   Summary: Add filters and links in basketgroups page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 11708

- Open/Closed filtering
- Per-column filtering
- Links to basketgroups and booksellers


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708
[Bug 11708] Display all basketgroups on one page, and new column
aqbasketgroups.closeddate
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

--- Comment #9 from Katrin Fischer  ---
Created attachment 75517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75517=edit
Bug 7651: (follow-up) Correct visibility on admin sidebar

This patch corrects visibility of links to the different
acquisition pages from the admin sidebar.

It also makes a correction to the links on the acq start
page:
- Budgets = period_manage
- Funds = budget_manage

To test:
- Follow the test plan of the first patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/