[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #87 from Liz Rea --- Since this patch trying to import patrons seems to be noisy, lots of Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1017, <$handle> line 512. example line that has this problem, with header, private stuff removed: cardnumber,firstname,surname,address,address2,city,zipcode,email,phone,B_phone,branchcode,patron_attributes,borrowernotes,categorycode 10090,"borrower surname",firstname,"Po Box x"," City",,,firstname.surn...@institution.co.nz,,123456,BRANCHCODE,GROUP:STAFF,,STAFF It doesn't seem to affect the performance, patrons still get imported, but it sure does fill up the logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #34 from Jonathan Druart --- "Select all" only select visible rows. If it is expected it is confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #33 from Jonathan Druart --- (In reply to Jonathan Druart from comment #32) > Tiny ergonomic issue when the export column is displayed: > https://screenshots.firefox.com/0gdGrGVyEBanCz8n/pro.kohadev.org Hum, the export column should not be displayed actually, ExportCircHistory is off. But it is in the "column visibility" list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #32 from Jonathan Druart --- Tiny ergonomic issue when the export column is displayed: https://screenshots.firefox.com/0gdGrGVyEBanCz8n/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20948] Hold requests on detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #142 from Jonathan Druart --- Created attachment 76088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76088=edit Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #143 from Jonathan Druart --- Created attachment 76089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76089=edit Bug 12395: Add FK constraint and use patron-title.inc Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #141 from Jonathan Druart --- Created attachment 76087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76087=edit Bug 12395: Use standard + markup for showorder.tt Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #139 from Jonathan Druart --- Created attachment 76085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76085=edit Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #140 from Jonathan Druart --- Created attachment 76086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76086=edit Bug 12395: (QA follow-up) Add class/id to body tag Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #138 from Jonathan Druart --- Created attachment 76084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76084=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #137 from Jonathan Druart --- Created attachment 76083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76083=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #135 from Jonathan Druart --- Forgot the signed-off-by line, reattaching... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart changed: What|Removed |Added Attachment #76074|0 |1 is obsolete|| Attachment #76075|0 |1 is obsolete|| Attachment #76076|0 |1 is obsolete|| Attachment #76077|0 |1 is obsolete|| Attachment #76078|0 |1 is obsolete|| Attachment #76079|0 |1 is obsolete|| Attachment #76080|0 |1 is obsolete|| Attachment #76081|0 |1 is obsolete|| --- Comment #136 from Jonathan Druart --- Created attachment 76082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76082=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #134 from Jonathan Druart --- (In reply to Julian Maurice from comment #125) > (In reply to Jonathan Druart from comment #124) > > (In reply to Jonathan Druart from comment #113) > > > Bug 12395: Save order line's creator > > > reverts bug 20303 > > > > This one is still missing I think. > > These changes are intended. orderreceive.pl doesn't use > aqbaskets.authorisedby anymore (with those patches applied) Indeed! I have tested to delete the account of the creator and receive an order and it seems ok. The screen displays "Ordered by: " and nothing in front. Maybe we could add something to explain why it's empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #133 from Jonathan Druart --- Created attachment 76081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76081=edit Bug 12395: Add FK constraint and use patron-title.inc Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #132 from Jonathan Druart --- Created attachment 76080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76080=edit Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #131 from Jonathan Druart --- Created attachment 76079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76079=edit Bug 12395: Use standard + markup for showorder.tt Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #130 from Jonathan Druart --- Created attachment 76078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76078=edit Bug 12395: (QA follow-up) Add class/id to body tag Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #128 from Jonathan Druart --- Created attachment 76076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76076=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #129 from Jonathan Druart --- Created attachment 76077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76077=edit Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #127 from Jonathan Druart --- Created attachment 76075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76075=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart changed: What|Removed |Added Attachment #75900|0 |1 is obsolete|| Attachment #75901|0 |1 is obsolete|| Attachment #75902|0 |1 is obsolete|| Attachment #75903|0 |1 is obsolete|| Attachment #75904|0 |1 is obsolete|| Attachment #75905|0 |1 is obsolete|| Attachment #75906|0 |1 is obsolete|| Attachment #75907|0 |1 is obsolete|| --- Comment #126 from Jonathan Druart --- Created attachment 76074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76074=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20948] New: Hold requests on detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Bug ID: 20948 Summary: Hold requests on detail.pl Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The next hold request showing on the detail.pl page next to items is useless and should be removed or fixed. The information for requests on an item is misleading. It shows the next item level hold rather than showing the next hold it will fulfill. I understand how this might be useful in some obscure circumstances, but for the most part it leads staff to believe that this is the next hold it will fill, and that is not the case. Case in point...we have a new item, only one in the collection. 33 next available holds, and 1 item level hold at the very end of the list, going to a different library. With all the other holds ahead of it, and the fact that we have local holds priority enabled, this looks very wrong, and leads staff to confusion and panic. It might be helpful to some libraries to see that there is a specific hold on a particular item, but around here, most libraries will view this as misleading. There should be a setting to change the behavior, or turn it off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Jonathan Druart changed: What|Removed |Added Attachment #76072|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 76073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76073=edit Bug 20651: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger The modal looks good! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20561] Don't allow holds when all items are withdrawn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561 Jonathan Druart changed: What|Removed |Added Attachment #76071|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Jonathan Druart changed: What|Removed |Added Attachment #75655|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 76072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76072=edit Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger The modal looks good! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20561] Don't allow holds when all items are withdrawn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561 --- Comment #4 from Jonathan Druart --- Created attachment 76071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76071=edit Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger The modal looks good! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20561] Don't allow holds when all items are withdrawn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #29 from Jonathan Druart --- Well, yes it works, but I do not think it is the way to do. I still think we should use the standard title-string sort method. I am not going to consider it as blocker anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I guess it would be useful to have the result floating as well (?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Jonathan Druart changed: What|Removed |Added Attachment #75935|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 76070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76070=edit Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard Followed the test plan and the patch works. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- I do not recreate, I noticed that accountlines.itemnumber is set to NULL when the item is deleted. Can you detail a bit more the steps to recreate? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||18497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 [Bug 18497] Downloading a report passes the constructed SQL as a parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Jonathan Druart changed: What|Removed |Added Blocks||20945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 [Bug 20945] Report params not escaped when downloading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Attachment #76066|0 |1 is obsolete|| Attachment #76067|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 76068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76068=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #5 from Kyle M Hall --- Created attachment 76069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76069=edit Bug 20912: Update schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #3 from Kyle M Hall --- Created attachment 76067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76067=edit Bug 20912: Update schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #2 from Kyle M Hall --- Created attachment 76066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76066=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #1 from Kyle M Hall --- Created attachment 76065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76065=edit Bug 20912: Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental Fees based on Time Period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20947] New: Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947
Bug ID: 20947
Summary: Navigating to moremember.pl for a patron who has
fines on deleted items causes software error.
Change sponsored?: ---
Product: Koha
Version: 17.11
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Note this ONLY happens in 17.11 -- earlier versions of Koha don't have this
code, and GetMemberAccountRecords does not exist in 18.05+ (per bug 12001)...
however it is a major problem in 17.11.
--
Steps to re-create:
1) Find a borrower with fines, preferably on an item that has already been
checked in.
2) Delete the item
3) Navigate to moremember.pl for that borrower. This will trigger a software
error with
Can't call method "biblio" on an undefined value at
/usr/share/koha/lib/C4/Members.pm line 767.
in the plack-error.log
Here's the code:
750 sub GetMemberAccountRecords {
751 my ($borrowernumber) = @_;
752 my $dbh = C4::Context->dbh;
753 my @acctlines;
754 my $numlines = 0;
755 my $strsth = qq(
756 SELECT *
757 FROM accountlines
758 WHERE borrowernumber=?);
759 $strsth.=" ORDER BY accountlines_id desc";
760 my $sth= $dbh->prepare( $strsth );
761 $sth->execute( $borrowernumber );
762
763 my $total = 0;
764 while ( my $data = $sth->fetchrow_hashref ) {
765 if ( $data->{itemnumber} ) {
766 my $item = Koha::Items->find( $data->{itemnumber} );
767 my $biblio = $item->biblio;
The problem is that $data->{itemnumber}, (the itemnumber read from
accountlines) may point to an active item or a deleted item. If the item was
deleted, $item, as populated in
my $item = Koha::Items->find( $data->{itemnumber} );
will be undef, and
my $biblio = $item->biblio;
Will throw the error message.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Kyle M Hall changed: What|Removed |Added Attachment #70241|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 76064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76064=edit Bug 16804 - semicolons break series search in 490 To test: * have OPACSuppression on * have a record with a 490 field a la: 490 _a something ; _v 123 * go to the opac and search for this record * click the Series link from the detail Without this patch, there will be no results. With this patch, you will get relevant results (possibly the same record back) Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20946] New: Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Bug ID: 20946 Summary: Cannot pay fines for patrons with credits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Add a $5 credit to a patron 2 - Add a $1 fine 3 - Try to pay all fines 4 - You will be told to enter a value less than or equal to -4.00 5 - Observe you cannot do that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #10 from Victor Grousset/tuxayo --- Rebased and compared the old and new patches to check that nothing was lost or added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #43116|0 |1 is obsolete|| --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 76063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76063=edit Bug 14666 - add fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #3 from Phil Ringnalda --- Still present in master. How about the example from bug 5844, which fixed the copy of jquery.highlight-3.js in koha-tmpl/opac-tmpl/ but not the copy in koha-tmpl/intranet-tmpl/, "mag ma m"? All that's actually needed is to patch the intranet-tmpl copy the same way. I don't quite see how an example can actually work, unless there's some standard set of bib records everyone has that I haven't yet run across documentation of, though. Before I realized why it only happens in the staff client, I was drafting a set of steps to reproduce that were going to start with "Create a bib record with the title A is for apple and another with the title A my name is Anna" since reproducing requires only that you have a search which in your database will return two or more records and will have matches in things which are displayed in the staff client search results list. "a a" is actually a pretty good example since as long as you have two (or more) records in your database which contain the letter "a" in any indexed field, you will have highlights that will show the letter being removed from the DOM in the words "Material" and "Format" and "Literary" in the line "Material type: Book Format: print Literary form: Not fiction" even if you don't have highlights in the author or title. Might still fail for a non-English install, but otherwise it seems like the most likely to work in any install with any bib records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi --- Right now, we are able to create credits (mancredit.pl) but there's no way to 'use' the existing credit against existing outstanding (debit) lines. This is odd in the interface and worth working on. I don't think this should be implemented as an automatic feature in the first place. I would rather implement a way to assign remaining credits to specific lines, and THEN add the option to do it automatically, maybe syspref-controlled (better by payment type ;-)) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #71 from Jerome Charaoui --- Created attachment 76062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76062=edit bug 15562: Roll-up and rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Jerome Charaoui changed: What|Removed |Added CC||jchara...@cmaisonneuve.qc.c ||a --- Comment #70 from Jerome Charaoui --- I found this bug report after being mentioned on IRC, and as a sysadmin working with Koha, I'm quite interested in this. At our public College, we like to provide an autonomous Koha instance to every student so they can work on assignments and expriment and learn the software. The instances are regularly thrown away and recreated. We can do it without Plack, but it's somewhat painful to use, even more so with recent versions. We can have up to 120 instances available at any one time on a single server! I was able to apply the patchset on top of master with only very few adjustments and make it work with 5 instances. But I only did very cursory test, just making sure login works and the catalogue search was available. I soon hit problems, though. For example, rebuild_zebra.pl throws a segfault. While I understand that a following the path laid out with this patch through to the end might seem like a huge task, I would be very happy to see this patchset maintained and improved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 --- Comment #9 from Bernardo Gonzalez Kriegel --- (In reply to Fridolin SOMERS from comment #7) > Does not apply on 17.11..x because of > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ > marc21_field_007.tt > I'm not comfortable with MARC21 so can you provide a rebase ? Master has Bug 19823 applied, that's the reason. Don't know if this needs it's own Sign/QA etc. This new patch implements the same changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 --- Comment #7 from Jonathan Druart --- Created attachment 76061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76061=edit Bug 20285: Lost item refund won't always pay down lost item fee first Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. Test Plan: 1) Find a patron with existing fines 2) Ensure your settings will charge patrons for lost items 3) Check out an item to a patron with existing fees that need paid 4) Mark the item lost, charging the lost item fee 5) Return the item 6) Note the fee was refunded, but it paid down earlier fines first, and not the lost item fee first 7) Apply this patch set 8) Repeat steps 1 - 5 9) Note the lost item fee is the first fee to be paid off by the lost item fee refund Signed-off-by: Maryse Simard Followed the test plan and it works as expected. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Jonathan Druart changed: What|Removed |Added Attachment #72122|0 |1 is obsolete|| Attachment #75936|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 76060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76060=edit Bug 20285: Unit Test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 --- Comment #5 from Jonathan Druart --- Caused by bug 14826? Is this bug present in 17.11? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 76059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76059=edit Bug 20700: MARC21 add/update leader/007/008 codes (17.11.x version) For Koha 17.11.x version This add/updates some codes from updates 22 (Apr/16) and 23 (Nov/16) Update 22 https://www.loc.gov/marc/up22bibliographic/bdapndxg.html Sound Recording 007/03 n (new) Sound Recording 007/10 n (new) Sound Recording 007/01 r (new) Sound Recording 007/01 s (new) Update 23 https://www.loc.gov/marc/up23bibliographic/bdapndxg.html Leader/18 n (new) Music 008/20 p (new), b (renamed) To test: 1) Apply the patch 2) Clean your browser cache 3) Go to cataloguing -> new record 4) Leader plugin: check leader/18, new option 'n' 5) 007 Plugin: a) Sound recording check 007/01 new 'r' check 007/03 new 'n' check 007/10 new 'n' b) Electronic resource check 007/01 new 's' 6) 008 Plugin: Music, check 008/20 renamed 'b', new 'p' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Is this really minor? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Fridolin SOMERS --- I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20928] Checkout status not showing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 --- Comment #2 from Jonathan Druart --- Created attachment 76058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76058=edit Bug 20928: Fix regression - display patron's info on moredetail if item is checked out This patch is a follow-up of commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used Test plan: - Check an item out - Go on the moredetail.pl page of this biblio record Home › Catalog › Item details for your biblio - Confirm that you see: "Checkout status: Checked out to" followed by the patron's info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20928] Checkout status not showing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20928] Checkout status not showing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 Jonathan Druart changed: What|Removed |Added Depends on||18403 --- Comment #1 from Jonathan Druart --- Caused by commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What|Removed |Added Blocks||20928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 [Bug 20928] Checkout status not showing patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20928] Checkout status not showing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate Severity|normal |major Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 --- Comment #1 from Jonathan Druart --- Created attachment 76057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76057=edit Bug 20919: Remove unecessary search calls on the biblio detail page There is a countanalytics flag that is set for items used in analytical biblio records. This flag is only used in the template when 'analyze' has been passed to the script. In order to avoid unecessary search calls (1 per item), $analyse must be tested. Test plan: 0. Do not apply the patch 1. tail -f /var/log/koha/kohadev/zebra-output.log 2. Hit a bibliographic record detail page with several items 3. Notice that the log has 1 line per item: 11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception) 4. Apply the patch 5. Hit the page again 6. There is nothing in the zebra log file If you are familiar with analytic records, confirm that you are not allowed to remove an item that is used in analytical biblio records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 --- Comment #1 from Nick Clemens --- Created attachment 76056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76056=edit Bug 20945: Escape SQL parameters when constructing download links TO test: 1 - Create a report that takes a parameter 2 - Enter a parameter containing '%' 3 - Attempt to download report, note link is misconstructed 4 - Apply patch 5 - Reload 6 - Note URL is now correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20945] New: Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Bug ID: 20945 Summary: Report params not escaped when downloading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Caused by bug 18497 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20944] Add routes to add credits and debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||20942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 [Bug 20942] Add route to get patron's account balance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20944] Add routes to add credits and debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi changed: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Patrons_account_l ||ines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits and debits to a patron's account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20944] New: Add routes to add credits and debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug ID: 20944 Summary: Add routes to add credits and debits to a patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #74 from David Gustafsson --- I'm actively working on fixing the remaining issues and moving relevant things from C4 into the Koha namespace. Will probably submit changes tomorrow or beginning of next week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 76055
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76055=edit
Bug 20942: Add route to get patron's account balance
This patch implements the /patrons/{patron_id}/account endpoint. It can
be used to get the patron's balance information, including outstanding
lines.
To test:
- Apply this patchset
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: tests pass!
- Make your favourite REST testing tool (RESTer on Firefox?) do:
GET /api/v1/patrons/{patron_id}/account
to a valid patron_id. Play with Koha's UI to add credits/payments and
notice the endpoint returns the right info following the voted RFC. [1]
- Sign off :-D
[1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 76054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76054=edit
Bug 20942: Unit tests for /patrons/{patron_id}/account
This patch adds tests for the /patrons/{patron_id}/account endpoint.
To test:
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> FAIL: Tests should fail because the endpoint is not implemented.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 76053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76053=edit
Bug 20942: OpenAPI spec for /patrons/{patron_id}/account
This patch adds the OpenAPI spec for the following paths:
- /patrons/{patron_id}/account
It also adds object definitions for:
- balance
- account line
Account line is to be used on both /account/lines (when implemented)
and for embeding the outstanding lines in the balance endpoint
(/patrons/{patron_id}/account).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added CC||josef.mora...@gmail.com, ||lari.task...@jns.fi, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20943] New: Cannot enable shibboleth and LDAP at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943 Bug ID: 20943 Summary: Cannot enable shibboleth and LDAP at the same time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org In C4::Auth->checkpw the authentication methods are in an elsif loop. When both methods are enabled the ldap loop catches the login, fails because it doesn't have the correct information, and a shibboleth login is not passed through. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Patrons_account_l ||ines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS --- Not backported to 17.11.x. I prefer not to change the compiled CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 [Bug 20942] Add route to get patron's account balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added Blocks||15165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 [Bug 15165] REST API routes to list, edit and pay borrower's accountlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account->balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 [Bug 20942] Add route to get patron's account balance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20942] Add route to get patron's account balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||17586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 [Bug 17586] Add the Koha::Account->balance method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
