[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #129 from Katrin Fischer  ---
Apart from the other issues that still need fixing, is there a way we could run
a performance test on this? I know we got libraries around with many years
(10+) of circulation data in these tables. Could this chance cause performance
issues?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Fridolin SOMERS  ---
(In reply to Koha Team Lyon 3 from comment #3)
> Hello,
> Tested on a sandbobx (biblibre sandbox n°1)
> At step n°11, there's an error when clicking on "allow" :
> 
> Software error:
> Undefined subroutine ::Patron::Debarments::AddDebarment called at
> /home/koha/src/Koha/Patron/Discharge.pm line 85.
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error.

You need to apply also Bug 20951 to be able to run test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20962] New: Overhaul to notices

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Bug ID: 20962
   Summary: Overhaul to notices
 Change sponsored?: Sponsored
   Product: Koha
   Version: unspecified
  Hardware: All
   URL: https://wiki.koha-community.org/wiki/Notices_Overhaul_
RFC
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hu...@brimbank.vic.gov.au
QA Contact: testo...@bugs.koha-community.org
  Deadline: 2018-11-01

Currently notices are run using effectively two separate systems. Overdue
notices run using their own cron job, whilst everything else is either queued
by the advance_notices cron or directly added to the message queue.
Additionally, print overdues are treated differently to other overdues. This
means the options available for print overdues considerably lag those available
for other notice types, and there are confusing discrepencies between overdues,
other notices, and print overdues and everything else.

Note that this enhancement is primarily aimed at modernising the way paper
(postal) notices are managed, but as part of that it moves overdues under the
same structure as other notices.

# Step 1 - Move Overdues into member messaging preferences
This should allow patrons (or staff on behalf of patrons) to:

  1. Select one or more notification methods (SMS, email etc)
  2. Choose not to be notified about Overdues at all
  3. Choose to receive a digest for overdues

# Step 2 - Enable 'postal' as a specific option rather than simply a
fallback,for all notice types

# Step 3 - option to process all print notices together

# Step 4 - extend  tags to other circulation notices

# Step 5 - Allow for 'digesting' of all notices in queue regardless of type

# Step 6 - Allow circulation notices to be created for any item status change

More detail is provided in the RFC - once we have community feedback the
details may change slightly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #14 from Hugh Rundle  ---
The functionality in the items tab is definitely not redundant.

However, it *is* pretty confusing that clicking on the barcode and clicking on
'edit item' take you to two completely different places.

It feels like 'click on barcode' is supposed to take the user to somewhere
useful for circ changes (e.g. changing a item statuses) and clicking on 'edit'
is more designed for cataloguing changes (e.g. updating a call number).
However, this isn't actually consistent: you can't change a Not-For-Loan status
in "Items", for example, which doesn't seem to be very logical.

So I don't have a big problem with removing the tab, as long as there is no
loss of *ease*, and the functional separation between "things circ staff might
need to update" and "things cataloguing staff might need to update" is still
there: i.e. forcing everyone to go into the cataloguing module to update an
item status would be bad, not least because it means all circ staff would need
access to cataloguing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

--- Comment #18 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #17)
> (In reply to David Cook from comment #16)
> > It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11
> > don't have an easy way of verifying TZ settings.
> 
> This one needs some work to be suitable for the old stable releases. You
> better talk to the release maintainers. If you need it.

In that case, I'd say reverting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 for 17.05 and
17.11 might be a better idea.

I ended up just copying admin/env_tz_test.pl from an older version of Koha and
ran that instead for the setup of the timezone and then deleted it again.

I imagine anyone who needs to check for 17.05 and 17.11 would just do the same
thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20961] New: cn_sort for DDC callnumbers should between 1 and 99 should be formatted as 001.* - 099.*

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20961

Bug ID: 20961
   Summary: cn_sort for DDC callnumbers should between 1 and 99
should be formatted as 001.* - 099.*
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The documentation for C4::ClassSortRoutine::GetClassSortKey says

* Concatenates class and item part.
* Converts to uppercase.
* Removes leading and trailing whitespace and '/'
* Separates alphabetic prefix from the rest of the call number
* Splits into tokens on whitespaces and periods.
* Leaves first digit group as is.
...

9.1 => 9_100
80.1 => 80_100
700.1 => 700_100

when sorted ascending by cn_sort are

700.1 => 700_100
80.1 =>  80_100
9.1 => 9_100

however, DDC classes are formatted

000 – Computer science, information & general works
100 – Philosophy and psychology
200 – Religion
300 – Social sciences
400 – Language
500 – Pure Science
600 – Technology
700 – Arts & recreation
800 – Literature
900 – History & geography

000 is sub-divided into the hundreds group

000 Computer science, knowledge & systems
010 Bibliographies
020 Library & information sciences
...

and sub-sub-divided into the thousands groups...

000 Computer science, information & general works
001 Knowledge
002 The book
003 Systems
...

As such, '* Leaves first digit group as is.', should read

* the first digit group should be 3 characters wide, 0-padded

I.e. the  value of cn_sort for callnumber 1.1 should be 001_100,

so that the examples above sort

009_100
080_100
700_100

See discussion here:
http://lists.koha-community.org/pipermail/koha-devel/2018-June/044623.html

And the summary of DDC 23 here:

https://www.oclc.org/content/dam/oclc/dewey/DDC%2023_Summaries.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

--- Comment #3 from Christopher Brannon  ---
I'm fine with waiting.  Added dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20813] Revamp user permissions system

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Christopher Brannon  changed:

   What|Removed |Added

 Blocks||20956


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
[Bug 20956] BorrowersLog is not logging permission changes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Christopher Brannon  changed:

   What|Removed |Added

 Depends on||20813


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813
[Bug 20813] Revamp user permissions system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #76107|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 76166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76166=edit
Bug 20867: Ability to show membership renewal date on moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
5. Apply the patch.
6. Reload the page now you will able to see the Membership renewal date.

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75824|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #7 from Katrin Fischer  ---
I think we had similar problems on patron search - anything we could pick from
there?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75882|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 76165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76165=edit
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter

To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
   perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where
biblio.biblionumber=38483  -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20896] Move Serial enumeration to the right of callnumber

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20889] Items marked as not for loan can be checked out

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
There still seems something off - if the user has a restriction and you use the
'temporary override' you can check out the item still. Even when
AllowNotForLoanOverride doesn't allow that. Separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Katrin Fischer  ---
It's a class in the  tag:



branch-CPL represents the branch of the currently logged in user. 

Maybe it would be cleaner to also add the borrowernumber there? Also the use of
custom attributes appears strange to me - why use class for the username but
then 2 attributes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20925] Changing font color for pipes between list items in #moresearch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---
Actually, you can already change the color with CSS. Here are the relevant
statements:

#moresearches li::after {
content: " | ";
color: red;
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20925] Changing font color for pipes between list items in #moresearch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Kyle, I don't understand this one, can you please explain?
Why not use CSS if this is just about changing color on something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20925] Changing font color for pipes between list items in #moresearch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

--- Comment #1 from Katrin Fischer  ---
*** Bug 20926 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20926] Changing font color for pipes between list items in #moresearch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20926

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 20925 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #2 from Katrin Fischer  ---
Ah, I think the JavaScript for navbar needs to be moved to the bottom.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I can confirm the error, but haven't been able to locate the mistake in the
code yet. Only thing I notice is some errors from the validator - 2 stay 
tags.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20945] Report params not escaped when downloading

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I've been testing with the following SQL:

select * from borrowers where firstname like <> and surname like
<>

Asort1 has a % in my test. But I can download fine in all formats and the URL
looks like this:

cgi-bin/koha/reports/guided_reports.pl?reports=2=Run+this+report_name=TEST|Asort1_params=%25_name=surname_params=%25

Can you explain more about the problem? What am I missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #2 from Katrin Fischer  ---
I can't reproduce the problem. I have tried discharging from the patron account
as well as discharging using the link from the dashboard and the 'allow'
button.

Similar to bug 20851?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20924] News content textarea not showing

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |normal

--- Comment #6 from Jonathan Druart  
---
Lowering severity, waiting for Aleisha's answer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Owen, I think doc-head-open is missing from patroncards/print.tt, could you
confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75832|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 76164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76164=edit
Bug 20641: Switch single-column templates to Bootstrap grid: Various, part 2

This patch updates various unrelated templates to use the Bootstrap
grid. In each case, confirm that the indicated page looks correct.

 - Acquisitions -> Vendor -> Add to basket -> From a staged file.
 - Logged-in user menu (in the upper right) -> Search history.
 - With plugins disabled in koha-conf.xml, go to Tools -> Tools plugins.
 - With the EasyAnalyticalRecords system preference set to 'Display,'
   view a bibliographic record.
   - Choose Edit -> Link to host item.
   - Submit a barcode to be linked.
 - Configure a MARC subfield (e.g. 100$a) to use the
   unimarc_field_225a_bis plugin.
   From the MARC edit page, trigger the plugin and confirm that the
   page in the popup window looks correct. Confirm that changes made in
   the popup window are saved to the corresponding field in the editor.
 - Administration -> Funds -> Edit a fund.
   - Click 'Select owner.'
   - Search for a patron.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75253|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 76163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76163=edit
Bug 19709: Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

This patch also modifies the templates to use the Bootstrap grid instead
of YUI, and removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 20460] Staff can only change password through the change password button if patron hits failedloginattempts

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460

--- Comment #1 from Agnes Rivers-Moore  ---
I agree, staff need both the information that it's locked, and also need a
reminder to use the Change Password button - at least until that is fixed.
Why does edit - change password not work? Is this intended behaviour?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #21 from Jonathan Druart  
---
Do whatever you want, but my opinion would be to not remove code that could be
fixed easily. To fix the original issue, it's a 3-lines patch ( Bug 16111: Fix
content type for RSS feed ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Jonathan Druart  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #20 from Jonathan Druart  
---
Created attachment 76162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76162=edit
Bug 16111: Remove 'rss2' which should be 'rss' or 'atom'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49837|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 76160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76160=edit
Bug 16111: Fix content type for RSS feed

Test plan:
GET
http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw=perl=50_by=acqdate_dsc=rss2

=> Without this patch it returns content type text/html
=> With this patch it returns text/xml

GET
http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw=perl=50_by=acqdate_dsc=rss
=> Without this patch it does not work
=> With this patch it returns text/xml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #19 from Jonathan Druart  
---
Created attachment 76161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76161=edit
Bug 16111: Fix atom support

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20813
   Severity|major   |enhancement
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I agree with both Christopher and Jonathan. We never logged permissions and
this has never come up before, so I would also classify this as an enhancement.
But at the same time I think it would be a very good and valuable addition.
Currently there is some work done on permissions, we might want to wait for bug
20813 before implementing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20813] Revamp user permissions system

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20956

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20960] System preference 'automatic_item_modification_by_age_configuration' does not appear in staff client.

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Should explain that a little more, the configuration is set in its own tool and
then added to the systempreferences table for storage. Once you have set the
first rule, it will appear on the 'local use' tab. This is a trick similar to
the one used by the 'did you see' feature. It's intentional it's not showing up
in search as you are not supposed to edit the rules by hand.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20960] System preference 'automatic_item_modification_by_age_configuration' does not appear in staff client.

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
It's a tool, not a system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #17 from Jonathan Druart  
---
I am sorry but we are doing something very wrong here.
The POC patch shows that it is very easy to support atom, whereas the "Revised"
patch is removing all this code.

I would suggest to:
1. Fix the content type for rss
2. Fix the rss2 vs rss and keep support for rss2
3. Add the support for atom

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75257|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 76159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76159=edit
Bug 20220: Move template JavaScript to the footer: Holds

This patch modifies the holds template so that JavaScript is included in
the footer.

To test, apply the patch and initiate the process of placing a hold.
Throughout the process JavaScript-based interactions should work: Patron
autocomplete, datepickers, DataTables, cancel confirmations, etc.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7867] Use consistent terminology for username and password

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
Summary|Staff and OPAC areas lack   |Use consistent terminology
   |consistency |for username and password

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #78 from Jonathan Druart  
---
Created attachment 76156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76156=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #80 from Jonathan Druart  
---
Created attachment 76158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76158=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #79 from Jonathan Druart  
---
Created attachment 76157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76157=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #77 from Jonathan Druart  
---
Created attachment 76155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76155=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #75 from Jonathan Druart  
---
Created attachment 76153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76153=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #76 from Jonathan Druart  
---
Created attachment 76154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76154=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

--- Comment #8 from Owen Leonard  ---
Created attachment 76150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76150=edit
Bug-18236: Add classes to material type

Test plan:
-Following the test plan above, the class should still have
'materialtype' but also the new class:
Books = mt_icon_BK
Kit = mt_icon_MX
Article = mt_icon_AR
Mixed material = mt_icon_MX
Computer files = mt_icon_CF
Map = mt_icon_MP
Music = mt_icon_MU
Sound = mt_icon_MU
Score = mt_icon_PR
Visual material = mt_icon_VM

-When viewing the details of a record, the material type img should also have
the
same changes
-Check that the material type classes in the results page is the same as
the details page

Notes
-The class names have changed from the previous patch in accordance to
$materialTypeCode in MARC21slim2intranetDetail.xsl

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #74 from Jonathan Druart  
---
Created attachment 76152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76152=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75370|0   |1
is obsolete||
  Attachment #75371|0   |1
is obsolete||
  Attachment #75372|0   |1
is obsolete||
  Attachment #75373|0   |1
is obsolete||
  Attachment #75374|0   |1
is obsolete||
  Attachment #75375|0   |1
is obsolete||
  Attachment #75376|0   |1
is obsolete||
  Attachment #75377|0   |1
is obsolete||

--- Comment #73 from Jonathan Druart  
---
Created attachment 76151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76151=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jway...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70571|0   |1
is obsolete||
  Attachment #70653|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 76149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76149=edit
Bug-18236: Add classes to material type

Test plan:
1. Open a list of results
2. Use fn+f12 to inspect element
3. Without patch it should show that the image class is 'materialtype'
4. With patch the class should have changed
-Books = mt_icon_book
-Kit = mt_icon_kit
-Continuous resource = mt_icon_cresource
-Mixed material = mixmaterial
-Computer files = mt_icon_computer
-Map = mt_icon_map
-Score = mt_icon_score
-Music = mt_icon_music
OR
1. Try using the classes in css to change the style

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #72 from Jonathan Druart  
---
(In reply to Caroline Cyr La Rose from comment #71)
> I had a bit of trouble applying the patch. I had to add member-flags.tt and
> then continue applying the patch. I don't know if that's normal or not.

Yes, conflict. I am going to re-attached a rebased version of these patches.

> I went to Global system preferences and clicked on the tab for circulation.
> When I clicked help, the manual was at the beginning of the sysprefs
> section. I don't know if it's possible at all to point to the right
> sub-section? It's just that are so many system preferences...

It should be the same behaviour as prior to the patch. We can imagine a link
close to each pref to point to the dedicated section of the manual.
TODO later ;)

> My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
> language in the list, but if I don't change it will this be the default?
> Should we put English by default instead of Arabic?

I guess you did not execute the updatedatabase.pl script. The default value is
"en".

> I also don't see the edit button mentioned in comment 7. Was that
> implemented or just an idea for a future development? It could be a second
> patch. People don't currently have the ability to modify from the staff
> interface, so it wouldn't necessarily be a step back. More advanced users
> can still use their own help files.

The original plan was to provide a full help system, local editing (on top of
git repository), etc.
I have asked several time on the mailing lists and during IRC meetings to get
feedbacks and ideas. I did not get answers and I am no longer willing to
provide such enhancements. Maybe later...

> I wasn't able to test switching languages because my master is only
> installed in English.

You can install a couple with:
  sudo koha-translate --install fr-CA --dev kohadev
  sudo koha-translate --install it-IT --dev kohadev

> It's a great development! It will be much easier to translate, no need to
> translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20933] Modifying the Advanced Prediction Pattern in Serials

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20933

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70571|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #236 from Jonathan Druart  
---
Is there a plan to avoid never-ending rebases?


(In reply to Alex Arnaud from comment #194)
> > Comment 164 - How can we open issue on 
> > http://git.biblibre.com/biblibre/koha-mana
> We plan to move Mana server sources on Koha community repository
> 
> > Comment 164 - I'd like a more complete README to run the server and the 
> > tests.
> http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be
> completed

What about these two points?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15315] Non-XSLT detail view still uses Greybox for MARC preview

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
Bug 8290 depends on bug 15315, which changed state.

Bug 15315 Summary: Non-XSLT detail view still uses Greybox for MARC preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49629|0   |1
is obsolete||

--- Comment #16 from Owen Leonard  ---
Created attachment 76148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76148=edit
Bug 16111 [Revised] RSS feed for OPAC search results has wrong content type

This patch fixing handling of OPAC search results feeds by correcting
parameters passed to the script and making format checks consistent in
the script.

This patch also removes altogether references to a separate "atom"
formatted feed, because the template for that feed displays no content
(and never has).

To test, apply the patch and perform a search in the OPAC.

- Click the RSS link and confirm that the browser displays a feed with
  no errors. In Chrome the feed should display a "document tree" view.
- Using the browser's developer console, verify that the content-type of
  the document is defined as "text/xml."
- Validate the resulting feed at https://validator.w3.org/feed/ and
  confirm that it is valid.

Revision adds suggestion from QA to accept the old 'rss2' parameter and
treat it like an 'rss' parameter. Also changed: Corrected another place
where 'rss2' was used in the template.

Signed-off-by: Magnus Enger 
Before the patch:
- RSS is served with content-type text/html
- The link from the RSS icon ona search page looks like
  opac-search.pl?idx=kw=perl=50_by=acqdate_dsc=rss2

After applying the patch:
- RSS is served as text/xml
- The RSS link leads to
  opac-search.pl?idx=kw=perl=50_by=acqdate_dsc=rss
  But the old link with format=rss2 still works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #76111|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 76147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76147=edit
Bug 20259: Shorter JS and CSS rewrite rule

Bug 20187 has changed the JS and CSS rewrite rules to :
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css
[L]

This patch changes this rules using [0-9]{N} and fusion in one rule.
And espaces the dot in extension js and css.

Test plan :
1) Go to intranet and opac
2) Check CSS and JS are doing well
3) Apply patch changes on our Apache configuration
4) Reload intranet and opac pages (Ctrl + F5)
5) Check CSS and JS are doing well

Signed-off-by: Charles Farmer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17869] Don't show pick-up library for list of holds in OPAC account when there is only one branch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17869] Don't show pick-up library for list of holds in OPAC account when there is only one branch

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

--- Comment #8 from Owen Leonard  ---
Created attachment 76146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76146=edit
Bug 17869: Don't show pick-up library for list of holds in OPAC account when
there is only one branch

This patch modifies the user summary page in the OPAC so that the
"pick up location" column isn't shown in the table of holds if there is
only one library defined.

To test, apply the patch and log into the OPAC as a user with one or
more holds.

 - In a system with more than one library defined the "Holds" tab of
   opac-user.pl should show a "Pick up location" column.

 - In a system with only one library defined there should be now "Pick
   up location" column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the same time

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Interesting. Has that changed in recent versions? We have a library using
Shibboleth and LDAP with 16.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20960] New: System preference 'automatic_item_modification_by_age_configuration' does not appear in staff client.

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

Bug ID: 20960
   Summary: System preference
'automatic_item_modification_by_age_configuration'
does not appear in staff client.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The system preference 'automatic_item_modification_by_age_configuration', used
in  misc/cronjobs/automatic_item_modification_by_age.pl, does not show in a
system preference search.

I think this is because it's missing from 

./koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/*.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20948] Hold requests on detail.pl

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

--- Comment #3 from Christopher Brannon  ---
I realize that it may be impossible to display next available holds, but if
there are next available holds and local hold priorities, I fail to see how
showing the next item level hold helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20948] Hold requests on detail.pl

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

--- Comment #2 from Christopher Brannon  ---
Created attachment 76145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76145=edit
Misleading Hold Info

Screenshot of misleading hold.  Shows the only item-level hold in the 35
current holds.  This is not who the item will be going to when checked in. 
Would prefer to not show this information if it is meaningless to us.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #261 from Martin Renvoize  ---
Created attachment 76144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76144=edit
Bug 11897: (follow-up) Default to 'replyto' and fallback on 'from'

In recent koha's, branchemail isn't necessarily an email address the
branch has access to. Reply-to however should always be accessible and
as such this patch uses that in preference to 'From'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #6 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #1)
> 
> This is not perfect but I think the best way to provide an easy to
> backport patch.
> 
> It highlights that we need improvements in this area.

Maybe not perfect, but fixing the bug ;) Hope some thing will be fixed during
merging issues and oldissues in future...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #4 from Josef Moravec  ---
Created attachment 76142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76142=edit
Bug 20934: (QA follow-up) Fix pod in Koha::Old::Checkout

Test plan:
Run qa tools - it shouldn't complain about pod levels

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #5 from Josef Moravec  ---
Created attachment 76143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76143=edit
Bug 20934: (QA follow-up) Fix showing number of records in checkout history

Test plan:
0) Do not apply this patch
1) Go to biblio checkout history page (issuehistory.pl)
2) You'll see something like "Checked out ARRAY(0xf830378) times"
3) Apply this patch
4) Now you should see number of checkout history records

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec  changed:

   What|Removed |Added

  Attachment #76104|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 76141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76141=edit
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard 
The patch works as expected.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Koha Team Lyon 3  ---
Hello,
Tested on a sandbobx (biblibre sandbox n°1)
At step n°11, there's an error when clicking on "allow" :

Software error:
Undefined subroutine ::Patron::Debarments::AddDebarment called at
/home/koha/src/Koha/Patron/Discharge.pm line 85.
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698

--- Comment #1 from Owen Leonard  ---
Created attachment 76140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76140=edit
Bug 20698 - Remove obsolete template: transfer-slip.tt

This patch removes an unused template file, circ/transfer-slip.tt. Its
use was removed by Bug 7001:

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12

To test, apply the patch and confirm that the file has been removed.
Confirm that no references to the template exist in the codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #2 from Owen Leonard  ---
Created attachment 76139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76139=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel

This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.

Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.

To test, apply the patch and clear your browser cache if necessary.

 - View the checkin page. The "checkin settings" panel should be
   collapsed by default.
 - Confirm that the settings panel collapses and expands as it should.
 - Confirm that selecting "Forgive overdue charges" or "Book drop mode"
   trigger the display of the correct message and that the style of the
   barcode field is changed.
 - Confirm that after submitting a barcode for check-in, the
   settings panel stays open and your selected settings are still
   selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20948] Hold requests on detail.pl

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Does it concern 17.05 only?

I do not understand what you are referring to on master, can you provide
screenshots?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20928] Checkout status not showing patron

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec  changed:

   What|Removed |Added

  Attachment #76105|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 76138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76138=edit
Bug 20928: Fix regression - display patron's info on moredetail if item is
checked out

This patch is a follow-up of
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used

Test plan:
- Check an item out
- Go on the moredetail.pl page of this biblio record
Home › Catalog › Item details for your biblio
- Confirm that you see:
"Checkout status: Checked out to"
followed by the patron's info

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20928] Checkout status not showing patron

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20928] Checkout status not showing patron

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

--- Comment #3 from Jonathan Druart  
---
Could you confirm the FK is missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|17.05   |master

--- Comment #1 from Jonathan Druart  
---
It sounds more like an enhancement request.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20924] News content textarea not showing

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #5 from Josef Moravec  ---
I can't reproduce it too.

According to tiny mce documentation the "textareas" is the right setting for
mode:
https://www.tinymce.com/docs-3x/reference/configuration/Configuration3x@mode/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #1 from Owen Leonard  ---
Created attachment 76137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76137=edit
Screenshot showing active book drop mode setting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] New: Style checkin form more like the checkout form, with collapsed settings panel

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Bug ID: 20959
   Summary: Style checkin form more like the checkout form, with
collapsed settings panel
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 76136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76136=edit
Screenshot of the revised checkin form

I think it would be nice to make the checkin page look more like the checkout
page, with a collapsed panel where settings like book drop mode can be hidden
when not in use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |tomasco...@gmail.com
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #260 from Martin Renvoize  ---
Fully rebased and taken account of a few pieces of customer feedback in the
followups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #69 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #68)
> Is this only for GRS-1?
> 
> Bug 14302 - Remove GRS1 indexing related code

Nope it has started for GRS-1 but its now for DOM only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #259 from Martin Renvoize  ---
Created attachment 76135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76135=edit
Bug 11897: (follow-up) Ensure rota's always come back ordered

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >