[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Pierre-Luc Lapointe changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-luc.lapointe@inLibro ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77019|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 77176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77176=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77164|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 77175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77175=edit Bug 21099: Reposition floating toolbars earlier To recreate: - Go to the advanced search form - scrolldown to position the toolbar on top of the window - scrollup https://screenshots.firefox.com/NnkFg3iOXqLPxfkd/pro.kohadev.org The toolbar should have been repositioned earlier Test plan: Edit a patron - scrolldown - scrollup - unfold the form in the header (tab "Search patrons", link "[+]") - scrolldown - scrollup Advanced search scrolldown scrollup You should notice the difference with and without this patch Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Pierre-Luc Lapointe changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-luc.lapointe@inLibro ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #22 from Jonathan Druart --- Applying: Bug 20968: (follow-up) Replace tabs with spaces error: sha1 information is lacking or useless (catalogue/detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20968: (follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart changed: What|Removed |Added Attachment #76308|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 77174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77174=edit Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633 --- Comment #10 from Jonathan Druart --- Created attachment 77173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77173=edit Bug 19633: (QA follow-up) Really remove these ugly numbers See BZ comment5. We now remove the numbers also from the constant names. Test plan: Read the changes. Git grep "ERRCODE_" Run t/db_dependent/Upload.t (Note: You may see one failure here; it is fixed on bug 20727. So depends on who reaches master first.) Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633 Jonathan Druart changed: What|Removed |Added Attachment #74722|0 |1 is obsolete|| Attachment #75856|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 77172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77172=edit Bug 19633: Use alphanumeric error codes in upload The error codes 1 to 7 are used in Uploader.pm or tools/upload.pl. It would be nice to use alphanumeric codes instead. No behavior change expected. Test plan: [1] Run t/db_dependent/Upload.t [2] Verify that a regular upload with tools/upload.pl still works. [3] Rename upload_path in your koha-conf.xml. Restart Plack, flush the cache and try to upload to a category. Correct error message? [4] Upload the same file twice to the same category. Correct error message the second time? Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #25 from Jonathan Druart --- Created attachment 77169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77169=edit Bug 20468: (follow-up) Changes to checkbox/menu interactions This patch makes a couple of minor interface changes and updates the way checkbox change events are handled: - jQueryUI tabs initialization sets a variable for "active table" which can be re-used by functions which affect only the visible table. - The batch "Actions" menu is shown or hidden based on whether there are checked items. - The item selection tools are shown or hidden based on whether there are rows in the table. To test, apply the patch and test various article request actions: - Single "process," "complete," and "cancel" operations. - Select all/ clear all operations on both tabs. - Batch operations with checked requests. - Process all pending requests to confirm the selection controls for that table are hidden. - Complete all processing requests to confirm the selection controls for that table are hidden. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #27 from Jonathan Druart --- Created attachment 77171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77171=edit Bug 20468: (QA follow-up) Deactivate select/clear all for empty tab This only pertains to the second (Processing) tab. Test plan: [1] Have one entry in Pending and zero in Processing. [2] Click on Processing tab. [3] Without this patch, you would see Select all/Clear all. With this patch, you won't. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Jonathan Druart changed: What|Removed |Added Attachment #74711|0 |1 is obsolete|| Attachment #75749|0 |1 is obsolete|| Attachment #75864|0 |1 is obsolete|| Attachment #76626|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 77168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77168=edit Bug 20468: Add multi-select to staff article request form Adds a column with a checkbox. Adds buttons under the table for Select, Clear and Actions menu. An additional javascript function HandleMulti is placed between the form and the functions handling individual requests. Note: The Actions menu below does not contain Print slip. This does not work in its current form. This could be handled on a separate report. Test plan: [1] Enable Article Requests. Add a few requests. [2] Test the Select all / Clear all functionality on the form. [3] Verify that the menu options Process, Complete and Cancel work as expected both from the individual Actions menu as from the shared Actions menu for selected requests. Signed-off-by: Marcel de Rooy Patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #26 from Jonathan Druart --- Created attachment 77170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77170=edit Bug 20468: (follow-up) Cancel multiple items for same reason The repeated prompts for cancelling multiple selected items are confusing. The wording is slightly adjusted. The reason is asked only once per group of selected items. Test plan: Create three requests. Select two requests and cancel (from top menu) for reason A. Cancel third request (from item menu) for reason B. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart changed: What|Removed |Added Attachment #76754|0 |1 is obsolete|| Attachment #76755|0 |1 is obsolete|| Attachment #77163|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 77165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77165=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a , with the preference name as the and the description as the . - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #22 from Jonathan Druart --- Created attachment 77166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77166=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #23 from Jonathan Druart --- Created attachment 77167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77167=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > When there is a match: > https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org > > When there is no match: > https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org > > The "Acquisitions preferences" h2 is display under the toolbar (I have > selected the text to show it on the screenshot. I have no idea how to fix that. I have also noticed that fixFloat duplicate the toolbar node (one is hidden), and so we should not have an id on them. Passing QA as it is a minor ergonomic issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 --- Comment #1 from Jonathan Druart --- Created attachment 77164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77164=edit Bug 21099: Reposition floating toolbars earlier To recreate: - Go to the advanced search form - scrolldown to position the toolbar on top of the window - scrollup https://screenshots.firefox.com/NnkFg3iOXqLPxfkd/pro.kohadev.org The toolbar should have been repositioned earlier Test plan: Edit a patron - scrolldown - scrollup - unfold the form in the header (tab "Search patrons", link "[+]") - scrolldown - scrollup Advanced search scrolldown scrollup You should notice the difference with and without this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20935 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21099 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #19 from Jonathan Druart --- Found and fix an ergonomic bug with the toolbar on bug 21099. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] New: Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Bug ID: 21099 Summary: Floating toolbars reposition too late Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org To recreate: - Go to the advanced search form - scrolldown to position the toolbar on top of the window - scrollup https://screenshots.firefox.com/NnkFg3iOXqLPxfkd/pro.kohadev.org The toolbar should have been repositioned earlier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #12 from M. Tompsett --- (In reply to M. Tompsett from comment #9) > If this regexp is wrong, there are several other places it is wrong too. See > C4/Barcodes/hbyymmincr.pm db_max for example. You can't just fix this place then. Fix them all. And include a full test plan. I'll look at it if all places are fixed, and I remember to get back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #11 from Blou --- I'm biased and in full agreement with Katryn here. The code does exist and is in use. And there is certainly no good way to deprecate it. So why not just fix it. It's a few adjustments in the code, one patch to push, some or many users happy. There are many valid reasons to refuse an enhancement, and some good reasons to refuse a fix (ugly, could break other things, badly engineered...). But I don't think deprecation is valid, unless there's a plan behind it. What is the suggested PRACTICAL alternative for the user at this point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #18 from Jonathan Druart --- Created attachment 77163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77163=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #17 from Jonathan Druart --- When there is a match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org When there is no match: https://screenshots.firefox.com/iaqfOGIV1yWAylQg/pro.kohadev.org The "Acquisitions preferences" h2 is display under the toolbar (I have selected the text to show it on the screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #220 from Martin Renvoize --- Looks to be going along the right lines to me, I like the approach and can see it leading to a much better base to start with. Maintaining it going forward is the next challenge.. hopefully some carefully placed git hooks could help there, or adding some logic to the qa script to try and catch them? I've also often wondered about having a community arachni server (or some other automated penetration testing system) setup and hitting a clone of master regularly... think I've brought that idea up before but didn't have the time to pursue it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 --- Comment #6 from Martin Renvoize --- Grr.. I ran the qa script but entirely missed the bad commit message line :(.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added Attachment #77157|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 --- Comment #5 from Martin Renvoize --- Created attachment 77162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77162=edit Bug 21097: Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #110 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Members.t CONFLICT (content): Merge conflict in members/update-child.pl CONFLICT (content): Merge conflict in members/memberentry.pl CONFLICT (content): Merge conflict in Koha/Item.pm CONFLICT (content): Merge conflict in C4/Members.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to create a new basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Please read https://wiki.koha-community.org/wiki/Commit_messages#Examples Then use the QA script to catch such errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #30 from Matthias Meusburger --- Yes, sorry about that. Thank you for the rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Nice enhancement, rebased master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19909] Show attributes in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Fridolin SOMERS changed: What|Removed |Added Attachment #70243|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 77161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77161=edit Bug 19909: Show attributes in patron search results Add a new column (hidden by default) in the results table which displays all attributes associated to the corresponding patron. New subroutine Koha::Patron::Attribute::display_value that returns the authorised value description and defaults to the raw value if the attribute's type is not associated to an authorised value category Test plan: 1. Create some patron attribute types, with and without an associated authorised value category 2. Choose an existing patron and set a value for each attribute 3. Go to patron search and do a search that will return your patron (and some others to avoid the redirection) 4. Show column 'Extended attributes' by clicking on 'Column visibility' button 5. Note that all attributes are displayed correctly 6. prove t/db_dependent/Koha/Patron/Attributes.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #29 from Marcel de Rooy --- (In reply to Nick Clemens from comment #24) > Changes from 15360 cause conflicts, can you rebase/add a follow up? Actually quite trivial rebase ;) Appears that Matthias missed your request? Verified that I still get results from LOC SRU auth server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Marcel de Rooy changed: What|Removed |Added Attachment #73134|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 77158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77158=edit Bug 19436: Add SRU support for authorities Test plan: - Apply the patch - Add an SRU authority server in admininistration -> Z39.50/SRU servers You can try with the French national library, configured as such: Hostname: catalogue.bnf.fr Port: 80 Database: api/SRU Syntax: Unimarc Record type: authority Additional SRU options: version=1.2,sru=get SRU Search fields mapping example: Keyword (any): aut.anywhere Name (any): aut.anywhere Author (any): (aut.type any "pep org") and aut.accesspoint Author (personal): aut.type=pep and aut.accesspoint Author (corporate): aut.type=org and aut.accesspoint Author (meeting/conference): aut.type=org and aut.accesspoint Subject heading: (aut.type any "geo ram_nc ram_ge ram_pe ram_co") and aut.accesspoint Subject sub-division: aut.type=ram_pe and aut.accesspoint Title (any): (aut.type any "tic tut tum ram_tp ram_tu") and aut.accesspoint Title (uniform):(aut.type any "tut tum ram_tu") and aut.accesspoint - Try a search from Authorities -> New from Z39.50/SRU - Check that the authority is correctly displayed in "Show Marc" - Check that the authority is correclty added to koha in "Import" - prove t/db_dependent/Breeding.t Signed-off-by: François Pichenot Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Marcel de Rooy changed: What|Removed |Added Attachment #73135|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 77159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77159=edit Bug 19436: (QA follow-up) Revert change in _handle_one_result See Bugzilla comment 7. This change does not belong here and is dubious on its own. Needs further attention on another report. Signed-off-by: Marcel de Rooy Amended: In consultation with the author the same change is applied to the corresponding lines in Z3950SearchAuth. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Marcel de Rooy changed: What|Removed |Added Attachment #73136|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 77160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77160=edit Bug 19436: (QA follow-up; see 19608) Fix use of intranet-bottom in template Bug 19608 incorrectly replaced intranet-bottom by popup-bottom. Adjusting the new template in the same way. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Going straight to Passed QA as it's such a trivial patch and it tests as it should :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Martin Renvoize changed: What|Removed |Added Attachment #77152|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 77157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77157=edit Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Passed QA Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #35 from Marcel de Rooy --- Adding back Jonathan as assignee :) He wrote the original fix. Note that this bug survived quite some releases (3.12 - 18.05) With the two follow-ups we fix a bad call and improve the use of -update. Further improvements are welcome on new reports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #33 from Marcel de Rooy --- Created attachment 77155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77155=edit Bug 20811: (QA follow-up) Make the isbn check work The following code was never reached, since $isbn was not filled. if (!$biblionumber && $isbn_check && $isbn) { $sth_isbn->execute($isbn); ($biblionumber,$biblioitemnumber) = $sth_isbn->fetchrow; } Solution: Fix the code with two $isbn declarations. Move the checkisbn condition a level deeper. Test plan: Run misc/migration_tools/bulkmarcimport.pl -file bib726.utf8 --update -isbn Since you do not match on biblionumber, the ISBN should match. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #34 from Marcel de Rooy --- Created attachment 77156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77156=edit Bug 20811: (QA follow-up) Prevent calling AddItemBatchFromMarc and ModBiblioMarc without biblionumber If you use -update but do not find matches (or did not want to match), you should not call those routines. We should warn and skip this record. Adding a warn at the start that the choice of options may not be smart. Note that this needs further attention somewhere else. You could mix -update with -insert for instance and still see some problems. (May depend on items with unique barcode etc.) Test plan: Run -update without match or isbn. Or run -update -isbn with a non-matching ISBN. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Marcel de Rooy changed: What|Removed |Added Attachment #76969|0 |1 is obsolete|| --- Comment #32 from Marcel de Rooy --- Created attachment 77154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77154=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5635] bulkmarcimport new parameters & features
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #31 from Marcel de Rooy --- Added a bad ModBiblio call. Look at see also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #31 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #28) > It's only the update opption that I can't get to work. I've documented my > testing in comment#4. I've done quite somte tests with bulkmarkimport lately > and it worked just fine otherwise. Since [cefa7c21e28b88351ee8ae0dfefb80a515323df9] Bug 5635: bulkmarcimport new parameters & features (version 3.11.00.109) the code contains the wrong ModBiblio call. If I use the -update parameter now with the -match parameter (e.g. pass "Control-number,001"), the fix works fine. But that is not the complete story. If you use the -update option without the -match parameter, you won't reach the ModBiblio call, but you will get errors from AddItemBatchFromMarc (called without bibionumber) and from ModBiblioMarc. If you use the -update option with -isbn, there will be no match on isbn due to a bug with the $isbn variable. Will add two simple follow-ups to overcome both situations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21097 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21098 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #1 from David Cook --- Created attachment 77153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77153=edit Bug 21098 - Add missing budget optgroups to parcels.tt and newemptyorder.tt I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt and parcels.tt do not. That is to say, when placing an order there is no organisation of funds in the drop-down menu, but there is when you recive an order, but not when you receive a shipment (ie choose a Shipping fund). This patch seeks to harmonize the user experience, so that users are always seeing funds organised by budget. _TEST PLAN_ 1. Add two budgets 2. Add one fund to each budget 3. Add a vendor 4. Add a basket 5. Add an order 5b. Note that you can now see funds grouped by budget 6. Close the basket 7. Receive the shipment 7b. Note that you can now see funds groups by budget 8. Receive the order 8b. Note that the organisation of funds is the same as the other two areas (even though the patch doesn't touch this one). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 --- Comment #1 from David Cook --- Created attachment 77152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77152=edit Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] New: Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Bug ID: 21098 Summary: Add missing budget optgroups to parcels.tt and newemptyorder.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org orderreceive.tt uses optgroup tags to organise funds into budgets, but this same functionality is missing on parcels.tt and newemptyorder.tt. If you have funds in different budgets with the same or similar descriptions, it becomes impossible to differentiate funds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21097] New: Missing optgroup closing tag in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21097 Bug ID: 21097 Summary: Missing optgroup closing tag in orderreceive.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org There's a missing optgroup closing tag in orderreceive.tt. Modern browsers tend to tidy HTML so it probably goes unnoticed, but it's a good idea to fix up our markup I reckon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Katrin Fischer changed: What|Removed |Added Summary|code to select patrons to |Code to select patrons to |purge needs to be |purge needs to be |centralized |centralized -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #24 from Katrin Fischer --- Aleisha, did you see my comment about not being able to edit the note because it pulls the pop-over note into the input field? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #30 from Marcel de Rooy --- QA: Looking here again now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Going straight to Passed QA, works as described.. sorry Nick, muppet moment on my part there ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Martin Renvoize changed: What|Removed |Added Attachment #77146|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 77151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77151=edit Bug 21095: Add ccode facets info to tests To test: 1 - prove -v t/db_dependent/Search.t 2 - Koha asks "Why am I getting these crazy facets!?!" 3 - Apply patch 4 - prove -v t/db_dependent/Search.t 5 - Koha purrs (tests pass) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #34 from Marcel de Rooy --- Chris: You fixed the problem without clearing $image_data too. Further testing and looking at the code now helped me reach that conclusion. Sorry for the misunderstanding raised. What remains, is what was the exact cause if it was not $image_data? Might be a problem in Graphics::Magick or in draw_image or still somewhere else?? My time is limited too.. Passing QA, no follow-ups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Attachment #76779|0 |1 is obsolete|| --- Comment #33 from Marcel de Rooy --- Created attachment 77150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77150=edit Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image This patch corrects referential problems which caused the script to "re-use" images as well as other sorts of bad image behaviour. To test: 1. Ensure that you can reproduce the original bug or some variation thereof using the steps described in either of these two comments: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c6 NOTE: This is not an easy bug to reproduce. 2. Once you can reproduce the bug, apply this patch and follow the same steps used to reproduce the bug. 3. Observe that the symptoms are corrected. Signed-off-by: Chris Nighswonger Signed-off-by: Christian Stelzenmüller Signed-off-by: Marcel de Rooy Reproduced the bug and resolved it with this patch. Code is hard to read; exact cause of the problem was not fully uncovered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/