[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 --- Comment #1 from Liz Rea --- Created attachment 77277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77277=edit Bug 21122: check-url-quick dies on utf8 characters in URL's To test: Make a record with a URL that has a UTF8 character, such as: http://some.nonexistent.tld/MāoriWomenAotearoa.pdf Run the check-url-quick.pl job, notice it dies at that URL Apply this patch Test again, it should work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Liz Rea changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] New: Check-url-quick.pl crashes on utf8 characters in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Bug ID: 21122 Summary: Check-url-quick.pl crashes on utf8 characters in urls Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Example URL: http://some.nonexistent.tld/MāoriWomenAotearoa.pdf Job dies with "Wide character in print" Solution seems to be to encode the URL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21121] New syspref to allow hiding of private patron data in circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21121] New syspref to allow hiding of private patron data in circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21121] New syspref to allow hiding of private patron data in circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 --- Comment #1 from Alex Buckley --- Created attachment 77276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77276=edit Bug 21121 - Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #10 from David Cook --- (In reply to emjhet from comment #9) > (In reply to David Gustafsson from comment #7) > > Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm > > quite new to Koha and marc, so I might be completely wrong, but I don't > > understand why the handling of 001 and 035a should be handled differently > > between the two. When importing a bibliographic record into Koha I would > > expect 001 to be replaced with the Koha local id, and the previous 001 moved > > to 035a. > > I know this thread was originally about authorities, but it went nowhere. > And regardless of the type of record, we really do need a way to move the > 001 to the 035, as mentioned in other bugs. Please do not disregard this > problem. Can this be made into a Cronjob or something? A cronjob wouldn't make sense for this. It'll need to be a mechanism added to import functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21121] New: New syspref to allow hiding of private patron data in circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Bug ID: 21121 Summary: New syspref to allow hiding of private patron data in circulation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Implementing a new system preference to allow libraries to choose if they want personal patron information such as phone number, email, address and city from being displayed in the circulation page for privacy reasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 emj...@pa.net changed: What|Removed |Added CC||emj...@pa.net --- Comment #19 from emj...@pa.net --- Did anything ever come of this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 emj...@pa.net changed: What|Removed |Added CC||emj...@pa.net --- Comment #9 from emj...@pa.net --- (In reply to David Gustafsson from comment #7) > Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm > quite new to Koha and marc, so I might be completely wrong, but I don't > understand why the handling of 001 and 035a should be handled differently > between the two. When importing a bibliographic record into Koha I would > expect 001 to be replaced with the Koha local id, and the previous 001 moved > to 035a. I know this thread was originally about authorities, but it went nowhere. And regardless of the type of record, we really do need a way to move the 001 to the 035, as mentioned in other bugs. Please do not disregard this problem. Can this be made into a Cronjob or something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #77147|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 77275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77275=edit Bug 12365: (follow-up) Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'View note' and the popover correctly displays note. View the note by hovering over the link I've moved the Note column so the popover displays nicely and doesn't cover the buttons. I've also changed the placement so that it doesn't cover information in the row. Update: Test that you can edit the note when clicking 'Edit' and that behaviour is the same for editing all other fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #8 from Liz Rea --- We fixed this by applying the RewriteRule patch from bug 20259. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21120] New: item-level types and advanced searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21120
Bug ID: 21120
Summary: item-level types and advanced searches
Change sponsored?: ---
Product: Koha
Version: 17.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs@lists.koha-community.org
Reporter: emj...@pa.net
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In Koha -- Administration -- System Preferences -- Cataloging -- Item Record --
under "item-level-itypes" we have selected "use the item type of the {specific
item} as the authoritative item type (for determining circulation and fine
rules, for displaying an item type icon on either opac detail or results page,
etc)."
however, when you do an advanced search for an item type, the search results
pull from both the item record AND the bibliographic record.
I have a few problems with this.
1) How was I suppose to know that, when doing an advanced search, after
selecting what I wanted as my authoritative item type, that advanced searches
were not covered in the "etc" of the description? When I run reports requesting
these item types they could not be found, because the reports were looking for
item records with the specified item types, not bibliographic records with a
specific field in the 942$c. It almost seems as though this is a Koha to MARC
mapping issue, except only one MARC field can be mapped to any one Koha field
and in this case, two fields are being mapped to the same field. When the item
record item type and the bibliographic 942$c were the same, it did not result
in twice the number of results -- so???
2) I have read the Koha manual. I have never found a place where terms are
defined. Is there somewhere that this information is found -- where it states
"when you search for item type in the opac field A, B, and C is searched." That
does not seem to be what the Koha to MARC mapping indicates. And that language
does not seem to match the Koha Search Indexes. Is there no way to use the same
language to indicate the same things?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Barton Chittenden changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Barton Chittenden --- Tried to test, patch does not apply on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 77274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77274=edit Bug 21116: Add API routes through plugins This patch adds plugins the capability of injecting new routes on the API. The plugins should provide the following methods to be considered valid API-generating plugins: - 'api_routes': returning the 'path' component of the OpenAPI specification corresponding to the routes served by the plugin - 'api_namespace': it should return a namespace to be used for grouping the endpoints provided by the plugin otherwise, they will be just skipped. All plugin-generated routes will be added the 'contrib' namespace, and will end up placed inside /contrib/, where is what the 'api_namespace' returns. A sample endpoint will be added to the Kitchen Sink plugin, and tests are being written. To test, wait a bit more for those samples :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 --- Comment #10 from Jonathan Druart --- Created attachment 77273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77273=edit Bug 21087: Fix create_superlibrarian.pl script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21119] New: Add option to repeat order line fields for next order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21119 Bug ID: 21119 Summary: Add option to repeat order line fields for next order Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: cu...@monterey.org QA Contact: testo...@bugs.koha-community.org It would be very handy to be able to repeat fields from one item order to the next the way new items in cataloging can be repeated, so if you are ordering 20 items from a vendor that all have the same price and fund code you wouldn't have to re-key every item. Also would be nice if on completion of receiving an invoice there was a "receive another" button to receive another invoice from the same vendor, as they often come in bunches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 --- Comment #4 from George Williams (NEKLS) --- Tested on the NEKLS test server - works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 George Williams (NEKLS) changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14413] map internalnotes to MarcFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413 Sandre Cunha changed: What|Removed |Added CC||cu...@monterey.org --- Comment #3 from Sandre Cunha --- I don't think BZ15503 addresses this enhancement request. One can import order notes from staged vendor files to one of the MarcFieldsToOrder Sort1 or Sort2, but in order to see them in the Order line -Accounting details - internal note [which on can view when receiving the item] it is necessary to copy-and-paste or retype the note. This type of note is useful for acquisitions receiving, to convey information like : item need for program by a certain date; 2 copies to one fund code, 1 to another ; discard old edition when new arrives; and other notes from selector that need to be retained until the item is received. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #6 from Pierre-Luc Lapointe --- Created attachment 77272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77272=edit Bug 20312: Add a link to last consulted patron This is an update to Maksim's patch. The link "Last patron" is now on the top-right corner of the screen and has the same style as attachment 75672. Moreover, the "X" button is added to remove the link if clicked on. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16544] Changes to circ rules should be logged.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12652] Acq: Wrong fund charged for orders created from staged marc records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12652 Barton Chittenden changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #3 from Barton Chittenden --- I suspect that this is a special case of either Bug 14850: Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl or Bug 20014: When adding to basket from a staged file item budgets are selected my matching on code, not id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21118] Highlighting of search terms in the 500 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21118 Marcy Dunning changed: What|Removed |Added CC||libr...@crmm.org --- Comment #2 from Marcy Dunning --- I would really like to see this enhancement. Some of our 5xx fields are quite long (and will get longer with our archival material) so this would be a great time saver. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 Pablo AB changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #5 from Pablo AB --- Still happen on 18.05, very annoying. Not only on search result (opac-search.pl) but anywhere on OPAC, even on user account (opac-user.pl). Maybe language should be part of the URL query using ISO 639-1 language code: ?hl=en. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Jonathan Druart changed: What|Removed |Added Blocks||21103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 [Bug 21103] Fix parameter reuse in Elasticsearch/QueryBuilder.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21103] Fix parameter reuse in Elasticsearch/QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||19604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21117] Highlighting of search terms in the 500 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21117 Kelly McElligott changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Kelly McElligott --- *** This bug has been marked as a duplicate of bug 21118 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21118] Highlighting of search terms in the 500 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21118 --- Comment #1 from Kelly McElligott --- *** Bug 21117 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21118] New: Highlighting of search terms in the 500 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21118 Bug ID: 21118 Summary: Highlighting of search terms in the 500 fields Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When a search term is entered into Koha, it will search the Marc 5xx fields. This will retrieve the results where the search term is found in the 5xx fields. However, the highlighting does not appear when this term is found in the Marc 5xx fields. It would be nice to show the highlighting throughout the Koha record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21117] New: Highlighting of search terms in the 500 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21117 Bug ID: 21117 Summary: Highlighting of search terms in the 500 fields Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When a search term is entered into Koha, it will search the Marc 5xx fields. This will retrieve the results where the search term is found in the 5xx fields. However, the highlighting does not appear when this term is found in the Marc 5xx fields. It would be nice to show the highlighting throughout the Koha record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Owen Leonard changed:
What|Removed |Added
Attachment #77270|0 |1
is obsolete||
--- Comment #8 from Owen Leonard ---
Created attachment 77271
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77271=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
--- Comment #7 from Jonathan Druart
---
Created attachment 77270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77270=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13542] Subscripton is only table to store userid instead of borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13542 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > It is actually worst than that, it is using "loggedinusername" that is a > concatenation of firstname and surname of the logged in librarian. > > This value is never displayed or reused anywhere else. This is wrong, it's the userid! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13542] Subscripton is only table to store userid instead of borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13542 --- Comment #4 from Jonathan Druart --- It is actually worst than that, it is using "loggedinusername" that is a concatenation of firstname and surname of the logged in librarian. This value is never displayed or reused anywhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Marcel de Rooy --- Rebased. Especially last patch had conflicts due to AddMember changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #76783|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 77267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77267=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #76784|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 77268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77268=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #76785|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 77269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77269=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #76782|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 77266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77266=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #76781|0 |1 is obsolete|| --- Comment #20 from Marcel de Rooy --- Created attachment 77265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77265=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Attachment #75765|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 77264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77264=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Version|18.05 |master --- Comment #6 from Jonathan Druart --- Confirmed on master. It appends on second click (no when just logged in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Marcel de Rooy --- Probably changes on Member.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 --- Comment #45 from Marcel de Rooy --- Simple rebase on Koha/Biblio.pm QA still needs to be finished ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76622|0 |1 is obsolete|| --- Comment #44 from Marcel de Rooy --- Created attachment 77263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77263=edit Bug 17530: (QA follow-up) Move may_article_request to ItemType As requested by QA, we should move may_article_request out of Biblio. For reasons of performance removed the wrapper layer of may_article_request in opac-search. No need to look up all item types. For readability kept the routine in the detail scripts. Note for running ArticleRequests.t: A possible failure on the subtest 'search_limited' is addressed on bug 20866. So you can ignore that one. As long as the subtest for may_article_request passes. Test plan: See previous patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76620|0 |1 is obsolete|| --- Comment #42 from Marcel de Rooy --- Created attachment 77261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77261=edit Bug 17530: (QA follow-up) Replace our variable by cached value Instead of saving the state locally in a variable during Plack lifetime, we move the saved hash to the cache. We clear the key when we enter smart-rules.pl. This makes a change in circ rules immediately effective. Test plan: Run the modified tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76621|0 |1 is obsolete|| --- Comment #43 from Marcel de Rooy --- Created attachment 77262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77262=edit Bug 17530: (QA follow-up) Replace class_or_self variables See comment23. Requested by QA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76618|0 |1 is obsolete|| --- Comment #40 from Marcel de Rooy --- Created attachment 77259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77259=edit Bug 17530: Use may_article_request method in opac-search If you enable pref ArticleRequests, until now all search results got the 'Request article' link. This patch tries to improve the situation by using the new sub with the itemtype of the search result. In most cases the number of links will drastically decrease. It may still be possible sometimes that a link is shown while it effectively is not possible, but we do not get the performance burden of determining that and going through all items. Test plan: [1] Look for two borrowers P1 and P2 within categories C1 resp. C2. [2] Look for two biblios B1 and B2 with default item types I1 resp. I2. (See 942c in case of MARC21.) [3] Make sure that no circ rules allow article requests. Enable the pref. [4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes. Log out. Search for B1 and B2, verify that only B1 has AR link. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that no biblio has AR link. [5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only. Log out. Search for B1 and B2, verify that both have AR links. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that only B2 has AR link. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76617|0 |1 is obsolete|| --- Comment #39 from Marcel de Rooy --- Created attachment 77258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77258=edit Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes This routine looks at the issuingrules and makes a fast 'intelligent guess' if article requests may be allowed for item types while branch code and patron category may not be available. We also add Koha::Biblio->may_article_request using the routine based on default item type or parameter. Implemented as both class and instance method. Added a few tests. Test plan: [1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t [2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What|Removed |Added Attachment #76619|0 |1 is obsolete|| --- Comment #41 from Marcel de Rooy --- Created attachment 77260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77260=edit Bug 17530: Use can_article_request to control sidebar link Before this patch, the 'Request article' link is displayed whenever the pref is enabled. In many cases this might be useless. Instead of a guess as in opac-search, we now call can_article_request to know for sure. Note: at least this is the case when a user has logged in. Update sidebar template with template variable artreqpossible. Add code in opac-detail, MARCdetail and ISBDdetail to fill it. Test plan: [1] Look for two biblios with items: one that should allow article requests and one that should not (respecting branch, patron, item type). [2] Verify on detail, ISBD and MARC that the link is displayed for the first biblio and hidden for the second biblio. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 --- Comment #2 from Marcel de Rooy --- Note for QA: Looks like we should remove the opac and intranet key from the cache when modifying a report. But that is not the topic of this report. So I use this phenomenon in my test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21112] Re-indent staff client cart template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21112 --- Comment #2 from DEVINIM --- Created attachment 77257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77257=edit Bug 21112: Re-indent staff client cart template This patch reindents the template for the staff client cart, basket.tt - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, apply the patch and add multiple items to the cart in the staff client. View the cart and confirm that it looks as it should both in the "brief" and "more details" views. HTML validation before and after the patch should return the same results. Signed-off-by: DEVINIM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 --- Comment #1 from Marcel de Rooy --- Created attachment 77256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77256=edit Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart Resolve things like: CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. The cache key in both script looks like: opac:report:id:602018 but should for consistency be: opac:report:id:60:2018 Note: The 2018 here is part of the sql_params and should not be concatenated to the report id. Test plan: Do not yet apply this patch. Make a report public, set cache to 300 secs. Check its output with opac/svc/report. Check for the warn in your log. Apply the patch, restart Plack and flush cache. Check opac/svc/report. Modify your report; e.g. add a simple string to the SELECT. Check opac/svc/report. You should still see cached output. Flush the cache. Check opac/svc/report. You should now see the added text. Signed-off-by: Marcel de Rooy Tested also by clearing individual keys with $cache->clear_from_cache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 Marcel de Rooy changed: What|Removed |Added Component|Reports |Architecture, internals, ||and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21061] Clean up expired password recovery requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21061 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #15 from Katrin Fischer --- True that :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #14 from Owen Leonard --- (In reply to Katrin Fischer from comment #11) > I like the slimmer display better as it seems easier to handle. What do you > think? No votes against the new design on the mailing list! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||k...@bywatersolutions.com, ||la...@live.fi, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] New: Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 Bug ID: 21116 Summary: Add API routes through plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com We should have a way to add routes using specially crafted plugins. The plugins should provide the following methods to be considered valid API-generating plugins: - 'api_routes': returning the 'path' component of the OpenAPI specification corresponding to the routes served by the plugin - 'api_namespace': it should return a namespace to be used for grouping the endpoints provided by the plugin Plugin-generated routes will be placed inside /contrib/, where is what the 'api_namespace' returns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 --- Comment #8 from Jonathan Druart --- Created attachment 77254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77254=edit Bug 21087: Fix one wrong call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21087] Patron's password is hashed twice when the object is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 --- Comment #9 from Jonathan Druart --- Created attachment 77255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77255=edit Bug 21087: Do not store the password in ->store for existing patrons When ->store is called on an existing patron we must not save the password, but keep the one in DB instead. There is a dedicated method (update_password) to call when the password need to be updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #24 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #23) > (In reply to Jonathan Druart from comment #22) > > The "correct" way to do it (regarding the discussion on bug 11983) would be: > > > > $patron->holds->filter_by_in_transit->filter_by_waiting > > > > But it is not as simple to implement as it sounds. > > Yeah, this sounds more like transit AND waiting instead of transit OR > waiting. Yes you are right, it's not equivalent. > And the idea of two filters applied in a row does not look good in terms of > performance. No it will not. DBIx::Class is building the ResultSet, nothing is fetch at this point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] New: Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 Bug ID: 21115 Summary: Add multi_param call and add divider in cache key in svc/report and opac counterpart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield is mandatory and linked to authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 --- Comment #5 from Katrin Fischer --- Summarizing with a test plan and description of expected behaviour: To test: - Mark collection, itemtype and damaged as mandatory in your MARC framework - Add a new item - Verify that instead of the fields being empty, the first value is selected If there is an itemtype on bilbio level, this itemtype should be selected. Expected behaviour: - All pull downs should offer an empty entry - Empty should be preselected, if there is no - existing value - default in the framework - Only for itemtypes: value in 942$c - If one of those is set, this value should be preselected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Kyle M Hall changed: What|Removed |Added Attachment #70534|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 77253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77253=edit Bug 19743 - Unit Tests Signed-off-by: Te Rauhina Jackson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Kyle M Hall changed: What|Removed |Added Attachment #70533|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 77252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77252=edit Bug 19743 - Header and Footer should be updated on each item for checkin / checkout / renewal notices When generating the checkout notice for a patron we only update the section in between the '---' tags For template toolkit purposes it means we cannot affect the content based on more than a single item. For instance, we want to add the total cost of all items checked out. Test Plan: 1) Add "Thank you for visiting <>." to the bottom of the checkout notice. Below the second ''. 2) Check out an item to a patron to generate that notice 3) Note the branch name in the notice 4) Update the branch name in the branches editor, change it to something else 5) Check out a 2nd item to that patron 6) Notice the items list updated, but the branch name did not 7) Apply this patch 8) Check out a 3rd item to that patron 9) Notice the branch name updated this time Signed-off-by: Te Rauhina Jackson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21114] New: Select multiple item rows with Ctrl+click and Shift+click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21114 Bug ID: 21114 Summary: Select multiple item rows with Ctrl+click and Shift+click Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dimanto...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently, if you want to select multiple items in "Edit items in batch" you have to click (check) per item. It would be great and time saving to add the ability to multiple select the items using Ctrl+click and Shift+click using some javascript code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Marcel de Rooy changed: What|Removed |Added Blocks||20469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 [Bug 20469] Add item status to staff article requests form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Depends on||11983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] Code to select patrons to purge needs to be centralized -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #23 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #22) > The "correct" way to do it (regarding the discussion on bug 11983) would be: > > $patron->holds->filter_by_in_transit->filter_by_waiting > > But it is not as simple to implement as it sounds. Yeah, this sounds more like transit AND waiting instead of transit OR waiting. And the idea of two filters applied in a row does not look good in terms of performance. I will leave this patch in BLOCKED for the time being. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21113] New: Hint Messages are misleading at "Merge Selected Patrons" in Patron Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21113 Bug ID: 21113 Summary: Hint Messages are misleading at "Merge Selected Patrons" in Patron Lists Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: ultron9...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 77251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77251=edit The message is suitable to display upon "Remove Selected" or "Remove Selected Patrons" buttons clicked but the "Merge Selected Patrons" ones. In patron lists, There are two functions for us to handle patrons: "Removed Selected Patrons" and "Merge Selected Patrons". However, even for "Merge Selected Patrons" both , the messages showed either "Are you sure you want to remove the selected patrons?" or "You must select one patron or more patrons to remove." given that one had clicked selected patrons beforehand. It seemed the original files of translations or phases didn't have separate message contents for them individually. (Please check the link as well as the attached image: http://translate.koha-community.org/en_GB/18.05/translate/en-GB-staff-prog.po#unit=4679192 ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #15 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Report wizards fatal errors if no radio buttons selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Report wizards fatal errors if no radio buttons selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 --- Comment #1 from David Cook --- I'm planning on fixing this one soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 --- Comment #5 from Lauski Mori --- (In reply to Lauski Mori from comment #4) > (In reply to Jonathan Druart from comment #3) > > (In reply to Jonathan Druart from comment #2) > > > You should paste here the values of surname and firstname you have set for > > > this user. > > > > And the userid (it is the one displayed on the intranet side actually) > > Hello, Jonathan Druart! > I set the same value for surname and firstname: they were 月 and 月, which > were Traditional Chinese Characters. Also the userid was 月月 as a full name for surname and firstname. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
