[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 --- Comment #1 from paxed --- Created attachment 6 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit Bug 21215: Saved SQL reports code improvements The saved SQL reports code is a bit warty, so improve it: Instead of using the same code in multiple places to split the SQL move that code into the Guided.pm module Add several tests for parameter substitution Make it much easier to add more parameter types for substitution. Test plan: 1) Run your saved SQL reports and check that they work correctly 2) Create new SQL reports and check that the parameters are queried correctly. 3) Prove the t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 paxed changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 paxed changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] New: Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 Bug ID: 21215 Summary: Saved SQL reports code improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org The code for the saved SQL reports is a bit warty - For example, there's the same code that splits the SQL and does the parameter parsing in multiple places, when it should be in the module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on||14576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 [Bug 14576] Allow arbitrary automatic update of location on checkin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Alex Buckley changed: What|Removed |Added Blocks||21159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #8 from Alex Buckley --- Created attachment 5 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5=edit Bug 21159 - Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #77594|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77611|0 |1 is obsolete|| --- Comment #165 from Charles Farmer --- Created attachment 2 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2=edit Bug 17015: Improved UI readability * The calendar tool page no longer shows past holidays in the lists on the right side of the page. * Improved wording in the "Hints" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77612|0 |1 is obsolete|| --- Comment #166 from Charles Farmer --- Created attachment 3 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3=edit Bug 17015: Fixes to migration script Fixes a few errors in the migration script. When first generation the discrete_calendar table, holidays should now be correctly imported for all branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77613|0 |1 is obsolete|| --- Comment #167 from Charles Farmer --- Created attachment 4 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4=edit Bug 17015: Fixes to cronjob Fixes a typo in the add_days cronjob. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77609|0 |1 is obsolete|| --- Comment #163 from Charles Farmer --- Created attachment 0 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=0=edit Bug 17015: Updated patch after bug 19204 This is a small modification to bring the patch up-to-date with current master after the changes made in 19204. Tests in db_dependent/Circulation.thave been changed slightly since DiscreteCalendar strictly prevents changing holidays in the past. This patch requires 20660. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77610|0 |1 is obsolete|| --- Comment #164 from Charles Farmer --- Created attachment 1 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1=edit Bug 17015: Improve stability for very old loans This patch fixes a crash when calculating fines for hourly loans created before the earliest date in the 'discrete_calendar' table. The SQL call has been altered to find the closest day (using DATEDIFF). QA Green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Charles Farmer changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #66 from Charles Farmer ---
New patch to fix, in part, some problems raised by QA.
> Why only changes to the ...style-us and not the other templates?
If I look at it chronologically, this patch was first submitted at a time when
no {de,fr} templates existed. Commits for these templates came in 2015 and
2017, and I couldn't say when they were added to the master. It's no excuse for
not reworking the patch, if that's what QA needs, but at least there's a
rationale: it was rebased over and over without extending what had been done.
> What has this to do with making it possible for adults to be guarantors? ;)
That looks like a prime candidate for an optional patch, I concede. But some of
the 'extra' developments in this patch were naturally asked by our clients when
we offered linking adults to adults. I do think there are merits to keeping
these functionalities together (though perhaps not as far as keeping the
example you quoted).
> If we set it on the patron category, why check here for I and A?
Indeed, it's information easily retrievable from the $patron object already
sent to the template. Worst of all, it's not even used by any template linked
to moremember.pl :/
I feel like that echoes my previous comment about it being an old cookie: it
has been rebased many times to quickly offer something to test, but at the cost
of not being rewritten everytime to leverage new
functions/variables/developments.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21125] Shortcut moredetail.pl on nonexistent biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21125 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77272|0 |1 is obsolete|| --- Comment #10 from Pierre-Luc Lapointe --- Created attachment 77769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77769=edit Bug 20312: Add a link to last consulted patron This new feature adds a link to the last patron consulted in the staff site. It uses cookies to save this information. When a staff site user accesses a patron record, the ID, name and card number of the patron will be saved in the cookie. To test: 1- Apply the patch 2- Go to a patron details' page 3- Verify that the link "Last patron" appears on the top-right corner of the screen 4- Go to another page 5- The link should still be here 6- Click on the link 7- Verify that you are at the patron's checkout page 8- Click on the "X" button next to the "Last patron" link 9- The link should be gone 10- Go to another page 11- The link shouldn't appear (until the next patron detail's page) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What|Removed |Added Attachment #77766|0 |1 is obsolete|| --- Comment #64 from Charles Farmer --- Created attachment 77767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77767=edit Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #65 from Charles Farmer --- Created attachment 77768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77768=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What|Removed |Added Attachment #72883|0 |1 is obsolete|| --- Comment #63 from Charles Farmer --- Created attachment 77766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77766=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #29 from Katrin Fischer --- I'd not insist on squashing per se - there are reasons when it might not make sense. I haven't taken a closer look at those patches (can't test coce), but signed off is good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #28 from Charles Farmer --- Thanks for the explanation Katrin, it does make sense. Though I feel like in that instance, it begs the question "why should we submit (QA follow-up) patches in the first place"? Either I'm squashing changes, and losing the distinctive history that follow-up patches bring (and signoffs, if any), or I'm breaking the QA script... Sorry for digressing here, it's more a discussion for the dev list :) If I had to make a suggestion, it would be to lower this 'warning' from FAIL to something else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21120] item-level types and advanced searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21120 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- I am not sure I understood correctly, but I will try and answer you anyway :) When you search by item type, Zebra will be queried with "mc-itype: BK" (BK for Book), mc-itype is defined and mapped in the different config files of Zebra. For instance in etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml you will notice that itype is indexed with values from 942$c and 952$y. Feel free to adjust this configuration depending on your needs (a full reindexation will be needed for the changes to be taken into account). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #27 from Katrin Fischer --- It's just a warning about something that could easily be confusing or a mistake: FAIL koha-tmpl/intranet-tmpl/prog/js/coce.js FAIL git manipulation The file has been added and deleted in the same patchset Usually, if it's an option (same authors, sign-offers on the patches) you can resolve that by squashing the patches. Then the file won't ever be added instead of being added to be removed with the next patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I agree with Jonathan - there are bigger issues with our database structure, but assuming 1:1 is safe for now and we should fix this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21090] Description of itemtype group doesn't show when there is an itemtype with the same code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090 --- Comment #5 from Jonathan Druart --- Still ok here. % git checkout v17.11.08 % sudo koha-mysql kohadev MariaDB [koha_kohadev]> select * from authorised_values where authorised_value="BK"; +-+-+--+-+--+--+ | id | category| authorised_value | lib | lib_opac | imageurl | +-+-+--+-+--+--+ | 398 | ITEMTYPECAT | BK | desc BK | desc BK | | +-+-+--+-+--+--+ 1 row in set (0.01 sec) MariaDB [koha_kohadev]> select itemtype, description from itemtypes where searchcategory="BK"; +--++ | itemtype | description| +--++ | BK | Books | | CF | Computer Files | +--++ 2 rows in set (0.00 sec) https://snag.gy/pG5ygm.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21072] Should not show 'Update patron to adult' if no adult patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21072 Jonathan Druart changed: What|Removed |Added Version|master |18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #26 from Owen Leonard --- (In reply to Charles Farmer from comment #23) > Wait, `git mv` is now seen as an erroneous operation?! I'll leave that up to QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Attachment #77598|0 |1 is obsolete|| Attachment #77599|0 |1 is obsolete|| --- Comment #24 from Owen Leonard --- Created attachment 77764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77764=edit Bug18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #25 from Owen Leonard --- Created attachment 77765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77765=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 --- Comment #1 from Jonathan Druart --- Created attachment 77763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77763=edit Bug 21209: (bug 20828 follow-up) Step 4 of moremember is used for Housebound and additional attributes Test plan: 1) Make sure the HouseboundModule is enabled in system preferences 2) Go to a patron file 3) Next to Housebound roles, click on "Add" 4) Check "Yes" next to one of the two roles (or both) 5) Click "Save" 6) The "Add" button is now "Edit", click on it The page is the one to edit housebound roles. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart changed: What|Removed |Added Blocks||21209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Depends on||20828 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23 from Charles Farmer --- Wait, `git mv` is now seen as an erroneous operation?! What am I supposed to do about that? Delete in one patch and submit the _same exact_ file in another one? I mean, I'm all for the QA script, but this seems questionable, for lack of a better adjective. Putting it back at 'Signed Off', it's an operation that had to be done. If, however, you wring my arm, I'll split it in two distinct patches :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- These patches were wrong, the issue should have been fixed by https://gitlab.com/koha-community/qa-test-tools/issues/1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #2 from Charles Farmer --- Created attachment 77762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77762=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 --- Comment #3 from Jonathan Druart --- (In reply to Martin Renvoize from comment #2) > QA Comment: Can we 100% guarantee that there is always 1 and only 1 > biblioitem attached to a biblio object? > > Looking at the dbic schema it appears there's no db level constraint for > this (it's a has_many relationship), looking a level up in the Koha::Biblio > object it appears we do indeed fire a ->find rather than using the > underlying dbic relationship, which suggests there's only 1 (or 0) > biblioitem attached to a biblio but there's no test to confirm we actually > get a biblioitem object back. > > I'd love to see the underlying db constraints added, but would accept a > second check that the biblioitem exists before calling unblessed upon it. > > Perhaps I'm being over cautious? I do not think this is valid, biblio and biblioitem must be considered 1-1, we discussed it several times on the mailing lists. Both tables must be merged, but it's a huge work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #225 from Jonathan Druart --- (In reply to Owen Leonard from comment #224) > Found two more issues: > > - The branches table is alerting something on ILL requests -> New request This comes from ILL backends (not in Koha). > - IntranetUserJS incorrectly outputs encoded HTML entities Fixed in a new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #224 from Owen Leonard --- Found two more issues: - The branches table is alerting something on ILL requests -> New request - IntranetUserJS incorrectly outputs encoded HTML entities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- I think this should be fixed now by the work on bug 10306 and depending bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21065] Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- on delete set null? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21176] decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 --- Comment #1 from Jonathan Druart --- Created attachment 77761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77761=edit Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21176] decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart changed: What|Removed |Added Blocks||21192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Jonathan Druart changed: What|Removed |Added Depends on||14658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Jonathan Druart changed: What|Removed |Added Severity|trivial |normal Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 --- Comment #1 from Jonathan Druart --- Created attachment 77760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77760=edit Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification There was a mix up between "modification" and "edit" for $action in opac-memberentry.pl. If a patron is logged into the OPAC and they attempt to submit changes to their personal details without having actually changed anything, the page reloads with a message stating 'No changes were made.' However, the fields that now appear are those that have been allowed/hidden according to the preferences set for patron self registration, even if patron self registration is disabled. This can lead to problems if there are discrepancies between the fields allowed for self register settings and those allowed for patron self modification settings. To replicate: 1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to 'don't allow' 2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is different between the two settings and save (for example, specify 'mobile' to be hidden in the former, but don't include in the list of fields to be hidden in the latter). 3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice that the editable fields correspond to those not hidden by PatronSelfModificationBorrowerUnwantedField 4.) Without making any changes, click on 'Submit update request'. 5.) Note that on this page the fields correspond to those not hidden by PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any fields that would otherwise be hidden by the Self Modification settings). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Jonathan Druart changed: What|Removed |Added Blocks||21196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 [Bug 21196] Allow calcfine to consider default item type replacement cost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 Jonathan Druart changed: What|Removed |Added Depends on||12768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 [Bug 12768] Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 --- Comment #1 from Jonathan Druart --- Created attachment 77758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77758=edit Bug 21196: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 --- Comment #2 from Jonathan Druart --- Created attachment 77759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77759=edit Bug 21196: Use replacement cost from the item type if not set at item level When circ rules are set to cap at item replacement cost, calcfine only checks the price in the item record, not the default replacement cost by item type. Note: We do not take '0' into account, what if you do not want to set a replacement cost for an item? It is how it is done in chargelostitem so keeping the existing behaviour, but that may be considered as a bug (?) Test plan: - Set useDefaultReplacementCost to use - Set a default replacement cost for a given item type - Create an item of that type with a replacementcost=0 - Create a circ rule for that item type that accrues fines but caps at replacement cost - check the item out, forcing a due date in the past - check that item in => Fines should have been generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Version|17.11 |master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Andrew Isherwood changed: What|Removed |Added Attachment #75330|0 |1 is obsolete|| --- Comment #19 from Andrew Isherwood --- Created attachment 77757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77757=edit Bug 20750: Allow logging of arbitrary actions This patch allows logging of arbitrary actions on request objects. A chronological summary of these actions can then be displayed when viewing a request. This patch also adds logging of request status changes. Additional work has been done on the BLDSS backend to log requests to the BLDSS request status check API. To test: - Apply patch - Ensure the Illlog logging preference is turned on - Create an ILL request and perform actions on it that change it's status. - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #7 from Jonathan Druart --- Olivier, yes you are right. I wanted to provide a patch for people who wanted to patch their installation locally. It should not be pushed until the situation has been clarified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #1 from Charles Farmer --- Created attachment 77756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77756=edit BZ 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] New: cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Bug ID: 21214 Summary: cleanup_database.pl --mail should let admin choose which letter codes to keep Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: charles.far...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz We are often asked if an email was sent to a patron, and despite not having 100% confirmation that the message reached the person, it feels bad when fines are attached to it and no information's left in the database for our librarians. A new patch would let certain messages stay in the database, despite their age, based on their letter_code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Owen Leonard changed: What|Removed |Added Attachment #75203|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77755=edit Bug 20690: Update two-column templates with Bootstrap grid: Acquisitions part 4 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 21213] Circulation.t needs diagnostics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21213] Circulation.t needs diagnostics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213 --- Comment #2 from Jonathan Druart --- Created attachment 77754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77754=edit Bug 21213: Add diagnostics to Circulation.t Jenkins reported failures on a D9 run. No idea why it is failing so adding diag and wait for the next failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21213] Circulation.t needs diagnostics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213 --- Comment #1 from Jonathan Druart --- I have no idea why this is failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21213] New: Circulation.t needs diagnostics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213 Bug ID: 21213 Summary: Circulation.t needs diagnostics Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 20721 koha_1 | # Failed test 'Test at line 1896' koha_1 | # at t/db_dependent/Circulation.t line 2424. koha_1 | # got: '0' koha_1 | # expected: '1' koha_1 | koha_1 | # Failed test 'Test at line 1896' koha_1 | # at t/db_dependent/Circulation.t line 2427. koha_1 | # got: undef koha_1 | # expected: '2018-08-25' koha_1 | # Looks like you failed 2 tests of 14. koha_1 | koha_1 | # Failed test 'AddReturn + suspension_chargeperiod' koha_1 | # at t/db_dependent/Circulation.t line 1905. koha_1 | # Looks like you failed 1 test of 118. koha_1 | [19:23:06] t/db_dependent/Circulation.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20721 [Bug 20721] Circulation.t keeps failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20721] Circulation.t keeps failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20721 Jonathan Druart changed: What|Removed |Added Blocks||21213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21213 [Bug 21213] Circulation.t needs diagnostics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 Owen Leonard changed: What|Removed |Added Attachment #75133|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77753=edit Bug 20672: Update two-column templates with Bootstrap grid: Acquisitions part 3 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #5 from Jonathan Druart --- Created attachment 77752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77752=edit Bug 21001: Add missing format=json to openlibrary calls See https://github.com/internetarchive/openlibrary/issues/1014 Test plan: Turn on OpenLibraryCovers and OpenLibrarySearch Do a search at the OPAC You should see the covers from OpenLibrary as well as the "Searching Open Library... " and "Found XXX results in OpenLibrary collection" info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21212] Syndetics image size should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21212 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #73 from Owen Leonard --- Created attachment 77750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77750=edit Bug 17674 - Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #74 from Owen Leonard --- Created attachment 77751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77751=edit Bug 17674 (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #71 from Owen Leonard --- Created attachment 77748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77748=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #72 from Owen Leonard --- Created attachment 77749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77749=edit Bug 17674 - Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #70 from Owen Leonard --- Created attachment 77747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77747=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard changed: What|Removed |Added Attachment #75643|0 |1 is obsolete|| Attachment #75644|0 |1 is obsolete|| Attachment #75645|0 |1 is obsolete|| Attachment #75646|0 |1 is obsolete|| Attachment #75647|0 |1 is obsolete|| Attachment #75648|0 |1 is obsolete|| Attachment #75649|0 |1 is obsolete|| --- Comment #68 from Owen Leonard --- Created attachment 77745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77745=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #69 from Owen Leonard --- Created attachment 77746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77746=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Owen Leonard changed: What|Removed |Added Attachment #77479|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77744=edit Bug 21157: Improve style of OPAC login modal This patch revises the style of the OPAC's login form modal view. The goal is simply to make it look nicer. To test, apply the patch and regenerate the OPAC's CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the OPAC, click the "Log in to your account" link at the top of the page. It should trigger the login modal. While the modal is displayed, resize the browser width to confirm that the form handles different widths well. Sign off if you think this is an improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Jonathan Druart changed: What|Removed |Added Severity|normal |major Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What|Removed |Added Attachment #75461|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 77743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77743=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Attachment #77022|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 77742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77742=edit Bug 10442: Remove references to non-standard "error" class The CSS for is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard . To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Attachment #76487|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Attachment #76489|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 --- Comment #14 from Owen Leonard --- Created attachment 77740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77740=edit Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Attachment #76488|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 77741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77741=edit Bug 10659: (follow-up) Add plugin information to the about page This patch updates the about page in the staff client, replacing the information about the jQuery Star Ratings plugin with information about the new jQuery Bar Ratings plugin. To test, apply the patch and go to the about page in the staff client. Confirm that the new information appears correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21211] Patron messages/notes do not appear in all the tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #4 from Owen Leonard --- (In reply to information from comment #3) > Add Message via button - only appears on the Checkout page. This should not be the case. The button is in an include file which is used across all patron-specific pages. If you find otherwise it's a bug (which I don't see in our installation of 17.11). > Add new message via link on checkout page - this also displays in the > Circulation Note field in the Details page but is clear from Checkout page > too. I don't really understand this comment, but I do see inconsistency between the way the "Add a new message" link appears on the circulation page versus the detail page: The link appears on Circulation when there are no messages and doesn't on the detail page. I consider it a bug that the link appears on circulation when there are no messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21211] Patron messages/notes do not appear in all the tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #3 from informat...@newcastle.gov.uk --- Description: messages/notes on Patrons do not appear in a consistent way across all the Patron tabs, depending on how they are created. Add Message via button - only appears on the Checkout page. Add new message via link on checkout page - this also displays in the Circulation Note field in the Details page but is clear from Checkout page too. Could messages be made to appear on both the Details and the Checkout tabs, please, regardless of the way they are created? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21211] Patron messages/notes do not appear in all the tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 --- Comment #2 from informat...@newcastle.gov.uk --- (In reply to Katrin Fischer from comment #1) > Hi, > there is no description for this bug report and there is not enough > information in the subject to see what it's about. Can you please add some > more details? Hi, sorry we never meant to leave it that way! It's a case of clicking too quickly and then not having time to go back to it straightaway. In the process of adding the details now. Thanks, Aude -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21211] Patron messages/notes do not appear in all the tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211 informat...@newcastle.gov.uk changed: What|Removed |Added Summary|Add message details |Patron messages/notes do ||not appear in all the tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312
--- Comment #9 from Owen Leonard ---
Some suggestions:
- Use instead of an image for X.
- Put the CSS in staff-global.scss
- Put the JavaScript in staff-global.js
- Add the JS to the existing $(document).ready() so you don't need
'addEventListener('DOMContentLoaded')';
- Be consistent about whether you use single or double quotes
(In reply to Katrin Fischer from comment #8)
> I wonder if libraries would like to have this optional for privacy reasons.
> It might be safer to add a pref.
A lot of this already rests in the hands of the librarian and their browser. If
I have my browser configured to restore my last session, my back button will
take me back to the last patron without a handy link.
The way this patch does it, the cookie should disappear when the browser is
closed. I would think that is adequate.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
