[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

paxed  changed:

   What|Removed |Added

   Assignee|olli-antti.kivila...@jns.fi |pasi.kalli...@joensuu.fi
 CC||pasi.kalli...@joensuu.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20935] Redesign system preferences interface

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

Summary|Syspref to choose whether   |Syspref to choose whether
   |to search homebranch,   |to search homebranch,
   |holding branch or both in   |holding branch or both for
   |advanced search |library groups in advanced
   ||search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21173,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21174,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21249,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21159

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

--- Comment #13 from Alex Buckley  ---
Just attached the save marc draft commit rebased against 18.05.02 so it now
applies cleanly, ready for testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

--- Comment #12 from Alex Buckley  ---
Created attachment 78021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78021=edit
Bug 20699 - Implemented a save marc as draft feature

This patch implements the ability to save marc records to the reservior
(in a similar way to how imported staged records are stored in the
 reservior).

The purpose of this feature is to be able to train junior library staff
and catalogers by letting them practise cataloging biblio records and saving
them as drafts
(stored in the reservoir). Because these draft records are stored in the
reservoir they are not returned as OPAC search results.

This patch implements a new 'editcatalogue' subpermission called
'commit_MARC_records_to_catalog'. A staff member must have this subpermission
enabled to commit a record to the catalog.

In the addbiblio.pl interface users with all editcatalogue
subpermissions (which should be staff experienced with cataloging) will see 4
'Save' options:

* Save and review record
* Save and edit items
* Save and continue editing
* Save without cataloging

Junior staff should have all editcatalog subpermissions except for
'commit_MARC_records_to_catalog' and they will see one save option 'Save
without cataloging' and this saves the record as a draft.

To view and administer all draft records you can click on the 'View
draft records' button in the toolbar on the addbooks.pl page.

Here draft records are listed newest to oldest and individual draft records can
be edited/deleted or all draft records
can be deleted in one go.

Test plan:

Test plan:
1. Go to addbooks.pl and notice there is no 'View draft reocrds' button
in the toolbar alongside 'New record'

2. Apply patch

3. Restart plack, memcached

4. Update your database, this can be achieved by runnning
installer/data/mysql/updatedatabase.pl or in Koha staff client going to
Adminstration->Global system preferences->Local use and amending the
Version syspref value

5. Create two user accounts one with superlibrarian permissions and the
other with all editcatalogue subpermissions except for
'commit_MARC_records_to_catalog' and also enable the catalogue
permission so this user can access the staff client.

6. Log in as user 1 (superlibrarian) go to Cataloging->New record and
select the 'Save' dropdown box and notice you have 4 options. Select
'Save and view record' and notice you have created a biblio in the
catalog.

7. Log out and log in as user 2 go to Cataloging->New record and
click the 'Save' button and notice that there is only one option 'Save
without cataloging'. Meaning you are restricted to only creating a draft
record.

8. Select 'Save without cataloging' and you are re-directed to the
Cataloging main page. Now select the 'View draft records' button and
view your draft record in the table of draft records.

9. Select the 'Edit' link and notice the addbiblio.pl page for the draft
record is loaded

10. Return to the View draft records interface and delete the draft
record and notice that after the page reloads the record is no longer
displayed in the table.

11. Create 2 more draft records and return to the View draft records
interface and select 'Delete all drafts from reservoir' and notice the
drafts table is emptied

12. Create 1 more draft record and then log out

13. Log in as user 1 (superlibrarian) and go to the View draft records
interface.

14. Select the 'Edit' link

15. Select any save option except for 'Save without cataloguing' and
notice the record is now committed to the catalog.

16. Return to the 'View draft records' interface and notice the record
you just committed to the catalog has been removed as a draft record in
the reservoir.

17. Run the unit test t/db_dependent/ImportBatch.t in koha-shell

18. Notice that unit test 12 passes: 'ok 12 - No biblio expected since
we deleted the biblio from the batch'

19. Log out and back in as the second user and search for a biblio
record which is in the catalog (i.e. not a draft record) and notice both
in the staff client search results and the biblio detail page the links
to edit the record and items associated with the biblio record are not
displayed. This is because the user you are logged in as has all
edit_catalogue permissions except
CAN_user_editcatalogue_commit_MARC_records_to_catalog which is
neccessary to add/edit/delete biblios or items in the catalog.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Alex Buckley  changed:

   What|Removed |Added

  Attachment #75193|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21251] tracklinks.pl doesn't work with URLs containing ampersands

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21251

Alex Buckley  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Alex Buckley  ---
Turned out to be an issue with the URL encoding in the XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21251] New: tracklinks.pl doesn't work with URLs containing ampersands

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21251

Bug ID: 21251
   Summary: tracklinks.pl doesn't work with URLs containing
ampersands
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

When the $uri variable is set from accessing the cgi->param('uri') value
retrieved from the URL in tracklinks.pl if the uri to be redirected to contains
a ampersand the ampersand and any content after it is ignored and not assigned
to the $uri value. 

This is because when values are passed via the URL  the ampersand is the
delimiter between the variables and so any values after the ampersand are not
considered to belong to uri. 

This results in a 404 error being displayed when track clicks is enabled and
the URL in the biblio's 856$u contains an ampersand.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060

--- Comment #4 from Liz Rea  ---
(In reply to Oliver Behnke from comment #2)
> For us it's the other way round: we use a two-library-setup, both with
> auto-self-checkout enabled (based on cardnumber). The problem is that since
> the internal self-checkout user also has to be assigned to exactly one
> branch, that branch will be used as "current location" when a patron checks
> out a book. So, it's the self-service account's branch that's used instead
> of the borrower's branch.
> 
> From looking at the code it seems that C4::Circulation->AddIssue() is using
> "C4::Context->userenv->{branch}" where "$borrower->{'branch'}" should
> probably be used instead, since the current user's branch isn't relevant
> (even wrong) in the auto-self-checkout context.
> 
> FYI, we use the following config (if relevant at all):
> - CircControl: the library the item is from
> - HomeOrHoldingBranch: the library the item is from
> 
> Shall I open a dedicated bug report for that I do we (re)use this one...?
> 
> Thanks!

Probably

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21174,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21173,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21159

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21173] Run auto item modifications by age every hour and set the item age unit to hours

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21173

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21249

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #15 from Elaine Bradtke  ---
Yes, the fewer clicks the better. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

Ulrich Kleiber  changed:

   What|Removed |Added

 CC||ulrich.klei...@bsz-bw.de

--- Comment #15 from Ulrich Kleiber  ---
Tested 'RequestHeader set X_FORWARDED_PROTO "https" env=HTTPS' with http and
https, everthing seemed to be ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

--- Comment #14 from Katrin Fischer  ---
We've also tested this line, but only with https:

RequestHeader set X_FORWARDED_PROTO "https" env=HTTPS

Maybe this could be a general solution?

https://httpd.apache.org/docs/2.4/mod/mod_headers.html#requestheader
The RequestHeader directive may be followed by an additional argument, which
may be any of: 
early Specifies early processing. 
env=[!]varname The directive is applied if and only if the environment variable
varname exists.
A ! in front of varname reverses the test, so the directive applies only if
varname is unset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

--- Comment #13 from Katrin Fischer  ---
We tested the solution Tomas suggested and it works well!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #24 from Kyle M Hall  ---
Created attachment 78020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78020=edit
Bug 7614: Don't allow un-usable pickup locations in the opac pickup locations
pulldown

Also fully qualifies some subroutine calls that fail for reasons unkown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20374] New french intranet and opac unimarc xslt

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20374

delaye  changed:

   What|Removed |Added

  Attachment #77671|0   |1
is obsolete||
  Attachment #77672|0   |1
is obsolete||
  Attachment #77673|0   |1
is obsolete||
  Attachment #77674|0   |1
is obsolete||
  Attachment #77675|0   |1
is obsolete||
  Attachment #77676|0   |1
is obsolete||
  Attachment #77677|0   |1
is obsolete||
  Attachment #77678|0   |1
is obsolete||

--- Comment #26 from delaye  ---
Created attachment 78019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78019=edit
OPAC result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20358] Add unitprice_tax_included on report spent.pl

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20358

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

Owen Leonard  changed:

   What|Removed |Added

  Attachment #77983|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 78018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78018=edit
Bug 20743: Update two-column templates with Bootstrap grid: Administration part
7

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #129 from Victor Grousset/tuxayo  ---
I realized that your patch was in bug 6473 so I attached it here instead of my
version.

- showed the raw patch in bug 6473
- copied the text
- added an attachment here where the text was pasted and the attachment was
marked as a patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20136] Test Bug

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20136

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6473
 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19706] Item search: Unsupported format html

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20136

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #208 from Victor Grousset/tuxayo  ---
(could be an issue even when attaching *another* patch in this bug, quite
tricky then ^_^ )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #77995|0   |1
is obsolete||

--- Comment #128 from Victor Grousset/tuxayo  ---
Created attachment 78017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78017=edit
Bug 12310: (QA follow-up) Add prefs to test too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #207 from Victor Grousset/tuxayo  ---
(In reply to Liz Rea from comment #0)
> Use this bug when testing your git-bz. :)
> 
> DO YOUR WORST!!
> 
> (yes, that's a challenge)

^_^

With an old git-bz version (or wrong branch), the above should cause an issue
when attaching to this bug:

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2632, in 
do_attach(*args)
  File "/usr/local/bin/git-bz", line 1998, in do_attach
attach_commits(bug, commits, edit_comments=global_options.edit)
  File "/usr/local/bin/git-bz", line 1913, in attach_commits
description, body, obsoletes, statuses, patch_complexities, depends =
edit_attachment_comment(bug, commit.subject, body)
  File "/usr/local/bin/git-bz", line 1866, in edit_attachment_comment
lines = edit_template(template.getvalue())
  File "/usr/local/bin/git-bz", line 811, in edit_template
f.write(template)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2192' in position
600: ordinal not in range(128)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #206 from Victor Grousset/tuxayo  ---
Created attachment 78016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78016=edit
Bug 6473: test strange char in summary → + emoji in file name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21142] Batch item/record modification/deletion tools does not open uploaded files in utf-8

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21142] Batch item/record modification/deletion tools does not open uploaded files in utf-8

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #77992|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 78015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78015=edit
Bug 21142: Open uploaded files in utf-8 - batch mod/del

Batch item/record modification/deletion tools does not open uploaded
files in utf-8

Test plan:
Edit and delete records and items using a file which will contain:
valid and invalid barcodes with and without utf-8 chars ()

You should see the warning message:
 "The *** 3000001679 does not exist in the database."

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20116] Cache language list

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

--- Comment #18 from Tomás Cohen Arazi  ---
Jonathan, it looks great. Will you provide a couple tests for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

--- Comment #2 from Alex Buckley  ---
Created attachment 78014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78014=edit
Bug 21249 - New syspref controlling branch fields queried against selected
library group value in advanced search

This commit allows librarians to choose whether they want to query the
homebranch, holdingbranch or homebranch AND holdingbranch when they set
a library group search condition in the staff client and OPAC advanced
searches.

Test plan:
1. Apply patch and run ./updatedatabase.pl in the koha shell

2. Restart memcached and plack

3. In the staff client go to Administration->Global system preferences
and search for the systempreference: AdvancedSearchBranchFieldToUse and
notice by default it is set to 'homebranch and holdingbranch'

4. Create a library group (if you do not already have one) and add
several library branches to the group.

5. Note down the barcode of an item to use for testing searching. Make
sure the items homebranch and holdingbranch are different and the items
homebranch is a child branch of the library group created in step 4

5. Perform an Advanced search in the staff client and write in the
keyword as the barcode of the item and select the library group in the
'Location and availability' section.

6. Submit the search query and notice the item with a homebranch
existing in the selected library group is returned. This proves that
when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and
holdingbranch' the homebranch value is checked.

Also note at the top of the search result page the search query is listed: 
Results of search
with limit(s): '(homebranch:  or holdingbranch:  or
homebranch:
 or holdingbranch: )'

7. Now edit the item making sure the homebranch branch is not in the
library group, and making sure the holdingbranch is in the library
group. This is to test that holdingbranch is indeed being checked when
the AdvancedSearchBranchFieldToUse is set to
'AdvancedSearchBranchFieldToUse'.

8. Repeat step 5 and 6 and notice the item with a holdingbranch existing
in the selected library group is returned. This proves that when the
AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and
holdingbranch' the holdingbranch is checked.

9. Change the value of the AdvancedSearchBranchFieldToUse syspref to
'holdingbranch' and repeat step 8 and again notice the item with a
holdingbranch existing in the selected library group is returned so we
know the holdingbranch is being chcked when the 'holdingbranch' value
for the syspref is set.

Also note the search query at the top of the page is: "Results of search
with limit(s): '(holdingbranch:  or holdingbranch: )'"
this shows holdingbranch not homebranch is a condition in the query

10. Change the homebranch back to a branch that is in the library group
and change the holdingbranch value to a library branch that is not in
the library group.

11. Repeat step 5 and 6 and notice the item with the homebranch in the
selected library group is returned, so we know the homebranch is being
checked when the 'homebranch' value for the syspref is set.

Also note the search query at the top of the page is: " Results of
search  with limit(s): '(homebranch:  or homebranch: )'" this
shows homebranch not holdingbranch is a condition in the query.

Sponsored-By: Brimbank Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7996] Patron modification log requires parameters permission

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996

--- Comment #10 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #7)
> It seems that we could remove the condition in viewlog.tt, do you confirm?

Yes, the permission check is done in the script, we shouldn't need a second

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78013|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

--- Comment #1 from Alex Buckley  ---
Created attachment 78013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78013=edit
Bug 21249 - New syspref controlling branch fields queried against selected
library group value in advanced search

This commit allows librarians to choose whether they want to query the
homebranch, holdingbranch or homebranch AND holdingbranch when they set
a library group search condition in the staff client and OPAC advanced
searches.

Test plan:
1. Apply patch and run ./updatedatabase.pl in the koha shell

2. Restart memcached and plack

3. In the staff client go to Administration->Global system preferences
and search for the systempreference: AdvancedSearchBranchFieldToUse and
notice by default it is set to 'homebranch and holdingbranch'

4. Create a library group (if you do not already have one) and add
several library branches to the group.

5. Note down the barcode of an item to use for testing searching. Make
sure the items homebranch and holdingbranch are different and the items
homebranch is a child branch of the library group created in step 4

5. Perform an Advanced search in the staff client and write in the
keyword as the barcode of the item and select the library group in the
'Location and availability' section.

6. Submit the search query and notice the item with a homebranch
existing in the selected library group is returned. This proves that
when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and
holdingbranch' the homebranch value is checked.

Also note at the top of the search result page the search query is listed: 
Results of search
with limit(s): '(homebranch:  or holdingbranch:  or
homebranch:
 or holdingbranch: )'

7. Now edit the item making sure the homebranch branch is not in the
library group, and making sure the holdingbranch is in the library
group. This is to test that holdingbranch is indeed being checked when
the AdvancedSearchBranchFieldToUse is set to
'AdvancedSearchBranchFieldToUse'.

8. Repeat step 5 and 6 and notice the item with a holdingbranch existing
in the selected library group is returned. This proves that when the
AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and
holdingbranch' the holdingbranch is checked.

9. Change the value of the AdvancedSearchBranchFieldToUse syspref to
'holdingbranch' and repeat step 8 and again notice the item with a
holdingbranch existing in the selected library group is returned so we
know the holdingbranch is being chcked when the 'holdingbranch' value
for the syspref is set.

Also note the search query at the top of the page is: "Results of search
with limit(s): '(holdingbranch:  or holdingbranch: )'"
this shows holdingbranch not homebranch is a condition in the query

10. Change the homebranch back to a branch that is in the library group
and change the holdingbranch value to a library branch that is not in
the library group.

11. Repeat step 5 and 6 and notice the item with the homebranch in the
selected library group is returned, so we know the homebranch is being
checked when the 'homebranch' value for the syspref is set.

Also note the search query at the top of the page is: " Results of
search  with limit(s): '(homebranch:  or homebranch: )'" this
shows homebranch not holdingbranch is a condition in the query.

Sponsored-By: Brimbank Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

--- Comment #12 from Marcel de Rooy  ---
This report needs a staff counterpart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21216] Add filter/search options to notices table

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216

--- Comment #1 from Owen Leonard  ---
Created attachment 78012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78012=edit
Bug 21216: Add filter/search options to notices table

This patch adds a DataTables toolbar to the Notices & slips table,
including a filter field, column visibility, and data export options.

To test, apply the patch and clear your browser cache if necessary.

 - Go to Tools -> Notices & slips
 - Confirm that there is a table toolbar with a filter, a "Column
   visibility" button, and "Excel," "CSV," "Copy," and "Print" buttons.
 - Confirm that showing and hiding columns via the button is working
   correctly.
 - Confirm that only the first four columns are sortable.

Go to Administration -> Columns settings.

- Expand the "Tools" section.
- Find "id=lettert."
- Make some selections to configure default settings of the reports
  table.
- Return to reports and confirm that these defaults are applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21216] Add filter/search options to notices table

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with two-branch library setup

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250

--- Comment #1 from Oliver Behnke  ---
It's probably a good idea to verify that all uses of "C4::Context->userenv"
(anywhere) are compatible with the auto-self-checkout system as the underlying
assumption that the current user is always a concrete patron or librarian isn't
applicable in that scenario.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Martin Renvoize  ---
Certainly, the code is solid and I'm more than happy for my SO to count as QA
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060

Oliver Behnke  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21250

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with two-branch library setup

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250

Oliver Behnke  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10060

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21250] New: Auto-self-checkout not fully compatible with two-branch library setup

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250

Bug ID: 21250
   Summary: Auto-self-checkout not fully compatible with
two-branch library setup
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oliver.beh...@aei.mpg.de
QA Contact: testo...@bugs.koha-community.org

We use a two-branch library setup, both with auto-self-checkout enabled, so
patrons log in with their cardnumber via the pre-defined staff user account
(see below). The problem is that since the internal self-checkout user also has
to be assigned to exactly one branch, that branch will be used as "current
location" when a patron checks out a book. So, it's the self-service account's
branch that's used instead of the patron's/borrower's branch.

>From looking at the code it seems that C4::Circulation->AddIssue() is using
"C4::Context->userenv->{branch}" where "$borrower->{'branch'}" should probably
be used instead, since the current user's branch isn't relevant (even wrong) in
the auto-self-checkout context.

FYI, we use the following config (if relevant at all):
- Koha 18.05.01-2
- AutoSelfCheckAllowed: Allow (AutoSelfCheckID/AutoSelfCheckPass)
- CircControl: the library the item is from
- HomeOrHoldingBranch: the library the item is from

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #14 from Josef Moravec  ---
Hi all, about the question asked on mailing lists: I think the default
behaviour change to one click to show the cart does make sense. So I am for it
;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21249] New: Syspref to choose whether to search homebranch, holding branch or both in advanced search

2018-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Bug ID: 21249
   Summary: Syspref to choose whether to search homebranch,
holding branch or both in advanced search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Implement a system preference for librarians to choose whether they want the
library or library group selected in the advanced search to be checked against
biblios homebranch, holdingbranch or both branches.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/