[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167

--- Comment #5 from Katrin Fischer  ---
Hi Cab, you printed the account summary. Try the printing links next to
payments and created fees/fines fees in the fines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

--- Comment #73 from Katrin Fischer  ---
If it's only the hint being added, I'd be ok putting this back into the QA
queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #9 from paxed  ---
Comment on attachment 78212
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78212
Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running
process_message_queue.pl

AFAICS, no other cronjob script uses one of the debian/scripts/koha- -scripts
... I wonder if this works for everyone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #8 from Alex Buckley  ---
Created attachment 78212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78212=edit
Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running
process_message_queue.pl

The script loops through every enabled instance. It checks if the 
messagequeue.lock file is locked in the instance directory.

If not then the cronjob runs.

If the lock file is locked then this is logged and a email is sent out.

Test plan:
1. In two terminals open koha-shell and try to run
./process_message_queue.pl and notice you can run the script multiple
times simulataneously without a warning/error being displayed

2. Apply patch

3. Repeast step 1 and notice that the second of the two scripts to be
run will output text saying './process_message_queue.pl is already
running. Exiting'

In this case the aforementioned text is displayed and the body of the
cronjob is not run.

4. The first cronjob script to run, runs without issues

Sponsored-By: Parliament Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78211|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78210|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #7 from Alex Buckley  ---
Created attachment 78211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78211=edit
Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running
process_message_queue.pl

The script loops through every enabled instance. It checks if the 
messagequeue.lock file is locked in the instance directory.

If not then the cronjob runs.

If the lock file is locked then this is logged and a email is sent out.

Test plan:
1. In two terminals open koha-shell and try to run
./process_message_queue.pl and notice you can run the script multiple
times simulataneously without a warning/error being displayed

2. Apply patch

3. Repeast step 1 and notice that the second of the two scripts to be
run will output text saying './process_message_queue.pl is already
running. Exiting'

In this case the aforementioned text is displayed and the body of the
cronjob is not run.

4. The first cronjob script to run, runs without issues

Sponsored-By: Parliament Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #6 from Alex Buckley  ---
Created attachment 78210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78210=edit
Bug 15529 - Lock /var/lock/koha//messagequeue.lock while running
process_message_queue.pl

The script loops through every enabled instance. It checks if the 
messagequeue.lock file is locked in the instance directory.

If not then the cronjob runs.

If the lock file is locked then this is logged and a email is sent out.

Test plan:
1. In two terminals open koha-shell and try to run
./process_message_queue.pl and notice you can run the script multiple
times simulataneously without a warning/error being displayed

2. Apply patch

3. Repeast step 1 and notice that the second of the two scripts to be
run will output text saying './process_message_queue.pl is already
running. Exiting'

In this case the aforementioned text is displayed and the body of the
cronjob is not run.

4. The first cronjob script to run, runs without issues

5. At the end of the execution of the first script a 15 second pause is run

Sponsored-By: Parliament Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

Alex Buckley  changed:

   What|Removed |Added

  Attachment #78205|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17507] Can upload the same .koc file twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507

--- Comment #2 from Liz Rea  ---
Or prevent duplicate files from being uploaded, period.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17507] Can upload the same .koc file twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507

Liz Rea  changed:

   What|Removed |Added

Summary|Preference to limit how old |Can upload the same .koc
   |an offline circ file can be |file twice
   |when uploaded   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167

--- Comment #4 from Cab Vinton  ---
Created attachment 78209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78209=edit
Bug 21167

Unable to duplicate. Perhaps not printing correct invoice/ receipt?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

--- Comment #3 from Cab Vinton  ---
Unable to duplicate the issue in Biblibre Sandbox 7 (see attachment).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

--- Comment #72 from Aleisha Amohia  ---
Rebased, ready for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 Status|NEW |ASSIGNED

--- Comment #5 from Alex Buckley  ---
I have attached a preliminary patch which will be refined further in the near
future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #78104|0   |1
is obsolete||

--- Comment #71 from Aleisha Amohia  ---
Created attachment 78208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78208=edit
Bug 14272: (follow-up) Fixing template error and layout

To test, confirm that OpacMainUserBlock and Quote of the Day do not show
if viewing a single news item, but do show otherwise. Confirm user
dashboard shows where expected

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

UPDATE 24/Aug: Add expiration date text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #77568|0   |1
is obsolete||

--- Comment #70 from Aleisha Amohia  ---
Created attachment 78207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78207=edit
Bug 14272: (follow-up) only display news available for a particular opac lang
[alternative patch]

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #77567|0   |1
is obsolete||

--- Comment #69 from Aleisha Amohia  ---
Created attachment 78206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78206=edit
Bug 14272: Show single news item [alternative patch]

This is a new patch for this bug that shows a single news item on the
OPAC using Koha Objects (Koha::News).

To test:
1) Go to Tools -> News on staff interface, make a news item to show on
the OPAC
2) Go to OPAC
3) Notice news item shows and title cannot be clicked
4) Apply patch, refresh page
5) Notice title is now a link. Click title
6) Confirm breadcrumbs shows title of news item
7) Confirm RSS feed and OpacMainUserBlock are not visible
8) In the URL, change the news_id param to an ID that does not exist
9) Confirm that an appropriate error message shows

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #4 from Alex Buckley  ---
Created attachment 78205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78205=edit
Bug 15529 - Using flock to lock new messagequeue.lock lockfile whilst
process_message_queue.pl is being executed

Test plan:
1. In two terminals open koha-shell and try to run
./process_message_queue.pl and notice you can run the script multiple
times simulataneously without a warning/error being displayed

2. Apply patch

3. Repeast step 1 and notice that the second of the two scripts to be
run will output text saying './process_message_queue.pl is already
running. Exiting'

In this case the aforementioned text is displayed and the body of the
cronjob is not run.

4. The first cronjob script to run, runs without issues

5. At the end of the execution of the first script a 15 second pause is run

Sponsored-By: Parliament Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|14289   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14289
[Bug 14289] all traces of record.abs files should be removed from Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14289] all traces of record.abs files should be removed from Koha

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14289

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|14302   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302
[Bug 14302] Remove GRS1 indexing related code
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #31 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #30)
> Created attachment 78191 [details] [review]
> Bug 18639: Alter DB update to populate replacementprice from rpp initially

Hi Nick, hoping to get back to this soon. Why did you change your mind about
the db update?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78151|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 78203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78203=edit
Bug 14302: (follow-up) Remove traces in koha-create

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78150|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 78202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78202=edit
Bug 14302: (QA follow-up) Remove remaining file

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78152|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 78204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78204=edit
Bug 14302: (follow-up) Remove traces in C4::Search and C4::Context

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78149|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 78201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78201=edit
Bug 14302: Remove grs1 records from test data

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78148|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 78200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78200=edit
Bug 14302: Remove GRS1 specific code

Remove:
- BIB_INDEX_MODE and AUTH_INDEX_MODE env var
- bib_index_mode and auth_index_mode options from scripts
- Warnings from about page, just kept one if zebra_bib_index_mode or
zebra_auth_index_mode still exist in config and are set to grs1

Test plan:
- Install Koha from src
- Install Koha from pkg
- Read the code, carefully!

Signed-off-by: Tomas Cohen Arazi 
Rebased

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78147|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 78199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78199=edit
Bug 14302: Remove GRS1 related files

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78027|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 78198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78198=edit
Bug 20743: Update two-column templates with Bootstrap grid: Administration part
7

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 21279] New: Transport cost matrix shows html entity in all empty cells

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279

Bug ID: 21279
   Summary: Transport cost matrix shows html entity in all empty
cells
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The transport cost matrix now shows  in all empty cells. Cells should be
empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20742] Update two-column templates with Bootstrap grid: Administration part 6

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20742

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20742] Update two-column templates with Bootstrap grid: Administration part 6

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20742

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78025|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 78197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78197=edit
Bug 20742: Update two-column templates with Bootstrap grid: Administration part
6

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265

--- Comment #1 from Alex Buckley  ---
Created attachment 78196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78196=edit
Bug 21265 - Added onboardingstep6 to the end of onboarding tool.

This step is to add values/enable HEA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21116] Add API routes through plugins

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #77601|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 78195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78195=edit
Bug 21116: Add API routes through plugins

This patch adds plugins the capability of injecting new routes on the
API.

The plugins should provide the following methods to be considered valid
API-generating plugins:

- 'api_routes': returning the 'path' component of the OpenAPI specification
corresponding to the routes served by the plugin
- 'api_namespace': it should return a namespace to be used for grouping the
endpoints provided by the plugin

otherwise, they will be just skipped.

All plugin-generated routes will be added the 'contrib' namespace, and
will end up placed inside /contrib/, where  is what the
'api_namespace' returns.

A sample endpoint will be added to the Kitchen Sink plugin, and tests
are being written.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> SUCCESS: Tests pass!
- Install the (latest) KitchenSink plugin
- Point your browser to the API like this:
  http://koha-intra.myDNSname.org:8081/api/v1/.html
=> SUCCESS: The /contrib/kitchensink/patrons/:patron_id/bother endpoint
implemented by the plugin has been merged!
- Sign off! :-D

Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21116] Add API routes through plugins

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 78194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78194=edit
Bug 21116: Unit tests

This path implements unit tests for the route-from-plugin development.
It adds the required methods to the Koha::Plugin::Test plugin
distributed along with the tests. A second plugin implementing invalid
OpenAPI specs is added (Koha::Plugin::BadAPIRoute).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20741] Update two-column templates with Bootstrap grid: Administration part 5

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20741

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Owen, can you please rebase? Part 5 is missing from the sequence! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78029|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 78193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78193=edit
Bug 20690: Update two-column templates with Bootstrap grid: Acquisitions part 4

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78028|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 78192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78192=edit
Bug 20672: Update two-column templates with Bootstrap grid: Acquisitions part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #30 from Nick Clemens  ---
Created attachment 78191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78191=edit
Bug 18639: Alter DB update to populate replacementprice from rpp initially

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21278] CANCEL_HOLD_ON_LOST notice contains different variables

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278

--- Comment #3 from Katrin Fischer  ---
It's a process, I think starting with the new notices now. The account slip
notices (payment/waive receipts) in 18.11 will also be TT from the start, as
they make calculations and do formatting (look in master).

The old ones are supposed to be converted too, maybe this should be a goal for
18.11?

Look at the graph view of this bug:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

There are 2 examples for converted notices here:
https://wiki.koha-community.org/wiki/Notices_and_Slips_Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

--- Comment #17 from Elaine Bradtke  ---
+1 'save as draft'
To a cataloguer, 'save without cataloguing' makes no sense. It makes one wonder
what's going to happen to the data when the button is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21278] CANCEL_HOLD_ON_LOST notice contains different variables

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278

--- Comment #2 from Caroline Cyr La Rose  ---
Katrin,

I didn't test it, but I figured it might be confusing to end users if they see
some notices have [% xxx %] and other notices have << xxx >>.

Either they should all be [% xxx %] or all << xxx >>, not a mix of the two.

If it is indeed changing, we have a lot of work to do in the manual and the
wiki to change the instructions on how to customize the notices.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21278] CANCEL_HOLD_ON_LOST notice contains different variables

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Caroline, 

that's the new TT syntax - it should work. Have you tested?

The notice also uses an IF/ELSE construct to display the right reason, this
would not be possible without TT (Template Toolkit)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21278] New: CANCEL_HOLD_ON_LOST notice contains different variables

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278

Bug ID: 21278
   Summary: CANCEL_HOLD_ON_LOST notice contains different
variables
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

The sample notice CANCEL_HOLD_ON_LOST contains variables with the syntax [% xxx
%] instead of << xxx >>.

in installer/data/mysql/en/mandatory/sample_notices.sql

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21277] fr-CA translation for notices in sample_notices.sql

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21277

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21277] fr-CA translation for notices in sample_notices.sql

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21277

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 78190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78190=edit
Bug 21277: fr-CA translation for notices in sample_notices.sql

This patch adds fr-CA translations for the following sample notices:

- ACCOUNT_PAYMENT
- ACCOUNT_WRITEOFF
- ACQORDER
- AR_CANCELED
- AR_COMPLETED
- AR_PENDING
- AR_PROCESSING
- AR_SLIP
- CANCEL_HOLD_ON_LOST
- CHECKOUT_NOTE
- MEMBERSHIP_EXPIRY
- PASSWORD_RESET

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21277] New: fr-CA translation for notices in sample_notices.sql

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21277

Bug ID: 21277
   Summary: fr-CA translation for notices in sample_notices.sql
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: caroline.cyr-la-r...@inlibro.com
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: philippe.blo...@inlibro.com

I hope this is the right place to submit this.

The following sample notices are missing fr-CA translations:
- ACCOUNT_PAYMENT
- ACCOUNT_WRITEOFF
- ACQORDER
- AR_CANCELED
- AR_COMPLETED
- AR_PENDING
- AR_PROCESSING
- AR_SLIP
- CANCEL_HOLD_ON_LOST
- CHECKOUT_NOTE
- MEMBERSHIP_EXPIRY
- PASSWORD_RESET

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #29 from Nick Clemens  ---
Created attachment 78189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78189=edit
Bug 18639: (follow-up) Populate replacement price from list price during
ordering

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #28 from Nick Clemens  ---
Created attachment 78188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78188=edit
Bug 18639 Use replacementprice when creating order from quote

Updates column name from rrp -> replacementprice when creating
order from EDI QUOTE message
Also ensure other rrp_tax* fields populated

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #27 from Nick Clemens  ---
Created attachment 78187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78187=edit
Bug 18639 - Unit tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #25 from Nick Clemens  ---
Created attachment 78185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78185=edit
Bug 18639 - Schema updates (DO NOT PUSH)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #26 from Nick Clemens  ---
Created attachment 78186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78186=edit
Bug 18639 - Add replacementprice field to acquisitions workflow

To test:
 0 - Apply patches and updatedatabase
 1 - Add an order to a basket
 2 - You should note new 'Retail price field'
 3 - You should have a separate 'Replacement price' field
 4 - Enter values and ensure they are saved as expected
 5 - In the basket you should see the replacement price
 6 - Modify order and ensure value is loaded and saved correctly
 7 - Add and cancle an order and esure replacement price shows/saves
 8 - Close basket
 9 - Receive an order
10 - You should be able to edit replacement price
11 - 'retail price' field is not editable
12 - Check associated item, replacement price in item should be updated
13 - Cancel receipt, check item. receive again with new replacement
price, check item
14 - Price should be correctly updated
15 - Finish receipt, value should show in table
16 - Test with receive from file

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens  changed:

   What|Removed |Added

  Attachment #76867|0   |1
is obsolete||
  Attachment #76868|0   |1
is obsolete||
  Attachment #76869|0   |1
is obsolete||
  Attachment #76870|0   |1
is obsolete||
  Attachment #76871|0   |1
is obsolete||

--- Comment #24 from Nick Clemens  ---
Created attachment 78184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78184=edit
Bug 18639 - Add replacementprice field to aqorders

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21274] SPAM

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21274

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21276] SPAM

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21276

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |INVALID
Summary|sad |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21274] SPAM

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21274

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|sad |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21275] SPAM

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21275

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|sad |SPAM
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21276] sad

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21276

--- Comment #1 from david  ---
Created attachment 78183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78183=edit
asd

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21276] New: sad

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21276

Bug ID: 21276
   Summary: sad
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hea
  Assignee: ch...@bigballofwax.co.nz
  Reporter: penyunata...@gmail.com
QA Contact: jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #34 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21275] New: sad

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21275

Bug ID: 21275
   Summary: sad
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hea
  Assignee: ch...@bigballofwax.co.nz
  Reporter: penyunata...@gmail.com
QA Contact: jonathan.dru...@bugs.koha-community.org

Created attachment 78182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78182=edit
sad

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14289] all traces of record.abs files should be removed from Koha

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14289

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Tomás Cohen Arazi  ---


*** This bug has been marked as a duplicate of bug 14302 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14302] Remove GRS1 indexing related code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #13 from Tomás Cohen Arazi  ---
*** Bug 14289 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21274] New: sad

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21274

Bug ID: 21274
   Summary: sad
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: penyunata...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 78181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78181=edit
Sad

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Sorry, forgot the sign-off line. RM, would you make an exception and add it
before push?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #15 from Ere Maijala  ---
Created attachment 78180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78180=edit
Bug 20447: Include basic summary holdings in the OAI-PMH responses.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

If include_items is set in oai conf, also basic location information from
holdings records is included in the returned MARC records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #14 from Ere Maijala  ---
Created attachment 78179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78179=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala  changed:

   What|Removed |Added

  Attachment #76735|0   |1
is obsolete||
  Attachment #76736|0   |1
is obsolete||

--- Comment #13 from Ere Maijala  ---
Created attachment 78178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78178=edit
Bug 20447: MARC Holdings support

https://bugs.koha-community.org/show_bug.cgi?id=20447

Enable by setting "SummaryHoldings" option to "Use".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

--- Comment #244 from Ere Maijala  ---
Looks like escaping was added also to places where it doesn't belong. The
examples I stumbled on were just setting a variable:

https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt#L328

and 

https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt#L330

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #210 from Julian Maurice  ---
test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21273] New: After upgrade from 17.11.08 to 18.05.02 intra not working, Software error: Template process failed

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21273

Bug ID: 21273
   Summary: After upgrade from 17.11.08 to 18.05.02 intra not
working, Software error: Template process failed
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: elias.deh...@thulb.uni-jena.de
QA Contact: testo...@bugs.koha-community.org

Created attachment 78177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78177=edit
Screenshot phpmyadmin

After upgrading from 17.11.08 to 18.05.02 we get the following software error
on the intra:

Software error:
Template process failed: undef error -
DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_koha.branches' doesn't
exist in engine at /usr/share/koha/lib/Koha/Objects.pm line 269

Users can't login on the OPAC and a search from the opac throws the following
error:
DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_koha.branches' doesn't
exist in engine at /usr/share/koha/lib/Koha/Objects.pm line 129

It seems like there went something wrong during the upgrade process.

With phpmyadmin we can see that the table 'koha_koha.branches' is still there
but the collation is shown as in-use. If we try to select this table we get the
following error:

#1932 - Table 'koha_koha.branches' doesn't exist in engine

The same error occurs on three other tables:
 borrower_attribute_types
 categories
 currency

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13127] SQL report creation mangles HTML if using non-existent auth value

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13127

paxed  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from paxed  ---
Already fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12340] Checkboxes are shown for nonexistent SMS transports

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12340

paxed  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from paxed  ---
Already fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12335] Add class="LOGGED_IN_BRANCH" to body

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12335

paxed  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from paxed  ---
Fixed by bug 12162

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12297] Waitingreserves code duplication

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12297

paxed  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi

--- Comment #1 from paxed  ---
Created attachment 78176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78176=edit
Bug 12297: Fix waitingreserves code duplication

waitingreserves.tt has two near-identical tables, holdst and holdso.
These should be folded into a single TT BLOCK, which is then called
with appropriate parameters to generate the two tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

--- Comment #6 from Cab Vinton  ---
Unable to replicate in Biblibre sandboxes 11 (this patch) & 12 (master), w/
database 2 (UNIMARC).

Tried searching by subject and subject phrase, & both with and without an item
type limit:
opac-search.pl?idx=su%2Cphr=rugby=and=kw==and=kw==Search=mc-itype%2Cphr%3ALIVR

Search returned the same 2 results in both sandboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20374] New french intranet and opac unimarc xslt

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20374

delaye  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20374] New french intranet and opac unimarc xslt

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20374

delaye  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12228] Sort patron category by description not by code

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12228

paxed  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from paxed  ---
Already fixed in master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

paxed  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi
 Status|NEW |Needs Signoff

--- Comment #1 from paxed  ---
Created attachment 78175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78175=edit
Bug 12187: Duplicate TT code for serial statuses

Instead of duplicating the code for serial statuses in multiple
files, move all of them into single include file, and use that.

Needs a test plan, but I haven't used serials.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21233] Add Koha::Exceptions::Password class

2018-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21233

--- Comment #14 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #13)
> (In reply to Marcel de Rooy from comment #7)
> > Just a language thing on TrailingWhitespaces
> > I would say we have trailing spaces or trailing whitespace where whitespace
> > is \s* in regex terms (catching all spaces, tabs, newlines etc.). No plural
> > form needed.
> > 
> > From
> > https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-
> > whitespace:
> > The word "whitespace" is usually uncountable. If you need it to be
> > countable, I would suggest saying "whitespace characters".
> 
> I'd say we should even get rid of 'Trailing', because this is then used in a
> test for whitespace chars at the begining too, right?

Too late ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/