[Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458

--- Comment #9 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #6)
> (In reply to Cab Vinton from comment #5)
> > Patch applied successfully in sandbox, but value still appears truncated to
> > DOCUMENTAT both w/ report displaying items.ccode and w/ XML export of 
> > record.
> 
> Oh indeed my test plan is missing that the trucation is made when item is
> saved.
> I correct the test plan.

To test on a sandbox :
- configure a sandbox with no patch using "master" instead of bug number
- run test plan until step 8
- reconfigure sandbox with this bug number
- run test plan skipping steps 8,9 and 10

Thanks for your tests ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #78385|0   |1
is obsolete||

--- Comment #7 from Fridolin SOMERS  ---
Created attachment 78553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78553=edit
Bug 5458: increase ccode column to varchar 80

Koha allows you to define an authorised value having length 80, but then you
can't use it.

Here is why:
The SQL field items.ccode is a varchar(10).
The SQL field authorised_values.authorised_value is a varchar(80).
Therefore the authorised value is truncated to length 10 in items.ccode and the
mapping from authorised value to description string fails in Koha.

This patch increases ccode column to varchar 80, like location.

Test plan :
1) Dont apply patches
2) Check there is on item field a subfield with authorised value category CCODE
3) Check this subfield is linked with database column items.ccode
4) Create an authorised values in category CCODE with 'DOCUMENTATION'
5) Edit an item on ccode and choose 'DOCUMENTATION'
6) Save item
7) Look at items.ccode in database or export in MARCXML
8) The value is troncated to 'DOCUMENTAT'
9) Apply patches and update database with
installer/data/mysql/atomicupdate/bug_5458.sql
10) Repeate step 5 to 7
11) The value is not truncated 'DOCUMENTATION'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #78386|0   |1
is obsolete||

--- Comment #8 from Fridolin SOMERS  ---
Created attachment 78554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78554=edit
Bug 5458: Update DBIx schema

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458

--- Comment #6 from Fridolin SOMERS  ---
(In reply to Cab Vinton from comment #5)
> Patch applied successfully in sandbox, but value still appears truncated to
> DOCUMENTAT both w/ report displaying items.ccode and w/ XML export of record.

Oh indeed my test plan is missing that the trucation is made when item is
saved.
I correct the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #78544|0   |1
is obsolete||

--- Comment #5 from Benjamin Rokseth  ---
Created attachment 78549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78549=edit
Bug 21327: Add Core::Main Namespace

- Core::Exceptions
- Core::Prefs

This is the main class of Core, along with siblings
Prefs  - to handle sysprefs and overrides, as well as
Exceptions - Also included are the Makefile and koha-conf setup

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #78547|0   |1
is obsolete||

--- Comment #8 from Benjamin Rokseth  ---
Created attachment 78552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78552=edit
Bug 21327: Implement Core::Circulation in admin and SIP

covered:

C4::SIP::ILS::Transaction::Checkin->do_checkin
C4::SIP::ILS::Transaction::Checkout->do_checkout
C4::SIP::Sip::MsgType->handle_checkout (add branch)
circ/circulation.pl
circ/renew.pl
circ/returns.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #78546|0   |1
is obsolete||

--- Comment #7 from Benjamin Rokseth  ---
Created attachment 78551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78551=edit
Bug 21327: Add Core::Community::Circulation

This is the Community subclass of Circulation that should be run as default
to handle the basic Circulation, and should be interchangable with today's
functionality.
It also adds SIP integration.

to use, add the following in the config section of koha-conf.xml:
 
   Core::Community::Circulation
   Core::Community::Circulation::SIP
 

This is also the default if not set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #78545|0   |1
is obsolete||

--- Comment #6 from Benjamin Rokseth  ---
Created attachment 78550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78550=edit
Bug 21327: Add Core::Circulation

This is the Circulation subclass of Core. It is a work in progress, but ideally
all neccessary subfunctions should be overridable, and it should consist of
a bare minimum of functionality for handling circulation.
It is a rewrite of C4::Circulation.

To use, add this in the config section in koha-conf.xml and restart plack:


  Core::Circulation


-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21116] Add API routes through plugins

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

--- Comment #94 from Jonathan Druart  
---
Created attachment 78548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78548=edit
Bug 7534: (QA follow-up) Use Koha.Preference template plugin to fetch the
pref's value

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14237] allow bibs to be added to course without items

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237

Leslie O'Brien  changed:

   What|Removed |Added

   Priority|P5 - low|P2
 CC||lobr...@vt.edu

--- Comment #4 from Leslie O'Brien  ---
We would like to be able to add course reserve items without using a dummy item
record or barcode. We had this functionality in our Sierra system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

--- Comment #1 from Benjamin Rokseth  ---
Created attachment 78544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78544=edit
Add Core::Main Namespace

- Core::Exceptions
- Core::Prefs

This is the main class of Core, along with siblings
Prefs, to handle sysprefs and overrides, as well as
Exceptions. Also included are the Makefile and koha-conf setup

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

--- Comment #4 from Benjamin Rokseth  ---
Created attachment 78547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78547=edit
Implement Core::Circulation in admin and SIP

covered:

C4::SIP::ILS::Transaction::Checkin->do_checkin
C4::SIP::ILS::Transaction::Checkout->do_checkout
C4::SIP::Sip::MsgType->handle_checkout (add branch)
circ/circulation.pl
circ/renew.pl
circ/returns.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

--- Comment #2 from Benjamin Rokseth  ---
Created attachment 78545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78545=edit
Add Core::Circulation

This is the Circulation child of Core. It is a work in progress, but ideally
all neccessary subfunctions should be overridable, and it should consist of
a bare minimum of functionality for handling circulation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

--- Comment #3 from Benjamin Rokseth  ---
Created attachment 78546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78546=edit
Add crude Core::Community::Circulation

This is the Community subclass of Circulation that should be run as default
to handle the basic Circulation, and should be interchangable with todays
functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21116] Add API routes through plugins

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #78323|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 78543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78543=edit
Bug 21116: Add API routes through plugins

This patch adds plugins the capability of injecting new routes on the
API.

The plugins should provide the following methods to be considered valid
API-generating plugins:

- 'api_routes': returning the 'path' component of the OpenAPI specification
corresponding to the routes served by the plugin
- 'api_namespace': it should return a namespace to be used for grouping the
endpoints provided by the plugin

otherwise, they will be just skipped.

All plugin-generated routes will be added the 'contrib' namespace, and
will end up placed inside /contrib/, where  is what the
'api_namespace' returns.

A sample endpoint will be added to the Kitchen Sink plugin, and tests
are being written.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> SUCCESS: Tests pass!
- Install the (latest) KitchenSink plugin
- Point your browser to the API like this:
  http://koha-intra.myDNSname.org:8081/api/v1/.html
=> SUCCESS: The /contrib/kitchensink/patrons/:patron_id/bother endpoint
implemented by the plugin has been merged!
- Sign off! :-D

Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21116] Add API routes through plugins

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #78322|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 78542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78542=edit
Bug 21116: Unit tests

This path implements unit tests for the route-from-plugin development.
It adds the required methods to the Koha::Plugin::Test plugin
distributed along with the tests. A second plugin implementing invalid
OpenAPI specs is added (Koha::Plugin::BadAPIRoute).

Edit: I made terminology changes to make it less rude.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21329] New: Purchase Suggestions Add Custom Fields

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

Bug ID: 21329
   Summary: Purchase Suggestions Add Custom Fields
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisettesla...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It would be great if we could add custom fields to the purchase suggestion
form, preferably set by library or hierarchical group. 
This would allow us to ask additional questions (Such as would you like a hold
if we purchase this item, would you like to request an ILL if we don't purchase
this item? etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21328] New: Purchase Suggestions View by Hierarchical Group

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21328

Bug ID: 21328
   Summary: Purchase Suggestions View by Hierarchical Group
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisettesla...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Allow staff to setup to view purchase suggestions for the entire hierarchical
group at once. 
Some libraries have multiple branches but people at the main branch do all the
ordering. Currently they have to click through 7 branches to see if branch B
has even 1 purchase suggestion. It would be great if they could see all for the
hierarchical group they belong to.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #110 from Ere Maijala  ---
True, I actually had a fix for that in
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74321. Awesome if
you can work on it soon since ES stuff will have an important role in Kohacon
hackfest this week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #109 from David Gustafsson  ---
And I would not say that concaternation currently works if the result is,
"JohansenHanna", "MaquetYves-Marie" or "BehndKathi" for example (missing
space). Probably easy to correct, but could be improved further with the
optimized indexing as mentioned above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #108 from David Gustafsson  ---
(In reply to Ere Maijala from comment #106)
> > Why? This is the behavior we had before. In my opinion, the point here is
> > not to discuss 
> > how we should format data for elasticsearch but make indexing process
> > faster. So, the first 
> > step is to have at least the same feature/data with koha-specific code we
> > had with Catmendu libraries and, once
> > we are done, check if we already have time saving.
> 
> I don't think the two can be separate. If the indexing method doesn't allow
> something that's clearly needed, any optimization of the indexing code needs
> to take it into account. Alex's comment #83 also implies that concatenation
> did work with Catmandu, and even if it didn't, it would have been easy to
> tweak the rules to fix it.
> 
> Your version of indexing would be faster than Catmandu even if subfields in
> a single field would be processed in rule order. But if all this becomes too
> complicated, I think it would be better to put any optimization on the back
> burner and work on the current code instead to fix its issues. E.g. I can
> easily resurrect the previous patch in bug 20244 for several improvements.

At took a look at it and it seams to be quite easily fixed with the optimized
indexing. I think you join all the subfields in your patch, but think can post
a patch by tomorrow (or the next day) where only some (defined in mappings)
subfields can be joins, without much increased complexity or impact on
performance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18102] REST API: Add pickup_location to library's Swagger definition

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18102
Bug 18102 depends on bug 7534, which changed state.

Bug 7534 Summary: New OPACAllowUserToChooseBranch setting for only showing 
libraries allowing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #93 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7614] Branch transfer limit and holds

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614
Bug 7614 depends on bug 7534, which changed state.

Bug 7534 Summary: New OPACAllowUserToChooseBranch setting for only showing 
libraries allowing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #17 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #15 from Martin Renvoize  ---
I really like this change :)

Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 20743, which changed state.

Bug 20743 Summary: Update two-column templates with Bootstrap grid: 
Administration part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 20742, which changed state.

Bug 20742 Summary: Update two-column templates with Bootstrap grid: 
Administration part 6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20742

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20742] Update two-column templates with Bootstrap grid: Administration part 6

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20742

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
Bug 20654 depends on bug 20741, which changed state.

Bug 20741 Summary: Update two-column templates with Bootstrap grid: 
Administration part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20741

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20741] Update two-column templates with Bootstrap grid: Administration part 5

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20741

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #9 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21295] Update selenium tests for Admin pages bootstrap updates

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21295

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 Depends on||20736
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Caused by bug 20736 not in 18.05.x series.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736
[Bug 20736] Update two-column templates with Bootstrap grid: Administration
part 1
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21295
[Bug 21295] Update selenium tests for Admin pages bootstrap updates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #422 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #420)
> Created attachment 78475 [details] [review]

See commit c1c7f5ede60ef63f5da969ff8495675248e50102
Bug 7143: Update about page for documentation team
IIRC we updated the about page depending on the work done during the release,
and not the candidates of the beginning of the release cycle.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #51 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #48)
> (In reply to Marcel de Rooy from comment #47)
> > Please add unit tests
> 
> Switching to NSO, I'd like a confirmation that the code is doing what we are
> expecting it to do. Then I will try to provide tests.

Wouldn't the tests show us what we are expecting it to do? The person who knows
what it is supposed to do should be writing the tests, or at least confirming
that any tests written represent what should be written.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21327] New: Add a Modular Koha Core design

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21327

Bug ID: 21327
   Summary: Add a Modular Koha Core design
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: benjamin.roks...@deichman.no
QA Contact: testo...@bugs.koha-community.org

This is a demonstration of the possibility to refactor parts of Koha into a
modular design. The idea is to make use of class inheritance and method
overrides to make it possible for a library to use only the parts of Koha that
are relevant.

It is possible to do this whilst maintaining the full compatibility of the
community version, and hopefully it could help in refactoring into a more
stable, maintanable and pluggable core.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15495] Change Browse Shelf Display

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15495

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21326] Add branch param to C4::SIP->checkout

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326

--- Comment #1 from Benjamin Rokseth  ---
Created attachment 78541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78541=edit
Bug 21326: C4::SIP::ILS add missing branch param

ILS::Transaction was missing branch param for unknown reason.
Since every transactions needs a branch, it makes sense to include it in
the object and allow as param.

This patch only adds the param to the object and ILS->checkout so it
can be used in submodules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21326] Add branch param to C4::SIP->checkout

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326

Benjamin Rokseth  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21326] New: Add branch param to C4::SIP->checkout

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326

Bug ID: 21326
   Summary: Add branch param to C4::SIP->checkout
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: benjamin.roks...@deichman.no
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

For some reason branch is not included in the SIP::ILS::Transaction object, but
rather fetched inside C4::Circulation using context. This bug adds branch to
object so it can be passed in as param to ILS::Transaction->checkout

(this is already present in ILS::Transaction->checkin)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #107 from Séverine Queune  ---
(In reply to Alex Arnaud from comment #105)
> (In reply to Nicolas Legrand from comment #103)
> > (In reply to David Gustafsson from comment #102)
> > [...]
> > > > I think the mapping system was designed for that. I.e
> > > > 
> > > > author: 700ba
> > > > # we get 700$a and 700$b concatenated
> > > > 
> > > > And when concatenation is not wanted:
> > > > 
> > > > author: 700b
> > > > author: 700a
> > > > # We get 700$a and 700$b in 2 different array elements
> > > 
> > > In that case there are MANY mappings that are defined in the wrong way.
> > 
> > True, but we recently learned the hard way we need those kind of
> > concatenation in the zone 7xx. We have cases of "authorfirstname
> > authorlastname" that don't work and should. Rewriting mappings is not
> > expansive compare to this.
> 
> Hello Nicolas,
> 
> Any exemples of what doesn't work ?

Hi Alex,
On Bulac catalog, you can search for "Ariane Eissen".
You'll have 2 results, but we possess 3 books she wrote.
In the third record, "Ariane" is preceded by "sous la direcetion d' " in 200$f
so with the apostophe, the name of the author is considered as "d'Ariane".
This is quite an obscur problem to us, because zone 7xxx is correctly indexed
and authorities are present, so we could have found this third record using
both "Ariane" and "d'Ariane".
I just test with the form you mentionned on comment 94 and it works : I've got
3 results searching "eissenariane".
Could that exemple help you ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

--- Comment #10 from Victor Grousset/tuxayo  ---
An hypothesis from a colleague is that there might be some circular dependency
that prevents the prefixless-resolution to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

--- Comment #20 from Martin Renvoize  ---
Can this be closed of as a duplicate of the now pushed bug 19166 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail

2018-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #9 from Victor Grousset/tuxayo  ---
Aren't "just" prefixes missing? (C4::Biblio::)

We are having the same problem with
Undefined subroutine ::Items::TransformMarcToKoha called at
/home/koha/src/C4/Items.pm line 243.

On a 17.11.06 on a Debian 8 with perl v5.20.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/