[Koha-bugs] [Bug 21376] New: Catalogue detail date handling improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21376 Bug ID: 21376 Summary: Catalogue detail date handling improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21376] Catalogue detail date handling improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21376 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20023] Password recovery should be case insensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Dilan Johnpullé changed: What|Removed |Added CC||di...@calyx.net.au --- Comment #3 from Dilan Johnpullé --- Created attachment 79070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79070=edit Internal server error at opac-password-recovery.pl after applying patch After applying the patch, opac-password-recovery.pl resolves at a screen complaining of an internal server error. Restarting plack, apache and memcached does not resolve this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||di...@calyx.net.au --- Comment #2 from Dilan Johnpullé --- Ran into issue trying to apply: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21158 Bug 21158 - Add cronjob references to the system preference descriptions if a cronjob is required 77484 - Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required /home/vagrant/kohaclone/.git/rebase-apply/patch:184: trailing whitespace. - "NOTE: This system preference requires the misc/cronjobs/holds/build_holds_queue.pl cronjob. Ask you system administrator to schedule it." warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref :184: trailing whitespace. - "NOTE: This system preference requires the misc/cronjobs/holds/build_holds_queue.pl cronjob. Ask you system administrator to schedule it." warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Failed to merge in the changes. Patch failed at 0001 Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21158-Add-cronjob-references-to-the-system-pre-0j9bCi.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21375] NCIP service for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 Amit Gupta changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21375] New: NCIP service for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 Bug ID: 21375 Summary: NCIP service for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng...@gmail.com QA Contact: testo...@bugs.koha-community.org NCIP service for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21375] NCIP service for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 Amit Gupta changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #19 from M. Tompsett --- Changing to signed off, since it didn't get marked as such, even though it is clear that it was. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #5 from Nick Clemens --- Created attachment 79069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79069=edit Bug 21364: (follow-up) Tidy indentation and remove copy/paste newlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 ByWater Sandboxes changed: What|Removed |Added Attachment #77725|0 |1 is obsolete|| --- Comment #18 from ByWater Sandboxes --- Created attachment 79068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79068=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13272] Many inputs lack a type attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13272] Many inputs lack a type attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 --- Comment #5 from M. Tompsett --- Comment on attachment 79018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79018 Bug 13272: Adds type="text" to inputs missing it Review of attachment 79018: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13272=79018) - ::: koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc @@ +59,4 @@ > > Add manual restriction > > +Comment: type="text" id="rcomment" name="comment" type="text" /> Oops... duplicate type. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +225,5 @@ > [% END %] > > > Hold expires on date: > + / type="text" > Oops... type="text" /> -- Though I don't think it is necessary (HTML5 vs XML thing, I believe) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #44 from Josef Moravec --- Created attachment 79064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79064=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #47 from Josef Moravec --- Created attachment 79067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79067=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #46 from Josef Moravec --- Created attachment 79066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79066=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #45 from Josef Moravec --- Created attachment 79065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79065=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #43 from Josef Moravec --- Created attachment 79063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79063=edit Bug 20819: DBIx schema changes No test plan. Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec changed: What|Removed |Added Attachment #78779|0 |1 is obsolete|| Attachment #78781|0 |1 is obsolete|| Attachment #78783|0 |1 is obsolete|| Attachment #78784|0 |1 is obsolete|| Attachment #78788|0 |1 is obsolete|| Attachment #79059|0 |1 is obsolete|| --- Comment #42 from Josef Moravec --- Created attachment 79062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79062=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21374] Self registration e-mail verification does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21374] Self registration e-mail verification does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 --- Comment #1 from Josef Moravec --- Created attachment 79061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79061=edit Bug 21374: Fix self registration verification Test plan: 0) Do not apply the patch 1) Set PatronSelfRegistration to Allow 2) Set PatronSelfRegistrationVerifyByEmail to Require 3) Try to create a account using self registration and verify it (use link in e-mail or take the url from table mesage_queue ;) The verificatin url return ISE - DBIx::Class::Row::store_column(): No such column 'timestamp' on Koha::Schema::Result::Borrower 4) Apply the patch 5) Try to acces the verification url again - now it should work Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 Michal Denar changed: What|Removed |Added Attachment #77781|0 |1 is obsolete|| --- Comment #3 from Michal Denar --- Created attachment 79060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79060=edit Bug 21215: Saved SQL reports code improvements The saved SQL reports code is a bit warty, so improve it: Instead of using the same code in multiple places to split the SQL move that code into the Guided.pm module. Add several tests for parameter substitution and SQL validation. Make it much easier to add more parameter types for substitution. Test plan: 1) Run your saved SQL reports and check that they work correctly 2) Create new SQL reports and check that the parameters are queried correctly. 3) Prove the t/db_dependent/Reports/Guided.t Signed-off-by: Pasi Kallinen Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21374] Self registration e-mail verification does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 Josef Moravec changed: What|Removed |Added Assignee|oleon...@myacpl.org |josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21374] Self registration e-mail verification does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 Josef Moravec changed: What|Removed |Added Blocks||20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21374] New: Self registration e-mail verification does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 Bug ID: 21374 Summary: Self registration e-mail verification does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org To reproduce: Set PatronSelfRegistration to Allow Set PatronSelfRegistrationVerifyByEmail to Require Try to create a account using self registration and verify it (use link in e-mail or take the url from table mesage_queue ;) The verificatin url return ISE - DBIx::Class::Row::store_column(): No such column 'timestamp' on Koha::Schema::Result::Borrower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec changed: What|Removed |Added Depends on||21374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 [Bug 21374] Self registration e-mail verification does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec changed: What|Removed |Added Attachment #78786|0 |1 is obsolete|| --- Comment #41 from Josef Moravec --- Created attachment 79059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79059=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Blou changed: What|Removed |Added Attachment #78566|0 |1 is obsolete|| --- Comment #3 from Blou --- Created attachment 79058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79058=edit Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 --- Comment #4 from M. Tompsett --- Created attachment 79057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79057=edit Bug 21349: Change cardnumber to borrowernumber The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added Attachment #78835|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Comment on attachment 78835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78835 Fix RemoveInstructor function Counter patch incoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | --- Comment #2 from M. Tompsett --- The patch submitted by Eric Phetteplace applies, but does not solve the problem. I created a user with the barcode of "Ka-boom:Ka-boom!KABOOM@#$!", and was not able to remove the user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082
--- Comment #6 from M. Tompsett ---
Comment on attachment 77056
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77056
Bug 21082: Update OverDrive authentication method
Review of attachment 77056:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21082=77056)
-
::: opac/svc/overdrive
@@ +45,4 @@
> eval {
> {
> $action eq 'login' && do {
> +my $password = $cgi->param("password") // "" ;
Not a real issue, but q{} is perlcritic friendlier. Even '' would be better
than "".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082
--- Comment #5 from M. Tompsett ---
Comment on attachment 77053
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77053
Bug 21082: Database updates
Review of attachment 77053:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21082=77053)
-
::: installer/data/mysql/sysprefs.sql
@@ +415,4 @@
> ('OverDriveClientKey','','Client key for OverDrive integration','30','Free'),
> ('OverDriveClientSecret','','Client key for OverDrive
> integration','30','YesNo'),
> ('OverDriveLibraryID','','Library ID for OverDrive
> integration','','Integer'),
> +('OverDrivePasswordRequired','',NULL,'Does the library require passwords for
> OverDrive SIP authentication','Free'),
Shouldn't 'Free' be 'YesNo'?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #172 from M. Tompsett --- git grep repeatable_holidays -- there are still references to this dropped table. Similar issues exist with the other dropped table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21298] Reopening a basket, the dates reset for date ordered and thus affect the late orders report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21298 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 John Sterbenz changed: What|Removed |Added CC||jster...@umich.edu --- Comment #2 from John Sterbenz --- 20180918: Failed testing Patch applied to master on (new) Bywater sandboxes. Verify fail: Apply patch to master As necessary, create and appropriate a budget As necessary, create and appropriate a fund within that budget As necessary, create a vendor As necessary, create a basket Select "Add to basket" Select "From a new (empty) record: ERROR: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt line 783: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 122 This also fails for Z39.50 cataloging record selection--perform search, pick a record from results list, click "Order"--same error. Untested for other "Add order to basket" methods. See https://drive.google.com/open?id=1jWM6wIoUTcu5CSQYeGJaYj_V2uIwZLjM (anyone with link can view)--files include a longer version that first replicated the problem. The steps above skip the replication on a system with the patch applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Blou changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #23 from Blou --- Created attachment 79056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79056=edit Bug 17385: Add tests for CustomXSLTExportList + Added tests for CustomXSLTExportList to C4::XSLT + Added an eval block in CustomXSLTExportList to handle invalid XML. * Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent + Added "Custom" option to OPACExportOptions preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Blou changed: What|Removed |Added Attachment #74661|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Blou changed: What|Removed |Added Attachment #74660|0 |1 is obsolete|| --- Comment #22 from Blou --- Created attachment 79055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79055=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley https://bugs.koha-community.org/show_bug.cgi?id=17835 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 --- Comment #10 from Jane Sandberg --- Thanks for your help, Jonathan! This was fun. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sand...@linnbenton.edu |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 --- Comment #9 from Jonathan Druart --- Great first patches Jane, congrats! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 --- Comment #8 from Jonathan Druart --- Created attachment 79054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79054=edit Bug 13406: (follow-up) Add styling classes to authority MARC detail display Signed-off-by: Jane Sandberg Amended patch: replace tab characters with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Jonathan Druart changed: What|Removed |Added Attachment #78999|0 |1 is obsolete|| Attachment #79026|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 79053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79053=edit Bug 13406: Add styling classes to authority MARC detail display When viewing authority MARC records in the staff client (detail view), the MARC tags were not displaying with the tag_num, tag_desc, tag_ind1, tag_ind2, and desc classes, which made it impossible to add styles to these specific parts of a MARC tag. This commit adds these styles (which are the same as the classes in the bibliographic MARC detail display). To test: 1) Open the staff client, then click Authorities. 2) Search for an authority record. 3) Click on Details. 4) Examine some MARC fields. Note that the entire tag title line is in a single . 5) Apply this commit. 6) Repeat steps 1-3. 7) Notice that the tag title line is now separated into several spans, each with their own classes. Signed-off-by: Jane Sandberg Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |colin.campbell@ptfs-europe. |y.org |com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What|Removed |Added Assignee|colin.campbell@ptfs-europe. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 --- Comment #6 from M. Tompsett --- My counter patch does NOT apply on top of the first patch. Choose one, sign it off. Obsolete both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |colin.campbell@ptfs-europe. |y.org |com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 --- Comment #5 from M. Tompsett --- Created attachment 79052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79052=edit Bug 20929: Create and Use CNF file Rather than have hostname, username, and passwords on the command line, visible with a ps, use a CNF file so that mysqldump knows them more securely. TEST PLAN -- 1) start kohadevbox 2) reset_all 3) sudo systemctl deamon-reload 4) git bz apply 20929 -- choose just this patch 5) restart_all 6) perl /home/vagrant/misc4dev/cp_debian_files.pl 7) sudo koha-dump kohadev 8) ls -la /var/spool/koha/kohadev -- there is a koha-dump.cnf file with rw owner only perms 9) sudo cat /var/spool/koha/kohadev/koha-dump.cnf -- the host, username, and password should match what are in the koha-conf.xml file. 10) zcat the backup to make sure the backup has meaningful data in it. BONUS TEST: Change the kohadev DB password, make the koha-conf.xml file match, confirm your kohadev still works, and that a retest has the new username/password in the koha-dump.cnf file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Andrew, did you notice the empty button (with and without the patch): https://snag.gy/9PQ5yL.jpg on /cgi-bin/koha/ill/ill-requests.pl?method=illview_id=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added Attachment #74549|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 79051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79051=edit Bug 20548: Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21362] Advanced MARC Editor - Rancor - Tab navigation not working in fixed fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21362
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #4 from Jonathan Druart
---
Ere, can you add a test plan please? I have linked a control field to AV but I
do not see the dropdown list.
Also I think the following change is wrong:
-if ( ( this.nodeName.toLowerCase() == 'select' &&
e.which == 9 ) || e.ctrlKey ) {
+if ( e.ctrlKey && 0 ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18506] Shibboleth SSO Only Mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #5 from Martin Renvoize --- Rebased and made requested corrections. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18506] Shibboleth SSO Only Mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 Martin Renvoize changed: What|Removed |Added Attachment #62810|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 79050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79050=edit BUG 18506 - Add xShibOnly preference for shibboleth This patch adds two system preferences to Koha, opacShibOnly and staffShibOnly, allowing users to restrict authentication to just one method, Shibboleth. A system preference was chosen over a configuration file update to allow for local override at the virtualhost level. In this way a hosting provider can setup a 'backdoor opac' for example to allow fallback to local logins for support operations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Alex Arnaud --- Hello, I've rebased the first two patches. Also i provide a third one that prove what Nick said is right and a fourth one that fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 --- Comment #11 from Alex Arnaud --- Created attachment 79049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79049=edit Bug 19945: Use CanItemBeReserved in ILSDI HoldItem instead of CanBookBeReserved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What|Removed |Added Attachment #75688|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 79046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79046=edit Bug 19945: ILSDI - Return the reason a reserve is impossible Currently, the ILDSI services HoldTitle and HoldItem always return a "NotHoldable" code is the reserve is impossible. We need to know why Test plan: - Apply this patch - Place a hold on a non reservable title using ILS-DI web service (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1_location=) - you should get the reason instead of NotHoldable, - Place a hold on a non reservable item using ILS-DI web service (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=1_id=1_id=1) - you should get the reason instead of NotHoldable, Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 --- Comment #10 from Alex Arnaud --- Created attachment 79048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79048=edit Bug 19945: Add a test proving that using CanBookBeReserved in ILSDI::HoldItem is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What|Removed |Added Attachment #75689|0 |1 is obsolete|| --- Comment #9 from Alex Arnaud --- Created attachment 79047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79047=edit Bug 19945: (follow-up) optimization and test correction The double call to CanItemBeReserved was pointless in the C4/Reserves.pm HoldItem, as CanBookBeReserved calls CanItemBeReserved and even returns that code. Additionally, the tests failed, because there were 5 tests not 4. TEST PLAN -- prove t/db_dependent/ILSDI_Services.t run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #202 from Josef Moravec --- Created attachment 79045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79045=edit Datatables Also the datatables are not working perfectly, you should probably use KohaTable instead of pure DataTable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #201 from Josef Moravec ---
Comment on attachment 79039
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79039
Bug 10662 - Build OAI-PMH Harvesting Client
Review of attachment 79039:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10662=79039)
-
Hi David,
thanks for your great job!
There are still some issues which I think should be solved to make this part of
master
::: Koha/Daemon.pm
@@ +1,2 @@
> +package Koha::Daemon;
> +
there is missing POD in this package
::: Koha/OAI/Harvester.pm
@@ +1,2 @@
> +package Koha::OAI::Harvester;
> +
there is missing POD for some methods in this package
@@ +29,5 @@
> +use DateTime;
> +use DateTime::Format::Strptime;
> +
> +use C4::Context;
> +use Koha::Database;
You should use Koha::Object[s] based classes not Koha::Database itself
@@ +114,5 @@
> +my $active_tasks =
> $poe_kernel->call("harvester","list_tasks","active");
> +my @active_uuids = map { $_->{uuid} } @$active_tasks;
> +
> +my $schema = Koha::Database->new()->schema();
> +my $rs = $schema->resultset('OaiHarvesterImportQueue')->search({
You should create and use class based on Koha::Object - could be something like
Koha::OAI::Harvester::ImportQueue[s] in this case
@@ +311,5 @@
> +sub reset_imports_status {
> +my ($self, $kernel, $heap, $session) = @_[OBJECT, KERNEL,HEAP,SESSION];
> +
> +my $schema = Koha::Database->new()->schema();
> +my $rs = $schema->resultset('OaiHarvesterImportQueue')->search({
Use Koha::Object[s]
@@ +421,5 @@
> +my ($self,$uuid) = @_;
> +my $count = undef;
> +if ($uuid){
> +my $schema = Koha::Database->new()->schema();
> +my $items = $schema->resultset('OaiHarvesterImportQueue')->search({
Use Koha::Object[s]
@@ +443,5 @@
> +my $schema = Koha::Database->new()->schema();
> +my @tasks = ();
> +foreach my $uuid (sort keys %{$heap->{tasks}}){
> +my $task = $heap->{tasks}->{$uuid};
> +my $items = $schema->resultset('OaiHarvesterImportQueue')->search({
Use Koha::Object[s]
@@ +594,5 @@
> +}
> +
> +#Step Three: stop pending imports for this task
> +my $schema = Koha::Database->new()->schema();
> +my $items = $schema->resultset('OaiHarvesterImportQueue')->search({
Use Koha::Object[s]
@@ +625,5 @@
> +$kernel->call($session,"stop_task",$task_uuid);
> +
> +#Step Two: delete pending imports in database
> +my $schema = Koha::Database->new()->schema();
> +my $items = $schema->resultset('OaiHarvesterImportQueue')->search({
Use Koha::Object[s]
::: Koha/OAI/Harvester/Client.pm
@@ +1,2 @@
> +package Koha::OAI::Harvester::Client;
> +
There is missing POD in this package
::: Koha/OAI/Harvester/Downloader.pm
@@ +95,5 @@
> +return;
> +}
> +}
> +
> +=head2 OpenXMLStream
the method is called "GetXMLStream"
@@ +167,5 @@
> +return;
> +}
> +}
> +
> +sub ParseXMLStream {
Missing POD
@@ +244,5 @@
> +warn "ParseXMLStream() requires a 'file_handle' argument.";
> +}
> +}
> +
> +sub harvest {
missing POD
::: Koha/OAI/Harvester/Import/MARCXML.pm
@@ +1,1 @@
> +package Koha::OAI::Harvester::Import::MARCXML;
There is missing pod in this package
::: Koha/OAI/Harvester/Import/Record.pm
@@ +26,5 @@
> +
> +use C4::Context;
> +use C4::Biblio;
> +
> +use Koha::Database;
use Koha::Object[s] based classes please
@@ +164,5 @@
> +my ($self, $args) = @_;
> +my $record_type = $args->{record_type} // "biblio";
> +my $link_id;
> +if ($record_type eq "biblio"){
> +my $link = $schema->resultset('OaiHarvesterBiblio')->find(
Use Koha::Object[s]
::: Koha/OAI/Harvester/Listener.pm
@@ +1,1 @@
> +package Koha::OAI::Harvester::Listener;
Missing POD in this package
::: Koha/OAI/Harvester/Request.pm
@@ +46,5 @@
> +sub _type {
> +return 'OaiHarvesterRequest';
> +}
> +
> +sub validate {
Please add POD for this sub
::: Koha/OAI/Harvester/Worker.pm
@@ +1,1 @@
> +package Koha::OAI::Harvester::Worker;
There is missing POD in this package
::: Koha/OAI/Harvester/Worker/Download/Stream.pm
@@ +1,1 @@
> +package Koha::OAI::Harvester::Worker::Download::Stream;
There is missing POD in this package
::: Koha/OAI/Harvester/Worker/Import.pm
@@ +1,1 @@
> +package Koha::OAI::Harvester::Worker::Import;
There is missing POD in this package
::: installer/data/mysql/atomicupdate/bug_10662.sql
@@ +10,5 @@
> + PRIMARY KEY (`import_oai_biblio_id`),
> + UNIQUE KEY `oai_record` (`oai_identifier`,`oai_repository`) USING BTREE,
> + KEY `FK_import_oai_biblio_1` (`biblionumber`),
> + CONSTRAINT `FK_import_oai_biblio_1` FOREIGN KEY (`biblionumber`)
> REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE NO ACTION
> +) ENGINE=InnoDB AUTO_INCREMENT=1 DEFAULT CHARSET=utf8
> COLLATE=utf8_unicode_ci;
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #298 from Martin Renvoize --- Rebased on current master.. also remember there are scss changes in here so you'll need to follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client to test it fully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #78408|0 |1 is obsolete|| --- Comment #297 from Martin Renvoize --- Created attachment 79044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79044=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #78406|0 |1 is obsolete|| --- Comment #295 from Martin Renvoize --- Created attachment 79042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79042=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #78407|0 |1 is obsolete|| --- Comment #296 from Martin Renvoize --- Created attachment 79043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79043=edit Bug 11897: Add Boolean handling to dbic classes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #78405|0 |1 is obsolete|| --- Comment #294 from Martin Renvoize --- Created attachment 79041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79041=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #78404|0 |1 is obsolete|| --- Comment #293 from Martin Renvoize --- Created attachment 79040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79040=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Jonathan Druart from comment #3) > We should create a .my.cnf, but this is much better than passing the > password in the options. I agree. The environment variable is documented here: https://dev.mysql.com/doc/refman/5.5/en/environment-variables.html Let me attempt a counter-patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21373] New: Checkout not possible when biblio level hold but other items could satisfy it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21373 Bug ID: 21373 Summary: Checkout not possible when biblio level hold but other items could satisfy it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Assume following 1. There is bib record with 5 items available 2. Patron A makes a bib level hold for the record Now we try to checkout one item from the bib record for patron B Result: I get a warning menu saying that this item is on hold Expected result: I can proceed with the checkout and no warnings come unless there are no available items, i.e., biblio level hold number <= items available. I refactored the C4/Circulation.pm a bit so that we can use the code from CanBookBeRenewd function to make the checkout work the same way as it is possible with renewals, i.e. renewals are possible even if there is a biblio level hold and some other available item that can satisfy the loan. I will send this patch ASAP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #149 from David Gustafsson --- I will also try to have a look whether the structure of auto-suggest "input"-fields is correct or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #148 from David Gustafsson --- If bug 19707 was to be accepted into Koha, new mappings could also be added that way, even if automatic syncing comes with it's own problems (old mappings are not purged since can't differentiate between those and those added by end user). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Andreas Hedström Mace changed: What|Removed |Added Attachment #78914|0 |1 is obsolete|| --- Comment #200 from Andreas Hedström Mace --- Created attachment 79039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79039=edit Bug 10662 - Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. Signed-off-by: Andreas Hedström Mace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Andreas Hedström Mace changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Björn Nylén changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
