[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Attachment #79687|0 |1 is obsolete|| --- Comment #34 from paxed --- Created attachment 79803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79803=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the host detail view in staff client or OPAC, with clickable links to the component records. Host has no linking entries to the components, but the components link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds a Yet Another System Preference, ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'. Except if UseControlNumber syspref is on, then it looks only for the Host field 001. Does not use easyanalytics. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||severine.que...@bulac.fr Status|ASSIGNED|In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #2 from Jonathan Druart --- Created attachment 79802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79802=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #1 from Jonathan Druart --- Created attachment 79801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79801=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17876] Show more invoice information in subscription details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17876 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17876] Show more invoice information in subscription details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21467 --- Comment #4 from Jonathan Druart --- I will try to provide an attempt on bug 21467 to answer this need. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] New: Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Bug ID: 21467 Summary: Allow several receipts for a given subscription Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea would be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #105 from Alex Buckley --- Created attachment 79800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79800=edit Bug 8367: Removed unneccessary warns and commented code Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #104 from Alex Buckley --- Created attachment 79799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79799=edit Bug 8367: Template fixes + fixes to C4/Reserves.pm and Koha/Hold.pm Fixed waitingreserves.tt template so the borrowernumber is successfully passed to waitingreserves.pl upon cancelling a hold, so users can now successfully cancel holds from the waitingreserves.pl interface. Removed check for ReserveMaxPickupdateDelay in Koha/Hold.pm as this syspref is removed in the previous patch. Instead the expirationdate is calculated the same way as the lastpickupdatedate that is retrieving the holdpickupwait value for the appropriate issuingrule and then adding that onto the waiting date. Same test plan as main patch Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #103 from Alex Buckley --- Created attachment 79798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79798=edit Bug 8367: How long is a hold waiting for pickup at a more granular level You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. The lastpickupdate-column is set based on the given instruction and lands only on an open library day. Also cancel_expired_reserves.pl now cancels only on open library days after the last pickup date has expired. And waitingreserves.pl respects the new DB column. If ReservesMaxPickUpDelay is not set prior to the databaseupdate, the holdspickupwait-directive is never defined, thus disabling this feature until the holdspickupwait is set. If the issuingrules holdspickupwait is 0 or less, this feature is disabled. So each issuingrule can disable this feature for the material it matches, while being fully functional with other rules. This patch adds: - a new column in the issuing rules, including help topics. - a new column reserves.lastpickupdate (+old_reserves) It contains the waitingdate + the corresponding "holds pickup wait". Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupwait - a new function C4::Reserves::MoveWaitingdate() to help in testing this feature. - a new function C4::Reserves::GetLastPickupDate() to calculate the proper date from Calendar. This patch removes: - the ReservesMaxPickUpDelay syspref. - the ExpireReservesOnHolidays syspref, because it became obsolete due to the changes in handling the last pickup date with Koha Calendar. - Also removes a code section from C4::Letters::_parseLetter() which worked blatantly disrespectfully towards Koha Calendar. - TODO figure out how to rename existing letter placeholders <> with <> Unit tests included. $ $ TEST PLAN $ $ 0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF 'ReservesMaxPickUpDelay' is bigger than 0. Otherwise existing reserves won't get UPDATEd with the new lastpickupdate-values. ** ** *** *** *** TEST: BASIC WORKFLOW * ** ** 1. Check there is no regression with a normal reserve workflow. 2. Add one or more issuingrules. 3. Update the new column 'Holds pickup wait' in your issuing rules. 4. In the 3 templates of staff client, you can see the 'Last pickup date' for an hold (circ/circulation.pl, circ/waitingreserves.pl, members/moremember.pl) 5. In opac-user.pl the last pickup date is displayed in the status-column if available. 5. According to a library and an item type, the lastpickupdate value will be equal to the waiting date + the "holds pickup wait" defined moved to the next open library day. ** ** *** *** *** TEST: LETTER PLACEHOLDER (no code modifications here, just regression)* ** ** 1. Modify the RESERVESLIP->email Letter. Add "Last pickup date<>" somewhere. 2. Make a hold for a borrower. 3. Catch the hold and print the reserve slip. Verify that the lastpickupdate is actually the (current date + the 'Holds pickup wait' in your issuing rules) in days. ** ** ** ** ** ** *** *** *** TEST: RESPECTING CALENDAR HOLIDAYS * ** ** ** ** ** ** 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a single, unrepeated, holiday. Then make the next day a weekly repeating holiday. Then make the next two days an annual holiday repeatable every year. 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be increased by four days. ** ** ** ** ** ** *** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION * ** ** ** ** ** ** 1. Modify the HOLD-letter, add <> and <> somewhere. 2. Catch a hold for a borrower. 3. See the members/notices.pl for the message queued and verify that the lastpickupdate-placeholder is set in your desired datetime format and that it is not on a holiday. Verify that the waitingdate is today. Conflicts: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley changed: What|Removed |Added Attachment #79791|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley changed: What|Removed |Added Attachment #79790|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #79796|0 |1 is obsolete|| --- Comment #61 from Aleisha Amohia --- Created attachment 79797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79797=edit Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #10 from Nick Clemens --- Created attachment 79795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79795=edit Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #60 from Aleisha Amohia --- Created attachment 79796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79796=edit Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #9 from Nick Clemens --- Created attachment 79794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79794=edit Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #8 from Nick Clemens --- Created attachment 79793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79793=edit Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens changed: What|Removed |Added Attachment #77053|0 |1 is obsolete|| Attachment #77054|0 |1 is obsolete|| Attachment #77055|0 |1 is obsolete|| Attachment #77056|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 79792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79792=edit Bug 21082: Database updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #102 from Alex Buckley --- Created attachment 79791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79791=edit Bug 8367: Template fixes + fixes to C4/Reserves.pm and Koha/Hold.pm Fixed waitingreserves.tt template so the borrowernumber is successfully passed to waitingreserves.pl upon cancelling a hold, so users can now successfully cancel holds from the waitingreserves.pl interface. Removed check for ReserveMaxPickupdateDelay in Koha/Hold.pm as this syspref is removed in the previous patch. Instead the expirationdate is calculated the same way as the lastpickupdatedate that is retrieving the holdpickupwait value for the appropriate issuingrule and then adding that onto the waiting date. Same test plan as main patch Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley changed: What|Removed |Added Attachment #42754|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #101 from Alex Buckley --- Created attachment 79790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79790=edit Bug 8367: How long is a hold waiting for pickup at a more granular level You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. The lastpickupdate-column is set based on the given instruction and lands only on an open library day. Also cancel_expired_reserves.pl now cancels only on open library days after the last pickup date has expired. And waitingreserves.pl respects the new DB column. If ReservesMaxPickUpDelay is not set prior to the databaseupdate, the holdspickupwait-directive is never defined, thus disabling this feature until the holdspickupwait is set. If the issuingrules holdspickupwait is 0 or less, this feature is disabled. So each issuingrule can disable this feature for the material it matches, while being fully functional with other rules. This patch adds: - a new column in the issuing rules, including help topics. - a new column reserves.lastpickupdate (+old_reserves) It contains the waitingdate + the corresponding "holds pickup wait". Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupwait - a new function C4::Reserves::MoveWaitingdate() to help in testing this feature. - a new function C4::Reserves::GetLastPickupDate() to calculate the proper date from Calendar. This patch removes: - the ReservesMaxPickUpDelay syspref. - the ExpireReservesOnHolidays syspref, because it became obsolete due to the changes in handling the last pickup date with Koha Calendar. - Also removes a code section from C4::Letters::_parseLetter() which worked blatantly disrespectfully towards Koha Calendar. - TODO figure out how to rename existing letter placeholders <> with <> Unit tests included. $ $ TEST PLAN $ $ 0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF 'ReservesMaxPickUpDelay' is bigger than 0. Otherwise existing reserves won't get UPDATEd with the new lastpickupdate-values. ** ** *** *** *** TEST: BASIC WORKFLOW * ** ** 1. Check there is no regression with a normal reserve workflow. 2. Add one or more issuingrules. 3. Update the new column 'Holds pickup wait' in your issuing rules. 4. In the 3 templates of staff client, you can see the 'Last pickup date' for an hold (circ/circulation.pl, circ/waitingreserves.pl, members/moremember.pl) 5. In opac-user.pl the last pickup date is displayed in the status-column if available. 5. According to a library and an item type, the lastpickupdate value will be equal to the waiting date + the "holds pickup wait" defined moved to the next open library day. ** ** *** *** *** TEST: LETTER PLACEHOLDER (no code modifications here, just regression)* ** ** 1. Modify the RESERVESLIP->email Letter. Add "Last pickup date<>" somewhere. 2. Make a hold for a borrower. 3. Catch the hold and print the reserve slip. Verify that the lastpickupdate is actually the (current date + the 'Holds pickup wait' in your issuing rules) in days. ** ** ** ** ** ** *** *** *** TEST: RESPECTING CALENDAR HOLIDAYS * ** ** ** ** ** ** 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a single, unrepeated, holiday. Then make the next day a weekly repeating holiday. Then make the next two days an annual holiday repeatable every year. 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be increased by four days. ** ** ** ** ** ** *** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION * ** ** ** ** ** ** 1. Modify the HOLD-letter, add <> and <> somewhere. 2. Catch a hold for a borrower. 3. See the members/notices.pl for the message queued and verify that the lastpickupdate-placeholder is set in your desired datetime format and that it is not on a holiday. Verify that the waitingdate is today. Conflicts: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Status|Patch doesn't apply |ASSIGNED --- Comment #100 from Alex Buckley --- Hi there I have gone through and rebased this, master had progressed quite a lot since this patch was added and so I had to make a few assumptions during the rebase. Please let me know if changes need to be made as a result of the rebase. I have also corrected the commit messages to the format 'Bug : ' I have also written two other patches which correct template issues, and remove the check for the value of the 'ReserveMaxPickupDelay' syspref in Koha/Hold.pm in the set_waiting() function. This check is unneccessary as the main patch on this bug report removes the ReserveMaxPickupDelay syspref, and so I replaced this with a retrieval of the appropriate issuingrule and setting the exprationdate = waitingdate + issuingrule.lastpickupwait I am currently working on the unit tests t/db_dependent/Hold.t and so I am assigning this the status of 'Assigned' until I have attached a commit with the corrected t/db_dependent/Hold.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #260 from Nick Clemens --- (In reply to Jonathan Druart from comment #259) > A new check to catch missing filters is not in the QA script, please update! s/not/now/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21462] "Filter paid transactions" stopped working after html-table was changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21403] Add Indian Amazon Affiliate option to AmazonLocale setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21403 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21429] Switch two-column templates to Bootstrap grid: Reports part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21429 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21428] Switch two-column templates to Bootstrap grid: Reports part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21428 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21430] Switch two-column templates to Bootstrap grid: Reports part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21430 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21176] decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly updated on partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #134 from Nick Clemens --- (In reply to Jonathan Druart from comment #133) > Created attachment 79752 [details] [review] > Bug 17602: Add missing html filters Followup pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #45 from Nick Clemens --- (In reply to Nick Clemens from comment #44) > Created attachment 79789 [details] [review] > Bug 18639: (follow-up) Remove debugging code Followup pushed to master, thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #44 from Nick Clemens --- Created attachment 79789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79789=edit Bug 18639: (follow-up) Remove debugging code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > Another thing to check: Is cn_source set correctly in all items? It's easy > to have some bad configuration there. I was thinking that as well but in my case the items seemed to all have cn_source set correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #43 from Jonathan Druart --- Debugging leftover in finishreceive.pl +warn "Replacement $replacementprice"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21176] decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Chris Cormack changed: What|Removed |Added Attachment #79326|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 79788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79788=edit Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21176] decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Chris Cormack changed: What|Removed |Added Attachment #79710|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 79787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79787=edit Bug 21448: Fix copy repeated subfields when linking an authority with 6xx The reported issue was: On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" Error in the logs: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. We should pass a ref (!), caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Test plan: Edit an authority and add several $x to 600 Link this authority to a bibliographic record => Without this patch only the first subfield is copied => With this patch applied they are all copied Signed-off-by: José Anjos Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Jonathan Druart changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 --- Comment #1 from Jonathan Druart --- (In reply to Katrin Fischer from bug 21010 comment #6) > (In reply to Jonathan Druart from bug 21010 comment #5) > > Bug 21466 - Data inconsistencies - items.location values must have a > > corresponding authorised value > > What if they are not mapped to LOC? I think I remember patches to display as > is in this case a while ago (Biblibre?) The mapping for items.location, depending on the framework, must be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #38 from Christopher Brannon --- I've accepted the alternative patch as the better way to go. This patch will depend on fixing AuthorisedValues.pm, per our discussion, to display the code if a description doesn't exist. That will have to be fixed before this is pushed. :/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #79684|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #37 from Christopher Brannon --- Created attachment 79786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79786=edit Bug 18355: Remove obsolete code from pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21010] Add a script to search for data inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- (In reply to Jonathan Druart from comment #5) > Bug 21466 - Data inconsistencies - items.location values must have a > corresponding authorised value What if they are not mapped to LOC? I think I remember patches to display as is in this case a while ago (Biblibre?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21010] Add a script to search for data inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 Jonathan Druart changed: What|Removed |Added Depends on||21466 --- Comment #5 from Jonathan Druart --- Bug 21466 - Data inconsistencies - items.location values must have a corresponding authorised value Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Jonathan Druart changed: What|Removed |Added Blocks||21010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 [Bug 21010] Add a script to search for data inconsistencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] New: Data inconsistencies - items.location values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Bug ID: 21466 Summary: Data inconsistencies - items.location values must have a corresponding authorised value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz See bug 18355. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Jonathan Druart changed: What|Removed |Added Severity|major |critical --- Comment #9 from Jonathan Druart --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 --- Comment #8 from Jonathan Druart --- Created attachment 79785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79785=edit Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons Template process failed: undef error - DBIC result _type isn't of the _type Borrower at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 54. Koha::Old::Checkout->patron should return undef if the patron record has been removed. Test plan: - Check 2 items out on the same bibliographic record - Check them in - Delete the patron's record of one of the issuer (Is this word really exist?) - View the checkout history for this bib record (Home › Catalog › Checkout history) => Without this patch you get the error => With this patch applied one of the "Patron" cells will be empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #36 from Christopher Brannon --- I also did a restart just to be sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #35 from Christopher Brannon --- Yes. I checked for my mods and they are not there. Just yours. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #7 from Katrin Fischer --- (In reply to Séverine Queune from comment #6) > Great enhancement Katrin ! > Thanks a lot ! Thx for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #25 from Katrin Fischer --- This bug here is for learning, not about solving it all :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Text to go in the|This feature integrates |This feature integrates release notes|RecordedBooks functionality |RecordedBooks functionality |into the catalog, following |into the catalog, following |the model of OverDrive. |the model of OverDrive. || |Searches on the opac will |Searches on the OPAC will |return a link to results in |return a link to results in |the RecordedBooks catalog |the RecordedBooks catalog |if they are found. From |if they are found. From |that results pagea user |that results page a user |that is signed in and has a |that is signed in and has a |valid email matching a |valid email matching a |RecordedBooks account will |RecordedBooks account will |be able to checkout the |be able to checkout the |books directly from the |books directly from the |results, and download them |results, and download them |via their account page on |via their account page on |the opac. Users will also |the OPAC. Users will also |be able to place holds on |be able to place holds on |unavailable items. |unavailable items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Jonathan Druart changed: What|Removed |Added Blocks||21432 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 [Bug 21432] Internal Server Error in Checkout History -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Jonathan Druart changed: What|Removed |Added Depends on||20899 --- Comment #7 from Jonathan Druart --- Caused by commit 3c65318243de786bdc11d9ad335a253d59754d74 Bug 20899: Fix patron's name display Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 [Bug 20899] Patron name not showing on issuehistory.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21432] Internal Server Error in Checkout History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 Jonathan Druart changed: What|Removed |Added Version|18.05 |master Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #6 from Jonathan Druart --- Confirmed on master if a patron has been removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15971] Allow use of all biblio and biblioitems fields (like issn) in serial claim letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 --- Comment #6 from Katrin Fischer --- Yay! Thx all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15139] Show non-public item note in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15139] Show non-public item note in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Jonathan Druart changed: What|Removed |Added Attachment #79034|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 79784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79784=edit Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays Signed-off-by: Spencer Signed-off-by: Jonathan Druart Amended patch: remove the branchcode line, added on its own bug report, see bug 21463 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Jonathan Druart changed: What|Removed |Added Blocks||15139 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 [Bug 15139] Show non-public item note in overdues report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15139] Show non-public item note in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Jonathan Druart changed: What|Removed |Added Depends on||21463, 21464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 [Bug 21463] Library is not longer displayed in the overdue list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 [Bug 21464] Overdues export is missing lot of fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21463] Library is not longer displayed in the overdue list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21463] Library is not longer displayed in the overdue list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 Jonathan Druart changed: What|Removed |Added Blocks||15139 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 [Bug 15139] Show non-public item note in overdues report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
--- Comment #63 from Josef Moravec ---
Comment on attachment 79759
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79759
Bug 11373: Show the difference between the amount collected and the amount paid
of a fine payment.
Review of attachment 79759:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11373=79759)
-
Great job, just one little thing, reading the code only:
::: members/paycollect.pl
@@ +194,4 @@
> patron=> $patron,
> total => $total_due,
> ExtendedPatronAttributes =>
> C4::Context->preference('ExtendedPatronAttributes'),
> +FineChange => C4::Context->preference('FineChange'),
Use Koha.Preference template plugin and do not pass system preferences as
template parameter
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #259 from Jonathan Druart --- A new check to catch missing filters is not in the QA script, please update! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 --- Comment #2 from Jonathan Druart --- Created attachment 79783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79783=edit Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21464] Overdues export is missing lot of fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 Jonathan Druart changed: What|Removed |Added Depends on||21463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 [Bug 21463] Library is not longer displayed in the overdue list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21463] Library is not longer displayed in the overdue list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 Jonathan Druart changed: What|Removed |Added Blocks||21464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 [Bug 21464] Overdues export is missing lot of fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #35 from Josef Moravec --- Created attachment 79782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79782=edit Bug 15520: (QA follow-up) Fix renaming of circ rules permission Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #34 from Josef Moravec --- Created attachment 79781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79781=edit Bug 15520: Rename permission to manage_circ_rules_from_any_libraries Signed-off-by: Lisette Scheer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec changed: What|Removed |Added Attachment #78735|0 |1 is obsolete|| Attachment #78736|0 |1 is obsolete|| --- Comment #33 from Josef Moravec --- Created attachment 79780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79780=edit Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Amended by JD: In a second version of this patch manage_circ_rules_restricted has been replaced by manage_circ_rules_from_any_libraries and 'no_inherit' related code has been removed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #9 from Caroline Cyr La Rose --- While testing bug 9775, I came upon a decimal problem in orderreceive.pl. I don't know if it's the same bug. This happens in the "Actual cost" box. To replicate: 1- Go to Acquisitions 2- Search for a Vendor 3- Click on "New basket" 4- Give basket a name and click "Save" 5- Click on "Add to basket" 6- Add an order through preferred method 7- In Accounting details, enter a vendor price with dot decimal (i.e. 19.44) 8- Save your order line 9- Click on "Close this basket" 10- Confirm closing of basket by clicking on "Yes, close" 11- Click on "Receive shipment" 12- Enter an invoice number and click "Next" 13- Click on "Receive" to the right of your order 14- In Accounting details, notice the Actual cost is written with a decimal dot. 15- Change the Actual cost, using a dot decimal (i.e. 20.99) 16- Receive the order 17- Click on "Save" 18- In "Already received" notice the price is multiplied by 100 (i.e. 2099,00) 19- Click on "Cancel receipt" 20- Click on "Receive" to the right of your order 21- In Accounting details, change the Actual cost, using a comma decimal (i.e. 20,99) 22- Receive the order 23- Click on "Save" 24- In "Already received", notice the price is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15139] Show non-public item note in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #36 from Josef Moravec --- (In reply to Owen Leonard from comment #35) > I agree that the responsive behavior of the page isn't perfect, but this bug > is intended to be an incremental change. I could live with this little issues, but what about my second point? Should be old-named yui-* classes be all removed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #34 from Jonathan Druart --- (In reply to Christopher Brannon from comment #33) > (In reply to Jonathan Druart from comment #31) > > Hi Christopher, > > I would suggest to move the display logic to the template for several > > reasons: > > - the pl logic from the first patch is not easy to read > > - not defined AV are handled properly by the template plugin > > (Koha::Template::Plugin::AuthorisedValues) > > - as we are going to reuse this logic, we will move it to an include file to > > avoid copy/paste > > > > Could you take a look at tell me what you think about it? > > Something funky is going on in your patch. item.location is resolving to a > description while item.permanent_location is resolving to a code. Thus, the > two can't be compared. Need to figure out where item.location is being > defined, because when I look at the table, the code is definitely being > stored in the table and not the description. Can you confirm you applied *only* the second patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #6 from Séverine Queune --- Great enhancement Katrin ! Thanks a lot ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Séverine Queune changed: What|Removed |Added Attachment #79554|0 |1 is obsolete|| --- Comment #5 from Séverine Queune --- Created attachment 79779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79779=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Caroline Cyr La Rose changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #139 from Josef Moravec ---
(In reply to Jonathan Druart from comment #121)
> Several things here:
>
> 1. I have reattached the patch in the correct order and add the
> signed-off-by lines for Lisette and Jesse (only last patch was signed off)
>
> 2. (In reply to Josef Moravec from comment #103)
> > Comment on attachment 78744 [details] [review] [review]
> > In the schema files I can see the foreign keys for branchcode, categorycode
> > and itemtype, but they aren't defined in db update nor kohastructure.sql.
> > But I think we want them.
>
> I have reworked the schema files (md5sum was wrong which caused the script
> to fail). Foreign keys have been added to both kohastructure.sql and atomic
> update file.
>
> 3.
> (In reply to Josef Moravec from comment #104)
> > Comment on attachment 78746 [details] [review] [review]
> > > +Koha::Hold - Koha Hold object class
> >
> > C & P mistake
>
> Fixed (x2)
>
> 4.
> > @@ +47,5 @@
> > > +my $categorycode = $params->{categorycode};
> > > +my $itemtype = $params->{itemtype};
> > > +my $branchcode = $params->{branchcode};
> > > +
> > > +croak q{No rule name passed in!} unless $rule_name;
> >
> > Please use Exception instead of croak
>
> Removed and exceptions are now thrown
>
> 5. Tests have been provided, finally!
Great job Jonathan, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #138 from Josef Moravec --- Created attachment 79778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79778=edit Bug 18887: (QA follow-up) Remove last occurences of old max_holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Caroline Cyr La Rose changed: What|Removed |Added Attachment #79211|0 |1 is obsolete|| --- Comment #7 from Caroline Cyr La Rose --- Created attachment 79777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79777=edit Bug 9775: Unitprice should be hidden when creating an order The actual cost box is effectively hidden from the order page. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #135 from Josef Moravec --- Created attachment 79774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79774=edit Bug 18887: Fix POD c/p issues Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #137 from Josef Moravec --- Created attachment 79776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79776=edit Bug 18887: Add tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #136 from Josef Moravec --- Created attachment 79775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79775=edit Bug 18887: Replace croak with exceptions Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #134 from Josef Moravec --- Created attachment 79773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79773=edit Bug 18887: Update existing schema files Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #133 from Josef Moravec --- Created attachment 79772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79772=edit Bug 18887: Add new schema file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #130 from Josef Moravec --- Created attachment 79769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79769=edit Bug 18887: Use get_effective_rule instead of search Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #132 from Josef Moravec --- Created attachment 79771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79771=edit Bug 18887: Add foreign keys Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #131 from Josef Moravec --- Created attachment 79770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79770=edit Bug 18887: Add 2 missing html filters Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #129 from Josef Moravec --- Created attachment 79768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79768=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
