[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #80 from Katrin Fischer --- A long journey - thx for your perseverance! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Attachment #80109|0 |1 is obsolete|| --- Comment #76 from Katrin Fischer --- Created attachment 80380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80380=edit Bug 8630: Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx==1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #79 from Katrin Fischer --- Created attachment 80383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80383=edit Bug 8630: (follow-up) Template corrections This patch makes two corrections to templates: One to correct the case of a variable, an error which I introduced when adding html filters. The other removes a redundant image tag from the recent comments template. To test, apply the patch and log in to the OPAC as a user with checkouts. Cover images on the "your summar" page should appear correctly. View the "recent comments" page and confirm that images still appear correctly. Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Attachment #80110|0 |1 is obsolete|| --- Comment #77 from Katrin Fischer --- Created attachment 80381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80381=edit Bug 8630: Adlibris covers (OPAC SCSS changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Attachment #80108|0 |1 is obsolete|| --- Comment #75 from Katrin Fischer --- Created attachment 80379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80379=edit Bug 8630: Adlibris covers (intranet CSS) This defined two new CSS classes for use by the intranet templates. Apply this patch before doing the testing of "intranet templates". Sponsored-By: Halland County Library Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #78 from Katrin Fischer --- Created attachment 80382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80382=edit Bug 8630: (follow-up) Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Attachment #80107|0 |1 is obsolete|| --- Comment #74 from Katrin Fischer --- Created attachment 80378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80378=edit Bug 8630: Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added Attachment #80106|0 |1 is obsolete|| Attachment #80245|0 |1 is obsolete|| Attachment #80246|0 |1 is obsolete|| --- Comment #73 from Katrin Fischer --- Created attachment 80377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80377=edit Bug 8630: Adlibris covers (syspref files) This patch adds a system preference for cover images from Swedish book retailer Adlibris. Images are retrieved via http or https from an external web server. This might leak OPAC and Staff interface data to third parties and should thus be used with caution. Sponsored-By: Halland County Library Test plan: Test 1: Test upgrade procedure for clean installation. Start by removing existing sysprefs, if present: $ mysql -u kohaadmin -p -D koha > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; * Apply this patch which will add a pref file, update the 'syspref' structure and add an atomic upgrade file. * Install the update: Koha$ perl installer/data/mysql/updatedatabase.pl * Once upgraded and logged in, Select 'More', 'Administration', 'Global Preferences' and finally 'Enhanced content'. There should be a new option called 'Adlibris'. The first option should default to "Don't show", if not the patch is broken. The second options should show the default URL: http://www.adlibris.com/se/organisationer/showimagesafe.aspx If not, the patch is broken. Test 2: Changing sysprefs * In the control panel, change the first value from "Don't show" to "Show" and save the changes. Use MySQL client to inspect changes: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; The column 'value' should now have the value '1', if not the patch is broken. Test 3: Apply update to existing data * Re-execute the installer now that the database has the data already: Koha$ perl installer/data/mysql/updatedatabase.pl If any errors occur the patch is broken. Examine the database contents: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; If the values were overwritten by the installer the patch is broken. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with two-branch library setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 --- Comment #13 from Katrin Fischer --- (In reply to Oliver Behnke from comment #12) > You could add "See also" refs to the Apache docs covering the expression I > used: > > https://httpd.apache.org/docs/2.4/mod/core.html#if > https://httpd.apache.org/docs/2.4/expr.html > > Also, could you please add the following in-line comments about Plack > integration, which is, AFAIK, optional. I also changed the user/pw > placeholders to match the existing wiki examples. > > > # Koha without Plack > SetEnv OVERRIDE_SYSPREF_AutoSelfCheckID "xyz" > SetEnv OVERRIDE_SYSPREF_AutoSelfCheckPass "abc" > > # Koha with Plack > # (commas must be escaped with '\') > RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_AutoSelfCheckID xyz" > RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_AutoSelfCheckPass abc" > > > HTH Hi Oliver, I didn't get to it yet. If you want, please feel free to edit the wikipage yourself! Account creation is moderated, so it might take a little bit to go through, but it's only an anti-spam measure and everyone is invited to contribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21319] Remove highlight and tooltip on Koha Team version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21319 Katrin Fischer changed: What|Removed |Added Summary|Remove highlight and|Remove highlight and |tooltip on Koha Team|tooltip on Koha Team |version.|version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group into a single line entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #3 from Alex Buckley --- Created attachment 80376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80376=edit Bug 21528: Single line for hold groups in intranet side Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group into a single line entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley changed: What|Removed |Added Attachment #80319|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de --- Comment #72 from Katrin Fischer --- Started here, will continue soon! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #173 from Charles Farmer --- I'll try another install with the patch already applied. Perhaps I've missed this last time because I was not using the kohadevbox. -- About repeatable_holidays, could you be more precise about the lingering references you've found? I've seen a lot of variables named that way, a few references to it in language files, which, to me, feel outside the scope of this POC, but nothing that would prevent someone from testing. I don't wanna misquote Jonathan's last comment, but this is more about gathering info about the feel of this implementation than ironing all the little details. If, however, you did find something that would prevent an enduser from testing this, don't hesitate to describe clearly which part is affected and I'll be happy to submit a follow-up fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21545] New: Update German web Installer for 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Bug ID: 21545 Summary: Update German web Installer for 18.11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The same procedure as every release...check sample files for missing values and translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21545] Update German web Installer for 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Katrin Fischer changed: What|Removed |Added Blocks||19588 Depends on|19588 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588 [Bug 19588] There is no ILL requests history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19588] There is no ILL requests history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588 Katrin Fischer changed: What|Removed |Added Depends on||7317 CC||katrin.fisc...@bsz-bw.de Blocks|7317| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Katrin Fischer changed: What|Removed |Added Attachment #80293|0 |1 is obsolete|| Attachment #80294|0 |1 is obsolete|| Attachment #80295|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 80373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80373=edit Bug 21174: Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #32 from Katrin Fischer --- Created attachment 80374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80374=edit Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS The 'Items in your cart' message is obsolete with the cart dropdown box being removed. Therefore the assignment of this text into the MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and the use of the MSG_IN_YOUR_CART variable in the updateBasket() function (in the OPAC's basket.js) has been removed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #33 from Katrin Fischer --- Created attachment 80375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80375=edit Bug 21174: (follow-up) Removed MSG_IN_YOUR_CART and its usage in OPAC JS Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #85 from Katrin Fischer --- i had missed one missing filter in my follow-up. As I signed off... can someone else QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What|Removed |Added Attachment #78297|0 |1 is obsolete|| --- Comment #84 from Katrin Fischer --- Created attachment 80372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80372=edit Bug 11297: (follow-up) Add html filter to new input field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #251 from Katrin Fischer --- Please also make sure to run the newest qa script on the code to check for missing filters! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #250 from Katrin Fischer --- Sorry, this no longer applies, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11708: Change aqbasketgroups.closed to closeddate Applying: Bug 11708: New page for basket groups fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11708: New page for basket groups The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11708-New-page-for-basket-groups-maTm2R.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #23 from Katrin Fischer ---
Can you please fix the issues pointed out by the QA script? I could fix the
filtes, but not sure about the first:
FAIL acqui/lateorders.pl
FAIL critic
# Variables::ProhibitUnusedVariables: Got 1 violation(s).
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
FAIL filters
missing_filter at line 84 ([%
lateorder.ordernumber %])
missing_filter at line 143 ()
missing_filter at line 144 ([% lateorder.isbn
%])
missing_filter at line 142 ()
missing_filter at line 269 (
$("#savenotes").after("
"+_("Loading")+"");)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20351] Implement blocking errors for serials scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351
Katrin Fischer changed:
What|Removed |Added
Attachment #78887|0 |1
is obsolete||
--- Comment #10 from Katrin Fischer ---
Created attachment 80371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80371=edit
Bug 20351: Shortcut serials scripts if a blocking error appeared
The idea of output_and_exit_if_error (added by bug 18403) is to make sure
parameters are valid before executing the script.
If not (old or broken URLs), we shortcut everything coming next to display a
generic error ("object does not exist", "you do not have permission to do
that", etc.)
This bug report fixes the scripts under serials/*.
Test plan:
Hit the script under the serials directory with an invalid subscriptionid
parameter
and confirm you get an error instead of the normal view with empty values.
The goal is not to be exhaustive during the first iteration, but at least to
fix
the most common views.
For instance:
/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=XXX
/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=XXX
/cgi-bin/koha/serials/routing.pl?subscriptionid=XXX=new
/cgi-bin/koha/serials/subscription-add.pl?op=modify=XXx
/cgi-bin/koha/serials/subscription-add.pl?op=dup=XXX
Signed-off-by: Séverine QUEUNE
Signed-off-by: Séverine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8000] Test mode for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8000] Test mode for notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou changed: What|Removed |Added Attachment #74848|0 |1 is obsolete|| --- Comment #146 from Blou --- Created attachment 80370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80370=edit Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal Signed-off-by: BWS Sandboxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21544] New: Self Check-in tool does not trigger holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21544 Bug ID: 21544 Summary: Self Check-in tool does not trigger holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 15492 Stand alone self Check-in Tool has been released into 18.05, however, if a book that has a hold on it gets returned through the stand alone self checkin tool, the hold does not trigger. There is no alert to the patron that this book needs to be brought to the circulation desk or prompt for any other direction. For libraries to use this self checkin tool, there needs to be some function/block that alerts the checkin with a hold to be different than a book with no hold. I tested, both bib level holds and item level holds were treated the same way, with no alert. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21291] request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21291] request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou changed: What|Removed |Added Attachment #79952|0 |1 is obsolete|| --- Comment #10 from Blou --- Created attachment 80369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80369=edit Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21543] New: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21543 Bug ID: 21543 Summary: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: marga...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The Advanced Notice (misc/cronjobs/advance_notices.pl) will try to send "advance notice of item due" phone notices which shouldn't be processed except by the Talking Tech Sending Notices File (misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl) In this case/to replicate: 1) A library is set up to use Advanced Notices and Talking Tech Sending/Receiving Notices File crons. 2) They want patrons to get advanced notice emails 7 days per week, but only get phone notices 5 days per week. 3) When Advanced Notices cron runs on those other two days it will try to send the "advance notice of item due phone notices" to Talking Tech, which fails because the i-tiva server is not making calls on that day. 4) The notices that Advanced Notice cron erroneously processed are forever stuck in pending status in the message queue. Can Advanced Notice cron be updated to not touch notices that are slated for processing by the Talking Tech Sending Notices File cron? TLDR: advance_notices.pl generates phone notices, these should only be generated by the talking tech crons. To recreate enable advanced messaging, set phone for advance notice for a patron and checkout an item that will trigger the notice, run advance_notices.pl, check the message queue and see a phone notice is pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #126 from Nick Clemens --- (In reply to Marcel de Rooy from comment #125) > One area did not have attention yet: > > C4/Budgets.pm needs similar adjustments: > Look at e.g. SUM( COALESCE(unitprice_tax_included, ecost_tax_included) * > quantity ) AS budget_spent > or SUM(ecost_tax_included * quantity) AS budget_ordered > > With the pref to nearest cent, the total ordered drops one cent, while it > should drop three cent (using your example where 78,83 becomes 78,80). > Can you point out some line numbers? I don't think I see where you are takling about? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20729] Update style of datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20729] Update style of datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard changed: What|Removed |Added Attachment #75232|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 80368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80368=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard changed: What|Removed |Added Attachment #75180|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 80367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80367=edit Bug 20260: Use CodeMirror for the SQL reports editor This patch adds CodeMirror syntax highlighting to the SQL reports editor. Newly added is a file containing the sql-specific syntax highlighting code, in both compressed and uncompressed versions. Unrelated changes: - Some JavaScript has been moved from inside the body of the page to the footer. - Paths to some assets have been corrected to no use relative paths. To test, apply the patch and go to Reports -> Saved SQL reports - Edit an existing report and confirm that the SQL is correctly highlighted and that there are no display problems when editing. - Confirm that changes are saved successfully. - Perform the same test when creating a new SQL report. - View an existing report and confirm that the SQL is syntax-highlighted but is read-only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #23 from Nick Clemens --- (In reply to jesus from comment #22) > Yep, no problem with searching even for other users: > > ou=Profesores,~ > grep cn=Profesor > CN=Profesor,OU=Profesores,DC=aulas,DC=campus,DC=local > ou=Profesores,~ > > > I'm even more concerned about the impossibility of login for local koha > users or even cached credentials. Are you still experiencing issues? So far all cases we have seen have been remedied by adding 0 and restarting memcached and apache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21541] HTML filter breaks HTML rendering of SQL output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21541] HTML filter breaks HTML rendering of SQL output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21541] HTML filter breaks HTML rendering of SQL output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541
--- Comment #1 from Nick Clemens ---
Created attachment 80366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80366=edit
Bug 21541: Use raw filter for report results
To test:
1 - Create new report
SELECT CONCAT('',"",firstname,"",surname,'')
AS people
FROM borrowers
2 - Run this report
3 - Note the results contain raw text, they are not hyperlinks
4 - Apply patch
5 - Reload the results
6 - They should now be links
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #21 from Martin Renvoize --- Sorry Josef, I think this also needs some minor updates to Koha::Account.. in particular near the bottom of the pay method, but I've not delved further yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17854] Print Slip and Close button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21541] HTML filter breaks HTML rendering of SQL output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311
--- Comment #5 from M. Tompsett ---
Comment on attachment 80352
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80352
Bug 21311: Remove locked message from opac-auth.tt
Review of attachment 80352:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21311=80352)
-
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
@@ +57,5 @@
> [% END %]
>
>
> +[% IF invalid_username_or_password ||
> too_many_login_attempts %]
> +
This is a very good security step.
@@ -62,5 @@
> -This account has been locked!
> -[% IF Koha.Preference('OpacResetPassword') %]
> - href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your
> password.
> -[% ELSE %]
> -Please contact a library staff member.
I think adding the "Please contact a library staff member if you continue to
have problems." would be a good idea.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115 M. Tompsett changed: What|Removed |Added Attachment #77256|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 80365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80365=edit Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart Resolve things like: CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. The cache key in both script looks like: opac:report:id:602018 but should for consistency be: opac:report:id:60:2018 Note: The 2018 here is part of the sql_params and should not be concatenated to the report id. Test plan: Do not yet apply this patch. Make a report public, set cache to 300 secs. Check its output with opac/svc/report. Check for the warn in your log. Apply the patch, restart Plack and flush cache. Check opac/svc/report. Modify your report; e.g. add a simple string to the SELECT. Check opac/svc/report. You should still see cached output. Flush the cache. Check opac/svc/report. You should now see the added text. Signed-off-by: Marcel de Rooy Tested also by clearing individual keys with $cache->clear_from_cache. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21082] OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens changed: What|Removed |Added Blocks||21542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 [Bug 21542] OverDrive password submission should use a password field to mask input -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21542] OverDrive password submission should use a password field to mask input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 Nick Clemens changed: What|Removed |Added Depends on||21082 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 [Bug 21082] OverDrive authentication method no longer supported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21542] OverDrive password submission should use a password field to mask input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 --- Comment #1 from Nick Clemens --- Created attachment 80364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80364=edit Bug 21542: Use modal and password field for overdrive password To test: 1 - Enabled Overdrive and fill all preferences 2 - Make sure OverDrivePasswordRequired is true 3 - Go to opac account 4 - Log in to overdrive 5 - Note the input is shown 6 - Apply patch 7 - Repeat 8 - Note popup is now a modal 9 - Note password is now hidden 10 - Confirm overdrive integration works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21542] OverDrive password submission should use a password field to mask input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21542] New: OverDrive password submission should use a password field to mask input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 Bug ID: 21542 Summary: OverDrive password submission should use a password field to mask input Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Enabled Overdrive and fill all preferences 2 - Make sure OverDrivePasswordRequired is true 3 - Go to opac account 4 - Log in to overdrive 5 - Note the input is shown in plain text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21541] New: HTML filter breaks HTML rendering of SQL output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 Bug ID: 21541 Summary: HTML filter breaks HTML rendering of SQL output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 13618 Many SQL reports use CONCAT to build hyperlinks into reports output. The current version of the template has an html filter on all report output. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard changed: What|Removed |Added Blocks||21541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 [Bug 21541] HTML filter breaks HTML rendering of SQL output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21540] New: Edit item/record pages don't show certain translations from po files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21540 Bug ID: 21540 Summary: Edit item/record pages don't show certain translations from po files Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: b.paster...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Created attachment 80363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80363=edit Edit record I have installed koha and my default language is english. I have additionally installed polish, french and ukrainian languages but when i switch to them in edit item/record page field/subfield names are not translated and items table has headers written in english. Most of those names are translated in corresponding .po files, but it still shows english text. Is there any way to solve this issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Josef Moravec changed: What|Removed |Added Attachment #80085|0 |1 is obsolete|| Attachment #80086|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 80360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80360=edit Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 --- Comment #5 from Josef Moravec --- Created attachment 80362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80362=edit Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 --- Comment #1 from Kyle M Hall --- Created attachment 80361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80361=edit Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] New: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Bug ID: 21539 Summary: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 --- Comment #1 from Nick Clemens --- Created attachment 80359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80359=edit Bug 21537: Fix itemtype processing To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Owen Leonard changed: What|Removed |Added Blocks||21537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 [Bug 21537] Regression: typo in acquisitions template processor name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard changed: What|Removed |Added Depends on||19289 Summary|Regression in #19289: typo |Regression: typo in |in acquisitions template|acquisitions template |processor name |processor name Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336
--- Comment #22 from M. Tompsett ---
Comment on attachment 80214
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80214
Bug 21336: Adjust cleanup_database.pl
Review of attachment 80214:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21336=80214)
-
::: misc/cronjobs/cleanup_database.pl
@@ +308,5 @@
> +Koha::Patrons->search_unsubscribed->lock({ expire => 1, remove => 1, verbose
> => $verbose });
> +# Anonymize patron data, depending on PatronAnonymizeDelay
> +Koha::Patrons->search_anonymize_candidates({ locked => 1 })->anonymize({
> verbose => $verbose });
> +# Remove patron data, depending on PatronRemovalDelay (will raise an
> exception if problem encountered
> +eval { Koha::Patrons->search_anonymized->delete({ verbose => $verbose }) };
Eval may mask output, which the user should see.
Though, I understand the use of eval, since the code should keep going.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Josef Moravec changed: What|Removed |Added Blocks||21538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538 [Bug 21538] Show ilbrary on account page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21538] Show ilbrary on account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538 Josef Moravec changed: What|Removed |Added Depends on||21401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 [Bug 21401] Account offsets should save the transacting library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression in #19289: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21312] Show lockout on Patrons form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21538] New: Show ilbrary on account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538 Bug ID: 21538 Summary: Show ilbrary on account page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As the bug 21401 enable saving branchcode for accountlines, we could want to show it on fines page too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #20 from Josef Moravec --- Created attachment 80358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80358=edit Bug 21401: Take transaction library from userenv when not defined Test plan: 1) Apply the patch 2) Run database update 3) prove t/db_dependent/Account.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #19 from Josef Moravec --- Created attachment 80357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80357=edit Bug 21401: Add tests for transaction_library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Josef Moravec changed: What|Removed |Added Attachment #79285|0 |1 is obsolete|| Attachment #79286|0 |1 is obsolete|| Attachment #79287|0 |1 is obsolete|| Attachment #79288|0 |1 is obsolete|| Attachment #79688|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 80355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80355=edit Bug 21401: Add column transaction_library to table account_offsets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #18 from Josef Moravec --- Created attachment 80356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80356=edit Bug 21401: DO NOT PUSH - schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21401] Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Andreas Roussos changed: What|Removed |Added CC||arouss1...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|Failed QA |ASSIGNED Assignee|n...@bywatersolutions.com |carn...@dgiinc.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Oliver Behnke changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21537 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] Regression in #19289: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Oliver Behnke changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19289 Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21537] New: Regression in #19289: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Bug ID: 21537 Summary: Regression in #19289: typo in acquisitions template processor name Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oliver.beh...@aei.mpg.de QA Contact: testo...@bugs.koha-community.org Hi, we just ran across the following error when creating a new book order based on a suggestion: > Template process failed: file error - options_for_itemtypes: not found at > /usr/share/koha/lib/C4/Templates.pm line 122 Investigating the problem I found a regression in #19289 where a new template processor called "options_for_item_types" got added to intranet-tmpl/prog/en/includes/html_helpers.inc. However, in intranet-tmpl/prog/en/modules/acqui/neworderempty.tt it's called as "options_for_itemtypes". Note the missing underscore in "itemtypes". Cheers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard changed: What|Removed |Added Attachment #79172|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 80354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80354=edit Bug 20970: Reformat basket information on acquisitions basket page This patch reformats the display of information on the acquisitions basket page, hiding form controls until they are triggered. Some basket information is now in the second column in order to balance the two columns better. The "Library" label has been replaced with the more precise "Managing library." Unrelated change: Removed script type attributes. To test, apply the patch and view a basket in acquisitions. Test these processes: - Adding and removing managing users - Setting and changing managing library - Setting and changing basket group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 --- Comment #2 from Mirko Tietgen --- Test plan: - have a system without Webservice::ILS available - in koha-shell, do prove t/Koha_ExternalContent_RecordedBooks.t - tests should be skipped and tests count as "passed" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Mirko Tietgen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17602 Depends on||17602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Mirko Tietgen changed: What|Removed |Added Blocks||21536 See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Blocks||21312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 [Bug 21312] Show lockout on Patrons form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21312] Show lockout on Patrons form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Marcel de Rooy changed: What|Removed |Added Depends on||21336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21312] Show lockout on Patrons form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Mirko Tietgen changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|ch...@bigballofwax.co.nz|mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 --- Comment #1 from Mirko Tietgen --- Created attachment 80353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80353=edit Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy changed: What|Removed |Added Severity|normal |major CC||dpav...@rot13.org Component|Architecture, internals,|Authentication |and plumbing| Patch complexity|String patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #4 from Marcel de Rooy --- Created attachment 80352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80352=edit Bug 21311: Remove locked message from opac-auth.tt We should not expose more information than needed when someone tries to login with invalid credentials. Saying that an account is locked reveals that the account exists (or perhaps an email address). Trivial fix. Keeping the var too_many_login_attempts for staff. Note: We do not remove this distinction for the staff client here (in the assumption that a library may well have additional security measures in place for staff client). But it could be done too (on another report). Test plan: Enable lockout feature. Enter invalid credentials until account locks out (on OPAC !!) Note that message does no longer change to 'Account is locked'. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
