[Koha-bugs] [Bug 15717] Installer: Step 3 has HTML tag br showing

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717

Katrin Fischer  changed:

   What|Removed |Added

Summary|Installer: Step 3 has  showing  |tag br showing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21592] When adding to basket from a file and using MarcFieldsToOrder items are not added to basket if missing funds

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21592

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21400] Cronjobs: processes exited with return code 1

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21400

Claudio  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||oleon...@myacpl.org

--- Comment #29 from Katrin Fischer  ---
Next time as a separate follow-up patch please! ;)

Looking at this again I have some issues, I am sorry to come up with this a
little lately :(

1) Usability
There is visual indicator to tell apart an already stored from a
changed/unsafed note. It's really easy to forget to press the button. 

If you happen to end your note with pressing "Enter" you trigger the error
message "No order selected"

It really doen't work well for notes that are longer than the input field is.
They don't display in full and it's hard to move around in the input field.

I think I'd like this much better following the existing design pattern with
links and a modal (see basket summary). I am adding Owen in hope he has time to
take a look.

2) Search
Searching on the notes column doesn't work.

3) Export
The notes are not exported, neither using the "Export as CSV" nor the new
"Excel" export at the bottom of the table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Katrin Fischer  ---
Hi Aleisha,

please make sure you always run the latest version of the QA tools from the
gitlab repository on your patches:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
   FAIL   filters
missing_filter at line 125 (   
View note)

I'd have fixed that, but there is another issue: The layout of the issuing rule
table is broken with this patch. The buttons at the end of the table are
misaligned. 
My entered note shows up in the last column labelled "Actions" as well, pushing
the buttons into another non-existing column... (looking at it this will
hopefully make more sense)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Andreas Roussos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Andreas Roussos  ---
(In reply to Katrin Fischer from comment #3)
> Thx Andreas!
No problem, typo-related patches and sign offs is where I'm more confident at.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

--- Comment #3 from Katrin Fischer  ---
Thx Andreas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Andreas Roussos  changed:

   What|Removed |Added

  Attachment #80965|0   |1
is obsolete||

--- Comment #2 from Andreas Roussos  ---
Created attachment 80967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80967=edit
Bug 21625: Fix wording and typo in SMSSendDriver system preference description

SMSSendDriver was missing an S.
Koha is sending not receiving messages, so I think switching
that will be a little more clear.

To test:
Verify that the system preference description reads correctly.

Signed-off-by: Andreas Roussos 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Andreas Roussos  changed:

   What|Removed |Added

 CC||arouss1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #257 from Katrin Fischer  ---
Patches apply, QA script is clean.

I am wondering about the changes to
koha-tmpl/intranet-tmpl/prog/js/datatables.js as well. Adding Owen, maybe he
has a moment to take a look at the datatables question here.

Jonathan, could you have another look at Julian's answers in comment#249?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

--- Comment #17 from Katrin Fischer  ---
Sorry for all the comments, I am just getting warmed up today it seems. 

I've decided to pass QA since the behaviour makes sense to me. I've tested an
acquisition order. When it's not yet received the amounts show in Ordered and
when you receive, the actual cost is shown in Spent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80704|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 80966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80966=edit
Bug 9775: Unitprice should be hidden when creating an order

The actual cost box is effectively hidden from the order page.

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

--- Comment #15 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #11)
> Do not we want to keep the value from the "last order received" for
> subscription?
> 
> -$data->{unitprice}  = $lastOrderReceived->{unitprice};
> 
> 
> You do not hide it, you removed it. Is it really what we want?

Martin, can you check this specific line? 

I agree with you on the workflow - actual cost is supposed to be set on
receiving/processing the invoice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #14 from Katrin Fischer  ---
Hm, checking the GUI it looks like I imagined the option to view? *scratches
head* So the change makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Katrin Fischer  ---
We have the option to view an already received order. I think it still makes
sense to display the value there to have complete information. 

I agree that entering it at ordering time doesn't make sense with the current
workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

--- Comment #1 from Katrin Fischer  ---
Created attachment 80965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80965=edit
Bug 21625: Fix wording and typo in SMSSendDriver system preference description

SMSSendDriver was missing an S.
Koha is sending not receiving messages, so I think switching
that will be a little more clear.

To test:
Verify that the system preference description reads correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21625] New: Fix wording and typo in SMSSendDriver system preference description

2018-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21625

Bug ID: 21625
   Summary: Fix wording and typo in SMSSendDriver system
preference description
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/