[Koha-bugs] [Bug 21701] New: Have PayPal return to originating OPAC url rather than OPACBaseURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21701 Bug ID: 21701 Summary: Have PayPal return to originating OPAC url rather than OPACBaseURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: techservs...@gmail.com QA Contact: testo...@bugs.koha-community.org We are part of a multi-library consortium that shares a single Koha server. Each of the member libraries has its own unique OPAC URL. When a patron pays a charge online, they are directed to PayPal. When the transaction is completed (or if the patron cancels the payment) they are redirected to the value of OPACBaseURL, not the URL from which the patron was using. This ends up with the ending up on a screen displaying a combination of all our OPACs together. We would like to have the ability to have the URL of the OPAC the patron is using be sent as the return url sent to PayPal. This could also be set up as a global option to use either the OPACBaseURL or the OPAC's individual's domain (for systems that would prefer to still use the current method). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21701] Have PayPal return to originating OPAC url rather than OPACBaseURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21701 David Kuhn changed: What|Removed |Added CC||techservs...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21700] New: Additional Patron information on purchase suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21700 Bug ID: 21700 Summary: Additional Patron information on purchase suggestions Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org A library has suggested that it would be helpful to view the card type of the patron when managing purchase suggestions. For instance, if an item is not going to be purchased, the library would attempt to ILL the item, but since not all patron categories are eligible for ILLs, knowing the patron category from the beginning of the review process would be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21647] Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Charles Farmer changed: What|Removed |Added Attachment #81132|0 |1 is obsolete|| --- Comment #4 from Charles Farmer --- Created attachment 81341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81341=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21647] Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21698] FIX POD of cancel_unfilled_holds.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 --- Comment #1 from Magnus Enger --- Created attachment 81340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81340=edit Bug 21698 - FIX POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21698] FIX POD of cancel_unfilled_holds.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17378] Add ability to specify maximum number of items per record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17378 Cori Lynn Arnold changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Pierre-Marc Thibault changed: What|Removed |Added Attachment #81321|0 |1 is obsolete|| --- Comment #3 from Pierre-Marc Thibault --- Created attachment 81339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81339=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Charles Farmer changed: What|Removed |Added Attachment #79263|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 81338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81338=edit Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves The cardnumber can contain strange non-javascript-friendly characters. This patch converts all the internal references to borrowernumber, but displays the cardnumber when showing list of matching users. TEST PLAN - 1) Make sure Course Reserves is being used. Check system preferences. 2) Make sure there is a Course entered. 3) Make sure there is a patron with an cardnumber which breaks the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) 4) Go into the course list. 5) Click the course name link 6) In the "Instructor Search" box enter the patron name. 7) Select the patron which has the ugly cardnumber. 8) Click Save -- The course listing should have the new teacher listed. 9) Click the course name link again. 10) Click 'Remove' beside the instructor's name. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 11) apply this patch 12) restart_all 13) sudo service apache2 restart 14) refresh the page. 15) click 'Remove' beside the instructor's name. -- name is removed. 16) Click Save -- the course listing no longer lists the new teacher. 17) Actually confirm that adding and removing others normally works as expected. 18) run koha qa test tools. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21349] Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21699] New: Allowing circulation Messages to be editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Bug ID: 21699 Summary: Allowing circulation Messages to be editable Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page. It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #35 from Nick Clemens --- (In reply to Andrew Isherwood from comment #34) > Did you definitely run the database update and regenerated the schema after > applying the bug? Sorry, I'm *sure* you did, but I thought it was worth > mentioning. Never be too sure - I can't recreate now either, moving back to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21698] New: FIX POD of cancel_unfilled_holds.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Bug ID: 21698 Summary: FIX POD of cancel_unfilled_holds.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: mag...@libriotech.no Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz - Description of some options in the SYNOPSIS section - Missing options - Use of a single dash for long options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21697] Free-floating subdivision cannot be manage correctly in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21697 Héctor Eduardo Castro Avalos changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=3313 Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3313] bulkauthimport.pl doesn't import MARC21 subdivision records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3313 Héctor Eduardo Castro Avalos changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21697 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21697] New: Free-floating subdivision cannot be manage correctly in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21697 Bug ID: 21697 Summary: Free-floating subdivision cannot be manage correctly in Koha Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org Koha doesn't have right authority frameworks to deal with free-floating subdivisions records 180, 181, 182, and, 185. These fields needs their own frameworks to work properly an to be searchable headings. When you prepare this kind of records in ISO2709 file and export them to Koha, Koha treat well as free-floating subdivisions but there aren't frameworks to deal with. So the heading are stored but not searchable. You can see this in module C4::AuthoritiesMarc lines 350-367 sub GuessAuthTypeCode { my ($record, $heading_fields) = @_; return unless defined $record; $heading_fields //= { "MARC21"=>{ '100'=>{authtypecode=>'PERSO_NAME'}, '110'=>{authtypecode=>'CORPO_NAME'}, '111'=>{authtypecode=>'MEETI_NAME'}, '130'=>{authtypecode=>'UNIF_TITLE'}, '148'=>{authtypecode=>'CHRON_TERM'}, '150'=>{authtypecode=>'TOPIC_TERM'}, '151'=>{authtypecode=>'GEOGR_NAME'}, '155'=>{authtypecode=>'GENRE/FORM'}, '180'=>{authtypecode=>'GEN_SUBDIV'}, '181'=>{authtypecode=>'GEO_SUBDIV'}, '182'=>{authtypecode=>'CHRON_SUBD'}, '185'=>{authtypecode=>'FORM_SUBD'}, }, NOTE: These records are not usable in biblio records but serves to librarians to take decision when creating complex-headings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 --- Comment #18 from Nick Clemens --- Created attachment 81337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81337=edit Bug 21526: (RM follow-up) Fix merge markers and a few extra filters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21634] "Circulation" option is lost when viewing patron's logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Pierre-Marc Thibault changed: What|Removed |Added Attachment #81335|0 |1 is obsolete|| --- Comment #4 from Pierre-Marc Thibault --- Created attachment 81336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81336=edit Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERSmodules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERSmodules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21634] "Circulation" option is lost when viewing patron's logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks||21678 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 Martin Renvoize changed: What|Removed |Added Depends on||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21673] Koha::Account::Lines->total_outstanding must be used when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 --- Comment #2 from Martin Renvoize --- Comment on attachment 81196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81196 Bug 21673: Use Koha::Account::Lines->total_amountoutstanding when needed Review of attachment 81196: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21673=81196) - ::: Koha/Account/Lines.pm @@ -46,4 @@ > sub total_outstanding { > my ( $self ) = @_; > > -my $total = sum0( $self->get_column('amountoutstanding') ); You've removed the only use of sum0, but not removed the List::Util import above ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Jonathan Druart changed: What|Removed |Added Depends on||21681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 [Bug 21681] Remove C4::Accounts::getcharges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added Blocks||21696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 [Bug 21696] Use Koha::Account->lines from Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21634] "Circulation" option is lost when viewing patron's logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21634] "Circulation" option is lost when viewing patron's logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Jonathan Druart changed: What|Removed |Added Attachment #81023|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 81335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81335=edit Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERSmodules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERSmodules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added Blocks|21696 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 [Bug 21696] Use Koha::Account->lines from Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Martin Renvoize changed: What|Removed |Added Depends on|21681 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 [Bug 21681] Remove C4::Accounts::getcharges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21634] "Circulation" option is lost when viewing patron's logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault --- There is a conflict when the patch is applied. A rebase is necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21695] Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 --- Comment #1 from Owen Leonard --- Created attachment 81334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81334=edit Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: /tmp/koha-public Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21695] Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- No brainer, works as expected :) Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Martin Renvoize changed: What|Removed |Added Attachment #81332|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 81333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81333=edit Bug 21696: Use Koha::Account->lines from Koha::Account There is now Koha::Account->lines, we should use it instead of Koha::Account::Lines->search Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #16 from Caroline Cyr La Rose --- I created a new vendor and set the tax parameters to "include tax" for both invoice price and list price. When I order an item from this vendor, hints are ok (tax inc.) But when I receive the same item from this vendor, the tax hints are wrong (tax exc.) Am I understanding what this is supposed to do? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 --- Comment #1 from Jonathan Druart --- Created attachment 81332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81332=edit Bug 21696: Use Koha::Account->lines from Koha::Account There is now Koha::Account->lines, we should use it instead of Koha::Account::Lines->search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Jonathan Druart changed: What|Removed |Added Blocks||21696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 [Bug 21696] Use Koha::Account->lines from Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added Blocks||21696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 [Bug 21696] Use Koha::Account->lines from Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Jonathan Druart changed: What|Removed |Added Depends on||21694, 21681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 [Bug 21681] Remove C4::Accounts::getcharges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 [Bug 21694] Add the Koha::Account->lines method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21673] Koha::Account::Lines->total_outstanding must be used when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 Jonathan Druart changed: What|Removed |Added Blocks||21696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 [Bug 21696] Use Koha::Account->lines from Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] New: Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Bug ID: 21696 Summary: Use Koha::Account->lines from Koha::Account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Jonathan Druart changed: What|Removed |Added Depends on||21673 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 [Bug 21673] Koha::Account::Lines->total_outstanding must be used when needed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added Attachment #81327|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 81331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81331=edit Bug 21681: Improve the account lines fetch Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added Attachment #81325|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 81329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81329=edit Bug 21681: Remove C4::Accounts::getcharges Test plan: 0) Do not apply the patch 1) Enable ILS-DI 2) Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=51_fines=1 use patron with some paid and unpaid fines 3) Save the page for later usage 4) Apply the patch 5) Repeat 2 with same patron and compare the saved result with the new one, they should be same 6) git grep getcharges should return no occurance 7) prove t/db_dependent/Accounts.t Co-authored-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added Attachment #81326|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 81330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81330=edit Bug 21681: Add tests for GetPatronInfo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Owen Leonard changed: What|Removed |Added Blocks||21695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 [Bug 21695] Clean up access files template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21695] Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Owen Leonard changed: What|Removed |Added Depends on||11317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 [Bug 11317] Add a way to access files from the intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Yup, tested and all works as expected still, code looks great after that golfing session and Jonthans added ILSDI tests too.. can't ask for more.. lets PQA it as there's now three QA team eyes here ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21685] Name our exceptions consistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685 Jonathan Druart changed: What|Removed |Added CC||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com Status|NEW |In Discussion --- Comment #1 from Jonathan Druart --- CCing some of you, how do you feel about that? Any good practices you have in mind? It would be good to have something on the wiki. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #15 from Martin Renvoize --- Loving the code golf here.. nice teamwork! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21695] New: Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Bug ID: 21695 Summary: Clean up access files template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/access_files.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 20654 The access files template has several issues which need to be cleaned up: - Bootstrap grid - Improve DataTables configuration - Markup corrections Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Owen Leonard changed: What|Removed |Added Depends on||21695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 [Bug 21695] Clean up access files template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #93 from Charles Farmer --- Removed the SQL script and based the new perl atomic update on skeleton.perl instead. Hope this came fast enough for 18.11 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #14 from Jonathan Druart --- I have squashed the first 2 patches (wrong manip), sorry Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #92 from Charles Farmer --- Created attachment 81328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81328=edit Bug 11297: (QA follow-up) Make the database update script idempotent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #12 from Jonathan Druart --- Created attachment 81326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81326=edit Bug 21681: Add tests for GetPatronInfo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added Attachment #81298|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 81325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81325=edit Bug 21681: Remove C4::Accounts::getcharges Test plan: 0) Do not apply the patch 1) Enable ILS-DI 2) Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=51_fines=1 use patron with some paid and unpaid fines 3) Save the page for later usage 4) Apply the patch 5) Repeat 2 with same patron and compare the saved result with the new one, they should be same 6) git grep getcharges should return no occurance 7) prove t/db_dependent/Accounts.t Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #13 from Jonathan Druart --- Created attachment 81327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81327=edit Bug 21681: Improve the account lines fetch Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 --- Comment #2 from Jonathan Druart --- Created attachment 81324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81324=edit Bug 21694: Keep the context Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 --- Comment #1 from Jonathan Druart --- Created attachment 81323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81323=edit Bug 21694: Add the Koha::Account->lines method Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added Attachment #81306|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added Attachment #81322|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Jonathan Druart changed: What|Removed |Added Blocks||21681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 [Bug 21681] Remove C4::Accounts::getcharges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||21694 --- Comment #10 from Jonathan Druart --- I will move the 2 last patches to their own bug report, see bug 21694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 [Bug 21694] Add the Koha::Account->lines method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] New: Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Bug ID: 21694 Summary: Add the Koha::Account->lines method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Koha::Account->lines will return a set of Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 --- Comment #4 from Josef Moravec --- (In reply to Tomás Cohen Arazi from comment #2) > I agree with the patch. But wouldn't you want to work on > Koha::Account::add_debit instead? :-D It would be definitely best solution, but "a bit" more work ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on|21680 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 [Bug 21680] Remove dead code C4::Accounts::fixaccounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21680] Remove dead code C4::Accounts::fixaccounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21681] Remove C4::Accounts::getcharges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #9 from Martin Renvoize --- Created attachment 81322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81322=edit Bug 21681: (follow-up) Add tests for Koha::Account->lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #431 from Nick Clemens --- (In reply to Nick Clemens from comment #430) > Created attachment 81316 [details] [review] > Bug 7143: Update about page for new devs Margaret Hade and Isobel Graham Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21680] Remove dead code C4::Accounts::fixaccounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21663] Incorrect filter prevents predefined notes from being added to patron acccounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21669] TT assignment statements must not be html filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21639] Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21635] Incorrect GROUP BY clause in batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21629] List sort on call number does not use cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21612] Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Incorrect GROUP BY clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #20 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21562] Sorting on checkout date is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #35 from Nick Clemens --- Exception rename pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #2 from Owen Leonard --- Created attachment 81321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81321=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 --- Comment #3 from Martin Renvoize --- I think there are plans afoot to add an add_debit method to Koha::Account and this if probably a prime candidate for using that method once it's there.. I'll check in with Tomas on the progress there.. but this patchset could be a good half way house if add_debit is further off than I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20758] Typo in BrowseResultSelection syspref description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20758 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work Isobel! Pushed to master for 18.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard changed: What|Removed |Added Attachment #81320|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/