[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81482|0 |1 is obsolete|| --- Comment #56 from Marcel de Rooy --- Created attachment 82058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82058=edit Bug 21336: Adjust cleanup_database.pl Add the new Patron routines to this cron job. Actions are performed only if preferences are set. Note: No specific command line flags for these actions are added here (and probably not needed too). So no crontab changes too. Test plan: Add a new patron. Enable GDPR_Policy and refuse consent on OPAC for this patron. Set only the first delay to zero (0) for immediate action. Run cleanup_database.pl --logs (or any other flag) for the first time. Check lock and expiration. Set the second delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the second time. Check anonymization. Set the third delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the third time. Check removal. Signed-off-by: Marcel de Rooy Amended: Added the warn $@ line in cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81483|0 |1 is obsolete|| --- Comment #57 from Marcel de Rooy --- Created attachment 82059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82059=edit Bug 21336: (follow-up) Fix last line after PatronRemovalDelay in pref file Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81480|0 |1 is obsolete|| --- Comment #54 from Marcel de Rooy --- Created attachment 82056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82056=edit Bug 21336: Introduce administrative lockout As a preparation for Koha::Patron->lock, we add the concept of administrative lockout. The account is locked just as it would have been by too much failed login attempts. This is handled by a negative value in borrowers.login_attempts. Test plan: Run t/db_dependent/Auth.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81481|0 |1 is obsolete|| --- Comment #55 from Marcel de Rooy --- Created attachment 82057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82057=edit Bug 21336: Search, lock and anonymize methods Add Koha::Patron->lock and anonymize. Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates and search_anonymized. And wrappers for lock and anonymize. Add unit tests. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81475|0 |1 is obsolete|| --- Comment #49 from Marcel de Rooy --- Created attachment 82051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82051=edit Bug 21336: Small adjustment in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81477|0 |1 is obsolete|| --- Comment #51 from Marcel de Rooy --- Created attachment 82053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82053=edit Bug 21336: DBIx changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81479|0 |1 is obsolete|| --- Comment #53 from Marcel de Rooy --- Created attachment 82055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82055=edit Bug 21336: Do not increase login_attempts after locking If an account has been locked, there is no use to keep increasing this number. It is not true too; after the pref number has been reached, we can not really speak of login attempts anymore. The credentials are just ignored. Adding a dbrev to put existing values in line. And a simple test in Auth.t to confirm that login_attempts stop increasing. Note: It feels safe to keep the '>=' condition in account_locked. But it could obviously be changed to '=='. (Added a test for that.) Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all tests will pass when the pref is enabled (though disabled by default). Test plan: Run dbrev with updatedatabase.pl. Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Auth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81476|0 |1 is obsolete|| --- Comment #50 from Marcel de Rooy --- Created attachment 82052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82052=edit Bug 21336: Database revision for borrowers.flgAnonymized This new flag should speak for itself ;) Test plan: Run installer or updatedatabase. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What|Removed |Added Attachment #81478|0 |1 is obsolete|| --- Comment #52 from Marcel de Rooy --- Created attachment 82054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82054=edit Bug 21336: Dbrev for new prefs This patch adds three new prefs: - UnsubscribeReflectionDelay - PatronAnonymizeDelay - PatronRemovalDelay Test plan: Run upgrade. Check patrons pref page. Look under Privacy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #72 from Martin Renvoize --- Ignore the subquery bit.. that doesn't apply here (though I'd still be interested in comparing that at some point) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #71 from Martin Renvoize --- Agreed, that test isn't testing what you think Marcel. The ->next is chained onto the resultset inside the loop in C4::Auth whereas the resultset is created outside of the loop in your test. I actually don't know which is faster, but I would imagine count is a bit faster and more memory efficient. Try moving the queries inside the loop and test again, I'd certainly be interested in the results. (a correlate subquery version might be interesting too) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21711] Remove $shib in Auth.t (17776 folllow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21711 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Marcel de Rooy --- (In reply to Nick Clemens from comment #4) > I don't get any instances in grep before this patch? Ah. This is foolish. It came from a patch set that is not pushed yet.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6988] formatted strings get split in substrings for translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6988 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi --- Comment #2 from paxed --- If there absolutely has to be HTML formatting in the middle of a sentence (eg. a link), one solution is to put the HTML elements in TT directives, so they don't split the sentence into separate msgid strings. For example: Click [% 'http://example.com;>' %]here[% '' %] to do whatever. Which should show up in the po-files as msgid "Click %shere%s to do whatever." (I didn't test the example, so it may not work. Putting the elements in TT variables, and using the variable, definitely does work) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11113] Title of pages are not easy to translate in some languages, especially in french
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi --- Comment #2 from paxed --- I have to agree with this - constructions like these (basically just concatenations) are very hard or even impossible to translate properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20281] Allow translating library names for notices/slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20281 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8023] Facebook share link not used current localization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Mikael Wilander changed: What|Removed |Added CC|vargavind+k...@gmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8023] Facebook share link not used current localization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6988] formatted strings get split in substrings for translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6988 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11113] Title of pages are not easy to translate in some languages, especially in french
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Mikael Wilander changed: What|Removed |Added CC||vargavind+k...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21715] Ease translation of account and account offset type descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21755] Show patron updated date in circ menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21719] Fix typos in codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21719 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21628] Simplify holds awaiting pickup report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21666] Advanced editor search- error is given for 'Unsupported Use attribute' when searching on title + author
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21666 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21433] Switch two-column templates to Bootstrap grid: Tools part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21433 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20486] Add --marc_conditions option to export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #134 from Nick Clemens --- (In reply to Nick Clemens from comment #133) > Created attachment 82050 [details] [review] > Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests Followup pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #133 from Nick Clemens --- Created attachment 82050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82050=edit Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #31 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #29) > Took a look at this one too. I think the intended behaviour is that when you > check the authorities checkbox, the list option is not offered as the lists > can only contain bibliographic records. That does work ok when you start at > the top, but when you've already switched to the list tab and then switch > from bibliographic to authority, your conf remains visible. Maybe needs a > little tweaking. Hi Katrin, I've spent a lot of time playing with different methods as specified here: https://api.jqueryui.com/tabs/ but haven't had any success in fixing this toggle issue. Do you have any tips or ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #36 from Christopher Brannon --- Finally. I think this was the best approach. Sorry for the number of changes. If someone thinks I need to create a test for the modification to C4/Circulation.pm, I can try to do that to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #35 from Christopher Brannon --- Created attachment 82049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82049=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21299] Move referer code from changelanguage to module in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #33 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21408] Inventory - Warn of items possibly scanned out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21408 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master Keywords||release-notes-needed --- Comment #132 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #68 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21711] Remove $shib in Auth.t (17776 folllow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21711 Nick Clemens changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- I don't get any instances in grep before this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21785] Add column configuration to hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 --- Comment #1 from Owen Leonard --- Created attachment 82046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82046=edit Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 82047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82047=edit Bug 19066: Tests for AddRenewal AddIssuingCharge and ChargeReserveFee This patch adds some tests that cover functions changed by this patchset. A bug in ChargeReserveFee is highlighted. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21785] Add column configuration to hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 82048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82048=edit Bug 19066: (QA follow-up) Fix ChargeReserveFee This patch fixes a bug in ChargeReserveFee: To test: - Run: $ kshell k$ prove t/db_dependent/Reserves.t => FAIL: Tests fail because branchcode is not set - Apply this patch - Run: k$ prove t/db_dependent/Reserves.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21785] Add column configuration to hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard changed: What|Removed |Added Depends on||21442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442 [Bug 21442] Switch two-column templates to Bootstrap grid: Circulation part 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21442] Switch two-column templates to Bootstrap grid: Circulation part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21442 Owen Leonard changed: What|Removed |Added Blocks||21785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 [Bug 21785] Add column configuration to hold ratios report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #46 from Tomás Cohen Arazi --- With Kyle's permission, I'm taking this one. I will complete the tests, so they cover all the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21785] New: Add column configuration to hold ratios report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Bug ID: 21785 Summary: Add column configuration to hold ratios report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/reserveratios.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I propose to add column configuration to the hold ratios report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 --- Comment #1 from Owen Leonard --- Created attachment 82045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82045=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] Clean up js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] Clean up js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 --- Comment #1 from Owen Leonard --- Created attachment 82044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82044=edit Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] Clean up js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Owen Leonard changed: What|Removed |Added Summary|Clean up js_includes|Clean up js_includes.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] New: Clean up js_includes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Bug ID: 21784 Summary: Clean up js_includes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Script type attributes should be removed from js_includes. CDATA markers can also be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Kelly D changed: What|Removed |Added CC||ke...@flo.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Katrin Fischer changed: What|Removed |Added Keywords||rel_18_11_candidate CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Blocks||21777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Katrin Fischer changed: What|Removed |Added Depends on||21775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 [Bug 21775] Lack of tests for audio alerts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Created attachment 82043 [details] [review] > Bug 21777: Add a regression test > > Signed-off-by: Jonathan Druart These tests will apply for master on top of bug 21775. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 --- Comment #3 from Jonathan Druart --- Created attachment 82043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82043=edit Bug 21777: Add a regression test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21783] New: Reindent admin/columns_settings.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Bug ID: 21783 Summary: Reindent admin/columns_settings.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org admin/columns_settings.tt was created with two-space indentation, but coding guidelines require 4. This patch will reindent the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #11 from Tomás Cohen Arazi --- I liked my patch because it was more clear to me. But as the author for the tests, I prefer Jonathan's approach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82009|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 82041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82041=edit Bug 21770: Add tests for html_entity Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 82042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82042=edit Bug 21770: Allow html_entity for href We certainly should not expect this filter to be used much for href, but we have one occurrence that needs it. Test plan: t/template_filters.t and xt/find-missing-filters.t must return green Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82008|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21413] Inventory - Allow skipping items with waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 82040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82040=edit Bug 21413: Fix condition to avoid operator bnding isssues The original WHERE condition wasn't enclosed in parenthesis, and hence was subject to binding precedence issues in some situations. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #70 from Jonathan Druart --- Marcel, use DBIC_TRACE=1 to understand what's going on. You are comparing 100 queries vs 1 query: 100 "SELECT COUNT" vs 1 "SELECT *" The ->next will return something only on first pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
--- Comment #69 from Marcel de Rooy ---
use Modern::Perl;
use Data::Dumper qw/Dumper/;
use Test::More tests => 1;
use Time::HiRes qw/time/;
use t::lib::Mocks;
use t::lib::TestBuilder;
use Koha::Patron::Consents;
my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;
$schema->storage->txn_begin;
subtest 'myTest' => sub {
plan tests => 2;
# Add 1000 consents
my $firstid;
foreach(1..100) {
my $consent = $builder->build_object({ class =>
'Koha::Patron::Consents' });
$firstid = $consent->borrowernumber if !$firstid;
}
my $set = Koha::Patron::Consents->search({ borrowernumber => $firstid });
#my $set = Koha::Patron::Consents->search;
my $t1 = time;
foreach(1..100) { my $i = $set->count; }
my $t2 = time;
is(1, 1, sprintf( "COUNT %6.4f\n", $t2 - $t1 ) );
$t1 = time;
foreach(1..100) { my $i = $set->next; }
#foreach(1..1000) { my $i = $set->next; #$set->_resultset->first unless $i;
}
$t2 = time;
is(1, 1, sprintf( "NEXT %6.4f\n", $t2 - $t1 ) );
};
$schema->storage->txn_rollback;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Marcel de Rooy changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- We need this enh still in 18.11 btw ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18303] Release team omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Marcel de Rooy changed: What|Removed |Added Depends on||21782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 [Bug 21782] Release team 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Marcel de Rooy changed: What|Removed |Added Blocks||18303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 [Bug 18303] Release team omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21782] New: Release team 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 Bug ID: 21782 Summary: Release team 18.11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
--- Comment #68 from Marcel de Rooy ---
my $set = Koha::Patron::Consents->search({ borrowernumber => $firstid });
#my $set = Koha::Patron::Consents->search;
my $t1 = time;
foreach(1..100) { my $i = $set->count; }
my $t2 = time;
is(1, 1, sprintf( "COUNT %6.4f\n", $t2 - $t1 ) );
$t1 = time;
foreach(1..100) { my $i = $set->next; }
#foreach(1..1000) { my $i = $set->next; #$set->_resultset->first unless $i;
}
$t2 = time;
is(1, 1, sprintf( "NEXT %6.4f\n", $t2 - $t1 ) );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
--- Comment #67 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #66)
> +my $consent = Koha::Patron::Consents->search({
> +borrowernumber => getborrowernumber($user),
> +type => 'GDPR_PROCESSING',
> +given_on => { '!=', undef },
> +})->next;
> +if( !$consent ) {
>
>
> ->count could have been better.
I tested that assumption a bit. And it seems not to be true in terms of
performance at least?
In short:
1.3480 sec for 1000 counts and 0.0094 for 1000 next's (on 1000 records).
It seems that DBIx goes to the db for each count but the repeated nexts are
handled much more efficiently (cache, prefetch, ..)?
Script fragment on next comment.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #76 from Michal Denar --- Please rebase on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #80468|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #81993|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78467|0 |1 is obsolete|| --- Comment #65 from Andrew Isherwood --- Created attachment 82036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82036=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78469|0 |1 is obsolete|| --- Comment #67 from Andrew Isherwood --- Created attachment 82038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82038=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #81992|0 |1 is obsolete|| --- Comment #68 from Andrew Isherwood --- Created attachment 82039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82039=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78465|0 |1 is obsolete|| --- Comment #63 from Andrew Isherwood --- Created attachment 82034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82034=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78466|0 |1 is obsolete|| --- Comment #64 from Andrew Isherwood --- Created attachment 82035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82035=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78468|0 |1 is obsolete|| --- Comment #66 from Andrew Isherwood --- Created attachment 82037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82037=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78464|0 |1 is obsolete|| --- Comment #62 from Andrew Isherwood --- Created attachment 82033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82033=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Andrew Isherwood changed: What|Removed |Added Attachment #78463|0 |1 is obsolete|| --- Comment #61 from Andrew Isherwood --- Created attachment 82032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82032=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger Works as advertised. Nice enh! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #134 from David Gustafsson --- Fixed too long foreign key length causing troubles with MariaDB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #81970|0 |1 is obsolete|| --- Comment #132 from David Gustafsson --- Created attachment 82030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82030=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle field to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #18 from Ere Maijala --- The latest version might actually work, at least to some extent. I still need to go through all the paths that have been changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #81971|0 |1 is obsolete|| --- Comment #133 from David Gustafsson --- Created attachment 82031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82031=edit Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle field to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #82027|0 |1 is obsolete|| --- Comment #17 from Ere Maijala --- Created attachment 82029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82029=edit Bug 11529: Use new biblio fields whenever possible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle field to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #82026|0 |1 is obsolete|| --- Comment #16 from Ere Maijala --- Created attachment 82028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82028=edit Bug 11529: Add new fields to biblio table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle field to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #82024|0 |1 is obsolete|| --- Comment #14 from Ere Maijala --- Created attachment 82026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82026=edit Bug 11529: Add new fields to biblio table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle field to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #82025|0 |1 is obsolete|| --- Comment #15 from Ere Maijala --- Created attachment 82027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82027=edit Bug 11529: Use new biblio fields whenever possible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
