[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #34 from Joonas Kylmälä --- Comment on attachment 74947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74947 Bug 15253: Add Koha::Logger based logging for SIP2 Review of attachment 74947: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15253=74947) - ::: C4/SIP/Sip.pm @@ +203,5 @@ > + : 'error'; > + > +my $message = @args ? sprintf($mask, @args) : $mask; > + > +C4::SIP::SIPServer::get_logger()->$method($message); I think C4::SIP::SIPServer::get_logger() should not be hard coded here because if the C4::SIP code is used from other parts of Koha like the intranet (yeah, I know this should not happen but think the same situation with some things in C4 being either just for OPAC or intranet) then instead of the log going to the intranet log it will go the sip server log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21913] Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21920] Create Form Letters (not automated)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21920 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I've certainly had a number of people ask for functionality like this, so I'm sure people would use it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21920] New: Create Form Letters (not automated)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21920 Bug ID: 21920 Summary: Create Form Letters (not automated) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org We should create customizable form letters (similar to notifications), that can be e-mailed or printed. These would not be automated, but letters that could be filled out by providing a patron barcode or patron list and then generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added Attachment #82755|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 82766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82766=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21405] Pagination in authorities search broken for Zebra and broken for 10000+ results in ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #12 from Heather --- Hi! I just wanted to chime in that as a cataloger, I want to thank everyone who is working on this bug! This bug is causing me a lot of extra work: I have to do all my authority searching in the public OPAC, then switch back to the staff client to search the authority record(s) in ways that I know they will be retrieved in order to edit, update, etc., or even just look at the MARC record in an efficient way. If I don't take all that time & forget to do all my searching in the public OPAC, then I run the risk of importing duplicate authority records, creating duplicate authority records, etc. My workflow to clean up our headings & authority file is not just impacted, but my workflow for every single title that I catalog is impacted, since every, single authority controlled access point requires searching the authority file in the OPAC...switching to staff client...etc., etc., etc. So my hearty thanks to all of you working to fix this bug--I'm cheering you on and really appreciate your efforts!! --Grateful librarian h2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED CC||cbran...@cdalibrary.org, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82762|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 82765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82765=edit Bug 21915: Add AccountAutoReconciliate syspref This syspref will be used to call the reconcile_balance routing as needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82763|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 82764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82764=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82762=edit Bug 21915: Add AccountAutoReconciliate syspref This syspref will be used to call the reconcile_balance routing as needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 82763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82763=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21918] Update buttons on fines to match newer buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #4 from Christopher Brannon --- (In reply to Owen Leonard from comment #3) > (In reply to Christopher Brannon from comment #2) > > Is there a reason we want to keep these links? > > The intention is to make the "cancel" option less visible. The primary > action is always going to be "Submit," and having a cancel link makes it > very clear which is which. Okay. Is there a reason we are not doing this on the modals? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #439 from Nick Clemens --- (In reply to Devinim from comment #438) > Created attachment 82744 [details] [review] > Bug 7143: Update about page for Nazlı Last two patches pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21736] Allow translating the localization widget messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21736 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21861] The MARC modification template actions editor does not always validate user input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21861 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21897] Typo in postinst
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21897 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21895] translations fail on upgrade to 18.11.00 (package installation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #27 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens --- Awesome work everyone! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21918] Update buttons on fines to match newer buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #3 from Owen Leonard --- (In reply to Christopher Brannon from comment #2) > Is there a reason we want to keep these links? The intention is to make the "cancel" option less visible. The primary action is always going to be "Submit," and having a cancel link makes it very clear which is which. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21919] Fast Add Cataloging UX Enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21919 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21919] Fast Add Cataloging UX Enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21919 Jessie Zairo changed: What|Removed |Added Summary|Fast Add UX Enhancements|Fast Add Cataloging UX ||Enhancements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14862] Upgrade jQuery from 1.7 to 1.8.x (or higher) in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 Owen Leonard changed: What|Removed |Added Blocks|10659 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 [Bug 10659] Upgrade jQuery star ratings plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21919] New: Fast Add UX Enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21919 Bug ID: 21919 Summary: Fast Add UX Enhancements Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jza...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 82761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82761=edit fast-add-example Enhancements to the Fast Add framework would help libraries efficiently enter both biblio and item level data to their record to get the record out and circulated as quickly as possible. Below is an example of what the form could present to the staff inputting the data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Depends on|14862 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 [Bug 14862] Upgrade jQuery from 1.7 to 1.8.x (or higher) in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Attachment #77740|0 |1 is obsolete|| Attachment #77741|0 |1 is obsolete|| --- Comment #17 from Owen Leonard --- Created attachment 82760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82760=edit Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. - Confirm that information about the plugin appears on the About page in the staff client, replacing the old star ratings plugin information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21918] Update buttons on fines to match newer buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #2 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > (In reply to Christopher Brannon from comment #0) > > change cancel links to buttons. > > "Cancel" is a link throughout the staff client. I think the only place where > there is inconsistency is some modals. Is there a reason we want to keep these links? If it is okay in the modals (and we can't do anything about the pop-up message buttons), should we change them to buttons for consistency? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20102] Remove attribute "text/css" for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 --- Comment #1 from Owen Leonard --- Created attachment 82759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82759=edit Bug 20102: Remove attribute "text/css" for
[Koha-bugs] [Bug 20102] Remove attribute "text/css" for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21918] Update buttons on fines to match newer buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #1 from Owen Leonard --- (In reply to Christopher Brannon from comment #0) > change cancel links to buttons. "Cancel" is a link throughout the staff client. I think the only place where there is inconsistency is some modals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21918] New: Update buttons on fines to match newer buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Bug ID: 21918 Summary: Update buttons on fines to match newer buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org Replace buttons with new buttons with font awesome, and change cancel links to buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21917] New: Payment type should not show on Write off selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21917 Bug ID: 21917 Summary: Payment type should not show on Write off selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org Payment type shows when you select Write off selected. Should not be a choice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21916] New: Add ability to specify where credits are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 Bug ID: 21916 Summary: Add ability to specify where credits are used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 18805 adds the ability to apply credits to fines, which is amazing! However, it'd be good if one could specify which fines to pay with a credit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #26 from Martin Renvoize --- The qa script throws an error: 'Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc line 84.' But, I think it's a false catch as .count numifies. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize changed: What|Removed |Added Attachment #82712|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 82758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82758=edit Bug 18805: Add ability to use up account credits This patch introduces a new button in the 'Pay fines' tab on the patron's account page. This button, labeled 'Normalize account' is only displayed when outstanding credits are available, that could be used to pay up existing debts. When clicking the button, the Koha::Account::normalize_balance method (bug 21896) is used for the purpose. To test: - Apply this patch (on top of 21896) - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than one) - Go to the 'Pay fines' tab => SUCCESS: No 'Apply credits' button is displayed. - On the 'create manual credit' tab, create a couple credits. - Go to the 'Pay fines' => SUCCESS: 'Apply credits' button is displayed - Click on 'Apply credits' => SUCCESS: Outstanding credits have been used to pay up debts. - Play with different options (credit excedes debts and vice-versa, they match, etc) => SUCCESS: They all work as expected - Sign off :-D Signed-off-by: Christopher Brannon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21913] Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21913] Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 --- Comment #1 from Owen Leonard --- Created attachment 82757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82757=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly - Confirm that the payments table only appears when there are payments to list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] New: Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Bug ID: 21915 Summary: Add a way to automatically reconcile balance for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 18805 introduced a way to use existing credits to cancel outstanding debts, from the staff interface. Most users expressed they want existing credits to be applied to outstanding debt, in an automatic way. We could add a syspref controlling this behaviour, and a cli script for people wanting all the balances reconciled at once, or nightly through a cronjob. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21914] New: Add preferences for default and requirement on payment type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21914 Bug ID: 21914 Summary: Add preferences for default and requirement on payment type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org The new payment type should have preferences to be required and a default setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Owen Leonard changed: What|Removed |Added Depends on||21913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 [Bug 21913] Clean up payment details page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial patch that works as expected.. going straight to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #2 from Katrin Fischer --- I think this would be nice for the detail pages maybe? I am not sure how it would like for the result list as we cannot provide a human-readable form of the search atm. Especially with translations in mind. Would you be opposed to remove the search bit from the page title as a first step? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 Martin Renvoize changed: What|Removed |Added Attachment #82709|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 82756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82756=edit Bug 21905: Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered The new plugin hook intranet_catalog_biblio_enhancements_toolbar_button is rendered useless due to the outputted html being escaped using the html filter. It should be using the raw filter instead. Test Plan: 1) Enable plugins 2) Download and install the latest version of the Kitchen Sink plugin https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.21/koha-plugin-kitchen-sink-v2.1.21.kpz 3) Browse to catalogue/detail.pl for a record 4) Note you see the raw html of the plugin output in the toolbar 5) Apply this patch 6) Restart all the things 7) Reload the page 8) Note the html is now correctly rendered as a button Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works as expected, Signing off.. With my QA hat on, it would be lovely to have a regression test for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works as expected and has tests.. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Martin Renvoize changed: What|Removed |Added Attachment #82741|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 82755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82755=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Martin Renvoize changed: What|Removed |Added Attachment #82743|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 82754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82754=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Martin Renvoize changed: What|Removed |Added Attachment #82747|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 82752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82752=edit Bug 21909: Make Koha::Account::outstanding_* preserve context This patch modifies the methods so they preserve the caller's context (list and scalar). To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: outstanding_credits and outstanding_debits tests fail - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: We are so happy now :-D - Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Nice catch, works as expected.. Signing Off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Martin Renvoize changed: What|Removed |Added Attachment #82748|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 82753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82753=edit Bug 21909: Add return type explanation to POD Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Martin Renvoize changed: What|Removed |Added Attachment #82746|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 82751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82751=edit Bug 21909: Unit tests This patch introduces regression tests for the behaviour to be introduced. Both outstanding_credits and outstanding_debits methods should return a Koha::Account::Lines object in scalar context, and a list of Koha::Account::Line objects in list context. To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: The current behaviour doesn't match the described Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Trivial patch to increase the test coverage.. straight to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Martin Renvoize changed: What|Removed |Added Attachment #82745|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 82750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82750=edit Bug 21912: Add tests for Koha::Objects->search This patch adds simple tests for the current behaviour. Specifically the return values in both scalar and list context. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] Show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 --- Comment #2 from Owen Leonard --- Created attachment 82749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82749=edit Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template. To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be enabled. - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] Show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 82748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82748=edit Bug 21909: Add return type explanation to POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 82747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82747=edit Bug 21909: Make Koha::Account::outstanding_* preserve context This patch modifies the methods so they preserve the caller's context (list and scalar). To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: outstanding_credits and outstanding_debits tests fail - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: We are so happy now :-D - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82746=edit Bug 21909: Unit tests This patch introduces regression tests for the behaviour to be introduced. Both outstanding_credits and outstanding_debits methods should return a Koha::Account::Lines object in scalar context, and a list of Koha::Account::Line objects in list context. To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: The current behaviour doesn't match the described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] Show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82745=edit Bug 21912: Add tests for Koha::Objects->search This patch adds simple tests for the current behaviour. Specifically the return values in both scalar and list context. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] New: Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 Bug ID: 21912 Summary: Koha::Objects->search lacks tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The 'search' method in Koha::Objects uses the context in which it was called to return either an iterator (in scalar context) or a list of singular objects, in list context. This behaviour should be covered by tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #438 from Devinim --- Created attachment 82744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82744=edit Bug 7143: Update about page for Nazlı -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Depends on||21910 Assignee|oleon...@myacpl.org |n...@bywatersolutions.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||kyle.m.h...@gmail.com, ||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Blocks||21911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 [Bug 21911] Scoping OPACs by branch does not work with new library groups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 --- Comment #1 from Nick Clemens --- Created attachment 82743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82743=edit Bug 21911: Fix OPAC scoping to work with new group system To test: 0 - Apply patch 1 - Create a library group enabled for opac search limits and add some libraries 2 - Check the DB (or advanced search dropdown) to get the id of the group (using 7 as example below) 3 - Add to apache configuration (OPAC virtualhost) SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7 SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:multibranchlimit-7" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" 4 - Ensure OpacAddMastheadLibraryPulldown is disabled 5 - Restart all the things 6 - Visit the opac 7 - Perform a search, confirm it is scoped to the branches in the group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Attachment #82740|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 82742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82742=edit Bug 21896: (QA follow-up) Document and Test for FIFO behaviour A short dicussion lead to the decision to make it explictly clear that this method will implicitly apply credits against debits in a 'First In First Out' manor, meaning oldest outstanding debits will be paid off first. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21911] New: Scoping OPACs by branch does not work with new library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21911 Bug ID: 21911 Summary: Scoping OPACs by branch does not work with new library groups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Previously one could scope an OPAC to a specific library group using lines as below in the apache configuration: SetEnv OPAC_SEARCH_LIMIT branch:HCC_GROUP SetEnv OPAC_LIMIT_OVERRIDE 1 RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT branch:HCC_GROUP" RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1" This does not work with the new groups system as the groups do not have codes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 --- Comment #1 from Nick Clemens --- Created attachment 82741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82741=edit Bug 21910: Koha::Library::Groups->get_search_groups should return the groups To test: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group 6 - Apply patch, restart all the things 7 - Visit staff and opac advanced search 8 - Confirm the group dropdowns are correct 9 - Enable OpacMastheadLibraryPulldown 10 - Ensure the dropdown on opac shows groups correctly 11 - Confirm earchign groups works from all three locations 12 - prove -v t/db_dependent/LibraryGroups.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 82739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82739=edit Bug 21896: (QA follow-up) Add tests for FIFO behaviour Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82738|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 82740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82740=edit Bug 21896: (QA follow-up) Document and Test for FIFO behaviour A short dicussion lead to the decision to make it explictly clear that this method will implicitly apply credits against debits in a 'First In First Out' manor, meaning oldest outstanding debits will be paid off first. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #20 from Martin Renvoize --- I've added a followup to document the FIFO behaviour of this function and a supplemental test to guarantee the current implicit behaviour. Otherwise, I like this now.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 --- Comment #19 from Martin Renvoize --- Created attachment 82738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82738=edit Bug 21896: (QA follow-up) Document and Test for FIFO behaviour A short dicussion lead to the decision to make it explictly clear that this method will implicitly apply credits against debits in a 'First In First Out' manor, meaning oldest outstanding debits will be paid off first. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Attachment #82720|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 82735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82735=edit Bug 21896: Add unit tests for Koha::Account::normalize_balance Signed-off-by: Christopher Brannon Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Attachment #82722|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 82737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82737=edit Bug 21896: (QA follow-up) normalize_balance -> reconcile_balance rename This was requested on the QA review and I agree. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Attachment #82721|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 82736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82736=edit Bug 21896: Add Koha::Account::normalize_balance This patch adds the normalize_balance() method to Koha::Account. Its purpose is to apply outstanding credits (i.e. manual ones ore remaining amounts like in the case of refunds) to outstanding debts. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Christopher Brannon Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21116] Add API routes through plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21116 --- Comment #15 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #14) > New feature not pushed to 17.11.x to encourage upgrade ;) I changed my mind, plugins are great, it does no harm to have this in 17.11.x I haded a followup to remove use of Koha::Exceptions::Exception that needs Bug 20590. Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21910] New: Koha::Library::Groups->get_search_groups should return the groups, not the children
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 Bug ID: 21910 Summary: Koha::Library::Groups->get_search_groups should return the groups, not the children Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate the issue: 1 - Add a library group (Admin->Library groups) 2 - Enable use as an opac and staff search limit 3 - Add some libraries to the group 4 - Visit advanced search on staff and opac 5 - Note the dropdown has as many empty rows as there are libraries in the group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #1 from Owen Leonard --- We could also look into providing Open Graph data for pages like search results, lists, details. http://ogp.me/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/