[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #12 from Josef Moravec --- This also should be one script with parameters --enable and --disable, as it is in other Koha debian commands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21923] Sort problem in some letters of Patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21923 --- Comment #4 from paxed --- (In reply to Jonathan Druart from comment #3) > As Pasi said it is expected and I would not consider it a bug. The "actual" bug/feature request is bug 20269 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #16 from David Cook --- (In reply to David Cook from comment #15) > I think the proper solution might be to refactor > C4::Circulation::CanBookBeRenewed and then maybe make a separate function > C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it > seems that different libraries have different needs/wants for autorenewal. That said, I don't have the resources to do this at present. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #15 from David Cook --- I think the proper solution might be to refactor C4::Circulation::CanBookBeRenewed and then maybe make a separate function C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it seems that different libraries have different needs/wants for autorenewal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #1 from Caroline Cyr La Rose --- It would be great for troubleshooting if the SQL query created by the wizard was available through a button on the page (like regular SQL reports). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21982] New: Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Bug ID: 21982 Summary: Circulation statistics wizard does not count deleted items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org A client noticed that deleted items are not counted in circulation stats when using the statistics wizard. Here is the test plan: 1) Search the catalog for a record with an available item 2) Loan out that item to a user and return it 3) Go in Reports > Statistics wizards > Circulation 4) Fill in the form - Choose a period that includes today - Choose "Type" = Checkout - Choose Item type for both "Row" and "Column" 5) Leave the rest as is and click "Submit" 6) Note the quantity of loans for the itemtype of your item 7) Go back to your item and delete it 8) Go back to your report and refresh 9) Notice that the amount of loans is less than it was before It's not because the item is deleted that the loan didn't happen The wizard should look at both items and deleted_items to calculate the amount of circulation transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jonathan Druart changed: What|Removed |Added Attachment #82877|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 83033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83033&action=edit Bug 21465: Don't throw duplicate userid error if userid belongs to the matched patron To test: 1 - Export your patrons a - Create a report 'SELECT * FROM borrowers' b - Run and save the report as csv (check your delimiter) c - Delete the borrowernumebr column 2 - Use the Patron Import tool to import the csv from above 3 - Set matching to 'cardnumber' 4 - Set 'If matching record is already in the borrowers table:' to Overwrite 5 - Import 6 - None are import because of matchign userid (their own) 7 - Apply patch 8 - Repeat 9 - Patrons are successfully overwritten 10 - prove -v t/db_dependent/Koha/Patrons/Import.t 11 - prove -v t/db_dependent/Koha/Patrons.t Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21465 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=21761
--- Comment #10 from Jonathan Druart
---
Comes from eval { $patron->set(\%borrower)->store }; in import_patrons, it
complains on invalid patron attribute's values (login_attempts, lost, etc.)
Related to bug 21761.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- Nick, did you investigate the new warnings your tests add? Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21962] Searching entire authority record failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962 --- Comment #6 from Jonathan Druart --- Created attachment 83032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83032&action=edit Bug 21962: Fix authority search using 'all' To test: 1 - Set search engine to Zebra 2 - Have some authorities and indexes up to date 3 - Search authorities with option 'search entire record' 4 - No results 5 - Apply patch 6 - Run unit tests, they pass! 7 - Repeat search 8 - Results! Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21962] Searching entire authority record failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21962] Searching entire authority record failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962 Jonathan Druart changed: What|Removed |Added Attachment #82999|0 |1 is obsolete|| Attachment #83000|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 83031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83031&action=edit Bug 21962: Unit tests Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Lucas Gass changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #13 from Lucas Gass --- backported to 18.05 for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Tomás Cohen Arazi changed: What|Removed |Added Summary|_FixAccountForLostAndReturn |Avoid manually setting |ed does not always create |amountoutstanding in |an account offset |_FixAccountForLostAndReturn ||ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 83029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83029&action=edit Bug 21759: Regression tests This patch tests for a new behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. Only changes to the 'remaining debt' use cases on this tests are expected. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct. Note: some tests order changes are introduced to avoid calling discard_changes twice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 83030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83030&action=edit Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned This patch changes the behaviour in the _FixAccountForLostAndFound method. The method will now add the amountoutstanding value for the lost item fee to the CR credit to be generated. This means that: - If there's some remaining debt, the same amount will be added to the CR credit and used to cancel that debt. The final amountoutstanding will be the same as before, but an offset will be generated as required. - If the line was written off, the behaviour remains unchanged, so no offset. - If the line was payed and/or written off in full only the payments are refund, preserving the current behaviour. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because the behaviour is not correct - Apply this patch - Run: k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests now pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21923] Sort problem in some letters of Patron list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21923 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- As Pasi said it is expected and I would not consider it a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941 --- Comment #1 from Jonathan Druart --- This is a hard one. I have tried several weeks ago with circ/pendingreserves.pl that has the same problem but decided to postpone it :-/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||21941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941 [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941 Jonathan Druart changed: What|Removed |Added Blocks||17258 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #36 from Jonathan Druart --- Aleisha, With the last patch I do not think it is longer a problem. On the contrary it may be better to not empty the inputs when tabs change (it is the same behavior we have in the header). Switching back to NSO to get other opinions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart changed: What|Removed |Added Blocks||21649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Jonathan Druart changed: What|Removed |Added Depends on||18789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955 --- Comment #6 from Jonathan Druart --- (In reply to Julian Maurice from comment #5) > I cannot reproduce the issue you mentioned on the ML. > > about.pl says > > > Effective caching method: Cache::Memory > > I have 2 starman workers but reloading the page always show the right value > for the syspref. > What am I missing ? Can you confirm you are displaying the pref's value using the Koha.Preference method, i.e. not looking at the pref admin view, which fetches the value from the DB directly? Also make sure starman's parameter --max-requests is not set to 1 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #86 from Owen Leonard --- Created attachment 83027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83027&action=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #87 from Owen Leonard --- Created attachment 83028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83028&action=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #85 from Owen Leonard --- Created attachment 83026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83026&action=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #84 from Owen Leonard --- Created attachment 83025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83025&action=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Owen Leonard changed: What|Removed |Added Attachment #82853|0 |1 is obsolete|| Attachment #82854|0 |1 is obsolete|| Attachment #82855|0 |1 is obsolete|| Attachment #82856|0 |1 is obsolete|| Attachment #82895|0 |1 is obsolete|| --- Comment #83 from Owen Leonard --- Created attachment 83024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83024&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Good call.. all tests still pass for me after applying. Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Martin Renvoize changed: What|Removed |Added Attachment #82250|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 83023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83023&action=edit Bug 21817: Centralize the mock of userenv from tests This patch adds a new method mock_userenv from t::lib::Mocks in order to simplify the mock of the userenv. Test plan: prove all the test files modified by this patch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973
Owen Leonard changed:
What|Removed |Added
Attachment #82978|0 |1
is obsolete||
--- Comment #2 from Owen Leonard ---
Created attachment 83022
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83022&action=edit
Bug 21973: Do not url escape casServerUrl
It is already escaped correctly in
C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape
Note that shibbolethLoginUrl is not and must be url escaped in template
("be consistent, they said")
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Owen Leonard changed: What|Removed |Added Attachment #82907|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 83021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83021&action=edit Bug 21950: Remove filtering for query_cgi and limit_cgi We must not escape query_cgi and limit_cgi template-side, they are already escape properly from build_query_compat using uri_escape_utf8. To fix further problems we should replace all occurrences to make things clear (I decided to keep the html filter so far, which did not hurt, but uri or url do) Same patch as the following commit will be provided commit 2fc599c0893620c395ca0492c9d9e3c860c8f951 Bug 21526: Fix search result pages (url vs uri vs raw) query_cgi is uri_escaped from the pl, so we should displayed as raw Test plan: Use wide characters ❤ Search, filter, facets, search history, rss (both interfaces) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #9 from Owen Leonard ---
The QA tool says there are missing filters, for example:
missing_filter at line 383 ( output += ' ' + [% t('by').json %]; )
it should be:
[% t('by').json | $raw %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21981] New: Specify due date, remember for session and alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21981 Bug ID: 21981 Summary: Specify due date, remember for session and alert Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@collecto.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi, Due date is remaining after a yellow alert with question Test plan in 18.05: - Set the specify due date option to a date, check the checkbox Remember for session - Check out an item - Change patron - Uncheck checkbox and clear the specified date - Check out another item - a yellow alert displayed to confirm checkout - Verify that the date is back Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10391] specify due date remaining even if not selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12551] Special due date not cleared after item added through fast cataloging is checked out.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12551 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #5 from Julian Maurice --- I cannot reproduce the issue you mentioned on the ML. about.pl says > Effective caching method: Cache::Memory I have 2 starman workers but reloading the page always show the right value for the syspref. What am I missing ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #12 from Nick Clemens --- (In reply to Nick Clemens from comment #11) > Created attachment 83020 [details] [review] > Bug 21649: [18.05.X] Pass guarantee info to template when adding child > > To test: > 1 - Find an adult patron > 2 - Click 'Add child' > 3 - Note address/phone info does not carry over > 4 - Apply patch > 5 - Repeat > 6 - Note information populates This should be tested - in 18.05 we are creating a new patron object when creating a new one - testing for borrowernumber seems to confirm it is an 'empty' patron and allow for the pass of the guarantor info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #11 from Nick Clemens --- Created attachment 83020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83020&action=edit Bug 21649: [18.05.X] Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #26 from David Gustafsson --- Fixed incorrectly named is_mapped_biblios to mapped_biblios in mappings.tt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 David Gustafsson changed: What|Removed |Added Attachment #83016|0 |1 is obsolete|| --- Comment #25 from David Gustafsson --- Created attachment 83019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83019&action=edit Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn't show data in table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- This patch does not work for 18.05, not backporting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Devinim changed: What|Removed |Added Attachment #82923|0 |1 is obsolete|| --- Comment #2 from Devinim --- Created attachment 83018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83018&action=edit Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20224] Account restrictions still allow hold / reservation to be placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20224 Ray Delahunty changed: What|Removed |Added Status|NEW |BLOCKED --- Comment #5 from Ray Delahunty --- My apologies, but I should NOT have raised this bug report. I have done more testing these last weeks and every time my account has a restriction on it I am *unable* to place a reservation. I am now 99% sure the reservation was placed using the myUAL app (our branding for the Ex Libris Campus M product). We have integrated this application into Koha but transactions via myUAL app are not exposed to all Koha rules, such as max reserves / holds permitted, and also the restricted account preventing reservations / holds from being placed. We are hoping we can improve our myUAL app integration by having Ex Libris use newer RESTful services rather than older ILSDI HoldTitle calls (for example), but in the meantime we are stuck with a far from perfect integration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr --- Comment #6 from Devinim --- (In reply to Caroline Cyr La Rose from comment #2) > The behaviour is not changed with the patch. When I click submit changes, > new fields appear anyway, even after I apply the patch... Do I have to > restart something? You can try to restart Plack. sudo koha-plack --restart kohadev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Devinim changed: What|Removed |Added Attachment #78980|0 |1 is obsolete|| --- Comment #5 from Devinim --- Created attachment 83017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83017&action=edit Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification There was a mix up between "modification" and "edit" for $action in opac-memberentry.pl. If a patron is logged into the OPAC and they attempt to submit changes to their personal details without having actually changed anything, the page reloads with a message stating 'No changes were made.' However, the fields that now appear are those that have been allowed/hidden according to the preferences set for patron self registration, even if patron self registration is disabled. This can lead to problems if there are discrepancies between the fields allowed for self register settings and those allowed for patron self modification settings. To replicate: 1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to 'don't allow' 2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is different between the two settings and save (for example, specify 'mobile' to be hidden in the former, but don't include in the list of fields to be hidden in the latter). 3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice that the editable fields correspond to those not hidden by PatronSelfModificationBorrowerUnwantedField 4.) Without making any changes, click on 'Submit update request'. 5.) Note that on this page the fields correspond to those not hidden by PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any fields that would otherwise be hidden by the Self Modification settings). Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 David Gustafsson changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #24 from David Gustafsson --- Rebase against master (but currently untested). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 David Gustafsson changed: What|Removed |Added Attachment #82544|0 |1 is obsolete|| --- Comment #23 from David Gustafsson --- Created attachment 83016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83016&action=edit Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 Colin Campbell changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Colin Campbell --- Tests added to confirm patch does stop duplicate messages are loaded, protecting the system from damage resulting from multiple ingests of duplicate files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 --- Comment #5 from Colin Campbell --- Created attachment 83015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83015&action=edit Add tests for patch 20254 Run tests, confirms that file is added to edifact_messages and that a second attempt to re-add the same filename is rejected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #8 from Martin Renvoize --- Oh nice :) Fancy testing Claire and I'll grab it for QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 --- Comment #4 from Colin Campbell --- Created attachment 83014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83014&action=edit Patch working_directory method Was an unused method. Needs an update to set the correct member as is now required for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16067] Koha::Cache, fastmmap caching system is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 --- Comment #8 from Martin Renvoize --- I think we can fairly safely remove this option too.. if it's been broken for 2 years already it's not really all that likely it's being used in production surely! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 Colin Campbell changed: What|Removed |Added Attachment #74002|0 |1 is obsolete|| --- Comment #3 from Colin Campbell --- Created attachment 83013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83013&action=edit Patch forbidding ingest of duplicate filename -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch --- Comment #2 from Martin Renvoize --- This patch was split out from bug 21002 to prevent 21002 from blocking bug 21727. It is a trivial patch adding 2 new exceptions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Assignee|k...@bywatersolutions.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #11 from Kyle M Hall --- I do not plan on continuing to develop this code. If anyone wished to pick it up and work on it, or use it as inspiration for a re-write, they are most welcome to it! I will remove myself as the assignee. (In reply to Katrin Fischer from comment #10) > Hi Kyle, > > I think with Koha's code having moved since this was originally written, > this needs more of a rebase than I can handle :( > > Do you think you will have time to work on this? I'd really like to help > move this along and will make time for it. > > Some things I noticed so far: > > - CATCODE_MULTI will be removed by bug 20226 > - We have the patron object available in the templates now, so won't need > the template variables (bug 18789) > - We already got a has_permission in Patron.pm, so this gets doubled up by > the patch > - There is also a is_child that could simplify some of the code > - Do we still need the description column in the permission table? We could > think about removing it as the descriptions are in the templates. > - Database update appears to be missing > - Why the change to member in members-toolbar.inc? > - Got confused by having both Koha::Patron::Permission(s) and > Koha::Permission(s) > - Owen is trying to get rid of the tree view on bug 11375 - maybe something > to talk about before moving forward here or there. > - I feel like we should keep part of the copyright on top of member-flags.pl > > I am thinking about moving on with my patch for making granular > administration permissions that I had started as it might not be too hard to > adapt this patch set (bug 14391). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- +1 from me too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- A very sensible change that makes these methods considerable more robust... Signing Off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Martin Renvoize changed: What|Removed |Added Attachment #82940|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 83012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83012&action=edit Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases This patch makes outstanding_* methods be safe regarding pathological account lines that get converted into another type because of the value of amountoutstanding To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t =>SUCCESS: All green! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 Martin Renvoize changed: What|Removed |Added Attachment #82939|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 83011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83011&action=edit Bug 21969: Regression tests This patch introduces regression tests for Koha::Account::outstanding_* methods so they don't pick wrong lines when amountoutstanding matches what we are looking for (i.e. negative for credits and positive for debits). To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail because pathological account lines are wrongly picked. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Attachment #82785|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 83009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83009&action=edit Bug 21002: Add tests for Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Attachment #82786|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 83010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83010&action=edit Bug 21002: Add ->add_debit method to Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 --- Comment #1 from Martin Renvoize --- Created attachment 83008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83008&action=edit Bug 21980: Add new excpetions for Koha::Account He add two new exceptions here; One to be thrown when negative 'amount' is passed into verious account methods that always expect positive decimals and another to be thrown when a bad 'type' is passed into an account method. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added Depends on|21002 |21980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 [Bug 21980] Add some new Exceptions for Koha::Account methods -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks|21727 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Martin Renvoize changed: What|Removed |Added Blocks||21727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Martin Renvoize changed: What|Removed |Added Blocks||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Depends on||21980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 [Bug 21980] Add some new Exceptions for Koha::Account methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] New: Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Bug ID: 21980 Summary: Add some new Exceptions for Koha::Account methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We aren't validating as much as we should in the add_credit and upcoming add_debut and adjust methods in the Koha::Account classes. This bug adds a couple of new exceptions for such cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #7 from Martin Renvoize --- Thanks Tomas, that's it.. sorry I missed the dependency chain in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21897] Typo in postinst affecting zebra configuration file installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21897 Martin Renvoize changed: What|Removed |Added Summary|Typo in postinst|Typo in postinst affecting ||zebra configuration file ||installation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- I'm fully behind this, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955 Martin Renvoize changed: What|Removed |Added Attachment #82890|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 83007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83007&action=edit Bug 21955: Remove Cache::Memory as fallback for L2 cache If Plack is running with several workers we must not use Cache::Memory as L2 cache. If a value is set from a worker, it will not be available from other workers as the Cache::Memory instance is not shared (of course!) Moreover we now have Koha::Cache::Memory::Lite that does the same job, so we should not expect performance regressions by removing it. See also the email sent to koha-devel for more info http://lists.koha-community.org/pipermail/koha-devel/2018-December/045004.html Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood changed: What|Removed |Added Attachment #79691|0 |1 is obsolete|| --- Comment #19 from Andrew Isherwood --- Comment on attachment 79691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79691 Bug 7088: DO NOT PUSH - Compiled CSS Obsoleting this, I can't see any way in which it's helpful. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood changed: What|Removed |Added Attachment #82274|0 |1 is obsolete|| --- Comment #18 from Andrew Isherwood --- Created attachment 83006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83006&action=edit Bug 7088: (follow-up) Fix renewal limit bug There was a bug in that altering the state of the "Override renewal limit" checkbox was altering the appearance of the per-item "On hold" checkbox. This is incorrect, the "Override renewal limit" checkbox is unconnected with this bug. Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood changed: What|Removed |Added Attachment #79690|0 |1 is obsolete|| --- Comment #17 from Andrew Isherwood --- Created attachment 83005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83005&action=edit Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood changed: What|Removed |Added Attachment #79689|0 |1 is obsolete|| --- Comment #16 from Andrew Isherwood --- Created attachment 83004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83004&action=edit Bug 7088: Add AllowRenewalOnHoldOverride syspref Enables the renewal of on hold items with specified due dates to be turned on/off Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18805] Add ability to use up account credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #29 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Text to go in the||Adds a business logic level release notes||routine for reconciling ||user account balances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21896] Add Koha::Account::reconcile_balance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #31 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01. This is early enough in the release to be pushed even though it's technically an enhancement and as it is required as part of the fix for the critical bug 18805 I believe the justification is sound. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Martin Renvoize changed: What|Removed |Added Attachment #82744|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Martin Renvoize changed: What|Removed |Added Attachment #82726|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21736] Allow translating the localization widget messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21736 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
