[Koha-bugs] [Bug 21848] Handle encoding when calling Text::Unaccent::unac_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848
--- Comment #7 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #5)
> Marcel, do you understand why we do not get the warning from Patrons.t?
Since we do not use special chars in the names there.
Which we did in Circulation.t. At least I see:
my %expired_borrower_data = (
firstname => 'Ça',
surname => 'Glisse',
categorycode => $patron_category->{categorycode},
branchcode => $branch,
dateexpiry => dt_from_string->subtract( months => 1 ),
);
[…]
Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
Yeah, renaming Ça is enough to get rid of the warn.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 --- Comment #7 from Marcel de Rooy --- fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #16 from Marcel de Rooy --- Applying: Bug 21798: Unify the creation of bibliographic record in tests fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #12 from Nightly Build Bot --- Created attachment 83145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83145=edit Bug 17108 - Automatic debian/control updates (stable/18.11.x) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What|Removed |Added Attachment #82852|0 |1 is obsolete|| --- Comment #4 from Christopher Brannon --- Created attachment 83144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83144=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 --- Comment #3 from Jonathan Druart --- (In reply to Elaine Bradtke from comment #2) > Created attachment 83143 [details] > image of the problem Hi Elaine, do you still have this problem with the patch applied? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Elaine Bradtke changed: What|Removed |Added CC||e...@efdss.org --- Comment #2 from Elaine Bradtke --- Created attachment 83143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83143=edit image of the problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #13 from rkui...@roundrocktexas.gov --- This fix would be SUPER helpful for our library as well. At our library we do not give any refunds because of the way our money goes through the city. Rhonda Kuiper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #10 from Alex Buckley --- Hi Michael, Are you able to retest please,? This still applies cleanly on master. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21934] Allow user to specify name for 'Shibboleth'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21934 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack --- I agree with Katrin, this makes koha less translatable, it will directly impact a few of our customers and also lots of other Koha users. Can we come up with a better way of doing this (and also think of how we can move any of the stuff we currently have in sys prefs into a more translatable format) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #12 from Martha Fuerst --- This would really help us out with the lost item credits issues we are having at our library. Can we look into this again? Thanks! -Marti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Blocked by bug 17896. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21956] Sysprefs not reset by regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21956 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch --- Comment #2 from Jonathan Druart --- Skipping SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11492] Receiving a serial item causes routing list notes to be lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Hi Aleisha, You are doing things that are not advertised in the commit message. For instance you are passing $publisheddatetext to NewIssue. I feel like this is wrong, $publisheddatetext should not be kept from one issue to another. There is 1160 my $nextpublisheddate = GetNextDate($subscription, $publisheddate, 1); 1161 my $nextpubdate = $nextpublisheddate; And $nextpubdate is passed as $planneddate and $publisheddate for the next one, but $publisheddatetext will be unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Jonathan Druart changed: What|Removed |Added Assignee|mtomp...@hotmail.com|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 --- Comment #1 from Jonathan Druart --- Created attachment 83142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83142=edit Bug 21993: Display a user-friendly message when the CSRF token is wrong Instead of dying! Test plan: Assuming you have a patron with borrowernumber=51 and another one that can be deleted with borrowernumber=42 - authorities-home.pl * Delete an authority record * hit /cgi-bin/koha/authorities/authorities-home.pl?op=delete - basket/sendbasket.pl * Send a basket to someone * hit /cgi-bin/koha/basket/sendbasket.pl?email_add=1 - members/apikeys.pl * Generate and delete an API key for a patron * hit /cgi-bin/koha/members/apikeys.pl?patron_id=51=delete - members/deletemem.pl * Delete a patron * hit /cgi-bin/koha/members/deletemem.pl?member=42=delete_confirmed - members/mancredit.pl * Add a manual credit * hit /cgi-bin/koha/members/mancredit.pl?borrowernumber=51=1 - members/maninvoice.pl * Add a manual invoice * hit /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51=1 - members/member-flags.pl * Change permissions for a patron * hit /cgi-bin/koha/members/member-flags.pl?member=51=1 - members/member-password.pl * Change the password for a patron (from the staff interface) * hit /cgi-bin/koha/members/member-password.pl?member=51=aA1 - members/memberentry.pl * Edit some patron's info * hit /cgi-bin/koha/members/memberentry.pl?borrowernumber=51=save - members/paycollect.pl * Pay an individual fine * hit something like /cgi-bin/koha/members/paycollect.pl?borrowernumber=51_individual=1=L=1.00=1.00_id=157=1 You may need to edit some values - tools/import_borrowers.pl * Import some patrons * hit /cgi-bin/koha/tools/import_borrowers.pl?uploadborrowers=1 - tools/picture-upload.pl * Upload an image for a patron * You will need to edit the html content hit Home › Tools › Upload patron images then locate the csrf_token input and modify its value Note for QA: - Opac is not done as blocking_errors.inc does not exist for this interface - ill/ill-requests.pl I did not manage to replace this occurrence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21993] New: Be userfriendly when the CSRF token is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 Bug ID: 21993 Summary: Be userfriendly when the CSRF token is wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org We can use output_and_exit (with blocking_errors.inc) to handle this case in a user friendly manner. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/18.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Lucas Gass changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #49 from Lucas Gass --- backported to 18.05 for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21405] Pagination in authorities search broken for Zebra and broken for 10000+ results in ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21516] Request notes CSS bug makes them unreadable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21516 Lucas Gass changed: What|Removed |Added Status|Pushed to Master|CLOSED Resolution|--- |FIXED CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21529] Fix display of HTML tags in print notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Lucas Gass changed: What|Removed |Added Status|Pushed to Stable|Pushed to Master --- Comment #14 from Lucas Gass --- reverted from 18.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21774] Cloned item subfields disappear when editing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #33 from Lucas Gass --- reverted and reapplied cleaner merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21962] Searching entire authority record failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Jonathan Druart changed: What|Removed |Added Blocks||5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5334] add explicit foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What|Removed |Added Depends on||21983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Christopher Davis changed: What|Removed |Added CC||cgda...@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 [Bug 21547] Use set_password in opac-passwd and remove sub goodkey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 [Bug 21178] Add Koha::Patron::set_password method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21178] Add Koha::Patron::set_password method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21992 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Tomás Cohen Arazi from comment #8) > > A follow-up bug will make the codebase use this instead of > > update_password, and use a proper method for changing the userid if > > required. > > Where is this follow-up? (Yes I saw bug 21547) That'd be bug 21992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Jonathan Druart changed: What|Removed |Added Attachment #83138|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 83141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83141=edit Bug 21991: Pass param names to report limit tool To test: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <> AND 0 ) OR <>=<> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results 5 - Apply patch 6 - Run report 7 - Change display rows 8 - Results remain! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Jonathan Druart changed: What|Removed |Added Attachment #83060|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 83140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83140=edit Bug 21984: Pass param_name in pagination URL To test: 1 - Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) 6 - Apply patch 7 - Run the repot, enter 'CATS' and 'DOGS' 8 - Verify first page looks right 9 - Go to page 2 10 - Results are correct! Signed-off-by: Kyle M Hall Signed-off-by: “Lucas Gass” Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21984] Unable to load second page of results for reports with reused parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] New: Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Bug ID: 21992 Summary: Remove Koha::Patron::update_password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org With 21178, we should be using set_password everywhere instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 --- Comment #6 from Jonathan Druart --- Created attachment 83139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83139=edit Bug 21971: TestBuilder::build_sample_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Jonathan Druart changed: What|Removed |Added Summary|TestBuilder::gimme_an_item |TestBuilder::build_sample_i ||tem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Nick Clemens changed: What|Removed |Added Severity|enhancement |major Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Blocks||21991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 [Bug 21991] Displaying more rows on report results does not work for reports with parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 --- Comment #1 from Nick Clemens --- Created attachment 83138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83138=edit Bug 21991: Pass param names to report limit tool To test: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <> AND 0 ) OR <>=<> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results 5 - Apply patch 6 - Run report 7 - Change display rows 8 - Results remain! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Depends on||9634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 [Bug 9634] Allow for parameters re-use on SQL reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #15 from Jonathan Druart --- I can replace gimme_a_biblio with whatever you want in 5 secondes. However it will take much longer to rebase the patch given its size :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Attachment #82943|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 83136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83136=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #14 from Jonathan Druart --- Created attachment 83137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83137=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21991] New: Displaying more rows on report results does not work for reports with parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Bug ID: 21991 Summary: Displaying more rows on report results does not work for reports with parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <> AND 0 ) OR <>=<> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21178] Add Koha::Patron::set_password method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #21 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #8) > A follow-up bug will make the codebase use this instead of > update_password, and use a proper method for changing the userid if > required. Where is this follow-up? (Yes I saw bug 21547) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #38 from Jonathan Druart --- Created attachment 83134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83134=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to orderreceive.tt which corresponds to the changes made in the previous patch. To test, apply the patch and set the AcqCreateItem system preference to "receiving an order." - Go to Acquisitions -> Vendor -> Receive shipment. - Submit the "Receive a new shipment" form. - Click "Receive" for an order line. - Fill out the item form and click "Add item." - The table of existing items should display correctly, with a single "Actions" column containing an "Edit" and "Delete" button. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #39 from Jonathan Druart --- Created attachment 83135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83135=edit Bug 16939: (follow-up) Adding missing bracket Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #12 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > create_biblio ? > build_biblio ? Or perhaps is build_sample_biblio even better on second thought. It conveys also that it is a sample. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Attachment #82986|0 |1 is obsolete|| Attachment #82987|0 |1 is obsolete|| Attachment #82988|0 |1 is obsolete|| --- Comment #37 from Jonathan Druart --- Created attachment 83133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83133=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error Edit: circ/reserveratios.tt updated so that the plus icon doesn't show if there is no link Edit: fixing logic in circ/reserveratios.tt Edit: merge conflicts Edit: updating buttons to bootstrap 3, which i believe fixes the problem in comment 16 To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #2 from Andrew Isherwood --- Created attachment 83132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83132=edit Bug 21988: Add support for SMSSendFrom syspref This patch adds a SMSSendFrom syspref which allows a "from" number to be provided to SMS drivers that support it. It is passed to the driver as a "_from" parameter, in line with the formatting of the _username and _password parameters. Testing: Since this work depends on an SMS driver that supports it, it is virtually impossible to test. I have added the mocking of the SMSSendFrom preference to t/SMS.t, but can't really take it beyond that. Other than the adding of the syspref, a very tiny modification is made to C4/SMS.pm, but I don't anticipate this having an adverse effect. SMS drivers that do not support the _from paramter will simple ignore it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21848] Handle encoding when calling Text::Unaccent::unac_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848 --- Comment #6 from Jonathan Druart --- I think that we should add a test to show that we removed the warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21848] Handle encoding when calling Text::Unaccent::unac_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Marcel, do you understand why we do not get the warning from Patrons.t? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8864] AutoUnsuspendReserves date check incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8864 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #13 from Kyle M Hall --- (In reply to Katrin Fischer from comment #12) > :( > > But thx for the status update, Kyle. Maybe someone will be able to pick this > up! Maybe post it to the developers list? Perhaps another Koha developer would be interested in picking it up! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21990] No background color for div.error, must be .alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21990] No background color for div.error, must be .alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990 --- Comment #1 from Jonathan Druart --- Created attachment 83131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83131=edit Bug 21990: Replace dialog .error with .alert will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages Test plan: Hit /cgi-bin/koha/acqui/parcel.pl Notice the background color change with and without this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21990] New: No background color for div.error, must be .alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21990 Bug ID: 21990 Summary: No background color for div.error, must be .alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Josef Moravec changed: What|Removed |Added Attachment #82989|0 |1 is obsolete|| --- Comment #28 from Josef Moravec --- Created attachment 83129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83129=edit Bug 14334: Remove AutoCommit from tests And use a DBIx transaction instead. Test plan: prove that the test files modified by this patch are passing Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Josef Moravec changed: What|Removed |Added Attachment #81890|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 83130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83130=edit Bug 21747: Use Koha::Account:: routines in UpdateFine Set to use Koha::Account->add_debit and Koha::Account::Line->adjust Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Jonathan Druart changed: What|Removed |Added Blocks||21989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 [Bug 21989] JS error in "Add orders from MARC file" - addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21989] New: JS error in "Add orders from MARC file" - addorderiso2709.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Bug ID: 21989 Summary: JS error in "Add orders from MARC file" - addorderiso2709.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 19753 On addorderiso2709.pl there is a JS error "ReferenceError: $ is not defined" It comes from commit 1a132440766277d6d94246a86ec671b79de7a442 Bug 19753: Move template JavaScript to the footer: Acquisitions >From Owen on #koha: """ That's just poor testing on my part, and the change to that file should be undone. There's currently no good way to handle cataloging plugin JS with all other JS in the footer """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 [Bug 19753] Move template JavaScript to the footer: Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Andrew Isherwood changed: What|Removed |Added Summary|Add SMSSendDriverFromNumber |Add SMSSendFrom system |system preference for |preference for specifying a |specifying a source number |source number for SMS |for SMS messages|messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #1 from Andrew Isherwood --- Thinking more about it, naming the syspref SMSSendFrom is more consistent with the other SMS prefs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098
--- Comment #8 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #6)
> The "Show inactive" does not seem to work on parcels.pl
This is wrong, it works. I had budget_amount==0
The behavior between the 2 views is different, because of:
neworderemtpy.pl
324 if (!defined $r->{budget_amount} || $r->{budget_amount} <0) {
and parcels.pl
186 if (!defined $r->{budget_amount} || $r->{budget_amount} == 0) {
You can forget my comment.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendDriverFromNumber system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] New: Add SMSSendDriverFromNumber system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Bug ID: 21988 Summary: Add SMSSendDriverFromNumber system preference for specifying a source number for SMS messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Some SMS gateways (specifically, in my case, http://123-txt.com) require a "source" number to be specified which all SMS messages appear to be sent from. This bug proposes adding a SMSSendDriverFromNumber syspref, similar to the new EmailSMSSendDriverFromAddress (Bug 20356), to allow a source number to be specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin sends entries with wrong branchcode without error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #6 from Matthias Meusburger --- Before Bug 16497 is pushed, koct can use this koha api plugin: https://git.biblibre.com/biblibre/koha-plugin-libraries-api to retrieve libraries in a dropdown list, starting from koct 4.0.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #41 from Nick Clemens --- (In reply to Katrin Fischer from comment #38) > 1) There is currently no way to access the page from the OPAC if you don't > know the address. Should we not add it to the top navigation? Maybe with an > id to make it easy to hide? Yes, can add a followup once we are ready :-) > 2) Will long lists be paged? I couldn't get it to page on my system but > wonder how it will look for a really long list. Not yet, future enhancement I think > 5) Was the C intentional? Assuming not and removing > 3) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt >FAIL forbidden patterns > forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug > 12904) - > May be false positive (line 87) Not showing anymore > 4) Still MARC21 only? Not that I can tell Updated to use scss, you will need to run: yarn build --view=opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Attachment #69614|0 |1 is obsolete|| --- Comment #39 from Nick Clemens --- Created attachment 83127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83127=edit Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record Signed-off-by: Sebastian Hierl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #40 from Nick Clemens --- Created attachment 83128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83128=edit Bug 14567: Rebase adjustments and QA fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 --- Comment #1 from Andreas Roussos --- Here's some more info from tests I conducted earlier: Original image -> Koha imagefile Koha thumbnail ----- -- aliakmon 160x245 24-bit JPG -> 160x245 8-bit 140x214 24-bit aliakmon 601x801 24-bit JPG -> 600x800 24-bit 140x187 24-bit oatrotf 599x799 32-bit PNG -> 599x799 8-bit 140x187 24-bit oatrotf 601x801 32-bit PNG -> 600x800 24-bit 140x187 24-bit testing 200x400 8-bit GIF -> 200x400 8-bit 140x280 24-bit testing 601x801 8-bit GIF -> 600x800 24-bit 140x187 24-bit whitebg 599x799 24-bit PNG -> 599x799 1-bit 140x187 24-bit * whitebg 601x801 24-bit PNG -> 600x800 24-bit 140x187 24-bit worrying 599x799 8-bit PNG -> 599x799 8-bit 140x187 24-bit worrying 601x801 8-bit PNG -> 600x800 24-bit 140x187 24-bit [*] the uploaded image was empty (white background), perhaps that explains the resulting 1-bit imagefile? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83124|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi --- Created attachment 83126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83126=edit Bug 21817: Fix 2 failing tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83123|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi --- Created attachment 83125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83125=edit Bug 21817: Centralize the mock of userenv from tests This patch adds a new method mock_userenv from t::lib::Mocks in order to simplify the mock of the userenv. Test plan: prove all the test files modified by this patch Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83052|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 83124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83124=edit Bug 21817: Fix 2 failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83023|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 83123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83123=edit Bug 21817: Centralize the mock of userenv from tests This patch adds a new method mock_userenv from t::lib::Mocks in order to simplify the mock of the userenv. Test plan: prove all the test files modified by this patch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21987] New: Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Bug ID: 21987 Summary: Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1...@gmail.com QA Contact: testo...@bugs.koha-community.org We use local cover images in our setup, and also resize the covers we scan to a width of 160px before uploading and attaching them to a Koha bibliographic record (we upload one cover per biblio). While using phpMyAdmin to view the contents of the 'biblioimages' table (relevant screenshot here: https://imgur.com/a/cSEVLBI), we noticed that the size of the BLOBs for the 'thumbnail' column was in some cases twice as big as that of the 'imagefile' column. In fact, this happens for more than 50% of uploaded covers as you can see from the output of the SQL queries below: mysql> SELECT COUNT( * ) AS count FROM biblioimages WHERE LENGTH( thumbnail ) > ( LENGTH( imagefile ) * 2 ) ; +---+ | count | +---+ | 1356 | +---+ mysql> SELECT COUNT( * ) AS count, SUM( LENGTH( imagefile ) ) AS images_size, SUM( LENGTH( thumbnail ) ) AS thumbnails_size FROM biblioimages ; +---+-+-+ | count | images_size | thumbnails_size | +---+-+-+ | 2347 |68323933 | 115839686 | +---+-+-+ It would appear that for each 160px-wide JPG with 24-bit depth that we have uploaded, the 'imagefile' column has been populated with an PNG of 8-bit depth with the same dimensions as the uploaded file, whereas the 'thumbnail' column contains a 24-bit PNG image with a width reduced to 140 pixels. I've tracked down the creation of resized 24-bit PNGs to this code: https://github.com/Koha-Community/Koha/blob/master/C4/Images.pm#L182-L183 Do thumbnails for covers need to be true colour (24-bit) images? Also, why is it that _scale_image() returns an image of 8-bit depth if the source image's dimensions are less than 600x800? (i.e. when no resizing is performed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Tomás Cohen Arazi changed: What|Removed |Added Summary|Update |Remove |C4::Accounts::manualinvoice |C4::Accounts::manualinvoice |to use |(use |Koha::Account->add_debit|Koha::Account->add_debit ||instead) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #29 from Josef Moravec --- Great catch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #28 from Josef Moravec --- Created attachment 83122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83122=edit Bug 21727: Add handling for cases requireing patron refunds As it is possible to partially pay off a fine that is still incrementing we can end up in a position (when dropbox mode is enabled) where the patron may be owed money by the library should they have paid off the fine between dropping the item off in dropbox mode and the increment that reverts the increase on the dropbox day. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Josef Moravec changed: What|Removed |Added Attachment #83117|0 |1 is obsolete|| Attachment #83118|0 |1 is obsolete|| --- Comment #27 from Josef Moravec --- Created attachment 83121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83121=edit Bug 21727: Unit tests for the refund case This patch introduces tests for the behaviour when the negative adjust exceedes the amount that was already paid. In this case, the line amount is expected to be set to 0, and a credit with the payed amount created. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
