[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #11 from Alex Buckley --- Created attachment 83518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83518=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #19 from Alex Buckley --- Hi Nick, I have made those changes in a commit I have just attached to the bug report. I will set the status back to 'Passed QA' - not sure if that is the correct status it should be at now. Can you please retest? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #18 from Alex Buckley --- Created attachment 83517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83517=edit Bug 21241: (follow-up) Made SQL change idempotent Also added the new pref to sysprefs.sql Also simplified the conditional statement. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21571] Translate notices fail on ACCTDETAILS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21695] Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21789] Example usage of I18N Template::Toolkit plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21789 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #2 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21844] Add callnumber to fines descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21844 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21790] Switch error page template to Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21790 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21929] Typo in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21795] Switch two-column templates to Bootstrap grid: Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21795 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22033] related_resultset is a hole in the Koha::Object logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||n...@bywatersolutions.com
--- Comment #17 from Nick Clemens ---
Please make the statement idempotent (INSERT IGNORE)
Add the pref to sysprefs.sql for new installs
I think the conditional can be further simplified:
-my $transport = 'email';
-if (C4::Context->preference("FallbackToSMSIfNoEmail")) {
-$transport = ($patron->smsalertnumber) && (!$patron->email) ?
'sms' : 'email';
-}
+my $transport = (C4::Context->preference("FallbackToSMSIfNoEmail")) &&
($patron->smsalertnumber) && (!$patron->email) ? 'sms' : 'email';
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #38 from Lucas Gass --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #40 from Nick Clemens --- Please rebase, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- does not apply cleaning to 18.05 please rebase if needed in 18.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83125|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 83515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83515=edit Bug 21817: Centralize the mock of userenv from tests This patch adds a new method mock_userenv from t::lib::Mocks in order to simplify the mock of the userenv. Test plan: prove all the test files modified by this patch Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83126|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 83516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83516=edit Bug 21817: Fix 2 failing tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21912] Koha::Objects->search lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21912 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 83514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83514=edit Bug 21912: (QA follow-up) Do not delete existing patrons Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #24 from Joy Nelson --- Katrin, Currently this analytic feature only works where the leader7=s. I'd like to propose the following changes to this feature to allow it be used by your library and others in a more standard method. 1. Allow the link to appear when leader7 =s or leader7=m. Both monographs and serial records can have component parts and as such have children that should be displayed by this feature. The Show analytics link is searching for bib-level:a (Monographic component part) and bib-level:b (Serial component part). 2. Add a search function to this display page that checks the index (Host-item) to see if any children are present. If so, then display the "Show Analytics Link". This search would search for control number or title depending on the value of usecontrolnumber sys pref. 3. Add a syspref for this method of analytic cataloging, much like we have for Easy Analytics and 'use control number'. Allow libraries the ability to turn off the analytic cataloging if they don't use it. Call it "ShowLinktoChildfromParent"? Your thoughts? joy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Nick Clemens from comment #11) > Simple rebase needed Tests count mismatch, done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 83513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83513=edit Bug 21909: Add return type explanation to POD Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 83511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83511=edit Bug 21909: Unit tests This patch introduces regression tests for the behaviour to be introduced. Both outstanding_credits and outstanding_debits methods should return a Koha::Account::Lines object in scalar context, and a list of Koha::Account::Line objects in list context. To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: The current behaviour doesn't match the described Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 83512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83512=edit Bug 21909: Make Koha::Account::outstanding_* preserve context This patch modifies the methods so they preserve the caller's context (list and scalar). To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: outstanding_credits and outstanding_debits tests fail - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: We are so happy now :-D - Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82799|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82800|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82801|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #55 from Lucas Gass --- requires 21526 wont backport to 18.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #9 from Alex Arnaud --- QA is ok for the patch. I'd like a second QA point of view for the unit tests i wrote. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Attachment #83508|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 83510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83510=edit Bug 13515: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Attachment #83463|0 |1 is obsolete|| --- Comment #7 from Alex Arnaud --- Created attachment 83509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83509=edit Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted Signed-off-by: Nazlı Çetin Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #6 from Alex Arnaud --- Created attachment 83508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83508=edit Bug 13515: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21817] Mock userenv should be a t::lib::Mocks method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21817 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #10 from Nick Clemens --- Please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 83504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83504=edit Bug 22048: Use set_password in create_superlibrarian.pl Use $patron->set_password instead of update_password. In this case the 'skip_validation' param needs to be set as no password strength checks are expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 83505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83505=edit Bug 22048: Use set_password opac/opac-password-recovery.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 83502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83502=edit Bug 22048: Use set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83503=edit Bug 22048: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 83507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83507=edit Bug 22048: Use set_password in Auth_with_ldap.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 83506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83506=edit Bug 22048: Use set_password in tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Search/History.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83501=edit Bug 22048: Use set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 [Bug 21547] Use set_password in opac-passwd and remove sub goodkey -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Tomás Cohen Arazi changed: What|Removed |Added Blocks|21992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on|21547 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 [Bug 21547] Use set_password in opac-passwd and remove sub goodkey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have a 'skip_validation' param -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22048] New: Use set_password instead of update_password in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 Bug ID: 22048 Summary: Use set_password instead of update_password in the codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- update_password has been deprecated and will be removed by bug 21992. We need to switch all the uses in the codebase into using set_password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Blocks|21992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on|22047 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have a 'skip_validation' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83494|0 |1 is obsolete|| Attachment #83495|0 |1 is obsolete|| Attachment #83496|0 |1 is obsolete|| Attachment #83497|0 |1 is obsolete|| Attachment #83498|0 |1 is obsolete|| Attachment #83499|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 83500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83500=edit Bug 21992: Remove unused Koha::Patron->update_password method This patch removes the no longer used method. To test: - Apply this patch - Run: $ git grep update_password => SUCCESS: Only references are in Auth_with_ldap.pm and not related - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #44 from Nick Clemens --- Biblio.t fails for me on master with this applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6533] Enhancement: Printer Friendly Lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6533 karen.fell...@citruslibraries.org changed: What|Removed |Added CC||karen.fellows@citruslibrari ||es.org --- Comment #2 from karen.fell...@citruslibraries.org --- We have had patron requests for this as well. A downloadable or printable reading history as well would be a great enhancement --without the book jackets and extra stuff, just title and author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21929] Typo in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #82836|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Nick Clemens changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Simple rebase needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 --- Comment #2 from mjn...@gmail.com --- Just FYI - I've upgraded to 18.11.01.000 and the behaviour seems the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 83497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83497=edit Bug 21992: Remove use of update_password in create_superlibrarian.pl In this case we are not using $patron->set_password, because we want to keep the current behaviour: no checks on the password quality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 83498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83498=edit Bug 21992: Use set_password opac/opac-password-recovery.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83494=edit Bug 21992: Use ->set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 83495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83495=edit Bug 21992: Use ->set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 83499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83499=edit Bug 21992: Remove uses of update_password in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83496=edit Bug 21992: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have a 'skip_validation' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Summary|set_password should have an |set_password should have a |'unsafe' param |'skip_validation' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83493=edit Bug 22047: Fix opac/opac-passwd.pl call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 83492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83492=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83491=edit Bug 22047: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21992] Remove Koha::Patron::update_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have an 'unsafe' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have an 'unsafe' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 [Bug 21547] Use set_password in opac-passwd and remove sub goodkey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21547] Use set_password in opac-passwd and remove sub goodkey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 83490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83490=edit Bug 21547: (follow-up) Rely on Koha::Patron->set_password checks This patch makes the controller just call $patron->set_password and use the exceptions it might raise instead of manually checking the passwor strength. No behaviour change should be expected. It also removes some leftovers. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19458] Self-check module highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19458] Self-check module highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Alex Arnaud changed: What|Removed |Added Attachment #83383|0 |1 is obsolete|| --- Comment #6 from Alex Arnaud --- Created attachment 83489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83489=edit Bug 19458: (follow-up) Self-check module highlighting Signed-off-by: Josef Moravec Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19458] Self-check module highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Alex Arnaud changed: What|Removed |Added Attachment #83382|0 |1 is obsolete|| --- Comment #5 from Alex Arnaud --- Created attachment 83488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83488=edit Bug 19458: Self-check module highlighting In SCO Module there is no difference on how new checkouts and renewals are shown from previous ones. This commit is done to address that issue. How to test: 1. Go to /cgi-bin/koha/sco/sco-main.pl and login. 2. Checkout a new item. 3. In checkout's table new checkouts should be easily identifiable. Signed-off-by: Josef Moravec Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21844] Add callnumber to fines descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21844 Nick Clemens changed: What|Removed |Added Attachment #82419|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21178] Add Koha::Patron::set_password method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 [Bug 22047] set_password should have an 'unsafe' param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] New: set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Bug ID: 22047 Summary: set_password should have an 'unsafe' param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- On removing traces of update_password in the codebase, I noticed the use case in Auth_with_ldap.pm which basically skips any password quality check. I'm not sure if that 'feature' is or should be used. For now, we should provide this alternate behaviour. The best approach is adding an 'unsafe' param. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22047] set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 [Bug 21178] Add Koha::Patron::set_password method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19458] Self-check module highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21803] Redesign authorized values interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21803 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- I agree with Martin about the descriptions, it makes me want to be able to add descriptions for user added categories, but I think that is future enhancement I like that the breadcrumbs can take us back to the main list, but I think we need a more obvious button - it is unclear after clicking on a single category how to get back to the list. Could we have a 'Return to main page' button or similar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19458] Self-check module highlighting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #10 from Nick Clemens --- (In reply to Owen Leonard from comment #9) > (In reply to Nick Clemens from comment #6) > > Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't > > make them work with this > > This was an error in the placement of the tag. That's the only change > to the signed-off patch. I hope it's okay to return this to 'Passed QA.' Yup,that's okay, would be better as a follow-up patch so that the change can be easily seen and verified, but it works in testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
