[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #36 from David Cook --- Quick question: How does one "regenerate the staff client CSS"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #35 from David Cook --- I've run out of time today but I want to test this tomorrow. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED --- Comment #7 from Fridolin SOMERS --- Depends on Bug 18789 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21980] Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21436] Switch two-column templates to Bootstrap grid: Tools part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #33 from Nick Clemens --- We should have a dependent bug to call reconcile balance for fines (when closed, not accruing) but I think is beyond scope here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21928] CircAutoPrintQuickSlip 'clear' is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18531] Add an endpoint for use by GOBI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21909] Koha::Account::outstanding_* methods should preserve call context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21909 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #18 from Lucas Gass --- cannot cleanly apply this for 18.05. if this is needed in 18.05 can we please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14476] Improving opac-search performances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 --- Comment #6 from David Cook --- (In reply to Fridolin SOMERS from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > I have a concern: if we cache the record to be displayed, then the item > > statuses won't be up-to-date. If the tradeoff is not enough, maybe this is > > just not worth. Because people expect to see updated information on the > > records. > > Indeed. > > I think we need to change this by moving items out of this XSLT file. > I think we should use Ajax to load in realtime items infos, with and API for > that. > This will also avoid indexing all record on item circulation. > Dreams ... I often think using Ajax to load real time item info is a good idea too, although I think we'd still have the indexing issue because of the "limit to currently available items" filter on the search. Often, I think we should think about our OPAC as if it were a totally separate system, and just link it up to the Koha instance using APIs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- http://devs.bywatersolutions.com/2016/11/30/Limit-Item-Types-by-Branch/ According to the updated dev site on Bywater it looks like this has been funded. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Devinim changed: What|Removed |Added Attachment #83714|0 |1 is obsolete|| --- Comment #2 from Devinim --- Created attachment 83733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83733=edit Bug 22082: ambiguous column in patron stats In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error : ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous This is because FROM contains tables borrowers and borrower_attributes both containing borrowernumber column. Test plan : 1) Be sure to have a patron extended attribute 2) Be sure you have some recent circulation activity 3) Go to Reports > Patrons statistics 4) Select 'active' in 'Patron activity' and 1 years of activity 5) Check 'Row' in 'Patron category' 6) Check 'Columns' in a extended attribute 7) Submit 8) Without patch you have no results, with patch you have exepected results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Attachment #83292|0 |1 is obsolete|| Attachment #83293|0 |1 is obsolete|| --- Comment #33 from Owen Leonard --- Created attachment 83731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83731=edit Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #34 from Owen Leonard --- Created attachment 83732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83732=edit Bug 21751: Remove former fixFloat plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #15 from Josef Moravec --- Created attachment 83730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83730=edit Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl Test plan: Try to upload koc file with some returns Success: the file should be correctly processed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #13 from Josef Moravec --- Created attachment 83728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83728=edit Bug 22049: Add tests The current tests only check some failure use cases. This patch makes it cover more use cases To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 --- Comment #14 from Josef Moravec --- Created attachment 83729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83729=edit Bug 22049: (follow-up) Remove leftover variable The $circControlBranch variable was originally set to be used to pick the right dropbox branch. It was only used in MarkIssueReturned, to get the right Koha::Calendar object. As this responsability was moved top to the AddReturn caller, and the fact that _GetCircControlBranch is actually used for fines rules, there's no use for it in this context. And it was left on the previous patch as a mistake. To test: - Make sure the variable is not actually used: $ git grep '$circControlBranch' => SUCCESS: removed variable is not actually used. - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added Attachment #83654|0 |1 is obsolete|| Attachment #83655|0 |1 is obsolete|| Attachment #83656|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 83727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83727=edit Bug 22049: Make MarkIssueReturned rely on returndate only This patch changes the params accepted by C4::Circulation::MarkIssueReturned by removing the $dropbox_branch param. This passed branchcode was only used to initialize the Koha::Calendar object, but the date arithmetic has already taken place in a couple places before we reach this point. This logic needs to be simplified (bug 14591), and this is the starting point. To test: - Apply this patch - Run: $ git grep MarkIssueReturned => SUCCESS: Check all the uses of the function either originally passed undef, or now pass the same date that would've been calculated anyway, in the returndate param. - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master CC||tomasco...@gmail.com Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 --- Comment #1 from Kyle M Hall --- Created attachment 83726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83726=edit Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered. In addition, if the plugin has no upgrade method, the installed version is never updated in the database! Lastly, when an upgrade succeeds it prints a warning that the upgrade failed. Test Plan: 1) Install an older version of the Kitchen sink plugin: * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz 2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from plugin_data for this plugin, to simulate having installed from an earlier version of Koha 3) Upgrade to the latest version of the Kitchen sink plugin: * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz 4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the plugin_data table 5) Apply this patch 6) Restart all the things 7) Browse to the Kitchen sink configuration page, this should trigger the upgrade method 8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in plugin_data for the Kitchen Sink plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20669] Add upgrade method to plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20669 Kyle M Hall changed: What|Removed |Added Blocks||22084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Kyle M Hall changed: What|Removed |Added Depends on||20669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20669 [Bug 20669] Add upgrade method to plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Tomás Cohen Arazi --- This could be solved by replacing ->pay for ->add_credit + ->apply (they were designed for that). I'll take a look! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added Attachment #83657|0 |1 is obsolete|| Attachment #83658|0 |1 is obsolete|| Attachment #83659|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 83723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83723=edit Bug 22051: Add Koha::Exceptions::Object::WrongValue This patch adds a new exception to be thrown in Koha::Object->store when a DBIC exception is thrown regarding bad data format. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #12 from Josef Moravec --- Created attachment 83725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83725=edit Bug 22051: Make Koha::Object->store translate incorrect value exceptions This patch adds a new condition to Koha::Object->store so it catches incorrect value-related DBIC exceptions. This DBIC exceptions get now translated into Koha::Exceptions::Object::BadValue exceptions with relevant parameters passed. To test: - Apply the exception and unit tests patches - Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because this exception handling code is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 --- Comment #11 from Josef Moravec --- Created attachment 83724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83724=edit Bug 22051: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] New: Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Bug ID: 22084 Summary: Plugin upgrade method and database plugin version storage will never be triggered for existing installs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered. In addition, if the plugin has no upgrade method, the installed version is never updated in the database! Lastly, when an upgrade succeeds it prints a warning that the upgrade failed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Josef Moravec changed: What|Removed |Added Attachment #82285|0 |1 is obsolete|| Attachment #82286|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 83721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83721=edit Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21788] C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 --- Comment #6 from Josef Moravec --- Created attachment 83722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83722=edit Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Nick Clemens --- (In reply to Katrin Fischer from comment #2) > Hi Nick, > > ist this patch testable? It needs to take separate holdings into account, not testable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Nick Clemens changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Nick Clemens changed: What|Removed |Added Attachment #55831|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 83720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83720=edit Bug 17353 - Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. It also ads the table to columns configuration To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone does not display 5 - Visit columns configuration 6 - Unhide the 'phone' column 7 - Note phone displays 8 - Ensure page functions as before patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020 Josef Moravec changed: What|Removed |Added Attachment #83472|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 83719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83719=edit Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl The table is used by circulation.pl and moremember.pl When it is modified we need to take care of the two view. Test plan: Use the columns settings to hide/show the "check in" and other columns Confirm the this patch fixes the display for moremember.pl Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #16 from Jesse Maseto --- This was backported to 18.05.x for 18.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 Josef Moravec changed: What|Removed |Added Attachment #83708|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 --- Comment #4 from Josef Moravec --- Created attachment 83718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83718=edit Bug 22073: Add to diacritics mappings for Ž and ž To test: 1 - Find or add a record by author Slavoj Žižek 2 - Search for 'Zizek' 3 - No results 4 - Apply patch 5 - Reindex 6 - Search again 7 - Success! https://bugs.koha-community.org/show_bug.cgi?id=22073 Signed-off-by: Eric Phetteplace Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Nick Clemens changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #1 from Nick Clemens --- To recreate: 1 - Create a manual fine for a patron (or find one with fines) 2 - Check out an item to this patron 3 - Ensure the item has a lost charge 4 - Mark the item lost via a method that will not check it in (MarkLostItemsAsReturned syspref) 5 - Note the item is checked out to patron and they are charged 6 - From patron go to Accounting->Make a payment, select all, 'Pay selected' 7 - Enter an amount less than the value of the first fine and pay 8 - Payments are calculated correctly, however, the item is now checked in 9 - View the item on the 'items' tab of the biblio 10 - The 'Paid for?' section notes the item has been paid for 11 - Pay a partial amount again 12 - Paid for now has doubled info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 83717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83717=edit Bug 21846: (follow-up) Add maintenance script This patch adds a maintenance script that generates the missing tags_approval entries based on the tags_all table, and then recalculates the weights for both tags_approval and tags_index tables. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22059] Wrong exception parameters in Koha::Patron->set_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip bad borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22030] OverDrive requires configuration for field passed as username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21786] Routes for credits should include library_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21605] Cannot create EDI account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #63 from Nick Clemens --- (In reply to Martin Renvoize from comment #62) > Fixed a single whitespace error that was introduced. > > Passing QA Tests are failing with these patches: prove -v t/db_dependent/SearchEnginge/ElasticSearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Kyle M Hall changed: What|Removed |Added CC||je...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 --- Comment #1 from Kyle M Hall --- Created attachment 83716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83716=edit Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha The CM field was all set up for implementation, but never completed. We should fully implement the CM ( Hold Pickup Date ), which according to the SIP2 protocol specification is "The date that the hold expires". Test Plan: 1) Set up a waiting hold for an item 2) Using the sip cli emulator, send an item information request for that item 3) Note the CM field does not show up 4) Apply this patch 5) Restart all the things! 6) Repeat the item information request 7) Note the CM field is now transmitted! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Kyle M Hall changed: What|Removed |Added Assignee|je...@bywatersolutions.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 --- Comment #2 from Caroline Cyr La Rose --- I also think that the 'too many checked out' warning should only appear if the circulation rules allow 1 or more. If the circulation rules allow 0, only 'This patron can't check out this item per library circulation rules' should show... It is, however, outside of the scope of this bug and outside my capabilities... Just throwing it out there if someone wants to take it over :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Caroline Cyr La Rose changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083
--- Comment #1 from Caroline Cyr La Rose ---
Created attachment 83715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83715=edit
Bug 22083: Typo in circulation_batch_checkouts.tt
There is a typo in circulation_batch_checkouts.tt that makes Koha skip a
warning if the user cannot borrow due to circulation rules.
This patch corrects this typo.
To test:
1. In Administration > Global system preferences, 'Allow' BatchCheckouts and
enter patron categories in BatchCheckoutsValidCategories
2. Go to Administration > Circulation and fines rules
3. Enter a rule where a certain category of patrons (that is in
BatchCheckoutsValidCategories) cannot take out a particular item type
4. Search the catalog for an item of that item type
5. Copy the barcode
6. Go into patrons and find a patron of that category
7. Click on the Batch checkout tab
8. Paste the barcode in the box and click Check out
9. It should say 'Too many checked out'
10. Apply the patch
11. Try the check out again, it should show both warnings ('Too many checked
out' and 'This patron can't check out this item per library circulation
policy')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] New: Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Bug ID: 22083 Summary: Typo in circulation_batch_checkouts.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: caroline.cyr-la-r...@inlibro.com Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Target Milestone: --- There is a typo in circulation_batch_checkouts.tt that makes Koha skip a warning if the user cannot borrow due to circulation rules. To reproduce: 1. In Administration > Global system preferences, 'Allow' BatchCheckouts and enter patron categories in BatchCheckoutsValidCategories 2. Go to Administration > Circulation and fines rules 3. Enter a rule where a certain category of patrons (that is in BatchCheckoutsValidCategories) cannot take out a particular item type 4. Search the catalog for an item of that item type 5. Copy the barcode 6. Go into patrons and find a patron of that category 7. Click on the Batch checkout tab 8. Paste the barcode in the box and click Check out 9. It should say 'Too many checked out' It should also say 'This patron can't check out this item per library circulation policy'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 --- Comment #1 from Fridolin SOMERS --- Created attachment 83714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83714=edit Bug 22082: ambiguous column in patron stats In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error : ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous This is because FROM contains tables borrowers and borrower_attributes both containing borrowernumber column. Test plan : 1) Be sure to have a patron extended attribute 2) Be sure you have some recent circulation activity 3) Go to Reports > Patrons statistics 4) Select 'active' in 'Patron activity' and 1 years of activity 5) Check 'Row' in 'Patron category' 6) Check 'Columns' in a extended attribute 7) Submit 8) Without patch you have no results, with patch you have exepected results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #22 from Claire Gravely --- Created attachment 83712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83712=edit [SIGNED-OFF] Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Claire Gravely changed: What|Removed |Added Attachment #82333|0 |1 is obsolete|| Attachment #82334|0 |1 is obsolete|| Attachment #82335|0 |1 is obsolete|| --- Comment #21 from Claire Gravely --- Created attachment 83711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83711=edit [SIGNED-OFF] Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #23 from Claire Gravely --- Created attachment 83713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83713=edit [SIGNED-OFF] Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22080] Easier translation of ElasticSearch mappings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22082 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8306 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] New: ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Bug ID: 22082 Summary: ambiguous column in patron stats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error : ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Martin Renvoize changed: What|Removed |Added QA Contact||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #62 from Martin Renvoize --- Fixed a single whitespace error that was introduced. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Martin Renvoize changed: What|Removed |Added Attachment #83704|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 83710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83710=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens Signed-off-by: Ere Maijala Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22081] Alternate merging functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22081 --- Comment #1 from Simon Hohl --- One solution: 1. Add a toggle when merging "keep merged record" 2. If the toggle is active, let the user specify into which of the loosing record's fields to write the replacement's system number. 3. Remove all data from the loosing record except the replacement's sys number If somebody navigates to a record replaced in this manner either redirect directly (OPAC) or show a link to the replacement record (Backend). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21902] OPAC login should redirect to referring page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21902 Hugo Agud changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Hugo Agud --- Hi you are right!, for most uupdated versions it is already working... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14476] Improving opac-search performances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 --- Comment #5 from Fridolin SOMERS --- (In reply to Tomás Cohen Arazi from comment #4) > I have a concern: if we cache the record to be displayed, then the item > statuses won't be up-to-date. If the tradeoff is not enough, maybe this is > just not worth. Because people expect to see updated information on the > records. Indeed. I think we need to change this by moving items out of this XSLT file. I think we should use Ajax to load in realtime items infos, with and API for that. This will also avoid indexing all record on item circulation. Dreams ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14476] Improving opac-search performances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added Attachment #83694|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 83709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83709=edit Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22081] New: Alternate merging functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22081 Bug ID: 22081 Summary: Alternate merging functionality Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: simon.h...@dainst.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- Currently the merging process let's you select which fields ought to be copied over to the "winning" record from the "loosing" record(s). Afterwards, the "loosing" record is deleted (moved to tables "deletedbiblio" etc.). One problem with the current solution: You can't tell after the fact, which deleted record was merged with which existing record. This is bad if you want to provide stable links to bibliographic records, for citation in research papers for example: Ideally you would want to be able to redirect to the "winning" records if somebody calls URL to a deleted record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22073] Diacritics Ž and ž not being mapped for searching (Non-ICU)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22073 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
