[Koha-bugs] [Bug 22334] New: perldoc is not complete

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22334

Bug ID: 22334
   Summary: perldoc is not complete
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: josef.mora...@gmail.com
  Target Milestone: ---

There are missing at least some modules from perldoc.koha-community.org, for
example:

Koha::Patrons
Koha::Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22334] perldoc is not complete

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22334

Josef Moravec  changed:

   What|Removed |Added

 CC||g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||ere.maij...@helsinki.fi

--- Comment #23 from Katrin Fischer  ---
Patch doesn't apply right now, conflict looks small. Could we get a rebase
please?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20334 - Option for escaping slashes in search queries
Using index info to reconstruct a base tree...
M   Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
CONFLICT (content): Merge conflict in
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20334 - Option for escaping slashes in search queries
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20334---Option-for-escaping-slashes-in-search--Co2Ks4.patch


Also adding Ere here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||ere.maij...@helsinki.fi,
   ||katrin.fisc...@bsz-bw.de

--- Comment #41 from Katrin Fischer  ---
This patch doesn't apply right now. Might not be a hard fix if you are familiar
with the Elasticsearch code. Can we get a rebase please?

@Ere - It'd also be great if you could have a look here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #64 from Katrin Fischer  ---
Hi Andrew, getting started with this one.

1) QA script: 
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
   FAIL   filters
missing_filter at line 10 (from [% display_before
%])
   FAIL   forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 5)
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 13)
   OK git manipulation
   OK js_in_body
   OK spelling
   OK tt_valid
   FAIL   valid_template
: filter not found

2) I am wondering a bit about the date operations in the Logger module,
get_epoch  especially.

3) This doesn't need to be part of the installer outside the sysprefs.sql file. 
Files ill_logging_pref.txt and ill_logging_pref.sql can be removed.
sysprefs.sql will always be run during installation, installing all prefs. 

4) I wonder if we should set the logger to off by default for updated
installations and allow people to turn it on themselves.

5) For translations it's always nice to be specific. 'request' is a very
general term that appears in multiple contexts. I am suggesting 'Display
request log' > "ILL request log" (it being a button kind of transports the
display part :) )

6) In the log viewer, could we make the visibility of the ILL parts depend on
the system preference? I think this would make it a little less confusing for
people without the ILL module activated.

7) Just using this for a teaching moment :) Status changed  will be
turned into Status changed with a space at the end on translations, which will
do nothing in this case, but can be a bit tedious. In other cases forgetting
the space will be bad for display, so translators have to always look for
those.

8) Tests are failing for me:
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 1/11 
#   Failed test 'Status_alias getter works.'
#   at t/db_dependent/Illrequests.t line 66.
#  got: undef
# expected: 'gCXbRHL2vgImhl1lv0AsoWfYj15fmIgBiFT9i_fmMnIzh1laXf'
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
# Looks like you failed 1 test of 25.
t/db_dependent/Illrequests.t .. 3/11 
#   Failed test 'Basic object tests'
#   at t/db_dependent/Illrequests.t line 117.
t/db_dependent/Illrequests.t .. 5/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
t/db_dependent/Illrequests.t .. 7/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
t/db_dependent/Illrequests.t .. 10/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
# Looks like you failed 1 test of 11.
t/db_dependent/Illrequests.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/11 subtests 

Test Summary Report
---
t/db_dependent/Illrequests.t (Wstat: 256 Tests: 11 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22305] Add syspref to allow ILL to be hidden in OPAC

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22305

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
To make things a bit more complicated: you might have another 'thing' for
adding ILL requests, like a special search interface/portal and still want to
see the requests, but not options to change or add new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84930|0   |1
is obsolete||

--- Comment #214 from Katrin Fischer  ---
Created attachment 85094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85094=edit
Bug 20581: (follow-up) Fix unit test

Since we're now storing the authorised_value column as the foreign key,
rather than the id, we need to account for this in the test

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84929|0   |1
is obsolete||

--- Comment #213 from Katrin Fischer  ---
Created attachment 85093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85093=edit
Bug 20581: (follow-up) Fix status_alias comparison

status_alias will arrive in the Koha object as a string, so when we
special case it, we should also pass a string

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84931|0   |1
is obsolete||

--- Comment #215 from Katrin Fischer  ---
Created attachment 85095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85095=edit
Bug 20581: (follow-up) Passed value to status_alias

Now we have overloaded status_alias, we can no longer pass it undef (as
it uses that to determine if it's being used as a getter or setter). So
we now pass it -1 to indicate it should actually be setting undef (a
hack, I know, but what are you going to do...)

This patch makes sure ill-request.pl conforms to that. It also fixes the
testing of the passed parameter, which was wrong.

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84964|0   |1
is obsolete||

--- Comment #216 from Katrin Fischer  ---
Created attachment 85096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85096=edit
Bug 20581: (follow-up) Fix status_alias -1 bug

Stupid bug, we need to pass NULL not -1 when unsetting status_alias

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84928|0   |1
is obsolete||

--- Comment #212 from Katrin Fischer  ---
Created attachment 85092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85092=edit
Bug 20581: (follow-up) Overload status_alias

We need Koha::Illrequest->status_alias to return the correct authorised value.
Since the foreign key uses a non-unique column, we need to take into
account the authorised value category too.

This patch overloads status_alias with some additional logic that
considers the request's branch and the authorised value category to
attempt to return the correct value.

The same logic is applied to the custom statusalias method, which
returns the entire AuthorisedValue object

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84926|0   |1
is obsolete||

--- Comment #210 from Katrin Fischer  ---
Created attachment 85090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85090=edit
Bug 20581: (follow-up) Do not use PK for AV FK

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c133

We switch from using authorised_values.id when creating the foreign key
illrequests.status_alias, we now use authorised_values.authorised_value

I have added a migration from using id -> authorised_value, so when
existing users of this bug get this version, their DB migrates nicely
instead of just breaking.

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84921|0   |1
is obsolete||

--- Comment #205 from Katrin Fischer  ---
Created attachment 85085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85085=edit
Bug 20581: (follow-up) Fix AV population

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84925|0   |1
is obsolete||

--- Comment #209 from Katrin Fischer  ---
Created attachment 85089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85089=edit
Bug 20581: (follow-up) Fix dependency requirement

Since this bug is now dependent on Bug 20600 (Provide the ability for
users to filter ILL requests) we need to make the status filtering aware
of the custom statuses. This patch does that.

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84924|0   |1
is obsolete||

--- Comment #208 from Katrin Fischer  ---
Created attachment 85088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85088=edit
Bug 20581: (follow-up) Fix QA errors

This patch fixes the "missing_filter" errors on ill-requests.tt

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84918|0   |1
is obsolete||

--- Comment #202 from Katrin Fischer  ---
Created attachment 85082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85082=edit
Bug 20581: (follow-up) Allow for undefined lib

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84919|0   |1
is obsolete||

--- Comment #203 from Katrin Fischer  ---
Created attachment 85083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85083=edit
Bug 20581: (follow-up) Fix statusalias return

As per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84927|0   |1
is obsolete||

--- Comment #211 from Katrin Fischer  ---
Created attachment 85091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85091=edit
Bug 20581: (follow-up) Fix typo in DB upgrade

IN -> ON

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84922|0   |1
is obsolete||

--- Comment #206 from Katrin Fischer  ---
Created attachment 85086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85086=edit
Bug 20581: (follow-up) Modify POD

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c69

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84923|0   |1
is obsolete||

--- Comment #207 from Katrin Fischer  ---
Created attachment 85087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85087=edit
Bug 20581: (follow-up) Fix typo in kohastructure

Fix the missing comma

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84917|0   |1
is obsolete||

--- Comment #201 from Katrin Fischer  ---
Created attachment 85081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85081=edit
Bug 20581: (follow-up) Display status name

Rather than display the status code for custom statuses, we should be
displaying the name

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84914|0   |1
is obsolete||

--- Comment #198 from Katrin Fischer  ---
Created attachment 85078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85078=edit
Bug 20581: Add display of status_alias to staff vw

- This patch adds display of the new status_alias value, when set, in
favour of the request's status value.
- It also allows the user to set a status_alias for an existing request.
When set, this value will be displayed in preference to the status.

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84916|0   |1
is obsolete||

--- Comment #200 from Katrin Fischer  ---
Created attachment 85080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85080=edit
Bug 20581: Unit tests for status_alias

This patch adds unit tests for the specific status_alias functionality
added in this bug

- Creation of the ILLSTATUS authorised value
- Illrequest->statusalias accessor
- Illrequest->status overloading to reset status_alias

To test:
1) Apply this patch
2) prove t/db_dependent/Illrequests.t

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84920|0   |1
is obsolete||

--- Comment #204 from Katrin Fischer  ---
Created attachment 85084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85084=edit
Bug 20581: (follow-up) Fix fallback status_alias

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84915|0   |1
is obsolete||

--- Comment #199 from Katrin Fischer  ---
Created attachment 85079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85079=edit
Bug 20581: Fix display of status alias in OPAC

Fix for status alias display in OPAC, we should be displaying the status
name, not the status code.

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84911|0   |1
is obsolete||

--- Comment #195 from Katrin Fischer  ---
Created attachment 85075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85075=edit
Bug 20581: Modifications to database schema

- This patch provides an illrequests.status_alias column that is a foreign key
to
authorised_values.id. This provides the ability for an ILL request to
have an optional status alias that is defined as an authorised valued.
- A new ILLSTATUS authorised value category is also made available during
install.

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Following commit was squashed into this one:

Bug 20581: (follow-up) Modify DB updgrade

As per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84913|0   |1
is obsolete||

--- Comment #197 from Katrin Fischer  ---
Created attachment 85077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85077=edit
Bug 20581: API provide status_alias embed

- This patch provides the illrequests API route with an additional embed,
called 'status_alias'. Requesting this embed returns an object for the
request's status_alias authorised value, or null if one is not set.
- This patch also adds the new status_alias as a default embed on the API
call made by the illlist view

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #84912|0   |1
is obsolete||

--- Comment #196 from Katrin Fischer  ---
Created attachment 85076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85076=edit
Bug 20581: Provide status_alias on IllRequest

This patch provides status_alias support for the Koha::Illrequest
object.

- New 'statusalias' getter method, returns the request's status_alias
authorised value object if set, otherwise undef
- Overloads existing 'status' method, getter/setter accessors intact,
but setting the request's status now implicitly removes any status_alias
that has been set

Signed-off-by: niamh.walker-hea...@it-tallaght.ie

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

--- Comment #5 from Katrin Fischer  ---
I was looking for an example for that. I will have another look. Maybe just
push a variable to the template and wrap it all in if-else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #6 from Katrin Fischer  ---
... or just use the TT plugin. I will try it out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360

--- Comment #6 from David Cook  ---
I have a solution which will live in the automatic_renewals.pl script.

It'll essentially borrow the code from #22333 but put it into
automatic_renewals.pl wrapped with a system preference so that the first thing
automatic_renewals.pl does is check if it's too early to renew (ie consult No
Renewal Before or fallback to checking if it's before the due date).

I think this should be a good solution.

Just trialing it locally first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20360

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

--- Comment #2 from David Cook  ---
I don't have a formal test plan yet, since it's a fiddly bit of code and I have
other things to do, but I wanted to share the change anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22333

--- Comment #5 from David Cook  ---
I think I have a solution and I'll be

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22333

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19014

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

--- Comment #1 from David Cook  ---
Created attachment 85074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85074=edit
Bug 22333: Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

This patch replaces some duplicated code in CanBookBeRenewed by
using the GetSoonestRenewDate function.

This patch also refactors some of the auto_renew logic in CanBookBeRenewed,
so that it's more readable/maintainable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22333] New: Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

Bug ID: 22333
   Summary: Replace duplicated code in CanBookBeRenewed with
GetSoonestRenewDate
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

There is some duplicated code between CanBookBeRenewed and GetSoonestRenewDate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This feature allows the
  release notes||import and export of
   ||authority types to match
   ||the capabilities of biblio
   ||frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #92 from Aleisha Amohia  ---
Created attachment 85073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85073=edit
Bug 13952: (follow-up) Tests

Run:
prove -v t/db_dependent/ImportExportFramework.t and confirm all tests
pass.

I've also added a fix to remove the warns when exporting in ODS format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22332] Limit to currently available items in home library

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332

Jessie Zairo  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org,
   ||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22332] New: Limit to currently available items in home library

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332

Bug ID: 22332
   Summary: Limit to currently available items in home library
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
  Target Milestone: ---

When performing a search in the staff client you have a facet option to limit
to currently available items. It would be useful for multi site libraries to
have a second option to limit to currently available items in their home
library (library they are set to)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22331] New: Lost items that are written off gives credit when returned

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331

Bug ID: 22331
   Summary: Lost items that are written off gives credit when
returned
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bdaeu...@cityoffargo.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

When a lost item is written off by the library, but later returned, Koha gives
a credit for that item. To recreate:

1. Ensure "Refund lost item fee" is set to "Yes" in Circulation and Fine Rules.
2. Check out an item to a patron.
3. Mark item as lost. Replacement price should be added to their account. 
4. Write off the fee.
5. Return the item. A refund is generated.

A write off should not generate a refund in this situation. 

Is it possible this is related to Bug 19919 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #85064|0   |1
is obsolete||

--- Comment #24 from Arthur Suzuki  ---
Created attachment 85072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85072=edit
Bug 17229: Check if patron is expired in CanItemBeReserved

This way, calls to ILS-DI HoldTitle and HoldItem do this check too

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #85066|0   |1
is obsolete||

--- Comment #22 from Arthur Suzuki  ---
Created attachment 85070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85070=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #85070|0   |1
is obsolete||

--- Comment #23 from Arthur Suzuki  ---
Created attachment 85071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85071=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #74 from Maryse Simard  ---
Created attachment 85069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85069=edit
Bug 12446: (follow-up) Show all guarantees on the guarantor detail page

Only one guarantee is shown on the guarantor detail page. The
guarantees list should be passed to the template as a ref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

--- Comment #5 from Kyle M Hall  ---
Created attachment 85068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85068=edit
Bug 22330: Cache item and library objects when building the holds queue

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

--- Comment #4 from Kyle M Hall  ---
Created attachment 85067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85067=edit
Bug 22330: Transfer limits should be respected for placing holds in staff
interface and APIs

Branch transfer limits are respected for placing holds in the OPAC but nowhere
else. This should be remedied.

Test Plan:
1) Set up a branch transfer limit from Library A to Library B
2) Verify you cannot set up a hold for an item from Library A for pickup at
Library B from the staff interface ( without overriding )
3) Verify you cannot place that hold via ILS-DI
4) Verify you cannot place that hold via SIP
4) Verify a forced hold from Library A to Library B will not show up in the
holds queue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #55 from Kyle M Hall  ---
Moving to new bug that encompasses multiple old bugs.

*** This bug has been marked as a duplicate of bug 22330 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

--- Comment #2 from Kyle M Hall  ---
*** Bug 11024 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
Bug 22160 depends on bug 7376, which changed state.

Bug 7376 Summary: Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 CC||henridamien.laurent@biblibr
   ||e.com

--- Comment #3 from Kyle M Hall  ---
*** Bug 7376 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Patch doesn't apply |RESOLVED

--- Comment #11 from Kyle M Hall  ---
Moving to new bug that encompasses multiple old bugs.

*** This bug has been marked as a duplicate of bug 22330 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376
Bug 7376 depends on bug 11024, which changed state.

Bug 11024 Summary: Transfer limits should be respected in the 
build_holds_queue.pl -script.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024
Bug 11024 depends on bug 11020, which changed state.

Bug 11020 Summary: Transfer limits should be checked when placing a 
hold/reservation in Staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #1 from Kyle M Hall  ---
*** Bug 11020 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||7614
 Blocks|22160   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614
[Bug 7614] Use branch transfer limits for determining available opac holds
pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 CC||k...@bywatersolutions.com
 Resolution|--- |DUPLICATE

--- Comment #11 from Kyle M Hall  ---
Moving to new bug that encompasses multiple old bugs.

*** This bug has been marked as a duplicate of bug 22330 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||22330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330
[Bug 22330] Transfer limits should be respected for placing holds in staff
interface and APIs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|22330   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330
[Bug 22330] Transfer limits should be respected for placing holds in staff
interface and APIs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7614] Use branch transfer limits for determining available opac holds pickup locations

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||22330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330
[Bug 22330] Transfer limits should be respected for placing holds in staff
interface and APIs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Depends on||22330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330
[Bug 22330] Transfer limits should be respected for placing holds in staff
interface and APIs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] New: Transfer limits should be respected for placing holds in staff interface and APIs

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Bug ID: 22330
   Summary: Transfer limits should be respected for placing holds
in staff interface and APIs
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

Branch transfer limits are respected for placing holds in the OPAC but nowhere
else. This should be remedied.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22329] New: Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329

Bug ID: 22329
   Summary: Parent funds showing incorrect amounts for Ordered,
Spent, Available on Acquisitions Home
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

On acqui-home.pl, the amounts for Ordered and Spent for parent funds to no
reflect orders charged to their child funds, only orders charged to the parent
fund directly. I can see some room for argument here if libraries are are
sometimes charging a parent fund directly, but overall it may be more clear if
ordered and spent for a parent fund showed totals for all orders charged to the
parents AND its children.

Total Available for the parent is also based only on orders charged to the
parent directly and this is definitely misleading. Total available for a parent
fund should display as total allocated to parent minus (total ordered/spent for
parent plus total ordered spent for all children).

These changes would bring acqui-home.pl in line with the numbers shown on
aqbudgets.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22328] Inconsistent behavior throughout acquisitions for determining whether or not an item as been received

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22328

Nick Clemens  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22328] Inconsistent behavior throughout acquisitions for determining whether or not an item as been received

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22328

Andrew  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22328] New: Inconsistent behavior throughout acquisitions for determining whether or not an item as been received

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22328

Bug ID: 22328
   Summary: Inconsistent behavior throughout acquisitions for
determining whether or not an item as been received
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

When an aqorders line has quantityreceived>0 but datereceived is NULL, fund
totals shows inconsistently across acquisitions. 

To test:
- create an order with quantityreceived=1 and datereceived NULL (this may need
to be done from the command line)
- find the relevant fund in the All Available Funds table at acqui-home.pl,
note that the order is reflected in the Spent total
- Click through to spent.pl for the relevant fund, note that the order is not
reflected here
- Click through to ordered.pl for the relevant fund, note that the order is not
reflected here either


I'll acknowledge that it shouldn't really be possible for an item to have a
quantityreceived without a datereceived -- I haven't yet figured out how the
library I found this on did it -- but the inconsistent logic is an issue
nonetheless.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22327] New: Circulation Rules simplification

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22327

Bug ID: 22327
   Summary: Circulation Rules simplification
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

What if the rules table was a condensed summary table, linkable to a modal that
opened up with options for the rule that is clicked?

Would also like to see the ability to test rules out by plugging in variables
and see what rule runs with it.  This would help greatly in troubleshooting the
rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #85065|0   |1
is obsolete||

--- Comment #21 from Arthur Suzuki  ---
Created attachment 85066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85066=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22326] New: decreaseLoanHighHolds flexibility

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22326

Bug ID: 22326
   Summary: decreaseLoanHighHolds flexibility
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

decreaseLoanHighHolds would benefit to be tied in to circulation rules.  I
would suggest setting up a table that would allow you to set individual rules
for item types or groups of item types or collections in the preference.

I would suggest staying away from tying this into the circulation rules table,
as that would overly bloat the already bloated table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #72971|0   |1
is obsolete||

--- Comment #20 from Arthur Suzuki  ---
Created attachment 85065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85065=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

--- Comment #19 from Arthur Suzuki  ---
Not sure what I did is right but rebased this patch so that it applies to
branch master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #72970|0   |1
is obsolete||

--- Comment #18 from Arthur Suzuki  ---
Created attachment 85064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85064=edit
Bug 17229: Check if patron is expired in CanItemBeReserved

This way, calls to ILS-DI HoldTitle and HoldItem do this check too

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #37 from David Gustafsson  ---
(In reply to Ere Maijala from comment #33)
> David Gustafsson, what do you think about the latest one?

Hello! Sorry about the late reply. I have been a little bit buried in non-Koha
related work the last few months. I think it looks good. I first found it a
little bit hardcore with a low-level fork implementation, but since there is no
need to spawn and wait for workers more than once when using several long lived
threads equal to the concurrency level, the code is simple enough to
understand. 

If I may make a suggestion I think starting the slice index on 0 instead of 1
and assign index using "$slice_index = $proc - 1" in the process dispatch loop
would get rid of the "$slice_modulo = 0 if ($slice_modulo == $slice_count);"
condition in the iterator.

I think I will be able to test the patch tomorrow and can provide a patch for
this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5739] Check out waiting holds directly from "hold waiting" alerts on circulation screen

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5739

--- Comment #7 from Liz Rea  ---
Having a thought to revisit this - would something like 

barcode ([link to patron detail]) be better?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

--- Comment #6 from David Nind  ---
Thanks Galen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

Galen Charlton  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

--- Comment #5 from Galen Charlton  ---
(and header)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

--- Comment #4 from Galen Charlton  ---
I've updated the index page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22177] Update years for meetings.koha-community.org

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22177

Liz Rea  changed:

   What|Removed |Added

   Assignee|wizzy...@gmail.com  |gmcha...@gmail.com
 Status|In Discussion   |ASSIGNED

--- Comment #3 from Liz Rea  ---
Righto, I've poked Galen about this one. :)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22304] Bugzilla blocked by UK mobile network EE

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22304

Liz Rea  changed:

   What|Removed |Added

   Assignee|wizzy...@gmail.com  |ch...@bigballofwax.co.nz
 Status|NEW |ASSIGNED
 CC||wizzy...@gmail.com

--- Comment #2 from Liz Rea  ---
Hi,

Chris will need to investigate this one. :)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing)

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

  Attachment #75389|0   |1
is obsolete||

--- Comment #12 from claire.hernan...@biblibre.com 
 ---
Created attachment 85063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85063=edit
Bug 20390: (follow-up) UNIMARC biblio mappings

Changes from Laurence

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #78 from David Gustafsson  ---
(And in many other places). Should perhaps not matter though if "an" never
contains whitespace.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #77 from David Gustafsson  ---
Could the cause be that the value of an: is unquoted in clause where
UseAuthoritiesForTracings is set in the excerpt below
(koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl line
308):



av




/cgi-bin/koha/catalogue/search.pl?q=an:


/cgi-bin/koha/catalogue/search.pl?q=au:""



-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #76 from David Gustafsson  ---
Oops, bug 22325 I mean, perhaps you linked to the wrong bug number in the
previous comment?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #75 from David Gustafsson  ---
(In reply to Nick Clemens from comment #69)
> Extra note: I found that indexes like 'se' and 'an' were not searchable - no
> results were returned from faceting or searchign like "se:pengiun" changing
> to title-series (or even 'ser' in testing) seemed to work

About this issue and the "an" alias, this does not work with this patch
applied? The alias seems to exist in the %index_field_convert map, and is
expanded as far as I can tell. But could look into this if not working. I got a
little bit confused since bug 20388 says "'se' is fixed in bug 19575". :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user

2019-02-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Martin Renvoize  ---
Hmm.. I would love to see this in.. but I don't think it's really ready as it
stands.. it's not comprehensive (only works in circulation, not patron
searching in general and even within circulation it's not updating in the case
where a borrower is found by their cardnumber rather than any other search
fields).

The routines are also not especially generalised, expecting the return of a
datatables centric method call rather than a Koha::Patron (or even borrower
row) structure.

I'm afraid I'd have to Fail QA on it for those reasons.  Not sure I'm going to
get around to proposing an alternate solution any time soon though :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >