[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #34 from Ere Maijala --- It'd be fine for me to change _truncate_terms to something more general. That'd be a good place to do any other clean up, escaping or query terms transformations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #24 from Josef Moravec ---
I am still getting this fron QA tools:
FAIL members/maninvoice.pl
FAIL valid
(Missing operator before $error?)
Global symbol "$template" requires explicit package name (did
you forget to declare "my $template"?)
Scalar found where operator expected
Can't redeclare "my" in "my"
members/maninvoice.pl has too many errors.
Global symbol "$cookie" requires explicit package name (did you
forget to declare "my $cookie"?)
Global symbol "$loggedinuser" requires explicit package name
(did you forget to declare "my $loggedinuser"?)
Global symbol "$error" requires explicit package name (did you
forget to declare "my $error"?)
"my" variable $input masks earlier declaration in same scope
Type of arg 1 to Try::Tiny::catch must be block or sub {} (not
reference constructor)
syntax error
Also test don't pass:
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. 1/6
# Failed test 'Got correct offset type'
# at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 81.
# got: 'Lost Item'
# expected: 'Manual Debit'
# Failed test 'No tests run for subtest "auto_too_much_oweing |
OPACFineNoRenewalsBlockAutoRenew"'
# at t/db_dependent/Circulation.t line 703.
Can't use string ("FU") as a subroutine ref while "strict refs" in use at
t/db_dependent/Circulation.t line 668.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22361] Not able to create Vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Avi, Which is the exact version of Koha you are using? How was it installed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22361] Not able to create Vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361 Avi changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22361] New: Not able to create Vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361 Bug ID: 22361 Summary: Not able to create Vendor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: avin...@isdi.in QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.26/DBI.pm line 2081. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22361] Not able to create Vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22361 Avi changed: What|Removed |Added CC||avin...@isdi.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22327] Circulation Rules simplification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22327 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I noticed recently that "lastseen" updates for "Patron logs into OPAC" and "Patron is authenticated via SIP2" and that's it. I've had libraries interested in the field being updated for the other activities Nicole mentioned as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #51 from David Cook --- (In reply to Ere Maijala from comment #50) > Unfortunately cached prepared statements don't work well with Plack where > the process can outlive the MySQL connection. We found that reconnection to > MySQL would leave the prepared statements holding on to the previous > connection leading to "MySQL server has gone away" errors. All this could be > overcome with additional logic, but that'd be another effort. That's an interesting point, although I was thinking of just caching (actually, re-using is probably a more accurate word than caching here) the prepared statement in the scope of the batch operation. I wouldn't cache it at the level of the Plack web server. I actually had to deal with that reconnection issue on a separate project recently (see "validate-on-match" and "background-validation" at https://docs.jboss.org/jbossas/docs/Server_Configuration_Guide/beta500/html/ch13s13.html). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > Done with a script, see > commit 582502644801b44595497caf6bbee449f0347238 > Bug 21526: uri escape TT variables when used in 'a href' > We may need to adjust some occurrences manually. I'm not sure what you're saying, Jonathan. Do you mean that the filter was added by the script and that we need to remove the filters manually? If so, what would prevent the filters from being re-added by a script in the future? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #7 from Iming Chan --- We are running Koha 18.11.02. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #6 from Iming Chan --- Created attachment 85232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85232=edit Biblio. with "On Order" detail missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #5 from Iming Chan --- Created attachment 85231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85231=edit Acquisition detail for the biblio. record for library staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #4 from Iming Chan --- Created attachment 85230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85230=edit OPACacquisitiondetail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #3 from Iming Chan --- (In reply to Katrin Fischer from comment #1) > Hi Irmin, can you give us some more information? > > - Where did you choose to create items on creating the basket? We haven't created the item until it is received from the supplier. > - Where are you missing the information (which page? acquisition module or > somewhere else?) The missing information is at the bottom of OPAC page. I have supplied and attached additional screen images. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19378] Onboarding tool should allow configuration of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19378 Aleisha Amohia changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19378] Onboarding tool should allow configuration of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19378 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | --- Comment #1 from Aleisha Amohia --- Will start working on this when I get a chance! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 --- Comment #2 from Katrin Fischer --- Is OPACAcquisitionDetails active? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Irmin, can you give us some more information? - Where did you choose to create items on creating the basket? - Where are you missing the information (which page? acquisition module or somewhere else?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Iming Chan changed: What|Removed |Added Summary|On order information|On order information |missing |missing in OPAC normal ||display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] New: On order information missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Bug ID: 22360 Summary: On order information missing Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: im...@rosewoodfarm.com.au QA Contact: testo...@bugs.koha-community.org Target Milestone: --- On order information is missing when there is an order linked to the bibliographic record. The order is showing under "Acquisitions" tab in the staff catalogue record correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #264 from Josef Moravec --- I tested again. I have to say it is looking good. So there is the only last thing, but big one: the tests... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Attachment #84321|0 |1 is obsolete|| --- Comment #261 from Josef Moravec --- Created attachment 85227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85227=edit Bug 10662: (QA follow-up) Enhance marc matchers description Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Attachment #84320|0 |1 is obsolete|| --- Comment #260 from Josef Moravec --- Created attachment 85226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85226=edit Bug 10662: (QA follow-up) Fix plural in pod and use statements Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Attachment #85152|0 |1 is obsolete|| --- Comment #262 from Josef Moravec --- Created attachment 85228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85228=edit Bug 10662: (follow-up) Template corrections and improvements This patch makes a number of corrections and improvements to the OAI harvester templates: - Add missing DataTables CSS include - Replace YUI grid with Bootstrap - Correct style of inline dialogs (.dialog.alert, .dialog.message) - Correct class of form hint and error messages - Format dates in saved and submitted requests tables - Add title-string sorting to DataTables configuration - Add delete confirmation to saved and submitted tables - Disable sorting on action columns - Style action links inside tables as buttons - Removed commented markup - Add missing JavaScript include (tools-menu.js) to highlight active section in sidebar menu - Add CodeMirror styling to record view page (CodeMirror XML mode file is added to enable this) - Remove invalid
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #263 from Josef Moravec --- Created attachment 85229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85229=edit Bug 10662: (QA follow-up) Make atomic update consistent with kohastructrure. Remove utf8 charset Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Attachment #84319|0 |1 is obsolete|| --- Comment #259 from Josef Moravec --- Created attachment 85225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85225=edit Bug 10662: (QA follow-up) provide DBIC schema files DBIC schema files Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What|Removed |Added Attachment #84318|0 |1 is obsolete|| --- Comment #258 from Josef Moravec --- Created attachment 85224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85224=edit Bug 10662: Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. Signed-off-by: Andreas Hedström Mace Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22354] Protect existing specified tags when importing and overlaying with z39 record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22354 --- Comment #2 from Joy Nelson --- Thanks Katrin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22334] Missing modules on perldoc.k-c.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22334 Jonathan Druart changed: What|Removed |Added Summary|perldoc is not complete |Missing modules on ||perldoc.k-c.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232
Jonathan Druart changed:
What|Removed |Added
Severity|normal |major
--- Comment #5 from Jonathan Druart
---
Now failing with
Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/Koha/Subscription.pm line 165
Koha::Subscription::get_sharable_info('Koha::Subscription', 1) called
at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123
Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription')
called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82
Koha::SharedContent::send_entity('', 51, 1, 'subscription') called at
/home/vagrant/kohaclone/serials/subscription-add.pl line 376
CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl::redirect_add_subscription
at /home/vagrant/kohaclone/serials/subscription-add.pl line 178
It's time to add the missing FK
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
--- Comment #456 from Jonathan Druart
---
A couple of things wrong in serials/subscription-add.pl
1.
447 if ( defined( $query->param('mana_id') ) ) {
It's always defined, you wanted to test with ""
2.
375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq
"subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){
Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22316] Double quotes in borrowernotes breaks table sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20891 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- (In reply to Magnus Enger from comment #0) > Tested with 18.11.02. Probably somewhat related to bug 21986. I think it's more related to bug 20891. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29 from Jonathan Druart --- sudo cpanm Plack::Middleware::LogErrors sudo cpanm Plack::Middleware::LogWarn sudo cp debian/templates/plack.psgi /etc/koha/plack.psgi sudo cp etc/log4perl.conf /etc/koha/sites/kohadev/log4perl.conf sudo cp debian/templates/log4perl-site.conf.in /etc/koha/log4perl-site.conf.in restart plack I get: Log4perl: Seems like no initialization happened. Forgot to call init()? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587
--- Comment #8 from Jonathan Druart
---
(In reply to Koha Team Lyon 3 from comment #7)
> Still doesn't work in a 17.11.13.000 koha version.
> If you add a user to notify in a new order, then save the order and after
> click on modify : there's no user to notify displayed in this order.
> If you modify the same order to add a user to notify,then save the order and
> after click on modify : you can see the user who have add to notify
Confirm!
Works ok for other versions however.
The issue comes from a wrong merge conflict:
289 ModOrderUsers( $orderinfo->{ordernumber}, @order_users );
vs
299 ModOrderUsers( $order->ordernumber, @order_users );
Frido: Why did you change this line?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22356] Warnings when running fines.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22356 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21753 --- Comment #1 from Jonathan Druart --- Same from Circulation.t, see bug 21753 comment 13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 --- Comment #13 from Jonathan Druart --- git bisect blames commit aa71519660a43cebc734763e4821818dfc636775 Bug 21753: Remove all reference of chargename from scripts for the following warning from t/db_dependent/Circulation.t: Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22356 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 --- Comment #11 from Jonathan Druart --- (In reply to Nick Clemens from comment #10) > I missed this one and filed 22260 > > I am wondering if one situation is preferable to the other (subquery vs > adding all fields to group by) > > Bug 20182 and 21723 imply there may be some issues here - can we get some > opinions here on the best way to fix these situations? Could you benchmark the 2 queries on a big production DB? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #17 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #16) > (In reply to Jonathan Druart from comment #15) > > What about generate a password if none is provided? > > You talking about the set_password.pl script? Yep! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22349] Overzealous deletion of data in t/db_dependant/Koha/Acquisitions/Booksellers.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22349 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22349] Overzealous deletion of data in t/db_dependant/Koha/Acquisitions/Booksellers.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22349 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22349] Overzealous deletion of data in t/db_dependant/Koha/Acquisitions/Booksellers.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22349 Jonathan Druart changed: What|Removed |Added Attachment #85177|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 85223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85223=edit Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 --- Comment #4 from Jonathan Druart --- Created attachment 85222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85222=edit Bug 21904: Add missing PROCESS stt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #20 from Jonathan Druart --- Back to SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #29 from Jonathan Druart
---
(In reply to Josef Moravec from comment #27)
> So, let's start QA process:
>
> 1) Pass the database name from proverc file is not possible, but still in
> .proverc.dist as example/default...
Yes, maybe we need to remove proverc in this iteration, and readd it later. So
far no args is used from Bootstrap.
> 2) No tables are created in Bootstrap.pm, the structure creation was removed
> in
> "Do not modify KOHA_CONF, use new database_test entry instead" patch
Yes it is:
30 $dbh->do("DROP DATABASE IF EXISTS $database_test");
31 $dbh->do("CREATE DATABASE $database_test");
I cannot retest right now, my selenium tests do not run (local issue).
TODO: remove proverc and update the test plan.
Test plan:
- prove t/db_dependent/selenium/authentication.t # "database" from conf will
be used
- prove -Mt::lib::Bootstrap t/db_dependent/selenium/authentication.t # will
die because "database_test" does not exist
- Add the database_test entry to your koha-conf, use the same value as database
- prove -Mt::lib::Bootstrap t/db_dependent/selenium/authentication.t # die
with "same values"
- Modify database_test to be different than database
- prove -Mt::lib::Bootstrap t/db_dependent/selenium/authentication.t # Will
drop, create and use "database_test" to run the tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22342 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #1 from Katrin Fischer --- I'll start: 1) I am not a fan of the extra step the modal adds: - you click 'confirm' - modal appears to 'confirm' There is a lot of text on the modal which I think makes it hard to 'parse' quickly. It also feels a bit 'extra' as the change was already shown before I clicked 'confirm'. - Could we improve/simplify the text? - Could we add keyboard shortcuts to yes/no like in other spots? - could we make the amount stand out more visually as this is the most important information? 2) For me it's not clear what goes into which input field and I think it might get worse with translation. We got: Amount paid : (additonal space should be removed) Collect from patron: It's not clear to me what does input fields each are meant for :( Should it be: Collect_ed_ from patron? - Could we improve the labels to be more clear? - Could it make sense to set the fields apart a bit visually as the change calculation is optional? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22359] New: Improve usability of 'change calculation' (bug 11373)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Bug ID: 22359 Summary: Improve usability of 'change calculation' (bug 11373) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 11373 Target Milestone: --- There has been some discussion about the usability of the change calcualation feature from bug 11373. Adding a bug to collect comments and suggestions in a central spot in hope that we will be able to improve things prior to the 19.05 release :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #90 from Katrin Fischer --- (In reply to Katrin Fischer from comment #89) > I have to say I am not a fan of the modal. It adds an extra step and has too > much text. I got some more feedback in chat - I've added bug 22359 for more discussion and ideas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Katrin Fischer changed: What|Removed |Added Blocks||22359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850 --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #4) > This bug number got into the 19.05 release notes because of a typo: > > http://git.koha-community.org/gitweb/?p=koha.git;a=commit; > h=6d44f9dac8235dfe0259ea5b935c5a8908d2e441 I added an issue to the release notes repository: https://gitlab.com/koha-community/koha-release-notes/issues/6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850 --- Comment #4 from Katrin Fischer --- This bug number got into the 19.05 release notes because of a typo: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6d44f9dac8235dfe0259ea5b935c5a8908d2e441 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22355] site can't be reached in koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22355 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Hi tapu, This sounds like a support request/installation issue rather than a bug. Please ask your question on the mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22354] Protect existing specified tags when importing and overlaying with z39 record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22354 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Joy, I think this is a duplicate to bug 14957 that is waiting for sign-off. *** This bug has been marked as a duplicate of bug 14957 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #137 from Katrin Fischer --- *** Bug 22354 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #455 from Katrin Fischer --- (In reply to Jonathan Druart from comment #454) > Please add POD to Koha::SharedContent: > > perldoc Koha/SharedContent.pm > > DESCRIPTION > Package for accessing shared content via Mana > > Package Functions >process_request >increment_entity_value >send_entity >prepare_entity_data >get_entity_by_id >search_entities >build_request >get_sharing_url Moved to Bug 22358 - Add POD to Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22358] New: Add POD to Koha::SharedContent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Bug ID: 22358 Summary: Add POD to Koha::SharedContent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 17047 Target Milestone: --- Moved from bug 17047 comment 454: Please add POD to Koha::SharedContent: perldoc Koha/SharedContent.pm DESCRIPTION Package for accessing shared content via Mana Package Functions process_request increment_entity_value send_entity prepare_entity_data get_entity_by_id search_entities build_request get_sharing_url Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer changed: What|Removed |Added Blocks||22358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 [Bug 22358] Add POD to Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #32 from Katrin Fischer --- Rebase? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Katrin Fischer changed: What|Removed |Added Attachment #84154|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 85221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85221=edit Bug 21692: created a test for Koha::Account->new Test plan: 1) Run test for /Koha/Account.t and confirm that all tests were successful Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21691] Koha::Account->non_issues_charges has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #84123|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply Component|Architecture, internals,|Fines and fees |and plumbing| CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com Summary|Development for fines and |Detailed description of |Fees Module - Detailed |charges on Accounting tab |Description of charges in | |Patron Account Tab/Fines| |Tab | --- Comment #31 from Katrin Fischer --- Hi Devinim, can we please get a rebase? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #28 from Katrin Fischer --- Tiny issue: FAIL t/db_dependent/Holds.t OK critic FAIL forbidden patterns forbidden pattern: tab char (line 142) OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer --- Same question from me - as this changes a core routine not only used for ILS-DI, what are the consequences in the GUI? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22357] New: Every run of runreport.pl with --store-results creates a new row in saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Bug ID: 22357 Summary: Every run of runreport.pl with --store-results creates a new row in saved reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- While testing bug 22323 I noticed an issue with the reports table in combination with stored results. Stealing a part of the test plan: 1) Create a new item with itemnotes 'accentué' 2) Create a report and note the report number ... 5) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results ... 7) Go to saved reports table 8) Look at the table, each run of the cronjob will create a new row in the table instead of just updating the saved results column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22323] Cronjob runreport.pl has a CSV encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Katrin Fischer changed: What|Removed |Added Attachment #85189|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 85220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85220=edit Bug 22323: cronjob runreport.pl CSV add encoding Cronjob runreport.pl runs SQL reports and can export as CSV. This export needs to be UTF-8 encoded. This pathes replaces use of Text::CSV_XS by Text::CSV::Encoded like in other places like tools/viewlog.pl. It adds a decode of headers bcause they will be encoded lika other lines. Test plan: 1) Create a new item with itemnotes 'accentué' 2) Create a SQL report with : SELECT barcode,itemnotes AS itè FROM items WHERE itemnotes LIKE 'accenté' 3) Run this report 4) You see well encoded header and content 5) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 6) You well encoded header and content 7) Go to saved reports table 8) Look at saved results of report 9) You well encoded header and content Signed-off-by: Mikaël Olangcay Brisebois Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22323] Cronjob runreport.pl has a CSV encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22323] Cronjob runreport.pl has a CSV encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Katrin Fischer changed: What|Removed |Added Summary|cronjob runreport.pl CSV|Cronjob runreport.pl has a |encoding issue |CSV encoding issue CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Katrin Fischer changed: What|Removed |Added Attachment #84339|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 85219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85219=edit Bug 22200: Forgiving a fine (FFOR) does not update the accountline date Each time a fine is incremented, the date column is updated. When that fine is forgiven ( often via the "Forgive fines" option on the checkin page ), it does not update the column. It makes sense that if updating a fine sets the date column, forgiving it should do so as well. Test Plan: 1) Find a checkout that is overdue with fines, where the date is not today 2) Note the date in the accountlines table 3) Check it in, note the date is not updated 4) Apply this patch 5) Repeat steps 1-2 6) Note the date is updated! Signed-off-by: Genevieve Beaudry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- I've fixed the commit subject and added Genevieve's sign-off line manually. But I am a little confused here :( I started my tests with verifying the current behavior and noticed that accountlines.date is already updated to the current date when the entry is changed to FFOR in my testing. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22356] New: Warnings when running fines.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22356 Bug ID: 22356 Summary: Warnings when running fines.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- This might point to a problem: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/fines.pl Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. Use of uninitialized value $actionname in concatenation (.) or string at /home/vagrant/kohaclone/C4/Log.pm line 85. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Katrin Fischer changed: What|Removed |Added Attachment #85199|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 85218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85218=edit Bug 21870: Convert browser alerts to modals: OPAC user summary This patch updates the user summary page in the OPAC so that JavaScript alerts are replaced with Bootstrap modals. This provides us the ability to more carefully control the content of confirmation dialogs and their control buttons. A global function for defining a modal confirmation boxes has been added, to which one can pass: - The modal title - Body - Text for submit and cancel buttons - A callback function to trigger on submit To test, apply the patch and clear your browser cache if necessary. - Log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Jose-Mario Monteiro-Santos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Just a note for now: The space in front of strings seems to get lost in translations. Example: Resume all suspended holds http://translate.koha-community.org/sv/translate/#search=Resume%20all%20suspended%20holds=source,target=exact,case=8394611=0 Strings here are the same before and after, so not a reason to fail, but something we might want to keep in mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hi Owen, there are some 'red flags' in the QA script, can you please take a look and fix/comment? In testing it did work well so far: FAILkoha-tmpl/intranet-tmpl/prog/en/includes/str/cataloging_additem.inc OK filters OK forbidden patterns OK git manipulation FAIL js_in_body A
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer --- (In reply to Jonathan Druart from comment #11) > I am not convinced we really need this additional parameter (and even less > the new subroutine). > > The following is much more readable IMO: > [% USE date %] > [% date.format(biblio.timestamp, '%F') %] > [% date.format(biblio.timestamp, '%Y-%m-%d') %] > > > The only advantage would be to take into account the timezone if defined in > the config. Just some thoughts here: So without the patch the above constructs only display the server time, but not the configured time? If that's correct a syntax taking the timezone into account might prove really helpful over time. The advantage I see with using standard template toolkit operations is better documentation and flexibility. At the moment the TT notices remain rather unhelpful to libraries, because we lack documentation and examples (Josef++ for his work on documentation this week) What other formats would the new parameter support? In what kind of situations would it be useful? I miss a 'real life example' in the test plan to make things more clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||josef.mora...@gmail.com, ||tomasco...@gmail.com --- Comment #71 from Katrin Fischer --- I'd really like to get a second set of QA eyes on the code for this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
