[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 David Cook changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |dc...@prosentient.com.au |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #8 from David Cook --- Test plan: 1. Create data in your test Koha as follows: Layout: Units: PostScript Points Field 1 Text: Font: Times-Roman Font size: 20pt Text alignment: Center Lower left X coordinate: 40pt Lower left Y coordinate: 20pt Barcode Print card number as barcode: checked Lower left X coordinate: 0 Lower left Y coordinate: 50 Print card number as text under barcode: checked -- -- Template: Units: SI Millimeters Page height: 32mm Page width: 95mm Card width: 95mm Card height: 30mm Top page margin: 5mm Left page margin: 2mm Number of columns: 1 Number of rows: 1 -- -- User: Cardnumber: 1 Surname: Test Firstname: 12345678 123456 (Test) 2. Before applying the patch, try to export a batch that contains the user with cardnumber 1 3. Note that Apache will timeout and that create-pdf.pl infinitely loops in the background (I haven't tested with Plack, but Katrin has mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429#c1 that it will bring down the instance.) 3a. ps -efww | grep "create-pdf" 4. Apply the patch 5. Note that the patron card is generated and downloaded via your browser -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #7 from David Cook --- Created attachment 85972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85972=edit Bug 22429: Infinite loop in patron card printing Text fields in Patron Card Text Layouts can contain regular expression metacharacters, which - instead of being treated as literal values - are interpreted and prevent line wrapping. This causes the process to get stuck in an infinite loop, which keeps running even after the web server has timed out (at least when using CGI). This patch escapes the relevant input from the text field so the regular expression substitution treats characters as literals instead of as metacharacters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #6 from David Cook --- Aha... it's the parentheses which are the problem. They're being interpreted as regex metacharacters and not literal values! First line: '12345678 123456 (Test) Test' First string width: 299.775390625 First $1: ' Test' First $trim: '' Next line: '12345678 123456 (Test)' Next string width: 249.94140625 Next $1: ' (Test)' Next $trim: ' (Test) Test' Next line: '12345678 123456 (Test)' Next string width: 249.94140625 Next $1: ' (Test)' Next $trim: ' (Test) (Test) Test' And the $trim just keeps prepending (Test) over and over again. -- Fortunately, this is a very easy solve. I change the following $line =~ s/$1//; to $line =~ s/\Q$1\E//; And voila. It works. I bet this sort of "regular expression injection" could bite us in other parts of Koha... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #5 from David Cook --- Forgot to mention the problem is in C4/Patroncards/Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #1) > We have seen conditions where exporting a batch of patron cards brings down > the instance. Do you know how the patron cards need to be set up to create > this one? I don't have master conditions yet but in a 17.05.x I've reproduced with the following: -- Layout: Units: PostScript Points Field 1 Text: Font: Times-Roman Font size: 20pt Text alignment: Center Lower left X coordinate: 40pt Lower left Y coordinate: 20pt Barcode Print card number as barcode: checked Lower left X coordinate: 0 Lower left Y coordinate: 50 Print card number as text under barcode: checked -- -- Template: Units: SI Millimeters Page height: 32mm Page width: 95mm Card width: 95mm Card height: 30mm Top page margin: 5mm Left page margin: 2mm Number of columns: 1 Number of rows: 1 -- -- User: Cardnumber: 1 Surname: Test Firnatme: 12345678 123456 (Test) -- This can generate an infinitely looping process of /home/dcook/git/patroncards/create-pdf.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||hayleymap...@catalyst.net.n ||z --- Comment #4 from Hayley Mapley --- Patch does not apply. Applying: Bug 21948: Clean up style of item detail page .git/rebase-apply/patch:46: trailing whitespace. No. of items: [% count | html %][% IF ( hiddencount ) %]total ([% showncount | html %] shown / [% hiddencount | html %] hidden) error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 21948: Clean up style of item detail page The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22434] correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #2 from Hayley Mapley --- Hi, I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #81 from David Cook --- Looking at the patches, is the idea that you'd have a routing list per issue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #39 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #38) > In my opinion we should fix bug 22420 first. No, 22420 won't be fixed if the weights are wrongly calculated, which is fixed here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Needs Signoff |Patch doesn't apply --- Comment #27 from Hayley Mapley --- Patch 54542 did not apply cleanly. Marking as Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22395] Data in 245 field (subfield a or b) will be deleted if it has Quotation Marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22395 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 Hayley Mapley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 --- Comment #2 from Hayley Mapley --- Created attachment 85971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85971=edit Bug 22366: Amended help text - Web Installer step2 On Step 2 of the Web Installer, the 'Need Help?' section refers to MySQL documentation if the DB used is MySQL, or refers to PostgreSQL documentation in all other cases. This patch removes the reference to PostgreSQL and instead only displays the 'Need Help' text if the user's database is MySQL. To test: When running the Web Installer, if you are using MySQL then text that says Need Help? with a link to the documentation should be present. If you are using anything else (PostgreSQL, MariaDB, etc.), this text and link should not be present. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #38 from Jonathan Druart --- In my opinion we should fix bug 22420 first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #18 from Jonathan Druart --- TODO, remove that: Bug 15032: UpdateDB entry +# $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" ); Bug 22417: Add the ability to cancel a job +sleep(5); :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #17 from Jonathan Druart --- (In reply to David Cook from comment #15) > If I understand correctly, each Koha instance would get its own RabbitMQ > "vhost", and within each "vhost" there would be named queues (which at the > moment are hard-coded but could be configurable I suppose). I imaged one koha-worker script per Koha instance, with as well one vhost. The queues would be named 'batch_record_modification', 'manage-marc-import', 'batch_item_modification', etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jonathan Druart changed: What|Removed |Added Resolution|FIXED |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 --- Comment #1 from Jonathan Druart --- I guess this apply for other permissions as well. It seems tedious to handle that case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #58 from Jonathan Druart --- Created attachment 85970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85970=edit Bug 18235: Do not call get_facetable_fields excessively -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #57 from Jonathan Druart --- Created attachment 85969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85969=edit Bug 18235: Update facet_order default value in atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18235] Elastic search - Configurable facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #56 from Jonathan Druart
---
(In reply to Josef Moravec from comment #50)
> Comment on attachment 85214 [details] [review]
> Bug 18235: DB changes
>
> Review of attachment 85214 [details] [review]:
> -
>
> :::
> installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql
> @@ +1,1 @@
> > +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0'
> > AFTER weight;
>
> Here is default 0
>
> ::: installer/data/mysql/kohastructure.sql
> @@ +1493,4 @@
> >`label` varchar(255) NOT NULL COMMENT 'the human readable name of the
> > field, for display',
> >`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn',
> > 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when
> > storing it in the search engine',
> >`weight` decimal(5,2) DEFAULT NULL,
> > + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the
> > field in facet list if faceted',
>
> And here NULL
Right, must be NULL in the atomic update file.
(In reply to Josef Moravec from comment #51)
> Comment on attachment 85212 [details] [review]
> Bug 18235: ES - Facets configurable
>
> Review of attachment 85212 [details] [review]:
> -
>
> ::: Koha/SearchEngine/Elasticsearch.pm
> @@ +971,5 @@
> > +my @faceted_fields = Koha::SearchFields->search(
> > +{ name => { -in => \@search_field_names }, facet_order => { '!='
> > => undef } }, { order_by => ['facet_order'] }
> > +);
> > +my @not_faceted_fields = Koha::SearchFields->search(
> > +{ name => { -in => \@search_field_names }, facet_order => undef },
> > { order_by => ['facet_order'] }
>
> Why do you retrieve fields from database in 2 queries, you always use them
> all.
To have the not faceted fields at the end of the array. I agree it's a lazy way
to handle that, but it works :)
> ::: admin/searchengine/elasticsearch/mappings.pl
> @@ +215,4 @@
> > push @all_search_fields, $search_field_unblessed;
> > }
> >
> > +my @facetable_fields =
> > Koha::SearchEngine::Elasticsearch->get_facetable_fields();
>
> get_facetable_fields is called 3 or 4 times every run of mappings.pl.
Yep, could be lowered to 2.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 Hayley Mapley changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n |ity.org |z CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Attachment #82347|0 |1 is obsolete|| Attachment #85967|0 |1 is obsolete|| --- Comment #42 from Jonathan Druart --- Created attachment 85968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85968=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley changed: What|Removed |Added Attachment #85966|0 |1 is obsolete|| --- Comment #41 from Hayley Mapley --- Created attachment 85967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85967=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #40 from Hayley Mapley --- Created attachment 85966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85966=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Hayley Mapley changed: What|Removed |Added Assignee|fridolin.som...@biblibre.co |hayleymap...@catalyst.net.n |m |z CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #7 from Brian --- I just know that it is related to at least 3 other patches of a ticket that concerns a problem with the Validation for *MandatoryField and *UnwantedField sysprefs. For now I'm putting my foot in the door as to speak so I receive email updates when progress is made and hopefully the patch is eventually finished -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
