[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Hayley Mapley changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #30 from Hayley Mapley --- It appears that the default_circ_rules table is no longer used in the current development version. Should this table be removed from the database? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||hayleymap...@catalyst.net.n ||z --- Comment #5 from Hayley Mapley --- Test fails with the following error: t/db_dependent/Circulation.t .. 122/126 # No tests run! t/db_dependent/Circulation.t .. 123/126 # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge tests"' # at t/db_dependent/Circulation.t line 2948. Can't call method "lengthunit" on an undefined value at /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. # Looks like your test exited with 11 just after 123. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 4/126 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) Failed test: 123 Non-zero exit status: 11 Parse errors: Bad plan. You planned 126 tests but ran 123. Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr 3.22 csys = 21.89 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #7 from Hayley Mapley --- Test fails with the following error: t/db_dependent/Circulation.t .. 122/126 # No tests run! t/db_dependent/Circulation.t .. 123/126 # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge tests"' # at t/db_dependent/Circulation.t line 2948. Can't call method "lengthunit" on an undefined value at /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. # Looks like your test exited with 11 just after 123. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 4/126 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) Failed test: 123 Non-zero exit status: 11 Parse errors: Bad plan. You planned 126 tests but ran 123. Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr 3.22 csys = 21.89 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Hayley Mapley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #3 from Hayley Mapley --- Created attachment 86497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86497=edit Modified to pass QA tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #2 from Hayley Mapley --- Created attachment 86496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86496=edit Bug 22489: Fixed issue with onboarding tool failing at step 5 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #7 from Agustín Moyano --- Created attachment 86495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86495=edit Bug 21772: (follow-up) Included more information on tab label for SCO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n |ity.org |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Katrin Fischer --- A slightly different approach, using the news system istead of system preferences: bug 15326 *** This bug has been marked as a duplicate of bug 15326 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Bug 7840 depends on bug 12806, which changed state. Bug 12806 Summary: Adding 'Koha as a CMS' to the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer changed: What|Removed |Added CC||indr...@l2c2.co.in --- Comment #80 from Katrin Fischer --- *** Bug 12806 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title's Checkout History display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I am not sure how to achieve this. Currently all information is pulled from the issues and old_issues tables, but the information about the checkin branch is not recorded there. We'd need statistics, but we don't record the issue_id there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 --- Comment #3 from Katrin Fischer --- Created attachment 86494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86494=edit Bug 13094: Make it easy to hide 'Cancel all' button on holds over report This patch makes some small modifications to the 'Holds awaiting pickup' report: - Fixes typo sypref - Fixes 'Home branch' to 'Home library' - Adds a span to easily hide the cancel all button with CSS To test: - Make sure you have a hold appearing on the awaiting pickup list second tab: Holds waiting over... - Verify the 'cancel all' button on top shows - Verify syspref and Home library changes mentioned above - Add #holdsover-cancel-all { display:none; } to IntrentUserCSS - Verify that the button and the text have vanished Note: If the text doesn't display next to the button, try toggling the TransferWhenCancelAllWaitingHolds system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer changed: What|Removed |Added Summary|Make it easy to hide|Make it easy to hide |'Cancel all holds' button |'Cancel all' button on |on holds over report|holds over report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|unspecified |master --- Comment #2 from Katrin Fischer --- (In reply to Marc Véron from comment #1) > Still valid? It looks like it is, but there are even more occurrences of timestamp in the file. The attached file is also not a valid patch format, still needs some work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Summary|show all fields when|Show acquisition |ordering from suggestion|information when ordering ||from suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4833] show all fields when ordering from suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4833] show all fields when ordering from suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #1 from Katrin Fischer --- Created attachment 86493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86493=edit Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9983] printable fines page should include name/barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9983 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer --- The current print version of this page is not very nice, but it includes the left column with the patron information. As others have said, we need a nice way to print fines, as a customizable slip. Original bug is 'fixed' tho. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8506] return date of lost items recorded wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8506 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I can't replicate this issue on current master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- missing dependency for 18.05.x. not backporting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14396] library groups are allowed to have same codes as branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14396 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Tested on current master and the bug reported appears to have been fixed with the new library group system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22494] New: When adding a library group with an already existing name, an ugly error is displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22494 Bug ID: 22494 Summary: When adding a library group with an already existing name, an ugly error is displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- Duplicate ID at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16785] Autocomplete broken on overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #2 from Katrin Fischer --- eferenceError: create_auto_completion_responder is not defined[Learn More] overdue.pl:486:1 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16785] Autocomplete broken on overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- This appears to still be broken - even more than when reported. It appears now that the pull down with options never loads. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #95 from Josef Moravec --- I rebased and squashed the patches a bit. To pass QA there are at least missing tests for GetOpenURLResolverURL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #94 from Josef Moravec --- Created attachment 86492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86492=edit Bug 8995: (follow-up) Adapt to current codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86483|0 |1 is obsolete|| Attachment #86484|0 |1 is obsolete|| Attachment #86485|0 |1 is obsolete|| Attachment #86486|0 |1 is obsolete|| Attachment #86487|0 |1 is obsolete|| Attachment #86488|0 |1 is obsolete|| Attachment #86489|0 |1 is obsolete|| --- Comment #92 from Josef Moravec --- Created attachment 86490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86490=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #93 from Josef Moravec --- Created attachment 86491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86491=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #91 from Josef Moravec --- Created attachment 86489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86489=edit Bug 8995: (follow-up) Adapt to current codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #90 from Josef Moravec --- Created attachment 86488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86488=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #88 from Josef Moravec --- Created attachment 86486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86486=edit Bug 8995: Tell about the new sysprefs in COinSinOPACResults description Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #86 from Josef Moravec --- Created attachment 86484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86484=edit Bug 8995: Remove useless code OpenURL link display is done in XSLT only, so this code is now useless Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #64532|0 |1 is obsolete|| Attachment #64533|0 |1 is obsolete|| Attachment #64534|0 |1 is obsolete|| Attachment #64535|0 |1 is obsolete|| Attachment #64536|0 |1 is obsolete|| Attachment #64537|0 |1 is obsolete|| Attachment #64538|0 |1 is obsolete|| --- Comment #85 from Josef Moravec --- Created attachment 86483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86483=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #89 from Josef Moravec --- Created attachment 86487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86487=edit Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation There were still references to the OPAC 'prog' theme in XSL files Now, when using a relative URL, we have to give the full path Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #87 from Josef Moravec --- Created attachment 86485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86485=edit Bug 8995: Fix URL generation when the URL in syspref has a query part Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > The log viewer uses the action_logs table, the holds history uses data from > reserves and old_reserves. The action_logs table has the column 'interface' > which can be used to determine where the hold was placed. This information > is not available form the *reserves tables. > > Strangely, it doesn't look like we are logging the reserve_id - so there is > no safe way to tell which line in action_logs corresponds to an entry in > *reserves :( I was wrong, I was looking at old incomplete entires - reserve_id is logged now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 --- Comment #1 from Katrin Fischer --- The log viewer uses the action_logs table, the holds history uses data from reserves and old_reserves. The action_logs table has the column 'interface' which can be used to determine where the hold was placed. This information is not available form the *reserves tables. Strangely, it doesn't look like we are logging the reserve_id - so there is no safe way to tell which line in action_logs corresponds to an entry in *reserves :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 Katrin Fischer changed: What|Removed |Added Version|17.11 |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15860] Alias missing for /plugin on packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Tomas, I am not good with Apache, but I remember seeing broken images. Could we fix this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #11 from Josef Moravec --- This should be rebased and adapted on top of bug 19489 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #43 from Josef Moravec --- I agree with Tomas, we should fix bug 22420 independently. This patchset works, code is OK and fixes the described bug, so setting PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea changed: What|Removed |Added Priority|P5 - low|P2 CC||wizzy...@gmail.com Severity|major |blocker --- Comment #1 from Liz Rea --- We can't have a release with this broken. Thanks for filing the bug, I spotted this too. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #8 from Katrin Fischer --- I agree too - looking at the change I was just wondering, if it should be: columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #42 from Martin Renvoize --- This looks solid to me and seems to work.. can this go to PQA Josef.. or are you waiting on some further feedback here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #11 from Kyle M Hall --- Created attachment 86482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86482=edit Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Kyle M Hall changed: What|Removed |Added Attachment #86479|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 86480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86480=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #10 from Kyle M Hall --- Created attachment 86481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86481=edit Bug 22330: Cache item and library objects when building the holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #6 from Sarah Cornell --- Agustín, I tested the patch and the functionality works. Is it possible to include more information in the tab labels in SCO, as it is displayed in opac-user.pl? Such as: Checkouts (0) Holds (1) Fines and charges (16.99) Thanks, Sarah -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22004] When decreaseLoanHighHolds is set to Enable, suspended holds still count in the number of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22004 Christofer changed: What|Removed |Added CC||christofer.zorn@ajaxlibrary ||.ca --- Comment #1 from Christofer --- We had the same issue where a patron was trying to check out their own hold, on a book with a suspended hold. The system reduced the loan period as it saw two holds on the account, when in actuality there was really only one active hold. Could this be changed to only count active holds as we have many people place a hold on an item and then suspend the hold for months. Thanks Christofer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Kyle M Hall changed: What|Removed |Added Attachment #85067|0 |1 is obsolete|| Attachment #85068|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 86479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86479=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard changed: What|Removed |Added Attachment #86466|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 86478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86478=edit Bug 22023: (follow-up) Right-to-left layout improvements This patch makes some corrections to accommodate right-to-left layouts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #34 from Owen Leonard --- The rebase for this was tedious enough that I think it could use another look in the form of a signoff. Please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard changed: What|Removed |Added Attachment #82995|0 |1 is obsolete|| Attachment #82996|0 |1 is obsolete|| Attachment #82997|0 |1 is obsolete|| Attachment #83180|0 |1 is obsolete|| Attachment #83772|0 |1 is obsolete|| --- Comment #33 from Owen Leonard --- Created attachment 86477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86477=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86461|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 86476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86476=edit Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 86471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86471=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 86475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86475=edit Bug 21683: (follow-up) Remove last occurences of statistics.proccode columns.def is used to define descriptions of db columns in guided reports test is not useful anymore IMO Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 86473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86473=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 86470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86470=edit Bug 21683: Database update Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 86472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86472=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 86474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86474=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86336|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86232|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86233|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86231|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86234|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Josef Moravec --- Owen, thanks for quick follow-up, but I still have some minor issues with this: https://screenshots.firefox.com/VWFAQUJcL2Jg9RAi/localhost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #6 from Josef Moravec --- Created attachment 86469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86469=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec changed: What|Removed |Added Attachment #86402|0 |1 is obsolete|| Attachment #86403|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 86468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86468=edit Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Passed QA --- Comment #7 from Josef Moravec --- (In reply to Owen Leonard from comment #5) > (In reply to Katrin Fischer from comment #4) > > Should the columns be configurable? > > Maybe, but I think that would be a different bug. I agree, this patch fixes bug, enhancement could be done on another report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec changed: What|Removed |Added Attachment #86399|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 86467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86467=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Bin Wen Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 --- Comment #8 from Owen Leonard --- Created attachment 86466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86466=edit Bug 22023: (follow-up) Right-to-left layout improvements This patch makes some corrections to accommodate right-to-left layouts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #21 from Josef Moravec --- (In reply to Josef Moravec from comment #18) > Also, it would be nice to have test for changes in > Koha/REST/V1/Illrequests.pm Test in this attachmend of 21460 is exactly what I mean: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184=diff we could move it here maybe... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #20 from Josef Moravec --- 1) You are setting dateFormat on two places, but not use it anywhere. 2) In the ill requests list tables (both, in ill module and patron ill view) are shown columns placed_unformatted and updated_unformatted, only data, table header is blank. 3) There is error in js console, when load the ill request lista table in ill module ill-list-table_18.1200024.js:242 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined at getStatusName (ill-list-table_18.1200024.js:242) at ill-list-table_18.1200024.js:34 at Array.forEach () at Object.prep (ill-list-table_18.1200024.js:29) at a.fn.init.initComplete (ill-list-table_18.1200024.js:460) at jquery.dataTables.min_18.1200024.js:75 at Function.map (jquery-2.2.3.min_18.1200024.js:2) at v (jquery.dataTables.min_18.1200024.js:75) at ta (jquery.dataTables.min_18.1200024.js:49) at ia (jquery.dataTables.min_18.1200024.js:48) 3) when trying to filter by date placed, there is one more error in console: ill-list-table_18.1200024.js:519 Uncaught TypeError: Cannot read property 'api' of undefined at HTMLFormElement. (ill-list-table_18.1200024.js:519) at HTMLFormElement.dispatch (jquery-2.2.3.min_18.1200024.js:3) at HTMLFormElement.r.handle (jquery-2.2.3.min_18.1200024.js:3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #19 from Andrew Isherwood --- Created attachment 86465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86465=edit Bug 18589: (follow-up) Fix QA tool failures As per comment #17: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17 Sorry Josef, I honestly have no idea where those tabs came from :( Every once in a while my copy of Vim decides to embarass me and stick in tabs instead of spaces... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #18 from Josef Moravec --- Also, it would be nice to have test for changes in Koha/REST/V1/Illrequests.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Josef Moravec --- Andrew, thanks for quick rebase. I just run QA test tools and they are not happy: FAILkoha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 2) forbidden pattern: simple-quote string (line 3) forbidden pattern: simple-quote string (line 5) forbidden pattern: simple-quote string (line 6) forbidden pattern: simple-quote string (line 7) forbidden pattern: simple-quote string (line 8) forbidden pattern: simple-quote string (line 9) forbidden pattern: simple-quote string (line 10) forbidden pattern: simple-quote string (line 11) forbidden pattern: simple-quote string (line 12) forbidden pattern: simple-quote string (line 14) forbidden pattern: simple-quote string (line 16) forbidden pattern: simple-quote string (line 17) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc FAIL forbidden patterns forbidden pattern: tab char (line 2) forbidden pattern: tab char (line 3) forbidden pattern: tab char (line 4) forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 6) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 8) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 12) forbidden pattern: tab char (line 13) forbidden pattern: tab char (line 14) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 26) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 41) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt FAIL forbidden patterns forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 43)
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 --- Comment #2 from dominique.rou...@univ-st-etienne.fr --- It could also be useful to have an option to launch an indexing by decrementing the record number -w "100,2" index 2 biblio with biblionumber after 100th (101 and 102) and -w "100,-2" index 2 biblio with biblionumber before 100th (99 and 98) This allows the highest biblionumbers, i.e. the most recent records, to be indexed first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 dominique.rou...@univ-st-etienne.fr changed: What|Removed |Added CC||dominique.rouger@univ-st-et ||ienne.fr --- Comment #1 from dominique.rou...@univ-st-etienne.fr --- It could also be useful to have an option to launch an indexing by decrementing the record number -w "100,2" index 2 biblio with biblionumber after 100th (101 and 102) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #9 from Owen Leonard --- Created attachment 86463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86463=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #10 from Owen Leonard --- Created attachment 86464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86464=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard changed: What|Removed |Added Attachment #86085|0 |1 is obsolete|| Attachment #86086|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 86462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86462=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 --- Comment #1 from Nick Clemens --- Created attachment 86461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86461=edit Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com Assignee|ch...@bigballofwax.co.nz|n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/