[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #46 from David Cook ---
Comment on attachment 80256
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256
Bug 15529: Altered logic for lockfile creation
Review of attachment 80256:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15529=80256)
-
::: misc/cronjobs/process_message_queue.pl
@@ +89,5 @@
> +foreach (
> +C4::Context->config("cron_lockdir"),
> +'/var/lock/cron_' . C4::Context->config('database'),
> +'/tmp/cron_' . C4::Context->config('database')
> +) {
This seems excessive and process_message_queue.pl doesn't seem like the place
you'd want to do it anyway. This seems pretty generic and like it could be used
by other scripts.
@@ +98,5 @@
> +if( !defined $LockFH ) {
> +print "WARNING: Could not create lock file $lockfile: $!\n";
> +print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n";
> +print "Verify file permissions for it too.\n";
> +$use_flock = 0; # we disable file locking now and will continue
Yeah, I'd say mandate that locks must be used.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Failed QA |Patch doesn't apply --- Comment #45 from Hayley Mapley --- Patch no longer applies - is somebody able to rebase? Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is running Applying: Bug 15529 - Wrapping email sending up in the verbose flag error: sha1 information is lacking or useless (misc/cronjobs/process_message_queue.pl). error: could not build fake ancestor Patch failed at 0001 Bug 15529 - Wrapping email sending up in the verbose flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 --- Comment #6 from David Cook --- (In reply to Hayley Mapley from comment #5) > Test fails with the following error: > > t/db_dependent/Circulation.t .. 122/126 # No tests run! > t/db_dependent/Circulation.t .. 123/126 > # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge > tests"' > # at t/db_dependent/Circulation.t line 2948. > Can't call method "lengthunit" on an undefined value at > /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. > # Looks like your test exited with 11 just after 123. > t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > Failed 4/126 subtests > > Test Summary Report > --- > t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) > Failed test: 123 > Non-zero exit status: 11 > Parse errors: Bad plan. You planned 126 tests but ran 123. > Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr > 3.22 csys = 21.89 CPU) > Result: FAIL Thanks, Hayley! I'm guessing this highlights a problem with that test rather than this patch though. Hmm. What are your thoughts, Tomas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #17 from Hayley Mapley --- (In reply to Jonathan Druart from comment #16) > 1. Please adjust commit title and body > 2. Table footer is broken - > https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org > 3. Why a new column? Maybe it would make more sense to have it in the first > column, close to the biblio's title? > > Failing QA for 1 and 2, Discussion for 3. The current master has a barcode column in the Patrons 'Make a payment' tab. Does anything need to be done further for this bug or shall I mark it resolved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6710] (Optionally) sort lists in OPAC pull down alphabetically instead of ordering by last changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6710 Katrin Fischer changed: What|Removed |Added Summary|lists of lists in Alpha |(Optionally) sort lists in |order |OPAC pull down ||alphabetically instead of ||ordering by last changed CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6705] Hide withdrawn items in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6705 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Summary|hide withdrawn items|Hide withdrawn items in ||OPAC Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Withdrawn items can be hidden using the OpacHiddenItems system preference, marking RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6664] Allow to set a weekly holiday for a given data range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Katrin Fischer changed: What|Removed |Added Summary|enhancements to repeatable |Allow to set a weekly |holidays|holiday for a given data ||range CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6659] Show OpacNav and OpacNavBottom on the login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6659 Katrin Fischer changed: What|Removed |Added Summary|show opacnav on the log in |Show OpacNav and |page|OpacNavBottom on the login ||page --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Still valid, but maybe by intention? For libraries not allowing OPAC > searches until after you have logged in, this might be the desired behaviour. Maybe it could also be tied to the OpacPublic system preference, only showing navigation, if the OPAC is public. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6625] Allow Koha to use Openlibrary subject API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6625 Katrin Fischer changed: What|Removed |Added Summary|Allow Koha to use |Allow Koha to use |Openlibrary subject api |Openlibrary subject API CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- API is still marked as experimental, last change was: October 12, 2010 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6615] Add shelving location option to transfers page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6615 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Owen, is this resolved with the item batch edit features? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16915] Integrate OMDb in to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16915 Katrin Fischer changed: What|Removed |Added Component|OPAC|Web services Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com --- Comment #13 from Katrin Fischer --- *** Bug 16924 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16924] Add Search by Accelerated Reading Level Range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16924 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- bug 20078 has some sample jQuery to add the serach filters to advanced search. *** This bug has been marked as a duplicate of bug 20078 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 --- Comment #12 from Katrin Fischer --- *** Bug 17832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17832] arl (accelerated reading level) and ard (? -- Title point value) searches do not return results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17832 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 20078 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer changed: What|Removed |Added Attachment #81129|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 86556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86556=edit Bug 21659: Fix links to basket groups from order receive page Fixes a problem with the template variables on the order receive page, so that the links to basket groups work correctly again. To test: - Create some orders with and without basket groups - Receive shipment - Verify that the basket group links for pending orders work right - Receive an order line - Verify that the basket group links for received orders work right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 --- Comment #5 from Katrin Fischer --- Hi Dobrica, hope it's ok I stole this one. Fixed it a little differently to your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #8 from Sarah Cornell --- The tabs look good. I'm almost ready to sign off. At some point in my testing the SCO shut down. I think it was because the SCO was trying to edit an item as part of the normal process. I reproduced the shutdown when I tried to edit an item in the intranet. This is one of the last lines of the plack log when it shuts down: Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 853. 2019/03/12-19:48:38 Server closing! I don't see why it would be related but I'm new to testing on the sandboxes so I have to ask! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #100 from Michal Denar --- Created attachment 86555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86555=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #98 from Michal Denar --- Created attachment 86553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86553=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #97 from Michal Denar --- Created attachment 86552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86552=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #99 from Michal Denar --- Created attachment 86554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86554=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar changed: What|Removed |Added Attachment #83024|0 |1 is obsolete|| Attachment #83025|0 |1 is obsolete|| Attachment #83026|0 |1 is obsolete|| Attachment #83027|0 |1 is obsolete|| Attachment #83028|0 |1 is obsolete|| Attachment #86549|0 |1 is obsolete|| --- Comment #95 from Michal Denar --- Created attachment 86550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86550=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #96 from Michal Denar --- Created attachment 86551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86551=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22502] New: Auto Complete not working when Placing Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22502 Bug ID: 22502 Summary: Auto Complete not working when Placing Holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- Prior to Koha version, 18.05.10, if a library has the CIRCAUTOCOMPL system preference set to TRY, Koha would attempt to search for the patrons name during checkout (circulation.pl) or when placing holds for a patron (reserves.pl). In Koha 18.05.10, Koha is still attempting to complete the patron's name when using the checkout feature, but not when placing holds for patrons. The spinning thing does not appear when starting to type the patrons name on the reserves.pl page but does continue to work in the circulation.pl page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #11 from Hayley Mapley --- All looks good Martin, the only issue (and it's a small one) is that the alert on the final page of the onboarding 'Circulation rule created' appears twice which may be confusing to users. I haven't found the cause of this yet, but it doesn't appear to be an issue with the database as there are no duplicates of the rules I created during onboarding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #85073|0 |1 is obsolete|| --- Comment #94 from Aleisha Amohia --- Created attachment 86549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86549=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Hayley Mapley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |hayleymap...@catalyst.net.n ||z CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr --- Comment #2 from Devinim --- Hi Pierre-Marc, We have followed your steps. However we didn't get any error as you mentioned in step 7. The MARC file without tag 100 inserted into the system without any error. Devinim Koha Team -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #10 from Hayley Mapley --- (In reply to Martin Renvoize from comment #9) > I felt mean asking Hayley to change so much.. so I've done a cleaned up > patch myself.. I'd really appreciate your testing though Heyley, thanks for > reporting it and having a first crack, you've saved me considerable time > digging to work out the cause and fix. Sorry for all the mistakes there Martin and Katrin, I was working on this with someone else and I forgot that they had added all those warns. I appreciate having someone more experienced than me to make a follow up, so thank you for that. I will test your patch now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22501] New: OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Bug ID: 22501 Summary: OPAC course reserves notes should allow html links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Some libraries have been using the public notes field to point to electronic resources, this functionality has been removed by HTML filtering the content. We should allow the use of a $raw filter on these fields as they can only be entered by staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |Failed QA --- Comment #26 from Liz Rea --- Hi Tomas, I can't seem to get these to apply on latest master: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21890: Allow restricting password resets by patron category Sorry :( Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22500] New: Patron Self Registration Verify by email does not work with display and prefill option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22500 Bug ID: 22500 Summary: Patron Self Registration Verify by email does not work with display and prefill option Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Target Milestone: --- When using sys pref PatronSelfRegistrationVerifyByEmail,sys pref PatronSelfRegistrationPrefillForm Display and Prefill does not work. Clicking on the verification link in the email takes patron to the correct page (PatronSelfRegistrationAdditionalInstructions), but the library card number and password are not displayed or prefilled in the login box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Liz Rea changed: What|Removed |Added Attachment #83716|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 86548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86548=edit Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha The CM field was all set up for implementation, but never completed. We should fully implement the CM ( Hold Pickup Date ), which according to the SIP2 protocol specification is "The date that the hold expires". Test Plan: 1) Set up a waiting hold for an item 2) Using the sip cli emulator, send an item information request for that item 3) Note the CM field does not show up 4) Apply this patch 5) Restart all the things! 6) Repeat the item information request 7) Note the CM field is now transmitted! Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Martin Renvoize --- I felt mean asking Hayley to change so much.. so I've done a cleaned up patch myself.. I'd really appreciate your testing though Heyley, thanks for reporting it and having a first crack, you've saved me considerable time digging to work out the cause and fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize changed: What|Removed |Added Attachment #86497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize changed: What|Removed |Added Attachment #86496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #8 from Martin Renvoize --- Created attachment 86547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86547=edit Bug 22489: Update onboarding tool for bug 18925 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions by bug 18925. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- I'd take a look around line 225 of admin/smart-rules.pl to see how the new maxissue stuff works.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489
--- Comment #6 from Martin Renvoize ---
Comment on attachment 86496
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86496
Bug 22489: Fixed issue with onboarding tool failing at step 5
Review of attachment 86496:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=22489=86496)
-
Sorry.. I think there's a bit more work to do here I'm afraid.
::: admin/smart-rules.pl
@@ +223,5 @@
> }
>
> +warn $bor;
> +warn $itemtype;
> +warn $br;
Cleaning up the warnings again would be great ;)
@@ +302,5 @@
> $sth_insert->execute($branch, $holdallowed,
> $hold_fulfillment_policy, $returnbranch);
> }
>
> +warn $branch;
> +warn $categorycode;
More warnings ;)
::: installer/onboarding.pl
@@ +31,5 @@
> use Koha::Patron::Categories;
> use Koha::ItemTypes;
> use Koha::IssuingRules;
> +use Koha::CirculationRules;
> +use Switch;
Switch is recommended against... and doesn't appear to be used anywhere either.
@@ +258,5 @@
> issuelength => $issuelength,
> lengthunit => $lengthunit,
> onshelfholds=> $onshelfholds,
> };
> +$branchcode = $branchcode if $branchcode ne '*';
Erm.. this doesn't make sense "Set branchcode to branchcode if branchcode not
equal to '*'".. What were you intending here?
@@ +260,5 @@
> onshelfholds=> $onshelfholds,
> };
> +$branchcode = $branchcode if $branchcode ne '*';
> +$branchcode = undef if $branchcode eq '*';
> +$categorycode = $categorycode if $categorycode ne '*';
As above.. I'm confused as to what the intention is here?
@@ +262,5 @@
> +$branchcode = $branchcode if $branchcode ne '*';
> +$branchcode = undef if $branchcode eq '*';
> +$categorycode = $categorycode if $categorycode ne '*';
> +$categorycode = undef if $categorycode eq '*';
> +$itemtype = $itemtype if $itemtype ne '*';
and again..
@@ +278,4 @@
> eval { $issuingrule->store; };
>
> +my $circulationrule =
> Koha::CirculationRule->new($circulationruleparams);
> +eval { $circulationrule->store; };
New eval, but we're no longer catching errors for the first insert.. we'd need
to catch errors above this line too..
@@ +287,4 @@
> push @messages, { code => 'error_on_insert_circ_rule' };
> }
> }
> +warn Koha::CirculationRules->count;
Another warn ;)
::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
@@ +98,5 @@
> + class="required">Current checkouts allowed:
> + name="maxissueqty" id="maxissueqty" size="10" value="50" class="required"
> required="required" />
> +Required
> +
> +
This looks to me as though it's just been moved.. not sure why yet as I've not
actually inspected the new UI layout.. perhaps it makes good sense to move it..
perhaps not.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 --- Comment #4 from Nick Clemens --- (In reply to Janet McGowan from comment #3) > Hi Nick, > Testing on our sandbox I'm seeing a problem in that after adding the initial > adjustment, every time you subsequently click Update Adjustments it changes > the Fund that you want to debit or credit back to No Fund. > This means I can't really test properly as I can't add a 2nd adjustment line > without it changing the Fund to No Fund! > Do you need any more info? > many thanks > Janet Looks like I missed updating one variable on the dependent bug 22498 - new patch attached there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens changed: What|Removed |Added Attachment #86531|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 86546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86546=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 --- Comment #3 from Kelly McElligott --- Katrin, I posted an attachment - has Koha changed? Now, when a CSV profile is created, there is a dropdown menu of 3 options where these profiles will display- and these profiles no longer display in the Download cart/list feature. The manual does not match what I current see on the Koha version 18.05.08. Kelly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #2 from Kelly McElligott --- Created attachment 86545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86545=edit CSV profile -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 --- Comment #3 from Janet McGowan --- Hi Nick, Testing on our sandbox I'm seeing a problem in that after adding the initial adjustment, every time you subsequently click Update Adjustments it changes the Fund that you want to debit or credit back to No Fund. This means I can't really test properly as I can't add a 2nd adjustment line without it changing the Fund to No Fund! Do you need any more info? many thanks Janet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7890] Highlight required field in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard changed: What|Removed |Added Attachment #86112|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 86544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86544=edit Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Serhij Dubyk changed: What|Removed |Added CC||du...@ukr.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #5 from Liz Rea --- Oh also you left in some warns - it would be good to tidy those up. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Liz Rea --- Hi Hayley, Thank you for the quick turnaround, however there is a QA fail: installer/onboarding.pl: Found use of Switch. This module is deprecated by the Perl 5 Porters at line 35, column 1. Find an alternative module. (Severity: 5) I suspect you will want to find a different solution for this. Thanks for keeping after it! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22249] Error when submitting Mana comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249
Jon Knight changed:
What|Removed |Added
CC||j.p.kni...@lboro.ac.uk
--- Comment #1 from Jon Knight ---
Not tackling the cause of this directly (ie why is it requesting a module that
doesn't exist and hasn't be loaded into the code) but what about having
something like this before line 89:
my $loaded = $packages->VERSION;
if(!$loaded) {
eval('use '.$packages);
if(!$packages->VERSION) {
warn "Can't load package $packages: $!\n";
}
}
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize changed: What|Removed |Added Summary|Term "Lost item"|Term "Lost item" is |untranslatable |untranslatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #141 from Katrin Fischer --- (In reply to Frank Hansen from comment #140) > Katrin, I have already signed off the patches from a sandbox. I'm getting: > koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: needs merge > > Guess, I don't have a change to do that. > > The sandbox is here: http://sb1.sandboxes.bywatersolutions.com if somebody > want to try. Hi Frank, looks like we might need a rebase - master is changing fast and sometimes there are conflicts in files changed by different patches. We will fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #140 from Frank Hansen --- Katrin, I have already signed off the patches from a sandbox. I'm getting: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: needs merge Guess, I don't have a change to do that. The sandbox is here: http://sb1.sandboxes.bywatersolutions.com if somebody want to try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize changed: What|Removed |Added QA Contact|tomasco...@gmail.com|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize --- Sorry Caroline but... There's a weird case here where a Lost item could receive two types of charge depending on what system preferences were in play. One with the code 'PF' for "Processing Fee" and another with the code "L" for Lost Item.. The DB update needs to catch both before I can PQA the bug.. Also, do we need to somehow distinguish that the Processing Fee line is attributed to the Lost item? With this patch we're losing that I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20128] Permission for advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Yeay for bug 22031 and it's first real use here :) All works as expected.. I had to do a minor rebase to get it to apply again. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20128] Permission for advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize changed: What|Removed |Added Attachment #86208|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 86543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86543=edit Bug 20128: Add permission for advanced cataloging editor To test: 1 - Have a borrower with edit_catalogue permission and one with editcatalogue top level 2 - Confirm they can both access the advanced editor from the 'Cataloguing' home page or from the basic editor 3 - Apply patch 4 - Update database 5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor' permission 6 - Confirm borrowers can access advanced editor as above 7 - Remove 'advanced_editor' permission from borrower 8 - Ensure they cannot access the advanced editor 9 - Ensure links to 'Edit record' from search results go to basic editor Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #96 from Josef Moravec --- Created attachment 86541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86541=edit Bug 8995: (follow-up) Added test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #97 from Josef Moravec --- Created attachment 86542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86542=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- Thanks Matthias, All works well, no QA Script failures and as a new route there's no regressions.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added Attachment #85693|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 86537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86537=edit Bug 19661: REST API - Funds Endpoint This patch adds a new route to the REST api: /api/v1/acquisitions/funds/ Signed-off-by: David Bourgault Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added Attachment #85694|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 86538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86538=edit Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added Attachment #85695|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 86539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86539=edit Bug 19661: Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added Attachment #85696|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 86540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86540=edit Bug 19661: (follow-up) Use Basic auth in tests Test plan: prove t/db_dependent/api/v1/acquisitions_funds.t Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #140 from Kyle M Hall ---
Created attachment 86535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86535=edit
Bug 20750: Add unit tests
Signed-off-by: Josef Moravec
Bug 20750: (follow-up) Remove status_alias test
This test is now redundant.
We can't test the return of $req->status_alias against the value of
$req->{status_alias} any more since we've overloaded the status_alias
method and it won't always return the value of the object's property.
We test the functionality of the status_alias method elsewhere so we're
still covered.
Signed-off-by: Josef Moravec
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #141 from Kyle M Hall --- Created attachment 86536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86536=edit Bug 20750: (QA follow-up) Fix templates Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Kyle M Hall changed: What|Removed |Added Attachment #86434|0 |1 is obsolete|| Attachment #86435|0 |1 is obsolete|| Attachment #86436|0 |1 is obsolete|| --- Comment #139 from Kyle M Hall --- Created attachment 86534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86534=edit Bug 20750: Allow logging of arbitrary actions This patch allows logging of arbitrary actions on request objects. A chronological summary of these actions can then be displayed when viewing a request. This patch also adds logging of request status changes. Additional work has been done on the BLDSS backend to log requests to the BLDSS request status check API. To test: - Apply patch - Ensure the Illlog logging preference is turned on - Create an ILL request and perform actions on it that change it's status. - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Niamh Walker Signed-off-by: Josef Moravec Since this bug now is dependent on Bug 20581, it should be aware of the custom statuses provided in 20581. This patch enables logging of request statuses being changed to custom ones. As such the test plan is modified: To test: - Apply patch - Ensure the Illlog logging preference is turned on - Ensure you have some custom request statuses defined in the Authorised Values ILLSTATUS category - Create an ILL request and perform actions on it that change it's status. - Edit the request and change status to a custom one - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19661] Add routes for funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize changed: What|Removed |Added Attachment #85771|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 86533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86533=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Trivial patch that does what it says on the tin.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens changed: What|Removed |Added Attachment #84900|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 86532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86532=edit Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy To test: 1 - prove -v t/db_dependent/Budgets.t 2 - Create some invoices on a single budget Invoice 1: add a non-encumbered adjustment for 1 add an encumbered adjustment 2 leave open Invoice 2: add a non-encumbered adjustment for 4 add an encumbered adjustment for 8 3 - View acq home page, should see 2 order and 12 spent for the budget 4 - View the spent and ordered pages, they should show the correct amounts 5 - Add more orders etc and confirm things total correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Depends on||14850 Blocks||22296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 [Bug 22296] Invoice adjustments are not populating to budget views -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens changed: What|Removed |Added Depends on||22498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 [Bug 22498] Can not select any funds for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Nick Clemens changed: What|Removed |Added Blocks||22498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 [Bug 22498] Can not select any funds for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #139 from Katrin Fischer --- Hi Frank! Can you please add a sign-off line to the patch too? This can be done for example by using the sandboxes: https://wiki.koha-community.org/wiki/Sandboxes If you can't that's ok, we can also fix it in the QA step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 --- Comment #1 from Nick Clemens --- Created attachment 86531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86531=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #138 from Frank Hansen --- The patch is tested and works fine. Nice work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Björn Nylén changed: What|Removed |Added CC||bjorn.ny...@ub.lu.se --- Comment #3 from Björn Nylén --- The functionality works but the tests fail due to the weight is beeing returned as a decimal number. # Failed test 'Match search field is weighted with 15' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 61. # got: '15.00' # expected: '15' # Failed test 'Title search field is weighted with 20' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 64. # got: '20.00' # expected: '20' # Looks like you failed 2 tests of 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- Made a few minor corrections to make the QA scripts happy. Otherwise, a nice improvement which I think considerably improves feedback to the end user. I don't believe we can easily translate these error messages and do believe it's better to display them than to not display them so I'm Passing QA here even though it's untranslatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #9 from Owen Leonard --- (In reply to Jesse Maseto from comment #8) > Patch doesn't apply cleanly. Please rebase if needed for 18.05.x It is not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize changed: What|Removed |Added Attachment #86038|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #86042|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #14 from Martin Renvoize --- Created attachment 86530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86530=edit Bug 19417: (QA follow-up) Fix missing $raw filter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #12 from Martin Renvoize --- Created attachment 86528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86528=edit Bug 19417: Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #13 from Martin Renvoize --- Created attachment 86529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86529=edit Bug 19417: Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22499] New: Itemcallnumber "0" not displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22499 Bug ID: 22499 Summary: Itemcallnumber "0" not displayed Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: r...@rbit.cz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- If there is "0" (just zero) as an itemcallnumber, it's not displayed in Holdings tab in /cgi-bin/koha/catalogue/detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] New: Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Bug ID: 22498 Summary: Can not select any funds for invoice adjustments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Bug 14850 renamed budgets_loop to budgets but did not update the variables for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Eminently sane, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
