[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 --- Comment #1 from Agustín Moyano --- Created attachment 86770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86770=edit Bug 22538: Add a noticeable alert about waiting holds In SCO, bug 21772 introduced holds information, but it lacked the capability to attract atention when any of those holds was in waiting status. Because SCO and opac-user uses the same include file for holds table, this bug applies to both modules. To test: 1) Have a patron with holds in waiting status and pending status. 2) Enable SCO module. 3) Holds tab label contains holds count, but doesn't inform that there is something that requires attention. 5) Holds tab content has no visual aid to recognize without reading effort which holds are in waiting status. 6) Apply this patch => SUCCESS: Holds tab label has a visual aid to indicate that something requires attention, and in holds table it's easy to recognize waiting holds without reading effort. 7) Sign off Sponsored-by: Pasco County Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula changed: What|Removed |Added Attachment #86765|0 |1 is obsolete|| --- Comment #9 from Lari Taskula --- Created attachment 86769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86769=edit Bug 22471: Add system preferences for Finnish installer To test: 1. Apply all patches in this Bug 2. Create an empty database. Make sure database user has permissions to it and $KOHA_CONF is pointing to the correct database. 3. Add Finnish translation, for help, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 4. Run web installer and select fi-FI as installer language 5. Select all mandatory and optional default values 6. Finish installation and make sure you get no SQL errors Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula changed: What|Removed |Added Attachment #86761|0 |1 is obsolete|| Attachment #86762|0 |1 is obsolete|| --- Comment #6 from Lari Taskula --- Created attachment 86766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86766=edit Bug 22471: Add installer/data/mysql/fi-FI This patch adds a direct copy of installer/data/mysql/en. No translations provided in this patch! Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula changed: What|Removed |Added Attachment #86763|0 |1 is obsolete|| --- Comment #7 from Lari Taskula --- Created attachment 86767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86767=edit Bug 22471: Mandatory Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula changed: What|Removed |Added Attachment #86764|0 |1 is obsolete|| --- Comment #8 from Lari Taskula --- Created attachment 86768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86768=edit Bug 22471: Optional Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #5 from Lari Taskula --- Created attachment 86765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86765=edit Bug 22471: Add system preferences for Finnish installer To test: 1. Apply all patches in this Bug 2. Create an empty database. Make sure database user has permissions to it and $KOHA_CONF is pointing to the correct database. 3. Add Finnish translation, for help, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 4. Run web installer and select fi-FI as installer language 5. Select all mandatory and optional default values 6. Finish installation and make sure you get no SQL errors Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #2 from Lari Taskula --- Created attachment 86762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86762=edit Bug 22471: Add installer/data/mysql/fi-FI (2/2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #4 from Lari Taskula --- Created attachment 86764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86764=edit Bug 22471: Optional Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #1 from Lari Taskula --- Created attachment 86761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86761=edit Bug 22471: Add installer/data/mysql/fi-FI (1/2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #3 from Lari Taskula --- Created attachment 86763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86763=edit Bug 22471: Mandatory Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Development: Limit view/edit of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Assignee|je...@bywatersolutions.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] add user expiration date to SIP2 message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Assignee|k...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- can't prove t/db_dependent/DecreaseLoanHighHolds.t in 18.05.x 1..17 ok 1 - userenv set Can't locate object method "build_sample_biblio" via package "t::lib::TestBuilder" at t/db_dependent/DecreaseLoanHighHolds.t line 74. # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/17 subtests Test Summary Report --- t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 17 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.18 cusr 0.16 csys = 1.36 CPU) Result: FAIL not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] Optimize ODS exports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #34 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #17 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- missing dependency, won't back port to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- 18.05.x is missing 14850 dependency. won't backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 18.05.x for 18.05.11 Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #3 from Lisette Scheer --- This is happening for us as well and our settings are: BlockReturnofLostItems to Not Block. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Andrew changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22541] New: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Bug ID: 22541 Summary: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- On ordered.pl and spent.pl, invoice adjustments are shown with a label that gives the invoiceid rather than the invoicenumber. For consistency and clarity, these should show the invoicenumber and link to the invoice page, just like the entries in the Invoice column in the table on these pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #15 from Liz Rea --- I realised half a second too late that there was a QA tool fail here, but I'm not 100% sure it's not a false positive, and no one was around to ask. Anyway, here's what it was: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL filters missing_filter at line 666 (var biblionumber = "[% biblionumber %]";) missing_filter at line 667 (var borrowernumber = "[% patron.borrowernumber %]";) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com --- Comment #10 from José-Mario Monteiro-Santos --- I'm not quite sure if I can ask about this here, but I've been having problems when urls contain characters such as é or à. I understand that this patch makes it so check-url-quick doesn't explode when it encounters such characters, but when the http request is sent they're encoded differently and are marked as broken links (é turns into é for example). Is this related to this bug ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #10 from Hayley Mapley --- (In reply to Bin from comment #9) > Created attachment 86745 [details] [review] > Bug 13763: Added check for filter syspref in renew.pl > > In Circulation->Renew, the renew feature does not check the system > preference itemBarcodeFilter to see whether the barcode needs to be > converted. This patch fixes this, adding a check for the system pref and > applying it accordingly to convert the barcode if it is needed. > > Test plan: > 1) In Circulation->Renew, enter a barcode that you know exists in the > catalogue but add extra spaces, breaking up the barcode. Note that this > fails with a warning that says 'No item matches this barcode' > > 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove > spaces and repeat step1. Note that the result is the same as in step 1 > > 3) Apply the patch > > 4) Repeat step 1, and note that the filter removes the spaces and the > item is renewed (or gives an error that indicates it recognises the > barcode) > > Sponsored-by: Catalyst IT > Signed-off-by: Bin Wen Thanks again for testing! I'll change the status to Signed Off so it'll get picked up by the QA team :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea changed: What|Removed |Added Attachment #86480|0 |1 is obsolete|| Attachment #86481|0 |1 is obsolete|| Attachment #86482|0 |1 is obsolete|| --- Comment #12 from Liz Rea --- Created attachment 86758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86758=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #13 from Liz Rea --- Created attachment 86759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86759=edit Bug 22330: Cache item and library objects when building the holds queue Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #14 from Liz Rea --- Created attachment 86760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86760=edit Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #5 from José-Mario Monteiro-Santos --- Slightly modifying Auth.pm restores the original functionnality. It may be useful as a temporary fix for those who have this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 --- Comment #1 from Liz Rea --- Created attachment 86757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86757=edit Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
José-Mario Monteiro-Santos changed:
What|Removed |Added
Attachment #86756|Bug 22522 - Update API |Fix for newer
description|specs' access in Auth.pm|Mojolicious/OpenAPI
||versions
--- Comment #4 from José-Mario Monteiro-Santos
---
Comment on attachment 86756
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86756
Fix for newer Mojolicious/OpenAPI versions
>From 9398e9ce1ddb545b031c4accad4148f743eddadd Mon Sep 17 00:00:00 2001
>From: Jose-Mario Monteiro-Santos
>Date: Tue, 19 Mar 2019 11:55:45 -0400
>Subject: [PATCH] Bug 22522 - Update API specs' access in Auth.pm
>
>With newer versions of Mojolicious and its plugins, endpoints' specs
>could no longer be accessed, thus bypassing authorization checks
>and failing to validate query parameters.
>
>Test plan:
>1. Without being logged in to Koha, access an endpoint directly
> (such as /api/v1/patrons/{patron_id})
>2. Notice results are received (which is bad since we're not authenticated)
>3. Try again with an endpoint that accepts query parameters
> (such as /api/v1/patrons?firstname=something)
>4. Notice that the query is not accepted (even with correct parameters)
>
>5. Apply the patch
>
>6. Repeat step 1
>7. Notice that the access is denied
>8. Login as a user with proper access rights
>9. Repeat step 1
>10. Notice that you can now get results
>11. Repeat step 3
>12. Notice that the query is now accepted
>13. Repeat step 3 but with an absurd parameter
>14. Notice the query is correctly rejected
>
>15. Ideally, check if other API calls were not broken
>---
> Koha/REST/V1/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm
>index 53c6bac..d0ecd13 100644
>--- a/Koha/REST/V1/Auth.pm
>+++ b/Koha/REST/V1/Auth.pm
>@@ -130,7 +130,7 @@ sub authenticate_api_request {
>
> my $user;
>
>-my $spec = $c->match->endpoint->pattern->defaults->{'openapi.op_spec'};
>+my $spec = $c->openapi->spec;
> my $authorization = $spec->{'x-koha-authorization'};
>
> my $authorization_header = $c->req->headers->authorization;
>--
>2.7.4
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #3 from José-Mario Monteiro-Santos
---
Created attachment 86756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86756=edit
Bug 22522 - Update API specs' access in Auth.pm
With newer versions of Mojolicious and its plugins, endpoints' specs
could no longer be accessed, thus bypassing authorization checks
and failing to validate query parameters.
Test plan:
1. Without being logged in to Koha, access an endpoint directly
(such as /api/v1/patrons/{patron_id})
2. Notice results are received (which is bad since we're not authenticated)
3. Try again with an endpoint that accepts query parameters
(such as /api/v1/patrons?firstname=something)
4. Notice that the query is not accepted (even with correct parameters)
5. Apply the patch
6. Repeat step 1
7. Notice that the access is denied
8. Login as a user with proper access rights
9. Repeat step 1
10. Notice that you can now get results
11. Repeat step 3
12. Notice that the query is now accepted
13. Repeat step 3 but with an absurd parameter
14. Notice the query is correctly rejected
15. Ideally, check if other API calls were not broken
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Severity|critical|blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Nick Clemens changed: What|Removed |Added Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 sandbo...@biblibre.com changed: What|Removed |Added Attachment #86754|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 86755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86755=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. Signed-off-by: Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22203] Holds modal no longer links to patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Nick, why did you set hide_patron_infos_if_needed=1? This was a copy/paste - reviewing how it works, this modal now respects the HidePatronName syspref - so while a change in behavior I think it should stand but am noting that effect here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 --- Comment #1 from Owen Leonard --- Created attachment 86754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86754=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Owen Leonard changed: What|Removed |Added Version|18.05 |master Summary|Customers Cancelling their |Allow patrons to cancel |Pending Holds |their waiting holds Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #28 from Owen Leonard --- Created attachment 86753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86753=edit Bug 21304: (follow-up) Correct hc-sticky configuration This patch corrects the element passed to the hc-sticky plugin to define which element the floating toolbar sticks to. To test, apply the patch and perform a search in the staff client which will return multiple results. Confirm that scrolling down the page triggers the floating toolbar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 --- Comment #6 from Owen Leonard --- Rebased. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Owen Leonard changed: What|Removed |Added Attachment #86397|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 86752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86752=edit Bug 22250: Clean up Mana KB integration with serials and reports This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment
[Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall changed: What|Removed |Added Attachment #86750|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 86751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86751=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a -p -su -sp -l --patron --item -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall changed: What|Removed |Added Attachment #86748|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 86750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86750=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a -p -su -sp -l --patron --item -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 86749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86749=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #2 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandbo...@biblibre.com changed: What|Removed |Added Attachment #86747|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #1 from Kyle M Hall --- Created attachment 86748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86748=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a -p -su -sp -l --patron --item -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22540] New: Add ability to place holds using SIP CLI emulator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Bug ID: 22540 Summary: Add ability to place holds using SIP CLI emulator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #22 from Liz Rea --- I'd like to test what's here, but don't want to waste the time if it's just going to be superceded. If no one is going to submit a counterpatch in the very near term, this looks like it will be an improvement and the patch probably needs attention so as not to waste Jonathan's work. For the record, it still applies and I plan to test it in the very near term, unless someone says "no here is my go at fixing this." Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22203] Holds modal no longer links to patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard changed: What|Removed |Added Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #1 from Owen Leonard --- Created attachment 86747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86747=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea changed: What|Removed |Added Attachment #86711|0 |1 is obsolete|| --- Comment #8 from Liz Rea --- Created attachment 86746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86746=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #21 from Ray Delahunty --- Almost 3 years after going live with auto-renewals, including our workaround to deal with this bug we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version. But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk --- Comment #8 from Ray Delahunty --- Almost 3 years after going live with auto-renewals, including our workaround to deal with bug 19014 we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version (especially bug 19014). But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #4 from Andrew Isherwood --- Test plan: (ignore the plan in comment #3) - Ensure you have at least two "partners" set up. These are patrons in the category defined in -> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - Go to the "Manage ILL request" screen => TEST: Observe that the request "Status" is "Requested from partners : first_partner_email_address_here" => TEST: Observe that the first_partner_email_address links to the appropriate patron screen - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) => TEST: Observe that the email addresses displayed link to the appropriate patron page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Andrew Isherwood --- Test plan: - Ensure you have at least two "partners" set up. These are patrons in the category defined in -> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Nick Clemens changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin changed: What|Removed |Added Attachment #86594|0 |1 is obsolete|| --- Comment #9 from Bin --- Created attachment 86745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86745=edit Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22539] New: Fines charged on back-dated checkin when item has been renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Bug ID: 22539 Summary: Fines charged on back-dated checkin when item has been renewed Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- In a certain niche situation, a patron can end up with an unexpected fine due to renewing a book just prior to returning it. Here's the situation: - Patron has a book due on a Saturday and doesn't return it - On Sunday, the library is closed - Early Sunday morning, the fines cron generates an accruing fine on the item - Patron puts the item in the bookdrop on Sunday - Patron renews the item via the OPAC on Sunday - At renewal, the fine changes from FU to F - Monday morning, the item is checked in via bookdrop mode, which back-dates the checkin to Saturday According to the old_issues table, the item was checked in before any fine was charged, but the fine remains on the patron's account. If the patron had not renewed the item, the fine would have remained FU and would have been forgiven on checkin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #2 from Andrew Isherwood --- Created attachment 86744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86744=edit Bug 22531: Add unit tests Add tests for new and modified methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #8 from Bin --- Sorry, I found that I made a wrong step in my understanding. There is no problem with the patch and test plan, which worked well！ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen changed: What|Removed |Added CC||frank.han...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tomás Cohen Arazi changed: What|Removed |Added Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 [Bug 22538] Add a noticeable alert about waiting holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Depends on||21772 Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | CC||j...@bywatersolutions.com, ||wizzy...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22538] New: Add a noticeable alert about waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Bug ID: 22538 Summary: Add a noticeable alert about waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Work to be done: - Add an alert red symbol to the holds tab in SCO (maybe ) if there are waiting holds. - Inside the holds tab, mark somehow those waiting holds in a noticeable way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #14 from Owen Leonard --- Created attachment 86743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86743=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Marjorie Barry-Vila changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22537] New: Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Bug ID: 22537 Summary: Suspend all hold button appears even if the hold can no longer be suspended. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: marjorie.barry-v...@collecto.ca QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Created attachment 86742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86742=edit suspend_hold Hi, I understand that a hold can not be suspended when it is awaiting for pickup. This is why the Suspend column is empty in the opac user's account. However, "Suspend all holds" button still appears and causes misunderstanding. Nothing happens when you click on the button but the user thinks that his hold has been suspended. See image attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19736] Add a digest option for AUTO_RENEWALS Notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736 Catherine E. Ingram changed: What|Removed |Added CC||catherine.ingram@cedarparkt ||exas.gov --- Comment #2 from Catherine E. Ingram --- Please please please make it so patrons can Digest the auto renew emails. When you get 30 or more emails in one day it is obnoxious. I get MANY patron complaints about this. Is there any development on this? We could maybe help out with that financially. Catherine Ingram Cedar Park Public Library, TX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Catherine E. Ingram changed: What|Removed |Added CC||catherine.ingram@cedarparkt ||exas.gov --- Comment #2 from Catherine E. Ingram --- Please please please make it so patrons can Digest the auto renew emails. When you get 30 or more emails in one day it is obnoxious. I get MANY patron complaints about this. Is there any development on this? We could maybe help out with that financially. Catherine Ingram Cedar Park Public Library, TX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #8 from Marjorie Barry-Vila --- Still valid in 18.05 Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 --- Comment #4 from Tomás Cohen Arazi --- There's already in the koha-conf.xml* files. But you should recover the changes to Makefile.PL on this patchset, Olli. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Tomás Cohen Arazi changed: What|Removed |Added Summary|search_marc_map.marc_field |search_marc_map.marc_field |should have |should have COLLATE= |COLLATE=utf8_bin|utf8mb4_bin CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED QA Contact|tomasco...@gmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from Julian Maurice --- Patch rebased on master + comment 3 addressed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice changed: What|Removed |Added Attachment #67577|0 |1 is obsolete|| --- Comment #5 from Julian Maurice --- Created attachment 86740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86740=edit Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new element inside //record/items/item that contains , and 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 --- Comment #6 from Julian Maurice --- Created attachment 86741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86741=edit Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22032] Improve local cover image tab on detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Owen Leonard changed: What|Removed |Added Attachment #86128|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 86739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86739=edit Bug 22032: Improve local cover image tab on detail page This patch makes a variety of improvements to the images tab of the staff client's bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. - Enable the LocalCoverImages system preference. - Locate a bibliographic record which has no images attached. - There should be a "no images" message and an upload button. - Upload an image and return to the detail page. - The "Images" tab should have a nicely-styled thumbnail of the image you uploaded. - Test the "Delete image" link: It should ask for a confirmation. If you confirm, the image should disappear and a "loading" spinner should appear. - When the image has been deleted the thumbnail container should disappear and the "no images" message should reappear. - Test this process with AllowMultipleCovers enabled and disabled. Extra credit: Modify the AJAX url in the removeLocalImage function in detail.tt. After misspelling a parameter name or the URL path, clicking the "Delete image" link should trigger an alert and re-show the image thumbnail. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
