[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

Hayley Mapley  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #69622|0   |1
is obsolete||

--- Comment #7 from Hayley Mapley  ---
Created attachment 87696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87696=edit
Fixed merge conflicts -

Bug 19780 - Updating the invoice costs after updating of the actual value post
receiving of the order

This invoice will update the invoice values if the order actual price
value is modified after the order has been received.

Test plan:
1. Create an order with the vendor price: 10.00 and actual price of
12.00

2. Close the order and receive the shipment. Change the actual price in
the receival page to 14.00

3. View the invoices and notice that 14.00 is the value displayed

4. Go back to the order and click on the order line to modify the order.
Change the actual price to 15.00

5. View the invoice now and notice that 14.00 is still the value being
displayed

6. Apply patch

7. Repeat steps 1,2,3,4 and 5 and notice that 15.00 is the value
displayed in the invoice

8. Now repeat steps 1. View the aqorders database table and notice after
step 1 is completed the order has unitprice:12.00 and
unitprice_tax_included and unitprice_tax_excluded values of NULL

9. Now before closing the order modify it and set the actual price to
14.00

10. Check the aqorders table again and notice that the unitprice is
14.00 and the unitprice_tax_included and unitprice_tax_excluded both
equal NULL. This means the unitprice_tax_included and
unitprice_tax_excluded values are not being updated before the order has
been receieved by they are being correctly updated if the order has been
received and the actual price is changed.

Sponsored-by: Horowhenua Distircit Council

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #28 from Liz Rea  ---
Created attachment 87694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87694=edit
Bug 21159 - Corrected typo

Same test plan as first patch.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

https://bugs.koha-community.org/show_bug.cgi?id=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Liz Rea  changed:

   What|Removed |Added

  Attachment #87037|0   |1
is obsolete||
  Attachment #87038|0   |1
is obsolete||
  Attachment #87041|0   |1
is obsolete||

--- Comment #27 from Liz Rea  ---
Created attachment 87693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87693=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue. This patch builds upon the functionality implemented in bug 14576,   
  by allowing library staff to automatically change the item shelving 
location of items whic

In the case of this patch it automatically blanks the item shelving
 locations of items
 when they are issued if the
 BlankItemLocationOnCheckout syspref is enabled.

 t/db_dependent/Circulation/issue.t contains tests for
 BlankItemLocationOnCheckout.

 Test plan:
 1. Create a new biblio and associated item and set the value of the
 shelving location for the item to 'CART'
 2. Checkout the item to a user and notice that the status does not
 change
 3. Apply patches on bug report 14576, and this patch, and run
 ./updatedatabase.pl inside the koha shell
 4. Now return the checked out item (when you updated the database
 you
 added one new syspref: UpdateItemLocationOnCheckout which
 is off by default)
 5. Check the item out again and notice the shelving location is not
 changed, showing that when the UpdateItemLocationOnCheckout is not
 enabled and the shelving location is not changed upon issue.
 6. Enable the aforementioned syspref in the Administration->Global
 system preferences->Circulation interface
 7. Check out the item and notice the shelving location is changed
 to no
 value, showing when the UpdateItemLocationOnCheckout syspref is
 enabled
 it blanks the shelving location on the issue of an item.
 8. Run t/db_dependent/Circulation/issue.t

 Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

https://bugs.koha-community.org/show_bug.cgi?id=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #30 from Liz Rea  ---
Well that commit message is slightly closer anyway. I'll fix it again when I
sign it off lol.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #29 from Liz Rea  ---
Created attachment 87695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87695=edit
Bug 21159: (follow up) Fixed broken indentation in circulation. pref

Test plan:
Same as comment 21.

Sponsored-by: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #26 from Liz Rea  ---
Hi Hayley,

Cool, I"ll test it and if it looks all good will see if I can't get the right
commit message into the patch. :)

Thanks for clearing that up!

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Liz Rea  changed:

   What|Removed |Added

  Attachment #87574|0   |1
is obsolete||
  Attachment #87687|0   |1
is obsolete||

--- Comment #15 from Liz Rea  ---
Created attachment 87691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87691=edit
Bug 1: Updated Currency onboarding step to match DB

Between the time that the original patch was created and now, a field
has been added to the currency table which allows the user to specify
whether the currency should appear with a space between the symbol and
value. This patch updates the onboarding tool to accommodate that
option, as well as cleans up some issues with script tags and duplicate
entries to the DB. This patch depends on Bug 18308, building on the
steps that have been rearranged.

Test plan:

0) Apply patch 18308.

1) Drop and recreate your database, then restart_all

2) Go through the onboarding tool, noting that the order matches the
following:
 1 Create a library
 2 Create patron category
 3 Set minPasswordLength
 4 Create Koha administrator
 5 Create item type
 6 Define currency (see step 3!)
 7 Circulation rule/Complete

3) Note that when you get to the currency page that there is no option
for setting there to be a space between symbol and value

4) Apply this patch, and repeat step 1 - 3

5) Go through the onboarding tool again and this time note that on the
currency page there is an option to set there to be a space between
symbol and value - check this box.

6) Continue on to Koha

7) Apply a fine to a patron, log in as that patron, and verify that the
currency is displayed with a space between the symbol and the value in
the OPAC

8) Also verify that there is only one currency (the one you created) in
the currency table in your database

Note: This patch may fail the QA tools due to Asset not working with the
installer.

Sponsored-by: Catalyst IT

Signed-off-by: Liz Rea 
I confirm that the QA tool has a false positive for Asset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

--- Comment #16 from Liz Rea  ---
Created attachment 87692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87692=edit
Bug 1: Added missing template file

Thanks for testing Liz. Here is the missing file!

Sponsored-by: Catalyst IT.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |koha-b...@lists.koha-commun
   |m   |ity.org
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4264] Categories/Groups for authorized value categories

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4264

Katrin Fischer  changed:

   What|Removed |Added

Summary|categories for authorized   |Categories/Groups for
   |values  |authorized value categories

--- Comment #3 from Katrin Fischer  ---
Maybe this could work similar to the groups/subgroups on reports? 

We have a table for categories now, so the development would no longer be that
big.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4503] Javascript files in js directory are not translated

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |koha-b...@lists.koha-commun
   |m   |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Katrin Fischer  ---
All linked bugs have been closed - closing this bug as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4948] When cancelling a waiting hold, allow to trigger hold for next patron

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948

Katrin Fischer  changed:

   What|Removed |Added

Summary|canceling a hold missing|When cancelling a waiting
   |steps for existing holds|hold, allow to trigger hold
   ||for next patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5250] Various enhancements to web based checkouts

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Katrin Fischer  ---
This is a very old bug where most of the things listed have since been resolved
separately. Closing here, please reopen small separate bugs if anything was
missed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5785] Holds should catch new acquisitions

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5785

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I am not sure about what was the intended behavior here. We display information
about holds in acq. Once an item is ready for checkout, it's usually returned
and triggers the hold. The checkin can also be used to remove a 'processing'
status.

I am not sure when the hold should be caught otherwise - on receive would be
too early as getting items ready might take a few days depending on workflows.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Katrin Fischer  changed:

   What|Removed |Added

  Component|Patrons |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8469] Inconsistent language in reserve status

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8469

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
I just checked and it seems all ok to me in master. The item shows everywhere
as in transit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
Hi Owen,
not sure you remember that one. What would you expect to display?

I just checked, when returning the item the messages on top say:

Item is withdrawn.
Item not checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21855] Remove deprecated delete_unverified_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22580

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21855] Remove deprecated delete_unverified_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=20580   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20580] create_superlibrarian.pl should accept parameters

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20580

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=21855   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

   Target Milestone|--- |19.05

--- Comment #3 from Katrin Fischer  ---
As we remove the other related script in this release, it would make sense to
remove this one in 19.05 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

--- Comment #2 from Katrin Fischer  ---
Created attachment 87690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87690=edit
Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob

Removes the deprecated script and changes the hint on the
PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference.

To test:
- Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl
  was deleted
- Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay
  system preference is correct
- Make sure there are no other reference to the removed script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||The functionality of
  release notes||delete_expired_opac_registr
   ||ations.pl was moved into
   ||the cleanup_database.pl
   ||cronjob. Please make sure
   ||to adjust your conjob
   ||configuration accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21855] Remove deprecated delete_unverified_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||The functionality of
  release notes||delete_unverified_opac_regi
   ||strations.pl was moved into
   ||the cleanup_database.pl
   ||cronjob. Please make sure
   ||to adjust your conjob
   ||configuration accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

Summary|Remove  |Remove deprecated
   |misc/cronjobs/delete_expire |delete_expired_opac_registr
   |d_opac_registrations.pl |ations.pl cronjob
  Component|Architecture, internals,|Command-line Utilities
   |and plumbing|
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
 CC||katrin.fisc...@bsz-bw.de,
   ||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21855] Remove deprecated delete_unverified_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20580

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21855] Remove deprecated delete_unverified_opac_registrations.pl cronjob

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855

Katrin Fischer  changed:

   What|Removed |Added

Summary|Remove mention of   |Remove deprecated
   |deprecated  |delete_unverified_opac_regi
   |delete_unverified_opac_regi |strations.pl cronjob
   |strations.pl cronjob|
  Component|System Administration   |Command-line Utilities
 CC||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20580] create_superlibrarian.pl should accept parameters

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20580

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Katrin Fischer  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Katrin Fischer  ---
*** Bug 22465 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580
Bug 22580 depends on bug 22465, which changed state.

Bug 22465 Summary: PatronSelfRegistrationExpireTemporaryAccountsDelay should 
recommend cleanup_database.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22465] PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Marking as duplicate to bug 22580 - we can change the note with removing the
file.

*** This bug has been marked as a duplicate of bug 22580 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6876] OAI-PMH: ListMetadataFormats lists 2 URLs in namespace

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6876

--- Comment #7 from Katrin Fischer  ---
marc21
Namespace http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
Schema http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd

marcxml
Namespace http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
Schema http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd

Note: Schema links exist, Namespace links do not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6876] OAI-PMH: ListMetadataFormats lists 2 URLs in namespace

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6876

Katrin Fischer  changed:

   What|Removed |Added

Summary|oai-pmh ListMetadataFormats |OAI-PMH:
   |marcxml definition  |ListMetadataFormats lists 2
   ||URLs in namespace

--- Comment #6 from Katrin Fischer  ---
It looks like it was changed in part, there is only 1 URL in schema, but 2 URLs
in one namespace element separated by space.

.../cgi-bin/koha/oai.pl?verb=ListMetadataFormats

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

--- Comment #1 from Katrin Fischer  ---
Could be: /cgi-bin/koha/oai.pl?verb=Identify

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22677] New: Include hint on OAI-PMH URL for Koha in system preference

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677

Bug ID: 22677
   Summary: Include hint on OAI-PMH URL for Koha in system
preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

We should include a link to the right URL like we do for other things like
ILS-DI and Self checkout in the description of the OAI-PMH system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org
   Patch complexity|String patch|---
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730

--- Comment #3 from Katrin Fischer  ---
Created attachment 87689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87689=edit
Bug 6730: Rename 'basket' filter to 'basket name' on receive page

This way it's clear that you can search for the name here, but
not for the number. It also matches the labelling of the
other filter: Basket group name below.

To test:
- Receive shipment
- Enter invoice number and go to receive page
- Look at the filters on the left
- Confirm the changed label and that basket name is searched

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730

Katrin Fischer  changed:

   What|Removed |Added

Summary|basket number should show   |Rename 'basket' filter to
   |the number entered by the   |'basket name' on receive
   |library |page
 QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
The filter works on the basket name, I suggest we just relabel it to make it
more clear. Both the basket name and it's number are shown in the table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18556] Message "Patron's address in doubt" is confusing

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Maybe we should rename the flag too to make a bit easier to understand?

Wrong address
Wrong contact details
Wrong address information

... ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Katrin Fischer  changed:

   What|Removed |Added

Summary|change description of   |Fine descriptions related
   |rental charges in account   |to Rentals are
   |fines   |untranslatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166
Bug 12166 depends on bug 11573, which changed state.

Bug 11573 Summary: change description of rental charges in account fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] change description of rental charges in account fines

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED
  Component|Circulation |Fines and fees

--- Comment #34 from Katrin Fischer  ---
Not sure if this is a duplicate to bug 21953 - Rental vs. Lost. 

It looks like Rental might still have issues:

C4/Circulation.pm

if ( $charge > 0 ) {
my $description = "Rental";
AddIssuingCharge( $issue, $charge, $description );
}

if ( $accumulate_charge > 0 ) {
my $type_desc = "Renewal of Daily Rental Item " . $biblio->title . "
$item_unblessed->{'barcode'}";
AddIssuingCharge( $issue, $accumulate_charge, $type_desc )
}

And same without Daily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15860] Alias missing for /plugin on packages

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860

Katrin Fischer  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22674] Change wording of payments in the GUI

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22674] Change wording of payments in the GUI

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674

--- Comment #1 from Katrin Fischer  ---
Created attachment 87688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87688=edit
Bug 22674: Change wording of payments in the GUI

This changes the different versions of "Payment, thanks"
to just read "Payment".

To test:
- Look at the Fines & Charges tables in
  - OPAC patron account > your fines
  - Staff patron account > Accounting > Transactions tab
  - Staff patron account > Accounting > Make a payment tab
- Verify all tables display the descriptions correctly
- Decide if you like this better than before
  Yes: sign-off
  No: comment on the bug please

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22674] Change wording of payments in the GUI

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17127] Can't blacklist MARC21 500 with NotesBlacklist

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

--- Comment #4 from Katrin Fischer  ---
Magnus, interesting riddle...
I haven't been able to find out where it comes from either. I was thinking it
could be biblioitems.notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Hayley Mapley  changed:

   What|Removed |Added

 Blocks||21265


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265
[Bug 21265] Additional step at end of onboarder to enable HEA
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265

Hayley Mapley  changed:

   What|Removed |Added

 Depends on||1


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1
[Bug 1] Include the definition of currency in onboarding tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Hayley Mapley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

--- Comment #14 from Hayley Mapley  ---
Created attachment 87687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87687=edit
Bug 1: Added missing template file

Thanks for testing Liz. Here is the missing file!

Sponsored-by: Catalyst IT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22676

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22676] Staff able to workaround holds block

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22676

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18450

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22676] Staff able to workaround holds block

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22676

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Stephanie, how are you renewing? Scanning in the item again or from the
renewal tab? Probably not a duplicate, but reads similar to bug 18450.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

--- Comment #13 from Liz Rea  ---
I think probably you just forgot to add the file for step 7 with git add 
:D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22676] Staff able to workaround holds block

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22676

Stephanie  changed:

   What|Removed |Added

 CC||sl...@duncanville.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22676] New: Staff able to workaround holds block

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22676

Bug ID: 22676
   Summary: Staff able to workaround holds block
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sl...@duncanville.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

Created attachment 87686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87686=edit
Permissions settings

I've tried to set permissions so that no one but SuperLibrarians have the power
to override blocked renewals (particularly for over the renewal limit or items
that have a hold). I did the permission in Administration and also in
everyone's individual permissions. But the regular staff still see the option
to override the hold and renew.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

--- Comment #4 from rkui...@roundrocktexas.gov ---
Having the ability to track transfer between budgets would be a great help to
our library.  It would make reconciling with our cities budget much easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #12 from Liz Rea  ---
Hi, 

At step 7, I've got 

Template process failed: file error -
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep7.tt
: not found at /home/vagrant/kohaclone/C4/Templates.pm line 122

After clicking "submit" on the define a currency page.

Something I had not noticed before in the onboarder, is that the "next" buttons
all say Submit on them. I think I'd rather they say something like "save and
continue" or "Next" instead, as Submit is a developer word for what the button
is/does. That doesn't need to be fixed here, but I may file another bug for it.

Thanks for having another look,

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #4 from Liz Rea  ---
I laughed so hard at myself I scared my dog.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Liz Rea  changed:

   What|Removed |Added

  Attachment #87684|0   |1
is obsolete||

--- Comment #3 from Liz Rea  ---
Created attachment 87685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87685=edit
Bug 22675: Fix SCO behaviour on non-existent barcodes

Bug 21206 replaced GetItem for Koha::Items->find, and introduced this
problem. This patch verifies $item is defined before attempting to use
its methods.

To test:
- Log into SCO
- Type an invalid barcode
=> FAIL: Things explode :-/
- Apply this patch, reload
- Type an invalid barcode
=> SUCCESS: A nice error message is displayed :-D
- Sign off :-D

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Liz Rea  changed:

   What|Removed |Added

  Attachment #87672|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 87684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87684=edit
Bug 22675: Fix SCO behaviour on non-existent barcodes

Bug 21206 replaced GetItem for Koha::Items->find, and introduced this
problem. This patch verifies $item is defined before attempting to use
its methods.

To test:
- Log into SCO
- Type an invalid barcode
=> FAIL: Things explode :-/
- Apply this patch, reload
- Type an invalid barcode
=> SUCCESS: A nice error message is displayed :-D
- Sign off :-D

Signed-off-by: Liz Rea 
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87621|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize  ---
Created attachment 87680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87680=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87622|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 87681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87681=edit
Bug 22521: Update existing accounttypes

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87624|0   |1
is obsolete||

--- Comment #61 from Martin Renvoize  ---
Created attachment 87683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87683=edit
Bug 22521: (follow-up) Update 'Offsets' test

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87623|0   |1
is obsolete||

--- Comment #60 from Martin Renvoize  ---
Created attachment 87682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87682=edit
Bug 22521: (QA follow-up) Corrections to tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87620|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize  ---
Created attachment 87679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87679=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87619|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize  ---
Created attachment 87678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87678=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21891] Remove non-XSLT detail view in the staff client

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21891] Remove non-XSLT detail view in the staff client

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891

Michal Denar  changed:

   What|Removed |Added

  Attachment #87664|0   |1
is obsolete||

--- Comment #2 from Michal Denar  ---
Created attachment 87677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87677=edit
Bug 21891: Remove non-XSLT detail view in the staff client

This patch removes the non-XSLT markup from the bibliographic detail
page in the staff client. The XSLTDetailsDisplay preference has
been altered to accommodate this change. A blank value in
XSLTDetailsDisplay will now be equivalent to "default."

To test, apply the patch and set the value of XSLTDetailsDisplay to
either blank or "default."

View the detail page for a bibliographic record in the staff client. The
XSLT view should be shown.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22069] Log viewer not displaying item renewals

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87667|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 87676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87676=edit
Bug 22538: Add a noticeable alert about waiting holds

In SCO, bug 21772 introduced holds information, but it lacked the
capability to attract atention when any of those holds was in waiting
status. Because SCO and opac-user uses the same include file for holds
table, this bug applies to both modules.

To test:
1) Have a patron with holds in waiting status and pending status.
2) Enable SCO module.
3) Holds tab label contains holds count, but doesn't inform that there
   is something that requires attention.
5) Holds tab content has no visual aid to recognize without reading
   effort which holds are in waiting status.
6) Apply this patch
   => SUCCESS: Holds tab label has a visual aid to indicate that
  something requires attention, and in
  holds table it's easy to recognize waiting holds without reading
  effort.
7) Sign off

Sponsored-by: Theke Solutions

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

--- Comment #16 from Liz Rea  ---
Created attachment 87675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87675=edit
Bug 20837: (QA Follow-up) adding missing filter to make QA tool happy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

--- Comment #15 from Liz Rea  ---
Created attachment 87674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87674=edit
Bug 20837: Use ReservesControlBranch to determine holdability of items

To test:
 1 - Set a default holds plicy for an item type as 'from home library'
 2 - Set CircControl to 'logged in library'
 3 - Log in as staff from a library without the rule set
 4 - Note you can set holds for patrons of any library on items of type
above
 5 - Toggle ReservesControlBranch and note that nothing changes
 6 - Toggle CircControl and note some combinations don't allow holds
 7 - Apply patch
 8 - Toggle ReservesControlBranch and note that holdability is affected
 9 - Toggle CircControl and note holdability does not change
10 - Read the note on admin/smartrules.pl and confirm it makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Liz Rea  changed:

   What|Removed |Added

  Attachment #87409|0   |1
is obsolete||
  Attachment #87410|0   |1
is obsolete||

--- Comment #14 from Liz Rea  ---
Created attachment 87673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87673=edit
Bug 20837: Unit tests

To test:
prove -v t/db_dependent/Holds.t
prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

--- Comment #13 from Liz Rea  ---
I have questions about how this could affect current users and might cause some
nasty surprises for existing users, but the behaviour is correct now based on
the tooltips so new libraries might find this easier to understand so the
change is probably in the better long term interest.

Signing off.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

--- Comment #15 from Martin Renvoize  ---
No worries, I initially thought it was a new perl operator I hadn't come
across.

I'll do some testing proper tomorrow morning. Thanks Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 87672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87672=edit
Bug 22675: Fix SCO behaviour on non-existent barcodes

Bug 21206 replaced GetItem for Koha::Items->find, and introduced this
problem. This patch verifies $item is defined before attempting to use
its methods.

To test:
- Log into SCO
- Type an invalid barcode
=> FAIL: Things explode :-/
- Apply this patch, reload
- Type an invalid barcode
=> SUCCESS: A nice error message is displayed :-D
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22675


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675
[Bug 22675] SCO broken on invalid barcodes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||21206
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
[Bug 21206] C4::Items - Remove GetItem
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22675] New: SCO broken on invalid barcodes

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Bug ID: 22675
   Summary: SCO broken on invalid barcodes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The SCO tool breaks when a non-existent barcode is introduced
To reproduce:
- Log into SCO
- Type any barcode that doesn't exist on the DB, hit enter
=> FAIL: Explodes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3766] Cities/Towns only on one address

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3766] Cities/Towns only on one address

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87656|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 87671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87671=edit
Bug 3766: Cities/Towns only on one address

This patch ties the alternate address and alternate contact address
fields in the patron entry form to the cities and towns data. This
provides a dropdown of predefined city data to these address fields.

To test, apply the patch and edit a patron record.

Test city selection for all three address fields: Main address,
alternate address, and alternate contact. Confirm that city selection
works correctly and that your changes are saved correctly.

Perform these tests with all AddressFormat options: French, German, and
US.

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >