[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer changed: What|Removed |Added QA Contact|tomasco...@gmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22652] Editing Course reserves is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #10 from Katrin Fischer --- I think that fixes part of the problem I saw - will retest and file separate bugs if necessary later. Thx Sonia! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 --- Comment #11 from Katrin Fischer --- Sorry, I forgot that git bz would not obsolete the first patch automatically because I had changed the subject line :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Katrin Fischer changed: What|Removed |Added Attachment #12733|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Chris Cormack changed: What|Removed |Added Attachment #86548|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 87994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87994=edit Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha The CM field was all set up for implementation, but never completed. We should fully implement the CM ( Hold Pickup Date ), which according to the SIP2 protocol specification is "The date that the hold expires". Test Plan: 1) Set up a waiting hold for an item 2) Using the sip cli emulator, send an item information request for that item 3) Note the CM field does not show up 4) Apply this patch 5) Restart all the things! 6) Repeat the item information request 7) Note the CM field is now transmitted! Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack changed: What|Removed |Added Attachment #86574|0 |1 is obsolete|| --- Comment #38 from Chris Cormack --- Created attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Chris Cormack changed: What|Removed |Added Attachment #87937|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 87992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87992=edit Bug 22695: Remove non-XSLT search results view from the staff client This patch removes the option to select non-XSLT search results in the staff client. The patch removes the markup from the template, updates the system preference options, and modifies Search.pm so that OPAC and staff client results XSLT functions are not tied together. To test, apply the patch and set the XSLTResultsDisplay to a blank value. Run the database update. The value of the XSLTResultsDisplay system preference should now be "default." Perform a catalog search in the staff client. The results should be shown using the XSLT view. Test that OPAC search results respect the OPACXSLTResultsDisplay preference when enabled and disabled. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Bin Wen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84551|0 |1 is obsolete|| --- Comment #218 from Aleisha Amohia --- Created attachment 87989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87989=edit Bug 15565: (follow-up) Changes to maximum hold allowed logic Implemented changes to the logic to address Katrin Fischer's points in comment #175, also changed the modal box wording to use 'hold' not 'reserve' Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe the first item checkbox is checked and other unchecked checkboxes are disabled. 6. Repeat step 4 this time setting holds per day to 5 7. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays 8. Select a second item checkbox and observe a modal saying you have reached the maximum number of holds for the record is loaded - notice the wording 'hold' not 'reserve' in use in the modal box 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed - notice the wording of 'hold' not 'reserve' is used in the modal box. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. In both the OPAC and staff client try placing a record level hold, selecting a value from the 'Holds to place (count)' dropdown. Notice that the maximum value of this is the lowest value out of the 'maximum number of holds per record', 'maximum number of holds per day' and the 'maxreserves' system preference so in this case it will be 2 18. Save and notice 2 holds are placed 19. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84553|0 |1 is obsolete|| --- Comment #220 from Aleisha Amohia --- Created attachment 87991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87991=edit Bug 15565: (follow-up) fixing typo that breaks placing a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84552|0 |1 is obsolete|| --- Comment #219 from Aleisha Amohia --- Created attachment 87990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87990=edit Bug 15565: (follow-up) Place multiple holds from opac-search.pl Previously before this patch if you selected multiple bibliographic results from opac-search.pl and selected 'Place hold' and confirmed the hold only 1 hold on the first of the selected biblios would be placed. This patch fixes this bug and enables users to be able to place holds on multiple bibliographic records in opac-search.pl, select 'Place hold', select if they want each of these holds to be on 'Next available', 'Next available from group', or 'A specific item' and place their holds and all the holds they placed will be placed correctly. Test plan: 1. Follow test plan on the last patch - (Don't apply this patch) 2. Try to select multiple bibliographic record checkboxes and select 'Place hold' 3. Confirm holds and notice you are re-directed to opac-user.pl and only the first hold has been placed 4. Apply this patch 5. Restart memcached and plack if running 6. Repeat steps 2 and 3 and notice all holds were placed 7. Repeat step 2 and then select a variety of 'A specific item' and 'Next available item' holds for each of the bibliographic holds and confirm they are all placed correctly 8. Confirm you can still place multiple holds correctly in opac-reserve accessing from a OPAC biblio detail page Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84550|0 |1 is obsolete|| --- Comment #217 from Aleisha Amohia --- Created attachment 87988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87988=edit Bug 15565: (QA follow-up) Fix some last filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84549|0 |1 is obsolete|| --- Comment #216 from Aleisha Amohia --- Created attachment 87987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87987=edit Bug 15565: (follow-up) Removed leftover debug code and added missing filters Sponsord-By: Brimbank Library, Australia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84544|0 |1 is obsolete|| --- Comment #211 from Aleisha Amohia --- Created attachment 87982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87982=edit Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder Signed-off-by: Danielle Elder Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84543|0 |1 is obsolete|| --- Comment #210 from Aleisha Amohia --- Created attachment 87981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87981=edit Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84547|0 |1 is obsolete|| --- Comment #214 from Aleisha Amohia --- Created attachment 87985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87985=edit Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Previously the selected branch dropdown value was not being successfully retrieved in opac-reserve.pl, this resulted in opac holds being placed with no pickup branch being set. Consequently as no branch was associated with the hold an Ajax error was thrown when viewing the holds-table in the patron page in the staff client. This commit successfully retrieves the selected branch value and so fixing the Ajax error. Test plan: 1. Apply all patches on bug report 15565 except this commit 2. Place a hold(s) from opac-reserve.pl. 3. Go to your opac patron summary page (opac-user.pl) and notice although the holds are successfully displayed they have no 'Pickup location' value 4. Go to the patron page in the staff client and click on the 'Hold(s)' tab and notice a popup explaining the datatable Ajax error is loaded 5. Apply this patch 6. Repeat step 3 noticing this time in the opac-user.pl a 'Pickup location' is displayed for the hold you just created. 6. Repeat step 4 and notice the hold datatable is successfully loaded and populated without an Ajax error popup being loaded. Sponsored-By: Brimbank Library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84546|0 |1 is obsolete|| --- Comment #213 from Aleisha Amohia --- Created attachment 87984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87984=edit Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84548|0 |1 is obsolete|| --- Comment #215 from Aleisha Amohia --- Created attachment 87986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87986=edit Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds This commit implements changes to opac-reserve.tt and opac-reserve.pl. 1. The change to opac-reserve.tt JS fixes the total_requested() function which returns an output which is always 2 digits higher than the actual number of selected item checkboxes. i.e. if the 'maxreserves' syspref (limit for the overall number of reserves allowed by a user) is 4 and a user has no previous holds and ticks 3 item checkboxes and submits the form. The 'Maximum number of reserve exceded.' popup message is displayed, however as they have selected 3 items for reservation this is less than the maxreserves value of 4. The popup is displayed because total_requested() JS function is returning 5 (i.e. 2 on top of the actual number of requested holds). This commit usbtracts 2 from the number of holds calculated by total_requested() so that the accurate number of requested holds is being used to determine whether or not to display the excess holds popup. 2. When the 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item checkboxes in opac-reserve.pl and submit the form. The form will submit successfully and to the user everything looks to have worked however the holds will not be successfully created. This is because after the form is submitted to opac-reserve.pl a check is done: If 'number of submitted hold requests' + 'number of previous existing holds' greater than or equal to maxreserves syspref then set the variable '$canreserve' to 0. If the $canreserve variable is 0 the form will submit, no warning/error message is displayed to the user but the holds are not created. Users should be able to place 4 holds if the maxreserves syspref is 4 (just not more than 4 holds). This commit changes this check to: If 'number of submitted hold requests' + 'number of previous existing holds' greater than maxreserves syspref then set the variable '$canreserve' to 0.. i.e. notice we only check for greater than (not equal to). Which solves the bug of the form submitting and no holds being created when the maxreserves syspref and 'Holds per record (count)' (circulation rule) are the same. Test plan (in two parts to test fix #1 and #2 (above)): Test plan for fix #1: 1. Apply all patches on this bug report (15565) and follow and confirm the feature works as described in the test plan in the first commit 2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)' (circulation rule) to 5) 3. Ensure your logged in patron account has no existing reserves 4. In the OPAC go to a biblio page with 3 or more items 5. In the reservation page (opac-reserve.pl) for that biblio select 2 item checkboes to place 2 item level holds and notice the 'Maximum number of reserve exceded.' popup message is displayed. As the maxreserves syspref value is 3 you should be able to place 2 holds without exceeding that value 6. Apply this patch 7. Repeat step 5 and notice the form submits without the exceeding popup message and the holds are successfully placed. Test plan for fix #2: 1. Apply all patches attached to this bug report (bug 15565) and perform the test plan in the first commit and verify it works. 2. Set your 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref to the same value 3 3. Go to a biblio in the OPAC with 3 or more items 4. In the opac-reserve.pl reservation interface for that biblio tick 3 item checkboxes to place 3 item level holds and submit the form. 5. Notice the form submits and no warning/error message is displayed 6. In the opac user summary page that is displayed after the reserve form is submitted notice the holds are not displayed this is because they have not been placed 7. Apply this patch 8. Repeat step 4 and 5 and notice the holds have been successfully placed and are displayed in your opac user summary page. Sponsored-By: Brimbank Library Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84545|0 |1 is obsolete|| --- Comment #212 from Aleisha Amohia --- Created attachment 87983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87983=edit Bug 15565: Remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84542|0 |1 is obsolete|| --- Comment #209 from Aleisha Amohia --- Created attachment 87980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87980=edit Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84541|0 |1 is obsolete|| --- Comment #208 from Aleisha Amohia --- Created attachment 87979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87979=edit Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Test plan: 1. Create an circulation rule to use for testing the patches on this bug report. Ensure it has a value greater than 1 for 'Holds allowed', 'Holds per record (count)', and 'Item level holds' is enabled. 2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'. 3. Go to the reservation page (request.pl) of a biblio in the staff client with more than one item. 4. Notice beside each item a radio button is displayed preventing you from being able to select multiple items to place a hold on. 5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC also notice a radio button is displayed beside every item. 6. Apply patches 7. Repeat step 3 and 5 and notice in both the staff client and OPAC checkboxes rather than radio buttons are displayed beside each item so you can select multiple items for reservation at a time. 8. From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record. - check also maxReserves system preference. 9. From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record. This is enforced by all unticked item checkboxes being disabled after the number of ticked checkboxes equals the 'Holds per record (count)' (circulation rules) value. - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22698] Fix incorrect button classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698 Chris Cormack changed: What|Removed |Added Attachment #87941|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 87978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87978=edit Bug 22698: Fix incorrect button classes This patch builds on Bug 22023 in making further corrections to toolbar button classes. To test, apply the patch and view the following pages to confirm that toolbar buttons are consistent: - Acquisitions -> Vendor -> View basket. - Administration -> Additional fields -> Select a table. - Administration -> Audio alerts. - Catalog -> Advanced search -> More/fewer options link - Cataloging -> Edit record -> Advanced editor -> Advanced search. - Cataloging -> Edit record -> Advanced editor -> Macros. - Cataloging -> Edit record -> MARC21 008 value builder. - Cataloging -> Search results. - Circulation -> Checkout notes. - Circulation: Sticky due date clear button, view restrictions, override restrictions temporarily, add message, delete message - Course reserves: Toolbar buttons on that page and the course reserve detail page. - ILL requests -> View ILL requests. The "New ILL request" and "List requests" button. - Lists and Lists -> View list. - Patrons -> Search -> Merge patrons. - Patrons -> View patron -> "Edit" button on patron image (patronimages must be enabled). - Patrons -> View patron -> "More" menu -> Manage API keys. - Patrons -> View patron -> "More" menu -> Set permissions. - Patrons -> View patron -> Delete circulation message link. - Patrons -> View patron -> Edit patron. - Patrons -> View patron -> Housebound. - Reports -> Dictionary. - Serials -> Numbering patterns. - Serials -> Subscription -> Receive. - Tools -> Labels -> Manage -> Label batches: Export selected. - Tools -> Patron card creator -> Manage -> Card batches -> Edit batch. - Tools -> Patron card creator. The "New" and "Manage" buttons. - Tools -> Patron clubs. - Tools -> Quote editor -> Import quotes. - Tools -> Rotating collections. Toolbar buttons on that page and the collection view page. - Tools -> Tags. - Tools -> Upload local cover image. Signed-off-by: Michal Denar Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22698] Fix incorrect button classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||hayleymap...@catalyst.net.n ||z --- Comment #10 from Hayley Mapley --- (In reply to Katrin Fischer from comment #9) > The system preference text has been fixed, there are only some occurences in > dev type documentation now. Hi Katrin, Should both patches be applied here? I have merge conflicts if that's the case. Applying: Bug 8701 - Help for OpacHiddenItems pref should not point to text in install directory Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 8701 - Help for OpacHiddenItems pref should not point to text in install directory Or should I only apply your patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044 Hayley Mapley changed: What|Removed |Added Attachment #83469|0 |1 is obsolete|| --- Comment #5 from Hayley Mapley --- Created attachment 87975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87975=edit Bug 22044: Set default and add NoRenewalBeforePrecision preference for new/affected installs I am not sure the correct answer - for upgraded installs the pref was set to date, which changed behaviour For new installs the pref was unset, behaved as if 'exact_time' so we shouldn't change behaviour? If the perceived default is date then the code should be changed, or this shouldn't be a pref at all? To test: 1 - Have a new system missing this pref 2 - Note when searchign the pref in staff client if appears as 'date' 3 - Check the db to confirm value is 'NULL' 4 - Apply patch and run update 5 - Pref is now set to 'exact_time' Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044 --- Comment #4 from Hayley Mapley --- (In reply to Nick Clemens from comment #1) > 3 - Check the db to confirm value is 'NULL' I am guessing that this is instructing us to check whether the preference is actually in the database, rather than whether it's value cell is set to null. If this is the case, I am able to sign off as the test plan results were as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #3 from Hayley Mapley --- (In reply to Katrin Fischer from comment #2) > Nick, don't make your QAM grumpy, assign your bugs! ;) Hi Nick, I'm in the process of testing your patch, and am stuck at step 3 - check db to confirm value is 'NULL'. Probably because I'm a newbie, but I can't locate the NoRenewalBeforePrecision that you mention in the systempreferences table to check that it has the value of NULL. The system preference does show up in the staff client. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Chris Cormack changed: What|Removed |Added Attachment #87935|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 87973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87973=edit Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages This patch modifies the patron category edit form so that the enrollment period datepicker widget cannot be used to select a date in the past. The element had a "datepicker" class, which triggers a default datepicker configuration. This was overriding the configuration in the page-specific JavaScript file. To test, apply the patch and go to Administration -> Patron categories. Click the "Enrollment period -> Until date" field and verify that dates before today are disabled. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Chris Cormack changed: What|Removed |Added Attachment #86664|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 87972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87972=edit Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v" Signed-off-by: Björn Nylén Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22174] Add link to help page for API key management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Hayley Mapley changed: What|Removed |Added Attachment #86703|0 |1 is obsolete|| --- Comment #2 from Hayley Mapley --- Created attachment 87971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87971=edit Bug 22174: Add link to help page for API key management Makes the help link on the API key management page point to the proper section in the Koha manual. To test: - Activate RESTOAuth2ClientCredentials system preference - Go to any patron account - Go to More > Manage API keys - Click on the Help link in top right corner - Verify that the right section of the Koha manual displays Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22174] Add link to help page for API key management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22645] Add 'ISSN' option to OPAC's basic search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22645 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22645] Add 'ISSN' option to OPAC's basic search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22645 Chris Cormack changed: What|Removed |Added Attachment #87524|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 87970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87970=edit Bug 22645: Add 'ISSN' sarch option to OPAC simple search pull down To test: - Apply patch - Verify that the ISSN option shows up in the pull down for the simple search on top of the OPAC - Search for an ISSN with the new search option - Verify the correct search result shows Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22633] Link barcodes in hold summary in patron account to moredetail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22633 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #3 from Chris Cormack --- There's a conflict in the js now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Chris Cormack changed: What|Removed |Added Attachment #87946|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 87969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87969=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22652] Editing Course reserves is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Chris Cormack changed: What|Removed |Added Attachment #87936|0 |1 is obsolete|| --- Comment #9 from Chris Cormack --- Created attachment 87968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87968=edit Bug 22652 - Editing Course reserves is broken To test: 1. Create a course reserve or go on an existing one 2. Add items and add a change for the holdingbranch 3. On the list of items in this course reserve (course_reserves/course-details.pl?course_id=xx), click on "edit" at the end of a row : Without the patch, you can't see the holdingbranch you have choose for this item, but you see "LEAVE UNCHANGED" With the patch, you can see the holdingbranch you have choose when adding this item in the course Signed-off-by: Liz Rea Signed-off-by: Mikaël Olangcay Brisebois Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22652] Editing Course reserves is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Chris Cormack changed: What|Removed |Added Attachment #87285|0 |1 is obsolete|| --- Comment #10 from Chris Cormack --- Created attachment 87967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87967=edit Bug 20830: Make sure a fund is selected when ordering from a stage file Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #46 from Hayley Mapley --- Created attachment 87966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87966=edit Bug 18308: Added missing filter in memberentrygen.tt Test plan: Apply this patch and check that everything still works. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22090] Cash register report missing data in CSV export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22090 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22090] Cash register report missing data in CSV export
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22090 Chris Cormack changed: What|Removed |Added Attachment #87548|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 87965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87965=edit Bug 22090: Add missing information to cash register CSV file Some information was missing from the CSV export file of the Cash register report: manager surname, patron surname and payment notes. Also pretties up the column headers a bit and makes the sequence between GUI and CSV export match. To test: - Make sure you have some fines and fees and payments in your system - Make a search with the Cash register report - Export results as CSV - Proof read hader line and make sure contents match headings - Verify first name and surname are shown for manager and patron - Verify notes show up Signed-off-by: Michal Denar Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #45 from Hayley Mapley --- Created attachment 87964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87964=edit Bug 18308: Changed ordering of onboarding steps This patch cleans up the previous patches according to comment 23, fixes various typos, and changes the order of steps in the onboarding so that the setting of minPasswordLength occurs before the admin password is set. Test plan: 1) Drop and recreate your database, and restart_all 2) Go through installation and onboarding 3) Note that the order of steps is: 1 Create a library 2 Create a ptron category 3 Create Koha administrator patron 4 Create a new item type 5 Create a new circulation rule 6 Set minPasswordLength syspref/Complete 4) Repeat steps 1 & 2 5) Note that the order of steps is now: 1 Create a library 2 Create a patron category 3 Set minPasswordLength syspref 4 Create Koha administrator patron 5 Create a new item type 6 Create a new circulation rule/Complete 6) Verify that the minPasswordLength syspref is set to the value from onboarding 7) Verify that the patron, item type, and circulation rule made in the onboarding exist in the administration 8) Sign off! Sponsored-by Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #44 from Hayley Mapley --- Created attachment 87963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87963=edit Bug 18308: Fixed issues with onboarding_messages.inc and onboardingstep6.tt Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #43 from Hayley Mapley --- Created attachment 87962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87962=edit Bug 18308: Added warning and dialog alert If an institution has a minPasswordLength which is < 8 characters then a warning will be set (which is visible in the intranet-error.log) and a dialog alert div will display the warning to the user in the memberentry.pl page in the intranet. Test plan: 1. Ensure that your minPasswordLength is set to less than 8 characters. This replicates the use case that a Koha instance is existing (i.e. not a new Koha instance) and not gone through the password length step of the onboarding tool (previous patch on this bug report) or that the institituion is new but set a password length of less than 8 in the onboarding tool 2. Go to the memberentry.pl page and notice that there is no warning at the top of the page informing you that your minPasswordLength is less than 8 3. Apply this patch 4. Refresh the memberentry.pl page and notice that there is a yellow warning at the top of the page informing you that your minPasswordLength syspref is less than 8 Sponsored-By: Catalyst IT Signed-off-by: Dominic Pichette Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Attachment #87959|0 |1 is obsolete|| Attachment #87960|0 |1 is obsolete|| --- Comment #42 from Hayley Mapley --- Created attachment 87961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87961=edit Bug 18308: Added step to onboarding tool to set minPasswordLength This patch increases the default minPasswordLength syspref value to 8 characters, for new installations. The final (6th step) of the onboarding tool is now a password length page where the default value of 8 can be altered. There is a security warning in red recommending to the user they keep the minimum length of the password at 8 characters or more. This patch also removes the atomicupdate .sql file to be run in an update to alter the default minPasswordLength value for existing Koha installations, based on tester feedback. Test plan: 1. Create a patron with a password less than 3 characters in length and notice that a red message is displayed by the input telling you that the password must be 3 characters minimum length 2. Query the database "select value from systempreferences where variable="minPasswordLength"; and notice the value is 3 3. Drop and recreate your database and restart memcached 4. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to create a circulation rule 5. Apply patch 6. Repeat step 3 7. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to set the minimum password length, the numerical input element has a default value of 8 and notice that it will go below 3 8. Repeat step 2 and notice the value is 8 9. In the onboarding tool change the minimum password length value to 7 and submit the form 10. Notice the completed page of the onboarding tool is displayed with the message that the minimum password length has been set. 11. Repeat step 2 and notice the value is now 7. 12. Try to create a patron in Intranet and OPAC with a password less than 7 characters and notice that a red message is displayed by the input telling you that the password must be 7 characters minimum length Sponsored-By: Catalyst IT Signed-off-by: David Bourgault https://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22316] Double quotes in some patron's attributes breaks patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #3 from David Roberts --- I've reproduced this too, but it doesn't affect the patron search on the checkout screen, only the patron search screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #41 from Hayley Mapley --- Created attachment 87960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87960=edit Bug 18308: Added warning and dialog alert If an institution has a minPasswordLength which is < 8 characters then a warning will be set (which is visible in the intranet-error.log) and a dialog alert div will display the warning to the user in the memberentry.pl page in the intranet. Test plan: 1. Ensure that your minPasswordLength is set to less than 8 characters. This replicates the use case that a Koha instance is existing (i.e. not a new Koha instance) and not gone through the password length step of the onboarding tool (previous patch on this bug report) or that the institituion is new but set a password length of less than 8 in the onboarding tool 2. Go to the memberentry.pl page and notice that there is no warning at the top of the page informing you that your minPasswordLength is less than 8 3. Apply this patch 4. Refresh the memberentry.pl page and notice that there is a yellow warning at the top of the page informing you that your minPasswordLength syspref is less than 8 Sponsored-By: Catalyst IT Signed-off-by: Dominic Pichette Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Attachment #87339|0 |1 is obsolete|| Attachment #87340|0 |1 is obsolete|| Attachment #87564|0 |1 is obsolete|| Attachment #87572|0 |1 is obsolete|| Attachment #87573|0 |1 is obsolete|| Attachment #87747|0 |1 is obsolete|| --- Comment #40 from Hayley Mapley --- Created attachment 87959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87959=edit Bug 18308: Added step to onboarding tool to set minPasswordLength This patch increases the default minPasswordLength syspref value to 8 characters, for new installations. The final (6th step) of the onboarding tool is now a password length page where the default value of 8 can be altered. There is a security warning in red recommending to the user they keep the minimum length of the password at 8 characters or more. This patch also removes the atomicupdate .sql file to be run in an update to alter the default minPasswordLength value for existing Koha installations, based on tester feedback. Test plan: 1. Create a patron with a password less than 3 characters in length and notice that a red message is displayed by the input telling you that the password must be 3 characters minimum length 2. Query the database "select value from systempreferences where variable="minPasswordLength"; and notice the value is 3 3. Drop and recreate your database and restart memcached 4. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to create a circulation rule 5. Apply patch 6. Repeat step 3 7. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to set the minimum password length, the numerical input element has a default value of 8 and notice that it will go below 3 8. Repeat step 2 and notice the value is 8 9. In the onboarding tool change the minimum password length value to 7 and submit the form 10. Notice the completed page of the onboarding tool is displayed with the message that the minimum password length has been set. 11. Repeat step 2 and notice the value is now 7. 12. Try to create a patron in Intranet and OPAC with a password less than 7 characters and notice that a red message is displayed by the input telling you that the password must be 7 characters minimum length Sponsored-By: Catalyst IT Signed-off-by: David Bourgault https://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22069] Log viewer not displaying item renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Chris Cormack changed: What|Removed |Added Attachment #87649|0 |1 is obsolete|| --- Comment #13 from Chris Cormack --- Created attachment 87958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87958=edit Bug 22069: Make log viewer find item renewals Without this patch renewals for checkouts wouldn't show in the log viewer. The log viewre was using RENEW, which we use for patrons, but for issue RENEWAL is used. The patch adds RENEWAL to the search params, when Renew was selected in the form, so both terms are included in the query. To test: - Make sure you have RenewalLog turned on - Make a patron renewal - Check something out and renew it - Go to Tools > Log viewer and test different searches - Modules All - Actions All - Modules All - Actions Renew - Modules Circulation - Actions Renew ... - Make sure results show as expected Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22069] Log viewer not displaying item renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #35 from Chris Cormack --- Created attachment 87957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87957=edit Bug 20689 Follow - tiny typo fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Chris Cormack changed: What|Removed |Added Attachment #83827|0 |1 is obsolete|| --- Comment #34 from Chris Cormack --- Created attachment 87956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87956=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. Both templates (the main view and the edit view) have been modified so that item_search_fields.js can be included in both. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Test both "new" and "edit" operations. Test other operations like delete and cancel. Signed-off-by: Mark Tompsett Signed-off-by: Jose-Mario Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Chris Cormack changed: What|Removed |Added Attachment #83795|0 |1 is obsolete|| --- Comment #33 from Chris Cormack --- Created attachment 87955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87955=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #131 from Aleisha Amohia --- (In reply to Michal Denar from comment #130) > Hi Aleisha, > ready for test? This can be nice new feature for 19.05 release. Not yet, almost there! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #9 from Hayley Mapley --- (In reply to Michal Denar from comment #8) > Patch works. Can I set it as SO? Or some more folow-ups coming? Hi Michal, I think I need to change some things to align with the comments I've received first. Thanks for taking a look! Setting to assigned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #39 from Hayley Mapley --- (In reply to Katrin Fischer from comment #38) > Hi Hayley, > > can you please fix a few things here? > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt >OK filters >FAIL forbidden patterns > forbidden pattern: Do *not* include full path to js files, use > the Asset > TT plugin (bug 20538) (line 137) >OK git manipulation >OK js_in_body >OK spelling >OK tt_valid >OK valid_template > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep8.tt >OK filters >FAIL forbidden patterns > forbidden pattern: Do *not* include full path to js files, use > the Asset > TT plugin (bug 20538) (line 137) >OK git manipulation >OK js_in_body >OK spelling >OK tt_valid >OK valid_template > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >FAIL filters > missing_filter at line 136 ( Warning: > [% > passwordwarning %]) >OK forbidden patterns >OK git manipulation >OK js_in_body >OK spelling >OK tt_valid >OK valid_template > > If you are using kohadevbox you can run the qa test tools from koha-shell: > qa -c 6 -v 2 > > There is also a complaint about the commit messages: > > Processing additional checks > > * Commit title does not start with 'Bug X: ' - df4b236511 > * Commit title does not start with 'Bug X: ' - a1946b6a31 > > This can be fixed easiest with: git rebase -i HEAD~6 and then rewording the > 2 at the beginning. > > Let me know, if I can help more. Hi Katrin, The missing filter I can definitely add. I normally do run the QA tools before attaching, I must have missed it this time though! Thanks for picking it up. The Asset plugin issue is trickier because it does not work with onboarding due to how it retrieves Koha version from the database (or tries to before the database is created). There is a patch that will solve this and allow for Asset to be used in onboarding Bug 22451, but it is not yet pushed to Master, so the full path js is all that can be done for now I think. I will reattach once I have reworded the commits and added the missing filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21662] Missing Developers from history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #18 from Michal Denar --- Hi Martin and Liz, any test for this patch? On Abou tpage Is till see Natasha ?? or Andy??. Is it correct? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #5 from Michal Denar --- Hi Josef, can you rebase this patch on master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't increment properly barcode in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937 --- Comment #4 from Michal Denar --- Created attachment 87954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87954=edit Bug 21937: syspref autoBarcode annual doesn't increment properly barcode This patch fix the barcode annual builder. The test wil work. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't increment properly barcode in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937 Michal Denar changed: What|Removed |Added Attachment #82828|0 |1 is obsolete|| Attachment #82829|0 |1 is obsolete|| --- Comment #3 from Michal Denar --- Created attachment 87953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87953=edit Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode in some cases This patch show the issue. If the DB contains a barcode (not auto attributed by Koha) which begin with the year used to generate automatically a new one, there may be a 'collision'. prove -v t/db_dependent/Barcodes_ValueBuilder.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't increment properly barcode in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6847] Bulk userid, password generation and email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I wonder how sending the password can work here... I guess it would require resetting it to a freshly generated one. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21942] Clean up cataloging merge template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #2 from Michal Denar --- Hi Owen, can you rebase patch on master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Michal Denar changed: What|Removed |Added Attachment #85262|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 87952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87952=edit Bug 22365: Removing warn when accessing Log Viewer To test: Go to Tools -> Log Viewer and confirm the warn no longer shows after applying the patch. Sponsored-by: Catalyst IT Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22365] Warn on Log Viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22408] Subscription entry form cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #13 from Michal Denar --- Created attachment 87951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87951=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #12 from Michal Denar --- Created attachment 87950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87950=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Michal Denar changed: What|Removed |Added Attachment #86462|0 |1 is obsolete|| Attachment #86463|0 |1 is obsolete|| Attachment #86464|0 |1 is obsolete|| --- Comment #11 from Michal Denar --- Created attachment 87949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87949=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #49 from Michal Denar --- Please rebase on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Michal Denar changed: What|Removed |Added Attachment #85722|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 87948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87948=edit Bug 22418: Add magnifying glass to 655 results To test: 1 - Have some 655 fields linked to authorities 2 - Notice they have no magnifyiung glass 3 - Apply patch 4 - Note they have one now Signed-off-by: Michal Denar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #20 from Michal Denar --- Martin, how can I test your patch? Please, gime us some test plan. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #8 from Michal Denar --- Patch works. Can I set it as SO? Or some more folow-ups coming? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #7 from Michal Denar --- Sorry folks, my fault. Nothing broken. It's between chair nad keyboard :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #27 from Michal Denar --- It's very useful feature, but sleep very long. Time to take it back to life? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22697] Reindent catalogue/result.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Michal Denar changed: What|Removed |Added Attachment #87924|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 87947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87947=edit Bug 22697: Reindent catalogue/result.tt This patch reindents the template for staff client catalogue search results. The only non-whitespace changes are comments to help identify closing tags and template directives. To test, apply the patch and perform a catalog search in the staff client. The results should look correct. The diff using the '-w' flag to ignore whitespace should highlight only moved lines and added comments. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22697] Reindent catalogue/result.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 --- Comment #7 from Michal Denar --- ES problem reportetd as bug 22704. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22704] Subtype search don't work with ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22704 Michal Denar changed: What|Removed |Added CC||ere.maij...@helsinki.fi, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22704] New: Subtype search don't work with ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22704 Bug ID: 22704 Summary: Subtype search don't work with ElasticSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: blac...@gmail.com Target Milestone: --- Hi, Steps to reproduce: - set Elastic as search engine - make full reindex of biblio - make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions - go to Advanced search - if necessary, click on 'More options' - in the 'Subtype limits' section, choose some Subtype like CD audio from drop-down menu - click on 'Search' - get result: No results match your search with limit(s): 'ff7-01-02:sd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22306] Elasticsearch search not working - it returns no result found in catalog search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22306 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar changed: What|Removed |Added Attachment #87945|0 |1 is obsolete|| --- Comment #6 from Michal Denar --- Created attachment 87946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87946=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
