[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #96 from Katrin Fischer  ---
I'll keep testing, but we need another patch:
- Remove  manage_keywords2koha_mappings from display and patron accounts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

--- Comment #11 from Katrin Fischer  ---
Hi Josef, I think you are right about subscription, thx for taking my other
suggestion into account!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #95 from Katrin Fischer  ---
Working here...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #94 from Katrin Fischer  ---
Managed the rebase myself - the change was caused by the non-XSLT view being
removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #93 from Katrin Fischer  ---
Hi Ere, I am sorry, I waited to long to continue here. Could you rebase it
please? I will try to come back to it as fast ass possible after (faster than
last time!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||oleon...@myacpl.org

--- Comment #17 from Katrin Fischer  ---
This changes the beahaviour of the patron duplicate message as the template for
displaying the data of the duplicate candidate patron is removed. I am not sure
about this change and it's not described in the commit messsage.

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #10 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #9)
> Can you explain why the 942$s is used here? 
> Why not use the LDR pos. 7 = s or check for an existing subscription?
> How is 942$s set?

Subscription is not a solution I think, sometimes library don't have
subscription for all serials - for example the ones not currently subscribed,
but imported from legacy system and circulated.

But using leader does make sense, I will add it, we could check both - leader
and biblio.serial.

As 942$s is by default mapped to biblio.serial, i just used it. There was some
discussion some time ago (year or two?) I think, but I can't find it now...

942$s need's to be added by cataloguer, or as default value in framework used
for serials...

> 
> Setting Failed QA to get attention to my questions! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #25 from Hayley Mapley  ---
I completed steps 1-5 in the test plan. After clicking on Print range though,
clicking on the template and layout dropdowns shows no options. Am I missing
something? Then, with neither of those options chosen, clicking Export and then
Download as PDF results in an error.

Also, the close link in the corner doesn't look like the rest of the close
icons, instead is a red square next to the word 'Close'.

Error trace:

Can't bless non-reference value at
/home/vagrant/kohaclone/C4/Creators/Layout.pm line 110

1.in C4::Creators::Layout::retrieve at
/home/vagrant/kohaclone/C4/Creators/Layout.pm line 110

  107: return -1;
  108: }
  109: my $self = $sth->fetchrow_hashref;
  110: bless ($self, $type);
  111: return $self;
  112: }
  113: 

2.in C4::Labels::Layout::retrieve at
/home/vagrant/kohaclone/C4/Labels/Layout.pm line 29

   26: sub retrieve {
   27: my $self = shift;
   28: push @_, "creator", $me;
   29: return $self->SUPER::retrieve(@_);
   30: }
   31: 
   32: sub delete {

3.in (eval) at /home/vagrant/kohaclone/labels/label-create-pdf.pl line 63

   60: our $pdf = C4::Creators::PDF->new(InitVars => 0);
   61: my $batch = C4::Labels::Batch->retrieve(batch_id => $batch_id);
   62: our $template = C4::Labels::Template->retrieve(template_id =>
$template_id, profile_id => 1);
   63: my $layout = C4::Labels::Layout->retrieve(layout_id => $layout_id);
   64: 
   65: sub _calc_next_label_pos {
   66: my ($row_count, $col_count, $llx, $lly) = @_;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664

Liz Rea  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664

--- Comment #9 from Liz Rea  ---
Created attachment 88246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88246=edit
Bug 22664: More making acquisitions links more easily clickable

To test:

* create a basket with an order from a staged record, and an order from
a suggestion
* add that basket to a basket group when you close it.
* note that the links to the basket in the first column, the link to the
basket group in the second column, and the link to
the suggester in the summary column are very small (only the ID# is
linked)
* apply this patch, restart the things
* refresh the page, note that the previously ogled links are now bigger
and easier to find and click, and that the links work and such
* rejoice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #88216|0   |1
is obsolete||

--- Comment #10 from Hayley Mapley  ---
Created attachment 88245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88245=edit
Bug 22139: Fields of ACCTDETAILS email not populating

To test:
* Make sure AutoEmailOpacUser is set to "send"
* Create a new patron with a username and password, and an email address
* In Kohadevbox, check the mail (usually you can type "mail" and go down
to the last message) - these do not go into the message queue and they
are processed immediately.
notice that the email does not have
<> <> <>

Apply this patch, restart the things, retest as above.

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22687] Type in Koha::Manual breaks Portuguese links

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22687] Type in Koha::Manual breaks Portuguese links

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #87755|0   |1
is obsolete||

--- Comment #2 from Hayley Mapley  ---
Created attachment 88244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88244=edit
Bug 22687: Typo correction for Portuguese manual link

Signed-off-by: Martin Renvoize 
Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #8 from Liz Rea  ---
let's do a bunch for 10 years. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22408] Subscription entry form cleanup

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Hayley Mapley  ---
Failed QA

Steps taken
- Set Record for New Subscription and clicked Next, clicking Okay to continue
without a Vendor.
- Set Issue publication date, set Frequency 1 week, did not specify
subscription length
- Set subscription start date and end date.
- Created an advanced pattern and named it, then created another advanced
pattern and chose it as the Numbering pattern above
- Clicked test prediction pattern and selected two dates to not publish
randomly
- Clicked Save subscription
- Error!

Error trace:

Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/Koha/Subscription.pm line 165

1.in Koha::Subscription::get_sharable_info at
/home/vagrant/kohaclone/Koha/Subscription.pm line 165

  162: my $sub_numberpatteern =
  163:   Koha::Subscription::Numberpatterns->find(
$subscription->numberpattern );
  164: 
  165: my $sub_mana_info = {
  166: 'title'   => $biblio->title,
  167: 'sfdescription'   => $sub_frequency->description,
  168: 'unit'=> $sub_frequency->unit,

2.   in Koha::SharedContent::prepare_entity_data at
/home/vagrant/kohaclone/Koha/SharedContent.pm line 123

  120: my $ressource_mana_info;
  121: my $packages = "Koha::".ucfirst($ressourcetype)."s";
  122: my $package = "Koha::".ucfirst($ressourcetype);
  123: $ressource_mana_info =
$package->get_sharable_info($ressourceid);
  124: $ressource_mana_info = { %$ressource_mana_info, %$mana_info };
  125: 
  126: return $ressource_mana_info;

3.in Koha::SharedContent::send_entity at
/home/vagrant/kohaclone/Koha/SharedContent.pm line 82

   79: my ($lang, $loggedinuser, $resourceid, $resourcetype, $content)
= @_;
   80: 
   81: unless ( $content ) {
   82: $content = prepare_entity_data($lang, $loggedinuser,
$resourceid, $resourcetype);
   83: }
   84: 
   85: my $result = process_request(build_request('post',
$resourcetype, $content));

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #56 from Hayley Mapley  ---

Test plan:

0) Apply all patches
1) Drop and recreate your database, and restart_all
2) Go through installation and onboarding
3) Note that the order of steps
is:
 1 Create a library
 2 Create a ptron category
 3 Create Koha administrator patron
 4 Create a new item type
 5 Create a new circulation rule
 6 Set minPasswordLength syspref/Complete
4) Repeat steps 1 & 2
5) Note that the order of steps is now:
 1 Create a library
 2 Create a patron category
 3 Set minPasswordLength syspref
 4 Create Koha administrator patron
 5 Create a new item type
 6 Create a new circulation rule/Complete
6) Verify that the minPasswordLength syspref is set to the
value from onboarding
7) Verify that the patron, item type, and circulation rule
made in the onboarding exist in the administration
8) Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Hayley Mapley  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #55 from Hayley Mapley  ---
Created attachment 88243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88243=edit
Bug 18308: Removed extraneous file

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22624] Show OPAC description for authorised values in OPAC

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22624

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 18.05.x for 18.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13629] SingleBranchMode removes both library and availability search from advanced search

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13629

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 18.05.x for 18.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14358] Changing the module refreshes the page and resets library choice

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14358

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 18.05.x for 18.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #54 from Hayley Mapley  ---
Created attachment 88242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88242=edit
Bug 18308: Changed templates to use Asset plugin rather than full path

Test plan:
Same as before

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #86789|0   |1
is obsolete||

--- Comment #3 from Hayley Mapley  ---
Created attachment 88241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88241=edit
Bug 21783: Reindent admin/columns_settings.tt

This patch reindents admin/columns_settings.tt to use four spaces
instead of two for indentation, following coding guidelines.

To test, apply the patch and compare the file to master using the -w
flag to ignore whitespace. The only changes should appear where lines
were added during indentation.

Go to Admin -> Columns settings and confirm that everything works
correctly.

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22732] Redundant search box on admin-home.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732

--- Comment #3 from Christopher Brannon  ---
I guess.  It just drives me nuts to use up screen space to duplicate a
function.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22732] Redundant search box on admin-home.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Thx for filing this Christopher, it's always good to discuss these kinds of
things.

I tend to be biased too, as I end up using it quite often for its better
visiblity. So I think siding with Owen here. Would you be ok with the ID?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22731] ID needed on "Merge selected patrons" button in list.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22731

Katrin Fischer  changed:

   What|Removed |Added

Summary|ID needed on Mege selected  |ID needed on "Merge
   |patrons button in list.pl   |selected patrons" button in
   ||list.pl
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22730] Not possible to set default value for patron attributes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22730

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Ron, can you explain your use case a bit? Maybe we can suggest a work
around.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #26 from Katrin Fischer  ---
The patch description says that Rep is not used, but it's not removed here
either. Is there a way to set it or a plan to bring it back?

Again, setting Failed QA to get attention, reads well :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Can you explain why the 942$s is used here? 
Why not use the LDR pos. 7 = s or check for an existing subscription?
How is 942$s set?

Setting Failed QA to get attention to my questions! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #88234|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 88239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88239=edit
Bug 13795: Make database update idempotent

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Michal Denar  ---
Hi Josef,
one test fails :-(

#   at t/db_dependent/Items/GetItemsForInventory.t line 138.
# Looks like you failed 1 test of 9.
t/db_dependent/Items/GetItemsForInventory.t .. Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/9 subtests

Test Summary Report
---
t/db_dependent/Items/GetItemsForInventory.t (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=9,  2 wallclock secs ( 0.01 usr  0.01 sys +  1.82 cusr  0.22
csys =  2.06 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #88235|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 88240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88240=edit
Bug 13795: Remove occurences of unused columns in code

These patch removes these two columns from backfill_statstics script
and from columns.def - this file is used to create description in guided
reports

Test plan:
1. Run installer/data/mysql/backfull_statistics.pl
--> without this patch, there are associatedborrower and usercode errors
reported
--> with patch, these two columns are not reported

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #88233|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 88238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88238=edit
Bug 13795: Delete unused columns from statistics table

The following 2 fields are never used in the statistics table:

associatedborrower
usercode

This patch removes them.

To test:

* check the database and make sure columns are gone

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

--- Comment #8 from Michal Denar  ---
Created attachment 88237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88237=edit
Bug 16284: Add test

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Michal Denar  changed:

   What|Removed |Added

  Attachment #88050|0   |1
is obsolete||
  Attachment #88051|0   |1
is obsolete||

--- Comment #7 from Michal Denar  ---
Created attachment 88236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88236=edit
Bug 16284: Check only item for previous checkout if biblio is serial

Test plan:
1) Set 'CheckPrevCheckout' system preference to 'Do'
2) Make a checkout with item from serial record (942$s is 1 on default
settings)
3) Return that checkout
4) Try to check it out again, you should see an alert, that the patron
has thi item checked out previously
5) Try to checkout another item from same bibliographic record, you
sholud not see the alert and item should be checked out
6) prove t/db_dependent/Patron/Borrower_PrevCheckout.t

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Michal Denar  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Michal Denar  ---
Hi,
test t/db_dependent/Patron/Borrower_PrevCheckout.t fail just with ES. With
Zebra passed.

Result with ES as engine:
t/db_dependent/Patron/Borrower_PrevCheckout.t .. 38/60 Can't call method
"leader" on an undefined value at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 429.
# Looks like your test exited with 255 just after 55.
t/db_dependent/Patron/Borrower_PrevCheckout.t .. Dubious, test returned 255
(wstat 65280, 0xff00)
Failed 5/60 subtests

So, I geve this back to Need Singed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
Summary|Delete unused columns from  |Delete unused columns from
   |statistics table.   |statistics table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

--- Comment #21 from Martin Renvoize  ---
Resetting to assigned as I've spotted a followup I need to make.

It would seem that accountlines wise we have always marked overdues for lost
items as 'returned'. I think this is misleading and should be replaced with an
'OVERDUE' + 'LOST' combination to show the fines final state as LOST rather
than RETURNED. I don't believe there's any way to retrospectively apply this to
prior records unfortunately.

Followup will come shortly (along with a full test plan.. appologies for not
including one before now)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Michal Denar  changed:

   What|Removed |Added

  Attachment #86809|0   |1
is obsolete||
  Attachment #86810|0   |1
is obsolete||
  Attachment #86811|0   |1
is obsolete||

--- Comment #12 from Michal Denar  ---
Created attachment 88233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88233=edit
Bug 13795: Delete unused columns from statistics table

The following 2 fields are never used in the statistics table:

associatedborrower
usercode

This patch removes them.

To test:

* check the database and make sure columns are gone

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

--- Comment #14 from Michal Denar  ---
Created attachment 88235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88235=edit
Bug 13795: Remove occurences of unused columns in code

These patch removes these two columns from backfill_statstics script
and from columns.def - this file is used to create description in guided
reports

Test plan:
1. Run installer/data/mysql/backfull_statistics.pl
--> without this patch, there are associatedborrower and usercode errors
reported
--> with patch, these two columns are not reported

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

--- Comment #13 from Michal Denar  ---
Created attachment 88234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88234=edit
Bug 13795: Make database update idempotent

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 88232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88232=edit
Bug 16149: Generate and send custom notices based on report output

Ths patch add an EmailReport function to C4::Reports::Guided

It accepts a notice (module, code, branch) and a report and attempts to
email notices to patron, generating content using report content.

Notice must be in template toolkit syntax, only columns in report are
available for notice.

To test:
1 - Specify various options
2 - Ensure errors are returned if options are incomplete or incorrect
3 - Pass a report containing 'from' and 'email' and 'borrowernumber'
columns and ensure message queue populated as expected

Signed-off-by: Jessica Ofsa 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 88231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88231=edit
Bug 16149: Unit tests

To test:
prove -v t/db_dependent/Reports/Guided.t

Signed-off-by: Claire Gravely 

Signed-off-by: Jessica Ofsa 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #85116|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #85117|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #79 from Michal Denar  ---
Hi,
status is still "In Discussion"? Or Need Signed Off?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13481] Don't show circulation and fine rules library selection when there is only one library

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13481

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13481] Don't show circulation and fine rules library selection when there is only one library

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13481

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13481] Don't show circulation and fine rules library selection when there is only one library

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13481

Owen Leonard  changed:

   What|Removed |Added

  Attachment #85445|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22732] Redundant search box on admin-home.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732

Owen Leonard  changed:

   What|Removed |Added

 Depends on||3181

--- Comment #1 from Owen Leonard  ---
I like the visibility of the search box in the body of the page (but I'm
biased...I added it). I would prefer that we give it a unique ID to make it
easy to hide it with custom CSS.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3181
[Bug 3181] Highlight global system preferences and add search box on admin-home
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3181] Highlight global system preferences and add search box on admin-home

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3181

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22732


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732
[Bug 22732] Redundant search box on admin-home.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #34 from Tomás Cohen Arazi  ---
Great work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 88225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88225=edit
Bug 15496: Add API endoint for deleting a bib

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 88229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88229=edit
Bug 15496: (QA follow-up) Change success status on api

DELETE response code must be 204, not 200 according to our API coding
guidelines

Test plan:

prove t/db_dependent/api/v1/biblios.t

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 88230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88230=edit
Bug 15496: (follow-up) Update interaction for deleting records

This patch makes minor changes to markup and JavaScript to alter the
interaction for deleting the record. Now a successful deletion will
convert the dialog to a "message" type dialog and show only the success
message.

To test, apply the patch and test the process of attaching the last item
from a record and deleting that record.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 88228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88228=edit
Bug 15496: (QA Follow up) remove text/javascript

Make the QA tool happy for html5

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 88227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88227=edit
Bug 15496: Delete Bib After Moving Item

Librarians have requested the ability to delete records with no items
quickly and easily from the "Attach item" results page as items are
moved from one record to another.

Test Plan:
1) Apply this patch
2) Create 2 records with 2 items each
3) Move one item from record A to record B
4) You should see no change from pre-patch behavior
5) Move the second item from record A to record B
6) You should now see a "Delete record" button
7) Click the button
8) Note the record in question has been deleted

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 88226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88226=edit
Bug 15496: Tidy code block (Whitespace changes only)

Signed-off-by: Liz Rea 

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88172|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22732] New: Redundant search box on admin-home.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732

Bug ID: 22732
   Summary: Redundant search box on admin-home.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

I suggest we get rid of the Global system preferences box under the Koha
administration label on admin-home.pl.  You can do the same search in the
search box ABOVE the Koha administration label.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88215|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88169|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88170|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88171|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88168|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22731] New: ID needed on Mege selected patrons button in list.pl

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22731

Bug ID: 22731
   Summary: ID needed on Mege selected patrons button in list.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

I'm noticing the Merge patrons button on member.pl has an ID of merge-patrons,
but the button on list.pl does not.  I suggest the list.pl button should have
the same ID.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||m.de.r...@rijksmuseum.nl,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 88224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88224=edit
Bug 22729: Adapt /patrons controller code to the change

This patch makes the controller code aware of the flgAnonymized =>
anonymized change.

To test:
- Run
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 88223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88223=edit
Bug 22729: DBIC update

I add this DBIC update because I didn't manage to add the +anonymize =>
{ is_boolean => 1 } change without the schema updating script to bark
because of the non-existent column...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 88222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88222=edit
Bug 22729: Adapt Koha::Patron(s) and tests

This patch adapts the Koha::Patron(s) code to the column change.
To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

--- Comment #25 from Martin Renvoize  ---
Dependencies now in master and patches freshly rebased here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87866|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 88219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88219=edit
Bug 22564: Remove references to 'Rep' accounttype

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87867|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 88220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88220=edit
Bug 22564: Add database update 'just in case'

With the introduction of the 'status' field it's a clear oportunity to
convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'.

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87868|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 88221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88221=edit
Bug 22564: Add UI handling for 'Replaced'

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22727] Forgiven fines are recreated when lost item that was not marked returned is returned

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22727

--- Comment #1 from Andrew  ---
Agreeing with Nick that the bug here is not that the fine reappears but,
rather, that we don't have a choice about whether or not the fine reappears.
Some libraries very much want this, others very much do not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22730] New: Not possible to set default value for patron attributes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22730

Bug ID: 22730
   Summary: Not possible to set default value for patron
attributes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rh...@ottumwapubliclibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Target Milestone: ---

It would be helpful to be able define default values for patron attributes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030

Andrew  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew  ---
Poking this old bug again. It is currently *possible* to make patron attributes
mandatory by referring to them as patron_attr_1, patron_attr_2, etc, but those
labels are relative to their position when listed on memberentry, so the
numbers change when attributes are added or removed, requiring an adjustment to
BorrowerMandatoryField. This is workable but clunky and requires extra work.

If possible, I'd support the suggestion of marking BorrowerMandatoryField use
the codes for each attribute.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Depends on||21336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336
[Bug 21336] GDPR: Handle unsubscribe requests automatically by optional
(administrative) lock, anonymize and remove
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22729


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729
[Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22729] New: flgAnonymized shouldn't be NULL and should be renamed anonymized

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729

Bug ID: 22729
   Summary: flgAnonymized shouldn't be NULL and should be renamed
anonymized
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

What the title says :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #123 from Tomás Cohen Arazi  ---
Moving the patches that rename the column to a separate bug for proper
discussion in context. Keeping a minor fix on the schema and fixes to the API.

@RM: I tested with and without my updatedatabase.pl patch and the results are
the same. It is just safer, just in case someone backports in the wrong order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #122 from Tomás Cohen Arazi  ---
Created attachment 88218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88218=edit
Bug 21336: Add borrowers.flgAnonymized in an explicit position

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

--- Comment #121 from Tomás Cohen Arazi  ---
Created attachment 88217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88217=edit
Bug 21336: Fix the API

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88199|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #88198|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22728] New: Manual for BorrowerMandatoryField should include note on extended attributes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

Bug ID: 22728
   Summary: Manual for BorrowerMandatoryField should include note
on extended attributes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

In explaining BorrowerMandatoryField, we should include a note on how to denote
extended patron attributes. They can be made mandatory by entering
"patron_attr_1" (or other correct number), but I don't see that documented
anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #9 from Liz Rea  ---
Formatting patch for community guidelines, authorship retained by Kris.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #114 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >