[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- Hi Josef, the duplicate dialog now works as expected, but I have issues loading the checkouts table (datatable errors, endless loading). Also the tabs are broken. Please check! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22751] Switch two-column templates to Bootstrap grid: Patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22751] Switch two-column templates to Bootstrap grid: Patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 Katrin Fischer changed: What|Removed |Added Attachment #88572|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 88594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88594&action=edit Bug 22751: Switch two-column templates to Bootstrap grid: Patron details This patch updates the patron details page template to use the Bootstrap grid. To test, apply the patch and view the detail page for a patron in the staff client. Adjust the browser width and confirm that the page adapts to different sizes. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Katrin Fischer changed: What|Removed |Added Attachment #88569|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 88593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88593&action=edit Bug 21034: Re-indent circulation.tt This patch reindents the template for the checkout page, circulation.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the checkout page under various circumstances: - No card number submitted - Name submitted (patron search results) - Card number submitted - Restricted patron - Patron with circulation messages - On-site checkouts - Check all tabs: checkouts, relatives' checkouts holds, article requests, restrictions, clubs HTML validation before and after the patch should return the same results. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22748] Wrong permission check in addbiblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 --- Comment #4 from Katrin Fischer --- Created attachment 88592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88592&action=edit Bug 22748: Pass userid to haspermission Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22748] Wrong permission check in addbiblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22748] Wrong permission check in addbiblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 --- Comment #3 from Katrin Fischer --- Misses a test plan, but looking at the code the change makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003
Johanna Räisä changed:
What|Removed |Added
Attachment #88262|0 |1
is obsolete||
--- Comment #25 from Johanna Räisä ---
Created attachment 88591
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88591&action=edit
Bug 17003: (follow-up) Update definitions according to voted RFC
Test plan:
1) Have some patrons with checkouts, some renewable and some not
renewable
2) Use your favorite API tester and access GET
http://koha.url/api/v1/checkouts/{checkout_id}/allows_renewal
3) Check the response is OK according to voted RFC:
https://wiki.koha-community.org/wiki/Checkouts_endpoint_RFC#Checkout_renewability_2
4) prove t/db_dependent/api/v1/checkouts.t
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Johanna Raisa
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Johanna Räisä changed: What|Removed |Added Attachment #88261|0 |1 is obsolete|| --- Comment #24 from Johanna Räisä --- Created attachment 88590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88590&action=edit Bug 17003: Adapt to OpenAPI Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Johanna Raisa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Johanna Räisä changed: What|Removed |Added Attachment #88260|0 |1 is obsolete|| CC||johanna.ra...@koha-suomi.fi --- Comment #23 from Johanna Räisä --- Created attachment 88589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88589&action=edit Bug 17003: Add API route to get checkout's renewability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #47 from Chris Cormack --- My apologies Axel, my phone autocorrected your name to Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Thx, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #46 from Chris Cormack --- I think what David meant to say was thank you Alex, for testing and providing your first patch to Koha to fix a broken test. Then gone on with the discussion of technical merits Rest assured we do value your contribution, and we want Koha to be a welcoming place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #45 from Katrin Fischer --- The plugin idea Alex is working on here is not new - see the discussion in the first comments. For added security we could discuss different solutions, like a separate permission for handling authentication plugins maybe? I don't agree with people saying it's too hard to get things in. But I definitely think we should not have this discussion on bugzilla. The dev meeting today would be a better place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #6 from Katrin Fischer --- (In reply to Agnes Rivers-Moore from comment #5) > The 'holds history' function allows staff to see a borrower's cancelled > holds. Tha helps, but is not a complete answer. Still would like the > borrower notification for cancelled due to late pickup. Also would like a > notice with 'cancelled for x reason' options, that staff could choose to > send or not send at the time of cancellation. +1! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #8 from Jonathan Druart --- (In reply to Liz Rea from comment #7) > Maybe we don't need to patch it at all? Maybe, maybe not. D19 is currently failing with the same issue. Something else is behind that issue for sure, but DateTime must not be used directly anyway (to use the correct timezone). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What|Removed |Added Attachment #88587|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 88588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88588&action=edit [<=18.11.x version] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item - Change the collection code value => The "Collection code" column must be filled with the new value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 --- Comment #1 from Jonathan Druart --- Created attachment 88587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88587&action=edit Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Blocks|22669 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22669 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] New: Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Bug ID: 22762 Summary: Collection codes not displayed on receiving Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What|Removed |Added Depends on|21206 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22762 --- Comment #6 from Jonathan Druart --- Comments 1 to 3 addressed on bug 22762. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #5 from Jonathan Druart --- Created attachment 88586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88586&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #4 from Jonathan Druart --- Scratch the last 3 comments, they are for another bug report. It has been introduced by commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file And the one to blame is JavaScript (remember, "0" is evaluated to true) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #3 from Jonathan Druart --- The explosion has highlighted an older problem. Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #2 from Jonathan Druart --- The log says: The method Koha::Item->collection is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||21206 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Blocks||22669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22715 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20891 --- Comment #10 from Jonathan Druart --- See bug 20891 for a similar issue, I think it is the correct fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||18426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 [Bug 18426] Subscriptions batch editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 --- Comment #2 from Jonathan Druart --- Created attachment 88585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88585&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Blocks||22621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 [Bug 22621] Filters on subscription result list search the wrong column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Depends on||17899
--- Comment #1 from Jonathan Druart
---
Bonjour Séverine,
It looks like it is the expected behaviour, from bug 17899 (commit
1104e61635e2d567c89587c28fd9a24b4f262037):
-{ "aTargets": [ 0 ], "bVisible": false, "bSearchable": false },
+{ "aTargets": [ 0 ], "bVisible": false, "bSearchable": true }, //
must be searchable for fnFilter
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899
[Bug 17899] Show only mine does not work in newordersuggestion.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart changed: What|Removed |Added Blocks||22736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart --- (In reply to Maria from comment #31) Hello Maria, Thanks for testing this! > Tried to test. Test plan is divided into pieces and difficult to follow. Yes there is one test plan per patch. The goal is to tell what individual patch does. > When we turned on the new sysprefs (CustomCoverImagesURL etc) the result was > that we got a few images. Noting is displayed if the cover does not exist, which isbn did you try? > The images that were added in result list had a link to the image itself, > not to the OPAC record. IIRC it is the behavior with other cover services. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 --- Comment #4 from Nick Clemens --- Created attachment 88583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88583&action=edit Bug 21181: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21181] Cancel expired holds cronjob does not cancel holds in transit if ExpireReservesMaxPickUpDelay not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21181 Nick Clemens changed: What|Removed |Added Attachment #81049|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 88584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88584&action=edit Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set To test: 0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow' 1 - Place a hold for a patron 2 - Check in at another library to set it in transit 3 - Update expirationdate of hold to be in the past UPDATE reserves SET expirationdate='1999-12-31' 4 - Run cancel_expired_holds.pl 5 - Hold is not canceled 6 - Apply patch 7 - Run again 8 - Hold is cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us --- Comment #3 from Brian --- Any updates on bug 20815? Carnegie team -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow placing holds on staff side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us --- Comment #1 from Brian --- any updates on bug 3153? Carnegie Team -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us --- Comment #5 from Brian --- Any Updates on bug 6508 Carnegie team -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Nick Clemens changed: What|Removed |Added Attachment #80750|0 |1 is obsolete|| Attachment #82654|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 88582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88582&action=edit Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #3 from Agustín Moyano --- I see advanced editor already has this functionality.. Is this intended for basic editor, or is this duplicate of 18417? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #18 from Nick Clemens --- Created attachment 88581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88581&action=edit Bug 21946: (follow-up) Correct dropdown when editing rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #19 from Kyle M Hall --- (In reply to Michal Denar from comment #17) > Hi kyle, > thank you for test plan. > I've found problem. Print button on "red" paymets works well. But on "green" > files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif On further review of your gif, it seems pretty clear that you don't have the slip configured. I think there was an sql error in the old patch set that has been corrected in this new one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #14 from Nick Clemens --- Created attachment 88577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88577&action=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #15 from Nick Clemens --- Created attachment 88578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88578&action=edit Bug 21946: Fix display of parent types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens changed: What|Removed |Added Attachment #87713|0 |1 is obsolete|| Attachment #87714|0 |1 is obsolete|| Attachment #87715|0 |1 is obsolete|| Attachment #87716|0 |1 is obsolete|| Attachment #87717|0 |1 is obsolete|| Attachment #87718|0 |1 is obsolete|| Attachment #87719|0 |1 is obsolete|| Attachment #88392|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 88574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88574&action=edit Bug 21946: Database updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #17 from Nick Clemens --- Created attachment 88580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88580&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #13 from Nick Clemens --- Created attachment 88576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88576&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #16 from Nick Clemens --- Created attachment 88579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88579&action=edit Bug 21946: Use objects for displaying circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #12 from Nick Clemens --- Created attachment 88575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88575&action=edit Bug 21946: SCHEMA UPDATES DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #44 from David Cook --- Just one final note... if this does make it into Koha, it'll be one of the first things I disable when upgrading to a new release. I think plugins are awesome but also dangerous when wielded by people without enough knowledge. (For instance, EBSCO have made an authentication plugin, which was installed by a librarian, and I discovered that it had a number of security vulnerabilities. I've sent in pull requests to patch them, but I never would've installed that plugin without reviewing it first. However, the librarian didn't even think to verify the contents of the plugin.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Kyle M Hall --- (In reply to Michal Denar from comment #17) > Hi kyle, > thank you for test plan. > I've found problem. Print button on "red" paymets works well. But on "green" > files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif I'm completely unable to reproduce this. Can you test this latest version of the patch set? If you are still seeing this can you provide specific steps to reproduce what you are seeing? Thanks! Kyle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #43 from David Cook --- I think we should ask ourselves what we're trying to achieve here. Are we adding authentication plugins via the Staff UI, because it's too difficult to get changes into Koha, especially around authentication? I would love for there to be more authentication methods for Koha. In fact, I wrote a generic OpenID Connect client for Koha, which I support locally. Of course, one of the reasons why I haven't tried to get it into Koha (besides sharing some code at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586 for other people to use) is that I thought I'd never be able to get changes to C4::Auth pushed. Partially because I didn't have enough time/money to dedicate to working on it for the community, and partially because I thought that I didn't have enough influence/power within the community. I know that I've heard grumblings behind closed doors from even prominent community folk about it being too hard to get changes into Koha these days. I wonder if the desire for user-managed authentication plugins is indicative of a larger problem within the Koha community. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #42 from David Cook --- I know things like WordPress have authentication plugins, but WordPress is also the biggest security nightmare on the Internet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #41 from David Cook --- Anyone else think that it's a terrible idea to have authentication plugins that non-technical staff can load into Koha? Sounds like a massive security problem waiting to happen. That said, I'm in favour of authentication "plugins" that administrators can add to the system via system packages or CPAN. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19098] Additional logic for 260/RDA 264 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19098 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #5 from Agnes Rivers-Moore --- The 'holds history' function allows staff to see a borrower's cancelled holds. Tha helps, but is not a complete answer. Still would like the borrower notification for cancelled due to late pickup. Also would like a notice with 'cancelled for x reason' options, that staff could choose to send or not send at the time of cancellation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8126] Funkiness with Patrons w/ Most Checkouts Report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8126 --- Comment #3 from Agnes Rivers-Moore --- This report seems to be working correctly now, at least for my single site library. Bug fixed somewhere along the way without anyone noticing and updating here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22735] Broken MARC and ISBD views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22735 --- Comment #11 from Katrin Fischer --- Thx Marcel and Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22735] Broken MARC and ISBD views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22735 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22735] Broken MARC and ISBD views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22735 Katrin Fischer changed: What|Removed |Added Attachment #88370|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 88573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88573&action=edit Bug 22735: Resolve internal server error on missing item type Trivial fix, similar to opac-detail, applied to ISBD and MARC detail. Test plan: Enable ArticleRequests pref. Make sure you have a biblio with no item type in 942c. (Perhaps you need to make 942c not mandatory temporarily and save a biblio record without this field being filled.) If you are logged in, log out. Go to MARC or ISBD detail page. No crash anymore? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22751] Switch two-column templates to Bootstrap grid: Patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 Lucas Gass changed: What|Removed |Added Attachment #88391|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 88572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88572&action=edit Bug 22751: Switch two-column templates to Bootstrap grid: Patron details This patch updates the patron details page template to use the Bootstrap grid. Nice update, looks good on all screen sizes. Signing off. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22751] Switch two-column templates to Bootstrap grid: Patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Katrin Fischer changed: What|Removed |Added Attachment #88372|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 88570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88570&action=edit Bug 22418: Add magnifying glass to 655 results To test: 1 - Have some 655 fields linked to authorities 2 - Notice they have no magnifyiung glass 3 - Apply patch 4 - Note they have one now Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Katrin Fischer changed: What|Removed |Added Attachment #88373|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 88571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88571&action=edit Bug 22418: (follow-up) OPAC changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #19 from Agustín Moyano ---
(In reply to Josef Moravec from comment #17)
> Comment on attachment 88145 [details] [review]
> Bug 22284: Opac pickup_locations
>
> Review of attachment 88145 [details] [review]:
> -
>
> ::: Koha/Item.pm
> @@ +297,5 @@
> > +
> > +my $branch_control = C4::Context->preference('HomeOrHoldingBranch');
> > +my $library = $branch_control eq 'holdingbranch' ?
> > $self->holding_branch : $self->home_branch;
> > +
> > +#warn $branch_control.' '.$branchitemrule->{holdallowed}.'
> > '.$library->branchcode.' '.$patron->branchcode;
>
> This line should be removed
Hello Josef,
Thanks for taking the Time to test.
Issues where addressed in follow-up.
Regarding comment #13, it was resolved in attachment 88369
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Katrin Fischer changed: What|Removed |Added Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Lucas Gass changed: What|Removed |Added Attachment #88548|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 88569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88569&action=edit Bug 21034: Re-indent circulation.tt This patch reindents the template for the checkout page, circulation.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the checkout page under various circumstances: - No card number submitted - Name submitted (patron search results) - Card number submitted - Restricted patron - Patron with circulation messages - On-site checkouts - Check all tabs: checkouts, relatives' checkouts holds, article requests, restrictions, clubs HTML validation before and after the patch should return the same results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22674] Change wording of payments in the GUI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 --- Comment #9 from Katrin Fischer --- (In reply to Josef Moravec from comment #8) > (In reply to Nick Clemens from comment #6) > > Needs a minor rebase please > > Done Thank you, Josef! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21662] Missing developers from history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #36 from Chris Cormack --- So Andy is kb2qzv Which leads to https://sourceforge.net/u/kb2qzv/wiki/Home/ But I am 99% sure it is actually Benedict https://www.postgresql.org/message-id/2509083006Z72802-9734%2B1003%40priv0.onet.pl Who was doing tons of work on Koha at that time https://lists.gnu.org/archive/html/koha-cvs/2004-04/msg00060.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 --- Comment #7 from Katrin Fischer --- Yes, but we are often not clear in our use of terminology around fines and fees I think. The only one you can remove other fines from is noissuescharge, I think. There are several other preferences relating to it. Most of those prefs are preset on installation. What would be the best a approach to update the list for HEA and get meaningful data? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21662] Missing developers from history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #35 from Chris Cormack --- Natasha was an Academy student who didn't want to use her last name. So can we make that just Natasha. (I do know, who it is but respect their wish for privacy) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21662] Missing developers from history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer --- Some small stuff: - Bugwrangler => Bug wrangler - Maybe add punctuation between versions? - Some of the roles are still not quite right, but were before. Maybe this is not the latest version? :( - Some additional fix to smuggle into history.txt: Rachel Hamilton-Willams of Katipo sends access to the katipo cma to edit the new koha.org site => ... Katipo CMS ... I generally like the more structured display of information :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] Clean up js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21784] Clean up js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Katrin Fischer changed: What|Removed |Added Attachment #88528|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 88568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88568&action=edit Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22679] circulation_rules are not deleted when accompanying issuingrules are deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 Katrin Fischer changed: What|Removed |Added Attachment #88529|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 88567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88567&action=edit Bug 22679: Delete related CirculationRules when Removing IssuingRule Unfortunately, the tables here can't use a foreign key as one table uses null where the other uses '*' This patchset alters the delete method so delete related rules. It is somewhat of a workaround until all the columns in issuingrules are moved to circulation_rules To test: 1 - Add some issuing rules in koha, making sure to set maxissueqty 2 - Check the DB: SELECT * FROM circulation_rules; 3 - note some circulation rules were created 4 - Delete your rules via the staff interface 5 - Check the DB, the circulation rules remain 6 - Apply patch 7 - Repeat 8 - Huzzah! The rules delete! 9 - Prove the tests, read the code Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22679] circulation_rules are not deleted when accompanying issuingrules are deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Katrin Fischer changed: What|Removed |Added Attachment #88540|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 88566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88566&action=edit Bug 22759: Fix wrong check of branch rule in C4::Circulation::TooMany The condition in TooMany applied branch limits only if the rule didn't have a branchcode, this was wrong To test: 1 - Find a title in the catalog, add 8 items, all of a single itemtype, 4 for branch A, four for branch B 2 - Remove any specific circ rules 3 - Set a default circ rule for the itemtype used above, limiting the max issue quantity to 3 4 - Find a patron and checkout the items from branch A 5 - You should be allowed to checkout 3, but the fourth should trigger 'too many' 6 - Now checkout the items from branch B, again you can checkout 3 and not four 7 - Apply this patch 8 - Assuming you have 6 items out now, try one from either branch, you should trigger 'too many' and have 6 9 - Return two from branch B and one from branch A 10 - Now you have three items issued total 11 - An item from either branch should be refused now 12 - Test with different values of 'CircControl' and confirm your expectations are met Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Katrin Fischer changed: What|Removed |Added Attachment #88538|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 88565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88565&action=edit Bug 22759: Unit tests To test: 1 - Apply only this patch 2 - prove -v t/db_dependent/Circulation/TooMany.t 3 - It fails 4 - Apply second path 5 - repeat 6 - All green! Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22225] Tax hints and prices on orderreceive.pl may not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Michal Denar --- Hi kyle, thank you for test plan. I've found problem. Print button on "red" paymets works well. But on "green" files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22744] 'Do not notify' is really a 'Clear' option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- It's a little long. Maybe "Clear preferences" would work too? I think the reason it's not a button is that you still need to save the changes. Maybe a "Clear settings" or "Clear preferences" link like we have on the z39.50 form? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 --- Comment #13 from Michal Denar --- Created attachment 88563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88563&action=edit Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 --- Comment #14 from Michal Denar --- Created attachment 88564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88564&action=edit Bug 21502: Add ItemsDeniedRenewal system preference to check syntax Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Michal Denar changed: What|Removed |Added Attachment #88462|0 |1 is obsolete|| Attachment #88463|0 |1 is obsolete|| Attachment #88464|0 |1 is obsolete|| --- Comment #12 from Michal Denar --- Created attachment 88562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88562&action=edit Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #16 from Claudio --- (In reply to Kyle M Hall from comment #15) > (In reply to Claudio from comment #11) > > Great! It would be nice to be able to customize members/printinvoice.pl too > > (see image attached) > > I'm planning on submitting another patch set on another bug for > printinvoice.pl ;) Thanks Kyle! (in spanish: Respiro aliviado!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #18 from Agustín Moyano --- Created attachment 88561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88561&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
