[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added Attachment #88841|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 88844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88844=edit Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Katrin Fischer --- Going straight to PQA here, thx Hayley! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22035] Improve local cover image browser page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22035] Improve local cover image browser page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Katrin Fischer changed: What|Removed |Added Attachment #88717|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 88843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88843=edit Bug 22035: Improve local cover image browser page This patch makes changes to the way local cover images are handled on the image viewer page in the staff client. From this page you can now delete images or reach the upload images page. The patch also modifies slightly the process for deleting an image from the images tab on the bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. LocalCoverImages and AllowMultipleCovers should be enabled. - Open the detail view for a record which has multiple cover images attached. On the Images tab, click the "Delete image" link for an image. After confirming, the link should change to a spinner icon and image should fade out. - Click one of the cover images to open the image viewer page. The thumbnails should each have a delete link which looks like and behaves like the delete links on the biblio detail page. - Clicking an image thumbnail should load a spinner icon into the area where the full-sized image was, which should be replaced by the image you chose. - There should be a button for uploading images which takes you to the correct page for adding images to that record. - The page title and breadcrumbs should show the title of the record. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Claire Gravely changed: What|Removed |Added Attachment #88789|0 |1 is obsolete|| --- Comment #2 from Claire Gravely --- Created attachment 88842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88842=edit Bug 22772: Menu link hover color incorrect in OPAC language choosers This patch makes a few corrections to OPAC CSS to fix colors in the language menus. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple languages in the OPAC, including more than one language "variation" (fr-FR, fr-CA). - Set the OpacLangSelectorMode preference to "both." - In the OPAC, test the language menu in both the header and footer. When you hover over the sub-menu items the background should be green and the text color white. - Perform the same test in the self checkout and self checkin interfaces. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley changed: What|Removed |Added Attachment #88368|0 |1 is obsolete|| --- Comment #7 from Hayley Mapley --- Created attachment 88841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88841=edit Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #76 from Hayley Mapley --- Created attachment 88840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88840=edit Bug 18308: Removed warns and moved password length warning to template Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88106|0 |1 is obsolete|| --- Comment #85 from Aleisha Amohia --- Created attachment 88835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88835=edit Bug 14715: (QA Follow up) Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88107|0 |1 is obsolete|| --- Comment #86 from Aleisha Amohia --- Created attachment 88836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88836=edit Bug 14715: (QA follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88195|0 |1 is obsolete|| --- Comment #89 from Aleisha Amohia --- Created attachment 88839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88839=edit Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88108|0 |1 is obsolete|| --- Comment #87 from Aleisha Amohia --- Created attachment 88837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88837=edit Bug 14715: (QA follow-up) Edits for ElasticSearch Note added to preferences that the dropdown should not be used with ElasticSearch activated. Dropdowns do not show on search results on staff side or OPAC side if Elasticsearch enabled. Ready to test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88104|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 88833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88833=edit Bug 14715: [QA Follow up] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88109|0 |1 is obsolete|| --- Comment #88 from Aleisha Amohia --- Created attachment 88838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88838=edit Bug 14715: (QA Follow up) More QA tool cleanup Tools are picking up more stuff now, so a few more things to fix! Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88105|0 |1 is obsolete|| --- Comment #84 from Aleisha Amohia --- Created attachment 88834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88834=edit Bug 14715: [QA Follow up] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88102|0 |1 is obsolete|| --- Comment #81 from Aleisha Amohia --- Created attachment 88831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88831=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88103|0 |1 is obsolete|| --- Comment #82 from Aleisha Amohia --- Created attachment 88832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88832=edit Bug 14715: [QA Follow up] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Attachment #87433|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 88830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88830=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Aleisha Amohia --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #84859|0 |1 is obsolete|| --- Comment #24 from Aleisha Amohia --- Created attachment 88829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88829=edit Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #84841|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 88827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88827=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #84842|0 |1 is obsolete|| --- Comment #23 from Aleisha Amohia --- Created attachment 88828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88828=edit Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Hayley Mapley --- (In reply to Jonathan Druart from comment #8) > Created attachment 88660 [details] [review] > Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest > > Almost everywhere we call IsAvailableForItemLevelRequest we already have > a Koha::Patron and Koha::Item object. It makes sense to use them to > avoid a refetch > > Test plan: > It would be good to test this patch on top of 19300 and 19301 and make > sure everything works as expected Sorry Jonathan, still has merge conflicts Applying: Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Reserves.pm M t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t CONFLICT (content): Merge conflict in t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #63 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #55 from Aleisha Amohia --- Created attachment 88826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88826=edit Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 1 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #53 from Aleisha Amohia --- Created attachment 88824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88824=edit Bug 8628: Digital signs - preferences and permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #52 from Aleisha Amohia --- Created attachment 88823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88823=edit Bug 8628: Digital signs - Koha objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #54 from Aleisha Amohia --- Created attachment 88825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88825=edit Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #51 from Aleisha Amohia --- Created attachment 88822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88822=edit Bug 8628: Digital signs - schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #82896|0 |1 is obsolete|| Attachment #82897|0 |1 is obsolete|| Attachment #82898|0 |1 is obsolete|| Attachment #82899|0 |1 is obsolete|| Attachment #82900|0 |1 is obsolete|| Attachment #82901|0 |1 is obsolete|| Attachment #83312|0 |1 is obsolete|| --- Comment #50 from Aleisha Amohia --- Created attachment 88821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88821=edit Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #25 from Jonathan Druart --- Additionally we should json filter all the other TT variables in this template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #26 from Katrin Fischer --- Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #24 from Jonathan Druart --- We need "To" (which must be renamed or adjusted) to correctly json escaped. We do not want to html filter the circulation notes, so it makes sense to remove this filter. The patches look ok to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22629] Maps are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22629 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org Resolution|--- |MOVED --- Comment #1 from Jonathan Druart --- Reported on gitlab: https://gitlab.com/koha-community/hea-app/issues/5 Merge request done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #23 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > (In reply to Katrin Fischer from comment #19) > > I think the $raw would have no other effect than showing we want HTML there. > > We are not really filtering.. we are adding and removing whitespace. Not > > sure what $To all does. Need another opinion, maybe Jonathan? > > Hi Katrin, see bug 20891 comment 5: > """ > If this patch works we will need to rethink the 'To' TT plugin. > It was originally designed to have several escape methods, but with > these changes it will not make sense to name it 'To' if used only to > escape JSON > """ Sorry Jonathan, but that doesn't help me :) What filters should be used here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #22 from Agustín Moyano --- (In reply to Agustín Moyano from comment #21) > Hello Alex, awesome job!, it works great.. > > Just a little question.. > > I noticed that disabled plugins have the "run plugin" button enabled, and > when you click on it works.. > > shouldn't that button be disabled if you disable the entire plugin?.. or > this bug is intended only for hookup functions? s/"run plugin" button/"run tool" option/g :P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #21 from Agustín Moyano --- Hello Alex, awesome job!, it works great.. Just a little question.. I noticed that disabled plugins have the "run plugin" button enabled, and when you click on it works.. shouldn't that button be disabled if you disable the entire plugin?.. or this bug is intended only for hookup functions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #19 from Agustín Moyano --- Created attachment 88819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88819=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #20 from Agustín Moyano --- Created attachment 88820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88820=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #18 from Agustín Moyano --- Created attachment 88818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88818=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 --- Comment #33 from Jonathan Druart --- (In reply to Katrin Fischer from comment #32) > Should we close the bug? Or mark as dependency? I would mark as fixed once done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #32 from Agustín Moyano ---
(In reply to Liz Rea from comment #31)
> Hi Agustin,
>
> I seem to be getting test failures like these on these current patches, have
> a look please?
>
> Functionally, the dev seems to be working up to this point of testing, so
> don't stress too much about that. :)
>
> Cheers,
> Liz
>
> (In reply to Josef Moravec from comment #16)
> > Hi Augustín,
> > I started to testing, overall it is looking good, I will continue on that,
> > but just found some issues, which should be addressed:
> >
> > prove t/db_dependent/Reserves.t
> >
> > # Failed test 'CheckReserves Test 1'
> > # at t/db_dependent/Reserves.t line 132.
> > # got: ''
> > # expected: 'Reserved'
> >
> > # Failed test 'CheckReserves() include reserve_id in its response'
> > # at t/db_dependent/Reserves.t line 134.
> >
> > # Failed test 'CheckReserves Test 2'
> > # at t/db_dependent/Reserves.t line 137.
> > # got: ''
> > # expected: 'Reserved'
> >
> > # Failed test 'CheckReserves Test 3'
> > # at t/db_dependent/Reserves.t line 140.
> > # got: ''
> > # expected: 'Reserved'
> > t/db_dependent/Reserves.t 59/60 # Looks like you failed
> > 4 tests of 60.
> > t/db_dependent/Reserves.t Dubious, test returned 4
> > (wstat 1024, 0x400)
> > Failed 4/60 subtests
> >
> >
> > prove t/db_dependent/Holds.t
> > # Failed test '$branch_1 patron allowed to reserve $branch_2 item with
> > IndependentBranches OFF (bug 2394)'
> > # at t/db_dependent/Holds.t line 270.
> >
> > # Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with
> > IndependentBranches ON ... (bug 2394)'
> > # at t/db_dependent/Holds.t line 278.
> >
> > # Failed test '... unless canreservefromotherbranches is ON (bug 2394)'
> > # at t/db_dependent/Holds.t line 285.
> > t/db_dependent/Holds.t .. 41/60
> > # Failed test 'Hold can be trapped for damaged item with
> > AllowHoldsOnDamagedItems enabled'
> > # at t/db_dependent/Holds.t line 309.
> > t/db_dependent/Holds.t .. 53/60
> > # Failed test 'Patron can reserve item with hold limit of 1, no holds
> > placed'
> > # at t/db_dependent/Holds.t line 594.
> > # Structures begin differing at:
> > # $got->{status} = 'branchNotInHoldGroup'
> > # $expected->{status} = 'OK'
> >
> > # Failed test 'Patron can reserve item with 2 reserves daily cap'
> > # at t/db_dependent/Holds.t line 611.
> > # Structures begin differing at:
> > # $got->{status} = 'branchNotInHoldGroup'
> > # $expected->{status} = 'OK'
> >
> > # Failed test 'Patron can reserve item with 2 bib level hold placed on
> > different days, 2 reserves daily cap'
> > # at t/db_dependent/Holds.t line 630.
> > # Structures begin differing at:
> > # $got->{status} = 'branchNotInHoldGroup'
> > # $expected->{status} = 'OK'
> >
> > # Failed test 'Patron can reserve if holds_per_day is undef (i.e.
> > undef is unlimited daily cap)'
> > # at t/db_dependent/Holds.t line 649.
> > # Structures begin differing at:
> > # $got->{status} = 'branchNotInHoldGroup'
> > # $expected->{status} = 'OK'
> >
> > # Failed test 'Patron can reserve if holds_per_day is undef (i.e.
> > undef is unlimited daily cap)'
> > # at t/db_dependent/Holds.t line 656.
> > # Structures begin differing at:
> > # $got->{status} = 'branchNotInHoldGroup'
> > # $expected->{status} = 'OK'
> > # Looks like you failed 5 tests of 10.
> > t/db_dependent/Holds.t .. 58/60
> > # Failed test 'CanItemBeReserved / holds_per_day tests'
> > # at t/db_dependent/Holds.t line 676.
> > t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60.
> > t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500)
> > Failed 5/60 subtests
> >
> > The tests needs to reflect changes in C4::Reserves.
> >
> > The Comment 13 is not reflected yet.
Hello Liz, thanks for testing.. It's weird.. I've tested it and it passes.
I changed chekcout rules before testing, and get no errors (that's the only
thing I can think of that may affect those tests).. could you please tell me
what was your rules configuration before testing?
Thanks
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Reserves.t
t/db_dependent/Reserves.t .. ok
All tests successful.
Files=1, Tests=60, 9 wallclock secs ( 0.02 usr 0.01 sys + 2.81 cusr 0.39
csys = 3.23 CPU)
Result: PASS
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. ok
All tests successful.
Files=1, Tests=61, 11 wallclock secs ( 0.02 usr 0.01 sys + 3.09 cusr 0.68
csys = 3.80 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #22 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > I think the $raw would have no other effect than showing we want HTML there. > We are not really filtering.. we are adding and removing whitespace. Not > sure what $To all does. Need another opinion, maybe Jonathan? Hi Katrin, see bug 20891 comment 5: """ If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON """ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
Liz Rea changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #31 from Liz Rea ---
Hi Agustin,
I seem to be getting test failures like these on these current patches, have a
look please?
Functionally, the dev seems to be working up to this point of testing, so don't
stress too much about that. :)
Cheers,
Liz
(In reply to Josef Moravec from comment #16)
> Hi Augustín,
> I started to testing, overall it is looking good, I will continue on that,
> but just found some issues, which should be addressed:
>
> prove t/db_dependent/Reserves.t
>
> # Failed test 'CheckReserves Test 1'
> # at t/db_dependent/Reserves.t line 132.
> # got: ''
> # expected: 'Reserved'
>
> # Failed test 'CheckReserves() include reserve_id in its response'
> # at t/db_dependent/Reserves.t line 134.
>
> # Failed test 'CheckReserves Test 2'
> # at t/db_dependent/Reserves.t line 137.
> # got: ''
> # expected: 'Reserved'
>
> # Failed test 'CheckReserves Test 3'
> # at t/db_dependent/Reserves.t line 140.
> # got: ''
> # expected: 'Reserved'
> t/db_dependent/Reserves.t 59/60 # Looks like you failed
> 4 tests of 60.
> t/db_dependent/Reserves.t Dubious, test returned 4
> (wstat 1024, 0x400)
> Failed 4/60 subtests
>
>
> prove t/db_dependent/Holds.t
> # Failed test '$branch_1 patron allowed to reserve $branch_2 item with
> IndependentBranches OFF (bug 2394)'
> # at t/db_dependent/Holds.t line 270.
>
> # Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with
> IndependentBranches ON ... (bug 2394)'
> # at t/db_dependent/Holds.t line 278.
>
> # Failed test '... unless canreservefromotherbranches is ON (bug 2394)'
> # at t/db_dependent/Holds.t line 285.
> t/db_dependent/Holds.t .. 41/60
> # Failed test 'Hold can be trapped for damaged item with
> AllowHoldsOnDamagedItems enabled'
> # at t/db_dependent/Holds.t line 309.
> t/db_dependent/Holds.t .. 53/60
> # Failed test 'Patron can reserve item with hold limit of 1, no holds
> placed'
> # at t/db_dependent/Holds.t line 594.
> # Structures begin differing at:
> # $got->{status} = 'branchNotInHoldGroup'
> # $expected->{status} = 'OK'
>
> # Failed test 'Patron can reserve item with 2 reserves daily cap'
> # at t/db_dependent/Holds.t line 611.
> # Structures begin differing at:
> # $got->{status} = 'branchNotInHoldGroup'
> # $expected->{status} = 'OK'
>
> # Failed test 'Patron can reserve item with 2 bib level hold placed on
> different days, 2 reserves daily cap'
> # at t/db_dependent/Holds.t line 630.
> # Structures begin differing at:
> # $got->{status} = 'branchNotInHoldGroup'
> # $expected->{status} = 'OK'
>
> # Failed test 'Patron can reserve if holds_per_day is undef (i.e.
> undef is unlimited daily cap)'
> # at t/db_dependent/Holds.t line 649.
> # Structures begin differing at:
> # $got->{status} = 'branchNotInHoldGroup'
> # $expected->{status} = 'OK'
>
> # Failed test 'Patron can reserve if holds_per_day is undef (i.e.
> undef is unlimited daily cap)'
> # at t/db_dependent/Holds.t line 656.
> # Structures begin differing at:
> # $got->{status} = 'branchNotInHoldGroup'
> # $expected->{status} = 'OK'
> # Looks like you failed 5 tests of 10.
> t/db_dependent/Holds.t .. 58/60
> # Failed test 'CanItemBeReserved / holds_per_day tests'
> # at t/db_dependent/Holds.t line 676.
> t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60.
> t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500)
> Failed 5/60 subtests
>
> The tests needs to reflect changes in C4::Reserves.
>
> The Comment 13 is not reflected yet.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22779] Simplify serials form to single page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com ||, bwsdo...@gmail.com, ||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22779] Simplify serials form to single page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 --- Comment #1 from Nick Clemens --- Created attachment 88817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88817=edit Bug 22779: WIP POC combining the page and making the prediction automatic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22779] New: Simplify serials form to single page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Bug ID: 22779 Summary: Simplify serials form to single page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Target Milestone: --- Right now this is a 2 column, 2 step page, I think this can all be done on a single page. Additionally we use alerts instead of modals, we prevent submission when a vendor is not entered, even though it is not required, and we force the user to click a button to predict the serial. I think we can greatly simplify this form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #3 from Claudio --- Thers's no Koha logs' useful information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Claudio changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 --- Comment #1 from Kyle M Hall --- Created attachment 88816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88816=edit Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #1 from Claudio --- Created attachment 88815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88815=edit OpenID connect internal server error Google OpenID Connect sysprefs configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #2 from Claudio --- No error with existing patrons. This occurs when patrons are created automatically, i.e., when GoogleOpenIDConnectAutoRegister is set to "Allow". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] New: Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Bug ID: 22778 Summary: Suggestions with no "suggester" can cause errors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedb.y -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22777] New: Google OpenId Connect Internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Bug ID: 22777 Summary: Google OpenId Connect Internal server error Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: cost...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Target Milestone: --- Internal Server Error when trying to login with Google OpenID Connection. See file attached please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #85873|0 |1 is obsolete|| --- Comment #43 from Nick Clemens --- Created attachment 88812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88812=edit Bug 17168: (follow-up) Address QA concerns and update for strict mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #45 from Nick Clemens --- Created attachment 88814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88814=edit Bug 17168: Remove j2a.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #85870|0 |1 is obsolete|| --- Comment #40 from Nick Clemens --- Created attachment 88809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88809=edit Bug 17168: Add a command line script for updating patron category based on status This patch adds a new script update_patrons_category.pl which allows for updating patron categories in a batch upon meeting provided criteria. This script additionally can replace j2a.pl. To test: 1 - perl update_patrons_category.pl -h 2 - Ensure help text makes sense and covers all options 3 - Test converting patrons supplying only fromcat and tocat perl update_patrons_category.pl -f PT -t J -v --confirm perl update_patrons_category.pl -f J -t PT -v --confirm 4 - All patrons should have been switched to and from Juveniles 5 - Try without --confirm switch perl update_patrons_category.pl -f PT -t J -v 6 - Should list all patrons but not update 7 - Set the age for juvenile patrons to be outside the range provided in categories (or set the upper age limit for juveniles to '2') 8 - Test with verbosity and with without --confirm perl update_patrons_category.pl -f J -a -t PT -v perl update_patrons_category.pl -f J -a -t PT -v --confirm 9 - Repeat above and verify linked/unlinked guarantors are removed in above scenario 10 - Test various fine and registration limits 11 - Test matching on specific fields i.e. --field surname=acosta 12 - Sign off Sponsored by: Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #44 from Nick Clemens --- Created attachment 88813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88813=edit Bug 17168: Add Koha:Script -cron, remove Dumper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #85872|0 |1 is obsolete|| --- Comment #42 from Nick Clemens --- Created attachment 88811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88811=edit Bug 17168: (follow-up) Clean up QA errors Cleanup variable names Remove Dumper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #85871|0 |1 is obsolete|| --- Comment #41 from Nick Clemens --- Created attachment 88810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88810=edit Bug 17168: (follow-up) Tidy, clean params/options, use date tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar changed: What|Removed |Added Attachment #88777|0 |1 is obsolete|| Attachment #88778|0 |1 is obsolete|| --- Comment #15 from Michal Denar --- Created attachment 88807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88807=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #16 from Michal Denar --- Created attachment 88808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88808=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What|Removed |Added Attachment #88804|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 88806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88806=edit Bug 22715: Remove extraneous html filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What|Removed |Added Attachment #88786|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 88805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88805=edit Bug 22715: Searching for patrons with "" in the circulation note hangs patron search To replicate: Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string" Go to the patron search, search for a set of results that would include the patron with the quotes in the note Enjoy looking at "Processing" for forever. Test Plan: 1) Apply this patch 2) Attempt to replicate using the steps above Signed-off-by: Liz Rea I took this a step further and used "something in quotes" for my test note and this worked just fine. YAY. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #19 from Katrin Fischer --- I think the $raw would have no other effect than showing we want HTML there. We are not really filtering.. we are adding and removing whitespace. Not sure what $To all does. Need another opinion, maybe Jonathan? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #18 from Nick Clemens --- (In reply to Katrin Fischer from comment #17) > I don't think that html_line_break does any escapign beyond changing the new > lines. I think actually there should be a $raw as we just allowed to add > HTML to that field. I don't think we need a raw since we are filtering in other ways, I think we do want the link breaks, so this works as expected, no? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #17 from Katrin Fischer --- (In reply to Nick Clemens from comment #16) > (In reply to Katrin Fischer from comment #13) > > I am in doubt about the filters used here: > > > > "[% data.borrowernotes | html_line_break | collapse | html | $To %]" > > I think we just need one html filter - the link break should take care of > filtering: > [% data.borrowernotes | html_line_break | collapse | $To %] > > Alternately: > If we don't want to process any of the html here but add line breaks: > [% data.borrowernotes | html | html_line_break | collapse | $To %] > > I suspect we do expect 'bold' etc to be processed though, I imagine some > libraries could have links here I don't think that html_line_break does any escapign beyond changing the new lines. I think actually there should be a $raw as we just allowed to add HTML to that field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #16 from Nick Clemens --- (In reply to Katrin Fischer from comment #13) > I am in doubt about the filters used here: > > "[% data.borrowernotes | html_line_break | collapse | html | $To %]" I think we just need one html filter - the link break should take care of filtering: [% data.borrowernotes | html_line_break | collapse | $To %] Alternately: If we don't want to process any of the html here but add line breaks: [% data.borrowernotes | html | html_line_break | collapse | $To %] I suspect we do expect 'bold' etc to be processed though, I imagine some libraries could have links here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #15 from Nick Clemens --- Created attachment 88804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88804=edit Bug 22715: Remove extraneous html filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22776] Remove 5 periods on tools-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22776 --- Comment #1 from Nick Clemens --- Created attachment 88803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88803=edit Bug 22776: Remove some periods for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Ok... actually it's me: I was testing without the patch applied. It did work. But now with the patch, I have: TEst das Hier\ Instead of the correct display. Without the patch (just master), I get: TEst (in bold) das Hier\ Help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #13 from Katrin Fischer --- I am in doubt about the filters used here: "[% data.borrowernotes | html_line_break | collapse | html | $To %]" html_line_break = turns line breaks into OK collapse = removes additional whitespace - OK html = escapes... so it shoudl escape the tags $To = ? We had other cases where we needed to switch to html html_line_break to make things work. Can someone help me out here an explain? That said it DOES work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22776] New: Remove 5 periods on tools-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22776 Bug ID: 22776 Summary: Remove 5 periods on tools-home.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- On the Tools homepage, we're inconsistent about whether or not we put periods at the end of tool descriptions. The following tools have periods: - Patron lists - Patron clubs (has two periods) - Comments - Stage MARC records for import We should remove these periods for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #30 from Agustín Moyano --- (In reply to Agustín Moyano from comment #29) > Created attachment 88802 [details] [review] > Bug 22284: (follow-up) fix test count after merge Bad bug title.. wasn't merge.. was rebase Sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88561|0 |1 is obsolete|| --- Comment #28 from Agustín Moyano --- Created attachment 88801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88801=edit Bug 22284: (follow-up) Remove commented warn and address test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #29 from Agustín Moyano --- Created attachment 88802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88802=edit Bug 22284: (follow-up) fix test count after merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
Agustín Moyano changed:
What|Removed |Added
Attachment #88369|0 |1
is obsolete||
--- Comment #27 from Agustín Moyano ---
Created attachment 88800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88800=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88145|0 |1 is obsolete|| --- Comment #26 from Agustín Moyano --- Created attachment 88799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88799=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88144|0 |1 is obsolete|| --- Comment #25 from Agustín Moyano --- Created attachment 88798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88798=edit Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 6 SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column 9) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88143|0 |1 is obsolete|| --- Comment #24 from Agustín Moyano --- Created attachment 88797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88797=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88140|0 |1 is obsolete|| --- Comment #22 from Agustín Moyano --- Created attachment 88795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88795=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88139|0 |1 is obsolete|| --- Comment #21 from Agustín Moyano --- Created attachment 88794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88794=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88138|0 |1 is obsolete|| --- Comment #20 from Agustín Moyano --- Created attachment 88793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88793=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #88142|0 |1 is obsolete|| --- Comment #23 from Agustín Moyano --- Created attachment 88796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88796=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 --- Comment #1 from Nick Clemens --- Created attachment 88792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88792=edit Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258
--- Comment #16 from Alex Arnaud ---
All is working here and i don't have any QA warning.
But i have concerns about Bug 20589. This last disable searching on _all and
could make this one useless. Am i right ?
if (yes) {
Ere, David: Is there something planned to build these 2 bugs together ?
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22775] New: It would be nice to be able to get to 'add to basket' directly from Tools > Manage staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22775 Bug ID: 22775 Summary: It would be nice to be able to get to 'add to basket' directly from Tools > Manage staged MARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- One can add to a basket via acquisitions > vendors > basket > add to basket and then selecting 'from staged file'. It would be nice to be able to go in the opposite direction too.. having a button on the 'Manage staged MARC files' screen table to be able to select a basket to add your items to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
