[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #14 from Claudio  ---
In the second customer plugin directoy is empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #13 from Claudio  ---
Created attachment 88975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88975=edit
EDS

Jonathan, look at the file attached. There's an EDS directory in koha/plugins
since 2016! But Koha backoffice says that there's no EDS plugin installed.

I do not know what to do. How can I uninstall EDS? Simply delete it? Probably
it was for a test, but do not need it now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #12 from Jonathan Druart  
---
The error you got before was about the EDS plugin, you may have installed it at
some point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #11 from Claudio  ---
Plack-error.log in other customer:

Use of uninitialized value in string ne at
/usr/share/koha/opac/cgi-bin/opac/svc/auth/googleopenidconnect line 102.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #10 from Claudio  ---
It fails, same error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22720] Including branchcode in PatronSelfModificationBorrowerUnwantedField causes internal server error on self registration page

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22720

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
Hi Barton, why do you suggest? Which library to you pick if there is more than
one?

A workaround could be to hide it with JS.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22717] google oauth auto registration error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Depends on||20287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #9 from Jonathan Druart  
---
Could you test the patch I have added on bug 22717?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22717


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717
[Bug 22717] google oauth auto registration error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22717] google oauth auto registration error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22717] google oauth auto registration error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

--- Comment #2 from Jonathan Druart  
---
Created attachment 88974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88974=edit
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration

Silly bug caused by:
  commit ef410fd62f279a10687636a4f26babb2c91ecadc
  Bug 20287: Replace occurrences of AddMember with
Koha::Patron->new->store->borrowernumber

Constructors take a hashref!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22717] google oauth auto registration error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

--- Comment #1 from Jonathan Druart  
---
Hi Maya, which exact version of Koha are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #8 from Claudio  ---
No Jonathan, I do not use EDS plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22717] google oauth auto registration error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22777

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22717

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #7 from Jonathan Druart  
---
Do you use the EDS plugin?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22552] Adding users to serials routing search requires edit_borrowers permission

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Just asking but, does it really appear in a real life condition?

How could we fix that?
Considering it a config issue? Add a new "search patrons" permissions (and so
hide the "Add recipients" link in this case)? Hide the link if logged in patron
does not have edit_borrowers?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

--- Comment #6 from Claudio  ---
Jonathan, hope this helps:


/var/log/koha/INSTANCE/plack-error,log


Can't locate Koha/Plugin/EDS in @INC (@INC contains: /usr/share/koha/lib
/usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86$
Attempt to reload Koha/Plugin/EDS.pm aborted.
Compilation failed in require at /usr/share/perl/5.20/Module/Load.pm line 77.
Can't locate Koha/Plugin/EDS in @INC (@INC contains: /usr/share/koha/lib
/usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86$

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22484

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22484] /svc/members/search has no tests

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22781

--- Comment #1 from Jonathan Druart  
---
There is none indeed. What would you want to test?
I think we should provide along with bug 22781.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Hello Claudio,
If there is a 500 error you might have an error in the log.
It would help a lot to have it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

Claudio  changed:

   What|Removed |Added

 CC||cost...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

--- Comment #7 from Jonathan Druart  
---
Sending to NSO with your patch then ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22766

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22420] Tag cloud feature broken

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #85748|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22420

--- Comment #4 from Jonathan Druart  
---
Note that Tomas's patch from bug 22420 might fix this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22766


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766
[Bug 22766] Tags cloud link in OPAC does not work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14385
   Assignee|oleon...@myacpl.org |mtomp...@hotmail.com
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Caused by bug 14385.

Mark, could you take a look?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower
categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20116] Cache language list

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

--- Comment #26 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #25)
> +my @enabled_languages =
> +  ( $interface && $interface eq 'intranet' )
> +  ? split ",", C4::Context->preference('language')
> +  : split ",", C4::Context->preference('opaclanguage');
> 
> Seems to reverse the previous logic. If eq opac then opac else intranet.

I do not think I get that one, please read again the whole diff:

before:
if $interface == opac:
  use opaclanguages
elsif $interface == intranet:
  use language
else:
  use opaclanguages

after:
if $interface == intranet:
  use language
else:
  use opaclanguages

Looks equal for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22782] Schema change for SocialData

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782

--- Comment #3 from Jonathan Druart  
---
Also note that "show create table" will display the NOT NULL constraint:

  `isbn` varchar(30) COLLATE utf8mb4_unicode_ci NOT NULL,

It looks safe to commit, and better to fix the kohastructure.sql as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22782] Schema change for SocialData

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782

--- Comment #2 from Jonathan Druart  
---
My bet would be a change in DBIx::Class::Schema::Loader, however I did not find
it.

social_data.isbn is a varchar and used as PK, so cannot be NULL, I guess that's
why it has a default ''.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22096] Missing default values in 'social_data' table

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22096

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 22782 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22782] Schema change for SocialData

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782

--- Comment #1 from Jonathan Druart  
---
*** Bug 22096 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com
  Attachment #88973|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042

--- Comment #4 from Marie-Luce Laflamme  ---
Created attachment 88973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88973=edit
Bug 21042: Make 'pay amount' also return lost fines

To test:
1 - Checkout an item to a patron, and make it lost ( but not returned)
and ensure fine is levied against the account
2 - Add some other fines to their account
3 - Click 'Pay amount' and pay everything they owe
4 - Note the book is not returned
5 - Repeat with 'Pay selected' and note item is returned
6 - Apply patch
7 - Repeat 1-5 and note item is returned in both cases

https://bugs.koha-community.org/show_bug.cgi?id=21014
Signed-off-by: marieluce 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com
  Attachment #88970|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

Marie-Luce Laflamme  changed:

   What|Removed |Added

  Attachment #88972|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

Marie-Luce Laflamme  changed:

   What|Removed |Added

  Attachment #88971|0   |1
is obsolete||

--- Comment #6 from Marie-Luce Laflamme  ---
Created attachment 88972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88972=edit
toto

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

--- Comment #5 from Marie-Luce Laflamme  ---
Created attachment 88971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88971=edit
toto

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

--- Comment #4 from Marie-Luce Laflamme  ---
Created attachment 88970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88970=edit
Bug 21042: Make 'pay amount' also return lost fines

To test:
1 - Checkout an item to a patron, and make it lost ( but not returned)
and ensure fine is levied against the account
2 - Add some other fines to their account
3 - Click 'Pay amount' and pay everything they owe
4 - Note the book is not returned
5 - Repeat with 'Pay selected' and note item is returned
6 - Apply patch
7 - Repeat 1-5 and note item is returned in both cases

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Charles Farmer  changed:

   What|Removed |Added

  Attachment #77756|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21036] Fix a bunch of older warnings

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #78456|0   |1
is obsolete||

--- Comment #13 from Bouzid Fergani  ---
Created attachment 88969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88969=edit
Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm

Like this one (16.11 line number):
Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070.

We need to add a scalar to some MARC::Field::subfield calls. In list context
an empty list returned affects the hash built around it.

Test plan:
Could reproduce this warning easily from OPAC authority search.
opac-authorities-home.pl calling BuildSummary.

Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791

--- Comment #1 from Nick Clemens  ---
Created attachment 88968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88968=edit
Bug 22791: Unify calculation between aqui-home and ordered.pl

To test:
1 - Enable order price rounding
2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax.
3 - Check ordered page - 94.17 is total
4 - Check aqui-home - 94.16 is total
5 - Apply patch
6 - Verify numbers now match

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791
[Bug 22791] Calculation differs on aqui-home/spent and ordered.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22791] New: Calculation differs on aqui-home/spent and ordered.pl

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791

Bug ID: 22791
   Summary: Calculation differs on aqui-home/spent and ordered.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Order an example with 8 * 16,99 and 42% discount, 19.45% tax.

Ordered.pl is doing: get_rounded_price( quantity * price )

Other pages are: quantity * get_rounded_price( price )

The second is more correct I believe

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791

Nick Clemens  changed:

   What|Removed |Added

 Depends on||18736
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736
[Bug 18736] Problems in order calculations (rounding errors)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21533] Do not allow password recovery for administrative locked patrons (see 21336)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #88904|0   |1
is obsolete||

--- Comment #3 from Bouzid Fergani  ---
Created attachment 88967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88967=edit
Bug 21533: Do not allow password recovery for administrative locked patrons

Depends on bug 21336 for the ADMINISTRATIVE_LOCKOUT constant.

This is a bit lazy solution (but good enough): The account will not be found
when recovering the password. The user should contact the library. Since
the library chose to lock the account, that seems appropriate.

Test plan:
Select a borrower and set login_attempts to -1. Via mysql command line or
with Koha::Patrons->find(borrowernumber)->lock.
Enable password recovery.
Try to recover password from OPAC. You should fail with 'Not found, contact
the library'.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 
Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790

Andreas Jonsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790

--- Comment #2 from Andreas Jonsson  ---
Testplan for kohadevbox:

1. Set syspref itemBarcodeInputFilter to "Remove spaces from"
2. Disable syspref RequireStrongPassword
3. Add a bibliographic record
4. Add an item with barcode '12' 
5. Add a borrower with cardnumber 2 and password aaa
6  Add a borrower with username term1 and password term1 and grant circulate
permissions
7. Confirm that this input match the item added in step 2.
8. Login to server via ssh and run 'sudo koha-sip-enable kohadev && sudo
koha-start-sip kohadev'
9. Try checking out an item using sip: /usr/share/koha/bin/sip_cli_emulator.pl
--sip_user=term1 --sip_pass=term1 --patron=2 --password=aaa --item='1 2' -m
checkout -a 127.0.0.1 -p 6001 -l MAIN
10. Without patch, the sip response  will be 'Invalid item'
11. With patch, the  sip response will be 'Item cannot be issued: TOO_MANY' (or
any other response indicating that the item was at least found)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790

--- Comment #1 from Andreas Jonsson  ---
Created attachment 88966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88966=edit
Bug 22790: The system preference itemBarcodeInputFilter is not applied for
barcodes inputed via SIP2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22790] New: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790

Bug ID: 22790
   Summary: The system preference itemBarcodeInputFilter is not
applied for barcodes inputed via SIP2
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andreas.jons...@kreablo.se
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

I would expect the filter specified by the system preference
itemBarcodeInputFilter to be applied to any item barcode inputed to the system.
 As equipment connected via SIP2 is used to input item barcodes, the filter
should be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] New: Establish Non-Priority Holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Bug ID: 22789
   Summary: Establish Non-Priority Holds
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

This development would allow holds to be placed so the hold wouldn't prevent
the current checkout from renewing the hold. 

The goal is a better customer service because certain library departments will
place holds to repair or replace a book when it is returned to the library (the
internal library need has no rush), they only want the catch the book on it's
return.  The library needs to allow the patron who has it out have the
flexibility to renew it on their account without a staff override.

This functionality would be specific to the staffside only. 
- Add a Checkbox on the hold form that stipulates that the hold being placed is
a 'non-priority' hold. 
- Add a field in the reserves tables to flag the hold as 'non-priority'. 
- The checkreserves module in Koha checks for this flag. If found, the hold
request is 'ignored' and item can be renewed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

--- Comment #6 from Michal Denar  ---
Hi Ere,
I'm not sure why, but search with range don't work for me. Test passed. If I
try 1989-2001 I get "No results match your search  with limit(s):
'copydate:1989-2001'. "

I chcecked all twoce but same results.


Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #54 from Agustín Moyano  ---
Created attachment 88962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88962=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library

This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )

To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #55 from Agustín Moyano  ---
Created attachment 88963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88963=edit
Bug 22284: (follow-up) Remove commented warn and address test failures

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #47 from Agustín Moyano  ---
Created attachment 88955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88955=edit
Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option

In order to add groups for holds, this patch provides a new column in
library_groups to identify them. Also provides new enum option for
hold_fulfillment_policy column of default_branch_circ_rules,
default_circ_rules, default_branch_item_rules and branch_item_rules.

To test:
1) check that there is no ft_local_hold_group column in library_groups
and that there are no 'holdgroup' enum option in hold_fulfillment_policy
in default_branch_circ_rules, default_circ_rules, default_branch_item_rules
and branch_item_rules
2) apply this patch
3) run perl installer/data/mysql/updatedatabase.pl
SUCCESS => !(step 1) ;-D
4) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #56 from Agustín Moyano  ---
Created attachment 88964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88964=edit
Bug 22284: (follow-up) fix test count after merge

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #57 from Agustín Moyano  ---
Created attachment 88965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88965=edit
Bug 22284: (follow-up) fixes after 15496

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #51 from Agustín Moyano  ---
Created attachment 88959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88959=edit
Bug 22284: Control hold groups in C4::Reserves

This patch modifies C4::Reserves to control when hold group options where
selected
in smart rules.
In CanItemBeReserved adds 2 new error status messages
1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group
2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold
group
Also CheckReserves is modified when item's priority is defined, to control by
hold
group when required.
Finally, IsAvailableForItemLevelRequest was also modified to control by hold
group when
required.

To test:
1) Apply this patch
2) prove t/db_dependent/Holds.t
SUCCESS => Result: PASS
3) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #53 from Agustín Moyano  ---
Created attachment 88961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88961=edit
Bug 22284: Opac pickup_locations

This patch modifies Koha::Libraries->pickup_location and moves most of the
logic to
Koha::Item and Koha::Biblio in preparation for api endpoints in the future.

There where 2 methods added

1) Koha::Item->pickup_locations that given a patron, returns all pickup
locations of
this item, considering hold fulfillment rules, and hold allowed rules.

2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list
of
libraries returned by each of this biblio items pickup location.

Koha::Libraries->pickup_location analyzes input param and calls
Koha::Item->pickup_locations
or Koha::Biblio->pickup_locations as needed.

Also in opac-reserve.tt the way options where obtained to fill the pickup
location select
was modified to pass the patron as a parameter.

To test:
1) opac: try to place hold on a item and check that all libraries are shown in
the
pickup location select.
2) intranet: in Library groups, add 2 root groups marked as local hold group
and
add different libraries to each.
3) opac: login as a user of a library belonging to one hold group, and search
try to
place a hold on an item belongin to the other hold group.
4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold
pickup
library match' rules.
5) opac: On each modification of the rules reload the page.
SUCCESS => Every time you reload the page, the number of pickup locations
showed in
select varies.
6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t
SUCCESS => Result: PASS
7) Sign off

Sponsored-by: VOKAL

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #52 from Agustín Moyano  ---
Created attachment 88960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88960=edit
Bug 22284: New messages in reserve/request.tt

This patch adds new messages to 'Hold' column in 'Place a hold on a specific
item' table
Those messages are
1) Cannot place hold from patrons's library: this message appears when patron's
homebranch
is not in item's hold group
2) Pickup library is not in hold group: self explanatory

To test:
1) In library groups add a root group and check it as hold group.
2) Add a library to the group
3) In circulation and fines rules, in 'Default checkout, hold and return
policy', in Hold
policy change the value to 'From local hold group'
4) Search a patron from a different library than step 2, select one and click
'search to hold'
5) Search by location for items in the library of step 2
6) On any item, clic on 'Place hold for ...'
SUCCESS => when the page is loaded, in the 'Place a hold on a specific item',
you should see
the message "Cannot place hold from patrons's library" in 'Hold' column
7) In circulation and fines rules, in 'Default checkout, hold and return
policy', in 'Hold
policy' change the value again to 'From any library' and change 'Hold pickup
library match'
to "Item's hold group"
8) Repeat steps 4 to 5
9) Find a biblio with items in 2 different libraries
SUCCESS => when the page is loaded, in the 'Place a hold on a specific item',
you should see
the message "Pickup library is not in hold group" in 'Hold' column for the item
that has no hold group
10) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #48 from Agustín Moyano  ---
Created attachment 88956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88956=edit
Bug 22284: (follow-up) Add schema modifications

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #49 from Agustín Moyano  ---
Created attachment 88957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88957=edit
Bug 22284: Add new checkbox in Library Groups

This patch adds a new checkbox option 'Is local hold group' when you create a
new root group.

To test:
1) In intranet go to Library Groups in admin module
2) Add new root group
3) Check that there is no 'Is local hold group' checkbox
4) Apply this patch
5) Add new root group
SUCCESS => a new 'Is local hold group' checkbox appears
6) Select 'Is local hold group' and save
7) Click edit button for root group
SUCCESS => 'Is local hold group' is checked
8) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #50 from Agustín Moyano  ---
Created attachment 88958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88958=edit
Bug 22284: New hold group options in smart-rules

This patch adds new options for 'Default checkout, hold and return policy'
and 'Default holds policy by item type', both in 'Hold policy' and 'Hold
pickup library match' columns

To test:
1) Go to 'Circulation and fines rules' in admin
2) Check that there are no options for hold group in 'Hold policy' and 'Hold
pickup library match' columns
3) Apply this patch
SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and
in
'Hold pickup library match' you should see "Item's hold group"
4) Select any of those options and save
SUCCESS => options should be selected when page reloads
5) Sign off

Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88948|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88945|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88944|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88942|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88949|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88940|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88946|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88943|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88939|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88947|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #88941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21512] CalculateFinesOnReturn doesn't work without the syspref finesMode

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512

hienpn  changed:

   What|Removed |Added

 CC||hien.p...@dlcorp.com.vn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22408] Subscription entry form cleanup

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408

Michal Denar  changed:

   What|Removed |Added

  Attachment #88189|0   |1
is obsolete||

--- Comment #8 from Michal Denar  ---
Created attachment 88953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88953=edit
Bug 22408: Subscription entry form cleanup

This patch makes a number of changes to the subscription entry form:

  - Make the default layout single-column.
  - Switch the layout to two-column only when testing prediction
pattern.
- Add a button to hide the prediction pattern test pane.
  - Change the style of some buttons and links. Add Font Awesome icons
to some.
  - Clean up some issues with capitalization and spacing.
  - Make it clearer when form fields are read-only: Move "locked" form
field style from addbiblio.css to staff-global.css and improve it
with regard to mouse interactions

To test, apply the patch and regenerate the staff client CSS. Clear your
browser cache if necessary.

 - Go to Serials -> New subscription.
 - Readonly fields under "Vendor" and "Record" should show a small
   padlock icon.
 - Test the process of adding a subscription, paying special attention
   to the advanced pattern controls: Showing, hiding, modifying,
   canceling.
 - Test the process of editing a subscription in the same way.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22408] Subscription entry form cleanup

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788

hienpn  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788

hienpn  changed:

   What|Removed |Added

 CC||hien.p...@dlcorp.com.vn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788

--- Comment #1 from hienpn  ---
Created attachment 88952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88952=edit
Checkout transaction

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22788] New: Wrong accruing Overdue Amount

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788

Bug ID: 22788
   Summary: Wrong accruing Overdue Amount
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hien.p...@dlcorp.com.vn
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 88951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88951=edit
Accruing fine amount

Hi All,

I found an issue with fine function on koha 18.11.02. Please help to check.

When the item is overdue, koha run fines.pl cronjob and update accruing fine to
patron account. But i think something wrong when koha run fines.pl cronjob to
update accruing fine.

Example: I checked out two barcode for one patron account. The barcodes have
the same item type, checkout from same location and same time.

System configuration:
- CalculateFinesOnReturn option is "Do"
- finesMode is "Calculate and charge"
- Loan period: 21 days
- Fine amount: RM0.5/day
- Overdue fines cap (amount): RM40

I checked out item on January 06, 2019 and item overdue on January 27, 2019. By
circulation rule, patron has RM40 accruing fine in his account for one overdue
item. But when i check accruing fine of patron, i see accruing fine incorrectly
and timestamp of action is not today. The attached file is screenshot of this
issue. 

Besides, this issue don't happen with all patron account in koha. Please help
to check this

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461

--- Comment #25 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #23)
> Created attachment 88921 [details] [review]
> Bug 22461: (follow-up) Use `exists` not `defined`
> 
> Prior to this patch there is a regression in the LDAP replication
> functionality such that clearing a field become impossible. This patch
> restores that functionality.
> 
> Signed-off-by: Martin Renvoize 

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #51 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #50)
> Final follow-up tested.. working solidly for me, thanks Tomas!

Final follow-up pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22787] Mapping missing for ů to u in word-phrase-utf-chr

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Mapping missing for ů to u  |Mapping missing for ů to u
   |in word-phrafe-utf-chr  |in word-phrase-utf-chr

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22787] New: Mapping missing for ů to u in word-phrafe-utf-chr

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787

Bug ID: 22787
   Summary: Mapping missing for ů to u in word-phrafe-utf-chr
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The problem was noticed when searching for this author:
https://en.wikipedia.org/wiki/Bohuslav_Martin%C5%AF

It seems we map this:
https://software.hixie.ch/utilities/cgi/unicode-decoder/character-identifier?characters=u%CC%8A

But not:
https://software.hixie.ch/utilities/cgi/unicode-decoder/character-identifier?characters=%C5%AF

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

--- Comment #50 from Martin Renvoize  ---
Final follow-up tested.. working solidly for me, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88938|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 88950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88950=edit
Bug 15496: (QA follow-up) Fix remaining cases

This patch fixes remaining cases of the list => scalar change.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Reserves.t
=> FAIL: Tests fail
- Apply this patch
- Run:
 k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Reserves.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22687] Typo in Koha::Manual breaks Portuguese links

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687

Katrin Fischer  changed:

   What|Removed |Added

Summary|Type in Koha::Manual breaks |Typo in Koha::Manual breaks
   |Portuguese links|Portuguese links
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #46 from Agustín Moyano  ---
Created attachment 88949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88949=edit
Bug 22284: (follow-up) fixes after 15496

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22786] Can create new funds for locked budgets

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786

Nick Clemens  changed:

   What|Removed |Added

 Depends on||9628


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9628
[Bug 9628] Replace YUI buttons and menus on budgets administration pages with
Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9628] Replace YUI buttons and menus on budgets administration pages with Bootstrap

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9628

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786
[Bug 22786] Can create new funds for locked budgets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #45 from Agustín Moyano  ---
New dependency on bug 15496 only needs to apply last patch

88938 - Bug 15496: (QA follow-up) Fix remaining cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Agustín Moyano  changed:

   What|Removed |Added

 Depends on||15496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496
[Bug 15496] Delete bibliographic record after moving last item to another
record(s)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496

Agustín Moyano  changed:

   What|Removed |Added

 Blocks||22284


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
[Bug 22284] Groups of pickup locations for holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 88948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88948=edit
Bug 22284: (follow-up) fix test count after merge

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 88947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88947=edit
Bug 22284: (follow-up) Remove commented warn and address test failures

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   3   4   5   >