[Koha-bugs] [Bug 22817] New: Call viewlog.pl using GET rather than POST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22817 Bug ID: 22817 Summary: Call viewlog.pl using GET rather than POST Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When in the log viewer, the page uses POST rather than GET. This means that the HTTP params are not viewable in the address bar. This is very inconvenient from a support standpoint, since you can't then copy the URL from the address bar in order to show someone what you're seeing in the logs -- instead, you have to tell them what to look for in the logs, which is very error prone. Possibly even better would be a 'Copy URL' button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill it's div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea changed: What|Removed |Added Assignee|oleon...@myacpl.org |wizzy...@gmail.com CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill it's container
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea changed: What|Removed |Added Summary|OPAC detail holdings table |OPAC detail holdings table |doesn't fill it's div |doesn't fill it's container -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill it's div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 --- Comment #1 from Liz Rea --- Created attachment 89158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89158=edit Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. thanks to Owen Leonard for the initial fix for the subscriptions table and the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill it's div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22816] New: OPAC detail holdings table doesn't fill it's div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816 Bug ID: 22816 Summary: OPAC detail holdings table doesn't fill it's div Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- it could fit better, so let's make it so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22803] Set dataTable width issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22803] Set dataTable width issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Liz Rea changed: What|Removed |Added Attachment #89011|0 |1 is obsolete|| Attachment #89035|0 |1 is obsolete|| --- Comment #6 from Liz Rea --- Created attachment 89157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89157=edit Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22799] Batch item modification is case sensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 --- Comment #7 from Aleisha Amohia --- > If you wanted to make the batch item modification tool case sensitive then > this behaviour needs to be made consistent everywhere in Koha. For example, > circulation - issuing with the barcode 'abcde' would check out the same item > as issuing with the barcode 'abcDE'. In case this wasn't clear, I am describing the current behaviour for circulation. You can check out an item with the barcode 'abcde' or 'abcDE' currently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22799] Batch item modification is case sensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 --- Comment #6 from Aleisha Amohia --- (In reply to Josef Moravec from comment #4) > I don't think so the barcode should be case insensitive - if you refer to > barcode as main identifier for items, you need to make exact matches - > taking your examples barcodes "abcde" and "abcDE" will not have same > graphics represantation - so they are different. That's fine but that isn't currently the behaviour anywhere in Koha. Everything (except passwords) is case insensitive because the database does case insensitive searching. If you wanted to make the batch item modification tool case sensitive then this behaviour needs to be made consistent everywhere in Koha. For example, circulation - issuing with the barcode 'abcde' would check out the same item as issuing with the barcode 'abcDE'. I think while the behaviour in Koha is not case sensitive, this patch is still valid and fixes the current problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #101 from Liz Rea --- i'll retest this tomorrow I think -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19062] Don't queue check-in/checkout messages if patron has no e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|NEW |In Discussion --- Comment #2 from Hayley Mapley --- Is this resolved? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #100 from Agustín Moyano --- (In reply to Agustín Moyano from comment #86) > Created attachment 89122 [details] [review] > Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option > > In order to add groups for holds, this patch provides a new column in > library_groups to identify them. Also provides new enum option for > hold_fulfillment_policy column of default_branch_circ_rules, > default_circ_rules, default_branch_item_rules and branch_item_rules. > > To test: > 1) check that there is no ft_local_hold_group column in library_groups > and that there are no 'holdgroup' enum option in hold_fulfillment_policy > in default_branch_circ_rules, default_circ_rules, default_branch_item_rules > and branch_item_rules > 2) apply this patch > 3) perl installer/data/mysql/updatedatabase.pl && dbic > SUCCESS => !(step 1) ;-D > 4) Sign off > > Sponsored-by: VOKAL > > Signed-off-by: Tomas Cohen Arazi After bug 18936, omit from this test plan the 'holdgroup' enum columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22815] Save item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22815 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15136 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22815 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22815] New: Save item's homebranch in patron's fines list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22815 Bug ID: 22815 Summary: Save item's homebranch in patron's fines list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- bug 15136 added a column to the fines screen (boraccount.pl) that shows the item's home branch. If the item is deleted the branch information goes away. It would be helpful if that column was filled and the data saved so if the item is deleted the information is not lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22807] Koha should use Skip to Main Content link for accessibility purposes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #1 from Hayley Mapley --- Hi Owen, Shall I change the status of this one to Assigned? Or do you want someone else to pick it up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Liz Rea --- Hi Arthur, Sorry to report this patch doesn't seem to apply: Applying: Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Please rebase on master and reattach, thanks very much for your contribution! Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #4 from Liz Rea --- Also fixed your commit message to make the QA tools happy :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 --- Comment #3 from Liz Rea --- Created attachment 89156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89156=edit Bug 22809: (QA follow-up) add bug description to atomicupdate Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What|Removed |Added Attachment #89115|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 89155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89155=edit Bug 22809: Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22808] Move Cache.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Liz Rea changed: What|Removed |Added Attachment #89108|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 89154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89154=edit Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. Signed-off-by: Liz Rea test passes in the new location, doesn't exist in the old one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22808] Move Cache.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #18 from Liz Rea --- Created attachment 89153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89153=edit Bug 22524: Fix date/time-last-modified search with Elasticsearch Avoid using slash in the field name since it would need to be escaped. Fix conversion of dtlm and any existing mapping. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Liz Rea changed: What|Removed |Added Attachment #88999|0 |1 is obsolete|| Attachment #89000|0 |1 is obsolete|| --- Comment #17 from Liz Rea --- Created attachment 89152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89152=edit Bug 22524: Fix publication date and year search with Elasticsearch Also fixes the mappings.yaml to use correct field name (left over issue from bug 19575), so reset mappings and reindex before testing. Test plan: 1. Reset mappings and reindex biblios. 2. Check that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t pass. 3. Try that all of the following year range type work in publication date search and year limit in advanced search: - - - Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #29 from Jonathan Druart
---
Quick code review:
1.
+my $child_types = Koha::ItemTypes->search( parent_type => $type );
search take a hashef!
2.
+$parent_maxissueqty_rule = undef if $parent_maxissueqty_rule &&
$parent_maxissueqty_rule->itemtype eq '*';
Is that possible? IIRC we had NULL in DB to tell "all", not "*"
3.
+if (C4::Context->preference('item-level_itypes')) {
+$count_query .= q|SELECT COALESCE( SUM( IF(items.itype = '| .$type
. q|',1,0) ), 0) as type_total, COUNT(*) AS total,
COALESCE(SUM(onsite_checkout), 0) AS onsite_checkouts|;
+} else{
+$count_query .= q|SELECT COALESCE(SUM( IF(biblioitems.itype = '|
.$type . q|',1,0) ), 0) as type_total, COUNT(*) AS total,
COALESCE(SUM(onsite_checkout), 0) AS onsite_checkouts|
+}
Please do not repeat, the only change is items vs biblioitems, so put it into a
var then generate the query.
4.
+while ( my $child = $children->next ){
+push @types, $child->itemtype;
+}
You need $children->get_column
5.
-Add item type
+]Add item type
6. The indentation fix should not be here, it will add unnecessary conflict
with patches already in the queue (bug 15522 and deps for instance!).
smart-rules.tt particularly
7. I am really not sure the comparisons with '*' in smart-rules.tt are correct.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 89151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89151=edit Bug 22813: (follow-up) Add missing condition This patch restores a missing condition. $patron gets renamed to make it obvious that it related to the logged in user. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What|Removed |Added Keywords||rel_19_05_candidate Severity|normal |major --- Comment #9 from Jonathan Druart --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #8 from Jonathan Druart --- *** Bug 22766 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 22420 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 --- Comment #6 from Jonathan Druart --- (In reply to Claudio from comment #5) > Jonathan, bug 22420 solves the problem. I have just tested and all work fine. Please sign it off then :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |Failed QA --- Comment #66 from Liz Rea --- Hi, I've just tried to test this, and I don't see the row at the bottom to add new mappings on the search tab? Terribly sorry, I'm quite sure I restarted the things and did all of the prerequisites, but as usual not sure if it was something I'm doing wrong or if it's the code. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22108] Items generated through MARCItemFieldsToOrder do not receive values applied in Item Information and Default Accounting Details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22108 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Liz Rea changed: What|Removed |Added Attachment #89137|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 89150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89150=edit Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #86040|0 |1
is obsolete||
--- Comment #12 from Tomás Cohen Arazi ---
Created attachment 89149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89149=edit
Bug 22453: Make TestBuilder generates dates taking into account the timezone
I have no idea why this only appears today but TestBuilder generates dates
using DateTime->now,
which does not take into account the timezone.
It has been highlights by a failing test today on U18.
Why today whereas this patch was pushed few weeks ago?
Why U18 and not D9?
The output of the test is:
koha_1 | # Failed test 'With BorrowerLogs and
TrackLastPatronActivity we should not spam the logs'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421.
koha_1 | # got: '2'
koha_1 | # expected: '1'
koha_1 | # Looks like you failed 1 test of 4.
koha_1 |
koha_1 | # Failed test 'BorrowersLog tests'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422.
koha_1 | # Looks like you failed 1 test of 33.
koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t
Actually there are 2 logs, one for the cardnumber that is expected, and on for
updated_on:
"updated_on" : {
"after" : "2019-03-04 21:10:00",
"before" : "2019-03-04 18:10:00"
}
Apart from the fact that we may want to remove this updated_on field from
MODIFY,
the before/after dates differ from 3 hours.
Here it's currently 18:10 and in UTC-3
To prevent such behaviors in tests (create stuffs in the future...), we should
use our Koha::DateUtils::dt_from_string method that takes care of the timezone
used in other places of Koha.
Test plan:
prove t/db_dependent/Koha/Patrons.t
May fail without this patch.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 --- Comment #2 from Jonathan Druart --- Created attachment 89148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89148=edit Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Jonathan Druart changed: What|Removed |Added Version|18.05 |master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22805] When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805
--- Comment #3 from Jonathan Druart
---
Here it is not saved, the crash appears at
Koha::Patron::get_age('Koha::Patron=HASH(0x55dfa6af0400)') called at
/home/vagrant/kohaclone/members/memberentry.pl line 338
before the patron is stored (on line 434).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #27 from Liz Rea --- Created attachment 89147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89147=edit Bug 5770: Notify for new suggestion - sample notices Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #26 from Liz Rea --- Created attachment 89146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89146=edit Bug 5770: Unit test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #25 from Liz Rea --- Created attachment 89145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89145=edit Bug 5770: New system pref for new suggestion email Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Liz Rea changed: What|Removed |Added Attachment #89139|0 |1 is obsolete|| Attachment #89140|0 |1 is obsolete|| Attachment #89141|0 |1 is obsolete|| Attachment #89142|0 |1 is obsolete|| --- Comment #24 from Liz Rea --- Created attachment 89144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89144=edit Bug 5770: Email librarian when purchase suggestion made Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens changed: What|Removed |Added Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea changed: What|Removed |Added Attachment #89138|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 89143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89143=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Liz Rea changed: What|Removed |Added Severity|blocker |major CC||wizzy...@gmail.com --- Comment #1 from Liz Rea --- This is probably to do with strict mode, as KohaDevBox doesn't seem to manifest this behaviour. Off of blocker because most people have already turned off strict mode if they are using mysql, but it's still pretty major because we can't add subscriptions in strict mode and that seems wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22814] New: Holds modal patron name display inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Bug ID: 22814 Summary: Holds modal patron name display inconsistency Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: geo...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #23 from Devinim --- Created attachment 89142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89142=edit Bug 5770: Notify for new suggestion - sample notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Devinim changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #22 from Devinim --- Created attachment 89141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89141=edit Bug 5770: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #21 from Devinim --- Created attachment 89140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89140=edit Bug 5770: New system pref for new suggestion email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Devinim changed: What|Removed |Added Attachment #83615|0 |1 is obsolete|| Attachment #83616|0 |1 is obsolete|| Attachment #83617|0 |1 is obsolete|| Attachment #84463|0 |1 is obsolete|| Attachment #84812|0 |1 is obsolete|| --- Comment #20 from Devinim --- Created attachment 89139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89139=edit Bug 5770: Email librarian when purchase suggestion made -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #272 from Mirko Tietgen --- I applied the patches, created a request, tested it ok, submitted and then … nothing happens. "OAI-PMH harvester offline" Is there something else I have to do? I can't choose "Record type: Authorities", is that intentional? I manually installed libpoe-perl and libpoe-component-jobqueue-perl. Are there other dependencies I mossed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 --- Comment #1 from Owen Leonard --- Created attachment 89138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89138=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 89137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89137=edit Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||josef.mora...@gmail.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22813] New: searchResults queries the Koha::Patron object inside two nested loops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Bug ID: 22813 Summary: searchResults queries the Koha::Patron object inside two nested loops Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- I haven't benchmarked this, but it seems really bad and easy to fix. To verify: Go to C4::Search:2119, notice the IF includes a query for a Koha::Patron object, and then for its related Koha::Patron::Category object. This is done for each item, on each record in the resultset WTF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] New: Cannot add new subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Bug ID: 22812 Summary: Cannot add new subscription Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Target Milestone: --- I can't seem to add a new subscription without filling in every. single. box. As an example, I created a subscription with no vendor, a biblio, no special anything, and I got an error Can't call method "set_additional_fields" on an undefined value at /kohadevbox/koha/serials/subscription-add.pl line 401 there are also sql errors when you don't fill in various boxes: Incorrect integer value: '' for column 'aqbooksellerid' at row 1 if you don't give a vendor Incorrect integer value: '' for column 'innerloop1' at row 1 if you don't use a prediction pattern that fills all boxes x y z My version of sql is 5.5.62 and this was in a docker test setup. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] New: Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Bug ID: 22811 Summary: Add button to clear DataTables filtering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Created attachment 89136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89136=edit Screen grab showing clear button interaction I propose that we add a "Clear filter" button to the global DataTables configuration which will be displayed if the table has a search form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #99 from Agustín Moyano --- Created attachment 89135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89135=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Liz Rea changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #98 from Agustín Moyano --- Created attachment 89134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89134=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Bug 22284 depends on bug 15496, which changed state. Bug 15496 Summary: Delete bibliographic record after moving last item to another record(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #96 from Agustín Moyano --- Created attachment 89132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89132=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #97 from Agustín Moyano --- Created attachment 89133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89133=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #95 from Agustín Moyano --- Created attachment 89131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89131=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #91 from Agustín Moyano ---
Created attachment 89127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89127=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #93 from Agustín Moyano --- Created attachment 89129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89129=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #94 from Agustín Moyano --- Created attachment 89130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89130=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #90 from Agustín Moyano --- Created attachment 89126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89126=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #92 from Agustín Moyano --- Created attachment 89128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89128=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #88 from Agustín Moyano --- Created attachment 89124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89124=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #89 from Agustín Moyano --- Created attachment 89125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89125=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #87 from Agustín Moyano --- Created attachment 89123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89123=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #86 from Agustín Moyano --- Created attachment 89122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89122=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8619] Remove hidelostitems syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #3) > I am not sure how hidelostitems is realized, but there are several > disadvantages to using OpacHiddenItems that keep some libraries from using > it (we also have a lot that do): > > 1) It works outside of Zebra, so there are holes in the search results and > you can end up with almost empty pages if you hide a lot of things > 2) Because of the holes, we have removed the numbering from the search > results when OpacHiddenItems is used, to make it less obvious > 3) It will need updating, as Owen points out Good point, Katrina. I'd say any move towards removing the syspref, should keep this behavior you describe from hidelostitems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #65 from axel Amghar --- Created attachment 89121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89121=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |Failed QA --- Comment #36 from Liz Rea --- Hi, There is something odd here - the Defaults row seems to always say (not set) even if the rules are propagated? Deleting the All-All rule from the main table seems to clear the default checkout, hold, and return policy values? Is that expected? You can re-set the checkout hold and return policy rules without having an All-All rule, but deleting it seems to delete both? Probably not going to go on testing the actual function until I get an answer on these things, sorry. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar changed: What|Removed |Added CC||axel.amg...@biblibre.com Attachment #89118|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #141 from Tomás Cohen Arazi --- Created attachment 89120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89120=edit Bug 8995: (QA follow-up) Mock required sysprefs in the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89082|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89084|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89083|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89085|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89079|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89075|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89080|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89081|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89078|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
