[Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #21 from Agustín Moyano --- (In reply to Agustín Moyano from comment #18) > Created attachment 89406 [details] [review] > Bug 18930: (follow-up) Change variable used in refund select for default > options This change was because when default rules where undefined, select value always showed 'No' option, while 'use default' options of specific branches showed 'Use default (yes)' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #20 from Agustín Moyano --- (In reply to Agustín Moyano from comment #17) > Created attachment 89405 [details] [review] > Bug 18930: (follow-up) Amend search parameter in > Koha::RefundLostItemFeeRules->_default_rule This patch was because branchcode was '*', which for CirculationRules should be undef to find default values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #19 from Agustín Moyano --- (In reply to Agustín Moyano from comment #16) > Created attachment 89404 [details] [review] > Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters > in smart-rules.pl Added this patch because since RefundLostItemFeeRules is based on CirculationRules, find parameters should not have '*' as branchcode, and a rule_name must be specified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #17 from Agustín Moyano --- Created attachment 89405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89405=edit Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #18 from Agustín Moyano --- Created attachment 89406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89406=edit Bug 18930: (follow-up) Change variable used in refund select for default options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #16 from Agustín Moyano --- Created attachment 89404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404=edit Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Hayley Mapley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | CC||hayleymap...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Hayley Mapley changed: What|Removed |Added Attachment #89389|0 |1 is obsolete|| --- Comment #3 from Hayley Mapley --- Created attachment 89403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89403=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Derryn changed: What|Removed |Added CC||derr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #2 from Hayley Mapley --- I tried to test this, but was unable to replicate on master. Borrower count was 2, I ran prove t/db_dependent/selenium/authentication.t, then checked my borrower count again, and it was two. Have I missed a step here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 Agustín Moyano changed: What|Removed |Added Attachment #89373|0 |1 is obsolete|| --- Comment #3 from Agustín Moyano --- Created attachment 89401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89401=edit Bug 22847: Correctly displayed circ rule values for max_holds and maxissue* There are several things going wrong on the circulation rules screen. The global rule is displayed for specific libraries (even if the rule does not exist for the library), and max_holds is always blank. I have trouble finding the root of the issue, but I will propose a patch to fix both problem. Certainly a mismatch between bug 18887 and bug 18925. Test plan: 0. Do not apply the patch 1. Notice the issue on the circulation rules screen 2. Apply the patch 3. Confirm that the value you set are correctly displayed (and not the propagated ones!) Signed-off-by: Liz Rea Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89377|0 |1 is obsolete|| --- Comment #63 from Agustín Moyano --- Created attachment 89402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89402=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22859] Copying an item that has location set as 'CART' sets the permanent location of the new item to 'CART'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22859 Christopher Brannon changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22859] Copying an item that has location set as 'CART' sets the permanent location of the new item to 'CART'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22859 --- Comment #1 from Christopher Brannon --- This explains a lot. Please fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22859] Copying an item that has location set as 'CART' sets the permanent location of the new item to 'CART'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22859 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #2 from Michal Denar --- Any test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22860] Selenium tests authentication.t does not remove all data it created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 --- Comment #1 from Jonathan Druart --- Created attachment 89400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89400=edit Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22860] New: Selenium tests authentication.t does not remove all data it created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Bug ID: 22860 Summary: Selenium tests authentication.t does not remove all data it created Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 19181 Target Milestone: --- 1 patron will remain in the DB after the tests ran. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 [Bug 19181] Intranet and OPAC authentication selenium test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 Jonathan Druart changed: What|Removed |Added Blocks||22860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 [Bug 22860] Selenium tests authentication.t does not remove all data it created -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22859] New: Copying an item that has location set as 'CART' sets the permanent location of the new item to 'CART'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22859 Bug ID: 22859 Summary: Copying an item that has location set as 'CART' sets the permanent location of the new item to 'CART' Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- It should copy the original items.permanent_location rather than items.location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #9 from Martin Renvoize --- Hmm, should we use 'adjust' or should we create a new credit/debit and offset against the original for this. I'm torn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22858] New: Overdue items should trigger holds suspension
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22858 Bug ID: 22858 Summary: Overdue items should trigger holds suspension Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- Would like to see a feature that would suspend all hold requests on an account if there are items overdue. It would be great if this had preference to enable or disable, and for what libraries this would affect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 --- Comment #10 from Liz Rea --- Created attachment 89397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89397=edit Bug 22781: Test patron's info filtering The patron's data was not correctly escaped actually. Test plan: This is a good value for the whole patchset: fir's"tname \123 ❤ use it for a patron's firstname, then do a search Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 --- Comment #11 from Liz Rea --- Created attachment 89398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89398=edit Bug 22781: Does not double filter address Ho, a bug! Some fields in the address where double filtered. Test plan: Use the evil strings in the address field and do a search, you will see double html encoded characters without this patch. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 --- Comment #12 from Liz Rea --- Created attachment 89399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89399=edit Bug 22781: Correctly filter the emails Ho, another bug! The email was not correctly filtered. Test plan: Use the evil string for an email, do a search. => Notice that without this patch the results never show up Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 --- Comment #9 from Liz Rea --- Created attachment 89396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89396=edit Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry This will fix the previous failure. Note that other fields like borrowernumber, Price escaped values, integers, etc. could be escaped the same way but will be useless (save polar bears). Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Liz Rea changed: What|Removed |Added Attachment #89267|0 |1 is obsolete|| Attachment #89268|0 |1 is obsolete|| Attachment #89269|0 |1 is obsolete|| Attachment #89270|0 |1 is obsolete|| Attachment #89271|0 |1 is obsolete|| --- Comment #8 from Liz Rea --- Created attachment 89395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89395=edit Bug 22781: Add tests Test plan: Apply only this patch => The tests will fail, the library's name is not correctly escaped. Note: This applies for the whole patchset, when the tests fail you will need to remove the patrons added by the tests with the following SQL query: delete from borrowers where surname like "test_patron_%"; We are expecting END to be called even if something goes wrong, but DESTROY must be used instead. This will be fixed separately, on its own bug report. NOTE: I (Liz) did not test this first patch because my selenium was not working, that is why my SO line is not on the patch. If someone could do that quickly I'd be really grateful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #7 from Liz Rea --- Just to point out, the interface won't actually allow saving the "bad string email," so you've got to force it in there in the DB. It's probably still good to make sure this is escaped though, because who knows what can happen in migration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea changed: What|Removed |Added Attachment #88966|0 |1 is obsolete|| --- Comment #4 from Liz Rea --- Created attachment 89394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89394=edit Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] New: Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Bug ID: 22857 Summary: Entries missing in koha-conf.xml Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- At least dev_install and strict_sql_modes are missing from the koha-conf.xml file. Even if there will not be used in production I feel like we should have all the possible flags available in etc/koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #3 from Liz Rea --- Can I just say this test plan is A+ very good, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #5 from Jonathan Druart --- Created attachment 89393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89393=edit Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement "SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist Test plan: Create a routing list, search for subscriptions In the action list you should see "Edit routing list (1)" or "New routing list" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #4 from Jonathan Druart --- Created attachment 89392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89392=edit Bug 22812: Add tests for checkrouting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Blocks||17258 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added Summary|Cannot add new subscription |Cannot add new subscription ||with strict SQL modes ||turned on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #2 from Jonathan Druart --- Created attachment 89391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89391=edit Bug 22812: Fix new subscription with strict sql modes With sql_strict_modes turned on, if you try to create a new subscription you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #3 from Jonathan Druart --- Note that now there is the following error in the log: DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement "SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist but does not explode the interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||22812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 [Bug 22812] Cannot add new subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows clickable tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Owen Leonard changed: What|Removed |Added Attachment #89379|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 89390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89390=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows clickable tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #2 from Owen Leonard --- Created attachment 89389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89389=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #62 from Agustín Moyano --- (In reply to Jonathan Druart from comment #61) > Created attachment 89377 [details] [review] > Bug 18928: Remove '(not set)' > > The "(not set)" part must be removed IMO, I am not sure I understand its > goal. > Now that we have 1 entry per rule (and not 1 DB row for the whole "Default > checkout, hold and return policy for Centerville" table), it will be harder > to handle it correctly. Not impossible, but if not really needed I would > prefer > to just remove it. If a rule is not set, the cell is empty or the dropdown > list > displays the option "Not set", which seems to correct the problem. Now that bug 22847 is a dependency of this bug, should't attachment 89348 be obsoleted? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21124] Non-Public note does not appear if added to item in MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21124 Jonathan Druart changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #32 from Liz Rea --- Created attachment 89388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89388=edit Bug 15260: (QA follow-up) Fix updatedatabase message Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #31 from Liz Rea --- Created attachment 89387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89387=edit Bug 15260: (follow-up) Fix bug in subtraction prev_open_days can receive either positive or negative numbers and then does the right thing with them. However, we weren't also doing this with the number it receives back from get_push_amt Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #30 from Liz Rea --- Created attachment 89386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89386=edit Bug 15260: (follow-up) Fix misnamed variable This was causing the amount to push by to be incorrectly calculated Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #29 from Liz Rea --- Created attachment 89385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89385=edit Bug 15260: Fix calculation of add amount In a sequence of closed days, we should take into account the nature of each closed day as we encounter it in order to calculate the amount to add to reach the next potential closed date. We are now doing this. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #28 from Liz Rea --- Created attachment 89384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89384=edit Bug 15260: Add unit tests This patch adds unit tests of the CalcDueDate function to ensure that the useDaysMode "Dayweek" mode works as expected Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #26 from Liz Rea --- Created attachment 89382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89382=edit Bug 15260: Modify next/prev_open_day We require next_open_day & prev_open_day to be more flexible. We could create a separate sub, but that's not very DRY given that they'll do pretty much the same thing. So next_open_day becomes next_open_days and prev_open_day becomes prev_open_days and both functions accept an additional parameter which determines how many days they add or subtract. All calls of these two functions have been modified accordingly. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #27 from Liz Rea --- Created attachment 89383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89383=edit Bug 15260: Implement weekly rollforward This patch will, when appropriate, roll due dates forward by full weeks, rather than single days. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #25 from Liz Rea --- Created attachment 89381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89381=edit Bug 15260: Modify description of Dayweek option Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows clickable tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Summary|Addbiblio shows tag editor |Addbiblio shows clickable |icons which do nothing |tag editor icons which do ||nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #7) > > Like that? Also I am wondering if we should not remove some classes, I do > > not know what is the purpose of .buttonDot > > This makes no actual difference. I still see a button that does not respond > to clicks. To me it's an improvement, the link is removed if no popup will be opened. So there is an icon but nothing to tell you it's clickable (pointer will be different). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Liz Rea changed: What|Removed |Added Attachment #88607|0 |1 is obsolete|| Attachment #88608|0 |1 is obsolete|| Attachment #88609|0 |1 is obsolete|| Attachment #88610|0 |1 is obsolete|| Attachment #88611|0 |1 is obsolete|| Attachment #88612|0 |1 is obsolete|| Attachment #88613|0 |1 is obsolete|| Attachment #89178|0 |1 is obsolete|| --- Comment #24 from Liz Rea --- Created attachment 89380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89380=edit Bug 15260: Add new useDaysMode option "Dayweek" This patch adds a new "Dayweek" option to the useDaysMode syspref, it has the description: "the calendar to push the due date to the next open day on the same weekday". Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Bouzid Fergani changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |bouzid.ferg...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Bouzid Fergani changed: What|Removed |Added Status|NEW |Needs Signoff CC||bouzid.ferg...@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Liz Rea changed: What|Removed |Added Comment #22 is|1 |0 private|| --- Comment #23 from Liz Rea --- Accidentally sent this as a private comment, sorry for the double up. Hi, This mostly looks good - tests pass now and I didn't get any failures on due date calculation using this system preference, and existing functionality seems good. This may very well be a false positive but could you check out this QA tool failure: FAIL Koha/Calendar.pm FAIL pod coverage POD is missing for get_push_amt I'll fix up the other QA tool concerns in a couple of follow ups (namely commit messages having malformed headers and the DB update not having a nice message) :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Bouzid Fergani changed: What|Removed |Added CC||bouzid.ferg...@inlibro.com Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Bouzid Fergani changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Attachment #81832|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 89379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89379=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #1 from Bouzid Fergani --- Created attachment 89378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89378=edit Bug 22426: Elasticsearch - Index location is missing in advanced search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #61 from Jonathan Druart --- Created attachment 89377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89377=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Attachment #89349|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #60 from Jonathan Druart --- So, if we agree that bug 22847 is valid, last patch must be obsoleted. However the "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Depends on||22847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 --- Comment #3 from Jonathan Druart --- Created attachment 89376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89376=edit Bug 22713: Remove unecessary $replacementprice var -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 Jonathan Druart changed: What|Removed |Added Blocks||18928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||18639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 [Bug 18639] Separate replacement cost and retail price fields in acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #17 from Liz Rea --- This is actually a really hard bug to fix because that field isn't uniform across libraries, and it's human input (sometimes) as well. It can be just numeric, alphanumeric, or only words. I don't know how you even could universally fix this sorting problem, short of making it so people could choose the type of sort they want on the column. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22799] Batch item modification is case sensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart --- Aleisha, the patch is wrong, try: 1. Use abCDE for barcode 2. Use the batch tool with abcde => Same wrong display You are using twice lc on the same element (from @barcodelist), so you are still comparing lc with another string which has not been lc'ed Better would be to use a map with a grep, let me know on IRC if you need help ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Jonathan Druart changed: What|Removed |Added Blocks||22713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22799] Batch item modification is case sensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- The display is definitely wrong indeed: https://snag.gy/UFqlg8.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #14 from Jonathan Druart --- Nick, not sure about the 2 spaces after '?'. I let you decide (and squash!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart changed: What|Removed |Added Attachment #88084|0 |1 is obsolete|| Attachment #89198|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 89374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89374=edit Bug 22527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula Sponsored-by: Hypernova Oy Signed-off-by: Hayley Mapley Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #13 from Jonathan Druart --- Created attachment 89375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89375=edit Bug 22527: Remove extra space after '?' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 Liz Rea changed: What|Removed |Added Attachment #89335|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 89373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89373=edit Bug 22847: Correctly displayed circ rule values for max_holds and maxissue* There are several things going wrong on the circulation rules screen. The global rule is displayed for specific libraries (even if the rule does not exist for the library), and max_holds is always blank. I have trouble finding the root of the issue, but I will propose a patch to fix both problem. Certainly a mismatch between bug 18887 and bug 18925. Test plan: 0. Do not apply the patch 1. Notice the issue on the circulation rules screen 2. Apply the patch 3. Confirm that the value you set are correctly displayed (and not the propagated ones!) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart changed: What|Removed |Added Assignee|lari.task...@hypernova.fi |wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 --- Comment #1 from Jonathan Druart --- Created attachment 89372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89372=edit Bug 22529: Use new C4::Auth::haspermission from svc/members/search The svc/members/search script can be used to retrieve patrons with a specific permission. This feature is only used once, to link patrons to funds. The code in the script is duplicated from what we have in C4::Auth::haspermission, and it makes sense to clean it. Test plan: Create a fund and add users to this fund. When you search for users you must only have a list of patrons with the acquisition.order_manage permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22854] Add separate column for administrative locked patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22854 --- Comment #2 from Jonathan Druart --- I think we could have only 1 more column: the reason of the lock. If NULL, the account is not locked. The field could be an ENUM with the different reasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
