[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #152 from David Cook  ---
(In reply to David Gustafsson from comment #151)
> https://bugs.koha-community.org/show_bug.cgi?id=14956

I think that URL should probably be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957, although I'm
not sure why it's there either?

In any case, intrigued to see how these patches progress.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #89709|0   |1
is obsolete||

--- Comment #6 from Hayley Mapley  ---
Created attachment 89725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89725=edit
Bug 22899: Add pending_hold method to Koha::Item

To test:
 1 - Enable course reserves
 2 - Create a course
 3 - Add an item to the course
 4 - Attempt to view the course on the OPAC
 5 - Internal Server Error
 6 - Apply patch
 7 - Add an item to the holds queue by placing a hold and  running holds queue
builder or:
 INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###);
 8 - View the course page, note item appears 'Pending hold'
 9 - Remove the holdsqueue line
10 - View the course page, note item appears 'Available'
11 - prove -v t/db_dependent/Koha/Item.t

Signed-off-by: Hayley Mapley 
I see Jonathan's comments about small improvements, but will sign off as
everything works as expected here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
I think this would be relevant when importing records for the first time via
Z39.50 as well.

For instance, it seems highly unlikely that you'd want to import the 9XX and
85X fields from another library's bibliographic record.

However, with that framework, you'd want to be able to have your own 9XX and
85X fields, so deleting the fields from the framework is not an acceptable
"workaround" to prevent importing of certain fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550

Derryn  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22900

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22900] New: Patron card images don't follow Units setting

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22900

Bug ID: 22900
   Summary: Patron card images don't follow Units setting
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: derr...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

When changing over our patron cards from Postscript points to SI Millimeters, I
noticed that while the layout coordinates switched over to mm, the image
display heights did not.

I tested with a new layout and encountered the same issue. Changing the display
height from 30 to 11 (the approximate conversion) it shrunk significantly.
Setting it back to 30 returned it to how it was.

To reproduce:
Create a card layout with an image and use points as the layout unit
* Export a PDF output 
* Change layout unit to SI millimeters then save
* Export another PDF output
* Compare PDFs - confirm they do not change in size.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22900] Patron card images don't follow Units setting

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22900

Derryn  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

--- Comment #7 from Hayley Mapley  ---
Hi Arthur,

Looks good, only the description is not displayed in the Hold column of the
item table when the 'On shelf holds allowed' preference is set to 'If all
unavailable'. It is shown though when the preference is set to 'If any
unavailable'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21662] Missing developers from history

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662

--- Comment #96 from Martin Renvoize  ---
I've pushed a copy of a marginally cleaned up get_developers.pl script to the
release-tools repo (with your fixes inlined).

There's lots of commented out print statements that were used for debugging
whilst the script was created.

What I'd like to do next is distil down the logic and merge it into the
koha-release script allowing for maintenance of both history and contributors
files to be automated at release time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #89039|0   |1
is obsolete||

--- Comment #4 from Arthur Suzuki  ---
Created attachment 89724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89724=edit
Bug 22806 : CanBookBeReserved and CanItemBeReserved must check
AllowHoldsOnPatronsPossessions

Test plan :
1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
2 - Checkout an item to a borrower
3 - Try to reserve an item using ILS-DI WebService -> Will work without
complaining.
4 - Cancel the hold and apply patch
5 - Repeat 3 -> Should not place hold and show error "NotHoldable"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #3 from Arthur Suzuki  ---
Thanks Liz :) I'm submitting a new patch right away!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22896] [18.11] Item to be transferred at checkin clears overridden due date

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Can you explain a bit more what happened? I have compared the two commits and
they are identical.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

--- Comment #5 from Jonathan Druart  
---
A couple of small things:
1. The new constraint will not be added if there are itemnumbers in the
tmp_holdsqueue that do not exist in items. I know it's unlikely to happen
but... who knows?

2. I am expecting ->pending_hold to return a Koha::Hold, maybe
->has_pending_hold could be better?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20116] Cache language list

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

--- Comment #36 from Jonathan Druart  
---
(In reply to Guillaume from comment #35)
> in file  /etc/koha/koha-sites.conf
> in find MEMCACHED_SERVERS="127.0.0.1:11211"
> 
> and in configuration MEMCACHED is on this server:
> 
>  systemctl status memcached.service
> â memcached.service - memcached daemon
>Loaded: loaded (/lib/systemd/system/memcached.service; enabled; vendor
> preset
>Active: active (running) since Mon 2019-05-13 19:44:21 CEST; 3min 57s ago
>  Docs: man:memcached(1)
>  Main PID: 632 (memcached)
> Tasks: 7 (limit: 4915)
>CGroup: /system.slice/memcached.service
>ââ632 /usr/bin/memcached -m 128 -p 11211 -u memcache -l 127.0.0.1
> 
> 
> in witch file is the "__MEMCACHED_SERVERS__" i find not it.
> 
> Sorry it's my 1st installation of Koha I am testing the software and need
> french translation.
> 
> Did I reinstall with Ubunutu 16.04 - >i can do it, i am installing in a VM
> on ESXI
> 
> What file is for you $KOHA_CONF
> 
> in /etc/koha/sites/kohadebian9/koha-conf.xml
> 
> i find
> 
>  127.0.0.1:11211
>  koha_kohadebian9

Guillaume, you will not get support here. You should ask the koha-devel list:
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
Or the general mailing list: https://lists.katipo.co.nz/mailman/listinfo/koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #2)
> When has it been added, do you have a bug number?
> It does not seem to work for me, I have 2 patron attributes, added
> patron_attr_1 to BorrowerMandatoryField and nothing marked as required on
> the patron edit form.

It actually works, but the input is not marked as required (class "required")
like other required inputs. The form submission is indeed prevented when one of
them is not filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

--- Comment #4 from Jonathan Druart  
---
So I think it's a side-effect, not a feature :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

--- Comment #3 from Jonathan Druart  
---
Ha, maybe this (js/members.js):

281 var mandatory_fields =
$("input[name='BorrowerMandatoryField']").val().split ('|');
282 $(mandatory_fields).each(function(){ 
283 $("[name='"+this+"']").attr('required', 'required');
284 });

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4030

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22728

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
When has it been added, do you have a bug number?
It does not seem to work for me, I have 2 patron attributes, added
patron_attr_1 to BorrowerMandatoryField and nothing marked as required on the
patron edit form.
Also I do not see the code that could deal with that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

--- Comment #6 from Arthur Suzuki  ---
(In reply to Hayley Mapley from comment #3)
> This patch results in a runtime error. Here are the steps I followed which
> led to the error.
> 
> - Checked default circulation rule - OnShelfHoldsAllowed is set to yes
> - Clicked Place hold on a biblio with one available item
> - Entered card number - error!
> 
> Error trace: 
> 
> Can't call method "effective_itemtype" on an undefined value at
> /home/vagrant/kohaclone/C4/Reserves.pm line 1181
> 
> 1.in C4::Reserves::IsAvailableForItemLevelRequest at
> /home/vagrant/kohaclone/C4/Reserves.pm line 1181
> 
>  1178: # consolidated
>  1179: my $patron = Koha::Patrons->find( $borrower->{borrowernumber}
> );
>  1180: my $item_object = Koha::Items->find( $item->{itemnumber } );
>  1181: my $itemtype = $item_object->effective_itemtype;
>  1182: my $notforloan_per_itemtype
>  1183:   = $dbh->selectrow_array("SELECT notforloan FROM itemtypes
> WHERE itemtype = ?",
>  1184:   undef, $itemtype);
> 
> 2.in C4::Reserves::CanItemBeReserved at
> /home/vagrant/kohaclone/C4/Reserves.pm line 332
> 
>   329: && !C4::Context->preference('AllowHoldsOnDamagedItems') );
>   330: 
>   331: # Check for item on shelves and OnShelfHoldsAllowed
>   332: return { status => 'onShelfHoldsNotAllowed' }
>   333:   unless ( IsAvailableForItemLevelRequest($item,$borrower) );
>   334: 
>   335: # Check for the age restriction
> 
> 3.in C4::Reserves::CanBookBeReserved at
> /home/vagrant/kohaclone/C4/Reserves.pm line 286
> 
>   283: 
>   284: my $canReserve = { status => '' };
>   285: foreach my $itemnumber (@itemnumbers) {
>   286: $canReserve = CanItemBeReserved( $borrowernumber,
> $itemnumber, $pickup_branchcode );
>   287: return { status => 'OK' } if $canReserve->{status} eq
> 'OK';
>   288: }
>   289: return $canReserve;
> 
> Setting to Failed QA

Hi Hayley,
Thanks for testing, updated my patch in consequence :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #86874|0   |1
is obsolete||

--- Comment #5 from Arthur Suzuki  ---
Created attachment 89723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89723=edit
Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved

Test plan :
1 / Check that default circulation have OnShelfHoldsAllowed to Yes
2 / Place a hold on a book with a single item, item being available for loan,
verify that hold can be placed.
3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be
placed for reason "onShelfHoldsNotAllowed" (shown in the item table).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

--- Comment #17 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #16)
> I am not sure about the commit messages - the first 2 are not referring to
> this bug. Leaving that to Nick ;)

They are ok, as they are reverting commits I think we should keep this syntax.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #38 from Nightly Build Bot  ---
Created attachment 89722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89722=edit
Bug 17084- Automatic debian/control updates (unstable/master)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22892] Warning when reindexing without parameters

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22892

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #3 from Katrin Fischer  ---
Trivial fix - going straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22365] Warn on Log Viewer

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 18.05.x for 18.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22892] Warning when reindexing without parameters

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22892

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89646|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 89721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89721=edit
Bug 22892: Remove warning from rebuild_es if --processes not passed

Use of uninitialized value $processes in numeric lt (<) at
misc/search_tools/rebuild_elasticsearch.pl line 199.

We want the number of processes to be set to 1 by default, and then
assign it to $slice_count

Test plan:
Run the script with and without --processes and confirm that the warning
went away.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22892] Warning when reindexing without parameters

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22892

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89705|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #91 from Katrin Fischer  ---
Owen, I hope you won't get grumpy with me, but I agree with Martin here - I
like the one column per team layout better than the divided layout with 3
columns. 

I have obsoleted your patch for now, but noting it for Nick. It works, of
course!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #90 from Katrin Fischer  ---
Created attachment 89720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89720=edit
Bug 21626: (follow-up) Minor tweaks to the columns formatting

This patch makes minor markup and CSS changes to improve the
column-formatting of team data. The primary goal of these changes is to
avoid showing a large blank space when using a development version. Some
text has been moved around to avoid validation errors.

To test, apply the patch and rebuild the staff client CSS.

Release and maintenance team information should be displayed in 3-column
sets. The information should look well-formatted when using a
development or non-development version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called twice when running link_bibs_to_authorities

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #14 from Lucas Gass  ---
i cannot rebase this and successfully prove -v t/db_dependent/Biblio.t in
18.05.x, if needed please rebase.


Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89720|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89704|0   |1
is obsolete||

--- Comment #89 from Katrin Fischer  ---
Created attachment 89719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89719=edit
Bug 21626: (follow-up) Template corrections for arrayref

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89700|0   |1
is obsolete||

--- Comment #85 from Katrin Fischer  ---
Created attachment 89715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89715=edit
Bug 21626: (follow-up) Changes based on feedback

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89698|0   |1
is obsolete||

--- Comment #83 from Katrin Fischer  ---
Created attachment 89713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89713=edit
Bug 21626: Add teams.yaml to /docs

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89702|0   |1
is obsolete||

--- Comment #87 from Katrin Fischer  ---
Created attachment 89717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89717=edit
Bug 21626: Add release dates to team

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89699|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 89714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89714=edit
Bug 21626: Use teams.yaml for teams section

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89703|0   |1
is obsolete||

--- Comment #88 from Katrin Fischer  ---
Created attachment 89718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89718=edit
Bug 21626: Corrections to typos

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89701|0   |1
is obsolete||

--- Comment #86 from Katrin Fischer  ---
Created attachment 89716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89716=edit
Bug 21626: (follow-up) Performance Improvement

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
I am not sure about the commit messages - the first 2 are not referring to this
bug. Leaving that to Nick ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89679|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 89712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89712=edit
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with
variable name

One occurrence was missing.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89678|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 89711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89711=edit
Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a
boolean"

This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4.

https://bugs.koha-community.org/show_bug.cgi?id=22836
Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89677|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 89710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89710=edit
Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags"

This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5.

https://bugs.koha-community.org/show_bug.cgi?id=22836
Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Nick Clemens  changed:

   What|Removed |Added

  Attachment #89706|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 89707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89707=edit
Bug 22899: Database update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

--- Comment #4 from Nick Clemens  ---
Created attachment 89709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89709=edit
Bug 22899: Add pending_hold method to Koha::Item

To test:
 1 - Enable course reserves
 2 - Create a course
 3 - Add an item to the course
 4 - Attempt to view the course on the OPAC
 5 - Internal Server Error
 6 - Apply patch
 7 - Add an item to the holds queue by placing a hold and  running holds queue
builder or:
 INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###);
 8 - View the course page, note item appears 'Pending hold'
 9 - Remove the holdsqueue line
10 - View the course page, note item appears 'Available'
11 - prove -v t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

--- Comment #3 from Nick Clemens  ---
Created attachment 89708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89708=edit
Bug 22899: [DO NOT PUSH] Schema updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899
[Bug 22899] Cannot view course details
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Nick Clemens  changed:

   What|Removed |Added

 Depends on||15505
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||martin.renvoize@ptfs-europe
   ||.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505
[Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

--- Comment #1 from Nick Clemens  ---
Created attachment 89706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89706=edit
Bug 22899: Add pending_hold method to Koha::Item

To test:
 1 - Enable course reserves
 2 - Create a course
 3 - Add an item to the course
 4 - Attempt to view the course on the OPAC
 5 - Internal Server Error
 6 - Apply patch
 7 - Add an item to the holds queue by placing a hold and  running holds queue
builder or:
 INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###);
 8 - View the course page, note item appears 'Pending hold'
 9 - Remove the holdsqueue line
10 - View the course page, note item appears 'Available'
11 - prove -v t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22899] New: Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899

Bug ID: 22899
   Summary: Cannot view course details
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Bug 15505 added a 'pending_hold' column to item-status.inc

Course reserves, however, passes item objects to the template and there is no
object method for pending_hold

To recreate:
1 - Enable course reserves
2 - Create a course
3 - Add an item to the course
4 - Attempt to view the course on the OPAC
5 - Internal Server Error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #82 from Martin Renvoize  ---
Also.. I actually like the abundance of whitespace when running a development
version.. it's bringing attention to the fact your running a dev version when
really you shouldn't be unless you're a developer.

Librarians should never see it, so we're not really saving any screen space
when running live.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89683|0   |1
is obsolete||

--- Comment #68 from Martin Renvoize  ---
Created attachment 89692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89692=edit
Bug 21626: (follow-up) Changes based on feedback

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #73 from Martin Renvoize  ---
Created attachment 89697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89697=edit
Bug 21626: (follow-up) Template corrections for arrayref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89695|0   |1
is obsolete||

--- Comment #79 from Martin Renvoize  ---
Created attachment 89703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89703=edit
Bug 21626: Corrections to typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89685|0   |1
is obsolete||

--- Comment #70 from Martin Renvoize  ---
Created attachment 89694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89694=edit
Bug 21626: Add release dates to team

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89693|0   |1
is obsolete||

--- Comment #77 from Martin Renvoize  ---
Created attachment 89701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89701=edit
Bug 21626: (follow-up) Performance Improvement

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89696|0   |1
is obsolete||

--- Comment #81 from Martin Renvoize  ---
Created attachment 89705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89705=edit
Bug 21626: (follow-up) Minor tweaks to the columns formatting

This patch makes minor markup and CSS changes to improve the
column-formatting of team data. The primary goal of these changes is to
avoid showing a large blank space when using a development version. Some
text has been moved around to avoid validation errors.

To test, apply the patch and rebuild the staff client CSS.

Release and maintenance team information should be displayed in 3-column
sets. The information should look well-formatted when using a
development or non-development version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89691|0   |1
is obsolete||

--- Comment #75 from Martin Renvoize  ---
Created attachment 89699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89699=edit
Bug 21626: Use teams.yaml for teams section

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89692|0   |1
is obsolete||

--- Comment #76 from Martin Renvoize  ---
Created attachment 89700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89700=edit
Bug 21626: (follow-up) Changes based on feedback

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89697|0   |1
is obsolete||

--- Comment #80 from Martin Renvoize  ---
Created attachment 89704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89704=edit
Bug 21626: (follow-up) Template corrections for arrayref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89694|0   |1
is obsolete||

--- Comment #78 from Martin Renvoize  ---
Created attachment 89702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89702=edit
Bug 21626: Add release dates to team

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89690|0   |1
is obsolete||

--- Comment #74 from Martin Renvoize  ---
Created attachment 89698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89698=edit
Bug 21626: Add teams.yaml to /docs

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89684|0   |1
is obsolete||

--- Comment #69 from Martin Renvoize  ---
Created attachment 89693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89693=edit
Bug 21626: (follow-up) Performance Improvement

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89687|0   |1
is obsolete||

--- Comment #72 from Martin Renvoize  ---
Created attachment 89696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89696=edit
Bug 21626: (follow-up) Minor tweaks to the columns formatting

This patch makes minor markup and CSS changes to improve the
column-formatting of team data. The primary goal of these changes is to
avoid showing a large blank space when using a development version. Some
text has been moved around to avoid validation errors.

To test, apply the patch and rebuild the staff client CSS.

Release and maintenance team information should be displayed in 3-column
sets. The information should look well-formatted when using a
development or non-development version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89682|0   |1
is obsolete||

--- Comment #67 from Martin Renvoize  ---
Created attachment 89691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89691=edit
Bug 21626: Use teams.yaml for teams section

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89686|0   |1
is obsolete||

--- Comment #71 from Martin Renvoize  ---
Created attachment 89695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89695=edit
Bug 21626: Corrections to typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89681|0   |1
is obsolete||

--- Comment #66 from Martin Renvoize  ---
Created attachment 89690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89690=edit
Bug 21626: Add teams.yaml to /docs

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22849] Data shared without agreement

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22849] Data shared without agreement

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89577|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 89689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89689=edit
Bug 22849: Do not share data (Mana) without agreement

A couple of things wrong in serials/subscription-add.pl

1.
447 if ( defined( $query->param('mana_id') ) ) {

It's always defined, you wanted to test with ""

2.
375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq
"subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){

Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case

So we are sharing data whereas the library did not decide yet!

Test plan:
You need to be familiar you Mana to test this patch.

JD: I did not test this patch

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20514] Searching for a patrons using the address option doesn't work with streetnumber

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Searching for a patron  |Searching for a patrons
   |using the search field  |using the address option
   |(street address) returns no |doesn't work with
   |results if inputting a  |streetnumber
   |address stored in multiple  |
   |db fields   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20514] Searching for a patrons using the address option doesn't work with streetnumber

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89647|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 89688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89688=edit
Bug 20514: Use streetnumber when searching for patrons by address

The streetnumber field was ignored from the search.

Test plan:
Create a patron with streetnumber="12", address="rue des cerisiers"
Search for patrons using the search field "street address"
using: 12 rue des cerisiers
=> Without this patch the patron will not be returned
=> With this patch applied it will!

Signed-off-by: Hayley Mapley 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20514] Searching for a patrons using the address option doesn't work with streetnumber

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89556|0   |1
is obsolete||

--- Comment #63 from Martin Renvoize  ---
Created attachment 89685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89685=edit
Bug 21626: Add release dates to team

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89553|0   |1
is obsolete||

--- Comment #60 from Martin Renvoize  ---
Created attachment 89682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89682=edit
Bug 21626: Use teams.yaml for teams section

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89557|0   |1
is obsolete||

--- Comment #65 from Martin Renvoize  ---
Created attachment 89687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89687=edit
Bug 21626: (follow-up) Minor tweaks to the columns formatting

This patch makes minor markup and CSS changes to improve the
column-formatting of team data. The primary goal of these changes is to
avoid showing a large blank space when using a development version. Some
text has been moved around to avoid validation errors.

To test, apply the patch and rebuild the staff client CSS.

Release and maintenance team information should be displayed in 3-column
sets. The information should look well-formatted when using a
development or non-development version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #64 from Martin Renvoize  ---
Created attachment 89686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89686=edit
Bug 21626: Corrections to typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89555|0   |1
is obsolete||

--- Comment #62 from Martin Renvoize  ---
Created attachment 89684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89684=edit
Bug 21626: (follow-up) Performance Improvement

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89554|0   |1
is obsolete||

--- Comment #61 from Martin Renvoize  ---
Created attachment 89683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89683=edit
Bug 21626: (follow-up) Changes based on feedback

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89552|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 89681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89681=edit
Bug 21626: Add teams.yaml to /docs

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626

--- Comment #58 from Martin Renvoize  ---
Hmm.. not sure I like the followup I'm afraid Owen.  I liked the side by side
of the two teams and I'm not a major fan of splitting the nicely ordered team
list over three columns..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Katrin Fischer  ---
Hi Hayley,

wouldn't make ordering by description make more sense? The codes might not
reflect the translation, making the list appear unordered again.

There is also a problem found by the QA tools:

 FAIL   C4/Languages.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   FAIL   pod
*** ERROR: 
Spurious =cut command

 in file C4/Languages.pm

Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

--- Comment #24 from Katrin Fischer  ---
RM, please see comment 18 for some discussion about where to store this script!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #89627|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 89680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89680=edit
Bug 22509: Clarify with an example the usage of --unless-exists

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22835] Serve static files from plugins through the API

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22863] Item replacement cost with tax

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22863

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Attachment #89655|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22863] Item replacement cost with tax

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22863

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89657|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22863] Item replacement cost with tax

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22863

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89656|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89266|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 89679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89679=edit
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with
variable name

One occurrence was missing.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89265|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 89678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89678=edit
Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a
boolean"

This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4.

https://bugs.koha-community.org/show_bug.cgi?id=22836
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >